| *** Barker has quit IRC | 00:19 | |
| *** krow has joined #openstack-trove | 00:22 | |
| *** rnirmal has quit IRC | 00:27 | |
| *** matsuhashi has quit IRC | 00:29 | |
| *** matsuhashi has joined #openstack-trove | 00:30 | |
| *** matsuhashi has quit IRC | 00:34 | |
| *** yidclare has quit IRC | 00:36 | |
| *** adrian_otto has quit IRC | 00:36 | |
| *** coolsvap has quit IRC | 00:38 | |
| *** yogesh has joined #openstack-trove | 00:49 | |
| *** yidclare has joined #openstack-trove | 00:52 | |
| *** krow has quit IRC | 01:01 | |
| *** nosnos has joined #openstack-trove | 01:05 | |
| *** nosnos has quit IRC | 01:05 | |
| *** adrian_otto has joined #openstack-trove | 01:05 | |
| *** nosnos has joined #openstack-trove | 01:06 | |
| *** matsuhashi has joined #openstack-trove | 01:07 | |
| *** krow has joined #openstack-trove | 01:08 | |
| *** amytron has quit IRC | 01:09 | |
| *** Barker has joined #openstack-trove | 01:10 | |
| *** yidclare has quit IRC | 01:14 | |
| *** yogesh has quit IRC | 01:26 | |
| *** yogesh has joined #openstack-trove | 01:27 | |
| *** yogesh has quit IRC | 01:31 | |
| *** krow has quit IRC | 01:37 | |
| *** adrian_otto has quit IRC | 01:37 | |
| *** krow has joined #openstack-trove | 01:58 | |
| *** yidclare has joined #openstack-trove | 02:08 | |
| *** krow has quit IRC | 02:15 | |
| *** krow has joined #openstack-trove | 02:21 | |
| *** adrian_otto has joined #openstack-trove | 02:28 | |
| *** vipul is now known as vipul-away | 02:35 | |
| *** yidclare has quit IRC | 02:42 | |
| *** vipul-away is now known as vipul | 02:43 | |
| *** erkules_ has joined #openstack-trove | 02:48 | |
| *** erkules has quit IRC | 02:48 | |
| *** robertmyers has joined #openstack-trove | 02:52 | |
| *** robertmyers has quit IRC | 03:00 | |
| *** robertmyers has joined #openstack-trove | 03:01 | |
| *** krow has quit IRC | 03:05 | |
| *** adrian_otto has quit IRC | 03:10 | |
| *** krow has joined #openstack-trove | 03:11 | |
| *** matsuhashi has quit IRC | 03:39 | |
| *** matsuhashi has joined #openstack-trove | 03:40 | |
| *** matsuhashi has quit IRC | 03:44 | |
| *** radez_g0n3 is now known as radez | 04:09 | |
| *** vipul has quit IRC | 04:09 | |
| *** vipul has joined #openstack-trove | 04:10 | |
| *** jcru has quit IRC | 04:11 | |
| *** matsuhashi has joined #openstack-trove | 04:17 | |
| redthrux | heyo | 04:33 |
|---|---|---|
| redthrux | quick q - | 04:34 |
| redthrux | how do i kick off a jenkins job for this after a "recheck bug"?: https://review.openstack.org/#/c/55035/ | 04:34 |
| *** robertmyers has quit IRC | 04:38 | |
| *** radez is now known as radez_g0n3 | 04:39 | |
| *** Barker has quit IRC | 04:44 | |
| *** krow has quit IRC | 04:44 | |
| *** adrian_otto has joined #openstack-trove | 04:59 | |
| *** adrian_otto has quit IRC | 04:59 | |
| *** matsuhashi has quit IRC | 05:01 | |
| *** matsuhashi has joined #openstack-trove | 05:02 | |
| *** matsuhashi has quit IRC | 05:02 | |
| *** adrian_otto has joined #openstack-trove | 05:03 | |
| *** adrian_otto has quit IRC | 05:06 | |
| *** matsuhashi has joined #openstack-trove | 05:07 | |
| *** krow has joined #openstack-trove | 05:09 | |
| *** amcrn has quit IRC | 05:10 | |
| *** vipul is now known as vipul-away | 05:20 | |
| *** haomaiwang has quit IRC | 05:33 | |
| *** yogesh has joined #openstack-trove | 05:34 | |
| *** vipul-away is now known as vipul | 05:37 | |
| *** erkules_ has quit IRC | 05:38 | |
| *** erkules_ has joined #openstack-trove | 05:38 | |
| *** yogesh has quit IRC | 05:40 | |
| *** krow has quit IRC | 05:45 | |
| *** SushilKM__ has joined #openstack-trove | 05:45 | |
| *** vipul is now known as vipul-away | 05:52 | |
| *** adrian_otto has joined #openstack-trove | 05:53 | |
| *** yogesh has joined #openstack-trove | 05:53 | |
| *** vipul-away is now known as vipul | 05:56 | |
| *** yogesh_ has joined #openstack-trove | 05:56 | |
| *** yogesh has quit IRC | 05:58 | |
| *** krow has joined #openstack-trove | 06:01 | |
| *** matsuhashi has quit IRC | 06:02 | |
| *** matsuhashi has joined #openstack-trove | 06:02 | |
| *** krow has quit IRC | 06:02 | |
| *** matsuhashi has quit IRC | 06:07 | |
| *** matsuhashi has joined #openstack-trove | 06:07 | |
| *** matsuhashi has quit IRC | 06:11 | |
| *** matsuhashi has joined #openstack-trove | 06:12 | |
| *** yogesh_ has quit IRC | 06:13 | |
| *** coolsvap has joined #openstack-trove | 06:13 | |
| *** matsuhashi has quit IRC | 06:16 | |
| *** matsuhashi has joined #openstack-trove | 06:17 | |
| *** krow has joined #openstack-trove | 06:20 | |
| *** matsuhashi has quit IRC | 06:30 | |
| *** matsuhashi has joined #openstack-trove | 06:30 | |
| *** matsuhashi has quit IRC | 06:30 | |
| *** matsuhashi has joined #openstack-trove | 06:30 | |
| *** yogesh has joined #openstack-trove | 06:38 | |
| *** yogesh has quit IRC | 06:45 | |
| *** yogesh_ has joined #openstack-trove | 06:45 | |
| *** erkules_ is now known as erkules | 06:54 | |
| *** denis_makogon has joined #openstack-trove | 07:02 | |
| *** yogesh_ has quit IRC | 07:08 | |
| *** yogesh has joined #openstack-trove | 07:08 | |
| *** yogesh has quit IRC | 07:13 | |
| *** coolsvap has quit IRC | 07:40 | |
| *** coolsvap has joined #openstack-trove | 07:47 | |
| *** coolsvap has quit IRC | 07:49 | |
| juice | redthrux are you there? | 07:55 |
| juice | I can't tell when this message was originally sent | 07:55 |
| juice | if there is no bug then you do a "recheck no bug" | 07:56 |
| juice | or "reverify no bug" if it has been approved and you just need to run the gate tests again | 07:56 |
| *** Krast has joined #openstack-trove | 07:58 | |
| *** coolsvap has joined #openstack-trove | 08:00 | |
| *** coolsvap has quit IRC | 08:08 | |
| *** coolsvap has joined #openstack-trove | 08:09 | |
| *** adrian_otto has quit IRC | 08:09 | |
| *** krow has quit IRC | 08:16 | |
| *** coolsvap has quit IRC | 08:28 | |
| *** matsuhashi has quit IRC | 08:30 | |
| *** krow has joined #openstack-trove | 08:34 | |
| *** matsuhashi has joined #openstack-trove | 08:35 | |
| *** hub_cap_ has joined #openstack-trove | 08:40 | |
| *** denis_makogon has quit IRC | 08:40 | |
| *** 20WAAKLSA has joined #openstack-trove | 08:44 | |
| *** yogesh has joined #openstack-trove | 08:44 | |
| *** 20WAAKLTG has joined #openstack-trove | 08:44 | |
| *** Krast has quit IRC | 08:45 | |
| *** shivamshukla has quit IRC | 08:45 | |
| *** jesusaurus has quit IRC | 08:45 | |
| *** hub_cap has quit IRC | 08:45 | |
| *** radez_g0n3 has quit IRC | 08:45 | |
| *** nosnos has quit IRC | 08:46 | |
| *** Krast has joined #openstack-trove | 08:46 | |
| *** jesusaurus has joined #openstack-trove | 08:46 | |
| *** radez_g0n3 has joined #openstack-trove | 08:46 | |
| *** coolsvap has joined #openstack-trove | 09:16 | |
| kiall | hub_cap_ in fairness now, that mcdonalds sorted me right out. 1 bite, headache gone ;) | 09:17 |
| *** svapneel has joined #openstack-trove | 09:27 | |
| *** svapneel has quit IRC | 09:27 | |
| *** svapneel has joined #openstack-trove | 09:27 | |
| *** coolsvap has quit IRC | 09:28 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 09:28 |
| openstackgerrit | Michael Still proposed a change to openstack/trove: Convert to a more modern form of openstack-common.conf https://review.openstack.org/56344 | 09:29 |
| *** svapneel has quit IRC | 09:31 | |
| *** coolsvap has joined #openstack-trove | 09:32 | |
| *** yogesh has quit IRC | 09:41 | |
| *** yogesh has joined #openstack-trove | 09:41 | |
| *** yogesh has quit IRC | 09:46 | |
| *** coolsvap has quit IRC | 09:51 | |
| *** coolsvap has joined #openstack-trove | 09:52 | |
| *** ashestakov has joined #openstack-trove | 09:54 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 09:56 |
| *** Krast has quit IRC | 10:13 | |
| *** ppenjoy has joined #openstack-trove | 10:19 | |
| *** matsuhashi has quit IRC | 10:20 | |
| *** matsuhashi has joined #openstack-trove | 10:21 | |
| *** matsuhashi has quit IRC | 10:25 | |
| *** 20WAAKLSA has quit IRC | 10:32 | |
| *** nosnos has joined #openstack-trove | 10:33 | |
| *** nosnos has quit IRC | 10:37 | |
| *** svapneel has joined #openstack-trove | 10:43 | |
| *** svapneel has quit IRC | 10:44 | |
| *** coolsvap has quit IRC | 10:44 | |
| *** krow has quit IRC | 10:57 | |
| *** krow has joined #openstack-trove | 11:08 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 11:36 |
| *** krow has quit IRC | 11:54 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Remove radmin credentials from create_heat_client https://review.openstack.org/56373 | 12:01 |
| *** haomaiwang has joined #openstack-trove | 12:08 | |
| *** SushilKM__ has quit IRC | 12:18 | |
| *** krow has joined #openstack-trove | 12:22 | |
| *** krow has quit IRC | 12:27 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Add support of datastore types https://review.openstack.org/47934 | 12:28 |
| *** ashestakov has quit IRC | 12:33 | |
| *** ppenjoy has left #openstack-trove | 13:02 | |
| *** kevinconway has quit IRC | 13:09 | |
| *** kevinconway has joined #openstack-trove | 13:35 | |
| *** kevinconway has quit IRC | 13:52 | |
| *** kevinconway has joined #openstack-trove | 13:57 | |
| *** SushilKM__ has joined #openstack-trove | 14:10 | |
| *** Barker has joined #openstack-trove | 14:26 | |
| *** kevinconway has quit IRC | 14:29 | |
| *** ppenjoy1 has joined #openstack-trove | 14:34 | |
| *** ppenjoy1 has quit IRC | 14:34 | |
| *** ppenjoy2 has joined #openstack-trove | 14:34 | |
| *** ppenjoy has joined #openstack-trove | 14:35 | |
| *** ppenjoy2 has quit IRC | 14:38 | |
| *** kevinconway has joined #openstack-trove | 14:39 | |
| *** kevinconway has quit IRC | 14:44 | |
| *** SushilKM__ has quit IRC | 14:44 | |
| *** SushilKM__ has joined #openstack-trove | 14:45 | |
| *** pdmars has joined #openstack-trove | 14:52 | |
| *** pdmars has quit IRC | 15:03 | |
| *** pdmars has joined #openstack-trove | 15:04 | |
| *** pdmars has quit IRC | 15:09 | |
| *** pdmars has joined #openstack-trove | 15:09 | |
| *** amytron has joined #openstack-trove | 15:12 | |
| *** SushilKM__ has quit IRC | 15:15 | |
| *** jcru has joined #openstack-trove | 15:15 | |
| *** robertmyers has joined #openstack-trove | 15:21 | |
| *** edmund has quit IRC | 15:29 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove-integration: Fixing logging setup call https://review.openstack.org/56404 | 15:37 |
| *** kevinconway has joined #openstack-trove | 15:40 | |
| *** robertmyers has quit IRC | 15:42 | |
| *** adrian_otto has joined #openstack-trove | 15:42 | |
| *** adrian_otto has quit IRC | 15:43 | |
| *** robertmyers has joined #openstack-trove | 15:43 | |
| *** ashestakov has joined #openstack-trove | 15:46 | |
| *** jmontemayor has joined #openstack-trove | 15:47 | |
| robertmyers | hmm did the gate start failing again? I'm seeing the same issue we fixed yesterday | 15:50 |
| robertmyers | sed: can't read /etc/nova/nova.conf: Permission denied | 15:51 |
| *** yidclare has joined #openstack-trove | 15:51 | |
| *** SushilKM__ has joined #openstack-trove | 15:54 | |
| *** datsun180b has joined #openstack-trove | 15:55 | |
| *** jmontemayor_ has joined #openstack-trove | 15:56 | |
| *** jmontemayor has quit IRC | 15:57 | |
| *** kevinconway has quit IRC | 16:00 | |
| *** robertmyers has quit IRC | 16:00 | |
| *** tanisdl has joined #openstack-trove | 16:00 | |
| *** pdmars has quit IRC | 16:00 | |
| *** pdmars has joined #openstack-trove | 16:01 | |
| *** amytron has quit IRC | 16:02 | |
| *** datsun180b has quit IRC | 16:03 | |
| *** amytron has joined #openstack-trove | 16:04 | |
| *** datsun180b has joined #openstack-trove | 16:05 | |
| *** datsun180b has quit IRC | 16:05 | |
| *** datsun180b has joined #openstack-trove | 16:06 | |
| *** kevinconway has joined #openstack-trove | 16:06 | |
| *** pdmars has quit IRC | 16:06 | |
| *** rnirmal has joined #openstack-trove | 16:08 | |
| *** pdmars has joined #openstack-trove | 16:08 | |
| *** pdmars has quit IRC | 16:09 | |
| *** plodronio has joined #openstack-trove | 16:10 | |
| *** pdmars has joined #openstack-trove | 16:10 | |
| *** SushilKM__ has quit IRC | 16:11 | |
| *** ashestakov has quit IRC | 16:13 | |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests https://review.openstack.org/45116 | 16:19 |
| datsun180b | CHOO CHOO | 16:22 |
| cweid | datsun180b: will look at in a sec. | 16:22 |
| datsun180b | cweid: let the robots have their turn, it'll save time | 16:23 |
| *** jmontemayor_ has quit IRC | 16:25 | |
| *** adrian_otto has joined #openstack-trove | 16:26 | |
| *** jmontemayor has joined #openstack-trove | 16:28 | |
| *** adrian_otto1 has joined #openstack-trove | 16:31 | |
| *** robertmyers has joined #openstack-trove | 16:31 | |
| *** robertmyers has quit IRC | 16:32 | |
| *** robertmyers has joined #openstack-trove | 16:32 | |
| *** adrian_otto has quit IRC | 16:33 | |
| openstackgerrit | Conrad Weidenkeller proposed a change to openstack/trove: Added Redis Crud Operations blueprint redis-support https://review.openstack.org/53481 | 16:42 |
| *** SushilKM__ has joined #openstack-trove | 16:47 | |
| *** edmund has joined #openstack-trove | 16:52 | |
| *** SushilKM__ has quit IRC | 16:52 | |
| *** amytron has quit IRC | 17:02 | |
| *** amytron has joined #openstack-trove | 17:09 | |
| *** SushilKM__ has joined #openstack-trove | 17:11 | |
| datsun180b | too bad i can't will this reddwarf time to speed up | 17:12 |
| *** plodronio has quit IRC | 17:12 | |
| datsun180b | i can see it passed all the tests, it's just spinning doing who knows what | 17:12 |
| *** plodronio has joined #openstack-trove | 17:12 | |
| *** datsun180b_ has joined #openstack-trove | 17:14 | |
| *** datsun180b has quit IRC | 17:17 | |
| *** datsun180b_ is now known as datsun180b | 17:17 | |
| *** robertmyers has quit IRC | 17:20 | |
| *** ashestakov has joined #openstack-trove | 17:22 | |
| datsun180b | https://review.openstack.org/#/c/45116/ both robots are happy again! | 17:23 |
| *** hub_cap_ is now known as hub_cap | 17:24 | |
| *** kevinconway has quit IRC | 17:24 | |
| *** jcru has quit IRC | 17:24 | |
| *** pdmars has quit IRC | 17:25 | |
| datsun180b | i wonder if i call all four core members in the same line, do their powers combine to form Captain Planet | 17:25 |
| *** jmontemayor has quit IRC | 17:40 | |
| *** amytron has quit IRC | 17:40 | |
| *** yidclare has quit IRC | 17:46 | |
| *** yidclare has joined #openstack-trove | 17:47 | |
| *** yidclare has quit IRC | 17:48 | |
| *** harlowja has joined #openstack-trove | 17:53 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 17:56 |
| *** ppenjoy has quit IRC | 17:57 | |
| *** vipul is now known as vipul-away | 17:57 | |
| *** rnirmal has quit IRC | 17:58 | |
| *** SushilKM__ has quit IRC | 17:59 | |
| hub_cap | datsun180b: we have no heart | 18:01 |
| * hub_cap has dibs on wheeler | 18:01 | |
| *** coolsvap has joined #openstack-trove | 18:21 | |
| *** yogesh has joined #openstack-trove | 18:21 | |
| *** yidclare has joined #openstack-trove | 18:24 | |
| *** amytron has joined #openstack-trove | 18:44 | |
| *** coolsvap has quit IRC | 18:44 | |
| *** vipul-away is now known as vipul | 18:46 | |
| dmakogon | cweid, please take a look at my comments on redis review | 18:49 |
| *** jmontemayor has joined #openstack-trove | 18:53 | |
| *** jcru has joined #openstack-trove | 18:53 | |
| *** pdmars has joined #openstack-trove | 18:54 | |
| *** robertmyers has joined #openstack-trove | 18:54 | |
| *** pdmars has quit IRC | 18:54 | |
| *** kevinconway has joined #openstack-trove | 18:54 | |
| *** pdmars has joined #openstack-trove | 18:54 | |
| *** robertmyers has quit IRC | 18:55 | |
| *** robertmyers has joined #openstack-trove | 18:56 | |
| *** jcru has quit IRC | 19:04 | |
| *** jcru has joined #openstack-trove | 19:05 | |
| *** rnirmal has joined #openstack-trove | 19:09 | |
| *** adrian_otto1 is now known as adrian_otto | 19:15 | |
| *** ashestakov has quit IRC | 19:21 | |
| *** coolsvap has joined #openstack-trove | 19:30 | |
| juice | does anyone object to putting type docstrings in for function comments? and as a carrot the usual expected documentation. | 19:33 |
| juice | the reason I ask is that pycharm and perhaps other IDEs use that information to do type inference...making debugging, code navigation, and completion and lot less frustrating | 19:34 |
| hub_cap | im good w/ it | 19:35 |
| hub_cap | we said a while ago we would complain if docstrs werent in code.... we never enforced it :( | 19:36 |
| juice | here's an example ... with just the type docstrings https://gist.github.com/juicegit/7472955 | 19:36 |
| juice | I don't suggest using the one for the local variable (line 13) but it is possible | 19:37 |
| datsun180b | types | 19:38 |
| *** krow has joined #openstack-trove | 19:38 | |
| *** coolsvap has quit IRC | 19:42 | |
| hub_cap | ok line 13 is really goofy | 19:43 |
| hub_cap | id say yes on the method docstr+types if u want, but also add something describing the method ;) | 19:44 |
| cweid | dmakogon: looked at them pushing up changes. | 19:44 |
| cweid | dmakogon: also please look at my responses on the comments as I did not make changes to everything you suggested. | 19:45 |
| datsun180b | yeah shouldn't the type on line 12 be clear from find_by's own docstrings | 19:45 |
| hub_cap | ++ | 19:46 |
| juice | correct datsun180b...at least in most cases except this is a factory method :) | 19:47 |
| juice | so the type is variable on the cls param | 19:47 |
| datsun180b | shouldn't your wizard ide pick up on that | 19:48 |
| juice | Like I said, I wouldn't implement/commit/recommend doing the local variable and yes, hub_cap, if this were to be done, the more common comments should be there as well. | 19:48 |
| datsun180b | well i don't think anyone's going to complain about you adding documentation and making development easier | 19:49 |
| openstackgerrit | Conrad Weidenkeller proposed a change to openstack/trove: Added Redis Crud Operations blueprint redis-support https://review.openstack.org/53481 | 19:52 |
| hub_cap | datsun180b: ++, and +++ to wizard ide | 19:52 |
| *** ashestakov has joined #openstack-trove | 19:54 | |
| *** vipul is now known as vipul-away | 19:57 | |
| *** demorris has joined #openstack-trove | 19:59 | |
| *** SnowDust has joined #openstack-trove | 19:59 | |
| vipul-away | hub_cap, datsun180b, grapex: quesiton for you regarding the Grants api.. should it allow grant to the 'mysql' schema | 20:03 |
| hub_cap | id say no personally, but im not sure how the masses feel | 20:05 |
| datsun180b | wuh huh | 20:06 |
| datsun180b | oh well they're going to find the wiring if they pry the faceplate off anyway | 20:06 |
| datsun180b | and that's one more onesie thing for our mysql impl to have to remember that others probably won't care about | 20:07 |
| datsun180b | cweid: your latest jenkins -1 is bogus (usage timestamp off by 1s), recheck no bug that noise | 20:08 |
| vipul-away | hub_cap datsun180b: i'll file a bug, we don't have anything preventing this now | 20:09 |
| cweid | Yeah I see it on my local tests all the time | 20:09 |
| cweid | datsun180b: I just do a git review again? | 20:10 |
| datsun180b | cweid: review yourself with a 0 and the contents verbatim "recheck no bug" | 20:10 |
| cweid | datsun180b: ty | 20:10 |
| hub_cap | sans the quotes | 20:11 |
| datsun180b | hub_cap: come on, we know what quotes mean | 20:11 |
| cweid | hub_cap: its a string sir. | 20:11 |
| cweid | am I doin it rite? ""recheck no bug"" | 20:11 |
| datsun180b | cweid: escape the " as " | 20:12 |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalization of heat template https://review.openstack.org/53499 | 20:12 |
| datsun180b | and the spaces as &nspb; and then urlencode the whole thing three times | 20:12 |
| datsun180b | is it a bug that we let mysql users shoot them in that particular foot vipul-away ? | 20:13 |
| datsun180b | not like they couldn't already do it themselves manually, right? | 20:13 |
| *** denis_makogon has joined #openstack-trove | 20:15 | |
| SnowDust | hubcap: denis_makogon: robertmyers: https://review.openstack.org/53499 | 20:17 |
| SnowDust | lets get this in today .... | 20:17 |
| *** vipul-away is now known as vipul | 20:18 | |
| vipul | datsun180b: not sure how they could do that if we excluded certain schemas | 20:19 |
| vipul | datsun180b: and if the root user doesn't have grant option | 20:19 |
| datsun180b | vipul: how about with a direct connection to the database? | 20:19 |
| vipul | datsun180b: they are limited to only the schema they have been granted to | 20:20 |
| datsun180b | i dunno, if i was a dba and using trove and i had a reason to grant that particular permission i'd be surprised to find out it was disallowed explicitly | 20:21 |
| datsun180b | if the ga's root permissions forbid it already then it'll fail anyway, but at least the api would hand the 202 back like every other well-formed request like it | 20:22 |
| *** krow has quit IRC | 20:22 | |
| *** krow has joined #openstack-trove | 20:24 | |
| SnowDust | vipul: https://review.openstack.org/53499 one more time ? | 20:26 |
| vipul | SnowDust: yup let's get it merged | 20:34 |
| vipul | SnowDust: please address robertmyers comment, looks like you messed up the conf | 20:35 |
| denis_makogon | hi 2 all | 20:35 |
| datsun180b | so can i get some core eyeballs on https://review.openstack.org/#/c/45116/ pretty please? the robots have been appeased, of course | 20:36 |
| datsun180b | glad the gates got fixed so quickly, i just had to wake it up and everything went smoothly | 20:36 |
| denis_makogon | datsun180b, code looks clean and nice) | 20:41 |
| SnowDust | vipul: denis answered to robertmyers | 20:41 |
| robertmyers | denis_makogon: SnowDust: the setting in cfg.py is 'template_path' not 'confirguration_path' | 20:42 |
| robertmyers | that is what i'm saying | 20:42 |
| *** krow has quit IRC | 20:42 | |
| robertmyers | I don't care what it is but it should be the same | 20:42 |
| datsun180b | denis_makogon: thanks, some of that is your fault you know c: | 20:42 |
| denis_makogon | datsun180b, lol, ok)) | 20:43 |
| denis_makogon | robertmyers, i know, but if we go deeper we could see that there is not only template entities | 20:44 |
| robertmyers | denis_makogon: i'm not arguing about what to call the setting | 20:45 |
| robertmyers | I'm saying it needs to be the same | 20:45 |
| *** yogesh has quit IRC | 20:45 | |
| denis_makogon | robertmyers, ah, got you | 20:45 |
| denis_makogon | robertmyers, sorry)) | 20:45 |
| robertmyers | :) | 20:46 |
| *** yogesh has joined #openstack-trove | 20:46 | |
| datsun180b | it's documentation, we don't want archaeologists finding our cave drawings and then get stumped by our misleading paintings on rock walls illustrating configuration options that don't mean anything | 20:46 |
| SnowDust | datsun180b: whew ! :D | 20:46 |
| denis_makogon | guys, take a look at cassandra review, please | 20:47 |
| datsun180b | so good to have the gates back | 20:48 |
| denis_makogon | hub_cap, cassandra's review is ready | 20:48 |
| datsun180b | what the sam hill is matchers | 20:49 |
| datsun180b | oh testtools | 20:49 |
| *** yogesh has quit IRC | 20:50 | |
| denis_makogon | datsun180b, could you add to docs how to use conductor and it's api | 20:50 |
| denis_makogon | decede, it would be great if you do o | 20:51 |
| denis_makogon | so | 20:51 |
| datsun180b | c = conductor.api.API(); c.heartbeat(instance_id, payload={'service_status': 'running'}) ? | 20:51 |
| datsun180b | that payload isn't its own arg what with the chimeric nature of our different impls so each can respond accordingly et cetera | 20:52 |
| denis_makogon | datsun180b, maybe it would be better to add docs | 20:52 |
| datsun180b | confirming that that's what you mean | 20:52 |
| *** pdmars has quit IRC | 20:52 | |
| denis_makogon | since docs has description of all components it would be nice to see there trove-conductor description | 20:53 |
| *** pdmars has joined #openstack-trove | 20:53 | |
| *** kevinconway has quit IRC | 20:53 | |
| denis_makogon | robertmyers, are you working on incrimental backups ? | 20:53 |
| robertmyers | denis_makogon: yes | 20:54 |
| datsun180b | <obscene interjection> | 20:54 |
| denis_makogon | robertmyers, could you share design of its ? | 20:54 |
| robertmyers | denis_makogon: I can update the wiki with my plans | 20:54 |
| denis_makogon | robertmyers, sounds good | 20:54 |
| robertmyers | currently waiting for conductor to get in | 20:55 |
| denis_makogon | robertmyers, i've got BP which describes scheduled backups | 20:55 |
| denis_makogon | and what about scheduller ? | 20:55 |
| robertmyers | I have to run right now but i can check it out later | 20:55 |
| denis_makogon | robertmyers, would be nice | 20:56 |
| denis_makogon | robertmyers, i'd like to co-work | 20:56 |
| robertmyers | scheduler will be a tough one :) | 20:56 |
| robertmyers | later | 20:56 |
| *** robertmyers has quit IRC | 20:56 | |
| *** pdmars has quit IRC | 20:58 | |
| denis_makogon | also, i'd like to tell, that current backuping system has potential bug | 20:58 |
| datsun180b | great | 20:58 |
| *** Barker has quit IRC | 20:58 | |
| denis_makogon | we could see while databse workload | 20:58 |
| datsun180b | i don't want to fix backups, i just want it to work as it does now but with conductor | 20:58 |
| denis_makogon | bug relayted to manifest which comes to swift with backup stream | 20:59 |
| datsun180b | i've got to head out for the day | 21:01 |
| *** datsun180b has quit IRC | 21:01 | |
| denis_makogon | maybe because backuping system is mysql specific and there is no problem with it, but with other databases which cannot create stream backup | 21:01 |
| denis_makogon | i've tested on cassandra and mongo - backup size is almost equal to manifest | 21:02 |
| *** jcru has quit IRC | 21:02 | |
| *** krow has joined #openstack-trove | 21:03 | |
| denis_makogon | no matter how big storage is | 21:03 |
| *** demorris has quit IRC | 21:05 | |
| *** vipul is now known as vipul-away | 21:06 | |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalization of heat template https://review.openstack.org/53499 | 21:16 |
| openstackgerrit | nilakhya proposed a change to openstack/trove: Externalization of heat template https://review.openstack.org/53499 | 21:18 |
| *** krow has quit IRC | 21:19 | |
| *** vipul-away is now known as vipul | 21:19 | |
| *** krow has joined #openstack-trove | 21:21 | |
| *** yogesh has joined #openstack-trove | 21:30 | |
| *** vipul is now known as vipul-away | 21:31 | |
| *** vipul-away is now known as vipul | 21:31 | |
| *** vipul is now known as vipul-away | 21:47 | |
| *** SnowDust has quit IRC | 21:48 | |
| *** vipul-away is now known as vipul | 21:51 | |
| *** krow has quit IRC | 21:53 | |
| *** SnowDust has joined #openstack-trove | 22:00 | |
| hub_cap | boo amcrn | 22:02 |
| hub_cap | wher ru | 22:02 |
| denis_makogon | hub_cap, hi) | 22:07 |
| *** Barker has joined #openstack-trove | 22:08 | |
| hub_cap | hello denis_makogon :) | 22:08 |
| hub_cap | denis_makogon: just so u know, i think we will merge ashestakov's code first and u/illia can update your guest code | 22:08 |
| denis_makogon | hub_cap, how long would it take to merge ashestakov reviews ? | 22:09 |
| hub_cap | well i have VERY minor -1 nits for it | 22:09 |
| hub_cap | and hes going to do the -integration code today / tomorrow | 22:09 |
| hub_cap | so id say hopefully friday | 22:09 |
| denis_makogon | hub_cap, Austons -1 ? | 22:09 |
| hub_cap | he was, but ashestakov did all the things auston has asked | 22:10 |
| hub_cap | so he should be +1 i think | 22:10 |
| hub_cap | i had one question for him but its not a -2 on ashestakov's review in my mind | 22:10 |
| hub_cap | so we cna let it slip.. we need this code in the codebase for a lot of things to fall into place | 22:11 |
| denis_makogon | hub_cap, take a look at https://review.openstack.org/#/c/47934/9..10/trove/guestagent/common/operating_system.py | 22:12 |
| denis_makogon | hub_cap, i need your thoughts about it | 22:12 |
| *** Barker has quit IRC | 22:12 | |
| hub_cap | im personally not a fan of making something "smaller" if its less readable | 22:16 |
| hub_cap | or "faster" | 22:16 |
| hub_cap | if its a real bottleneck, like building 10 million entries, sure | 22:16 |
| hub_cap | but if its building ~6 entries, the "fastness" and "smallness" will outweigh readability there | 22:17 |
| hub_cap | also, im not sure that .update is necessary... if its a python3 thing, or a hacking thing ten sure, but i typically do the same foo['bar'] = 'baz' and dont think 2x about it | 22:17 |
| hub_cap | ill let the python gods weigh in on it though (robert and datsun), both of which are in a meeting right now | 22:17 |
| denis_makogon | hub_cap, k, what about heat templates review ? | 22:19 |
| hub_cap | its next on my list | 22:19 |
| hub_cap | i want to finish this one, ive got 1 or 2 files left | 22:19 |
| denis_makogon | k | 22:20 |
| denis_makogon | hub_cap, i've looked through ashestakov code, and i thinks he should rebase his patch, because it would not get merged easily | 22:26 |
| denis_makogon | hub_cap, ashestakov added all new patches manualy, | 22:27 |
| *** Barker has joined #openstack-trove | 22:28 | |
| hub_cap | well if it doesnt merge its his responsibility to fix it :) | 22:29 |
| hub_cap | denis_makogon: once he finishes the -integration code, ill be pulling it down and testing it myself | 22:31 |
| hub_cap | to make sure the tests all pass still | 22:32 |
| denis_makogon | hub_cap, i hope | 22:32 |
| denis_makogon | so, good to heat you are going to test it | 22:33 |
| *** Barker has quit IRC | 22:33 | |
| hub_cap | yes | 22:33 |
| denis_makogon | hub_cap, have you read about backuping bug ? | 22:33 |
| hub_cap | we might be able to merge heat template first too | 22:33 |
| hub_cap | i read what u said | 22:33 |
| hub_cap | but i know for a fact that for mysql it works | 22:33 |
| hub_cap | cuz its in production iirc in 2 clouds | 22:33 |
| *** krow has joined #openstack-trove | 22:34 | |
| denis_makogon | because only mysql could backup into stream | 22:34 |
| SnowDust | denis_makogon: hub_cap: vipul: all fixed ... can u look https://review.openstack.org/#/c/53499/ | 22:34 |
| denis_makogon | SnowDust, we'll do | 22:35 |
| SnowDust | all gates passed .. too ! | 22:35 |
| SnowDust | thx ! | 22:35 |
| hub_cap | SnowDust: yes sir | 22:36 |
| hub_cap | denis_makogon: ok that is not good (wrt the stream) | 22:36 |
| denis_makogon | hub_cap, since databases perform backuping into file first (without ability to convert it into stream at first step), we are only able to "cat " backup into stream | 22:38 |
| denis_makogon | hub_cap, https://gist.github.com/crazymac/7335698 | 22:39 |
| *** vipul is now known as vipul-away | 22:39 | |
| *** SnowDust has quit IRC | 22:40 | |
| *** amytron has quit IRC | 22:41 | |
| *** jmontemayor has quit IRC | 22:41 | |
| *** vipul-away is now known as vipul | 22:41 | |
| hub_cap | well as long as the image is big enough to handle it locally thats ok | 22:41 |
| hub_cap | ugh thats a ugly long command lol | 22:41 |
| denis_makogon | hub_cap, that is what accepts backuoping system | 22:42 |
| hub_cap | i know some core cassandra devs denis_makogon, so i can ask them about streaming | 22:42 |
| denis_makogon | hub_cap, would be greate but mechanism of backing didn't changed for now (v2.0.1) | 22:43 |
| hub_cap | k ill ask them if its in the works | 22:43 |
| denis_makogon | hub_cap, http://www.datastax.com/documentation/cassandra/1.2/webhelp/index.html#cassandra/operations/ops_backup_restore_c.html?pagename=docs&version=1.2&file=operations/backup_restore | 22:45 |
| hub_cap | sure | 22:45 |
| hub_cap | fwiw, i know the guys who started datastax, so im asking them | 22:45 |
| hub_cap | ok no plans on making it streaming denis_makogon | 22:49 |
| hub_cap | 2:48 PM driftx it makes hardlinks, cuz sstables are immutable, so that's extremely cheap | 22:49 |
| hub_cap | so we will have to refactor maybe like u said | 22:50 |
| denis_makogon | hub_cap, just as i suspect | 22:50 |
| denis_makogon | hub_cap, i'm going to research a bit, i think i could find applicapable solution inside trove | 22:51 |
| denis_makogon | hub_cap, goodnight, cu tomorrow | 22:52 |
| hub_cap | ok awesome denis_makogon cu | 22:53 |
| hub_cap | nice chatting w u | 22:53 |
| *** denis_makogon has quit IRC | 22:59 | |
| *** cweid has quit IRC | 23:04 | |
| *** plodronio has quit IRC | 23:10 | |
| *** edmund has quit IRC | 23:13 | |
| *** kevinconway has joined #openstack-trove | 23:15 | |
| *** jcru has joined #openstack-trove | 23:20 | |
| *** yogesh has quit IRC | 23:22 | |
| *** yogesh has joined #openstack-trove | 23:23 | |
| *** jcru has quit IRC | 23:24 | |
| *** yogesh has quit IRC | 23:28 | |
| *** matsuhashi has joined #openstack-trove | 23:47 | |
| *** adrian_otto has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!