| *** denis_makogon has quit IRC | 00:01 | |
| hub_cap | cu | 00:02 |
|---|---|---|
| *** yogesh has quit IRC | 00:04 | |
| *** yogesh has joined #openstack-trove | 00:04 | |
| *** grapex has quit IRC | 00:12 | |
| *** yogesh has quit IRC | 00:15 | |
| *** jcru has quit IRC | 00:30 | |
| *** coolsvap_away has quit IRC | 00:33 | |
| *** adrian_otto has quit IRC | 01:17 | |
| *** yidclare has quit IRC | 01:19 | |
| *** rongze has joined #openstack-trove | 01:23 | |
| *** yogesh has joined #openstack-trove | 01:23 | |
| *** rongze has quit IRC | 01:27 | |
| *** yogesh has quit IRC | 01:29 | |
| *** nosnos has joined #openstack-trove | 01:40 | |
| *** nosnos has quit IRC | 01:40 | |
| *** nosnos has joined #openstack-trove | 01:41 | |
| *** esp has left #openstack-trove | 01:45 | |
| *** achampion has joined #openstack-trove | 01:54 | |
| *** rongze has joined #openstack-trove | 02:03 | |
| *** robertmyers has joined #openstack-trove | 02:11 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Simply swift storage load logic https://review.openstack.org/57796 | 02:13 |
| *** erkules_ has joined #openstack-trove | 02:15 | |
| *** erkules has quit IRC | 02:17 | |
| amcrn | cp16net: as promised, reviewed your latest configuration-group patch-set, fyi. | 02:20 |
| *** NehaV has joined #openstack-trove | 02:42 | |
| *** erkules_ has quit IRC | 02:46 | |
| *** erkules_ has joined #openstack-trove | 02:47 | |
| *** NehaV has quit IRC | 02:55 | |
| *** robertmyers has quit IRC | 03:07 | |
| *** robertmyers has joined #openstack-trove | 03:13 | |
| *** robertmyers has quit IRC | 03:21 | |
| cp16net | amcrn: <3 | 03:28 |
| cp16net | i'm still working on rebasing this review | 03:28 |
| *** demorris has joined #openstack-trove | 03:30 | |
| *** amcrn has quit IRC | 03:47 | |
| *** NehaV has joined #openstack-trove | 04:03 | |
| *** haomaiwa_ has joined #openstack-trove | 04:04 | |
| *** haomaiwang has quit IRC | 04:04 | |
| *** yogesh has joined #openstack-trove | 04:16 | |
| *** haomaiwa_ has quit IRC | 04:18 | |
| *** haomaiwang has joined #openstack-trove | 04:19 | |
| *** yogesh has quit IRC | 04:20 | |
| *** haomaiwang has quit IRC | 04:24 | |
| *** haomaiwang has joined #openstack-trove | 04:26 | |
| *** haomaiwang has quit IRC | 04:26 | |
| *** haomaiwang has joined #openstack-trove | 04:28 | |
| *** haomaiwa_ has joined #openstack-trove | 04:29 | |
| *** haomaiwang has quit IRC | 04:29 | |
| *** haomaiwang has joined #openstack-trove | 04:30 | |
| *** haomaiwa_ has quit IRC | 04:34 | |
| *** rongze has quit IRC | 04:53 | |
| *** jasonb365 has joined #openstack-trove | 05:03 | |
| *** matsuhashi has joined #openstack-trove | 05:06 | |
| *** adrian_otto has joined #openstack-trove | 05:09 | |
| *** matsuhashi has quit IRC | 05:16 | |
| *** NehaV has quit IRC | 05:22 | |
| *** matsuhashi has joined #openstack-trove | 05:23 | |
| *** rongze has joined #openstack-trove | 05:24 | |
| *** rongze has quit IRC | 05:33 | |
| *** yogesh has joined #openstack-trove | 05:40 | |
| *** yogesh has quit IRC | 05:44 | |
| *** yogesh has joined #openstack-trove | 05:45 | |
| *** yogesh has quit IRC | 05:49 | |
| *** demorris has quit IRC | 05:58 | |
| *** yogesh has joined #openstack-trove | 06:02 | |
| *** coolsvap has joined #openstack-trove | 06:05 | |
| *** jasonb365 has quit IRC | 06:08 | |
| *** yogesh has quit IRC | 06:11 | |
| *** yogesh has joined #openstack-trove | 06:12 | |
| *** yogesh has quit IRC | 06:16 | |
| *** SushilKM__ has joined #openstack-trove | 06:20 | |
| *** rongze has joined #openstack-trove | 06:37 | |
| *** yogesh has joined #openstack-trove | 06:42 | |
| *** matsuhashi has quit IRC | 06:44 | |
| *** ashestakov has joined #openstack-trove | 06:44 | |
| *** matsuhas_ has joined #openstack-trove | 06:49 | |
| *** matsuhas_ has quit IRC | 06:56 | |
| *** ashestakov has quit IRC | 06:59 | |
| *** matsuhashi has joined #openstack-trove | 07:03 | |
| *** yogesh has quit IRC | 07:21 | |
| *** yogesh has joined #openstack-trove | 07:21 | |
| *** yogesh has quit IRC | 07:25 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 07:45 |
| *** SushilKM__ has quit IRC | 07:47 | |
| *** adrian_otto has quit IRC | 07:59 | |
| *** flaper87|afk is now known as flaper87 | 08:22 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 08:24 |
| *** nosnos_ has joined #openstack-trove | 08:31 | |
| *** nosnos has quit IRC | 08:35 | |
| *** denis_makogon has joined #openstack-trove | 08:36 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 08:50 |
| *** ikhudoshyn_ has joined #openstack-trove | 08:53 | |
| *** nosnos_ has quit IRC | 09:04 | |
| *** nosnos has joined #openstack-trove | 09:05 | |
| *** matsuhashi has quit IRC | 09:29 | |
| *** matsuhashi has joined #openstack-trove | 09:30 | |
| *** denis_makogon has quit IRC | 09:59 | |
| *** erkules_ is now known as erkules | 10:38 | |
| *** simonmcc has quit IRC | 10:40 | |
| *** simonmcc has joined #openstack-trove | 10:41 | |
| *** simonmcc has quit IRC | 10:41 | |
| *** simonmcc has joined #openstack-trove | 10:42 | |
| *** matsuhashi has quit IRC | 12:09 | |
| *** matsuhashi has joined #openstack-trove | 12:10 | |
| *** matsuhashi has quit IRC | 12:15 | |
| *** coolsvap has quit IRC | 12:56 | |
| *** pdmars has joined #openstack-trove | 13:01 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 13:20 |
| *** SushilKM__ has joined #openstack-trove | 13:22 | |
| *** SushilKM__ has quit IRC | 13:26 | |
| *** SushilKM__ has joined #openstack-trove | 13:26 | |
| *** SushilKM__ has quit IRC | 13:31 | |
| openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Adding ConnectionError class https://review.openstack.org/56930 | 13:34 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects heat template for mysql https://review.openstack.org/57920 | 13:34 |
| *** nosnos has quit IRC | 13:38 | |
| *** jcru has joined #openstack-trove | 13:56 | |
| *** demorris has joined #openstack-trove | 14:01 | |
| *** radez_g0n3 is now known as radez | 14:09 | |
| *** rnirmal has joined #openstack-trove | 14:14 | |
| *** radez is now known as radez_g0n3 | 14:21 | |
| *** amytron has quit IRC | 14:26 | |
| *** SushilKM__ has joined #openstack-trove | 14:29 | |
| *** robertmyers has joined #openstack-trove | 14:35 | |
| *** kevinconway has joined #openstack-trove | 14:36 | |
| *** demorris_ has joined #openstack-trove | 14:39 | |
| *** demorris has quit IRC | 14:42 | |
| *** demorris_ has quit IRC | 14:43 | |
| *** shakayumi has joined #openstack-trove | 14:44 | |
| pdmars | imsplitbit: jcru: https://review.openstack.org/#/c/57935/ | 14:45 |
| *** demorris has joined #openstack-trove | 14:46 | |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove-integration: Add support for kick-starting postgresql https://review.openstack.org/57608 | 14:51 |
| *** amytron has joined #openstack-trove | 14:52 | |
| *** coolsvap has joined #openstack-trove | 14:58 | |
| *** russellb is now known as rustlebee | 14:59 | |
| *** NehaV has joined #openstack-trove | 15:18 | |
| *** shakayumi has quit IRC | 15:22 | |
| *** shakayumi has joined #openstack-trove | 15:23 | |
| *** adrian_otto has joined #openstack-trove | 15:23 | |
| *** NehaV has quit IRC | 15:25 | |
| *** Barker has joined #openstack-trove | 15:26 | |
| *** NehaV has joined #openstack-trove | 15:28 | |
| *** grapex has joined #openstack-trove | 15:32 | |
| *** grapex has quit IRC | 15:37 | |
| *** grapex has joined #openstack-trove | 15:37 | |
| *** datsun180b has joined #openstack-trove | 15:38 | |
| *** rongze has quit IRC | 15:45 | |
| *** shakayumi has quit IRC | 15:48 | |
| *** ikhudoshyn has quit IRC | 15:51 | |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests https://review.openstack.org/45116 | 15:55 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates cmd_set_datastore to replace mysql with SERVICE_TYPE https://review.openstack.org/57962 | 15:58 |
| *** adrian_otto has quit IRC | 16:03 | |
| *** rongze has joined #openstack-trove | 16:04 | |
| *** jasonb365 has joined #openstack-trove | 16:18 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates cmd_set_datastore to replace mysql with SERVICE_TYPE https://review.openstack.org/57962 | 16:29 |
| *** datsun180b_ has joined #openstack-trove | 16:30 | |
| *** rongze_ has joined #openstack-trove | 16:32 | |
| *** rongze has quit IRC | 16:32 | |
| *** datsun180b_ has quit IRC | 16:33 | |
| *** datsun180b_ has joined #openstack-trove | 16:33 | |
| *** datsun180b has quit IRC | 16:34 | |
| *** datsun180b_ is now known as datsun180b | 16:34 | |
| *** pdmars_ has joined #openstack-trove | 16:35 | |
| *** pdmars has quit IRC | 16:37 | |
| datsun180b | https://review.openstack.org/#/c/45116/ back in business | 16:57 |
| ikhudoshyn_ | https://review.openstack.org/#/c/50597/ is green like a buck again, pls review | 17:05 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates cmd_set_datastore to replace mysql with SERVICE_TYPE https://review.openstack.org/57962 | 17:06 |
| datsun180b | it's good to be back | 17:11 |
| *** adrian_otto has joined #openstack-trove | 17:20 | |
| *** adrian_otto has quit IRC | 17:21 | |
| *** adrian_otto has joined #openstack-trove | 17:31 | |
| *** SushilKM__ has quit IRC | 17:32 | |
| *** grapex has quit IRC | 17:50 | |
| *** datsun180b_ has joined #openstack-trove | 17:52 | |
| *** grapex has joined #openstack-trove | 17:52 | |
| *** datsun180b has quit IRC | 17:55 | |
| *** datsun180b_ is now known as datsun180b | 17:55 | |
| *** mrsnivvel has joined #openstack-trove | 17:56 | |
| *** rongze has joined #openstack-trove | 17:57 | |
| *** rongze_ has quit IRC | 18:01 | |
| *** amcrn has joined #openstack-trove | 18:01 | |
| hub_cap | datsun180b: we need to merge your conductor code | 18:12 |
| datsun180b | hub_cap: yes yes we do | 18:12 |
| hub_cap | vipul: SlickNik grapex amcrn dmakogon_ etc plz review it | 18:12 |
| datsun180b | deadline for icehouse is approaching isn't it | 18:12 |
| hub_cap | heh | 18:12 |
| hub_cap | icehouse 1 actually yes | 18:12 |
| hub_cap | but that wont stop us, feature freeze laws dont go into effect until icehouse 3 approaches | 18:12 |
| amcrn | hub_cap: don't mind my quick +1, i spent a lot of time reviewing it pre-rebase | 18:13 |
| hub_cap | amcrn: i did the same w the +2 | 18:13 |
| datsun180b | he certainly did | 18:13 |
| hub_cap | i noticed it was just small things from other peoples commits between the last patch (omg im so glad yall told me about the "Old Version History"), including the fix so datsun180b got +1s from robots :) | 18:15 |
| datsun180b | isn't it lovely | 18:16 |
| hub_cap | fo sure | 18:16 |
| *** jmontemayor has joined #openstack-trove | 18:16 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates cmd_set_datastore to replace mysql with SERVICE_TYPE https://review.openstack.org/57962 | 18:18 |
| *** SushilKM has joined #openstack-trove | 18:19 | |
| SushilKM | Please review https://review.openstack.org/#/c/57920/ | 18:20 |
| hub_cap | SushilKM: hey dude, your commit msg is a bit wrong | 18:20 |
| hub_cap | Fixes: Bug #1254088 <-- that does not produce a link in gerrit | 18:20 |
| SushilKM | k | 18:20 |
| *** yogesh has joined #openstack-trove | 18:20 | |
| hub_cap | try fixes-bug 1254088 | 18:20 |
| hub_cap | fixes-bug: 1254088 | 18:21 |
| robertmyers | or bug #1254088 | 18:21 |
| SushilKM | trying bug #number | 18:21 |
| hub_cap | well that shouldve triggered that regex then | 18:21 |
| hub_cap | id be interested to see how that works | 18:21 |
| amcrn | heresy, it should be Closes-Bug: #1254088 | 18:21 |
| amcrn | https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes :P | 18:21 |
| hub_cap | amcrn: ++ the docs got have spoken | 18:22 |
| robertmyers | nice | 18:22 |
| * hub_cap edits the wiki to say fixes-bug: X | 18:22 | |
| amcrn | lol | 18:22 |
| datsun180b | is that new? | 18:23 |
| datsun180b | i thought "fixes: bug #blargh" was the way to go | 18:23 |
| robertmyers | must be, I was pretty sure it was fixes | 18:23 |
| hub_cap | nope datsun180b its just amcrn was the only person who rtfm'd | 18:23 |
| *** david-lyle is now known as david-lyle_afk | 18:24 | |
| amcrn | i used that wiki when starting w/ openstack 5-6 months ago, so it's not new'ish | 18:24 |
| * hub_cap uses binary search to see how old the closes-bug thing is | 18:24 | |
| datsun180b | https://review.openstack.org/#/c/56966/ doesn't seem to have a problem | 18:24 |
| datsun180b | went right to the bug | 18:24 |
| hub_cap | ya it wont, cuz it looks for bug... | 18:24 |
| datsun180b | oh so you're saying it won't close it | 18:25 |
| hub_cap | i think SushilKM's problem was maybe Bug... | 18:25 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects heat template for mysql https://review.openstack.org/57920 | 18:25 |
| hub_cap | datsun180b: it will close it | 18:25 |
| hub_cap | well it wont close it | 18:25 |
| hub_cap | itll mark it as fixed | 18:25 |
| SushilKM | cool thats good now | 18:25 |
| SushilKM | it shows a link | 18:25 |
| datsun180b | well all's i know is my dot-escaping review comment has a link to the proper bug in LP | 18:26 |
| hub_cap | and ttx's scripts will then marke it as released when it gets put in a milestone | 18:26 |
| hub_cap | datsun180b: sure but SushilKM's entire closes-bug is in a link, so it looks more fancy | 18:26 |
| datsun180b | if you want fancy add a provision to HACKING | 18:26 |
| *** jasonb365 has quit IRC | 18:26 | |
| datsun180b | ERROR H27234: Not fancy enough (COMMIT_MESSAGE, line 6) | 18:27 |
| robertmyers | lol | 18:27 |
| hub_cap | datsun180b: ill give you back your +2 if u amend the commit! | 18:27 |
| *** mmcdaris has joined #openstack-trove | 18:27 | |
| SushilKM | so hub_cap and robertmyers and all good reviewers plz review this one | 18:27 |
| SushilKM | https://review.openstack.org/#/c/57920/ | 18:27 |
| datsun180b | are you ftharghing kidding | 18:27 |
| hub_cap | datsun180b: ya good call. i can do it myself | 18:27 |
| amcrn | SushilKM: are you subtly suggesting that some of us are bad reviewers? bold move cotton. | 18:27 |
| amcrn | ;) | 18:28 |
| SushilKM | i cannot actually @amcrn | 18:29 |
| datsun180b | just for you hub_cap i will amend that bugfix comment | 18:30 |
| SushilKM | i said all the good reviewers .... so all are good to my eyes | 18:30 |
| *** flaper87 is now known as flaper87|afk | 18:30 | |
| hub_cap | datsun180b: horray! | 18:31 |
| SushilKM | even a -1 review teaches something ..... :D | 18:31 |
| hub_cap | amcrn: a bad reviewer is someone who doesnt review enough | 18:31 |
| hub_cap | im a bad reviewer right now | 18:31 |
| SushilKM | definitions being freezed | 18:32 |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Extract suffix from req URL to avoid escaping dots https://review.openstack.org/56966 | 18:32 |
| amcrn | hey, cheer up champ, have a bacon pancake | 18:32 |
| hub_cap | look how beautiful it is datsun180b | 18:32 |
| datsun180b | it's not that great | 18:32 |
| * amcrn starts whistling the song | 18:32 | |
| hub_cap | amcrn: nooooooo i had 2.5 yesterday | 18:32 |
| hub_cap | i went into bacon pancake coma | 18:33 |
| datsun180b | also if you try to diff patch1 from patch2 hub_cap it'll make you cry what with all the rebasing | 18:33 |
| hub_cap | omg datsun180b | 18:33 |
| datsun180b | so it's not a panacea | 18:33 |
| datsun180b | oh gargh that conflict wasn't resolved right, it's going to explode | 18:34 |
| SushilKM | please check this too https://review.openstack.org/#/c/57962/ trove gate now moving ahead of earlier problems :D | 18:35 |
| SushilKM | many thanks ... | 18:35 |
| hub_cap | well i think it can be done well if u separate any "review changes" from rebase commits.. maybe ? but its hard to tell if u update things in a rebase commit... so ya, its def not perfect, but imho it makes sense (if you pulled down the 2 branches from the revisions, the diff would be just that if u rebased) | 18:35 |
| hub_cap | SushilKM: Closes-Bug:... in https://review.openstack.org/#/c/57962/ | 18:36 |
| SushilKM | oops | 18:37 |
| SushilKM | hub_cap i missed that ..... :( | 18:37 |
| hub_cap | no problemo | 18:37 |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Extract suffix from req URL to avoid escaping dots https://review.openstack.org/56966 | 18:37 |
| datsun180b | oh hubris | 18:38 |
| datsun180b | Protip: run tox before you run git-review | 18:38 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates cmd_set_datastore to replace mysql with SERVICE_TYPE https://review.openstack.org/57962 | 18:39 |
| SushilKM | oooooh there comes the link in the check-in now @hub_cap | 18:40 |
| SushilKM | :) | 18:40 |
| *** esp has joined #openstack-trove | 18:41 | |
| esmute | hub_cap, grapex, vipul, SlickNik: Can you guys review https://review.openstack.org/#/c/54412/? I am hoping to get this before the weekend | 18:42 |
| hub_cap | ok im all out of +2's for the day, datsun180b and SushilKM used em all up. thx for playing | 18:42 |
| hub_cap | ohh esmute, u just missed out | 18:42 |
| esmute | nooooooo | 18:42 |
| hub_cap | datsun180b: took that last +2 | 18:42 |
| datsun180b | hub_cap: you can balance it out by issuing -2s | 18:42 |
| esmute | damn.. always late | 18:42 |
| datsun180b | YOU SEEM SO KEEN ON DOING THAT | 18:42 |
| *** rongze has quit IRC | 18:42 | |
| hub_cap | esmute: good news i have a +2 to give since datsun180b has volunteered his review for -2 | 18:42 |
| esmute | datsun180b: That would be a difference of 4? | 18:43 |
| esmute | yay! <3 datsun180b, hub_cap | 18:43 |
| esmute | datsun180b: Ill give you a +1 for consolation | 18:43 |
| datsun180b | hub_cap: would not advise standing in the way of conductor | 18:43 |
| datsun180b | CHOO CHOO | 18:43 |
| SlickNik | esmute: why does rdjenkins not like your changes? | 18:43 |
| kevinconway | SushilKM: just curious. reason why you made a new review instead of commenting on mine? | 18:44 |
| *** demorris has quit IRC | 18:44 | |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Adding designate dns support to trove https://review.openstack.org/54412 | 18:48 |
| *** yidclare has joined #openstack-trove | 18:48 | |
| esmute | SlickNik: Not sure.. It used to last week and i didnt make any change. Let me run it again | 18:49 |
| datsun180b | there were some recent fixes in the last couple days, you just need to rebase again | 18:50 |
| esmute | datsun180b: Done.. Just rebased and uploaded patch 8 | 18:50 |
| robertmyers | hub_cap: is my response to https://review.openstack.org/#/c/56702/ good enough? | 18:51 |
| datsun180b | he said he was out of +2s | 18:52 |
| robertmyers | datsun180b: I just need a *not* -1 | 18:52 |
| robertmyers | I'll settle for a 0 | 18:52 |
| hub_cap | robertmyers: u cant get a 0, cuz your commit msg says Fixes: bug #1251649 | 18:52 |
| robertmyers | hub_cap: damn you!!!!! | 18:53 |
| esmute | hub_cap: What is the correct way to comment it? (serious question) | 18:53 |
| hub_cap | https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes | 18:55 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Simply swift storage load logic https://review.openstack.org/57796 | 18:56 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Moving storage logic out of backup runner class https://review.openstack.org/56702 | 18:57 |
| robertmyers | hub_cap: ^^ | 18:58 |
| SushilKM | yippie gate passed | 18:58 |
| *** david-lyle_afk is now known as david-lyle | 18:59 | |
| *** jasonb365 has joined #openstack-trove | 19:02 | |
| kevinconway | hub_cap: if you're going to approve SushilKM fix can you disapprove mine and close the blueprint it's attached to? | 19:03 |
| SlickNik | robertmyers / hub_cap: FYI we found a couple of corner case issues with backups. | 19:03 |
| SlickNik | https://bugs.launchpad.net/trove/+bug/1253849 | 19:03 |
| SlickNik | https://bugs.launchpad.net/trove/+bug/1253850 | 19:03 |
| kevinconway | hub_cap: here's the one to shut down https://review.openstack.org/#/c/57780/ | 19:04 |
| SlickNik | Hope to get fixes for those to gerrit sometime today. | 19:04 |
| hub_cap | kevinconway: no links on the reviews yet? | 19:06 |
| robertmyers | SlickNik: for the second one I was experimenting with using subprocess pipes better to chain the commands together | 19:07 |
| robertmyers | but using eventlet subprocess does not allow that | 19:07 |
| *** yogesh has quit IRC | 19:07 | |
| *** yogesh has joined #openstack-trove | 19:08 | |
| *** yogesh has quit IRC | 19:09 | |
| *** yogesh has joined #openstack-trove | 19:09 | |
| robertmyers | SlickNik: http://russ.garrett.co.uk/2011/12/16/green-threads-and-pipes-in-python/ | 19:09 |
| kevinconway | hub_cap: it's two lines above yours | 19:10 |
| SushilKM | needed few more eyes on https://review.openstack.org/#/c/57920/ before it could be merged ..... :D | 19:11 |
| robertmyers | SlickNik: if we use regular subprocess then we could pipe the output while maintaining the control of the main process, but that would require not using eventlet for the guest :( | 19:11 |
| kevinconway | robertmyers: are you sure that's still valid? i use the green subprocess without much difficulty | 19:13 |
| *** yogesh has quit IRC | 19:13 | |
| SlickNik | robertmyers: I hear you. it sucks that the eventlet subprocess is different from the regular one in this regard :(. | 19:13 |
| *** yogesh has joined #openstack-trove | 19:13 | |
| SlickNik | robertmyers: For now, I'm testing a fix that sets up a processgroup during the call. Then messaging a KILL to the process group leader should have it transmitted to the other processes in the group as well. | 19:13 |
| SlickNik | That should at least take care of cleaning up the processes in case of a failure. | 19:14 |
| robertmyers | kevinconway: try the code in the example and you'll see the same failure, it is because they monkey patch os | 19:14 |
| robertmyers | kevinconway: they == eventlet | 19:15 |
| *** yogesh has quit IRC | 19:15 | |
| robertmyers | SlickNik: sounds like a plan, look forward to seeing it | 19:15 |
| *** yogesh has joined #openstack-trove | 19:16 | |
| *** coolsvap has quit IRC | 19:17 | |
| *** coolsvap has joined #openstack-trove | 19:18 | |
| *** coolsvap has quit IRC | 19:18 | |
| *** yogesh has quit IRC | 19:21 | |
| *** yogesh has joined #openstack-trove | 19:22 | |
| *** yogesh_ has joined #openstack-trove | 19:24 | |
| *** yogesh has quit IRC | 19:25 | |
| *** yogesh_ has quit IRC | 19:25 | |
| *** yogesh has joined #openstack-trove | 19:26 | |
| *** yogesh has quit IRC | 19:27 | |
| *** yogesh has joined #openstack-trove | 19:28 | |
| *** yogesh has quit IRC | 19:30 | |
| *** yogesh has joined #openstack-trove | 19:30 | |
| *** yogesh has quit IRC | 19:31 | |
| *** yogesh has joined #openstack-trove | 19:31 | |
| SushilKM | how do i re-run trove-gate | 19:31 |
| SushilKM | for my check-in | 19:32 |
| cp16net | hmm i totally going to be yelled at by hub_cap for something i cant change in launchpad now... | 19:33 |
| *** yogesh has quit IRC | 19:33 | |
| hub_cap | !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 19:33 |
| openstack | hub_cap: Error: "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!" is not a valid command. | 19:33 |
| hub_cap | (╯°□°)╯︵ ┻━┻ | 19:34 |
| *** yogesh has joined #openstack-trove | 19:34 | |
| *** mmcdaris has quit IRC | 19:34 | |
| *** mmcdaris_ has joined #openstack-trove | 19:35 | |
| hub_cap | cp16net: what did u do? | 19:36 |
| cp16net | haha | 19:36 |
| cp16net | i couldnt change the milestone on a bug i just created | 19:36 |
| hub_cap | ლ(ಠ益ಠლ) | 19:37 |
| SlickNik | SushilKM: You can do so only if you're a member of reddwarf-drivers. | 19:37 |
| datsun180b | SushilKM: trove-gate? what patchset, i'll do it | 19:37 |
| cp16net | figures... | 19:37 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects heat template for mysql. https://review.openstack.org/57920 | 19:37 |
| hub_cap | cp16net: lnk me pz ill fix | 19:37 |
| datsun180b | oh or you could do that | 19:37 |
| cp16net | https://bugs.launchpad.net/python-troveclient/+bug/1254141 | 19:38 |
| hub_cap | cp16net: YOU SIR ARE IN LUCK | 19:38 |
| hub_cap | troveclient has no milestone | 19:38 |
| *** mmcdaris_ has quit IRC | 19:38 | |
| cp16net | oh | 19:38 |
| cp16net | oh i see that | 19:38 |
| cp16net | so now i can yell at hub_cap!!!! AHHHHHH | 19:39 |
| hub_cap | (｡-_-｡ )人( ｡-_-｡) | 19:39 |
| * cp16net accidentally floods hub_cap's room with Hydrofluoric acid | 19:39 | |
| hub_cap | ok thats mean | 19:39 |
| SlickNik | SushilKM: done | 19:39 |
| cp16net | "accidentally" | 19:39 |
| hub_cap | i just gave u a high 5 emoji | 19:39 |
| cp16net | lol | 19:39 |
| hub_cap | and u spill hypoclorsome acid on me | 19:39 |
| datsun180b | wait you made the openstack bot complain with just a line of ! | 19:40 |
| datsun180b | !bacon | 19:40 |
| openstack | datsun180b: Error: "bacon" is not a valid command. | 19:40 |
| datsun180b | interesting | 19:40 |
| SlickNik | extrovert: image me bacon | 19:40 |
| extrovert | http://yourfitnesschoice.com/wp-content/uploads/2013/10/caramelized-bacon-2.jpg#.png | 19:40 |
| cp16net | !help | 19:40 |
| openstack | cp16net: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin. | 19:40 |
| *** yogesh has quit IRC | 19:41 | |
| datsun180b | this is dangerous power to wield | 19:41 |
| datsun180b | extrovert: image me batman fighting an alligator | 19:41 |
| extrovert | http://www.the-isb.com/images/BatmanCrocChoke.jpg#.png | 19:41 |
| cp16net | lol | 19:41 |
| SlickNik | not bad at all | 19:41 |
| *** yogesh has joined #openstack-trove | 19:41 | |
| datsun180b | dangerous power | 19:41 |
| *** yogesh has quit IRC | 19:42 | |
| *** yogesh has joined #openstack-trove | 19:42 | |
| *** rongze has joined #openstack-trove | 19:43 | |
| *** yogesh has quit IRC | 19:44 | |
| grapex | extrovert: image me a plum in a hat floating in perfume | 19:44 |
| extrovert | http://www.sketchplease.com/wp-content/sketches/Angelo-single_plum_perfume_hat.jpg#.png | 19:44 |
| grapex | Wow | 19:44 |
| datsun180b | extrovert: image me vipul and/or slicknik giving conductor a +2 today https://review.openstack.org/#/c/45116/ | 19:45 |
| *** yogesh has joined #openstack-trove | 19:45 | |
| grapex | extrovert: image me the 45 president of the United States of America | 19:45 |
| extrovert | http://rlv.zcache.com/hillary_clinton_the_45th_president_of_america_tshirt-r3cd91a4b84b34274b3c78ca1677b6886_804gy_512.jpg#.png | 19:45 |
| grapex | There you have it America | 19:46 |
| hub_cap | extrovert: image me bacon pancakes | 19:46 |
| extrovert | http://thegourmandmom.files.wordpress.com/2010/06/051a1.jpg#.png | 19:46 |
| datsun180b | guess i had him stumped for that one | 19:46 |
| vipul | extrovert is still processing that request | 19:46 |
| hub_cap | extrovert: image me makin bacon pancakes | 19:46 |
| extrovert | http://fc04.deviantart.net/fs71/f/2012/355/6/e/makin_bacon_pancakes_by_loveandasandwich-d5orifi.jpg#.png | 19:46 |
| datsun180b | <3 | 19:46 |
| hub_cap | AWWWW YA that one is awesome | 19:46 |
| vipul | this room just went to shit :D | 19:46 |
| SlickNik | lol | 19:47 |
| cp16net | extrovert: image me a +1 | 19:47 |
| extrovert | http://www.blogcdn.com/green.autoblog.com/media/2013/03/bmw-3-cylinder-prototype-628.jpg#.png | 19:47 |
| *** yogesh has quit IRC | 19:47 | |
| *** rongze has quit IRC | 19:48 | |
| *** yogesh has joined #openstack-trove | 19:48 | |
| cp16net | extrovert: image me +1 | 19:48 |
| extrovert | http://1.bp.blogspot.com/-SieQC7vmg3A/Tghe4CwRl5I/AAAAAAAAAH8/EToGVE6e9jE/s1600/number-1-sign.jpg#.png | 19:48 |
| hub_cap | extrovert: image me plus one | 19:48 |
| extrovert | http://www.angelfire.com/super/christianmusic/plusone1.jpg#.png | 19:48 |
| hub_cap | HAHAHAHHAHHAHA | 19:48 |
| cp16net | wow | 19:48 |
| cp16net | extrovert: you letting me down | 19:49 |
| hub_cap | i just spit on my screen, and im teared up | 19:49 |
| datsun180b | the promise, indeed | 19:49 |
| hub_cap | that was so freakin funny | 19:49 |
| SushilKM | needed help again for https://review.openstack.org/#/c/57920/ to get merged the heat template got some bug on trove-gate and int-tests failed, i have jst got them restarted ... | 19:49 |
| hub_cap | thats a extrovert troll if i ever saw one | 19:49 |
| datsun180b | SushilKM: i'll take a look, i'm well-weathered by gate problems | 19:50 |
| cp16net | hub_cap: what -2 still? https://review.openstack.org/#/c/51262/ | 19:50 |
| hub_cap | just to piss u off cp16net | 19:50 |
| * cp16net sad | 19:50 | |
| *** yogesh has quit IRC | 19:51 | |
| * hub_cap whacks cp16net around a bit with a damaged shovel | 19:51 | |
| *** yogesh has joined #openstack-trove | 19:52 | |
| hub_cap | check it now | 19:52 |
| datsun180b | SushilKM: so the restore failed. have you run the tests locally? i bet the guestagent log would be helpful there | 19:52 |
| hub_cap | oh and whle youre at it | 19:52 |
| hub_cap | extrovert: image me plus one | 19:52 |
| extrovert | http://www.angelfire.com/super/christianmusic/plusone1.jpg#.png | 19:52 |
| cp16net | thx | 19:52 |
| SushilKM | i ran the tests locally | 19:52 |
| cp16net | SlickNik: https://review.openstack.org/#/c/51262/ | 19:52 |
| hub_cap | im sad more people arent around to share this link | 19:52 |
| hub_cap | extrovert: image me plus two | 19:53 |
| extrovert | http://mimg.sulekha.com/malayalam/plus-two/stills/plus-two-stills026.jpg#.png | 19:53 |
| datsun180b | test_instance_restored FAIL | 19:53 |
| datsun180b | went from BUILD to FAILED immediately looking at the logs | 19:54 |
| datsun180b | but that's just the host end of things | 19:54 |
| hub_cap | grapex: did u enter a cheat code into extrovert to have it give you exactly what it asked for? | 19:54 |
| *** yogesh has quit IRC | 19:56 | |
| SushilKM | keeping fingers crossd for trove-gate on this appearance :) | 19:57 |
| cp16net | hub_cap: konami code? | 20:00 |
| cp16net | extrovert: image me komani code | 20:00 |
| extrovert | http://img.gawkerassets.com/img/17eteo8jrb1okjpg/original.jpg#.png | 20:00 |
| hub_cap | lol. i still win the random off target phrase and grapex still wins most precise phrase. step it up cp16net | 20:02 |
| *** yogesh has joined #openstack-trove | 20:02 | |
| datsun180b | Come on, I got Batman wrestling an alligator | 20:03 |
| hub_cap | datsun180b: that one was good | 20:04 |
| hub_cap | but "a plum in a hat floating in perfume" was pretty awesome | 20:04 |
| *** flaper87|afk is now known as flaper87 | 20:06 | |
| grapex | hub_cap: I kind of expected it to work because that was a joke from the Simpsons. | 20:07 |
| hub_cap | ok grapex loses his title. datsun180b, you win now | 20:08 |
| hub_cap | he was caught cheating | 20:08 |
| datsun180b | well Batman has been known to get into fights at the zoo and in sewers to chase down at least KC and Penguin if not others | 20:09 |
| datsun180b | so it's not that rare that he'd be fighting crocs | 20:09 |
| hub_cap | ok datsun180b has disqualified himself | 20:10 |
| hub_cap | cp16net: youre in the lead for .... i dont know | 20:10 |
| datsun180b | we should probably just cancel this imaginary contest | 20:10 |
| hub_cap | ++ | 20:10 |
| *** yogesh has quit IRC | 20:16 | |
| *** yogesh has joined #openstack-trove | 20:16 | |
| grapex | extrovert: image me the true winner of this imaginary contest | 20:19 |
| extrovert | http://th07.deviantart.net/fs71/300W/f/2012/279/6/0/603b40244659388028d01bd50c236b8d-d5gxqfr.jpg#.png | 20:19 |
| *** demorris has joined #openstack-trove | 20:20 | |
| hub_cap | well grapex that might have won both prizes in one phrase | 20:20 |
| hub_cap | grapex: is the true winner | 20:20 |
| datsun180b | grapex: http://pbs.twimg.com/media/BCE-6gsCAAEIgAa.jpg:large | 20:21 |
| *** Barker has quit IRC | 20:46 | |
| *** Barker has joined #openstack-trove | 20:46 | |
| *** SushilKM has quit IRC | 20:50 | |
| demorris | trove peoples, are there any API level doc's written for the types/versions feature? | 20:57 |
| ikhudoshyn_ | hi guys | 20:57 |
| demorris | i saw the docs around the trove-manage command, but looking for the latest API spec doc | 20:57 |
| ikhudoshyn_ | hub_cap: and all, now when datastores are in may we get back to mongo? | 20:58 |
| amcrn | demorris: i'm fairly positive there is not | 20:58 |
| amcrn | all i know of is https://review.openstack.org/#/c/54921/2/doc/source/dev/datastores.rst | 20:58 |
| demorris | amcrn: thanks, we need to start to make that a requirement imho before we merge stuff | 20:59 |
| hub_cap | ikhudoshyn_: yes we need to look @ mongo and cassandra now | 20:59 |
| amcrn | i would have agreed, but i'd be told i'm inhibiting progress again | 20:59 |
| amcrn | lol | 20:59 |
| hub_cap | :P | 21:00 |
| demorris | hehe, well, gotta have some standards, API docs for a ReST service seems reasonable on the list of gates | 21:00 |
| amcrn | if someone on core can make it a requirement, i know i'd be aligned with your request | 21:00 |
| ikhudoshyn_ | hub_cap: https://review.openstack.org/#/c/50597/ is green and eager | 21:00 |
| hub_cap | ugh am i gonna have to srsly fire up a vm to format a usb stick.. lol | 21:00 |
| demorris | amcrn and demorris look to hub_cap to make it so | 21:02 |
| ikhudoshyn_ | grapex: hi, this was blessed by u before it gets rebased, hope u still dont mind against it https://review.openstack.org/#/c/50597/ | 21:02 |
| hub_cap | ++ demorris | 21:02 |
| *** yogesh has quit IRC | 21:02 | |
| *** yogesh has joined #openstack-trove | 21:03 | |
| demorris | this should help get us there - https://review.openstack.org/#/c/28065/ | 21:04 |
| *** NehaV has quit IRC | 21:05 | |
| demorris | at least for standardized docs, then we just need to ramp everyone up on updating those for new additions | 21:06 |
| demorris | there is a BP here for Icehouse on standardizing docs - https://wiki.openstack.org/wiki/Blueprint-os-api-docs | 21:06 |
| *** yogesh has quit IRC | 21:06 | |
| *** yogesh has joined #openstack-trove | 21:07 | |
| openstackgerrit | A change was merged to openstack/trove: Corrects heat template for mysql. https://review.openstack.org/57920 | 21:07 |
| demorris | API has not been updated for 3 months -> http://git.openstack.org/cgit/openstack/database-api/ | 21:08 |
| demorris | hub_cap: is that the single source of truth for the API? | 21:08 |
| hub_cap | thre is some changes w/ the api and where they live in openstack | 21:11 |
| hub_cap | but for now, yes | 21:11 |
| cp16net | thanks SlickNik | 21:18 |
| cp16net | :) | 21:18 |
| SlickNik | np cp16net | 21:19 |
| *** yogesh has quit IRC | 21:26 | |
| *** yogesh has joined #openstack-trove | 21:26 | |
| *** vipul is now known as vipul-away | 21:29 | |
| *** vipul-away is now known as vipul | 21:29 | |
| *** vipul is now known as vipul-away | 21:37 | |
| *** vipul-away is now known as vipul | 21:37 | |
| *** Barker has quit IRC | 21:38 | |
| *** Barker has joined #openstack-trove | 21:39 | |
| *** rnirmal has quit IRC | 21:41 | |
| *** Barker has quit IRC | 21:55 | |
| *** Barker has joined #openstack-trove | 21:56 | |
| *** kevinconway has quit IRC | 22:00 | |
| *** demorris has quit IRC | 22:00 | |
| *** denis_makogon has joined #openstack-trove | 22:01 | |
| *** NehaV has joined #openstack-trove | 22:01 | |
| grapex | SlickNik vipul: Can you guys look at the Conductor stuff? https://review.openstack.org/#/c/45116/ | 22:02 |
| vipul | grapex: Yes, i will look at it -- apologies for the delay | 22:03 |
| *** NehaV has quit IRC | 22:04 | |
| *** NehaV has joined #openstack-trove | 22:04 | |
| SlickNik | grapex: I'll take a look at it this afternoon as well. | 22:04 |
| grapex | Cool, thanks guys. | 22:04 |
| *** pdmars_ has quit IRC | 22:05 | |
| openstackgerrit | A change was merged to openstack/trove: Adding designate dns support to trove https://review.openstack.org/54412 | 22:09 |
| *** robertmyers has quit IRC | 22:11 | |
| denis_makogon | guys, i've got question, if Trove now support designate, is there any chanse to add integration tests for it ? | 22:17 |
| denis_makogon | and what about unit tests with fake Designate ? | 22:18 |
| openstackgerrit | A change was merged to openstack/trove: Allow query logging https://review.openstack.org/57408 | 22:18 |
| *** NehaV has quit IRC | 22:19 | |
| vipul | denis_makogon: I'm not sure if designate is available in devstack | 22:20 |
| denis_makogon | SlickNik, could you please take a look at https://review.openstack.org/#/c/54900/ | 22:20 |
| vipul | if it is, then it might be work enableing it and making that the default path tested | 22:20 |
| vipul | s/work/worth | 22:20 |
| denis_makogon | vipul, yes, i agree, does current DNS flow works with designate driver ? | 22:21 |
| SlickNik | vipul: designate is not currently in devstack, so it's gonna be a bit tricky until they move there. | 22:22 |
| vipul | yep it should.. the existing tests for DNS should just work | 22:22 |
| SlickNik | but yes, once designate is part of devstack, we should be able to add integration tests to test the DNS scenarios as well. | 22:23 |
| denis_makogon | yeah | 22:23 |
| denis_makogon | but i'm still wondering if designate drive author could add unit tests not only for driver ? | 22:24 |
| vipul | https://review.openstack.org/#/c/54412/8/trove/tests/unittests/dns/test_designate_driver.py | 22:25 |
| vipul | denis_makogon: ^ | 22:25 |
| denis_makogon | vipul, there's tests only for driver | 22:25 |
| vipul | denis_makogon: that's fair.. I'll ask him to add some tests for the Manager as well | 22:27 |
| *** Barker has quit IRC | 22:27 | |
| *** kevinconway has joined #openstack-trove | 22:27 | |
| vipul | esmute: ^ | 22:27 |
| denis_makogon | vipul, esmute: what about exception handling in driver ? | 22:27 |
| *** grapex has quit IRC | 22:27 | |
| *** grapex has joined #openstack-trove | 22:28 | |
| vipul | denis_makogon: I think that was discussed in the review.. there is no point in handling hte exception in the driver since the caller needs to know about it | 22:28 |
| esmute | The way i normal approach unit tests is to remove any external components of the thing im trying to test | 22:29 |
| esmute | so the test that i submitted does not include managers or DNS client | 22:29 |
| denis_makogon | esmute, yes, but it seems fair to add manager tests | 22:30 |
| esmute | denis_makogon: The designate client raises general errors 400, 401, 404 etc | 22:31 |
| esmute | http://designate.readthedocs.org/en/latest/rest/servers.html#create-server | 22:31 |
| esmute | So the layers that is using the driver should be the one handling these exceptions. In our case, it would be the taskmanager/manager | 22:31 |
| denis_makogon | vipul, my point is that Designate like Nova, Cinder - all client calls are covered with try:except, so i don't see a reason not to do same with python-designateclient | 22:32 |
| esmute | denis_makogon: Yes i agree. But the patch i submitted was solely around the designate driver feature. We can task to add unit tests to the DNS manager... There are so many places in our code that need tests | 22:33 |
| *** grapex has quit IRC | 22:33 | |
| denis_makogon | esmute, yes, i read documenation, but since trove support multiple drivers it would be better to raise common exception, instead of HTTP 401, 404 | 22:33 |
| vipul | hmm too bad this job seems broken https://jenkins.openstack.org/job/trove-coverage/ | 22:34 |
| denis_makogon | esmute, it means, that driver should handle http error and raise common exception | 22:35 |
| esmute | denis_makogon: I dont see Designate client as a core client.. From trove perspective, the DNS client is the one that interacts with the driver.. in our case it would be the manager | 22:36 |
| denis_makogon | esmute, so manager would handle multiple exceptions from any kind of drivers ever implemented in trove ? | 22:37 |
| *** jasonb365 has quit IRC | 22:37 | |
| vipul | denis_makogon: actually it does make sense to only raise a common exception -- i think we're able to get away with it though https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L209 | 22:38 |
| vipul | currently we don't care why it failed.. it's a provisioning error if it fails | 22:39 |
| denis_makogon | yes, that is what i'm saying | 22:39 |
| denis_makogon | vipul, is it ok to raise simple pythonic excetion ? | 22:40 |
| vipul | what's a pythonic exception :) ? | 22:40 |
| vipul | i agree it makes sense to raise a 'typed' exception that's common across drivers | 22:41 |
| esmute | ok.. So making the manager catch the designate error and create a 'trove_error' and raise that. | 22:41 |
| *** NehaV has joined #openstack-trove | 22:42 | |
| denis_makogon | vipul, or should it be class DNSException(TroveException) | 22:43 |
| datsun180b | We might not have to build our own exceptions within _create_dns_entry | 22:43 |
| vipul | sure, i agree with that | 22:43 |
| esmute | denis_makogon: I will create a new trove exception for DNS to catch all the erros | 22:43 |
| datsun180b | i mean i see a few ways that function could fail that we might expect | 22:43 |
| *** amytron has quit IRC | 22:43 | |
| denis_makogon | esmute, vipul: should driver catch exceptions from client ? | 22:43 |
| datsun180b | and should we name those exceptions we'll still have to have the BaseException net to fail the instance if nothing else worked | 22:44 |
| esmute | denis_makogon: I think it should be in the driver.. yes | 22:44 |
| denis_makogon | esmute, thanks for your work, anyway ;) | 22:45 |
| vipul | datsun180b: Yea, you'd need a catch all regardless | 22:45 |
| vipul | but i guess i see the point that you could diagnose / log better if there are known failures | 22:45 |
| datsun180b | so while it would be nice to expose a set of named, recognized problems and deal with them accordingly we'll still have that one at the bottom | 22:45 |
| datsun180b | i'm not going to fight any effort to remove "except Exception" from our codebase | 22:45 |
| datsun180b | so long as that effort can still cover all the bases, that is | 22:46 |
| denis_makogon | datsun180b, but it would lead us to huge amount of new exception classes | 22:46 |
| datsun180b | cost of doing business with a service we don't control | 22:47 |
| datsun180b | now i wonder if we can't get some kind of introspection into the exceptions designate already throws | 22:48 |
| datsun180b | why should we have to list all their exceptions if they already catalogue them at https://github.com/stackforge/designate/blob/master/designate/exceptions.py | 22:49 |
| vipul | I don't think we should create a 1:1 mapping of these exceptions.. just like we shouldn't do that for the rsdns client | 22:50 |
| datsun180b | looking at _create_dns_entry we might do to at least catch the timeout from poll_until at minimum | 22:50 |
| datsun180b | yeah i'm not saying we need to create a mapping, that sounds like work | 22:50 |
| vipul | but there might be things we don't care about.. like i don't know if it failed on InvalidTLD or InvalidRecord | 22:50 |
| vipul | i don't care what the error is.. it's a DNS Error to me | 22:50 |
| datsun180b | lucky for us those exceptions are organized into a hierarchy | 22:50 |
| esmute | denis_makogon: Feel free to submit a patch to be clear | 22:51 |
| datsun180b | they've got Base, Dupe, BadReq, and NotFound that I can see | 22:52 |
| esmute | and for folks to look at | 22:52 |
| datsun180b | ++ | 22:52 |
| denis_makogon | esmute, i thought we should not be competitors | 22:52 |
| esmute | denis_makogon: We are not... We are contributers :-) | 22:53 |
| vipul | the designate patch is merged denis_makogon any new patch will be enhancement | 22:53 |
| denis_makogon | vipul, datsun180b i suppose it would be enough to except any kind of exception which raises for client API call | 22:53 |
| denis_makogon | vipul, esmute i could deal with exception in client->driver->manager | 22:54 |
| vipul | it may be interesting to know what types of exceptions the rsdns driver may throw.. and only catching things in the Manager | 22:55 |
| datsun180b | if you're going to take apart a motorcycle, you're going to get grease on your hands. if we're going to use designate's api, we're going to get its errors when we screw things up, or it does | 22:55 |
| vipul | not if you wear gloves | 22:56 |
| datsun180b | try on one hand and except DNSClient.exception.BaseException on the other | 22:56 |
| denis_makogon | datsun180b, maybe | 22:57 |
| denis_makogon | datsun180b, but the problem is that we would expect only BaseException | 22:57 |
| datsun180b | if something catastrophic like a SolarFlareHasRenderedAllTechnologyInertException happens, I'd like to hope the client passes that to us | 22:57 |
| datsun180b | because that's not really a dns exception | 22:58 |
| denis_makogon | datsun180b, docs says that there is only limited amount of exceptions per client API call | 22:58 |
| datsun180b | anyway i'll probably have an easier time chattering about this over some code instead of wildly speculating and making my narrow trust of the sun apparent | 22:59 |
| denis_makogon | datsun180b, it's like playing air guitar, looks cool, but no real effect | 23:00 |
| amcrn | ever since playing mario 3, i haven't trusted the sun (http://bbsimg.ngfiles.com/15/24301000/ngbbs508f48cab1fe6.jpg) either | 23:01 |
| datsun180b | i have a whole shelf of air guitar trophies | 23:01 |
| *** jcru has quit IRC | 23:01 | |
| denis_makogon | datsun180b, no way))) | 23:01 |
| datsun180b | denis_makogon: you can't see them | 23:01 |
| denis_makogon | datsun180b, is it true ?))) | 23:01 |
| datsun180b | i have two more on my desk | 23:02 |
| denis_makogon | datsun180b, you so damn high with air guitars ?)) lol | 23:02 |
| datsun180b | amcrn: that sun lives in texas you know | 23:03 |
| amcrn | interesting. i hear you can also find shrooms that give you a power up | 23:05 |
| *** yogesh has quit IRC | 23:05 | |
| *** cweid has quit IRC | 23:05 | |
| *** yogesh has joined #openstack-trove | 23:05 | |
| datsun180b | yeah, the powerup is called jail | 23:06 |
| datsun180b | you guys have fun without me | 23:09 |
| *** datsun180b has quit IRC | 23:09 | |
| *** yogesh has quit IRC | 23:09 | |
| hub_cap | amcrn: u been to any parks north of marin county? | 23:13 |
| hub_cap | im trying to find a nice destination for my fam this wknd (day trip from bay area) | 23:14 |
| *** denis_makogon has quit IRC | 23:20 | |
| *** amcrn has quit IRC | 23:21 | |
| kevinconway | hub_cap: so how do you want to handle competing reviews? | 23:23 |
| kevinconway | i've got https://review.openstack.org/#/c/57780/ and Sush has https://review.openstack.org/#/c/57962/ | 23:23 |
| *** jmontemayor has quit IRC | 23:24 | |
| hub_cap | well yours has been around longer | 23:25 |
| hub_cap | id say mention to him that hes duped your code | 23:26 |
| hub_cap | maybe in the review | 23:27 |
| hub_cap | and then ill -2 his | 23:27 |
| hub_cap | after u mention it | 23:27 |
| SlickNik | I was just about to −2 it. | 23:28 |
| hub_cap | or SlickNik can too | 23:28 |
| SlickNik | I think he honestly didn't realize that there was another changeset around for the same issue. | 23:29 |
| hub_cap | for sure | 23:29 |
| hub_cap | i thikn he did it on purpose | 23:29 |
| hub_cap | to piss kevinconway off | 23:29 |
| kevinconway | hub_cap: you joke... | 23:29 |
| hub_cap | getting back at you for _users_ | 23:30 |
| SlickNik | lol, payback for those 6 am meetings? | 23:30 |
| hub_cap | hell i barely make 9am meetings :) | 23:30 |
| kevinconway | i'm going to get an early meeting one of these days | 23:32 |
| kevinconway | and be the only one that shows up | 23:32 |
| hub_cap | lol yup | 23:32 |
| hub_cap | ive seen some 8am meetings scheduled from recruiters | 23:32 |
| hub_cap | no one shows | 23:32 |
| hub_cap | u catn schedule a meeting at 9am... people _start_ getting in at 9am to look at their daily schedule | 23:33 |
| yidclare | lazy bums | 23:33 |
| yidclare | (of which I am one when I can be) | 23:34 |
| yidclare | (which is less often than I would like) | 23:34 |
| hub_cap | lol | 23:35 |
| hub_cap | hey im up at ~7am w my son | 23:35 |
| hub_cap | but i need my time w/ family in the am :) cooking breakfast now requires 2 adults | 23:35 |
| openstackgerrit | A change was merged to openstack/python-troveclient: Allow --json output override printing dict/list https://review.openstack.org/57619 | 23:40 |
| kevinconway | so if i make my review depend on another will gerrit let me know when my dependencies change? | 23:40 |
| hub_cap | kevinconway: u mean when the patch u depend on is "old" | 23:40 |
| hub_cap | like if u depend on someone elses patchset | 23:41 |
| kevinconway | hub_cap: yes | 23:41 |
| hub_cap | the ui will tell you, yes | 23:41 |
| hub_cap | but im not sure what git review will tell u (or try to do for u) | 23:41 |
| *** NehaV has quit IRC | 23:41 | |
| hub_cap | worth an experiment to run git review on a patchset that is dependentent on a "old" rev of a parent patchset | 23:41 |
| hub_cap | kevinconway: if mistakes happen, its pretty easy to fix as long as u have that change-id | 23:42 |
| hub_cap | u can remove dependencies just like u would add them and gerrit wont be the wiser | 23:42 |
| kevinconway | hub_cap: sounds good | 23:42 |
| kevinconway | i saw that robert did some updates to the backup logic | 23:43 |
| kevinconway | figured i should go ahead and use that to impl pgsql backups | 23:43 |
| hub_cap | absolutely | 23:43 |
| *** demorris has joined #openstack-trove | 23:44 | |
| *** flaper87 is now known as flaper87|afk | 23:46 | |
| openstackgerrit | SlickNik proposed a change to openstack/trove: Added --no-lock parameter to innobackupex https://review.openstack.org/58062 | 23:51 |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove: WIP: Add PostgreSQL support https://review.openstack.org/57609 | 23:56 |
| hub_cap | ok im out team trove | 23:59 |
| hub_cap | gotta plan my day trip tomorrow :) | 23:59 |
| vipul | to? | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
