Tuesday, 2013-11-26

*** shalini has quit IRC00:08
*** shalini has joined #openstack-trove00:08
*** achampion has quit IRC00:26
*** matsuhashi has joined #openstack-trove00:32
datsun180bhub_cap: yt?00:35
*** achampion has joined #openstack-trove00:42
*** yogesh has joined #openstack-trove00:44
*** tanisdl has quit IRC00:52
*** adrian_otto has joined #openstack-trove00:54
cp16netdatsun180b: yo01:02
datsun180bsup01:02
*** nosnos has joined #openstack-trove01:09
datsun180boh this is the dumbest solution and i'm mad it works01:10
datsun180bOLD_SAVE = bkup_models.DBBackup.save ... bkup_modes.DBBackup.save = OLD_SAVE01:11
datsun180btesttools.TestCase got some splainin to do01:12
hub_capdatsun180b: ModelNotFoundError: DBBackup Not Found01:12
hub_capthats the real error just so u know01:13
datsun180band where'd you find that01:13
*** achampio1 has joined #openstack-trove01:14
datsun180bso why wouldn't the model be found in the unittests? is that table not being initialized properly?01:14
hub_capdatsun180b: https://gist.github.com/hub-cap/765185901:14
hub_capdatsun180b: that, im unsure about01:14
hub_capeverythign seems a-ok01:14
datsun180bso there's some kind of model switch i can't find just yet01:15
*** achampion has quit IRC01:15
* hub_cap shrugs01:16
datsun180balso how'd you manage to get any kind of useful banana debugging out of tox? it seems to eat all of that01:16
hub_capit _must_ be timing01:16
datsun180bit can't be db locks because a lock would cause a wait, not a failure01:16
hub_capim not using tox01:16
hub_capive dropped down into testr's venv01:17
hub_capi find it much faster / easier01:17
hub_capand its showing me the errors01:17
datsun180byeah i'm going to just start using testr now, this is chicken-fried bullshit01:17
hub_cap++01:17
datsun180bso if i save the save method and restore it as the first action in my test's setUp it appears to be working all right01:18
*** adrian_otto has quit IRC01:18
*** achampion has joined #openstack-trove01:19
datsun180bit's okay right up until the body of setUp, even in the same file anywhere else on the left edge of the file01:19
*** achampio1 has quit IRC01:19
openstackgerritEd Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests  https://review.openstack.org/4511601:20
hub_capok datsun180b im not sure what was going on w/ that error01:21
*** rongze has joined #openstack-trove01:21
datsun180bi'm sort of hoping this doesn't do it01:22
datsun180bbut really i hope it works so we can move on and revisit the problem with clearer heads01:23
hub_caplink me to what u did01:25
datsun180bhttps://review.openstack.org/#/c/45116/33..34/trove/tests/unittests/conductor/test_methods.py01:25
*** rongze has quit IRC01:26
hub_capwhat huh01:27
datsun180byeah i know01:27
datsun180bsee if you were to assert that the save method wasn't None at about line 42 without this in there, you'd get an assertionerror01:27
datsun180bzuul's got a bit on his plate, so now i get to be patient01:28
hub_capdatsun180b: so i have confirmed what you said w/o seeing what you said lol01:30
hub_capsave is None01:30
datsun180bdid that link not work for you?01:30
hub_capit did. but i wanted to be sure that my eyes did not defy me01:31
datsun180bgotcha01:31
datsun180bi'm aware this is a stupid fix01:31
hub_capcuz that sounds quite odd01:31
datsun180bin a perfect world those two lines would basically be a noop01:32
datsun180bseeing as that method shouldn't be nulled at any point01:32
hub_capis it possible that other tests could modify the state of the mock vs real object? as in, a diff unit test mocking baseModel.create ?01:36
hub_capi dont want a rogue test clobbering things01:36
datsun180bahahahaha py26 just passed on jenkins01:36
hub_capnot saying its your test thats at fault :)01:36
datsun180bit is certainly not01:36
datsun180bi couldn't find anything in the tests that modified the save method01:36
datsun180btrust me, i looked01:36
datsun180bthat is, i couldn't see anything that just straight up said "go find the save method and replace it with this None I found"01:37
datsun180byeah the jenkins gates passed01:38
*** rongze has joined #openstack-trove01:39
hub_capfo sure01:40
datsun180ball right, it's go-home oclock01:40
datsun180bi'll read about conductor's stunning success in the morning01:41
datsun180bthanks for your help01:41
*** datsun180b has quit IRC01:42
hub_capnp01:45
hub_capim still lookin01:45
hub_capits intriguing01:45
*** rongze has quit IRC01:46
*** yogesh has quit IRC01:47
*** amcrn has quit IRC01:52
*** rnirmal has quit IRC01:55
*** rongze has joined #openstack-trove02:01
*** nosnos_ has joined #openstack-trove02:02
*** yogesh has joined #openstack-trove02:04
*** nosnos has quit IRC02:05
*** coolsvap has quit IRC02:06
*** yogesh_ has joined #openstack-trove02:09
*** yogesh has quit IRC02:11
*** erkules has quit IRC02:12
*** yogesh_ has quit IRC02:16
*** yogesh has joined #openstack-trove02:16
*** yogesh has quit IRC02:21
*** erkules has joined #openstack-trove02:26
*** amytron has quit IRC02:32
*** matsuhashi has quit IRC03:11
*** coolsvap has joined #openstack-trove03:50
*** matsuhashi has joined #openstack-trove04:19
*** vipul-away is now known as vipul04:29
*** coolsvap has quit IRC04:31
*** nosnos_ has quit IRC04:32
*** nosnos has joined #openstack-trove04:32
*** rongze has quit IRC04:48
*** yogesh has joined #openstack-trove04:59
*** yogesh has quit IRC05:04
*** SushilKM has joined #openstack-trove05:04
*** coolsvap_ has joined #openstack-trove05:05
*** SushilKM has quit IRC05:08
*** zigo_ has quit IRC05:10
*** zigo has joined #openstack-trove05:11
*** rongze has joined #openstack-trove05:19
openstackgerritSushil Kumar proposed a change to openstack/trove: Removes security_groups from _create_server_volume_heat signature  https://review.openstack.org/5820305:21
*** coolsvap_ has quit IRC05:24
*** rongze has quit IRC05:27
*** coolsvap has joined #openstack-trove05:29
*** matsuhashi has quit IRC05:50
*** matsuhashi has joined #openstack-trove05:51
*** matsuhas_ has joined #openstack-trove05:53
*** matsuhashi has quit IRC05:53
*** yogesh has joined #openstack-trove06:03
*** yogesh_ has joined #openstack-trove06:08
*** yogesh has quit IRC06:10
openstackgerritCraig Vyvial proposed a change to openstack/trove: setting fake mode to print startup errors  https://review.openstack.org/5844006:17
*** matsuhas_ has quit IRC06:20
openstackgerritCraig Vyvial proposed a change to openstack/trove-integration: fake mode script needs to be updated after changed were merged in trove  https://review.openstack.org/5844106:20
*** denis_makogon has joined #openstack-trove06:23
*** rongze has joined #openstack-trove06:24
*** yogesh_ has quit IRC06:25
openstackgerritCraig Vyvial proposed a change to openstack/trove-integration: changes to support configuration groups  https://review.openstack.org/5844506:25
*** yogesh has joined #openstack-trove06:26
*** coolsvap has quit IRC06:26
*** rongze has quit IRC06:28
*** matsuhashi has joined #openstack-trove06:29
*** yogesh has quit IRC06:31
*** coolsvap has joined #openstack-trove06:33
*** coolsvap has quit IRC06:36
*** rongze has joined #openstack-trove06:38
*** achampion has quit IRC06:39
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management  https://review.openstack.org/5316906:40
*** yogesh has joined #openstack-trove06:42
*** haomaiwa_ has quit IRC06:52
*** haomaiwang has joined #openstack-trove06:52
*** haomaiwang has quit IRC06:53
*** matsuhashi has quit IRC06:53
*** haomaiwang has joined #openstack-trove06:53
*** yogesh has quit IRC06:54
*** matsuhashi has joined #openstack-trove06:54
*** yogesh has joined #openstack-trove06:54
*** matsuhashi has quit IRC06:58
*** yogesh has quit IRC06:59
*** matsuhashi has joined #openstack-trove06:59
*** achampion has joined #openstack-trove07:04
*** yogesh has joined #openstack-trove07:07
*** matsuhashi has quit IRC07:26
*** matsuhashi has joined #openstack-trove07:27
*** ikhudoshyn has joined #openstack-trove07:29
*** matsuhas_ has joined #openstack-trove07:39
*** matsuhashi has quit IRC07:42
*** yogesh has quit IRC07:58
*** yogesh has joined #openstack-trove07:59
*** ashestakov has joined #openstack-trove08:00
*** ashestakov has quit IRC08:00
*** matsuhas_ has quit IRC08:05
*** matsuhashi has joined #openstack-trove08:05
*** SushilKM has joined #openstack-trove08:08
*** flaper87|afk is now known as flaper8708:10
*** yogesh has quit IRC08:16
*** yogesh_ has joined #openstack-trove08:19
*** yogesh has joined #openstack-trove08:22
*** yogesh_ has quit IRC08:24
*** yogesh_ has joined #openstack-trove08:26
*** yogesh has quit IRC08:29
*** SushilKM has quit IRC08:35
*** denis_makogon has quit IRC08:39
*** yogesh has joined #openstack-trove08:45
*** yogesh_ has quit IRC08:49
*** _coolsvap_ has joined #openstack-trove09:06
*** yogesh has quit IRC09:09
*** yogesh_ has joined #openstack-trove09:14
*** yogesh_ has quit IRC09:17
*** yogesh has joined #openstack-trove09:18
*** yogesh_ has joined #openstack-trove09:22
*** yogesh has quit IRC09:23
*** achampion has quit IRC09:29
*** _coolsvap_ has quit IRC09:37
*** yogeshmehra has joined #openstack-trove09:51
*** matsuhas_ has joined #openstack-trove09:58
*** matsuhas_ has quit IRC09:58
*** matsuhashi has quit IRC10:02
*** yogesh_ has quit IRC10:06
*** achampion has joined #openstack-trove10:07
*** yogesh has joined #openstack-trove10:07
*** yogesh has quit IRC10:11
*** achampion has quit IRC10:12
*** away-gone is now known as denis_makogon10:17
denis_makogon /msg NickServ identify dmakogon10:17
*** rongze has quit IRC10:29
*** yogeshmehra has quit IRC10:30
openstackgerritKevin Conway proposed a change to openstack/trove-integration: Add support for kick-starting new datastores  https://review.openstack.org/5778011:50
*** flaper87 is now known as flaper87|afk12:11
*** nosnos has quit IRC12:11
*** rongze has joined #openstack-trove12:15
*** flaper87|afk is now known as flaper8712:16
*** SushilKM has joined #openstack-trove12:58
*** pdmars has joined #openstack-trove12:59
*** SushilKM has quit IRC13:09
*** rongze has quit IRC13:17
*** SushilKM has joined #openstack-trove13:28
*** rongze has joined #openstack-trove13:29
*** isviridov has left #openstack-trove13:57
*** isviridov has joined #openstack-trove14:00
*** SushilKM has quit IRC14:05
*** SnowDust has joined #openstack-trove14:07
*** achampion has joined #openstack-trove14:15
*** isviridov is now known as help14:15
*** help is now known as isviridov14:15
*** isviridov has left #openstack-trove14:19
openstackgerritIllia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support  https://review.openstack.org/5059714:21
*** SnowDust has quit IRC14:30
*** radez_g0n3 is now known as radez14:36
*** isviridov has joined #openstack-trove14:39
*** NehaV has joined #openstack-trove14:44
*** yogeshmehra has joined #openstack-trove14:49
*** adrian_otto has joined #openstack-trove14:59
*** adrian_otto has quit IRC14:59
*** robertmyers has joined #openstack-trove15:02
*** adrian_otto has joined #openstack-trove15:04
*** Barker has joined #openstack-trove15:16
*** jasonb365 has joined #openstack-trove15:23
*** ashestakov has joined #openstack-trove15:25
*** datsun180b has joined #openstack-trove15:29
*** yogeshmehra has quit IRC15:34
*** rnirmal has joined #openstack-trove15:45
*** achampio1 has joined #openstack-trove15:47
*** achampion has quit IRC15:50
datsun180bhttps://review.openstack.org/#/c/45116/33..34/trove/tests/unittests/conductor/test_methods.py took way too long to figure out15:52
datsun180bin other news conductor is green again and anxiously awaiting approval and merging15:53
*** jmontemayor has joined #openstack-trove15:55
denis_makogondatsun180b, already +1 it))15:59
datsun180bsaw that, thanks15:59
datsun180bit's a stupid bug, the model appears to be corrupted but only when testcase is invoked15:59
*** amytron has joined #openstack-trove16:02
*** achampion has joined #openstack-trove16:04
*** achampio1 has quit IRC16:05
*** jasonb365 has quit IRC16:06
robertmyersdatsun180b: I think it is an issue with mockito16:07
datsun180bi built a dummy test class that has no trove deps except the backup models, and got the same problem16:11
datsun180bhttps://gist.github.com/ed-/094337a9c27738eb9d09 the assert in setUp fails16:11
datsun180bthough that doesn't rule out other tests ahead of that test running16:12
datsun180bwell that's interesting, importing testtools all at once causes the problem, BUT just importing testcase doesn't16:15
datsun180bfalse alarm16:20
*** Barker has quit IRC16:31
*** Barker has joined #openstack-trove16:34
*** achampio1 has joined #openstack-trove16:34
*** achampion has quit IRC16:36
*** grapex has joined #openstack-trove16:37
denis_makogonguys, take a look at this one https://review.openstack.org/#/c/54900/16:40
datsun180baw man i like doing that kind of thing16:42
openstackgerritDenis M. proposed a change to openstack/trove: Provide guest_info per datastore  https://review.openstack.org/5857416:42
denis_makogondatsun180b, thanks)))16:43
datsun180bwell i mean i would have preferred to have made those updates but if you'll do it, then it saves me work!16:43
denis_makogondatsun180b, sorry for stilling your bread16:44
denis_makogondatsun180b, you could do the same with trove16:45
denis_makogondatsun180b, not so long ago i tried to do that, but i've failed, pep8 took all my time =/16:45
*** grapex has quit IRC16:48
datsun180bit's fine, we all have work to do16:48
*** grapex has joined #openstack-trove16:49
datsun180band thanks for your work too16:49
denis_makogondatsun180b, thanks, you also doing great stuff16:50
openstackgerritDenis M. proposed a change to openstack/python-troveclient: Adding ConnectionError class  https://review.openstack.org/5693016:51
openstackgerritDenis M. proposed a change to openstack/python-troveclient: Exception handle on unreachable trove-api  https://review.openstack.org/5693016:52
*** flaper87 is now known as flaper87|afk16:59
*** yidclare has joined #openstack-trove17:00
denis_makogonrobertmyers, ping17:06
robertmyersdenis_makogon: hello17:06
denis_makogonrobertmyers, hi, Robert17:06
denis_makogoni saw your comment on my review17:06
denis_makogonrobertmyers, i'd like to explain if you don't mind17:07
denis_makogonrobertmyers, print was there, but also there is _pretty_print17:07
robertmyersyeah, the print command is now a function in python 317:08
robertmyersso you can call print('blah')17:08
denis_makogonrobertmyers, i'm not so deep with such things, but gate was failing on print statement, because Py3 syntax doesn't support such format17:08
robertmyersinstead of print 'blah'17:08
denis_makogonyes17:08
denis_makogonthat is what i did17:08
robertmyersI think it will work if you use is as a function the same way... I'd have to see, but I'm guessing that is what the failure is17:09
denis_makogonrobertmyers, ok, if it would be ok, could i get a +1 ?17:10
robertmyersyes17:11
*** plodronio has joined #openstack-trove17:11
denis_makogonrobertmyers, thanks17:12
*** SushilKM has joined #openstack-trove17:15
robertmyersdenis_makogon: it looks like it can be either 'Okay: print(msg)' or 'Okay: print (msg)'17:17
robertmyerspersonnally I like the former17:17
robertmyersbut I'll +1 it17:18
SushilKMneeded reviews followed by merge for https://review.openstack.org/#/c/58203/ :)17:18
SushilKMbeing ecstatic17:18
SushilKM:)17:18
hub_capSushilKM: a merge typically follows reviews :)17:19
SushilKMnews to me hub_cap, was thinking otherwise ;)17:19
SushilKMhub_cap, please check that, though its a small change17:20
hub_capSushilKM: -2 :)17:20
SushilKMwhat happen, any complaints, please17:20
*** david-lyle is now known as david-lyle_afk17:22
datsun180boh so hub_cap / grapex / vipul / SlickNik guess what turned green yesterday: https://review.openstack.org/#/c/45116/17:22
datsun180bfinally nailed that unittest problem, at least for now17:22
datsun180bit bears deeper analysis but not at the cost of essential features17:23
*** grapex_ has joined #openstack-trove17:23
*** grapex has quit IRC17:25
*** Barker has quit IRC17:27
openstackgerritCraig Vyvial proposed a change to openstack/trove-integration: clean up the trailing spaces in xsd/dbaas.wadl  https://review.openstack.org/5859117:27
hub_capdatsun180b: plz mark a bug for that issue, and make a comment in the code that says "check lp:XXXXXXX" w/ the bug id17:28
datsun180bhub_cap: is the bug against trove, trove-int, or something else?17:28
datsun180boh you want another patchset don't you17:29
hub_capdatsun180b: i do, they are free :)17:29
*** Barker has joined #openstack-trove17:29
hub_capummm.... i think trove is good to file it17:29
datsun180bfine, i'll get on that17:30
SushilKMhttp://upload.wikimedia.org/wikipedia/commons/5/55/Bug_blank.svg is a need everywhere ;)17:31
datsun180bi don't want to lose sleep over conductor when i'm on vacation :c17:31
datsun180bi want everyone happy about it so it gets merged and we can all move on17:32
datsun180bAnd I want to quit pestering you all about it17:33
ikhudoshynhup_cap: ... the mount_point17:40
hub_capdatsun180b: when do u go on vaca?17:40
datsun180bhub_cap: taking tomorrow off, and of course thursday17:40
datsun180bcloser to crimbo probably a week or more, got floats to burn off17:40
*** achampion has joined #openstack-trove17:41
hub_capgood call.. i think i do too17:41
denis_makogondatsun180b, agreed with your comments on PEP8 review, soring is our everything)17:41
datsun180bdenis_makogon: in vim, use V to grab the lines you want to sort, then type :%!sort and hit enter17:42
denis_makogondatsun180b, i'm almost newbie with vim17:42
*** grapex_ has quit IRC17:42
datsun180bnow it inserts '<'> for you before you hit ! since you used V (visual-line mode) but the result is what you highlighted gets sorted17:42
*** jasonb365 has joined #openstack-trove17:43
datsun180bwith vim i'm not sorceror supreme but i know a handful of neat tricks17:44
*** achampio1 has quit IRC17:44
ikhudoshynhub_cap: hi again, i guess i misspelled ur nick, blame me.. but what about mount_point17:44
*** rongze has quit IRC17:44
hub_capikhudoshyn: ask your questions17:44
hub_capwe can speak about it17:44
ikhudoshynwhat's the whole idea, at first17:45
ikhudoshynor could u point me, if it was discussed17:45
hub_capikhudoshyn: i dont remember it being discussed17:45
hub_capthe last few wks have been quite hazy though17:45
ikhudoshynthen what should i change17:46
hub_capikhudoshyn: link your review17:46
ikhudoshynhttps://review.openstack.org/#/c/57189/ please17:46
ikhudoshynthe main point is to remove mount_point from RPC. Den's idea (Den, fix me if i wrong) to get mount_point from db specific config17:47
ikhudoshynbut for me these two not necessary directly linked17:47
ikhudoshynDen, was that u?17:48
hub_capikhudoshyn: great... i didnt leave any context in what i said17:48
hub_capdenis_makogon: ^ ^17:48
denis_makogonhub_cap, hello_17:49
denis_makogon))17:49
ikhudoshynlet me try,17:49
ikhudoshynthe context was, its nice to get mount_point from, say, my.cnf, for mysql, or from mongo.conf17:50
*** grapex has joined #openstack-trove17:50
denis_makogonhub_cap, my point is to avoid multiple configuration for singe parameter: one comes in trove-taskmanager.conf, another one comes in config.template17:50
ikhudoshynbut it shuold not be taken from RPC call anyway17:50
hub_capah yes17:51
ikhudoshynthis looks like two steps for me17:51
ikhudoshynisn't it?17:51
denis_makogonnope17:51
denis_makogonone17:51
denis_makogonbut 2 steps for one review17:51
openstackgerritEd Cranford proposed a change to openstack/trove: Conductor proxies host db access for guests  https://review.openstack.org/4511617:52
datsun180bspoilers: i added comments17:52
hub_capdatsun180b: http://static3.wikia.nocookie.net/__cb20130921024344/tardis/images/e/e5/River_Looks_Left_LKH.jpg17:53
ikhudoshynwell, that review mostly updates server-side. Using config.template mostly implies guest-agent side..17:53
datsun180bi'm so behind on dr who17:53
hub_capikhudoshyn: denis_makogon brings up this point because you can do that "instead of" this code, rather than do both17:54
*** vipul is now known as vipul-away17:54
hub_capdatsun180b: she just says spoilers a lot cuz she knows the doctors timeline17:54
datsun180boh i know who River Song is17:54
denis_makogonhub_cap, yeah17:54
datsun180bI just left off early in season 7 I think17:54
hub_capdatsun180b: as in, the year of the original doctor who year 7 calendar?17:55
*** SushilKM has quit IRC17:55
kevinconwayhey there. easy with the Who spoilers17:55
hub_capor the newest season of the reboot datsun180b17:56
ikhudoshynhub_cap: got it, thanks17:56
hub_capkevinconway: dont worry, ill only spoil original doctor who17:56
hub_caphis face changes, his dog is stupid and annoying, the reboot will most certainly be better17:56
hub_cap^ ^ kevinconway: spoilers17:57
kevinconwayYOU DON"T LIKE K-9?17:57
hub_caplol17:57
hub_capno17:57
hub_capikhudoshyn: i think we left off not knowing if we should take that mount_point from the trove.conf and inject it in to the conf.template, or just assume itll be in the conf.template17:58
hub_capikhudoshyn: either way, the guest can glean that info from the config file it gets sent, and i think thats a fine and dandy idea17:58
robertmyersfine and dandy indeed17:59
datsun180bi think you can figure out which season 7 i mean if i know who river song is18:00
hub_capwell not exactly datsun180b, u could be reading up on your _own_ spoilers18:01
hub_capand be in classic who18:01
hub_capthiking, omg, why did i start it this way18:01
hub_capour son was the 11th doctor (matt smith) for halloween, now we have a baptism we need to go to for our friends baby in the area, so we are just gonna dress him back up, sans sonic screw, as the doctor for the day hehe18:03
ikhudoshynhub_cap: ic, and we could make the server-side code a lil'bit lighter by removing all the hustle around mount_point as well18:03
ikhudoshyni think i could love it18:04
hub_capmost definitely ikhudoshyn18:04
hub_capikhudoshyn: :)18:04
ikhudoshynok, I'm done with my stuff for today, cu all18:04
hub_capthx ikhudoshyn cu18:05
denis_makogonhub_cap, could we update delete instance method and let it delete instance in any kind state ?18:11
hub_capdenis_makogon: do u have a problem w/ the way it works now? if so give reason for why you want to change it18:11
denis_makogonhub_cap, suppose i want to break provisioning because i mentioned wrong parameter (bigger volume, flavor, name), but until it gets any status (excluding BUILDING) i need to wait18:13
denis_makogonor exception happened even before poll until18:13
denis_makogonin that case instance would stay in build status forever18:14
denis_makogonhub_cap, btw i started to work on infra extension for us18:15
*** yogesh has joined #openstack-trove18:17
hub_capdenis_makogon: if exceptions are happening and its not moving to error, thats a bug18:20
hub_capid rather make sure we get the instance into error state18:20
denis_makogonhub_cap, problems could come not from code18:21
denis_makogonhub_cap, from code-free files, like templates18:21
denis_makogonto be precise - missing templates18:21
hub_capdenis_makogon: will a missing template not throw an exception?18:22
denis_makogonmissing template cause exception in taskmanager, instance stays in BUILD status18:22
denis_makogonhub_cap, yes, that problem doesn't fixed18:22
openstackgerritDenis M. proposed a change to openstack/trove: Provide guest_info per datastore  https://review.openstack.org/5857418:23
hub_capdenis_makogon: well lets fix that bug18:23
hub_caprather than let the bug stay around in the code and masking it by letting users delete "build" instances18:24
denis_makogonsounds good18:24
hub_capalso, letting a user delete somethign in build will, say, delete step 2 in a 4 or 5 step process, and then step 4 could fail on that18:24
hub_capcausing it to go back in to build status18:24
hub_capand itll be even more cluttered system then18:24
denis_makogonmaybe18:24
denis_makogoni mean, yes, it would bring us to more complicated handling system18:25
denis_makogonhub_cap, could you please take a look at this https://review.openstack.org/#/c/56930/18:25
denis_makogonand maybe, this https://review.openstack.org/#/c/54900/18:26
denis_makogonhub_cap, with this change we could make secure access to instance specific ports, that is what we want but oslo didn't gave us more complex parameter that Dict18:29
denis_makogonhttps://review.openstack.org/#/c/58574/18:29
*** vipul-away is now known as vipul18:29
openstackgerritDenis M. proposed a change to openstack/python-troveclient: Exception handle on unreachable trove-api  https://review.openstack.org/5693018:30
hub_capdenis_makogon: yup i remember that18:31
datsun180bwhen did we add a pypy gate to troveclient?18:32
denis_makogonhub_cap, i'm on the way to make it real18:32
datsun180bis that from test-requirements18:32
hub_capdatsun180b: i think during the "rewrite"18:33
datsun180bwell whatever, apparently it's working18:34
hub_capdatsun180b: those come from the -infra/config stuff18:34
datsun180bthat's what i thought18:34
denis_makogonhub_cap, about your comment, i looked through all OS clients nobody need such class18:34
hub_capso what do the other OS clients do denis_makogon?18:35
denis_makogonthey reuse exception which comes from httplib or requests18:35
hub_capk18:35
hub_capcan u link one in the review?18:35
denis_makogonwhich review ?18:36
hub_capin the review that i -2'd, link the code that you viewed in the other OS client18:36
denis_makogonhub_cap, i can try to add this class to oslo18:36
hub_capdenis_makogon: you can, but if there is no reason, just prove there is no reason by linking the other OS client's code18:37
denis_makogonhttps://github.com/openstack/python-novaclient/blob/935e1fe1674c7680dfdcfed53996d66530fd9ed3/novaclient/exceptions.py18:37
denis_makogon#L5418:37
denis_makogonhttps://github.com/openstack/python-cinderclient/blob/0c2839414f999a8b9a0b085419de7a00d18e52ff/cinderclient/exceptions.py#L5618:38
hub_capso they are both using some sort of ConnectionRefused/Error18:38
hub_capid say propose the connectionrefused or whatever u want to call it, to oslo18:38
denis_makogonyeah, i can do that18:39
hub_capawesome18:39
denis_makogonthere's only one client where i cannot find any kind of such exception - heatclient18:39
denis_makogonhttps://github.com/openstack/python-keystoneclient/blob/8c8ed5f74f36aad814ee8f4a23711f0acfe5ac0b/keystoneclient/httpclient.py#L11618:40
SlickNikrobertmyers / vipul: Good comments on https://review.openstack.org/#/c/58062/5. Thanks!18:40
SlickNikI like the idea of making it a dictopt and applicable across all backup types.18:40
SlickNikStay tuned for a new patchset.18:40
*** SnowDust has joined #openstack-trove18:41
denis_makogonSlickNik, what if you extract whole backup command from code into some kind of config or template or something else18:41
denis_makogonpersonally i see no problems with doing it18:42
*** david-lyle_afk is now known as david-lyle18:42
SlickNikdenis_makogon: You can only extract parts of it (and it's probably a good idea). Other parts like the subprocess code, the process supervisor, setting up the pipes, etc need to exist across all backup types. This still needs to be part of the common code.18:44
*** rongze has joined #openstack-trove18:44
denis_makogonSlickNik, maybe, but hardcoding all command is not so good idea, do you agree ?18:46
robertmyersSlickNik: cool18:46
*** yogesh has quit IRC18:47
*** yogesh has joined #openstack-trove18:47
SlickNikdenis_makogon: The strategy class _is_ a template.18:49
SlickNikThere's nothing preventing you from defining and deploying another backup strategy with a different command, and switching out the backup strategy class in the config.18:50
*** yogesh has quit IRC18:52
robertmyersdenis_makogon: I agree with SlickNik, it seems like you could easily place this in a config file but then you quickly run into an edge case which you need to add a function to the restore or backup class18:52
*** rongze has quit IRC18:53
robertmyersdenis_makogon: see _pre_restore and _post_restore18:53
datsun180boh look the robots are still happy with conductor https://review.openstack.org/#/c/45116/18:56
datsun180bif only i could get some core approval too18:56
SlickNikrobertmyers / denis_makogon: However, something that needs some thought (and work) is how to support multiple backup types for multiple datastore types.18:56
robertmyersSlickNik: denis_makogon: https://review.openstack.org/#/c/52905/ why was this adandoned?18:59
denis_makogonSlickNik, i'm working on that19:01
denis_makogonrobertmyers, SlickNik https://review.openstack.org/#/c/58574/19:01
datsun180bSlickNik: <319:06
datsun180bthought you needed more highlights19:06
*** yogesh has joined #openstack-trove19:12
openstackgerritSlickNik proposed a change to openstack/trove: Replace uuidutils.generate_uuid() with str(uuid.uuid4())  https://review.openstack.org/5807119:31
datsun180bi seem to remember at least one point when generating uuid4s violated an api constraint for being too long but now i can't remember where19:41
datsun180bi think i have in a test somewhere a generate_uuid(len=16), i'll have to look19:41
datsun180bhah! it's in conductor's test_methods19:42
datsun180bnot that big a deal, that already uses uuid.uuid4(), hooray19:43
hub_capor u could use oslo uuid_utils.generate_uuid19:43
datsun180bbut i know we have uuid.uuid4(), that's probably not going away19:45
datsun180bwell this case is only used for generating bogus ids for bogus db tests and won't do any harm for now19:45
*** rongze has joined #openstack-trove19:49
SlickNikhub_cap: oslo uuid_utils.generate_uuid is going away.19:51
hub_cap:o19:51
hub_capfor just using uuid.uuid4 ?19:51
SlickNikYes, that's what they recommend.19:52
SlickNikhttps://bugs.launchpad.net/nova/+bug/125349719:52
datsun180bhence "hooray" earlier19:52
hub_capdatsun180b: wins the prize19:53
datsun180bi'll win the prize when zuul is happy19:53
datsun180bthen you ALL get to use conductor, it'll be so much fun oh boy19:54
*** rongze has quit IRC19:54
hub_capdatsun180b: i saw a typo, did u fix it?19:54
datsun180bhuh19:54
hub_capitll only be one more review19:54
datsun180bdon't even joke19:54
SlickNiklol19:54
hub_capHAHAHA19:54
datsun180bis it a semantic mistake19:54
hub_capyo i wants me some enchiladas today19:55
kevinconwayif the generate_uuid is going away then what gets used in all the SQLAlchemy models?19:57
*** NehaV has quit IRC19:57
datsun180bkevinconway: def generate_uuid(): return 919:57
datsun180b# chosen fairly, guaranteed to be random19:57
hub_capHAH19:57
kevinconway#link http://search.dilbert.com/comic/Random%20Number%20Generator19:58
datsun180bexactly19:58
SlickNikkevinconway: replace with trove.common.utils.generate_uuid which is a wrapper to str(uuid.uuid4()) https://review.openstack.org/5807120:00
datsun180boh man, it's like someone's got their finger on the pulse about this kind of thing20:00
*** spredzy has joined #openstack-trove20:03
*** jasonb365 has quit IRC20:06
*** datsun180b is now known as datsun_F40PH20:12
*** radez is now known as radez_g0n320:13
*** vipul is now known as vipul-away20:14
*** vipul-away is now known as vipul20:14
datsun_F40PHneat, freenode supports nick groups20:14
openstackgerritA change was merged to openstack/trove: Conductor proxies host db access for guests  https://review.openstack.org/4511620:15
datsun_F40PHCHOO CHOO20:15
*** SnowDust has quit IRC20:17
*** hub_cap is now known as pub_tap20:25
pub_tapi wanted to name change too20:25
pub_tapdatsun_F40PH: ^ ^20:25
datsun_F40PHyeah i'd say that's accurate20:25
*** jasonb365 has joined #openstack-trove20:27
datsun_F40PHso why didn't hudson go update https://blueprints.launchpad.net/trove/+spec/trove-conductor yet i wonder20:28
*** SnowDust has joined #openstack-trove20:32
*** denis_makogon_ has joined #openstack-trove20:34
*** denis_makogon has quit IRC20:41
*** denis_makogon_ is now known as denis_makogon20:41
*** vipul is now known as vipul-away20:41
*** dmakogon_ has joined #openstack-trove20:41
denis_makogonguys, i'm back ,did i missed something ?20:42
*** yogesh has quit IRC20:43
datsun_F40PHdenis_makogon: you know what got merged20:43
denis_makogondatsun_F40PH, hah, cond ?20:43
denis_makogon)))20:43
*** yogesh has joined #openstack-trove20:43
datsun_F40PHoh yes20:43
denis_makogondatsun_F40PH, we gonna have a party)))20:43
* denis_makogon wants party-hard20:44
datsun_F40PHno, we're going to finish our other work!20:44
denis_makogonwhich one ?20:46
datsun_F40PHwork on our other guest agent20:47
*** yogesh has quit IRC20:48
pub_tapdatsun_F40PH: the bp's do not get updated20:48
datsun_F40PHplumbers_tape: then i'll leave it to our ptl to maintain20:49
*** rongze has joined #openstack-trove20:50
denis_makogonpub_tap, Michael)))20:50
pub_tapdenis_makogon: :)20:51
denis_makogonlooks like i missed huge party20:52
imsplitbitpub_tap...20:52
denis_makogoni've been away for 1h lol20:52
pub_tapwell datsun_F40PH changed his name and i wanted to tag along20:55
*** rongze has quit IRC20:56
*** NehaV has joined #openstack-trove21:01
*** vipul-away is now known as vipul21:05
*** yogesh has joined #openstack-trove21:06
pub_tapkonetzed: u suck!21:14
imsplitbitwhat did he break now?21:15
*** ashestakov has quit IRC21:20
pub_taphe broke life21:28
pub_tapcuz he sucks at it21:28
*** rnirmal has quit IRC21:31
*** rongze has joined #openstack-trove21:52
*** grapex has quit IRC21:53
*** rongze has quit IRC21:59
openstackgerritCraig Vyvial proposed a change to openstack/trove: setting fake mode to print startup errors  https://review.openstack.org/5844021:59
openstackgerritCraig Vyvial proposed a change to openstack/trove-integration: fake mode script needs to be updated after changed were merged in trove  https://review.openstack.org/5844122:01
*** pub_tap is now known as hub_cap22:01
*** pdmars has quit IRC22:05
*** NehaV has quit IRC22:07
*** NehaV has joined #openstack-trove22:07
spredzyHi guys, I am getting started with trove, can someone points me to a doc/wiki, where I could find how to create a datastore please.22:21
spredzyI've came accross https://wiki.openstack.org/wiki/Trove/trove-versions-types but it provided me on how to get a list of them, not how to create them22:21
spredzyand trove help, didn't provide a datastore-create22:22
spredzyso I am uncertain on what's the way to do so22:22
*** vipul is now known as vipul-away22:22
*** vipul-away is now known as vipul22:22
*** Barker has quit IRC22:26
datsun_F40PHNo, we don't appear to have a create call in datastores just yet22:28
spredzyso if I want to create a datastore, I should do it directly with an HTTP call atm?22:29
hub_capvictory. got my stupid trackpad working22:29
hub_capUGH22:29
hub_caphey spredzy. as the operator you would use the trove-manage command22:30
datsun_F40PHthere you go22:30
hub_caphttps://github.com/openstack/trove-integration/commit/002ce73a07aca29fdc0b31257f5b5e0f1f5ec03222:30
hub_capthat command is where 2 dummy ones were created, so it shows usage22:30
*** amcrn has joined #openstack-trove22:32
spredzyhub_cap: thanks for the link, I do see the cmd_set_datastore(), will look into it closely22:33
robertmyershub_cap: trove-manage does not create new records22:33
robertmyersonly updates existing ones22:33
robertmyersIt is a bunch of fail22:33
robertmyerssee line 53722:34
hub_capspredzy: awesome, and welcome22:34
hub_caprobertmyers: huuuuuuuuuuuuuuuuuuh22:34
hub_capyoure joking right robertmyers??22:35
robertmyersnope22:35
robertmyerslook at the code you just linked22:35
kevinconwayrobertmyers: that's what rd-sql is for22:35
robertmyerskevinconway: lol22:35
SlickNiklol @ rd-sql22:36
robertmyershub_cap: https://github.com/openstack/trove/blob/master/bin/trove-manage#L7922:36
robertmyersthe update will fail if it is not found22:36
robertmyersno create method22:36
robertmyersdid we even review this ;)22:37
kevinconwayrobertmyers: except it won't actually fail because it prints instead22:37
robertmyershahaha22:37
hub_caprobertmyers: this is the problem w/ huge patches22:38
cp16netyeah22:39
hub_captotally yet _another_ place we couldve broken this patch up22:39
robertmyersagreed22:39
hub_capim tellin ya, i couldve broke that into like ~10 patches22:39
hub_capIM SO FREAKIN HAPPY22:39
hub_cap^ ^ happy22:39
hub_cap<--- happy22:39
kevinconwayhub_cap: you should revert that commit22:39
robertmyershahaha22:39
hub_capkevinconway: lol22:39
spredzyI'm so freaking lost ;)22:39
hub_capspredzy: easy to do in this oddball channel22:40
robertmyersspredzy: so are we22:40
hub_capim happy for orthoginal reasons fwiw22:40
spredzythanks guys, I do feel better now22:40
kevinconwaydoes it involve food?22:40
hub_capkevinconway: are you saying the only thing that makes me happy is food?22:40
hub_capkevinconway: CUZ IF U ARE, OH BOY ARE U RIGHT22:40
robertmyersnice22:40
hub_capbut srsly, im happy cuz my trackpad now works on my c720 in jessie22:41
* cp16net larrups hub_cap with a concrete christmas tree22:41
hub_capBender: I've personalized each of your meals. Amy, you're cute, so I baked you a pony!22:41
cp16netvery festive22:41
* hub_cap spills some coffee over cp16net's keyboard22:41
robertmyerswell, I have to run, laters!22:41
hub_capcu robertmyers22:41
*** robertmyers has quit IRC22:41
cp16neti think its about time for me to split out as well22:42
hub_capso spredzy might be just easiest to "insert into ..."22:42
cp16netBender: Pardon me, brother. Care to donate to the anti-mugging you fund?22:42
hub_capsince the -manage call is 1/2 baked22:42
cp16netBender: Cheese it!22:42
cp16netLOL22:43
hub_capwoah22:43
hub_capthat one is the BEST22:43
cp16netBender: Court’s kinda fun when it’s not my ass on the line!22:43
hub_capnope22:43
hub_capu sholdve quit22:43
cp16netHomer: Getting out of jury duty is easy. The trick is to say you're prejudiced against all races.22:43
hub_capNOPE22:43
hub_capBender: Cheese it!22:43
hub_capbest ever22:43
*** kevinconway has quit IRC22:43
hub_caphaving 2 laptops + a external mouse (cuz stupid c720 trackpad was borked) made me want to bust out synergy22:44
cp16netyeah thats a nice proggy22:45
cp16netalright i'm out22:45
cp16netbe on later22:45
spredzyI am out for the day, ttyl. Thanks for the pointers22:49
*** spredzy has quit IRC22:49
*** SnowDust has quit IRC22:49
*** jasonb365 has quit IRC22:50
*** rongze has joined #openstack-trove22:55
*** denis_makogon has quit IRC22:56
*** jcooley_ has joined #openstack-trove22:58
*** jmontemayor has quit IRC22:59
*** rongze has quit IRC22:59
*** plodronio has left #openstack-trove23:07
*** yogesh has quit IRC23:08
*** yogesh has joined #openstack-trove23:08
*** yogesh has quit IRC23:13
*** datsun_F40PH has quit IRC23:15
*** amytron has quit IRC23:16
*** NehaV has quit IRC23:40
*** vipul has quit IRC23:43
*** vipul has joined #openstack-trove23:44
*** rongze has joined #openstack-trove23:56
*** jcooley_ has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!