*** rongze has quit IRC | 00:02 | |
*** rnirmal has joined #openstack-trove | 00:04 | |
*** jmontemayor has quit IRC | 00:04 | |
*** key4 has quit IRC | 00:05 | |
*** openstackgerrit has quit IRC | 00:06 | |
*** openstackgerrit has joined #openstack-trove | 00:06 | |
*** rnirmal has quit IRC | 00:15 | |
*** matsuhashi has joined #openstack-trove | 00:21 | |
*** mmcdaris has joined #openstack-trove | 00:28 | |
*** grapex has quit IRC | 00:43 | |
*** mmcdaris has quit IRC | 00:48 | |
openstackgerrit | SlickNik proposed a change to openstack/trove: Added ability to pass custom command-line options to backup runner https://review.openstack.org/58062 | 00:55 |
---|---|---|
*** mmcdaris has joined #openstack-trove | 00:59 | |
*** plodronio has quit IRC | 01:02 | |
*** yogesh has joined #openstack-trove | 01:03 | |
*** yogesh has quit IRC | 01:10 | |
*** yogesh has joined #openstack-trove | 01:11 | |
*** yogesh has quit IRC | 01:15 | |
*** demorris has joined #openstack-trove | 01:21 | |
*** flaper87 is now known as flaper87|afk | 01:22 | |
*** rongze has joined #openstack-trove | 01:28 | |
*** amcrn has quit IRC | 01:29 | |
*** matsuhashi has quit IRC | 01:31 | |
*** rongze has quit IRC | 01:33 | |
*** matsuhas_ has joined #openstack-trove | 01:33 | |
*** tanisdl has quit IRC | 01:35 | |
*** mmcdaris_ has joined #openstack-trove | 01:35 | |
*** mmcdaris has quit IRC | 01:36 | |
*** mmcdaris_ is now known as mmcdaris | 01:36 | |
*** nosnos has joined #openstack-trove | 01:36 | |
*** mmcdaris has quit IRC | 01:47 | |
*** demorris has quit IRC | 02:10 | |
*** demorris has joined #openstack-trove | 02:10 | |
*** mmcdaris has joined #openstack-trove | 02:11 | |
*** openstack has joined #openstack-trove | 02:17 | |
*** openstackgerrit has quit IRC | 02:24 | |
*** openstackgerrit has joined #openstack-trove | 02:24 | |
openstackgerrit | Felipe Reyes proposed a change to openstack/trove: Added missing dependency to the documentation https://review.openstack.org/60133 | 02:26 |
*** jcooley_ has joined #openstack-trove | 02:35 | |
*** matsuhas_ has quit IRC | 02:35 | |
*** erkules_ has joined #openstack-trove | 02:48 | |
*** erkules has quit IRC | 02:49 | |
*** haomaiwang has joined #openstack-trove | 02:50 | |
*** rongze has joined #openstack-trove | 02:53 | |
*** rongze_ has joined #openstack-trove | 02:55 | |
*** rongze has quit IRC | 02:58 | |
*** jcooley_ has quit IRC | 03:17 | |
*** mmcdaris has quit IRC | 03:38 | |
*** matsuhashi has joined #openstack-trove | 04:14 | |
*** rongze_ has quit IRC | 04:35 | |
*** demorris has quit IRC | 05:02 | |
*** amytron has joined #openstack-trove | 05:06 | |
*** mmcdaris has joined #openstack-trove | 05:24 | |
*** mmcdaris has quit IRC | 06:13 | |
*** mmcdaris has joined #openstack-trove | 06:13 | |
*** matsuhashi has quit IRC | 06:14 | |
*** matsuhashi has joined #openstack-trove | 06:14 | |
*** mmcdaris has quit IRC | 06:24 | |
*** mmcdaris has joined #openstack-trove | 06:36 | |
*** rongze has joined #openstack-trove | 06:54 | |
*** yogeshmehra has joined #openstack-trove | 07:01 | |
*** amytron has quit IRC | 07:14 | |
*** denis_makogon has joined #openstack-trove | 07:15 | |
*** matsuhashi has quit IRC | 07:17 | |
openstackgerrit | Shalini khandelwal proposed a change to openstack/python-troveclient: Resolution for trove cli fail https://bugs.launchpad.net/python-troveclient/+bug/1258037 https://review.openstack.org/60160 | 07:18 |
*** yogeshmehra has quit IRC | 07:53 | |
*** yogeshmehra has joined #openstack-trove | 07:53 | |
*** yogeshmehra has quit IRC | 07:59 | |
openstackgerrit | Shalini khandelwal proposed a change to openstack/python-troveclient: Added a missing import statement https://review.openstack.org/60169 | 08:02 |
*** harlowja has quit IRC | 08:08 | |
*** flaper87|afk is now known as flaper87 | 08:09 | |
*** yogeshmehra has joined #openstack-trove | 08:12 | |
*** vipul is now known as vipul-away | 08:27 | |
*** vipul-away is now known as vipul | 08:37 | |
*** SlickNik has quit IRC | 08:39 | |
*** SlickNik has joined #openstack-trove | 08:39 | |
*** denis_makogon has quit IRC | 08:47 | |
*** yogeshmehra has quit IRC | 09:20 | |
*** yogeshmehra has joined #openstack-trove | 09:20 | |
*** yogeshmehra has quit IRC | 09:25 | |
*** bot-bot is now known as denis_makogon | 09:31 | |
*** erkules_ is now known as erkules | 10:04 | |
*** SnowDust has joined #openstack-trove | 10:14 | |
SnowDust | please look at https://review.openstack.org/60169 | 10:16 |
SnowDust | its a bugfix | 10:16 |
SnowDust | :) | 10:16 |
denis_makogon | k | 10:17 |
*** mmcdaris has quit IRC | 10:21 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Remove 'mount_point' from guestagent RPC API https://review.openstack.org/57189 | 10:23 |
*** shalini has joined #openstack-trove | 10:25 | |
*** yogeshmehra has joined #openstack-trove | 10:31 | |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Remove 'mount_point' from guestagent RPC API https://review.openstack.org/57189 | 10:33 |
SnowDust | please look at https://review.openstack.org/60169 | 10:33 |
denis_makogon | SnowDust, please, wait until robots will +1 it | 10:34 |
*** yogeshmehra has quit IRC | 10:35 | |
SnowDust | sure .. ! | 10:35 |
SnowDust | thats why i asked for the gate re-run :) and thanks .. u re-run that :) | 10:36 |
SnowDust | haomaiwang : how r u ? | 10:37 |
haomaiwang | SnowDust: | 10:37 |
openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Remove 'mount_point' from guestagent RPC API https://review.openstack.org/57189 | 10:40 |
ikhudoshyn | sry for that crap, guys ^ ^, struggling with git(( | 10:41 |
*** rongze has quit IRC | 11:12 | |
SnowDust | shalini: HAPPY BIRTHDAY .. DEC 6 WOW !! | 11:56 |
*** rongze has joined #openstack-trove | 11:57 | |
shalini | :) | 11:58 |
shivam__ | Hey Happy B'day :-) | 11:58 |
SnowDust | trove team expects a party !! | 11:58 |
*** rongze has quit IRC | 12:17 | |
*** rongze has joined #openstack-trove | 12:35 | |
*** rongze_ has joined #openstack-trove | 12:41 | |
*** rongze has quit IRC | 12:42 | |
*** nosnos has quit IRC | 12:45 | |
*** freyes_ has joined #openstack-trove | 12:59 | |
*** freyes has quit IRC | 12:59 | |
*** freyes_ is now known as freyes | 12:59 | |
*** pdmars has joined #openstack-trove | 13:01 | |
*** pdmars has quit IRC | 13:10 | |
*** pdmars has joined #openstack-trove | 13:14 | |
openstackgerrit | Debasish Chowdhury proposed a change to openstack/python-troveclient: Added a missing import statement https://review.openstack.org/60169 | 13:34 |
freyes | hi guys, is there any chance that you create a topic in the openstack-dev mailing list to filter the messages? | 13:35 |
*** debasish has joined #openstack-trove | 13:36 | |
denis_makogon | freyes, hi | 13:55 |
denis_makogon | maybe | 13:55 |
denis_makogon | heat already had their own topic | 13:55 |
freyes | denis_makogon, hi, yes, that's why it came to my mind :p | 13:59 |
denis_makogon | probably we need to ask hub_cap to do that, if it's involves infra | 14:00 |
openstackgerrit | Debasish Chowdhury proposed a change to openstack/trove: Unittest Case for get_user https://review.openstack.org/48201 | 14:16 |
*** radez_g0n3 is now known as radez | 14:43 | |
*** demorris has joined #openstack-trove | 14:46 | |
*** jcru has joined #openstack-trove | 14:48 | |
*** robertmyers has joined #openstack-trove | 14:54 | |
*** abramley has quit IRC | 14:56 | |
*** SnowDust has quit IRC | 15:04 | |
*** diakunchikov_ has joined #openstack-trove | 15:13 | |
*** amytron has joined #openstack-trove | 15:17 | |
*** abramley has joined #openstack-trove | 15:20 | |
*** datsun180b has joined #openstack-trove | 15:23 | |
*** plodronio has joined #openstack-trove | 15:28 | |
*** haomaiwang has quit IRC | 15:43 | |
*** jcooley_ has joined #openstack-trove | 15:58 | |
*** jcooley_ has quit IRC | 15:59 | |
*** diakunchikov has quit IRC | 16:01 | |
*** jcooley_ has joined #openstack-trove | 16:06 | |
*** rnirmal has joined #openstack-trove | 16:06 | |
*** jasonb365 has joined #openstack-trove | 16:11 | |
*** jcooley_ has quit IRC | 16:12 | |
*** jcooley_ has joined #openstack-trove | 16:13 | |
*** jcooley_ has quit IRC | 16:18 | |
*** grapex has joined #openstack-trove | 16:18 | |
*** jumping_Bond has joined #openstack-trove | 16:20 | |
*** jumping_Bond has quit IRC | 16:28 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Removing vim lines https://review.openstack.org/60276 | 16:28 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Cleaning __init__.py from headers https://review.openstack.org/60277 | 16:28 |
*** jumping_Bond has joined #openstack-trove | 16:28 | |
cp16net | denis_makogon: hey i made a comment on https://review.openstack.org/#/c/59410 | 16:30 |
cp16net | looks like that method name should be specific to the root user | 16:31 |
*** rongze_ has quit IRC | 16:37 | |
imsplitbit | why are we removing the vim lines? | 16:48 |
openstackgerrit | Jordan Pittier proposed a change to openstack/python-troveclient: Fix missing Instances imports https://review.openstack.org/60284 | 16:49 |
*** jcooley_ has joined #openstack-trove | 16:51 | |
*** ashestakov has quit IRC | 16:54 | |
*** jcooley_ has quit IRC | 16:54 | |
*** jcooley_ has joined #openstack-trove | 16:55 | |
*** jcooley_ has quit IRC | 16:57 | |
*** jcooley_ has joined #openstack-trove | 16:57 | |
ikhudoshyn | hub_cap: https://review.openstack.org/#/c/57189/ please | 17:00 |
datsun180b | imsplitbit: i remember a ML discussion about vim lines but i don't remember a conclusion | 17:02 |
*** jcooley_ has quit IRC | 17:02 | |
imsplitbit | yeah I removed my review pending investigation :) | 17:03 |
imsplitbit | I don't recall reaching an agreement on that | 17:03 |
imsplitbit | I mean, I don't use vim but I don't care that they're there | 17:03 |
imsplitbit | I don't view them as something needing to be cleaned up per se | 17:04 |
*** rnirmal has quit IRC | 17:05 | |
*** rnirmal has joined #openstack-trove | 17:05 | |
*** jcooley_ has joined #openstack-trove | 17:06 | |
*** jasonb365 has quit IRC | 17:07 | |
*** Barker has joined #openstack-trove | 17:11 | |
*** jmontemayor has joined #openstack-trove | 17:11 | |
denis_makogon | datsun180b, each project decided to do it like they want, but common why is to keen modules clean | 17:12 |
denis_makogon | imsplitbit, heat is on the way of removing vim lines | 17:15 |
denis_makogon | oslo is on the way of removing vim lines | 17:15 |
denis_makogon | imsplitbit, thanks for re-reviewing | 17:16 |
*** SnowDust has joined #openstack-trove | 17:18 | |
SnowDust | https://review.openstack.org/#/c/60169/ this is critical plz review | 17:18 |
*** jasonb365 has joined #openstack-trove | 17:20 | |
SnowDust | juice, mordred, robertmyers : https://review.openstack.org/#/c/60169/ this is critical plz review | 17:20 |
SnowDust | vipul : https://review.openstack.org/#/c/60169/ this is critical plz review | 17:21 |
*** jasonb365 has quit IRC | 17:21 | |
openstackgerrit | Jordan Pittier proposed a change to openstack/trove: Specify NetID for environment with several networks https://review.openstack.org/60292 | 17:23 |
*** jasonb365 has joined #openstack-trove | 17:25 | |
imsplitbit | denis_makogon: so then as I understand it this is a change across the board for all openstack projects? removing vim lines? | 17:25 |
denis_makogon | yes | 17:26 |
SnowDust | hub_cap: https://review.openstack.org/#/c/60169/ this is critical plz review | 17:26 |
denis_makogon | imsplitbit, but it's only at the beginning state | 17:26 |
vipul | SnowDust: i'll merge it if we don't hear from hub_cap | 17:28 |
SnowDust | sure .. thanks ! | 17:28 |
*** jmontemayor has quit IRC | 17:32 | |
*** Barker has quit IRC | 17:32 | |
*** jcooley_ has quit IRC | 17:47 | |
*** jcooley_ has joined #openstack-trove | 17:48 | |
openstackgerrit | A change was merged to openstack/python-troveclient: Added a missing import statement https://review.openstack.org/60169 | 17:49 |
*** denis_makogon is now known as bot_bot | 17:50 | |
*** mmcdaris has joined #openstack-trove | 17:51 | |
*** jcooley_ has quit IRC | 17:52 | |
*** jcooley_ has joined #openstack-trove | 17:56 | |
*** demorris_ has joined #openstack-trove | 17:57 | |
*** demorris has quit IRC | 18:00 | |
*** demorris_ is now known as demorris | 18:00 | |
*** amytron_ has joined #openstack-trove | 18:04 | |
*** amytron has quit IRC | 18:04 | |
*** amytron_ is now known as amytron | 18:04 | |
*** demorris has quit IRC | 18:10 | |
*** harlowja has joined #openstack-trove | 18:14 | |
*** mmcdaris has quit IRC | 18:17 | |
*** ashestakov has joined #openstack-trove | 18:18 | |
*** yogesh_ has joined #openstack-trove | 18:20 | |
SlickNik | vipul: Thanks for taking care of that breaking client change! | 18:25 |
SlickNik | And shalini, thanks for finding and fixing it quickly. | 18:26 |
SnowDust | Say Happy Birthday to Shalini ! | 18:31 |
SnowDust | 6th Dec her birthday HeHe ! | 18:31 |
*** plodronio has quit IRC | 18:31 | |
*** amcrn has joined #openstack-trove | 18:46 | |
*** jmontemayor has joined #openstack-trove | 18:54 | |
*** demorris has joined #openstack-trove | 18:56 | |
* imsplitbit 's belly is full of korean food goodness | 19:03 | |
*** ashestakov has quit IRC | 19:09 | |
datsun180b | you missed the food at the talk matt gave | 19:10 |
datsun180b | also you missed the talk matt gave | 19:10 |
SnowDust | who knows he relished all the korean he heard .. better than smart technology keywords :) | 19:13 |
datsun180b | i'd be willing to wager that none of them were talking about redis | 19:13 |
cweid | Mostly Kim Chi and Bulgogi talk.... | 19:15 |
SlickNik | Bi Bim Bap, so good... | 19:15 |
juice | +1 SlickNik | 19:16 |
cweid | Super good =) | 19:16 |
SnowDust | Bulgogi may be the name .. to another OpenStack service .. one thinks of to propose | 19:16 |
jmontemayor | +1 | 19:16 |
cweid | So need some core love on this review if I could... Got some +1's from the Robots and normal folks. Just no core yet: https://review.openstack.org/#/c/53481/ | 19:16 |
SlickNik | Information-as-a-service. | 19:17 |
cweid | SlickNik: vipul: hub_cap: grapex: <3 | 19:17 |
SnowDust | everyone gets .. +2 ovr that project .. and everyone is a core | 19:17 |
SnowDust | self approved ! | 19:17 |
SlickNik | cweid: will take a look this afternoon. | 19:17 |
cweid | SlickNik: Thank you sir =) | 19:18 |
SlickNik | no worries | 19:18 |
*** jasonb365 has quit IRC | 19:27 | |
*** jumping_Bond has quit IRC | 19:33 | |
*** jumping_Bond has joined #openstack-trove | 19:40 | |
*** tanisdl has joined #openstack-trove | 19:43 | |
*** jumping_Bond has quit IRC | 19:43 | |
*** jcooley_ has quit IRC | 19:44 | |
*** esp has joined #openstack-trove | 19:50 | |
*** jasonb365 has joined #openstack-trove | 19:58 | |
*** yogesh_ has quit IRC | 19:58 | |
*** yogesh_ has joined #openstack-trove | 19:59 | |
*** jcooley_ has joined #openstack-trove | 20:01 | |
*** SnowDust has quit IRC | 20:04 | |
*** cweid has quit IRC | 20:11 | |
*** denis_makogon has joined #openstack-trove | 20:16 | |
denis_makogon | whazzap, i'm back | 20:18 |
*** yogesh_ has quit IRC | 20:22 | |
denis_makogon | hub_cap, i've done subtree, what should i do next ? | 20:22 |
*** yogesh_ has joined #openstack-trove | 20:23 | |
denis_makogon | hub_cap, https://github.com/denismakogon/trove | 20:23 |
datsun180b | cool | 20:24 |
*** zacksh_ is now known as zacksh | 20:25 | |
kevinconway | denis_makogon: *another* github account? | 20:26 |
kevinconway | why do you have so many names on everything? | 20:26 |
denis_makogon | i renamed crazymac to denismakogon | 20:26 |
denis_makogon | and i have only one | 20:26 |
denis_makogon | i've got lots of forks and lots of branches | 20:27 |
datsun180b | probably best to cool off on the 'crazy' moniker anyhow | 20:27 |
imsplitbit | )))))) | 20:27 |
*** yogesh_ has quit IRC | 20:28 | |
datsun180b | can you imagine going to a fancy restaurant and being informed that tonight's sommelier is Frank the Bone-Gnawer, King of Dust and Nickels | 20:28 |
imsplitbit | lol | 20:28 |
datsun180b | and then a man dressed in wigs and trash bags then scrambles up to the table and screams about tonight's wines and specials | 20:30 |
*** jmontemayor has quit IRC | 20:34 | |
*** jasonb365 has quit IRC | 20:34 | |
*** jcooley_ has quit IRC | 20:35 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 20:35 |
*** jcooley_ has joined #openstack-trove | 20:41 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 20:45 |
openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management https://review.openstack.org/53169 | 20:47 |
cp16net | amcrn: i think those are ready for a new review :) | 20:48 |
* cp16net crosses fingers | 20:48 | |
openstackgerrit | Paul Marshall proposed a change to openstack/trove: Acknowledge Nova VERIFY_RESIZE as RESIZE state https://review.openstack.org/60346 | 20:51 |
*** jcooley_ has quit IRC | 20:59 | |
*** datsun180b has quit IRC | 21:01 | |
*** yogesh_ has joined #openstack-trove | 21:18 | |
amcrn | cp16net: awesome, let me take a look | 21:20 |
cp16net | pep8 is not happy after we removed some of the rules | 21:23 |
cp16net | but thats minor | 21:23 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 21:34 |
cp16net | should fix the pep8 issues | 21:34 |
cp16net | amcrn: btw setting a configuration on an instance you are allowed to send in the ref or just the uuid | 21:36 |
cp16net | this is the same as the flavor | 21:36 |
amcrn | yeah i noticed that, makes sense :) | 21:36 |
*** cweid has joined #openstack-trove | 21:36 | |
*** amrith has joined #openstack-trove | 21:36 | |
amcrn | name is still "configuration" though i believe? | 21:36 |
amcrn | (which is good, as long as it wasn't renamed to configurationRef or something like that) | 21:37 |
openstackgerrit | Robert Myers proposed a change to openstack/trove: Paginate backup list api https://review.openstack.org/60358 | 21:37 |
denis_makogon | cp16net, i started reviewing patchset 12, so, i'll let comments there | 21:38 |
cp16net | yeah its just plain ol configuration | 21:38 |
cp16net | denis_makogon: thats fine | 21:38 |
cp16net | there is very little changed between 12 and 13 | 21:38 |
cp16net | just pep8 stuffs | 21:38 |
amcrn | you ready for this cp16net? | 21:38 |
amcrn | *pushes the +1* | 21:39 |
cp16net | ummmmm... | 21:39 |
cp16net | YAY! | 21:39 |
amcrn | i'm going to put a comment that some serious end-to-end hand testing will still be done to make sure nothing is hiding, but it addresses all the previous concerns | 21:39 |
amcrn | nice work :) | 21:39 |
cp16net | yeah i think that will be a really good idea | 21:40 |
cp16net | i've run through just about all the senarios manually | 21:41 |
cp16net | and i tried to make integration tests to do them as well | 21:41 |
cp16net | i have a feeling this feature will be like datastores | 21:41 |
cp16net | where changes will need to be made to fix it up for all the cases i didnt account for | 21:42 |
amcrn | sure, but it's a huge feature, that's to be expected | 21:42 |
cp16net | yeah | 21:42 |
cp16net | i just need to stop at some point before this review gets any bigger | 21:42 |
denis_makogon | cp16net, done | 21:42 |
denis_makogon | cp16net, you can always split it to many | 21:43 |
cp16net | denis_makogon: what does this mean? | 21:43 |
cp16net | "this implementation doesn't allow to apply any of parameters to already applied conf file" | 21:43 |
denis_makogon | cp16net, first suggestion - dynamic valirables deserves it's own BP, as well patchset | 21:44 |
denis_makogon | suppose you've already sent a group of parameters | 21:44 |
denis_makogon | but i forgot to add one or more parameters | 21:45 |
cp16net | ok | 21:45 |
cp16net | so you modify the conf thats applied to the instance? | 21:45 |
denis_makogon | Are configuration groups are modifiable ? | 21:45 |
cp16net | yes | 21:45 |
cp16net | and it applies all the configs in the group again when you change them | 21:46 |
denis_makogon | problem - why do i need send whole config file only for one paramter ? | 21:46 |
cp16net | because it reads all the configuration_parameters and applies them | 21:46 |
*** amrith has quit IRC | 21:46 | |
cp16net | well the thought is that you can change the group how ever you like | 21:47 |
cp16net | but you need to apply the "group" | 21:47 |
denis_makogon | that's the problem | 21:47 |
cp16net | so its just applying the group again | 21:47 |
cp16net | why is that a problem? | 21:47 |
cp16net | we write to new file and apply the configs | 21:48 |
denis_makogon | sending one parameter is easier then whole conf | 21:48 |
denis_makogon | there's no flexibility | 21:48 |
cp16net | its more difficult to handle a single change than the entire change set | 21:48 |
denis_makogon | i want to apply N conf. group with 1 parameter, one by one | 21:49 |
denis_makogon | cp16net, but this is use case | 21:49 |
cp16net | but if you didnt modify the param what is the difference of appying it again or not? | 21:49 |
cp16net | the end result is that not change occurs for that parameter | 21:50 |
denis_makogon | i mean, i want to apply N groups with different parameters, but each group contains 1 parameter | 21:50 |
cp16net | you can only apply 1 config group per instance | 21:50 |
cp16net | 1 to 1 | 21:50 |
denis_makogon | what ? | 21:51 |
cp16net | not 1 to many | 21:51 |
denis_makogon | are you serious ? | 21:51 |
cp16net | yes | 21:51 |
cp16net | maybe there was a miscommunication about that | 21:51 |
denis_makogon | so, you telling that i can apply only one group to only one instance | 21:51 |
cp16net | but yes you apply a configuration_id group to the instane record | 21:52 |
cp16net | yes its a group | 21:52 |
cp16net | on the other hand | 21:52 |
cp16net | you can apply the same configuration group to multiple instnaces | 21:52 |
denis_makogon | this even brings more problems | 21:52 |
denis_makogon | no matter, overriding whole config = mess | 21:53 |
cp16net | please elaborate | 21:53 |
denis_makogon | i see next problems | 21:53 |
denis_makogon | 1. Overriding whole config, even if i want to change 1 parameter | 21:54 |
denis_makogon | 2. Only one group could be applied to instance (sound very creepy) | 21:54 |
denis_makogon | 3. Sending raw string instead of dict | 21:55 |
*** amcrn_ has joined #openstack-trove | 21:55 | |
*** amcrn has quit IRC | 21:55 | |
cp16net | so a configuration group contains a set of configuration parameters | 21:55 |
cp16net | that set you can change at will | 21:55 |
denis_makogon | but i cannot keep more then one group per instance | 21:56 |
denis_makogon | right ? | 21:56 |
cp16net | no a single group per sintance | 21:56 |
robertmyers | denis_makogon: how would it work with more than 1? | 21:56 |
amcrn_ | +1 robermyers | 21:56 |
robertmyers | that seems even harder to manage | 21:56 |
amcrn_ | trying to ascertain the actualized result-set from multiple groups being applied on top of each other sounds difficult to manage from a user-perspective | 21:57 |
cp16net | merging multiple groups with overlaps woud cause more problems | 21:57 |
*** amcrn_ is now known as amcrn | 21:57 | |
denis_makogon | you misunderstood me | 21:57 |
denis_makogon | i want to apply N groups with different parameters, one by one | 21:57 |
denis_makogon | each applying process overrides whole config | 21:58 |
robertmyers | I don't understand that use case | 21:58 |
amcrn | denis_makogon: i think you're going to have to draw up a full example vs. these generalizations | 21:58 |
robertmyers | one at a time? | 21:58 |
denis_makogon | yes | 21:58 |
cp16net | i see a case where you want to slowly test the changes you make one by one | 21:59 |
cp16net | but that wont be any different than slowly changing the parameters in the group | 21:59 |
robertmyers | still you can do that with one group | 21:59 |
amcrn | right, so i don't see the concern? | 21:59 |
cp16net | you can get the same end result. | 22:00 |
denis_makogon | ok, i will write it in ML | 22:00 |
denis_makogon | with whole examples | 22:00 |
denis_makogon | but current solution and design is not applicable at all | 22:00 |
cp16net | denis_makogon: could you pull in my change sets and test it out? maybe that will help? | 22:00 |
cp16net | hell everybody should try it out | 22:00 |
denis_makogon | i agreed only with validation in current implementation | 22:01 |
amcrn | oh ok, i think i see denis' position, let me cook up a quick example | 22:01 |
amcrn | ex: you have 100 databases deployed, all sharing the same configuration group. as a provider, you're interesting in trying to change parameter 'a' to '123', but you don't want to apply it to all running instances, but you're in an awkward position because of inheritance. If you had the ability to overlay multiple groups, you could arguably create a new configuration group with just parameter 'a', and apply it to 1 out of 100, then propagate | 22:03 |
amcrn | to other nodes as confidence grows. | 22:03 |
amcrn | BUT | 22:03 |
amcrn | you could arguably do the same thing by creation a new configuration with the old values + parameter 'a', deassociate the existing from a single node, attach the new one, and test. | 22:03 |
denis_makogon | also, do we gonna limit amount of them per user ? | 22:03 |
amcrn | by creating* | 22:03 |
amcrn | denis_makogon: did i infer your concern correctly? | 22:04 |
denis_makogon | amcrn, yes, closely | 22:04 |
amcrn | yeah, i don't see much of a difference, the scenario after the "BUT" works just as well, if not better from a long term management perspective | 22:05 |
denis_makogon | do not forget about operating system variables, such IP | 22:05 |
*** pdmars has quit IRC | 22:05 | |
cp16net | hmm i see the reasoning but you can still get the same behavior in a different manor | 22:06 |
amcrn | agreed cp16net | 22:06 |
cp16net | so different db's running on different os's and you still want to use the same configuration on all of them? | 22:07 |
*** abramley has quit IRC | 22:07 | |
robertmyers | I think baby steps are in order here, that use case is valid, but it is almost impossible to hit every edge case first time around | 22:07 |
cp16net | you can only apply the same configuration to the same datastore version | 22:07 |
denis_makogon | if cluster instance would contain paramteres only applicable for this VM, and you will override already peretty configured DB | 22:07 |
*** mmcdaris has joined #openstack-trove | 22:07 | |
cp16net | +1 robertmyers | 22:07 |
denis_makogon | overriding is bad | 22:08 |
cp16net | so configurations is going to manage the clusters? | 22:08 |
denis_makogon | of course | 22:08 |
amcrn | whoa, disagree completely | 22:08 |
cp16net | configuration is only there to manage the service | 22:08 |
cp16net | not the infra | 22:08 |
cp16net | or cluster | 22:08 |
amcrn | defining endpoint_snitch or seed-ips or replica-sets is the responsibility of the instance-create payload, not the configuration group | 22:09 |
cp16net | that *would* cause issues | 22:09 |
denis_makogon | cluster = N DB services | 22:09 |
denis_makogon | what the difference ? | 22:09 |
amcrn | denis_makogon: you're intermingling configuration of a datastore with configuration of a cluster | 22:09 |
robertmyers | I think this should mainly target one instance | 22:09 |
amcrn | the latter should be handled by the topology/cluster api | 22:09 |
*** denis_makogon has quit IRC | 22:10 | |
cp16net | yeah that is in some kind of progress somewhere | 22:10 |
robertmyers | we don't have cluster support *yet* | 22:10 |
cp16net | nope | 22:10 |
cp16net | oh ok i am understanding why you thought this was not going to work | 22:10 |
*** denis_makogon has joined #openstack-trove | 22:10 | |
robertmyers | I thought alot of that was driven by heat too? | 22:11 |
amcrn | it will | 22:11 |
denis_makogon | damn client drop me off | 22:11 |
cp16net | yeah i hear heat is magical | 22:11 |
amcrn | i hear it gives great back massages | 22:11 |
*** mmcdaris has quit IRC | 22:11 | |
denis_makogon | guys, let me describe my use cases in ML, it already deep night in my TZ | 22:11 |
*** jcooley_ has joined #openstack-trove | 22:12 | |
amcrn | denis_makogon: please include real-life scenarios vs. generlizations | 22:12 |
denis_makogon | amcrn, you are right, heat can do such tricks | 22:12 |
amcrn | generalizations* | 22:12 |
denis_makogon | amcrn, i would try | 22:12 |
amcrn | cool, thanks. | 22:13 |
cp16net | alright | 22:14 |
amcrn | hey cp16net, what's the reddwarf build failure for the python-troveclient? dyndns is blocked by our IT, so I can't see :/ | 22:14 |
amcrn | (https://review.openstack.org/#/c/53169/10) | 22:14 |
amcrn | let me know if it's some silly time drift, i'll +1 the review | 22:15 |
cp16net | amcrn: test_instance_restored FAIL | 22:18 |
cp16net | wonder if its because the integration needs to be merged first | 22:19 |
amcrn | i believe ashestakov had the same issue (that integration had to be merged first) | 22:19 |
cp16net | yeah i think it could be | 22:20 |
cp16net | i'll have to test that out | 22:20 |
cp16net | i'm pretty sure thats the case | 22:20 |
denis_makogon | cp16net, i restarted you build, seems like delay at gate | 22:23 |
*** mmcdaris has joined #openstack-trove | 22:23 | |
*** yidclare has joined #openstack-trove | 22:36 | |
*** rnirmal has quit IRC | 22:38 | |
*** ashestakov has joined #openstack-trove | 22:38 | |
cp16net | denis_makogon: i'm not sure there is a reason to remove all the headers from the __init__.py | 22:42 |
*** ashestakov has quit IRC | 22:43 | |
*** radez is now known as radez_g0n3 | 22:44 | |
cp16net | looking through the other projects i see __init__.py files with headers.. like nova | 22:46 |
amcrn | c16net: i believe denis_makogon lifted that concern from a comment flaper87 made on the mongodb review | 22:47 |
* flaper87 sneaks in | 22:47 | |
cp16net | i think its fine to remove the vim stuff and make all the other headers consistent but the __init__.py file is part of the proejct as well | 22:48 |
amcrn | flaper87: btw, you have the coolest sounding name of all time | 22:48 |
cp16net | flaper87: hey | 22:48 |
amcrn | (your real name) | 22:48 |
flaper87 | amcrn: Do I? :D | 22:48 |
flaper87 | :D | 22:48 |
flaper87 | cp16net: hey! | 22:48 |
*** openstackgerrit has quit IRC | 22:48 | |
denis_makogon | cp16net, amcrn - keeping clean __init__ soon will be as rule for all OpenStack projects | 22:48 |
*** openstackgerrit has joined #openstack-trove | 22:48 | |
flaper87 | so, re __init__.py headers. It's not necessary to remove them all, what I meant to say is that it's not necessary to add them either | 22:49 |
cp16net | did i miss that memo? | 22:49 |
cp16net | :-P | 22:49 |
denis_makogon | cp16net, there was convo in ML, involving Thierry and other guys | 22:49 |
cp16net | is there going to be a pep8 test to check for that? | 22:49 |
cp16net | :-P | 22:49 |
cp16net | heh | 22:49 |
denis_makogon | conclusion = keep __init__.py clean, if they are not containing logic | 22:50 |
flaper87 | thing is that those files are empty | 22:50 |
flaper87 | there's nothing to license there | 22:50 |
denis_makogon | flaper87, +1 | 22:50 |
flaper87 | nor copyrights to be held | 22:50 |
flaper87 | if the file is not empty, then fine, a license header is required | 22:50 |
denis_makogon | yes, again, agreed with flaper87 | 22:51 |
denis_makogon | also about vim lines | 22:51 |
flaper87 | denis_makogon: I like the way you think ;) | 22:52 |
denis_makogon | same, they should be removed, at all | 22:52 |
flaper87 | :D | 22:52 |
denis_makogon | flaper87, i'm not only thinking, i'm doing https://review.openstack.org/#/c/60277/ https://review.openstack.org/#/c/60276/1 it | 22:52 |
* flaper87 is happy to see both patches | 22:53 | |
*** mmcdaris has quit IRC | 22:57 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: .gitignore some extra generated files and test user creds for cli https://review.openstack.org/59527 | 22:58 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: fake mode script needs to be updated after changed were merged in trove https://review.openstack.org/58441 | 22:58 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: changes to support configuration groups https://review.openstack.org/58445 | 22:58 |
cp16net | oh crap | 22:58 |
* cp16net wonders if that was bad... | 22:58 | |
cp16net | ok that makes sense | 22:59 |
cp16net | thanks denis_makogon and flaper87 | 22:59 |
*** demorris has quit IRC | 22:59 | |
cp16net | RAMLimitExceeded: You can only allocate 4096 RAM (in MB), whereas minimum ram requested is 16384 (in MB) | 23:00 |
cp16net | vipul: SlickNik ^^ | 23:00 |
cp16net | i'm breaking stuff | 23:01 |
SlickNik | rdjenkins? | 23:01 |
*** mmcdaris has joined #openstack-trove | 23:01 | |
cp16net | ye | 23:01 |
cp16net | https://rdjenkins.dyndns.org/job/Trove-Integration-Gate/251/console | 23:01 |
SlickNik | let me take a look, one sec. | 23:01 |
flaper87 | cp16net: my pleasure! | 23:01 |
* flaper87 hopes to do more very soon | 23:01 | |
* flaper87 is very interested in the work around mongodb | 23:01 | |
cp16net | SlickNik: i wonder if too many reviews were trying to be run at the same time? | 23:02 |
*** jasonb365 has joined #openstack-trove | 23:03 | |
cp16net | and it failed to build a new server | 23:03 |
SlickNik | Right now it has 4 workers. It's capable of doing 6 at a time, I think. | 23:03 |
SlickNik | I just cleaned up 3 that were left behind as cruft. | 23:04 |
SlickNik | So we should be good for now. | 23:04 |
cp16net | cool | 23:05 |
cp16net | so if i sumbit like 10 reviews at the same time | 23:06 |
cp16net | it will break | 23:06 |
cp16net | hehe | 23:06 |
*** yogesh_ has quit IRC | 23:09 | |
*** cweid has quit IRC | 23:12 | |
*** robertmyers has quit IRC | 23:14 | |
*** jcooley_ has quit IRC | 23:14 | |
denis_makogon | flaper87, mongodb is delayed, until tempest tests would land | 23:15 |
denis_makogon | flaper87, same with cassandra, redis, postgresql | 23:15 |
denis_makogon | flaper87, delayed for 1-2 month | 23:16 |
flaper87 | denis_makogon: makes sense to me! | 23:17 |
amcrn | can someone provide me the link that shows the code-review statistics for each project? (it lists reviewers, percentages, etc.) | 23:21 |
amcrn | lost the link, and my google-fu is weak | 23:21 |
cp16net | http://www.stackalytics.com/ | 23:23 |
*** jcooley_ has joined #openstack-trove | 23:23 | |
cp16net | ? | 23:23 |
amcrn | nope, it was a site that served up a flat-file for each project, and it had ascii tables of all reviewers, percentage of reviews to code submissions, plus statistics about -1's, etc. | 23:25 |
*** grapex has left #openstack-trove | 23:25 | |
*** mmcdaris has quit IRC | 23:25 | |
*** jcru has quit IRC | 23:26 | |
denis_makogon | http://russellbryant.net/openstack-stats/trove-reviewers-30.txt | 23:30 |
amcrn | that's it, thanks denis_makogon | 23:30 |
denis_makogon | amcrn, always welcome | 23:30 |
*** jasonb365 has quit IRC | 23:31 | |
*** denis_makogon has quit IRC | 23:38 | |
*** jcooley_ has quit IRC | 23:42 | |
*** jcooley_ has joined #openstack-trove | 23:43 | |
*** openstackgerrit has quit IRC | 23:47 | |
*** openstackgerrit has joined #openstack-trove | 23:47 | |
*** jcooley_ has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!