| *** jcooley_ has quit IRC | 00:02 | |
| *** jcooley_ has joined #openstack-trove | 00:02 | |
| *** jcooley_ has quit IRC | 00:07 | |
| hub_cap | datsun180b approved | 00:08 |
|---|---|---|
| datsun180b | hooooooray | 00:08 |
| hub_cap | ok i must go now. its time to cook some tbone steaks on mah egg | 00:09 |
| datsun180b | watch it explode at verify again | 00:09 |
| datsun180b | thanks for approving it. enjoy your dinner | 00:10 |
| amcrn | dinner at 4pm? i think you just earned yourself an honorary aarp card. | 00:12 |
| amcrn | ;) | 00:12 |
| *** jcooley_ has joined #openstack-trove | 00:13 | |
| hub_cap | zing | 00:13 |
| *** jcooley_ has quit IRC | 00:13 | |
| hub_cap | im starting the fire now | 00:13 |
| *** jcooley_ has joined #openstack-trove | 00:13 | |
| hub_cap | they cook at like 700 degrees | 00:14 |
| datsun180b | argh, why did i have to call it? zuul feeds on doubt | 00:15 |
| hub_cap | omg srsly? | 00:15 |
| datsun180b | yeah | 00:15 |
| hub_cap | oh you got yourself a doc failure | 00:15 |
| datsun180b | the DOCS tests failed | 00:15 |
| hub_cap | i think there is a requirements issue w/ it, like sphynixczyx version change | 00:16 |
| datsun180b | oh dmak called a sphinx failure earler today | 00:16 |
| hub_cap | i can never spell that correctly | 00:16 |
| datsun180b | try archaeopteryx | 00:16 |
| hub_cap | srsly, what scientists decided to end it with 'yx' | 00:17 |
| hub_cap | ok but i digress, time to go sear mah meat | 00:17 |
| *** jcooley_ has quit IRC | 00:18 | |
| *** amytron has quit IRC | 00:22 | |
| openstackgerrit | SlickNik proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/61255 | 00:24 |
| *** jcru has quit IRC | 00:31 | |
| juice | denis_makogon, slicknik what did I miss? I just got back from dentist and drs | 00:36 |
| SlickNik | juice: denis_makogon was planning to work on removing mockito from trove. | 00:43 |
| juice | ha ha that's ridiculous why would he do that :) | 00:43 |
| SlickNik | So I told him to touch base with you; I know you some good reasons for adding it, but didn't recall them off the top of my head. | 00:43 |
| datsun180b | vindication, -docs failures clearly not my fault | 00:44 |
| datsun180b | have fun | 00:44 |
| *** datsun180b has quit IRC | 00:44 | |
| juice | what is it being replaced with? | 00:44 |
| juice | please don't tell me with builtin mock | 00:44 |
| SlickNik | I think he was concerned that unlike mock, it's not in the global-requirements for openstack. | 00:44 |
| SlickNik | heh, I don't know for sure what he was thinking of replacing it with (but I suspect mock) | 00:45 |
| * juice vomits on laptop | 00:46 | |
| SlickNik | hub_cap / grapex / vipul: I had to make a few changes to allow the new global requirements patch to merge. (Basically there were a couple of new rules added to hacking that we needed to follow in the codebase). | 00:47 |
| SlickNik | https://review.openstack.org/#/c/61267/ and https://review.openstack.org/#/c/61255/ address this. Please take a look when you get a chance. Thanks! | 00:48 |
| SlickNik | This also fixes the test-requirements files to address the failing sphinx doctests. So it would be good to get that unblocked. | 00:53 |
| yidclare | cage fight between juice and denis_makogon | 00:58 |
| juice | ha ha yidclare I think this is more something I need to talk to mordred on | 00:59 |
| clarkb | juice: there was an entire summit session on it... | 00:59 |
| clarkb | mock is what openstack is moving towards... | 01:00 |
| juice | mock aweful | 01:00 |
| juice | are we moving that way simply because it is included | 01:00 |
| clarkb | they are all awful. this one happens to work everywhere though | 01:00 |
| clarkb | juice: no mox is what most projects use and is not python3 friendlt | 01:00 |
| juice | mock was the first one I tried before running back to mockito | 01:01 |
| juice | I went back and reviewed the api the other night just to ensure it was the beast and it is | 01:01 |
| juice | It makes testing more difficult in my opinion and the result is much more difficult to grock | 01:02 |
| clarkb | juice: take it up with the long long threads on the mail list | 01:02 |
| juice | sounds like a challenge | 01:03 |
| juice | :) | 01:03 |
| juice | thanks clarkb | 01:03 |
| clarkb | http://lists.openstack.org/pipermail/openstack-dev/2013-December/021148.html is one of them | 01:03 |
| juice | was the session a design session (the one at the summit you mentioned) | 01:03 |
| clarkb | yes | 01:07 |
| clarkb | I think it was covered in the python3 session | 01:07 |
| clarkb | since mox is one of the big blockers to python3 compat | 01:08 |
| *** yogeshmehra has joined #openstack-trove | 01:10 | |
| *** amytron has joined #openstack-trove | 01:21 | |
| *** yidclare has quit IRC | 01:23 | |
| *** nosnos has joined #openstack-trove | 01:29 | |
| *** Barker has joined #openstack-trove | 01:30 | |
| *** yogeshmehra has quit IRC | 01:37 | |
| *** amcrn has quit IRC | 01:48 | |
| *** rongze has joined #openstack-trove | 02:01 | |
| *** jcooley_ has joined #openstack-trove | 02:04 | |
| *** achampion has joined #openstack-trove | 02:12 | |
| *** erkules has quit IRC | 02:24 | |
| *** erkules_ has joined #openstack-trove | 02:25 | |
| *** amytron has quit IRC | 02:25 | |
| *** mmcdaris has joined #openstack-trove | 02:26 | |
| *** rongze has quit IRC | 02:31 | |
| *** mmcdaris has quit IRC | 02:34 | |
| *** jcooley_ has quit IRC | 02:43 | |
| *** rongze has joined #openstack-trove | 02:46 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Fixed typos in files in trove/guestagent. https://review.openstack.org/60662 | 03:40 |
| *** haomaiwang has joined #openstack-trove | 03:52 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Enabling H403, H702 rules. https://review.openstack.org/60564 | 04:10 |
| *** mmcdaris has joined #openstack-trove | 04:15 | |
| *** mmcdaris has quit IRC | 04:15 | |
| *** haomaiwa_ has joined #openstack-trove | 04:20 | |
| *** haomaiwang has quit IRC | 04:20 | |
| *** SergeyLukjanov has joined #openstack-trove | 04:27 | |
| *** Barker has quit IRC | 04:29 | |
| *** haomaiwa_ has quit IRC | 04:33 | |
| *** haomaiwang has joined #openstack-trove | 04:34 | |
| *** haomaiwa_ has joined #openstack-trove | 04:39 | |
| *** haomaiwang has quit IRC | 04:39 | |
| *** rongze has quit IRC | 04:50 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 05:09 | |
| *** _SergeyLukjanov has quit IRC | 05:10 | |
| *** SergeyLukjanov has joined #openstack-trove | 05:14 | |
| *** rongze has joined #openstack-trove | 05:20 | |
| *** nosnos_ has joined #openstack-trove | 05:31 | |
| *** jcooley_ has joined #openstack-trove | 05:33 | |
| *** nosnos has quit IRC | 05:34 | |
| *** rongze has quit IRC | 05:35 | |
| *** juice has quit IRC | 05:57 | |
| *** vipuls has quit IRC | 05:58 | |
| *** rongze has joined #openstack-trove | 06:03 | |
| *** juice has joined #openstack-trove | 06:04 | |
| *** nosnos_ has quit IRC | 06:04 | |
| *** nosnos has joined #openstack-trove | 06:05 | |
| *** rongze has quit IRC | 06:07 | |
| *** vipul has joined #openstack-trove | 06:08 | |
| *** rongze has joined #openstack-trove | 06:15 | |
| *** SergeyLukjanov has quit IRC | 06:21 | |
| *** jcooley_ has quit IRC | 06:39 | |
| *** denis_makogon has joined #openstack-trove | 06:42 | |
| *** SushilKM has joined #openstack-trove | 06:46 | |
| *** lifeless has quit IRC | 07:05 | |
| *** jcooley_ has joined #openstack-trove | 07:09 | |
| *** jcooley_ has quit IRC | 07:15 | |
| *** erkules_ is now known as erkules | 07:21 | |
| *** SergeyLukjanov has joined #openstack-trove | 07:49 | |
| *** jcooley_ has joined #openstack-trove | 08:05 | |
| *** jcooley_ has quit IRC | 08:09 | |
| *** flaper87|afk is now known as flaper87 | 08:13 | |
| *** yogesh has joined #openstack-trove | 08:26 | |
| *** haomaiwa_ has quit IRC | 08:27 | |
| *** haomaiwang has joined #openstack-trove | 08:27 | |
| *** rongze has quit IRC | 08:46 | |
| *** rongze has joined #openstack-trove | 08:47 | |
| *** yogesh has quit IRC | 08:53 | |
| *** yogesh has joined #openstack-trove | 08:55 | |
| *** jcooley_ has joined #openstack-trove | 09:00 | |
| *** jcooley_ has quit IRC | 09:04 | |
| *** yogesh has quit IRC | 09:24 | |
| *** yogesh_ has joined #openstack-trove | 09:27 | |
| *** yogesh has joined #openstack-trove | 09:29 | |
| *** yogesh_ has quit IRC | 09:32 | |
| *** nosnos_ has joined #openstack-trove | 09:36 | |
| *** yogesh has quit IRC | 09:37 | |
| *** yogesh has joined #openstack-trove | 09:39 | |
| *** nosnos has quit IRC | 09:40 | |
| *** yogesh_ has joined #openstack-trove | 09:41 | |
| *** denis_makogon has quit IRC | 09:42 | |
| *** lifeless has joined #openstack-trove | 09:43 | |
| *** yogesh has quit IRC | 09:44 | |
| *** yogesh has joined #openstack-trove | 10:03 | |
| *** yogesh__ has joined #openstack-trove | 10:04 | |
| *** yogesh_ has quit IRC | 10:05 | |
| *** yogesh has quit IRC | 10:08 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 10:23 | |
| *** bot_bot is now known as denis_makogon | 10:34 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Changes back trove_client.client.HTTPClient to client.HTTPClient https://review.openstack.org/61370 | 10:49 |
| *** yogesh__ has quit IRC | 10:54 | |
| *** nosnos_ has quit IRC | 10:57 | |
| *** nosnos has joined #openstack-trove | 10:57 | |
| *** rongze has quit IRC | 11:21 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Changes trove_client.client.HTTPClient to trove_client.HTTPClient https://review.openstack.org/61370 | 11:24 |
| *** jcooley_ has joined #openstack-trove | 11:43 | |
| *** rongze has joined #openstack-trove | 11:44 | |
| *** jcooley_ has quit IRC | 11:47 | |
| *** yogesh has joined #openstack-trove | 12:05 | |
| *** amrith has joined #openstack-trove | 12:05 | |
| *** yogesh has quit IRC | 12:10 | |
| *** SergeyLukjanov has joined #openstack-trove | 12:10 | |
| denis_makogon | hub_cap, while you would test cassandra, please use cassandra=1.2 version | 12:12 |
| *** achampion has quit IRC | 12:32 | |
| *** pdmars has joined #openstack-trove | 13:01 | |
| *** dukhlov has joined #openstack-trove | 13:26 | |
| *** jcooley_ has joined #openstack-trove | 13:30 | |
| *** amrith has quit IRC | 13:31 | |
| *** jcooley_ has quit IRC | 13:35 | |
| *** achampion has joined #openstack-trove | 13:39 | |
| *** abramley has joined #openstack-trove | 13:49 | |
| *** nosnos has quit IRC | 14:06 | |
| *** robertmyers has joined #openstack-trove | 14:21 | |
| *** robertmy_ has joined #openstack-trove | 14:23 | |
| *** robertmyers has quit IRC | 14:23 | |
| *** jcooley_ has joined #openstack-trove | 14:25 | |
| *** robertmyers has joined #openstack-trove | 14:25 | |
| *** robertmy_ has quit IRC | 14:27 | |
| *** robertmyers has quit IRC | 14:27 | |
| *** robertmyers has joined #openstack-trove | 14:27 | |
| *** robertmy_ has joined #openstack-trove | 14:29 | |
| *** robertmyers has quit IRC | 14:29 | |
| *** jcooley_ has quit IRC | 14:29 | |
| *** robertmy_ has quit IRC | 14:29 | |
| *** robertmyers has joined #openstack-trove | 14:31 | |
| *** rnirmal has joined #openstack-trove | 14:34 | |
| *** dukhlov_ has joined #openstack-trove | 14:36 | |
| *** dukhlov has quit IRC | 14:36 | |
| *** kevinconway has joined #openstack-trove | 14:42 | |
| *** amrith has joined #openstack-trove | 14:48 | |
| *** SushilKM has quit IRC | 14:50 | |
| *** haomaiwang has quit IRC | 14:50 | |
| *** haomaiwang has joined #openstack-trove | 14:51 | |
| *** jcru has joined #openstack-trove | 14:52 | |
| *** amytron has joined #openstack-trove | 14:56 | |
| *** SergeyLukjanov_ has joined #openstack-trove | 15:03 | |
| *** freyes has joined #openstack-trove | 15:05 | |
| *** amrith has quit IRC | 15:05 | |
| *** SergeyLukjanov has quit IRC | 15:06 | |
| *** amrith has joined #openstack-trove | 15:06 | |
| *** SergeyLukjanov has joined #openstack-trove | 15:10 | |
| *** SergeyLukjanov_ has quit IRC | 15:12 | |
| *** Barker has joined #openstack-trove | 15:14 | |
| *** jcooley_ has joined #openstack-trove | 15:18 | |
| *** jcooley_ has quit IRC | 15:23 | |
| *** ashestakov has joined #openstack-trove | 15:26 | |
| *** datsun180b has joined #openstack-trove | 15:35 | |
| *** demorris has joined #openstack-trove | 15:38 | |
| mordred | hi juice | 15:41 |
| *** demorris has quit IRC | 16:03 | |
| *** haomaiwa_ has joined #openstack-trove | 16:04 | |
| *** haomaiwang has quit IRC | 16:04 | |
| *** SergeyLukjanov has quit IRC | 16:05 | |
| *** demorris has joined #openstack-trove | 16:08 | |
| *** jcooley_ has joined #openstack-trove | 16:15 | |
| openstackgerrit | Robert Myers proposed a change to openstack/python-troveclient: Adding pagination support for backups https://review.openstack.org/60626 | 16:16 |
| *** radez_g0n3 is now known as radez | 16:19 | |
| *** jcooley_ has quit IRC | 16:20 | |
| hub_cap | denis_makogon: when you say use cassandra=1.2, does the code not download that version? | 16:28 |
| *** yidclare has joined #openstack-trove | 16:29 | |
| denis_makogon | hub_cap, code does installing what was registered at datastore_version packages | 16:29 |
| hub_cap | ok cool so you just mean make sure teh version says 1.2 right? | 16:30 |
| hub_cap | how come thats not in the -integration code? i think we need to merge kevinconway | 16:30 |
| hub_cap | lol | 16:30 |
| hub_cap | merge kevinconway 's code | 16:30 |
| denis_makogon | hub_cap, there is function which register datastore_type, version, and packages | 16:32 |
| *** amrith has quit IRC | 16:32 | |
| hub_cap | yes there is something in trove-manage denis_makogon | 16:32 |
| hub_cap | but kevinconway had some code that called it properly iirc | 16:33 |
| hub_cap | let me find denis_makogon | 16:33 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: use_stderr should be False for tox tests https://review.openstack.org/60612 | 16:33 |
| cp16net | ok theres a better commit msg :) | 16:33 |
| denis_makogon | hub_cap, cmd_set_datastore() | 16:33 |
| hub_cap | https://review.openstack.org/#/c/57780/ | 16:33 |
| *** jcooley_ has joined #openstack-trove | 16:33 | |
| denis_makogon | hub_cap, yes | 16:34 |
| cp16net | SlickNik: you should be happier with the commit message ... AND i get extra credit :-P | 16:34 |
| denis_makogon | hub_cap, https://review.openstack.org/#/c/52666/5/scripts/files/elements/ubuntu-cassandra/install.d/10-cassandra | 16:34 |
| *** haomaiwa_ has quit IRC | 16:37 | |
| *** haomaiwang has joined #openstack-trove | 16:37 | |
| *** SushilKM has joined #openstack-trove | 16:39 | |
| *** haomaiwang has quit IRC | 16:42 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: add test.rc file to source and .gitignore addition https://review.openstack.org/59527 | 16:43 |
| hub_cap | cp16net: extra credit died w/ your soul in 6th grade | 16:43 |
| cp16net | touché | 16:44 |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Add support of neutron NICs https://review.openstack.org/61481 | 16:45 |
| hub_cap | i need a /slap cmd | 16:45 |
| hub_cap | https://github.com/draggy/irssi-scripts/blob/master/slap.pl | 16:45 |
| hub_cap | aww ya | 16:45 |
| datsun180b | you'd think there'd be some kind of Slap as a Service | 16:46 |
| datsun180b | send a GET to the service and a bot joins the room long enough to /slap someone for you | 16:47 |
| *** SushilKM has quit IRC | 16:51 | |
| *** rongze_ has joined #openstack-trove | 16:51 | |
| *** rongze__ has joined #openstack-trove | 16:52 | |
| *** rongze has quit IRC | 16:52 | |
| *** SushilKM has joined #openstack-trove | 16:56 | |
| *** rongze_ has quit IRC | 16:56 | |
| SushilKM | hi hub_cap | 16:56 |
| juice | hello mordred | 16:56 |
| SushilKM | currently troveclient client is not working | 16:56 |
| SushilKM | this is for the last change implemented on troveclient .... | 16:57 |
| SushilKM | I have fixed the bug please look into this checkin .... https://review.openstack.org/#/c/61370/ | 16:57 |
| *** timfreund has quit IRC | 16:57 | |
| *** ashestakov has quit IRC | 16:58 | |
| *** SushilKM has quit IRC | 16:58 | |
| mordred | juice: you seemed unhapy about mocking libraries earlier | 16:59 |
| *** SushilKM has joined #openstack-trove | 16:59 | |
| juice | yes - very :( | 16:59 |
| juice | some of it is bias but most of it is based on pragmatism | 16:59 |
| *** greghill has joined #openstack-trove | 17:00 | |
| juice | i found that the mock library for python makes the test code more difficult to understand and develop | 17:00 |
| juice | I have used mockito in the java world (which is more about stubbing) and it worked incredibly well | 17:00 |
| mordred | you know we're using the add-on mock and not just the one in the standard library, yeah? | 17:00 |
| SushilKM | all reviewers can please verify the checkin https://review.openstack.org/#/c/61370/ | 17:01 |
| *** glucas has joined #openstack-trove | 17:01 | |
| juice | i was under the impression that it is the builtin mock | 17:01 |
| mordred | thing is - if you want to use mockito, you really need to convince the entire openstack project | 17:01 |
| mordred | nope | 17:01 |
| mordred | pip install mock | 17:01 |
| clarkb | it is built in in python3 | 17:01 |
| juice | so add on for python 2 but builtin for python 3 | 17:01 |
| juice | ? | 17:01 |
| juice | right clarkb | 17:02 |
| mordred | https://pypi.python.org/pypi/mock | 17:02 |
| mordred | yeah | 17:02 |
| juice | so I am feeling the chance are slim but I would like to take a run at it since it is something I feel passionate about | 17:02 |
| juice | or am I wasting my time | 17:03 |
| SlickNik | Thanks cp16net for updating the commit message! | 17:04 |
| cp16net | SlickNik: np | 17:04 |
| juice | other than the "batteries included" argument, I don't feel the builtin lib compares in terms of readability and usability to mockito. Perhaps a demonstration (side-by-side) and education will help convince others to give it a go | 17:05 |
| SlickNik | Now if only I could get someone to look at merging the requirements patches so that we can fix the trove-docs gate. | 17:05 |
| juice | esp. if we are going to put all this effort into switching/rewriting tests | 17:05 |
| mordred | juice: go for it. I mean, the worst that can happen is you get flamed | 17:06 |
| juice | mordred - through the mailing list is the best route to bring it up | 17:06 |
| mordred | juice: you may want to try convincing lifeless - he's really good at counter arguments | 17:06 |
| mordred | juice: yeah - throught he mailing list | 17:06 |
| juice | thats a good idea. I'll spar with him first ;) | 17:07 |
| SlickNik | hub_cap / grapex: https://review.openstack.org/#/c/61255/, and https://review.openstack.org/#/c/61267/ when you get a chance. | 17:07 |
| mordred | juice: word to the wise - a) be prepared that you might get eye rolls since we just did a mox vs. mock debate - and b) you'll get further if you talk about how productive you feel mockito makes you vs. mock being deficient | 17:07 |
| *** dougshelley66 has joined #openstack-trove | 17:09 | |
| juice | got it - thanks mordred those are good points. | 17:09 |
| mordred | juice: good luck! | 17:10 |
| juice | thanks man | 17:11 |
| *** rongze__ has quit IRC | 17:11 | |
| *** freyes has quit IRC | 17:11 | |
| denis_makogon | whazaaap | 17:11 |
| openstackgerrit | Greg Hill proposed a change to openstack/trove: check for invalid hostnames on update_attributes https://review.openstack.org/61505 | 17:16 |
| *** rongze has joined #openstack-trove | 17:17 | |
| hub_cap | and here i thought i was gonna give greghill his first -1 but denis_makogon beat me to it! | 17:20 |
| denis_makogon | hub_cap, hehe | 17:20 |
| *** SergeyLukjanov has joined #openstack-trove | 17:20 | |
| denis_makogon | hub_cap, have you tested cassandra =) ? | 17:22 |
| hub_cap | 3-redis 4-cassandra 5-mongo <-- tabs in my tmux right now | 17:22 |
| hub_cap | im testing all 3 | 17:23 |
| hub_cap | but two of the vms failed with a rabbitmq error | 17:24 |
| hub_cap | and the last 4 runs failed too on jenkins | 17:25 |
| denis_makogon | could you please explain a bit | 17:26 |
| openstackgerrit | James E. Blair proposed a change to openstack/python-troveclient: Add -U to pip install command in tox.ini https://review.openstack.org/61510 | 17:26 |
| datsun180b | oh bonk i reversed user and host for my use case but i'm guessing ostensibly if you wanted to change only the user and not the host you could do that | 17:26 |
| datsun180b | like if you fire fred@secure-location but you want to give his replacement derf@secure-location all the same powers i guess | 17:27 |
| *** SushilKM has quit IRC | 17:28 | |
| hub_cap | denis_makogon: https://gist.github.com/hub-cap/7914753 | 17:28 |
| denis_makogon | hub_cap, doh =( | 17:29 |
| hub_cap | yea it happend on all 3 of the instances i spawned | 17:29 |
| hub_cap | oh well ill delete recreate :) | 17:29 |
| denis_makogon | hub_cap, nice | 17:32 |
| openstackgerrit | James E. Blair proposed a change to openstack/trove: Add -U to pip install command in tox.ini https://review.openstack.org/61515 | 17:34 |
| *** amrith has joined #openstack-trove | 17:42 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Moving storage logic out of backup runner class https://review.openstack.org/56702 | 17:43 |
| denis_makogon | hub_cap, SlickNik could we get sphinx update landed ? | 17:50 |
| *** yidclare has quit IRC | 17:54 | |
| *** SushilKM has joined #openstack-trove | 17:56 | |
| SlickNik | denis_makogon: sure. Just waiting for core approval on the requirements patch. | 17:56 |
| denis_makogon | SlickNik, you are core =))) | 17:57 |
| *** grapex has joined #openstack-trove | 17:59 | |
| datsun180b | #openstack-meeting-alt folks | 18:00 |
| SlickNik | denis_makogon: Yes, but it's my patch. :) I'd like someone else to review and approve. | 18:00 |
| denis_makogon | SlickNik, ok =)) | 18:00 |
| denis_makogon | damn, we have so many wrong assertions ... | 18:02 |
| denis_makogon | in unit tests | 18:02 |
| *** radez is now known as radez_g0n3 | 18:21 | |
| *** amcrn has joined #openstack-trove | 18:28 | |
| *** radez_g0n3 is now known as radez | 18:37 | |
| *** simonmcc has quit IRC | 18:38 | |
| *** yidclare has joined #openstack-trove | 18:42 | |
| *** simonmcc has joined #openstack-trove | 18:42 | |
| *** SushilKM has quit IRC | 18:42 | |
| *** yogesh has joined #openstack-trove | 18:42 | |
| lifeless | juice: mordred: hi, wassup? | 18:50 |
| juice | good morning lifeless (or is it) | 18:51 |
| juice | so I want to take up our choice of mock frameworks to the openstack folks in general | 18:52 |
| juice | I see there are some strong arguments in terms of productivity/readability in using mockito | 18:52 |
| lifeless | ok | 18:53 |
| juice | it's perhaps a lesser known mock/stub framework in the python world but has great success in the java communitiy | 18:53 |
| juice | lifeless: what do you think would be the most effective medium to present the case? code samples? | 18:55 |
| lifeless | well | 19:00 |
| hub_cap | ok so should we continue our conversations? | 19:00 |
| datsun180b | oh | 19:00 |
| datsun180b | boy | 19:00 |
| lifeless | firstly I'd thin about what benchmark the case needs to reach to be worth even discussing | 19:01 |
| lifeless | like | 19:01 |
| hub_cap | maybe lets finish the mockito discussion first | 19:01 |
| denis_makogon | yup | 19:01 |
| lifeless | say it takes two weeks of use to get up to speed on mockito | 19:01 |
| juice | well lifeless is providing some feedback now | 19:01 |
| lifeless | and say the docs are as accessible and complete as mock | 19:01 |
| juice | ok | 19:02 |
| lifeless | and say its going to take 2 years to migrate such that noone needs to care about the other frameworks anymore | 19:02 |
| denis_makogon | so, what should we do ? | 19:02 |
| lifeless | (The lower bound is 1 year to let old releases become unsupported) | 19:02 |
| *** olkonami has joined #openstack-trove | 19:03 | |
| lifeless | we've got > 1000 developers to retrain | 19:03 |
| juice | either way yes? | 19:03 |
| lifeless | and for the next 2 years they would have to train on 3 different mock libraries | 19:03 |
| lifeless | mox, mock, and mockito | 19:03 |
| hub_cap | when will the train arrive in cairo? | 19:03 |
| lifeless | whats the net productivity gain going to be? | 19:04 |
| lifeless | how long will this take to payoff, for it to be worth doing | 19:04 |
| lifeless | so thats one thing | 19:04 |
| datsun180b | hub_cap: trick question, the station's closed on Sundays | 19:04 |
| lifeless | a second thing, is what - if any - actual pain points do we have that it's solving. | 19:04 |
| lifeless | Like for nose vs testr, infra articulated a bunch of reliability issues they encounted due to observing tests running at scale. | 19:04 |
| hub_cap | thats the best Q right there lifeless | 19:05 |
| grapex | juice: How many tests are currently using mockito? | 19:05 |
| lifeless | That + some features like test output archiving and the particular form of parallelism used were the selling points for nose -> testr | 19:05 |
| hub_cap | if it doesnt offer us anything we cant get from existing frameworks then there is not a good reason to use it | 19:05 |
| juice | other than incorrectly writing the tests/mocks, I am not aware of any issues of scale, bugs, with either | 19:05 |
| lifeless | So *if* it's going to pay for itself *even though* it means three frameworks for an indefinite period, *and* it's going to solve pain points that are affecting (directly or indirectly) many people | 19:06 |
| juice | grapex: I'm not that sure but I would say around 20% | 19:06 |
| lifeless | then I think it's a discussion worth having | 19:06 |
| lifeless | and at that point we should look at how to have the discussion itself | 19:06 |
| lifeless | otherwise, while personally I'm a great fan of using the right tool for the job, and allowing variation about those tools, the OpenStack culture is very much concerned with homogeneity where possible (at least at the moment), so I think you'd run into a pretty strong pushback | 19:08 |
| juice | the main pain point I feel of this particular issue is a) the speed in which it takes to write the correct stub and b) the ability to understand what that stub does from a maintainers perspective | 19:08 |
| lifeless | . | 19:08 |
| juice | tests are roughly equal to half the number of lines of code in openstack | 19:08 |
| imsplitbit | juice we had some issues mocking builtins with mockito which weren't present when using mox | 19:08 |
| imsplitbit | fyi | 19:08 |
| imsplitbit | or rather fwiw | 19:09 |
| juice | that would be good to know imsplitbit | 19:09 |
| imsplitbit | specifically mocking __builtin__.open() | 19:09 |
| lifeless | always a risky proposition | 19:09 |
| imsplitbit | cweid can fill you in with code samples | 19:10 |
| imsplitbit | well we have code that specifically opens file handles and does things and we wanted to test as much of the code path as possible so the most direct mock would be open() | 19:10 |
| imsplitbit | it can be done responsibly | 19:10 |
| imsplitbit | this was done in some code I wrote for nova | 19:11 |
| juice | i'll look into that but that is either a known issue or there is a workaround for it | 19:11 |
| imsplitbit | yeah I'm just letting you know the one issue we ran into with mockito | 19:11 |
| imsplitbit | and it may be valid to say "you're doing it wrong" | 19:11 |
| imsplitbit | just making sure we communicated that use case upstream | 19:11 |
| datsun180b | oh are we talking about mockito weirdness | 19:12 |
| datsun180b | https://github.com/openstack/trove/blob/master/trove/tests/unittests/conductor/test_methods.py#L27 | 19:12 |
| datsun180b | thought that may just be part of testcase | 19:13 |
| datsun180b | never quite figured it out | 19:13 |
| *** rongze has quit IRC | 19:13 | |
| juice | datsun180b yeah that is odd perhaps a misuse | 19:14 |
| juice | well for those of you that have used both mock libraries - do you have a preference? | 19:14 |
| datsun180b | yeah i had to save and restore that method because only once i was within the body of Testcase the method had been nulled | 19:15 |
| *** rongze has joined #openstack-trove | 19:15 | |
| cp16net | thats weird | 19:16 |
| datsun180b | i personally prefer to mock objects and not built when.thens | 19:16 |
| juice | ok thanks for being upfront datsun180b | 19:16 |
| juice | anybody else want to chime in on your experience? | 19:17 |
| lifeless | the problem with open specifically is that testcase will open .py files to get lines for exception rendering | 19:18 |
| juice | and logging...lifeless | 19:18 |
| lifeless | https://github.com/openstack/trove/blob/master/trove/tests/unittests/conductor/test_methods.py#L46 <- that should be a cleanUp, not a tearDown | 19:18 |
| lifeless | yeah | 19:19 |
| lifeless | opening files is an operation on global state | 19:19 |
| lifeless | it's not pure | 19:19 |
| lifeless | so if you're mocking it, you have to allow for many more potential interactions | 19:19 |
| lifeless | for that case I'd always use a thunk function which can be mocked or injected without affecting the global open | 19:19 |
| juice | lifeless: that is a good suggestion | 19:20 |
| olkonami | Hi! We are working on support SQLAlchemy 0.8 in openstack. Trove is the last openstack core project which unit tests fail with this version. Please review the fix (it's really small :)) https://review.openstack.org/#/c/59157/ | 19:21 |
| *** rongze has quit IRC | 19:22 | |
| hub_cap | hi olkonami awesome, thx! | 19:22 |
| hub_cap | olkonami: approved | 19:23 |
| olkonami | thank you! | 19:23 |
| juice | so that bug test case posted above isn't even using mockito other than unstub...which probably shouldn't be called at all but also shouldn't have any impact | 19:26 |
| juice | and if it does then some previous test is not unstubbing the mocks datsun180b | 19:27 |
| cp16net | denis_makogon: in the review where you removed vim lines and cleaned up the copyright lines you have removed some copyright lines for companies | 19:27 |
| denis_makogon | cp16net, where ? | 19:27 |
| cp16net | i saw HP removed in at least one spot as i was going through the 100000s of files | 19:28 |
| datsun180b | right, i spent way too long trying to unknot those worker thread logs and this was the solution i chose to get conductor in for i1 and merged before Ragnarok | 19:28 |
| juice | datsun180b - are you inferring that the multiple worker threads of testr along with mocking is causing an issue? | 19:29 |
| datsun180b | nothing so grand, just my failure to unknot them in a timely fashion | 19:30 |
| denis_makogon | cp16net link ? | 19:30 |
| hub_cap | git diff|grep -B10 opy | 19:32 |
| hub_cap | maybe back 10 is too much denis_makogon :) | 19:32 |
| robertmyers | anyone know why the tox tests are logging all sorts of info to the console now? | 19:33 |
| robertmyers | it is impossible to see anything useful | 19:34 |
| denis_makogon | hub_cap, cp16net gonna fix that | 19:34 |
| cp16net | denis_makogon: https://review.openstack.org/#/c/60276/1/trove/extensions/routes/security_group.py | 19:34 |
| cp16net | robertmyers: yeah | 19:34 |
| denis_makogon | cp16net, only there ? | 19:34 |
| *** openstackgerrit has quit IRC | 19:34 | |
| *** openstackgerrit has joined #openstack-trove | 19:34 | |
| cp16net | denis_makogon: i got lost in all the files | 19:34 |
| cp16net | thats at least one | 19:35 |
| denis_makogon | cp16net, ok, i got it | 19:35 |
| cp16net | robertmyers: https://review.openstack.org/#/c/60612/ | 19:35 |
| *** rnirmal has quit IRC | 19:36 | |
| hub_cap | robertmyers: are they failing | 19:37 |
| hub_cap | cuz if thats the case theyve always puked | 19:37 |
| hub_cap | oh cool cp16net | 19:38 |
| hub_cap | mmmm my brother made some strawberry jelly and sent it to me | 19:41 |
| imsplitbit | oh man | 19:43 |
| imsplitbit | I bet that's good | 19:43 |
| imsplitbit | hub_cap: you missed my andouille chili | 19:43 |
| imsplitbit | it was so good | 19:43 |
| hub_cap | oh man i bet | 19:43 |
| imsplitbit | cweid said it was disgusting | 19:43 |
| hub_cap | i just had 2 piece o' toast | 19:43 |
| imsplitbit | after his 4th bowl | 19:43 |
| hub_cap | srsly???? hows that even possible | 19:43 |
| hub_cap | oh ok | 19:43 |
| hub_cap | so we still never came to conclusion about mount_point SlickNik ikhudoshyn did we | 19:47 |
| openstackgerrit | Greg Hill proposed a change to openstack/trove: check for invalid hostnames on update_attributes https://review.openstack.org/61505 | 19:48 |
| *** yogesh has quit IRC | 19:49 | |
| denis_makogon | hub_cap, am i able to try adding multiple mount points via oslo.config groups ? | 19:50 |
| greghill | is something broken with the docs gating tests? "error: 'source_dir' must be a directory name (got `/home/jenkins/workspace/gate-trove-docs/doc/source`)" | 19:51 |
| cp16net | yeah i think so | 19:51 |
| denis_makogon | grapex, sphinx | 19:51 |
| robertmyers | greghill: was about to ask the same thing | 19:51 |
| denis_makogon | greghill, sphinx | 19:51 |
| *** glucas has quit IRC | 19:51 | |
| *** glucas has joined #openstack-trove | 19:52 | |
| robertmyers | denis_makogon: works for me on my machine | 19:52 |
| denis_makogon | robertmyers, version ? | 19:52 |
| hub_cap | greghill: robertmyers we have a fix thats merging | 19:52 |
| robertmyers | hub_cap: cool | 19:53 |
| hub_cap | https://review.openstack.org/#/c/61255/ | 19:53 |
| hub_cap | https://blueprints.launchpad.net/trove/+spec/refactor-test-codes <-- best description evar | 19:58 |
| *** yogesh has joined #openstack-trove | 20:00 | |
| *** Barker has quit IRC | 20:00 | |
| *** SergeyLukjanov has quit IRC | 20:02 | |
| *** Barker has joined #openstack-trove | 20:04 | |
| SlickNik | hub_cap: looks like python-troveclient is currently broken :( | 20:05 |
| *** ashestakov_phone has joined #openstack-trove | 20:05 | |
| SlickNik | https://review.openstack.org/#/c/61370/ is the fix, so please review when you get a chance. | 20:06 |
| kevinconway | hub_cap: outch… that's a harsh description | 20:09 |
| *** freyes has joined #openstack-trove | 20:13 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Simplify swift storage load logic https://review.openstack.org/57796 | 20:15 |
| *** yogesh has quit IRC | 20:17 | |
| hub_cap | kevinconway: lol right? | 20:19 |
| hub_cap | its kinda a dup bp, but im keeping and making it the parent of the present bp | 20:19 |
| *** yogesh has joined #openstack-trove | 20:19 | |
| *** vipul is now known as vipul-away | 20:21 | |
| *** vipul-away is now known as vipul | 20:21 | |
| *** yogesh has quit IRC | 20:31 | |
| *** amrith has quit IRC | 20:31 | |
| *** vipul is now known as vipul-away | 20:37 | |
| hub_cap | so is anyone else seeing the issue | 20:39 |
| hub_cap | https://gist.github.com/hub-cap/7918037 | 20:39 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Fix mysqldump backup and restore https://review.openstack.org/59234 | 20:39 |
| hub_cap | ashestakov_phone: i beleive was seeing this issue earlier today | 20:39 |
| hub_cap | denis_makogon: ^ ^ | 20:42 |
| hub_cap | for some reason when i remove your latest commit to python-troveclient, i dont see issues anymore | 20:43 |
| hub_cap | i think u introduced a bug denis_makogon | 20:43 |
| *** radez is now known as radez_g0n3 | 20:44 | |
| hub_cap | also denis_makogon plz update your cassandra trove-integration review (sorry, rebase) | 20:46 |
| hub_cap | its somewhat old and there are bugs on that branch | 20:46 |
| *** demorris has quit IRC | 21:01 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Properly mark a backup as FAILED if the process failed https://review.openstack.org/59283 | 21:01 |
| *** denis_makogon_ has joined #openstack-trove | 21:02 | |
| hub_cap | ashestakov_phone: i found the bug, ill have a review up in ~5 min | 21:06 |
| hub_cap | ashestakov_phone: even better, https://review.openstack.org/#/c/61370/ | 21:08 |
| cp16net | hub_cap: i didnt see that error | 21:09 |
| cp16net | datastore-list worked for me | 21:09 |
| cp16net | this is built 5 days ago | 21:10 |
| *** denis_makogon has quit IRC | 21:10 | |
| *** denis_makogon has joined #openstack-trove | 21:10 | |
| *** denis_makogon has quit IRC | 21:11 | |
| *** denis_makogon_ is now known as denis_makogon | 21:11 | |
| *** dmakogon_ has joined #openstack-trove | 21:11 | |
| hub_cap | ya this was the last commit cp16net | 21:12 |
| hub_cap | it was the one that killed the client | 21:12 |
| hub_cap | ok im runnin to the store, ill be back in ~30 min | 21:14 |
| openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 21:15 |
| *** jasonb365 has joined #openstack-trove | 21:16 | |
| *** olkonami has left #openstack-trove | 21:18 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Simplify swift storage load logic https://review.openstack.org/57796 | 21:25 |
| *** vipul-away is now known as vipul | 21:25 | |
| *** yogesh has joined #openstack-trove | 21:26 | |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Fix mysqldump backup and restore https://review.openstack.org/59234 | 21:28 |
| openstackgerrit | A change was merged to openstack/python-troveclient: Changes trove_client.client.HTTPClient to trove_client.HTTPClient https://review.openstack.org/61370 | 21:29 |
| SlickNik | hub_cap: did you see my comment above? | 21:29 |
| SlickNik | Oh good, you merged the fix to python-troveclient :) | 21:30 |
| *** jcooley_ has quit IRC | 21:34 | |
| vipul | hub_cap, grapex: any reason why when DNS support is enabled we name the nova vm the same as the hostname, instead of instance name | 21:37 |
| cp16net | vipul: i think for traceability? | 21:39 |
| cp16net | not sure tho | 21:39 |
| *** jcooley_ has joined #openstack-trove | 21:39 | |
| vipul | woudl you guys be opposed to changing that to just always be customer supplied name? | 21:41 |
| robertmyers | vipul: is that how it works without dns enabled? | 21:48 |
| vipul | yes | 21:48 |
| robertmyers | I can't think of any reasons not to do that | 21:50 |
| vipul | cool then | 21:50 |
| vipul | thanks robertmyers | 21:50 |
| *** freyes has quit IRC | 21:57 | |
| *** achampion has quit IRC | 21:57 | |
| hub_cap | juice: u got a fix for https://bugs.launchpad.net/trove/+bug/1236620 yet ? | 22:00 |
| hub_cap | it nuked a review 2x times that we are trying to get in | 22:00 |
| robertmyers | hub_cap: it is always the deleted_at time | 22:01 |
| robertmyers | which is a hack, as we can't check for the record as the instance was deleted | 22:02 |
| SlickNik | Yeah, it's always that deleted_at time for the resize event. | 22:02 |
| * hub_cap cant remember robertmyers | 22:02 | |
| hub_cap | juice: would know | 22:02 |
| robertmyers | we have to change the delete to use the management api with deleted=True to get the actual time | 22:03 |
| robertmyers | in the test that is | 22:04 |
| *** greghill has quit IRC | 22:04 | |
| *** demorris has joined #openstack-trove | 22:06 | |
| *** pdmars has quit IRC | 22:07 | |
| imsplitbit | alrighty I'm out. see yous guys tomorrow. | 22:10 |
| denis_makogon | imsplitbit, cu tomorrow | 22:10 |
| denis_makogon | guys, i've got question, are we planning to move from openstack/wsgi to pecan ? | 22:12 |
| juice | @hub_cap: i do but I found a "bug" in a related test that needs to be fixed first | 22:13 |
| openstackgerrit | A change was merged to openstack/trove: Fixed PEP8/flake8 issues https://review.openstack.org/61267 | 22:19 |
| *** grapex has quit IRC | 22:31 | |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Make use of IP filtering when creating DNS records https://review.openstack.org/61589 | 22:35 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Fix deleted_at timestamp in usage tests https://review.openstack.org/61590 | 22:37 |
| robertmyers | hub_cap: juice: ^^ | 22:37 |
| juice | robertmyers: responded | 22:42 |
| hub_cap | denis_makogon: sure, eventually, but its very low priority | 22:44 |
| hub_cap | id like to see other projects take on the migration first, so we have less issues))) | 22:44 |
| hub_cap | juice: robertmyers so whats the deal w/ this fix? it seems that both of you are working on it in some way | 22:46 |
| juice | I am working on the resize timestamp issue | 22:46 |
| juice | It's fix requires something different from what robertmyers is doing. the resize test is that one that most frequently caused an error .... for me | 22:47 |
| juice | hub_cap ^ ^ | 22:47 |
| juice | the instance.service_status.status is currently what I am chasing down | 22:48 |
| juice | there is a scenario whether contrived or not exists in the resize which causes an error in status calculation in SimpleInstance.status | 22:49 |
| juice | in other words, i believe both the issue that robertmyers is addressing and the one that I am are both needed | 22:49 |
| juice | and uniquely foobarred :) | 22:50 |
| robertmyers | juice: I responded as well | 22:50 |
| robertmyers | the deleted_at is not the same as the DB record | 22:51 |
| robertmyers | cause we just set that when we delete it in the test | 22:51 |
| *** glucas has quit IRC | 22:52 | |
| robertmyers | it is not the actual time of deletion | 22:52 |
| juice | ah ok then should we remove that attribute on instance_info, does it serve a purpose? | 22:52 |
| robertmyers | I did remove it | 22:52 |
| juice | I was under the impression they were to represent the same value | 22:53 |
| robertmyers | well, that was the idea, but in practice it is not the same | 22:53 |
| robertmyers | probably microseconds rounding error | 22:53 |
| juice | yeah that's crap | 22:54 |
| juice | expanding the lines in gerrit to get context helps the review process :) | 22:54 |
| robertmyers | :) | 22:54 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Fix deleted_at timestamp in usage tests https://review.openstack.org/61590 | 22:56 |
| robertmyers | ^^^ now with less pep8 errors | 22:56 |
| *** demorris has quit IRC | 22:57 | |
| hub_cap | so SlickNik, do we have a recheck bug XX for the doc update issue we had earlier today? | 22:57 |
| robertmyers | alright, well, I have to run, happy reviewing | 22:57 |
| hub_cap | so we can go reverify/c/recheck some of the failed builds | 22:58 |
| hub_cap | thx robertmyers cu | 22:58 |
| hub_cap | also i prefer _more_ pep8 errors | 22:58 |
| robertmyers | doh | 22:58 |
| robertmyers | I'll submit a review for that | 22:58 |
| hub_cap | lol robertmyers | 22:59 |
| *** jmontemayor has joined #openstack-trove | 22:59 | |
| hub_cap | thx for fixing this, i cant wait for robots to +2 it! | 22:59 |
| yidclare | are you being replaced by robots hub_cap? | 23:00 |
| SlickNik | hub_cap: I don't have a bug number for the sphinx issue. I wonder if there's an openstack wide bug for it. | 23:00 |
| SlickNik | hub_cap: you can do "recheck no bug", just not "reverify no bug" | 23:00 |
| *** demorris has joined #openstack-trove | 23:01 | |
| hub_cap | cool lets hope no one was in reverify state :p | 23:02 |
| kevinconway | so do we need to start creating and tracking gate bugs to work with "reverify"? | 23:02 |
| *** robertmyers has quit IRC | 23:02 | |
| SlickNik | There's a couple in reverify state. | 23:03 |
| SlickNik | btw the bug is https://bugs.launchpad.net/openstack-ci/+bug/1259511 | 23:03 |
| hub_cap | SlickNik: did u already start the 'recheck no bug' madness? | 23:03 |
| hub_cap | i saw you had done one like 15 min ago | 23:04 |
| SlickNik | yes, I already started that | 23:04 |
| *** amytron has quit IRC | 23:05 | |
| SlickNik | We're already starting to see some greens, but it will be better after the fix for the deleted timestamp issue merges. | 23:05 |
| SlickNik | I'm holding off on +2 & approving until things stabilize, though. | 23:06 |
| hub_cap | ok thats a good point SlickNik, lets wait for robots to +1 that timestamp issue | 23:07 |
| SlickNik | sounds good. | 23:07 |
| hub_cap | then we can wait for merge of it and then tomorrow we can recheck no bug | 23:08 |
| hub_cap | cuz itll be 8pm pacific by the time all that happens :P | 23:08 |
| hub_cap | datsun180b: https://blueprints.launchpad.net/trove/+spec/taskmanager-statusupdate | 23:09 |
| hub_cap | im thinking thats a duplicate ;) | 23:09 |
| *** yogesh has quit IRC | 23:10 | |
| esmute | I got a question | 23:12 |
| esmute | I enabled DNS support in trove and i see that the IP is still shown in instance detail (trove show) | 23:12 |
| hub_cap | cp16net: around? | 23:12 |
| *** Barker has quit IRC | 23:12 | |
| esmute | i was under the impression that only the hostname was shown | 23:13 |
| juice | I am going coo-coo from instance(to the power of) status overload | 23:13 |
| hub_cap | esmute: u set dns_support to True right? | 23:13 |
| esmute | hub_cap: yes | 23:13 |
| *** demorris has quit IRC | 23:13 | |
| esmute | hub_cap: I was expecting not to see the IP. just the hostname | 23:13 |
| hub_cap | well thats odd.. it should only give u the hostname | 23:13 |
| juice | i hereby declare if someone creates a new class with either instance or status in it, I will give it an immediate -1 | 23:13 |
| esmute | is that indented? | 23:13 |
| esmute | *intended | 23:14 |
| hub_cap | esmute: oh crapola | 23:14 |
| hub_cap | https://github.com/openstack/trove/blob/d488e37a698d6f1727d3abeb31d7c6a7699af778/trove/instance/views.py#L95 | 23:14 |
| hub_cap | looks like u have to set add_addresses to false too | 23:14 |
| hub_cap | they are independent, i guess... maybe we can say thats a bug too hehe | 23:15 |
| esmute | hub_cap: ahh ok.... ill get a patch in then... | 23:15 |
| esmute | just wanted to make sure this was the intended behavior | 23:15 |
| hub_cap | esmute: maybe it is? im not sure.. it doesnt seem intuitive to me, but grapex / rax crew migthve had a reason | 23:16 |
| *** yogesh has joined #openstack-trove | 23:16 | |
| esmute | hub_cap: also noticed that the compute name get set to the hostname. As supposed to the trove instance name | 23:17 |
| *** flaper87 is now known as flaper87|afk | 23:17 | |
| *** yogesh has quit IRC | 23:17 | |
| *** jasonb365 has quit IRC | 23:17 | |
| *** kevinconway has quit IRC | 23:19 | |
| denis_makogon | esmute, trove instance name = nova instance name = kvm VM host name | 23:21 |
| esmute | denis_makogon: What i am seeing is that when dns is on, nova name = hostname | 23:22 |
| denis_makogon | esmute, it's normal | 23:22 |
| denis_makogon | esmute, dns entry doesn't modify hostname of VM | 23:22 |
| hub_cap | esmute: correct, thats a thing that rax wanted | 23:23 |
| denis_makogon | esmute, designate will resolve DNS name | 23:23 |
| hub_cap | so that the hostname == the displayed vm name | 23:23 |
| esmute | i am not agasint it... just weird seeing that my nova instances who were named after the trove instances are now named <somehash>.domain.com | 23:24 |
| denis_makogon | hub_cap, could this be approved ? https://review.openstack.org/#/c/61169/ | 23:26 |
| denis_makogon | would be nice to see Monty's bug report resolved | 23:27 |
| hub_cap | denis_makogon: why are u asking me? | 23:27 |
| hub_cap | :) | 23:27 |
| denis_makogon | oh, sorry, forgot that i typed your nickname ... | 23:28 |
| hub_cap | :P | 23:28 |
| hub_cap | ask core who havent +2'd it ;) | 23:28 |
| *** abramley has quit IRC | 23:28 | |
| datsun180b | Priority -> Low | 23:29 |
| datsun180b | oh i see how it is | 23:29 |
| *** abramley has joined #openstack-trove | 23:29 | |
| datsun180b | i forget how to make the robot reverify my work oh wait they turned off nobug didn't they | 23:30 |
| SlickNik | datsun180b: you can still do "recheck no bug". Which patch are you looking at? | 23:30 |
| datsun180b | SlickNik: just a dumb one I made that failed at verify because of sphinx | 23:31 |
| denis_makogon | another question about infra, are we going to use ElasticRecheck ? | 23:31 |
| SlickNik | (They only turned off "reverify no bug" because they want to be able to identify issues which were making the gate unstable. | 23:31 |
| SlickNik | ) | 23:31 |
| *** abramley has quit IRC | 23:31 | |
| datsun180b | yeah i should have known better | 23:31 |
| openstackgerrit | A change was merged to openstack/trove: Replace "tokenauth" by "authtoken" in configuration files https://review.openstack.org/61134 | 23:33 |
| SlickNik | denis_makogon: I think that's for tempest failures. Makes sense to use it _after_ we have tempest tests. | 23:33 |
| denis_makogon | SlickNik, thanks for explanation | 23:33 |
| datsun180b | that did it | 23:34 |
| denis_makogon | SlickNik, could you please take a look https://review.openstack.org/#/c/61169/ ? | 23:34 |
| *** openstackgerrit has quit IRC | 23:35 | |
| *** openstackgerrit has joined #openstack-trove | 23:36 | |
| *** dougshelley66 has quit IRC | 23:41 | |
| *** jcru has quit IRC | 23:46 | |
| datsun180b | how in the hell would 26 fail if 27 passed | 23:50 |
| *** vipul is now known as vipul-away | 23:52 | |
| denis_makogon | datsun180b, easily =)) | 23:55 |
| *** openstackgerrit has quit IRC | 23:56 | |
| *** openstackgerrit has joined #openstack-trove | 23:56 | |
| datsun180b | well i claim no fault, i'll investigate it tomorrow | 23:56 |
| *** datsun180b has quit IRC | 23:56 | |
| denis_makogon | sad, that eventlets, greenlets are not working with py3 =( | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!