Thursday, 2014-01-02

*** jmontemayor has quit IRC00:03
*** glucas_ has joined #openstack-trove00:11
*** jcooley_ has joined #openstack-trove00:13
*** Barker has quit IRC00:15
*** jcooley_ has quit IRC00:19
*** rongze has joined #openstack-trove00:42
*** rongze has quit IRC00:46
*** jcooley_ has joined #openstack-trove01:00
*** jcooley_ has quit IRC01:06
*** jcooley_ has joined #openstack-trove01:07
*** rongze has joined #openstack-trove01:15
*** krow has quit IRC01:25
*** krow has joined #openstack-trove01:28
*** jcooley_ has quit IRC01:31
*** rongze has quit IRC01:34
*** rongze has joined #openstack-trove01:49
*** erkules_ has joined #openstack-trove02:24
*** krow has quit IRC02:25
*** erkules has quit IRC02:26
*** krow has joined #openstack-trove02:27
*** krow has quit IRC02:32
*** krow has joined #openstack-trove02:41
*** krow has quit IRC02:42
*** krow1 has joined #openstack-trove02:42
*** krow1 has quit IRC02:46
*** krow has joined #openstack-trove02:49
*** erkules_ has quit IRC02:52
*** dougshelley66 has quit IRC03:01
*** krow has quit IRC03:15
*** dguitarbite has joined #openstack-trove03:22
*** krow has joined #openstack-trove03:26
*** krow has quit IRC03:31
*** krow has joined #openstack-trove03:32
*** dguitarbite has quit IRC03:34
*** krow has quit IRC03:43
*** krow has joined #openstack-trove04:01
*** krow has quit IRC04:11
*** rongze has quit IRC04:47
*** rongze has joined #openstack-trove04:48
*** erkules_ has joined #openstack-trove04:51
*** rongze has quit IRC04:52
*** dougshelley66 has joined #openstack-trove04:57
*** dougshelley66 has quit IRC05:02
*** rongze has joined #openstack-trove05:18
*** rongze has quit IRC05:20
*** rongze_ has joined #openstack-trove05:20
*** rongze_ has quit IRC05:25
*** SushilKM__ has joined #openstack-trove06:00
*** rongze has joined #openstack-trove06:18
*** rongze has quit IRC06:23
*** rongze has joined #openstack-trove06:28
*** zigo has joined #openstack-trove06:56
openstackgerritSushil Kumar proposed a change to openstack/trove: Corrects guest_config value in cfg.py  https://review.openstack.org/6453907:34
*** rongze has quit IRC07:45
*** rongze has joined #openstack-trove07:51
*** yogeshmehra has joined #openstack-trove07:51
*** dguitarbite_ has joined #openstack-trove08:12
*** SnowDust has joined #openstack-trove08:13
*** e0ne has joined #openstack-trove08:40
*** e0ne has quit IRC09:54
*** yogeshmehra has quit IRC09:54
*** SushilKM__ has quit IRC10:06
*** SushilKM__ has joined #openstack-trove10:08
*** SushilKM__ has quit IRC10:15
*** e0ne has joined #openstack-trove10:25
*** e0ne has quit IRC10:26
*** e0ne has joined #openstack-trove10:26
*** e0ne has quit IRC10:31
*** dguitarbite_ has quit IRC10:43
*** rongze_ has joined #openstack-trove10:43
*** haomaiwang has joined #openstack-trove10:44
*** haomaiwa_ has quit IRC10:46
*** rongze has quit IRC10:46
*** rongze_ has quit IRC10:48
*** laurelm has joined #openstack-trove11:11
*** rongze has joined #openstack-trove11:14
*** rongze_ has joined #openstack-trove11:18
*** rongze has quit IRC11:19
*** rongze_ has quit IRC11:22
*** e0ne has joined #openstack-trove11:27
*** e0ne has quit IRC11:32
*** SushilKM__ has joined #openstack-trove11:46
*** SushilKM__ has quit IRC11:53
*** e0ne has joined #openstack-trove12:02
*** rongze has joined #openstack-trove12:02
*** e0ne has quit IRC12:07
*** SnowDust has quit IRC12:17
*** e0ne has joined #openstack-trove12:27
*** e0ne has quit IRC12:32
*** rongze has quit IRC12:36
*** rongze has joined #openstack-trove12:37
*** rongze has quit IRC12:42
*** rongze has joined #openstack-trove13:03
*** e0ne has joined #openstack-trove13:27
*** e0ne has quit IRC13:32
*** pdmars has joined #openstack-trove13:45
*** jcru has joined #openstack-trove13:46
*** e0ne has joined #openstack-trove14:06
*** erkules_ is now known as erkules14:26
*** robertmyers has joined #openstack-trove14:29
*** demorris has joined #openstack-trove15:11
*** datsun180b has joined #openstack-trove15:24
*** e0ne_ has joined #openstack-trove15:25
*** kevinconway has joined #openstack-trove15:26
*** e0ne_ has quit IRC15:27
*** e0ne has quit IRC15:27
*** jimbobhickville has joined #openstack-trove15:30
*** jimbobhickville has quit IRC15:32
*** rongze has quit IRC15:34
*** rongze has joined #openstack-trove15:44
*** yidclare has joined #openstack-trove15:45
*** plodronio has joined #openstack-trove15:47
*** jasonb365 has joined #openstack-trove16:00
*** e0ne has joined #openstack-trove16:06
*** thedodd has joined #openstack-trove16:08
*** jmontemayor has joined #openstack-trove16:12
*** dougshelley66 has joined #openstack-trove16:13
*** e0ne has quit IRC16:16
*** thedodd has quit IRC16:16
*** thedodd has joined #openstack-trove16:21
*** vgnbkr has joined #openstack-trove16:24
*** vgnbkr has left #openstack-trove16:24
*** vgnbkr has joined #openstack-trove16:25
*** vgnbkr_1 has joined #openstack-trove16:27
*** vgnbkr has quit IRC16:27
*** vgnbkr_1 has quit IRC16:27
*** vgnbkr has joined #openstack-trove16:27
*** vgnbkr has joined #openstack-trove16:28
*** vgnbkr_1 has joined #openstack-trove16:28
*** e0ne has joined #openstack-trove16:28
*** vgnbkr_1 has quit IRC16:28
*** jimbobhickville has joined #openstack-trove16:28
*** vgnbkr has quit IRC16:33
*** vgnbkr has joined #openstack-trove16:33
*** vgnbkr_1 has joined #openstack-trove16:33
*** vgnbkr_1 has left #openstack-trove16:34
*** radez_g0` has joined #openstack-trove16:39
*** e0ne has quit IRC16:44
*** rongze has quit IRC16:48
*** radez_g0` is now known as radez16:48
*** rongze has joined #openstack-trove16:49
*** datsun180b has quit IRC16:51
*** datsun180b has joined #openstack-trove16:52
*** SushilKM__ has joined #openstack-trove17:11
SushilKM__hello robertmyers17:12
robertmyershello17:12
SushilKM__wish you a very happy new year :D17:13
SushilKM__regarding https://review.openstack.org/#/c/64517/17:13
robertmyershappy new year to you too17:13
SushilKM__I too was thinking first to remove that file.....17:13
robertmyerswell, redstack script needs to change17:14
SushilKM__but then i saw that we have a functionality in trove-integration to download as well as update the repositories17:14
robertmyersnot needed17:14
*** jmontemayor has quit IRC17:14
SushilKM__so, thats the reason i thought of updating it17:14
robertmyerswe shouldn't be in the business of duplicating devstack17:15
SushilKM__cool, if its like that I can consider this thing to clean up the task from the trove-integration which devstack already does for us17:15
SushilKM__shall i create a blue-print for that or a bug wud suffice the job17:15
robertmyersbug is fine, basically we are duplicating devstack, no need for a bp17:16
SushilKM__okies cool17:16
*** jmontemayor has joined #openstack-trove17:16
SushilKM__i would update my bug for cleaning up devstack duplicate code, and wud update my patchset tooo17:16
*** rongze has quit IRC17:17
*** rongze has joined #openstack-trove17:18
*** rongze has quit IRC17:18
*** rongze has joined #openstack-trove17:19
*** rwsu has joined #openstack-trove17:27
*** vgnbkr_ has joined #openstack-trove17:28
SushilKM__I have updated the bug report, would be later putting the updated patchset. :)17:29
SushilKM__one more thing robertmyers17:33
SushilKM__https://review.openstack.org/#/c/64539/17:33
SushilKM__i saw ur review suggesting to use something like a db config files17:34
*** vgnbkr has quit IRC17:37
*** mat-lowery has joined #openstack-trove17:39
*** rongze has quit IRC17:45
SushilKM__need help to re-run the reddwarf tests for https://review.openstack.org/#/c/64510/17:46
*** rongze has joined #openstack-trove17:47
robertmyersSushilKM__: retriggered17:48
SushilKM__thanks17:49
SushilKM__wanted to discuss for that guest_config parameter17:49
robertmyersSushilKM__: Yes, the guest config is sort of a hack to begin with17:49
*** harlowja has joined #openstack-trove17:49
SushilKM__i was saying that, relocation is  a better option17:49
robertmyersit *works* only if you install the full trove code base17:49
SushilKM__but since its not a kind of template so, we can do with file-handling as is already done17:50
SushilKM__wat do u say17:50
SushilKM__it has all the values which do not get edit .....17:51
*** esp has joined #openstack-trove17:51
robertmyerswell, it gets the db password currently17:51
robertmyersbut that should be removed17:51
robertmyersI'm not sure how to fix it off hand, just don't like the way it currently works17:52
SushilKM__i was seeing rabbit password, not sure abt db password17:52
robertmyersyeah it needs that too, and a template would work great for that17:53
jimbobhickvilleare the reddwarf tests working again?  They've been busted since before Christmas afaict17:54
SushilKM__also regarding this password, since setting up this rabbit password is not the trove's job but rather is the deployers job so trove shud not indulge in finding and putting that password, as the only other way wud be to introduce another config for that17:54
robertmyersjimbobhickville: yes17:54
SushilKM__templating cud be done, only -ve point i see is the extra code which is not adding any value, since all values are derrived out of trove's control17:55
jimbobhickvillecan we kick reddwarf off against https://review.openstack.org/#/c/63523/ again then?17:55
robertmyersSushilKM__: you are correct, like I said I'm not sure the best way to do it17:56
robertmyersjimbobhickville: done17:56
SushilKM__hmmm, so as i said, i think i would +1 the thought of relocation, as that brings the conf file under trove arena17:57
SushilKM__but i think file-handling  good to go with17:57
jimbobhickvillesigh, now jenkins is busted17:57
robertmyersSushilKM__: I think tho it would be nice if we used the same template location so admins can easily override it17:57
robertmyerslike they can with everything else17:58
SushilKM__i think i did not get ur last two lines17:58
robertmyersI would like it to be in trove/templates17:59
robertmyersso that it is all the same17:59
SushilKM__cool, and file-handling is good to go wid17:59
robertmyersI think it would work with $pybasedir if that is what you mean?18:00
SushilKM__yep18:00
robertmyersok18:00
SushilKM__it could be $pybasedir/templates/guest-agent.conf18:00
robertmyerssounds good18:01
SushilKM__cool18:01
SushilKM__let me do that straight forward:D18:01
jimbobhickvilleanyone seen this before on jenkins tests? "Command python setup.py egg_info failed with error code 1 in /home/jenkins/workspace/gate-trove-pep8/.tox/pep8/build/MySQL-python"18:01
robertmyersand eventually it could be made to use jinja to load it18:01
robertmyersjimbobhickville: locally?18:02
robertmyersjimbobhickville: nm18:02
robertmyersjimbobhickville: no18:02
kevinconwayi think error code 1 maps to "Run it again"18:03
jimbobhickvillelol, ok18:03
datsun180bjimbobhickville: is it complaining about pip and wheel, because that's what i'm dealing with18:04
SushilKM__so we would be reading that file using jinja or file-handling is fine18:06
robertmyersSushilKM__: my preference would be to use jinja for all templates, but I haven't look into to it closely to see where it is used18:07
robertmyersso it might be easier to keep it the same18:08
robertmyersfor now and change it in the future18:08
SushilKM__let me link that for u... https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L50218:09
SushilKM__only used here just read that file, thats it18:09
SushilKM__no checks and no changing of tests18:09
*** rongze has quit IRC18:09
robertmyersSushilKM__: ahh, yeah, that should be a template :)18:10
SushilKM__okies, then for obvious reasons it wud be a new method in template.py and the needful unit-test too :)18:10
robertmyerssame with the guest info file18:10
robertmyersSushilKM__: yeah18:11
SushilKM__guest info file is not source from anywhere, it is directly generated in the code18:11
*** amcrn has joined #openstack-trove18:12
robertmyersyeah, it should be a template, is what I'm saying so that we don't just build a file in code18:12
robertmyersjinja can do that pretty simply18:13
SushilKM__okies, that i could look separately, how do u say that18:13
robertmyersI think denis was working on that18:13
robertmyersnot sure where the review is18:13
SushilKM__oh do not know that18:13
openstackgerritA change was merged to openstack/python-troveclient: Correct database-create Name Help Text  https://review.openstack.org/6329418:23
espSushilKM__: hey do you have some time to chat?18:24
SushilKM__sure18:24
espcool, thx18:25
espSushilKM__: can you give me some more details on your comments regarding https://review.openstack.org/#/c/59529/ ? please18:25
SushilKM__i wanted to suggest you that can we do something like user api does it for username18:26
*** jasonb365 has quit IRC18:27
*** david-lyle has quit IRC18:28
*** david-lyle has joined #openstack-trove18:29
espSushilKM__: k, there is already a class that does validation for Database objects18:29
SushilKM__yep18:30
espSushilKM__: ... but the internal method it uses is not supposed to be called explicitly outside of the class for validating database hostnames18:30
espso as I compromise I can promote the method (rename it) to a more public method and then use it.  Would that work for you?18:31
SushilKM__how about using ValidatedMySQLDatabase18:32
espthat is the class I'm talking about18:35
espValidatedMySQLDatabase._is_valid()18:35
espif I want to use it directly, I would rename it to ValidatedMySQLDatabase.is_valid(..)18:35
SushilKM__i think we would not need to call that method18:36
SushilKM__only instantiating the class and then assigning new database names to that shud work for us18:36
espk, so what method would you call then?18:36
espso, you are suggesting something like   valiated_db = MySQLDatabase()18:37
SushilKM__validated_db =  ValidatedMySQLDatabase()18:37
espand then....18:38
SushilKM__sorry18:38
SushilKM__validated_db = MySQLDatabase18:38
espso we have code that does this..18:39
esp          mydb = models.ValidatedMySQLDatabase()18:39
esp                    mydb.deserialize(database)18:39
espand that will validate database names (hostnames)18:40
SushilKM__something like that18:40
*** rongze has joined #openstack-trove18:40
espwhich I did try this approach if you look at the initial commits18:40
espthe problem is this method requires the variable databases to be a list of database 'objects'18:40
espnot string names18:41
espdo you see what I mean?18:41
SushilKM__so cant we get the list18:41
*** yogesh has joined #openstack-trove18:41
espSushilKM__: list of what ?18:41
SushilKM__database names18:42
espgrant_access(self, username, hostname, databases)18:42
espin this method, 'databases' is the list of database names only.18:43
SushilKM__yeah this also does similar task18:43
espgrant_access(..) is the method I'm trying to fix :)18:43
SushilKM__hmm18:43
espso, it's unfortunate that we have a class that refers to a variable name "databases" in different methods where in one case it refers to Database Objects18:44
espwhile in another case it's database string hostnames18:45
SushilKM__so i think we might need a change there, coz that wud be proper way to go ...18:45
espthis is probably why we had a bug here in the first place.18:45
*** rongze has quit IRC18:45
espSushilKM__: sorry, got kicked off of irc there for a sec18:47
espSushilKM__: anyway, what I was suggesting for a fix would be a compromise.  I think we could potentially go back an refactor the class methods to be consistent later but I think that will take more discussions and feedback.18:48
SushilKM__true, u may include few more people to gather thoughts18:49
SushilKM__i just extressed my views18:49
jimbobhickvilleso am I the only one luck enough to get that jenkins fail?  Seems to be having trouble installing the mysql libraries via pip.  Gets a max recursion depth exceeded error18:50
*** abramley has left #openstack-trove18:51
*** abramley has joined #openstack-trove18:52
espSushilKM__: k, thx for reviewing I'll clean things up a bit more18:53
SushilKM__welcome buddy18:53
espjimbobhickville: hmm.. probably not I'll test it out in a few mins18:53
SushilKM__hey robertmyers, quick one18:54
robertmyersshoot18:54
SushilKM__it seems we need to ignore guest-agent.cong while pep8 testing18:54
SushilKM__shall i add that in tox.ini  ignores18:54
robertmyershmm, shouldn't it only look at .py files?18:55
*** vipul is now known as vipul-away18:55
*** vipul-away is now known as vipul18:55
SushilKM__agreed but we have ignore-list to take advantage ;)18:55
SushilKM__and pep8 was shooting a lot of things down in that conf file18:56
SushilKM__so, ignore is better i think18:56
SushilKM__for this conf file18:56
robertmyershow is it working for other template?18:57
robertmyerstemplates18:57
robertmyersfilename=*.py,trove-*18:57
robertmyersname it something other than that18:58
jimbobhickvilleand someone sent an email to openstack-dev, apparently it's a universal issue with mysql-python18:58
*** thedodd has quit IRC18:58
SushilKM__okies, its checking because of name18:58
SushilKM__trove-guestagent18:58
robertmyersah18:58
SushilKM__ok let me rename that18:58
SushilKM__but y do we have trove-* in the list18:59
SushilKM__ok got that too18:59
SushilKM__we have a lot of bin files with trove-18:59
SushilKM__anyways i wud make this as trove_guestagent.conf19:00
robertmyerscurrently the bin files are all trove-api19:00
robertmyersyeah, but we'll move that eventually19:00
SushilKM__means19:00
SushilKM__move?19:00
robertmyersSushilKM__: sounds good19:00
robertmyersI was referring to the bin files19:00
SushilKM__:)19:00
SlickNikhey guys19:02
SushilKM__yeah SlickNik19:03
SlickNikA happy 2014 to you all.19:03
*** rongze has joined #openstack-trove19:03
SlickNikrobertmyers: are you still seeing errors with rdjenkins?19:03
robertmyersSlickNik: not anymore19:04
SushilKM__cool, SlickNik, best wishes to u tooooooo19:04
SlickNiksorry, was out of town over the holidays.19:04
jimbobhickvilleI can confirm as well, reddwarf passes now, just regular jenkins is busted :D19:04
robertmyersSlickNik: no worries, I was only half here19:04
SlickNikback now and catching up. :)19:06
SlickNikjimbobhickville: failure link?19:06
jimbobhickvilleit's a known issue that's affecting all of openstack apparently (there's an email from Monty about it)19:06
jimbobhickville"MySQLdb situation with the gate"19:06
jimbobhickvillejust laughing at the timing of one going down as soon as the other was fixed :D19:07
*** datsun180b has quit IRC19:10
*** rongze has quit IRC19:13
SushilKM__hey slicknik i had done the changes as per ur reviews on my patchsets, u may please chk them in19:14
SlickNikSushilKM__: catching up on email now. Will def look at reviews after I'm done. Thanks for the changes!19:15
SushilKM__coool19:15
SushilKM__np19:15
*** datsun180b has joined #openstack-trove19:19
*** thedodd has joined #openstack-trove19:29
*** parstac_pete has joined #openstack-trove19:37
*** jimbobhickville has quit IRC19:56
*** jimbobhickville has joined #openstack-trove19:56
*** plodronio has left #openstack-trove19:58
*** demorris_ has joined #openstack-trove20:00
*** demorris has quit IRC20:01
*** demorris_ is now known as demorris20:01
*** mat-lowery has quit IRC20:04
*** robertmy_ has joined #openstack-trove20:04
*** robertmy_ has quit IRC20:04
*** robertmyers has quit IRC20:04
*** robertmyers has joined #openstack-trove20:05
*** konetzed has quit IRC20:08
*** konetzed has joined #openstack-trove20:08
*** jasonb365 has joined #openstack-trove20:13
*** mrsnivvel has quit IRC20:14
*** mrsnivvel has joined #openstack-trove20:15
*** SushilKM__ has quit IRC20:16
*** SushilKM__ has joined #openstack-trove20:17
SushilKM__jenkins is failing for MySQL-python20:23
SushilKM__https://review.openstack.org/#/c/62724/ is failed in python26 merging jenkins tests20:24
datsun180byeah there's a ml item about it20:25
SushilKM__do we any bug about that for "reverify bug #" kinda20:25
*** vipul is now known as vipul-away20:26
*** vipul-away is now known as vipul20:26
datsun180bhttp://lists.openstack.org/pipermail/openstack-dev/2014-January/023315.html found it20:27
SushilKM__datsun180b did not see any bug#20:28
SushilKM__i remember earlier hub_cap gave me some link to find those bugs but i have missd that link :(20:30
*** XxLocutusxX has joined #openstack-trove20:31
*** parstac_pete has quit IRC20:33
datsun180bi didn't say there was a bug, just an email so far20:34
SushilKM__okies20:34
clarkbrechecking wont help...20:34
SushilKM__yeah20:34
openstackgerritSushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation  https://review.openstack.org/6453920:38
openstackgerritSushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation  https://review.openstack.org/6453920:45
*** XxLocutusxX has quit IRC20:46
*** radez is now known as radez_g0n320:51
*** SushilKM__ has quit IRC20:51
*** vipul is now known as vipul-away20:55
*** datsun180b has quit IRC20:56
*** dougshelley66 has quit IRC21:00
*** parstac_pete has joined #openstack-trove21:01
*** parstac_pete has left #openstack-trove21:05
*** parstac_pete has joined #openstack-trove21:05
*** thedodd has quit IRC21:05
*** dougshelley66 has joined #openstack-trove21:06
*** doug_shelley66 has joined #openstack-trove21:08
*** doug_shelley66 has quit IRC21:09
*** doug_shelley66 has joined #openstack-trove21:09
*** doug_shelley66 has left #openstack-trove21:09
*** rongze has joined #openstack-trove21:12
*** freyes_ has quit IRC21:12
*** freyes_ has joined #openstack-trove21:14
*** demorris has quit IRC21:15
*** rongze has quit IRC21:17
*** vipul-away is now known as vipul21:18
*** mat-lowery has joined #openstack-trove21:21
*** robertmy_ has joined #openstack-trove21:24
*** vvutharkar has joined #openstack-trove21:25
*** robertmyers has quit IRC21:27
*** demorris has joined #openstack-trove21:36
*** vipul has quit IRC21:48
*** vipul has joined #openstack-trove21:49
*** jmontemayor has quit IRC21:59
*** jmontemayor has joined #openstack-trove22:01
*** vipul is now known as vipul-away22:04
*** vipul-away is now known as vipul22:04
openstackgerritDan Nguyen proposed a change to openstack/trove: Validate databases for user grants  https://review.openstack.org/5952922:09
*** thedodd has joined #openstack-trove22:10
*** rongze has joined #openstack-trove22:12
*** rongze has quit IRC22:17
*** robertmy_ is now known as robertmyers22:23
openstackgerritA change was merged to openstack/trove-integration: Fixes .gitignore  https://review.openstack.org/6185322:24
openstackgerritDan Nguyen proposed a change to openstack/trove: Validate databases for user grants  https://review.openstack.org/5952922:31
*** rwsu has quit IRC22:33
openstackgerritDan Nguyen proposed a change to openstack/trove: Validate databases for user grants  https://review.openstack.org/5952922:37
*** rwsu has joined #openstack-trove22:40
*** pdmars has quit IRC22:46
*** jcru has quit IRC22:47
*** vgnbkr_ is now known as vgnbkr22:58
*** rwsu has quit IRC22:59
*** jmontemayor has quit IRC23:00
*** robertmyers has quit IRC23:05
*** jmontemayor has joined #openstack-trove23:10
*** thedodd has quit IRC23:11
*** rwsu has joined #openstack-trove23:12
*** rongze has joined #openstack-trove23:13
*** jmontemayor has quit IRC23:15
*** jasonb365 has quit IRC23:15
*** jmontemayor has joined #openstack-trove23:17
*** rongze has quit IRC23:18
*** amcrn has quit IRC23:22
*** amcrn has joined #openstack-trove23:36
*** amcrn has quit IRC23:38
*** jmontemayor has quit IRC23:47
*** jimbobhickville has quit IRC23:49
*** plodronio has joined #openstack-trove23:52
*** kevinconway has quit IRC23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!