*** matsuhashi has joined #openstack-trove | 00:09 | |
*** mnaser has quit IRC | 00:16 | |
*** SnowDust has quit IRC | 00:20 | |
*** amcrn has joined #openstack-trove | 00:33 | |
*** matsuhashi has quit IRC | 00:33 | |
*** matsuhashi has joined #openstack-trove | 00:48 | |
*** yogesh has joined #openstack-trove | 00:48 | |
*** nosnos has joined #openstack-trove | 00:58 | |
*** jcooley_ has joined #openstack-trove | 01:12 | |
*** yogesh has quit IRC | 01:31 | |
*** nosnos_ has joined #openstack-trove | 01:53 | |
*** nosnos has quit IRC | 01:54 | |
*** matsuhashi has quit IRC | 02:26 | |
*** matsuhashi has joined #openstack-trove | 02:32 | |
*** erkules_ has joined #openstack-trove | 02:46 | |
*** erkules has quit IRC | 02:46 | |
*** matsuhashi has quit IRC | 03:18 | |
*** haomaiwang has joined #openstack-trove | 03:27 | |
*** haomaiwang has quit IRC | 03:29 | |
*** SnowDust has joined #openstack-trove | 03:30 | |
*** haomaiwa_ has joined #openstack-trove | 03:30 | |
*** Barker has quit IRC | 03:42 | |
*** hub_cap has quit IRC | 03:51 | |
*** hub_cap has joined #openstack-trove | 03:52 | |
*** robertmyers has joined #openstack-trove | 03:56 | |
*** hub_cap_ has joined #openstack-trove | 04:00 | |
*** SnowDust has quit IRC | 04:13 | |
*** matsuhashi has joined #openstack-trove | 04:40 | |
*** robertmyers has quit IRC | 04:43 | |
*** thedodd has joined #openstack-trove | 04:49 | |
*** jcooley_ has quit IRC | 04:50 | |
juice | hello amcrn - saw your bug on the timestamp issue in tox - can you please review this (https://review.openstack.org/#/c/66063/). it fixes that issue along with a few others surrounding instance/status. thanks | 04:52 |
---|---|---|
*** thedodd has quit IRC | 04:54 | |
amcrn | what's up juice; yeah, i'm still fairly positive there's a race that's not being accommodated for | 05:11 |
*** jcooley_ has joined #openstack-trove | 05:11 | |
*** jcooley_ has quit IRC | 05:19 | |
*** jcooley_ has joined #openstack-trove | 05:20 | |
*** werebutt has joined #openstack-trove | 05:22 | |
*** werebutt has left #openstack-trove | 05:22 | |
*** jcooley_ has quit IRC | 05:24 | |
amcrn | juice: can you rebase? | 05:30 |
amcrn | nevermind, was simple | 05:31 |
*** erkules_ is now known as erkules | 05:41 | |
*** shivamshukla has joined #openstack-trove | 05:54 | |
*** jcooley_ has joined #openstack-trove | 06:01 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 06:04 | |
hub_cap | juice: wtf is up w/ that ascii art dude? | 06:05 |
*** jcooley_ has quit IRC | 06:14 | |
amcrn | lol | 06:17 |
amcrn | juice: btw, i take it back, patch works like a charm, awesome job. i had a mini-patch that was close to solving the issue, but i couldn't get around message delivery timing issues in the tests :/. glad you did all the hard work :) | 06:18 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 06:31 | |
hub_cap | juice: why is abc introduced in your patchest? if anything, shouldtn that be a separate patchset applied before the one that amcrn is speaking of | 06:37 |
*** diakunchikov has quit IRC | 06:45 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 06:57 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 07:20 | |
*** flaper87|afk is now known as flaper87 | 07:37 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 07:48 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 08:03 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 08:03 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 08:17 | |
*** matsuhashi has quit IRC | 08:36 | |
*** matsuhashi has joined #openstack-trove | 08:37 | |
*** diakunchikov has joined #openstack-trove | 08:51 | |
*** SnowDust has joined #openstack-trove | 09:28 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects matching of heat resources status https://review.openstack.org/69304 | 09:34 |
*** SushilKM has joined #openstack-trove | 09:35 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects matching of heat resources status https://review.openstack.org/69304 | 09:39 |
*** flaper87 is now known as flaper87|afk | 09:55 | |
*** SnowDust has quit IRC | 09:55 | |
*** amcrn has quit IRC | 09:58 | |
*** SnowDust has joined #openstack-trove | 10:08 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects matching of heat resources status https://review.openstack.org/69304 | 10:16 |
*** haomaiwa_ has quit IRC | 10:29 | |
*** haomaiwang has joined #openstack-trove | 10:30 | |
*** SnowDust has quit IRC | 10:34 | |
*** SnowDust has joined #openstack-trove | 10:52 | |
*** SnowDust has quit IRC | 11:06 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 11:17 | |
*** flaper87|afk is now known as flaper87 | 11:18 | |
*** SnowDust has joined #openstack-trove | 11:26 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 11:33 | |
*** matsuhashi has quit IRC | 11:40 | |
*** matsuhashi has joined #openstack-trove | 11:45 | |
*** igor has joined #openstack-trove | 11:55 | |
*** SushilKM has quit IRC | 12:11 | |
*** matsuhashi has quit IRC | 12:12 | |
*** matsuhashi has joined #openstack-trove | 12:13 | |
*** isvirido1 is now known as isviridov | 12:15 | |
openstackgerrit | shivam shukla proposed a change to openstack/trove: Tests for heat based instance workflow https://review.openstack.org/66499 | 12:19 |
vgnbkr | What's the status of the Fedora int-test? I can't get redstack to work for DISTRO=fedora, either from an ubuntu host or a fedora. | 13:09 |
*** pdmars has joined #openstack-trove | 13:27 | |
*** Barker has joined #openstack-trove | 13:31 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 13:31 | |
*** grapex has quit IRC | 13:50 | |
*** freyes has joined #openstack-trove | 13:56 | |
*** rustlebee is now known as russellb | 14:12 | |
*** jcru has joined #openstack-trove | 14:21 | |
*** SushilKM has joined #openstack-trove | 14:21 | |
*** SushilKM has quit IRC | 14:30 | |
*** grapex has joined #openstack-trove | 14:32 | |
*** grapex has quit IRC | 14:34 | |
*** grapex has joined #openstack-trove | 14:35 | |
*** radez_g0n3 is now known as radez | 14:38 | |
*** kevinconway has joined #openstack-trove | 14:40 | |
*** robertmyers has joined #openstack-trove | 14:44 | |
*** SushilKM has joined #openstack-trove | 14:48 | |
SushilKM | Hey Denis r u thr | 14:49 |
*** robertmyers has quit IRC | 14:50 | |
*** robertmyers has joined #openstack-trove | 14:51 | |
SushilKM | hey robertmyers | 14:52 |
SushilKM | redstack rd-client is broken | 14:53 |
SushilKM | can u luk this one https://review.openstack.org/#/c/68859/ | 14:53 |
*** SnowDust has quit IRC | 14:58 | |
*** amytron has quit IRC | 15:01 | |
SushilKM | hi Robert | 15:02 |
SushilKM | saw ur comment | 15:02 |
SushilKM | let me tell u why this does not works | 15:02 |
SushilKM | since when you source openrc from devstack it takes first argument as username | 15:02 |
SushilKM | so list becomes the username instead of demo | 15:03 |
robertmyers | so then we should drop this command from redstack | 15:05 |
robertmyers | it is not needed at all | 15:05 |
robertmyers | just source openrc and then use the trove command directly | 15:05 |
robertmyers | this is only there to show how to do it | 15:06 |
robertmyers | redstack is close to being completely removed | 15:06 |
SushilKM | if its there to show then it shud work correctly, or it should not be there | 15:06 |
robertmyers | Well maybe we should fix it, but it is hardly holding up development | 15:07 |
robertmyers | this is a low priority, I would vote for removing it | 15:07 |
SushilKM | if someone executes this one they would not see the correct output | 15:08 |
robertmyers | and just add to the docs on how to use trove with devstack | 15:08 |
robertmyers | I'm just saying this is not a high priority to fix right now | 15:08 |
robertmyers | it is not blocking anything | 15:09 |
SushilKM | hmmm, its not a blocker, agree to that | 15:09 |
*** demorris has joined #openstack-trove | 15:10 | |
*** Barker has quit IRC | 15:15 | |
*** Barker has joined #openstack-trove | 15:15 | |
*** Barker has quit IRC | 15:15 | |
*** Barker has joined #openstack-trove | 15:16 | |
*** rwsu has joined #openstack-trove | 15:16 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects spelling typos https://review.openstack.org/69383 | 15:19 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects help messages in cfg.py https://review.openstack.org/68717 | 15:27 |
*** jasonb365 has joined #openstack-trove | 15:30 | |
*** igor has quit IRC | 15:31 | |
*** igor has joined #openstack-trove | 15:32 | |
*** amytron has joined #openstack-trove | 15:32 | |
*** datsun180b has joined #openstack-trove | 15:33 | |
*** igor has quit IRC | 15:36 | |
*** SushilKM has quit IRC | 15:37 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 15:38 | |
*** SushilKM has joined #openstack-trove | 15:39 | |
*** freyes has quit IRC | 15:39 | |
*** ashestakov has joined #openstack-trove | 15:39 | |
*** plodronio has joined #openstack-trove | 15:42 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects spelling typos https://review.openstack.org/69383 | 15:42 |
*** tanisdl has joined #openstack-trove | 15:45 | |
*** SushilKM has quit IRC | 15:49 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 15:58 | |
*** rnirmal has joined #openstack-trove | 16:02 | |
*** amytron_ has joined #openstack-trove | 16:04 | |
*** amytron has quit IRC | 16:04 | |
*** jasonb365 has quit IRC | 16:04 | |
*** amytron_ is now known as amytron | 16:04 | |
*** demorris has quit IRC | 16:06 | |
*** jasonb365 has joined #openstack-trove | 16:10 | |
*** nosnos_ has quit IRC | 16:14 | |
*** matsuhashi has quit IRC | 16:15 | |
hub_cap | vgnbkr: we dont run the int-tests for fedora | 16:19 |
hub_cap | hmph am i not chatting in this channel? | 16:20 |
*** hub_cap has left #openstack-trove | 16:20 | |
*** hub_cap has joined #openstack-trove | 16:21 | |
vgnbkr | hub_cap: Great. So it is normal practice to just run int-tests on ubuntu then submit for review? | 16:23 |
hub_cap | vgnbkr: yessir, thats all the gate runs | 16:25 |
hub_cap | but eventually we want the gate to run fedora | 16:25 |
hub_cap | do the int-tests fail if you set the vm to run fedora? | 16:25 |
hub_cap | id like to hope not :) | 16:25 |
*** Barker has quit IRC | 16:28 | |
hub_cap | lol man i totally spaced and forgot how i set up pgup hahah | 16:29 |
*** thedodd has joined #openstack-trove | 16:29 | |
hub_cap | and subsequently i mightve missed a hilight if anyone ping'd me since last night | 16:29 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 16:30 | |
*** SushilKM has joined #openstack-trove | 16:36 | |
*** Barker has joined #openstack-trove | 16:37 | |
ashestakov | hub_cap: vipul SlickNik grapex pls review neutron stuff https://review.openstack.org/#/c/61481/ https://review.openstack.org/#/c/63212/ | 16:37 |
vgnbkr | hub_cap: DISTRO=fedora failed for me on both ubuntu and fedora hosts. On ubuntu, I seem to recall it failed because it tried to run apt-get on fedora. On fedora host, it couldn't find percona-xtrabackup plus other issues. | 16:44 |
hub_cap | ok thats not good! | 16:44 |
hub_cap | it used to detect that it was fedora, right ashestakov | 16:44 |
hub_cap | ashestakov: did the work to build out the fedora impl for us (horray!) | 16:45 |
vgnbkr | It does get quite far in both cases. | 16:45 |
*** SnowDust has joined #openstack-trove | 16:45 | |
vgnbkr | I was using fedora20, and I did wasn't able to install the VirtualBox guest additions, so I suspect there may be some issues with 20. | 16:46 |
ashestakov | whats problem with fedora? | 16:47 |
SushilKM | hi hub_cap | 16:48 |
SushilKM | currently heat code, is broken up, I have put in a fix, can u see that https://review.openstack.org/#/c/69304/ | 16:49 |
SushilKM | Denis suggested me to use resource.state but it seems like there is no resource.state instead they have resource.resource_status in heat | 16:50 |
SushilKM | which is crapping the heat code, currently | 16:50 |
hub_cap | so they changed their resource object? | 16:50 |
hub_cap | that means they changed a contract, right? | 16:51 |
hub_cap | im confused :) | 16:51 |
SushilKM | I too was, but i agreed for Denis, when he showed me something in heat code | 16:52 |
SushilKM | but it seems they r using resource.state as their own terminology | 16:52 |
SushilKM | but with resource-show api they only publish resource.resource_status | 16:52 |
*** jasonb365 has quit IRC | 16:53 | |
*** Barker has quit IRC | 16:54 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 16:54 | |
*** mat-lowe_ has joined #openstack-trove | 16:54 | |
hub_cap | so then resource.state never worked? | 16:55 |
hub_cap | cuz what it looks like, is that resource.state used to work, but now you are using resource.resource_status cuz something changed | 16:55 |
SushilKM | yeah, it is like that only | 16:55 |
SushilKM | for me, at least | 16:55 |
hub_cap | or was resource.state never tested??/? | 16:55 |
*** ViswaV has joined #openstack-trove | 16:56 | |
*** SushilKM has quit IRC | 16:56 | |
openstackgerrit | Andrey Shestakov proposed a change to openstack/trove: Add mgmt API for datastores https://review.openstack.org/69408 | 16:57 |
*** SushilKM has joined #openstack-trove | 16:59 | |
*** mat-lowery_ has joined #openstack-trove | 16:59 | |
SushilKM | It was this place that he suggested of resource.state and its values https://github.com/openstack/heat/blob/master/heat/engine/stack_resource.py#L121 | 16:59 |
*** mat-lowery has quit IRC | 16:59 | |
*** thedodd has quit IRC | 17:00 | |
*** SushilKM has quit IRC | 17:00 | |
*** jasonb365 has joined #openstack-trove | 17:01 | |
*** thedodd has joined #openstack-trove | 17:01 | |
hub_cap | yea but lets try to run the heat path next time we commit to it (aka the big exception handling code) | 17:02 |
openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Add mgmt API for datastores https://review.openstack.org/69410 | 17:02 |
hub_cap | what this just points out is that if we want to consider heat a first class citizen is that it needs tests, right grapex1 | 17:02 |
hub_cap | DOH, grapex ! | 17:02 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 17:03 | |
*** mat-lowe_ has quit IRC | 17:04 | |
*** mat-lowery_ is now known as mat-lowery | 17:05 | |
*** SushilKM has joined #openstack-trove | 17:06 | |
SushilKM | sure, i wud keep that in mind while putting any new change for heat code, and also there is going on work for unit and int test cases for heat code, soon we may have that on :) | 17:06 |
hub_cap | good, im speaking on int-tests really | 17:07 |
SushilKM | :) | 17:07 |
kalebpomeroy | I'm starting work on the datastore capability features soon. If anyone wants to provide feedback, blueprint is here: https://blueprints.launchpad.net/trove/+spec/capabilities | 17:07 |
*** SushilKM has quit IRC | 17:07 | |
kalebpomeroy | wiki/more docs are here: https://wiki.openstack.org/wiki/Trove/trove-capabilities | 17:07 |
hub_cap | hey kalebpomeroy.. i wonder, do u think capabilities might be something we talk about at the mid cycle sprint? | 17:09 |
hub_cap | or is it pretty stright forward? | 17:09 |
ashestakov | i have question about mgmt api route | 17:09 |
kalebpomeroy | I believe its really straightforward | 17:09 |
ashestakov | pls look to https://review.openstack.org/#/c/69408/1/trove/extensions/routes/mgmt.py L116 | 17:09 |
grapex | hub_cap: Agreed | 17:10 |
ashestakov | i need connect route '{tenant_id}/mgmt/datastores/versions' to MgmtDatastoreVersionController() to update action | 17:10 |
ashestakov | can i do it without create new resource? | 17:10 |
hub_cap | hey ashestakov im not familar w/ the :(datastore_id) for extensions either heh | 17:11 |
hub_cap | u can absolutely do it, if u look at the instance code there is examples of routes that are explicitly defined | 17:11 |
hub_cap | ashestakov: ^ ^ | 17:11 |
ashestakov | hub_cap: why not :(datastore_id) ? | 17:13 |
hub_cap | ive just never seen it before :) | 17:13 |
hub_cap | maybe my memory just alludes me | 17:13 |
*** Barker has joined #openstack-trove | 17:13 | |
hub_cap | but lets not focus on that | 17:14 |
ashestakov | hub_cap: for "instances" resource there are actions like "/mgmt/instances/root" | 17:15 |
hub_cap | look @ instance actions | 17:16 |
hub_cap | tahts a call to a nonstandard method iirc | 17:16 |
ashestakov | i need like https://github.com/openstack/trove/blob/master/trove/common/api.py#L52 | 17:16 |
hub_cap | so i guess im confused w/ your question | 17:19 |
hub_cap | is all u need to call a specific method based on a route | 17:19 |
hub_cap | and that method is not called a standard thing (list/show/delete..) | 17:19 |
ashestakov | but i need standard "update" call for that alias | 17:20 |
hub_cap | what is a standard update call? | 17:21 |
hub_cap | u never said the verb either, POST, GET, ? | 17:21 |
ashestakov | PUT | 17:21 |
hub_cap | so its hard to understand "update call" | 17:21 |
hub_cap | so u just want a PUT? to call a method? | 17:21 |
hub_cap | thats done by default, the documentation for routes should show u what it shoudl be called | 17:21 |
hub_cap | GET/POST/PUT/DELETE/PATCH(maybe not patch?) are all magic and go to specifically named methods | 17:22 |
ashestakov | https://review.openstack.org/#/c/69408/1/trove/extensions/routes/mgmt.py L100 this is route for resource, it accepts POST/PUT calls. I need add alias '{tenant_id}/mgmt/datastores/versions' for same controleed and for same "update" method | 17:22 |
hub_cap | and are exposed naturaly for everuy reousrce | 17:22 |
hub_cap | isint that the 3rd route there ashestakov ? | 17:23 |
hub_cap | u already have that route defined | 17:23 |
vgnbkr | ashestakov: the first issue with fedora is that it couldn't find percona-xtrabackup, but as I said that could be because I was using fedora 20 | 17:23 |
hub_cap | line 116 | 17:23 |
hub_cap | vgnbkr: u might need to check if the image builder added any 3rd party repos (if needed) | 17:23 |
ashestakov | vgnbkr: do you using pre-installed image? | 17:23 |
ashestakov | hub_cap: at L116 i defined different resource for same controller | 17:24 |
ashestakov | hub_cap: and i want to know is it possible to avoid one more resource, and just make mapper.connect() | 17:25 |
hub_cap | so youre asking if u can remove the resource in 116 ? | 17:25 |
ashestakov | hub_cap: yes | 17:25 |
ashestakov | and attach that route to "update" methos | 17:25 |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 17:26 | |
SnowDust | hello all from RAX / HP / IBM | 17:26 |
SnowDust | can we discuss python-troveclient/tools/install_venv_common.py | 17:26 |
hub_cap | oh ok, so waht u are saying is that u have /versions u want to append to /datastores/ and /datastores/{id}, and u want to know if u can do it in 1x route instead of 2, right ashestakov ? | 17:27 |
hub_cap | SnowDust: yea i say nuke it, i read denis_makogon 's reply, and since _I_ told u to ask the list | 17:27 |
SnowDust | yeah .. | 17:27 |
SnowDust | :) | 17:27 |
hub_cap | and i also am pretty sure we dont use it in any of trove-integratio | 17:27 |
SnowDust | still .. it was a last time call ... | 17:27 |
hub_cap | and honestly i dont know what the last bit of his msg was talking about | 17:28 |
SnowDust | yeah .. :) | 17:28 |
hub_cap | denis_makogon: around? | 17:28 |
ashestakov | hub_cap: yes, i need two routes PUT '{tenant_id}/mgmt/datastores/:(datastore_id)/versions' and '{tenant_id}/mgmt/datastores/versions' in one resource | 17:28 |
ashestakov | hub_cap: https://gist.github.com/andreyshestakov/8557935#file-datastores_mgmt_api-L60-L61: | 17:30 |
hub_cap | ashestakov: ok now i understand yer question, give me a few min | 17:30 |
SnowDust | ok .. will wait an hour ... | 17:30 |
SnowDust | then will wipe it off ... | 17:31 |
*** freyes has joined #openstack-trove | 17:31 | |
hub_cap | SnowDust: sure.. but i dont think anyone will mind. if denis_makogon is around, maybe he can explain the stuff at the end of his message about the other clients | 17:32 |
SnowDust | yeah .. :) seriously .. his research as he says ! | 17:32 |
hub_cap | ya i didnt understand what he meant. but lets not merge the code berfore he gets a chance to explain it | 17:33 |
hub_cap | but feel free to propose it | 17:33 |
*** yidclare has joined #openstack-trove | 17:33 | |
SnowDust | yeah thats why .. i never hurried on it .. | 17:33 |
SnowDust | hey krast wassup ? | 17:34 |
*** jcooley_ has joined #openstack-trove | 17:34 | |
hub_cap | ashestakov: so i didnt see anything offhand, but you should check out the routes docs | 17:34 |
ashestakov | hub_cap: i dived in routes, but i didnd found any solution | 17:35 |
hub_cap | ive had to look @ the routes docs a few times to understand whats going on.. those are just objects that feed info to python-routes | 17:35 |
hub_cap | ok | 17:35 |
hub_cap | then id say no | 17:35 |
hub_cap | if youve already looked at routes :) | 17:35 |
vgnbkr | ashestakov: ran fedora live 20 under VirtualBox, defined DISTRO=fedora, then run ./redstack install | 17:35 |
ashestakov | that is not clear python-routes, that is trove extention for routes | 17:36 |
hub_cap | ashestakov: k | 17:36 |
hub_cap | vgnbkr: im not sure that DISTRO=... is good outside of teh redstack.rc | 17:36 |
hub_cap | did u define it there? | 17:36 |
hub_cap | ashestakov: did we make that external? | 17:36 |
hub_cap | yea vgnbkr , https://github.com/openstack/trove-integration/blob/master/scripts/redstack.rc | 17:37 |
hub_cap | did u put define it there, or as a env var? | 17:37 |
hub_cap | u might want to wrap that DISTRO=ubuntu | 17:37 |
hub_cap | to | 17:37 |
ashestakov | hub_cap: oh, not trove ext, just common openstack https://github.com/openstack/trove/blob/master/trove/openstack/common/extensions.py | 17:37 |
hub_cap | DISTRO=${DISTRO:-ubuntu} | 17:38 |
*** igor has joined #openstack-trove | 17:38 | |
hub_cap | yea those are broken too ashestakov | 17:38 |
*** thedodd has quit IRC | 17:38 | |
hub_cap | i dont think they are used or updated anymore ;) | 17:38 |
hub_cap | our wsgi and our extensions from common are both mostly unused by other teams :D | 17:38 |
ashestakov | it used for extentions https://github.com/openstack/trove/blob/master/trove/extensions/routes/mgmt.py#L32 | 17:38 |
hub_cap | sure | 17:39 |
hub_cap | by our project it is | 17:39 |
hub_cap | check nova | 17:39 |
*** thedodd has joined #openstack-trove | 17:39 | |
*** amcrn has joined #openstack-trove | 17:39 | |
ashestakov | does nova has extentions? | 17:39 |
hub_cap | yup | 17:39 |
hub_cap | i know nova, glance and cinder have extensions | 17:40 |
hub_cap | and thye used to use this common extensions code | 17:40 |
hub_cap | but i think they all stopped :) | 17:40 |
hub_cap | and iirc, using some combination of entrypoints+stevedore | 17:40 |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 17:41 | |
juice | hub_cap: amcrn: I am around when current discussions trickle down to discussion mega-patch | 17:41 |
juice | short answer - it wasn't intentional but it was all scaffolding to help keep me clear on what was going on while fixing the timestamp issue which turns out to involve other things | 17:42 |
juice | but more on that later | 17:42 |
juice | abc can be easily lifted to another patch set | 17:42 |
hub_cap | MEGAPATCH juice | 17:45 |
hub_cap | lets chat | 17:45 |
hub_cap | break it up | 17:45 |
hub_cap | done | 17:45 |
hub_cap | good chat | 17:45 |
hub_cap | ;) | 17:45 |
ashestakov | vgnbkr: can you login to you fedora instance and find xtrabackup manually? | 17:45 |
juice | ok | 17:46 |
vgnbkr | I meant it couldn't find it with yum (or whatever) | 17:46 |
juice | so ascii art... | 17:46 |
juice | :) | 17:46 |
vgnbkr | hub_cap: Yes, I'll be delivering: DISTRO=${DISTRO:-ubuntu} | 17:46 |
juice | for maintainers or people new to the project, our objects geography (for lack of better word) is a little unclear | 17:46 |
hub_cap | vgnbkr: <3 | 17:46 |
hub_cap | yes do the ascii art buildings explain anything juice ?? | 17:47 |
juice | so I thought it would help to have a few embedded diagrams to help as reminders | 17:47 |
hub_cap | :D im all for more documentation, but it seems kinda distracting | 17:47 |
juice | ha ha ... well a class diagram would be better :) | 17:47 |
* hub_cap pukes | 17:47 | |
hub_cap | but srsly, its all good work | 17:47 |
ashestakov | vgnbkr: do you using "$DATASTORE_TYPE" == "percona" with fedora? | 17:47 |
hub_cap | just make it into s few small works of art ;) | 17:47 |
vgnbkr | ashestakov: no | 17:48 |
hub_cap | ashestakov: i think perc bkup is default for non perc installs too | 17:48 |
juice | when you have this pinwheel of instance, server and compute instance, it gets a little dizzyying when you have logic bouncing around between those classes | 17:48 |
*** Barker has quit IRC | 17:48 | |
juice | I am not married to the art work and it's easy to put abc in another patchset | 17:49 |
ashestakov | hub_cap: frdora-percona has script for repos https://github.com/openstack/trove-integration/blob/master/scripts/files/elements/fedora-percona/install.d/05-percona-server | 17:49 |
juice | would that ease your indigestion? | 17:49 |
hub_cap | juice: i think there was 3 things, right? | 17:49 |
ashestakov | but fedora-mysql hasnt | 17:49 |
juice | like you, I just want this chapter closed | 17:49 |
juice | let me look at what you wrote | 17:49 |
hub_cap | ashestakov: u dont need percona server for xtrabackup | 17:49 |
hub_cap | juice: so do i | 17:49 |
hub_cap | its my highest prio, to get the bug merged | 17:49 |
ashestakov | but you need repo to retrieve percona-xtrabackup | 17:50 |
juice | oh actually 2 | 17:50 |
hub_cap | i dont want to see our gate failing | 17:50 |
hub_cap | ashestakov: oh the repo is only put to percona on fedora?? | 17:50 |
hub_cap | i think thats in the base in ubuntu | 17:50 |
ashestakov | yes | 17:50 |
juice | um the using iss I did not change someone else must have before me | 17:50 |
hub_cap | boom vgnbkr bug found, fix it up | 17:50 |
hub_cap | thx ashestakov | 17:50 |
juice | but it looks there were a few missing pieces | 17:50 |
juice | so I can pull out abc into another patch and then there will be just two | 17:51 |
*** Barker has joined #openstack-trove | 17:53 | |
hub_cap | juice: link me the review plz | 17:56 |
*** demorris has joined #openstack-trove | 17:57 | |
juice | this one -> https://review.openstack.org/#/c/66063/ or something else? | 17:57 |
*** ashestakov has quit IRC | 18:00 | |
*** Ranjitha has joined #openstack-trove | 18:00 | |
hub_cap | ahh the _other_ one juice | 18:00 |
hub_cap | was that you fixed the service status to use a object everywehre instead of just a string | 18:01 |
hub_cap | using the ISS object | 18:01 |
hub_cap | that seems like it cuold be patch #1 | 18:01 |
hub_cap | err | 18:01 |
hub_cap | #2 | 18:01 |
SnowDust | hub_cap : https://review.openstack.org/#/c/64439 | 18:01 |
SnowDust | can we get this in now ? | 18:01 |
hub_cap | #1 = abc meta (doesnt touch anything) --- also somewhat contriversial(sp*) | 18:01 |
hub_cap | SnowDust: yea im not sure why no one has approved yet | 18:02 |
SnowDust | :) | 18:02 |
vgnbkr | hub_cap: happy to take a look. Can I submit my change for first-boot.d independently (without fedora working)? | 18:04 |
hub_cap | vgnbkr: yes | 18:04 |
hub_cap | well | 18:04 |
vipul | SnowDust: approved | 18:04 |
hub_cap | do u plan on doing the other one too? | 18:04 |
hub_cap | maybe make it the first review in a 2 review dependency (its just 2 separate commits in the same branch, wo diff gerrit ids) | 18:05 |
juice | is abc controversial | 18:05 |
hub_cap | HAHAHAHHAHHHAAHH | 18:05 |
vgnbkr | hub_cap: didn't you ask me to look at it? (did I misunderstand your comment above?) | 18:05 |
hub_cap | juice: my hilight highlighted controversial | 18:05 |
*** harlowja_away is now known as harlowja | 18:05 | |
hub_cap | cuz nTROVEr | 18:05 |
hub_cap | vgnbkr: not at all | 18:05 |
hub_cap | so push your first one | 18:05 |
juice | well I like it but I can remove it | 18:06 |
hub_cap | and if u get finished w/ #2 first, then make #2 the first in the patch set "Chain" | 18:06 |
hub_cap | ill help u w/ that | 18:06 |
juice | sounds good | 18:06 |
hub_cap | not u juice | 18:06 |
hub_cap | lol | 18:06 |
hub_cap | that was for vgnbkr | 18:06 |
hub_cap | there is no hope for u juice ;) | 18:06 |
hub_cap | so heres the deal w/ abc juice | 18:06 |
juice | there is a just enough to keep me going | 18:06 |
hub_cap | if u ask a non java python dev about it, they will puke | 18:07 |
hub_cap | id say make the abc completely independent | 18:07 |
juice | understood | 18:07 |
hub_cap | and make the patchset #2(string to ISS object)->#3(fix of the stupid timestamps) | 18:07 |
hub_cap | and feel free to submit the abc one | 18:07 |
juice | i know the pythonic way is to keep folks on their toes | 18:07 |
hub_cap | but u might also want to bring it up | 18:07 |
juice | should have been called rattlesnake | 18:07 |
hub_cap | juice: well done ;) | 18:07 |
hub_cap | lol, u get bit once and u DIE | 18:08 |
hub_cap | vipul: thx for the approve on that.. lol | 18:08 |
juice | in that case a slow and steady strangulation is more appropropriate :) | 18:08 |
hub_cap | :) | 18:11 |
juice | let me actually explain myself a bit further...I really do like the ease and lightness of python...I really do. On the other hand as a maintainer of someone else's python code, I find there are some conventions that cause a noticeable amount of mental overhead keeping track of usage vs. declaration | 18:15 |
juice | and thus anything that helps us as maintainers keep things clear and concise helps us to deliver higher quality code and in a shorter amount of time with greater ease | 18:15 |
hub_cap | im all about the abc's yo | 18:16 |
hub_cap | fwiw | 18:16 |
hub_cap | so is cweid | 18:16 |
juice | :) | 18:16 |
juice | I just wanted to put it out there so it didn't seem random | 18:17 |
hub_cap | juice: the fact that u put it out there was random | 18:17 |
hub_cap | HAHAH | 18:17 |
juice | oh man :) | 18:17 |
grapex | juice: I came close to introducing ABCs to Trove on a few features I did, but by the time I was done working I often found they weren't as good as what I wanted. | 18:18 |
grapex | I'm ok with them if you find a good use case. Not sure what the OpenStack Gods will say though. | 18:18 |
juice | the other part of it to is that i am in a relatively monogamous relationship with my IDE | 18:18 |
hub_cap | juice: arent we all | 18:19 |
juice | and it helps in many many cases catch shit that we leave laying around | 18:19 |
grapex | juice: Which one are you using? | 18:19 |
hub_cap | the real question, is, of course, is your IDE faithful to u? | 18:19 |
juice | PyCharms | 18:19 |
hub_cap | who wears the pants in the relationship? | 18:19 |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Makes the backup tests less onerous https://review.openstack.org/69429 | 18:19 |
grapex | juice: That's kind of cool if it helps identify tiny mistakes in PyCharm | 18:19 |
grapex | though I don't think we can do something that drastic just for IDE support. I like PyCharm a lot but still prefer Sublime | 18:20 |
juice | like most relationships it is a compromise but I keep coming back for the sugar | 18:20 |
grapex | juice: Disturbing! | 18:20 |
grapex | By the way guys | 18:20 |
juice | ahh grapex :) | 18:20 |
hub_cap | LOL juice grapex | 18:20 |
grapex | that pull review I just pushed out is almost nothing but it takes away a lot of pain of running these backup tests | 18:20 |
cp16net | you need some sugar for your juice? | 18:20 |
cp16net | lol | 18:21 |
grapex | I know this is the pot calling the kettle a tool for cooking food via heat but if you could look at it it wouldn't take more than a second. :D | 18:21 |
juice | weak cp16net :) | 18:21 |
*** jcooley_ has quit IRC | 18:22 | |
juice | but damn you are still the beast on guitar in rock band cp16net | 18:22 |
*** jcooley_ has joined #openstack-trove | 18:23 | |
cp16net | haha | 18:24 |
cp16net | only when i'm inebriated | 18:24 |
*** amcrn has quit IRC | 18:24 | |
*** amcrn_ has joined #openstack-trove | 18:25 | |
*** amcrn_ is now known as amcrn | 18:25 | |
*** thedodd has quit IRC | 18:26 | |
*** amcrn has quit IRC | 18:26 | |
*** ViswaV has quit IRC | 18:30 | |
*** ViswaV has joined #openstack-trove | 18:31 | |
SnowDust | anyone who can look into the zuul failure : https://jenkins02.openstack.org/job/gate-python-troveclient-pypy/156/console | 18:33 |
*** ViswaV has quit IRC | 18:33 | |
*** khyati has joined #openstack-trove | 18:36 | |
*** ViswaV has joined #openstack-trove | 18:37 | |
*** yogesh has joined #openstack-trove | 18:40 | |
*** ViswaV has quit IRC | 18:42 | |
*** igor has quit IRC | 18:46 | |
*** igor has joined #openstack-trove | 18:46 | |
*** ashestakov has joined #openstack-trove | 18:48 | |
*** amcrn has joined #openstack-trove | 18:49 | |
esp | @SnowDust you might try to ask someone in #openstack-infra | 18:50 |
SnowDust | esp: sure ! | 18:51 |
mat-lowery | I was looking into adding "secgroup per datastore" functionality and found this blueprint (https://blueprints.launchpad.net/trove/+spec/security-groups-workflow-update) and this patch set (https://review.openstack.org/#/c/50944/3/trove/taskmanager/models.py). Patch set is abandoned with dmakogon stating in inline comment that change will come with another patch set. Can anyone help me find the patch set to which he is referring? | 18:51 |
esp | @SnowDust were you able to run the tests locally? | 18:51 |
*** igor has quit IRC | 18:51 | |
*** yogesh has quit IRC | 18:51 | |
SnowDust | no didnt try .. | 18:51 |
SnowDust | i tried reasoning the console output itself :) but cryptic | 18:52 |
*** yogesh has joined #openstack-trove | 18:52 | |
*** ViswaV has joined #openstack-trove | 18:53 | |
*** SergeyLukjanov_ is now known as SergeyLukjanov | 18:53 | |
*** jmontemayor has joined #openstack-trove | 18:55 | |
*** yogesh has quit IRC | 18:55 | |
*** yogesh has joined #openstack-trove | 18:56 | |
*** thedodd has joined #openstack-trove | 19:00 | |
*** yogesh has quit IRC | 19:02 | |
*** yogesh has joined #openstack-trove | 19:11 | |
hub_cap | mat-lowery: hmph i can barely remember hehe | 19:12 |
hub_cap | denis_makogon: would know | 19:12 |
*** igor has joined #openstack-trove | 19:16 | |
mat-lowery | hub_cap: Thanks. Regarding the approach taken in the patch set (i.e. ports per datastore specified in conf), what's the reason to put it there vs. datastore_versions table? And does this patch need to exist at all with Heat, which can handle secgroups per datastore now? Or is this patch a stop-gap until Heat becomes the only way? Or will Heat and Nova-based provisioning co-exist indefinitely? Sorry, lots of questions. | 19:17 |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Makes the backup tests less onerous https://review.openstack.org/69429 | 19:24 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Adds _delete_resources to FreshInstanceTasks https://review.openstack.org/69450 | 19:37 |
*** SushilKM has joined #openstack-trove | 19:37 | |
*** SnowDust has quit IRC | 19:44 | |
*** mat-lowery has quit IRC | 19:46 | |
*** mat-lowery has joined #openstack-trove | 19:47 | |
*** SushilKM has quit IRC | 19:48 | |
*** SushilKM has joined #openstack-trove | 19:48 | |
*** kevinconway_ has joined #openstack-trove | 19:51 | |
*** kevinconway has quit IRC | 19:52 | |
*** kevinconway_ is now known as kevinconway | 19:52 | |
*** ViswaV has quit IRC | 19:54 | |
*** amcrn has quit IRC | 19:54 | |
*** SnowDust has joined #openstack-trove | 19:56 | |
hub_cap | hey mat-lowery sry was in a meeting | 19:57 |
hub_cap | so, they _will_ Coexist | 19:57 |
hub_cap | but we will deprecate the old way | 19:57 |
hub_cap | and eventualy remove it | 19:57 |
hub_cap | SWEET SEASON ONE OF THE MUPPET ShOW JUST GOT HeRE!!! | 19:58 |
hub_cap | so ther eis a really odd place where there is a disconnect between the 2 impls | 19:58 |
*** SushilKM has quit IRC | 19:58 | |
hub_cap | aka _in_ the yaml vs _in_ a config to turn on off | 19:58 |
*** yogesh has quit IRC | 19:59 | |
hub_cap | so ive tried to make us adhere to if its configurable from the operator perspective via a config | 19:59 |
hub_cap | that we keep that in the default heat template as well (for instance jinja if stmts to turh things like dns on/off) | 19:59 |
*** michael-yu has joined #openstack-trove | 20:00 | |
*** Barker has quit IRC | 20:02 | |
*** datsun180b has quit IRC | 20:03 | |
*** yogesh has joined #openstack-trove | 20:03 | |
*** jasonb365 has quit IRC | 20:05 | |
*** datsun180b has joined #openstack-trove | 20:05 | |
*** kevinconway has quit IRC | 20:05 | |
*** openstackgerrit has quit IRC | 20:06 | |
*** pdmars_ has joined #openstack-trove | 20:06 | |
*** openstackgerrit has joined #openstack-trove | 20:06 | |
*** pdmars_ has quit IRC | 20:06 | |
*** jcru_ has joined #openstack-trove | 20:06 | |
*** pdmars_ has joined #openstack-trove | 20:07 | |
*** kevinconway has joined #openstack-trove | 20:08 | |
*** jcru has quit IRC | 20:08 | |
*** pdmars has quit IRC | 20:09 | |
*** ViswaV has joined #openstack-trove | 20:12 | |
*** ViswaV_ has joined #openstack-trove | 20:13 | |
*** ViswaV has quit IRC | 20:13 | |
*** radez is now known as radez_g0n3 | 20:14 | |
*** SnowDust has quit IRC | 20:16 | |
*** Barker has joined #openstack-trove | 20:16 | |
*** datsun180b has quit IRC | 20:18 | |
*** jcooley_ has quit IRC | 20:22 | |
*** jcooley_ has joined #openstack-trove | 20:22 | |
mat-lowery | hub_cap: Thanks. The line between what goes in datastore_versions vs. conf is blurry to me. What is wrong with modifying trove-manage call to "trove-manage datastore_version_update myds myversion mymanager myimage mypackages myactive 3306". My goal is to understand the line between table and conf since, in this case, as raw nova-based provisioning will ultimately go away (and along with it any need for secgroup columns in a table) it makes | 20:27 |
mat-lowery | sense for this to be purely conf. | 20:27 |
*** jasonb365 has joined #openstack-trove | 20:28 | |
hub_cap | sure | 20:28 |
hub_cap | i dont think we have a good answer to whether its in one or the other | 20:28 |
hub_cap | the reason it wasnt in the db before was cuz we didnt have datastores yet :) | 20:28 |
mat-lowery | hub_cap: Gotcha. Thanks. | 20:29 |
hub_cap | so its possible it belongs here | 20:30 |
hub_cap | but we also want to make it user serviceable in the future | 20:30 |
*** datsun180b has joined #openstack-trove | 20:31 | |
mat-lowery | hub_cap: "user serviceable" as in the user that issues "trove create"? meaning they can specify secgroup during create? | 20:35 |
*** amcrn has joined #openstack-trove | 20:37 | |
*** datsun180b has quit IRC | 20:40 | |
*** jasonb365 has quit IRC | 20:40 | |
*** jasonb365 has joined #openstack-trove | 20:42 | |
*** SergeyLukjanov is now known as SergeyLukjanov_ | 20:44 | |
*** datsun180b has joined #openstack-trove | 20:45 | |
*** michael-yu has quit IRC | 20:48 | |
*** jcru_ has quit IRC | 21:01 | |
*** pdmars has joined #openstack-trove | 21:01 | |
*** jcru has joined #openstack-trove | 21:01 | |
*** datsun180b_ has joined #openstack-trove | 21:02 | |
*** tanisdl has quit IRC | 21:03 | |
*** datsun180b has quit IRC | 21:03 | |
*** pdmars_ has quit IRC | 21:03 | |
*** datsun180b_ is now known as datsun180b | 21:03 | |
hub_cap | yea im thinking cases wher internal policy dictate not running mysql on 3306 | 21:15 |
*** michael-yu has joined #openstack-trove | 21:17 | |
*** radez_g0n3 is now known as radez | 21:19 | |
*** ashestakov has quit IRC | 21:19 | |
mat-lowery | Is there a policy for new conf options (naming convention, default values, milestone placement)? On the flip side, when can options be modified (e.g., default value changed)? | 21:22 |
*** ViswaV_ has quit IRC | 21:22 | |
*** ViswaV has joined #openstack-trove | 21:24 | |
datsun180b | if you're adding a new one i don't know that there are any hard rules besides you'd better put a default in cfg.py | 21:27 |
datsun180b | most of it seems to be more convention than compulsion | 21:28 |
mat-lowery | Thanks datsun180b. | 21:34 |
amcrn | a few other i can think of: don't prefix it with "trove_" unless there's a good reason (because it's redundant), if you're defaulting in cfg.py don't put the same parameter + value in the sample.conf (it's redundant), and the name shouldn't use datastore-specific terminology | 21:39 |
mat-lowery | amcrn: Got it. Thanks. | 21:40 |
kevinconway | also, if it's related to a db connection you should find a unique name for it like everyone else did... | 21:40 |
kevinconway | db_connection, sql_connection, connect_db, db_db_db_go, are all taken | 21:40 |
mat-lowery | kevinconway: lol | 21:41 |
cp16net | amcrn: i think i got conf stuff fixed up finally | 21:50 |
amcrn | noiiiice. | 21:50 |
* cp16net hopes i addressed every issue | 21:51 | |
cp16net | i wrote all them down and slowly crossed them off my list. | 21:51 |
cp16net | i'm running int tests now | 21:51 |
*** freyes has quit IRC | 21:51 | |
cp16net | passed with just the subset of tests and i'm running blackbox now | 21:51 |
*** jcooley_ has quit IRC | 21:53 | |
*** jcooley_ has joined #openstack-trove | 21:53 | |
kevinconway | cp16net: i have an issue with config changes | 21:55 |
kevinconway | i need you to change everything | 21:55 |
amcrn | seem reasonable, i agree. | 21:56 |
datsun180b | cp16net: i don't have anything constructive but here's a way to replace two unrelated sections of eight lines apiece with a six-line lambda | 21:57 |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Changing DNS to pass string to driver https://review.openstack.org/69480 | 21:58 |
kevinconway | datsun180b: reminds me of some fun stack overflow answers related to "How do i make a multi-line lambda and assign it to a variable?" | 21:59 |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Changing DNS to pass string to driver https://review.openstack.org/69480 | 22:00 |
cp16net | kevinconway: i will kill you... | 22:02 |
*** jasonb365 has quit IRC | 22:03 | |
*** rnirmal has quit IRC | 22:05 | |
*** pdmars has quit IRC | 22:06 | |
hub_cap | grapex: ive got 1h 20m left on my battery.. that woudl put it at about 7h unplugged today | 22:09 |
grapex | nice | 22:09 |
*** ViswaV has quit IRC | 22:18 | |
*** ViswaV has joined #openstack-trove | 22:18 | |
*** datsun180b has quit IRC | 22:26 | |
esmute | Hey grapex, got a question regarding https://bugs.launchpad.net/trove/+bug/1273446 | 22:33 |
esmute | where do you see a function being passed? What i am seeing is a string being passed as the content. The string is the IP. | 22:34 |
esmute | https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L593 | 22:34 |
esmute | https://github.com/openstack/trove/blob/master/trove/dns/manager.py#L55 | 22:34 |
esmute | https://github.com/openstack/trove/blob/master/trove/instance/views.py#L29 | 22:35 |
*** datsun180b has joined #openstack-trove | 22:37 | |
grapex | Your first line, line 593 | 22:40 |
grapex | ip.pop is the built in list pop function | 22:40 |
grapex | So my experience is, I have to call content() to get to the string. | 22:40 |
grapex | esmute:^^ | 22:40 |
grapex | So, as it is today, get_ip_address returns a list | 22:41 |
grapex | Th taskmanager code then passes the "pop" function of that list to the DnsManager | 22:41 |
grapex | which in turn puts it onto the content attribute of DnsEntry | 22:41 |
grapex | So at Rax I had to modify the code to call the content field first and use the result of that call, which is a string. | 22:41 |
esmute | ahh its a bug.. | 22:41 |
grapex | I think it would make more sense to just pass a string in the first place | 22:42 |
esmute | i meant to pop the first element in the array | 22:42 |
esmute | ip[0] | 22:42 |
grapex | esmute: I figured. Good ole dynamic languages. :) I once spent two days because I used the old style exception syntax when I meant to capture one of two types of exceptions. | 22:42 |
esmute | but i was told that was not too pythonic :P... so i meant to do ip.pop() | 22:42 |
grapex | So looking at the code, I gave the instance a "get_dns_address" function. I figured it was too important not to have its own function. | 22:43 |
esmute | yeah. i like that... i also like the decoupling of get_ip_address() from the taskmanager | 22:45 |
esmute | Thanks for looking into it grapex | 22:48 |
grapex | esmute: Thank you esmute. | 22:48 |
grapex | At the risk of delaying my own pull request, I think I'm going to add an integration test and some docs as well. | 22:48 |
*** rnirmal has joined #openstack-trove | 22:50 | |
*** flaper87 is now known as flaper87|afk | 22:50 | |
*** igor__ has joined #openstack-trove | 22:56 | |
*** kevinconway has quit IRC | 22:57 | |
*** igor has quit IRC | 22:59 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 23:02 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: changes to support configuration groups https://review.openstack.org/58445 | 23:03 |
openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adds support for configurations management https://review.openstack.org/53169 | 23:04 |
cp16net | amcrn: so i think there was one issue with the migrations | 23:04 |
amcrn | ? | 23:05 |
cp16net | i noticed that 019_ failed until i removed the session stuff that modifies the database | 23:05 |
cp16net | i think that might need to be changed like i did with the datastore version migration | 23:05 |
vipul | cp16net: you mean the tox run failures? | 23:06 |
cp16net | ye | 23:06 |
vipul | i seem to be getting those too.. what's the fix? | 23:06 |
vipul | session.configure_db(CONF)? | 23:06 |
cp16net | i fixed it by commenting these lines out | 23:07 |
cp16net | https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/019_datastore_fix.py#L33-L63 | 23:07 |
cp16net | lol | 23:07 |
cp16net | but i think it needs to be setup more like what i did here https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/017_update_datastores.py#L23 | 23:07 |
cp16net | because it should not use a session | 23:08 |
amcrn | that lets you avoid the session.configure_db, yes | 23:08 |
cp16net | i think thats the problem | 23:08 |
cp16net | yea amcrn and i ran into something similar when we were testing the migration paths | 23:08 |
vipul | that one line shoudl just be removed, that should fix it no? | 23:09 |
cp16net | no | 23:09 |
cp16net | need to remove the DBInstance.find_all | 23:09 |
vipul | ah i see | 23:09 |
cp16net | or any of the DBDatastore calls | 23:09 |
cp16net | ust call directly to the database table names | 23:09 |
cp16net | i *think* that will fix it | 23:10 |
vipul | Yea it's a circular dependency if you use the actual model classes | 23:10 |
cp16net | yeah ok | 23:11 |
cp16net | that makes sense | 23:11 |
cp16net | vipul: so are you making a fix for it? | 23:20 |
*** yogesh has quit IRC | 23:21 | |
cp16net | i could work on it if not | 23:24 |
amcrn | esp: ping | 23:24 |
cp16net | because i think i will have to fix it for my review anyway | 23:24 |
esp | yo | 23:24 |
amcrn | wow, like lightning | 23:25 |
esp | lol | 23:25 |
esp | I'm not always sleeping you know... | 23:25 |
cp16net | i'm headed out | 23:25 |
amcrn | esp: regarding https://blueprints.launchpad.net/trove/+spec/create-route-for-list-availability-zones | 23:25 |
esp | cp16net: peace | 23:25 |
esp | ah, right.. | 23:25 |
* esp reading | 23:25 | |
esp | amcrn: so that bp reflects the correct status. | 23:26 |
esp | not started | 23:26 |
esp | the AZ is probably not important to RAX and other folks but we have 3 AZ's in our deployments | 23:27 |
amcrn | gotcha | 23:27 |
esp | the thought was that we should allow end users to choose which of the 3 AZ's to launch their instance in. | 23:27 |
esp | and since you can pretty name an AZ whatever you like, the customer wouldn't know what to specify unless we told them (via documentation or something) | 23:28 |
*** plodronio has quit IRC | 23:38 | |
*** esp has left #openstack-trove | 23:43 | |
*** thedodd has quit IRC | 23:45 | |
*** dmakogon_ has joined #openstack-trove | 23:46 | |
*** denis_makogon has quit IRC | 23:48 | |
*** radez is now known as radez_g0n3 | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!