Friday, 2014-03-28

« Thursday, 2014-03-27 Index Saturday, 2014-03-29 »
*** abramley has joined #openstack-trove00:00
*** yidclare has quit IRC00:24
*** Barker has joined #openstack-trove00:26
*** matsuhashi has joined #openstack-trove00:31
*** ViswaV has quit IRC00:36
*** sbfox has joined #openstack-trove00:49
*** sbfox has quit IRC00:58
*** amcrn has quit IRC01:26
*** eghobo has joined #openstack-trove01:27
*** ViswaV has joined #openstack-trove01:27
*** nosnos has joined #openstack-trove01:37
*** achampion has joined #openstack-trove01:40
*** khyati_ has quit IRC01:41
*** jasonb365 has joined #openstack-trove01:51
*** Barker has quit IRC01:51
openstackgerritNikhil Manchanda proposed a change to openstack/trove: Remove mockito, and replace with mock  https://review.openstack.org/8288801:57
*** ViswaV has quit IRC02:00
SlickNik^^Okay, got all the mockito => mock changes in this one. Please review when you guys have a chance.02:03
*** michael-yu has quit IRC02:05
*** jasonb365 has quit IRC02:07
*** michael-yu has joined #openstack-trove02:10
SlickNikAlso, thanks juice for helping out with this!02:12
*** ViswaV has joined #openstack-trove02:17
*** ViswaV has quit IRC02:30
hub_capwoot02:36
*** achampio1 has joined #openstack-trove02:59
*** eghobo has quit IRC03:01
*** achampion has quit IRC03:02
*** matsuhashi has quit IRC03:04
*** matsuhashi has joined #openstack-trove03:10
*** nosnos has quit IRC03:17
*** harlowja is now known as harlowja_away03:19
*** matsuhashi has quit IRC03:31
*** eghobo has joined #openstack-trove03:35
*** matsuhashi has joined #openstack-trove03:53
*** nosnos has joined #openstack-trove04:06
*** sbfox has joined #openstack-trove04:50
*** michael-yu has quit IRC04:54
juiceI let out a loud wailing cry each line I yanked out...05:09
*** esp has left #openstack-trove05:23
*** michael-yu has joined #openstack-trove06:04
openstackgerritJenkins proposed a change to openstack/trove: Imported Translations from Transifex  https://review.openstack.org/8272106:22
*** michael-yu has quit IRC06:26
*** eghobo has quit IRC06:27
*** michael-yu has joined #openstack-trove06:28
*** SushilKM has joined #openstack-trove06:37
*** saju_m has joined #openstack-trove06:38
*** denis_makogon has joined #openstack-trove06:39
*** matsuhashi has quit IRC07:20
*** michael-yu has quit IRC07:22
*** matsuhas_ has joined #openstack-trove07:24
*** haomaiw__ has quit IRC07:33
*** jamielennox has left #openstack-trove07:38
*** sbfox has quit IRC07:56
*** flaper87|afk is now known as flaper8708:05
*** matsuhas_ has quit IRC08:53
*** matsuhas_ has joined #openstack-trove08:57
*** IvanZ has joined #openstack-trove09:05
*** saju_m has quit IRC09:05
*** saju_m has joined #openstack-trove09:25
*** denis_makogon has quit IRC09:39
*** IvanZ has quit IRC09:59
*** matsuhas_ has quit IRC10:00
*** nosnos has quit IRC10:16
*** flaper87 is now known as flaper87|afk10:18
*** SushilKM has quit IRC10:22
*** SushilKM has joined #openstack-trove10:24
*** flaper87|afk is now known as flaper8710:42
*** SushilKM has quit IRC11:14
openstackgerritDenis M. proposed a change to openstack/trove: Support floating IP association at provisioning  https://review.openstack.org/4507511:27
*** saju_m has quit IRC11:50
*** saju_m has joined #openstack-trove11:53
*** saju_m has quit IRC11:57
*** saju_m has joined #openstack-trove12:07
*** pdmars has joined #openstack-trove12:15
*** pdmars has quit IRC12:16
*** pdmars_ has joined #openstack-trove12:16
*** pdmars_ has quit IRC12:17
*** pdmars has joined #openstack-trove12:17
*** saju_m has quit IRC12:18
*** saju_m has joined #openstack-trove12:21
*** pdmars has quit IRC12:22
*** pdmars has joined #openstack-trove12:22
*** saju_m has quit IRC12:32
*** saju_m has joined #openstack-trove12:34
*** saju_m has quit IRC12:42
*** saju_m has joined #openstack-trove12:44
*** radez_g0n3 is now known as radez12:46
*** saju_m has quit IRC12:49
*** saju_m has joined #openstack-trove12:51
*** grapex has joined #openstack-trove12:54
*** grapex has quit IRC12:55
*** grapex has joined #openstack-trove12:55
*** achampion has joined #openstack-trove12:58
*** achampio1 has quit IRC13:00
*** zigo has quit IRC13:13
*** zigo has joined #openstack-trove13:14
*** saju_m has quit IRC13:15
*** saju_m has joined #openstack-trove13:15
*** Barker has joined #openstack-trove13:16
*** mrsnivvel has quit IRC13:17
*** SushilKM has joined #openstack-trove13:21
*** zigo has quit IRC13:47
*** zigo has joined #openstack-trove13:47
*** zigo has quit IRC13:51
*** demorris has joined #openstack-trove13:54
*** zigo has joined #openstack-trove13:55
*** zigo has quit IRC13:59
*** zigo has joined #openstack-trove13:59
*** achampio1 has joined #openstack-trove14:01
*** achampion has quit IRC14:02
*** Barker has quit IRC14:04
*** kevinconway has joined #openstack-trove14:06
*** russellb is now known as rustlebee14:08
*** achampio1 has quit IRC14:12
*** robertmyers has joined #openstack-trove14:13
*** achampion has joined #openstack-trove14:13
*** robertmy_ has joined #openstack-trove14:14
*** robertmyers has quit IRC14:14
*** amytron has joined #openstack-trove14:19
*** openstack has joined #openstack-trove14:20
*** SushilKM has quit IRC14:28
*** achampio1 has joined #openstack-trove14:32
*** tanisdl has joined #openstack-trove14:32
*** achampion has quit IRC14:34
*** rwsu has quit IRC14:38
*** rwsu has joined #openstack-trove14:41
openstackgerritDenis M. proposed a change to openstack/trove: Fix create call for security group rules  https://review.openstack.org/8376814:41
*** michael-yu has joined #openstack-trove14:50
*** Barker has joined #openstack-trove14:52
openstackgerritDenis M. proposed a change to openstack/trove: Fix create call for security group rules  https://review.openstack.org/8376814:55
*** demorris has quit IRC15:00
*** jcru has joined #openstack-trove15:01
*** dmakogon_ is now known as denis_makogon15:04
denis_makogongrapex, hub_cap, amcrn, vipul, SlickNik , this patch is critical and should be merged in RC1 https://review.openstack.org/8376815:04
*** jasonb365 has joined #openstack-trove15:08
*** demorris has joined #openstack-trove15:08
*** jmontemayor has joined #openstack-trove15:13
*** jmontemayor has quit IRC15:14
*** jmontemayor has joined #openstack-trove15:14
*** michael-yu has quit IRC15:18
*** amytron has quit IRC15:31
*** amytron has joined #openstack-trove15:32
*** saju_m has quit IRC15:35
*** eghobo has joined #openstack-trove15:41
*** amytron_ has joined #openstack-trove15:41
*** amytron has quit IRC15:42
*** amytron_ is now known as amytron15:42
*** jasonb365 has quit IRC15:58
*** sbfox has joined #openstack-trove16:02
*** jasonb365 has joined #openstack-trove16:02
*** sbfox has quit IRC16:06
*** sbfox has joined #openstack-trove16:08
*** jmontemayor has quit IRC16:20
hub_capdenis_makogon: so we arent using the conf valiues anymore? is that a critical bug, or just someone missing adding to the conf file?16:22
cp16netthere should be defaults on the configs right?16:23
*** demorris has quit IRC16:24
hub_capright, id rather _not_ change functionality for this if its as simple as fixing the conf file16:27
hub_capnot changing it so that it now accepts willy nilly what a user sends16:27
cp16netyeah i see that as weel16:28
hub_capcuz i tried to change it like tha tbefore and, while i cant remember why, it got shot down16:28
hub_capweeeeeeel16:28
*** ViswaV has joined #openstack-trove16:31
*** ViswaV_ has joined #openstack-trove16:33
*** ViswaV has quit IRC16:33
*** radez is now known as radez_g0n316:37
*** sbfox has quit IRC16:40
*** sbfox has joined #openstack-trove16:42
*** mayfield has quit IRC16:51
*** mayfield has joined #openstack-trove16:52
*** achampion has joined #openstack-trove16:58
*** sbfox has quit IRC17:00
*** achampio1 has quit IRC17:00
*** achampion has quit IRC17:03
*** achampion has joined #openstack-trove17:03
*** khyati has joined #openstack-trove17:05
*** SnowDust has joined #openstack-trove17:06
*** demorris has joined #openstack-trove17:07
*** michael-yu has joined #openstack-trove17:11
*** harlowja_away is now known as harlowja17:15
*** demorris has quit IRC17:17
*** saju_m has joined #openstack-trove17:19
*** sbfox has joined #openstack-trove17:20
*** achampio1 has joined #openstack-trove17:21
*** achampion has quit IRC17:24
*** sbfox1 has joined #openstack-trove17:26
*** radez_g0n3 is now known as radez17:26
*** achampion has joined #openstack-trove17:26
*** achampio1 has quit IRC17:27
*** sbfox has quit IRC17:27
*** esp has joined #openstack-trove17:29
espit’s comic con in Seattle: https://s3.amazonaws.com/uploads.hipchat.com/8522/170510/U1F2UoWqa5vjx8I/IMG_0404.JPG17:31
*** ViswaV_ has quit IRC17:32
hub_capesp: are u dressed as batman?17:32
esphub_cap: no I’m on the left.17:32
espjust kidding17:32
espI didn’t realize the pic needed rotating (sorry about that)17:33
*** ViswaV has joined #openstack-trove17:33
*** ViswaV has quit IRC17:33
*** tanisdl has quit IRC17:34
hub_capheh esp17:34
*** saju_m has quit IRC17:35
*** saju_m has joined #openstack-trove17:35
*** sbfox1 has quit IRC17:36
SnowDustjun-0 comes before fools day ..fingers crossed17:37
esphehe17:38
*** ViswaV has joined #openstack-trove17:38
*** sbfox has joined #openstack-trove17:40
*** jmontemayor has joined #openstack-trove17:46
*** ViswaV has quit IRC17:47
*** ViswaV has joined #openstack-trove17:49
*** ViswaV has quit IRC17:49
*** ViswaV has joined #openstack-trove17:49
*** yogesh has joined #openstack-trove17:50
*** sbfox has quit IRC17:57
*** demorris has joined #openstack-trove17:57
*** sbfox has joined #openstack-trove18:01
*** achampion has quit IRC18:03
*** achampion has joined #openstack-trove18:03
*** achampion has quit IRC18:07
*** Barker has quit IRC18:12
*** Barker has joined #openstack-trove18:13
*** sbfox has quit IRC18:14
*** sbfox has joined #openstack-trove18:18
*** tanisdl has joined #openstack-trove18:21
*** sbfox has quit IRC18:21
*** sbfox has joined #openstack-trove18:32
*** achampion has joined #openstack-trove18:33
*** yogesh has quit IRC18:41
*** jmontemayor has quit IRC18:41
*** shakayumi has joined #openstack-trove18:44
*** openstackgerrit has quit IRC18:48
*** openstackgerrit has joined #openstack-trove18:48
*** sbfox has quit IRC18:48
*** yidclare has joined #openstack-trove18:51
*** achampio1 has joined #openstack-trove18:56
*** shakayumi has joined #openstack-trove18:58
*** shakayumi has quit IRC18:58
*** achampion has quit IRC18:59
*** harlowja is now known as harlowja_away19:00
*** jasonb365_ has joined #openstack-trove19:05
*** jasonb365 has quit IRC19:05
*** jasonb365_ is now known as jasonb36519:05
*** demorris has quit IRC19:10
*** denis_makogon_ has joined #openstack-trove19:15
*** denis_makogon has quit IRC19:16
*** denis_makogon_ is now known as denis_makogon19:16
denis_makogonhub_cap, ping19:16
*** dmakogon_ has joined #openstack-trove19:16
*** harlowja_away is now known as harlowja19:17
denis_makogonhub_cap, it's critical because it breaks the SG API19:18
denis_makogonhub_cap, so, it should be merged in RC119:19
hub_capwhat if u put the config value in denis_makogon19:19
hub_caplike it used to be19:19
hub_caprather than letting customer specify19:19
denis_makogonhub_cap, its not about config values19:19
denis_makogonhub_cap, you cannot add new rule because there's no such parameters (because they are deprecated and dropped)19:20
hub_capwe dropped / depreccated w/o fixing?19:20
denis_makogonhub_cap, if Trove still supports SG API then it should be fixed asap19:21
hub_capi understand that19:21
hub_capill talk to core19:21
denis_makogonhub_cap, thanks19:21
denis_makogonhub_cap, mat-lowery mentioned all sides of this problem19:21
denis_makogonin the bug report19:22
*** jasonb365_ has joined #openstack-trove19:23
*** jasonb365 has quit IRC19:23
*** jasonb365_ is now known as jasonb36519:23
*** achampion has joined #openstack-trove19:34
*** demorris has joined #openstack-trove19:35
*** achampio1 has quit IRC19:37
vipuldidn't we discuss not being able to allow the user to specify which ports they want opened?19:40
vipulwe said that each datastore should define which ports are allowed, and we'd only allow those19:40
vipulwe don't want the case where users can open 22 for example19:40
*** SnowDust has quit IRC19:41
openstackgerritNikhil Manchanda proposed a change to openstack/trove: Remove mockito, and replace with mock  https://review.openstack.org/8288819:45
SlickNikvipul / hub_cap: Agreed, I don't think we want the user to be able to specify the ports in the request body.19:47
denis_makogonvipul, SlickNik, it's the part of the security groups API19:51
denis_makogonvipul, SlickNik https://github.com/openstack/python-troveclient/blob/master/troveclient/v1/security_groups.py#L81-L8719:51
SlickNikdenis_makogon: can you show me what you mean by, it's part of the API? As far as I recall, the server never honored those values even though the client was sending them.19:52
denis_makogonSlickNik, already sent the link19:52
SlickNikdenis_makogon: I'd call that a bug in the client; we should probably fix the client to not allow those options.19:53
SlickNikthe only one allowed should be CIDR19:53
denis_makogonSlickNik, then why do we need sg API ??19:53
SlickNik(and trivially group_id, for identigication)19:53
SlickNikTo set the allowed CIDR19:53
*** sbfox has joined #openstack-trove19:53
vipuldenis_makogon: to control which source addresses can access it19:53
vipulnot to control which ports are opened19:53
denis_makogonvipul, so, you telling that cidr is only could be changed ?19:55
vipuldenis_makogon: Yes19:56
vipulTrove should determine which ports, and the datastore should tell Trove19:56
denis_makogonvipul, from that perspective - its wrong implementation of the SG API19:56
denis_makogonvipul, i mean the way its implemented is wrong19:57
vipulhow so19:57
vipulwhen i looked the patch.. it seemed that we picked the ports from CFG, and the CIDR from user request19:57
vipulseems like the way it should (with one datastore).. we do need to enhance it to get the port from datastore though19:58
denis_makogonthen client should be changed19:58
denis_makogonand it means that SG API should be changed19:59
vipulYea, i'd be fine with that.. I think we need to remove the ports from the API19:59
denis_makogonfor I release, we need to change only server side20:00
denis_makogonfor J release client should be changed20:00
SlickNikdenis_makogon: I don't see why the server side needs to be changed.20:01
denis_makogonSlickNik, its easy, now we have ports per datastore20:01
denis_makogonSlickNik, current code expects old values that were dropped long time ago20:02
denis_makogonSlickNik, take a look at cfg.py and you wouldn't find CONF.trove_security_group_rule_protocol and CONF.trove_security_group_rule_port20:03
denis_makogonSlickNik, they were dropped if favor of parameters per datastore20:03
SlickNikdenis_makogon: Ah, I see. You're saying this merge https://review.openstack.org/#/c/50944/ caused a regression.20:03
denis_makogonSlickNik, yes20:03
*** ViswaV has quit IRC20:05
vipulwell so can't we just use the tcp_ports per datastore manager20:05
*** michael-yu has quit IRC20:05
denis_makogonvipul, tcp and udp20:06
denis_makogonvipul, both should be changed20:06
denis_makogonvipul, agreed ?20:06
denis_makogonwould it be ok, if i submit the new patch at monday, i'm going to small trip to the place with no internet ?20:07
cp16neti'm curious how come this was not caught in the tests?20:09
*** jmontemayor has joined #openstack-trove20:09
*** ViswaV has joined #openstack-trove20:09
denis_makogoncp16net, me too20:09
cp16netif you are getting this error i would expect a new test to be added to verify this20:09
cp16neta test that would get the error and fix it20:10
*** jmontemayor has quit IRC20:10
denis_makogoncp16net, with new patch there would be no need in new test case20:10
denis_makogoncp16net, because API would be changed20:10
cp16netlooks like this test should have failed before20:10
cp16nethttps://github.com/openstack/trove/blob/master/trove/tests/api/instances.py#L82520:11
cp16netso the biggest question i have is why20:11
cp16netif that can be answered it may find another bug we have20:11
cp16net(maybe in the tests)20:11
cp16netwhich would be helpful to know20:11
*** metral has quit IRC20:15
SlickNikcp16net / denis_makogon: Yes, I'm really curious to know why that test didn't fail.20:15
*** achampio1 has joined #openstack-trove20:15
*** metral has joined #openstack-trove20:15
*** jmontemayor has joined #openstack-trove20:16
SlickNikBut we need to make sure we update the tests as well20:16
*** achampion has quit IRC20:18
*** sbfox has quit IRC20:18
*** demorris has quit IRC20:19
*** metral has quit IRC20:22
*** metral has joined #openstack-trove20:22
cp16netSlickNik: for sure20:22
*** metral has quit IRC20:22
*** metral has joined #openstack-trove20:23
*** metral has quit IRC20:26
*** metral has joined #openstack-trove20:26
*** metral has quit IRC20:28
*** metral has joined #openstack-trove20:28
*** demorris has joined #openstack-trove20:32
*** metral has quit IRC20:33
*** metral has joined #openstack-trove20:34
*** metral has quit IRC20:37
*** michael-yu has joined #openstack-trove20:43
*** metral has joined #openstack-trove20:48
*** ViswaV has quit IRC20:49
*** eguz has joined #openstack-trove20:52
*** metral has quit IRC20:54
*** demorris has quit IRC20:54
*** michael-yu has quit IRC20:55
*** eghobo has quit IRC20:56
*** michael-yu has joined #openstack-trove20:57
*** metral has joined #openstack-trove20:58
*** ViswaV has joined #openstack-trove20:58
*** cweid has quit IRC20:59
*** ViswaV_ has joined #openstack-trove20:59
*** ViswaV__ has joined #openstack-trove21:00
*** ViswaV_ has quit IRC21:00
*** metral has quit IRC21:02
*** ViswaV has quit IRC21:02
*** metral has joined #openstack-trove21:02
*** robertmy_ has quit IRC21:05
*** metral has quit IRC21:06
*** metral has joined #openstack-trove21:07
*** denis_makogon has quit IRC21:07
*** amcrn has joined #openstack-trove21:08
*** michael-yu has quit IRC21:16
*** metral has quit IRC21:18
*** Barker has quit IRC21:25
*** michael-yu has joined #openstack-trove21:25
*** jasonb365 has quit IRC21:31
*** cweid has joined #openstack-trove21:35
*** khyati has quit IRC21:36
*** Barker has joined #openstack-trove21:38
*** eguz has quit IRC21:39
*** khyati has joined #openstack-trove21:42
*** jmontemayor has quit IRC21:46
*** sbfox has joined #openstack-trove21:53
*** khyati has quit IRC21:54
*** amytron has quit IRC21:56
SlickNikcp16net : This is why the test didn't catch the issue - https://github.com/openstack/trove/blob/master/trove/tests/api/instances.py#L82621:58
cp16netOMG21:59
SlickNikIt got introduced here https://review.openstack.org/#/c/44056/20/trove/tests/api/instances.py21:59
cp16netthat is a fail SlickNik21:59
cp16netLOL21:59
SlickNikSince the default rule exists, that test has never been run after that patch merged.22:00
SlickNik*shakes his head*22:00
cp16netyeah i was wondering why the test was runing in 0.0 seconds...22:00
cp16netthat would make more sense22:00
cp16net*face palm*22:00
*** amytron has joined #openstack-trove22:01
*** pdmars has quit IRC22:02
SlickNikI don't understand this comment either (from the same patchset):22:04
SlickNik  # Security group already have default rule22:04
SlickNik  # that is why 'delete'-test is not needed anymore22:04
SlickNikAnd test_delete_security_group_rule was removed22:04
SlickNikdenis_makogon: can you clarify?22:06
SlickNikWe need to be more vigilant, and careful with reviews that remove / rewrite tests.22:07
SlickNikIt's probably not a good thing (in most cases) since it may 1. introduce a regression, or 2. change a previous contract that may have upgrade / compat implications.22:09
*** michael-yu has quit IRC22:10
*** eghobo has joined #openstack-trove22:13
*** eghobo has quit IRC22:13
*** eghobo has joined #openstack-trove22:13
espcp16net: :)22:15
*** khyati has joined #openstack-trove22:15
SlickNikAlso to clarify the last point, denis_makogon: imho delete_security_group_rule is part of the API, and we need to have tests for it, regardless of whether the sec-group has a default rule or not.22:16
*** Barker has quit IRC22:17
*** michael-yu has joined #openstack-trove22:23
cp16netSlickNik: +1 on watching changing tests...22:25
*** khyati has quit IRC22:26
*** tanisdl has quit IRC22:40
*** eguz has joined #openstack-trove22:48
openstackgerritDan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade  https://review.openstack.org/8141022:50
*** sbfox1 has joined #openstack-trove22:51
*** eghobo has quit IRC22:52
*** achampion has joined #openstack-trove22:52
*** sbfox has quit IRC22:54
*** achampio1 has quit IRC22:55
*** amytron has quit IRC22:56
*** grapex has quit IRC22:57
*** ViswaV__ has quit IRC22:59
openstackgerritDan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade  https://review.openstack.org/8141023:02
*** grapex has joined #openstack-trove23:02
* esp tests gerrit ^23:03
*** SlickNik is now known as gerrit23:06
*** gerrit is now known as Guest3549423:06
*** Guest35494 is now known as SlickNik23:07
*** grapex has quit IRC23:07
*** kevinconway has quit IRC23:11
*** tanisdl has joined #openstack-trove23:12
*** jcru has quit IRC23:13
*** yogesh has joined #openstack-trove23:15
*** michael-yu has quit IRC23:28
*** yogesh has quit IRC23:32
*** michael-yu has joined #openstack-trove23:40
« Thursday, 2014-03-27 Index Saturday, 2014-03-29 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!