| dougshelley66 | anyone know why i'm getting this when running redstack int-tests | 00:01 |
|---|---|---|
| dougshelley66 | raise DuplicateOptError(opt.name) | 00:01 |
| dougshelley66 | oslo.config.cfg.DuplicateOptError: duplicate option: periodic_interval | 00:01 |
| dougshelley66 | it happens immediately before any tests run | 00:01 |
| dougshelley66 | they were working fine earlier | 00:02 |
| dougshelley66 | ok strike that - just figured out i accidentally added an import to the test file... | 00:03 |
| dougshelley66 | sorry for the noise | 00:03 |
| *** NehaV has quit IRC | 00:04 | |
| *** michael-yu has quit IRC | 00:07 | |
| *** eghobo has joined #openstack-trove | 00:10 | |
| *** eghobo has quit IRC | 00:16 | |
| *** eghobo has joined #openstack-trove | 00:16 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 00:17 |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 00:17 |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Unmounting ephemeral if it has already been mounted https://review.openstack.org/81379 | 00:19 |
| *** matsuhashi has joined #openstack-trove | 00:23 | |
| *** mattgriffin has quit IRC | 00:28 | |
| *** orzel has joined #openstack-trove | 00:30 | |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM https://review.openstack.org/86242 | 00:31 |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM https://review.openstack.org/86242 | 00:35 |
| esp | dougshelley66: np | 00:41 |
| openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add neutron switch for ini tests https://review.openstack.org/87856 | 00:45 |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORK IN PROGRESS) https://review.openstack.org/88349 | 00:47 |
| *** mariusv has quit IRC | 01:11 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Trove guestagent should not use sample conf https://review.openstack.org/88478 | 01:11 |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 01:11 |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Clean up redstack to use SERVICE_HOST https://review.openstack.org/71128 | 01:11 |
| *** mariusv has joined #openstack-trove | 01:12 | |
| *** mariusv has joined #openstack-trove | 01:12 | |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Fixes tests so that it passes when run in a macbook https://review.openstack.org/88464 | 01:21 |
| *** nosnos has joined #openstack-trove | 01:24 | |
| *** mariusv has quit IRC | 01:37 | |
| *** mariusv has joined #openstack-trove | 01:37 | |
| *** mariusv has joined #openstack-trove | 01:37 | |
| fifieldt | SlickNik, I can confirm that | 01:38 |
| *** mariusv has quit IRC | 01:41 | |
| *** mariusv has joined #openstack-trove | 01:43 | |
| *** mariusv has joined #openstack-trove | 01:43 | |
| *** mariusv has quit IRC | 01:46 | |
| *** mariusv has joined #openstack-trove | 01:48 | |
| *** mariusv has joined #openstack-trove | 01:48 | |
| *** khyati_ has quit IRC | 01:49 | |
| *** mariusv has quit IRC | 01:54 | |
| *** mariusv has joined #openstack-trove | 01:54 | |
| *** mariusv has joined #openstack-trove | 01:54 | |
| *** mariusv has quit IRC | 01:55 | |
| *** mariusv has joined #openstack-trove | 01:56 | |
| *** mariusv has joined #openstack-trove | 01:56 | |
| *** haomaiw__ has joined #openstack-trove | 02:01 | |
| *** jmontemayor has quit IRC | 02:04 | |
| *** mariusv has quit IRC | 02:05 | |
| *** haomaiwang has quit IRC | 02:06 | |
| *** mariusv has joined #openstack-trove | 02:06 | |
| *** mariusv has joined #openstack-trove | 02:06 | |
| *** michael-yu has joined #openstack-trove | 02:06 | |
| *** mariusv has quit IRC | 02:07 | |
| *** mariusv has joined #openstack-trove | 02:07 | |
| *** mariusv has joined #openstack-trove | 02:07 | |
| *** haomaiw__ has quit IRC | 02:18 | |
| *** haomaiwa_ has joined #openstack-trove | 02:19 | |
| *** rwsu has quit IRC | 02:22 | |
| *** michael-yu has quit IRC | 02:22 | |
| *** michael-yu has joined #openstack-trove | 02:24 | |
| *** amcrn has quit IRC | 02:32 | |
| fifieldt | SlickNik, left some questions on your doc patch | 02:33 |
| *** mattgriffin has joined #openstack-trove | 02:38 | |
| SlickNik | fifieldt: Saw your questions. | 02:39 |
| SlickNik | fifieldt: It's been a long time since the openstack-common code in trove has been sync'ed with oslo, and consequently it's using a lot of the old style configs. | 02:41 |
| fifieldt | oh, unfortunate :) | 02:41 |
| SlickNik | fifieldt: I will need to double check the code-base, but the alternative confs ([database], and specifying the keystone auth info in the conf) didn't work for me. | 02:42 |
| fifieldt | I'm all for things that work :D | 02:42 |
| *** michael-yu has quit IRC | 02:43 | |
| SlickNik | fifieldt: This is something we will need to tackle, and be better about going forward (Juno++) | 02:43 |
| SlickNik | (i.e. staying closer in step with code in oslo) | 02:44 |
| fifieldt | by all means :) | 02:44 |
| fifieldt | I just noticed them because we had problems with all the other projects as well :D | 02:45 |
| fifieldt | so no stress | 02:45 |
| fifieldt | on your patch, I just noticed one little niggle | 02:46 |
| fifieldt | but it's a +2 from me otherwise | 02:46 |
| *** harlowja is now known as harlowja_away | 02:49 | |
| SlickNik | Cool, thanks for the explanation about the distros piece, btw. | 02:50 |
| SlickNik | That was helpful. :) | 02:50 |
| fifieldt | no problemo | 02:52 |
| fifieldt | confused the hell out of me initially :) | 02:53 |
| *** coolsvap|afk is now known as coolsvap | 02:58 | |
| *** mattgriffin has quit IRC | 03:02 | |
| *** eghobo has quit IRC | 03:06 | |
| *** matsuhashi has quit IRC | 03:09 | |
| *** matsuhashi has joined #openstack-trove | 03:09 | |
| *** matsuhashi has quit IRC | 03:09 | |
| *** yidclare has joined #openstack-trove | 03:16 | |
| *** mattgriffin has joined #openstack-trove | 03:17 | |
| *** nosnos has quit IRC | 03:19 | |
| *** michael-yu has joined #openstack-trove | 03:22 | |
| *** matsuhashi has joined #openstack-trove | 03:25 | |
| *** matsuhashi has quit IRC | 03:27 | |
| *** matsuhashi has joined #openstack-trove | 03:28 | |
| *** matsuhashi has quit IRC | 03:31 | |
| *** matsuhashi has joined #openstack-trove | 03:31 | |
| *** matsuhas_ has joined #openstack-trove | 03:34 | |
| *** matsuhashi has quit IRC | 03:35 | |
| *** rueb7363 has joined #openstack-trove | 03:36 | |
| *** lnxnut has quit IRC | 03:37 | |
| *** lnxnut has joined #openstack-trove | 03:39 | |
| *** razvanm has quit IRC | 03:44 | |
| *** matsuhas_ has quit IRC | 03:54 | |
| *** khyati has joined #openstack-trove | 03:55 | |
| *** matsuhashi has joined #openstack-trove | 03:57 | |
| *** eghobo has joined #openstack-trove | 03:58 | |
| *** michael-yu has quit IRC | 04:05 | |
| *** nosnos has joined #openstack-trove | 04:10 | |
| *** demorris has joined #openstack-trove | 04:12 | |
| *** lnxnut has quit IRC | 04:22 | |
| *** rueb7363 has quit IRC | 04:36 | |
| *** coolsvap is now known as coolsvap|afk | 04:39 | |
| *** michael-yu has joined #openstack-trove | 04:43 | |
| *** demorris has quit IRC | 04:45 | |
| *** michael-yu has quit IRC | 04:52 | |
| *** mattgriffin has quit IRC | 04:52 | |
| *** michael-yu has joined #openstack-trove | 04:54 | |
| *** michael-yu has quit IRC | 04:56 | |
| *** coolsvap|afk is now known as coolsvap | 04:58 | |
| *** michael-yu has joined #openstack-trove | 04:59 | |
| *** coolsvap is now known as coolsvap|afk | 05:05 | |
| *** michael-yu has quit IRC | 05:15 | |
| *** khyati has quit IRC | 05:20 | |
| *** SushillKM has joined #openstack-trove | 05:25 | |
| *** michael-yu has joined #openstack-trove | 05:40 | |
| *** michael-yu has quit IRC | 05:55 | |
| *** razvanm has joined #openstack-trove | 05:56 | |
| *** denis_makogon has joined #openstack-trove | 06:05 | |
| *** global_ has joined #openstack-trove | 06:17 | |
| *** global_ is now known as _shalini | 06:18 | |
| *** coolsvap|afk is now known as coolsvap | 06:18 | |
| *** michael-yu has joined #openstack-trove | 06:28 | |
| *** haomaiwa_ has quit IRC | 06:44 | |
| *** haomaiwang has joined #openstack-trove | 06:45 | |
| *** eghobo has quit IRC | 06:58 | |
| *** flaper87|afk is now known as flaper87 | 07:01 | |
| *** matsuhashi has quit IRC | 07:06 | |
| *** matsuhashi has joined #openstack-trove | 07:08 | |
| *** haomaiw__ has joined #openstack-trove | 07:26 | |
| *** haomaiwang has quit IRC | 07:29 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORK IN PROGRESS) https://review.openstack.org/88349 | 07:37 |
| *** michael-yu has quit IRC | 07:40 | |
| *** michael-yu has joined #openstack-trove | 07:48 | |
| *** michael-yu has quit IRC | 07:48 | |
| *** SushillKM has quit IRC | 07:50 | |
| *** razvanm has quit IRC | 07:54 | |
| *** razvanm has joined #openstack-trove | 07:58 | |
| *** razvanm has quit IRC | 08:03 | |
| *** razvanm has joined #openstack-trove | 08:08 | |
| *** sbfox has joined #openstack-trove | 08:15 | |
| openstackgerrit | A change was merged to openstack/trove-integration: Remove Prefix From Datastore Version Name https://review.openstack.org/88119 | 08:21 |
| *** denis_makogon has quit IRC | 08:22 | |
| *** sbfox has quit IRC | 09:01 | |
| *** sbfox has joined #openstack-trove | 09:01 | |
| *** sbfox has quit IRC | 09:12 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Update cassandra version from 2.0.5 to 2.0.6 https://review.openstack.org/83365 | 09:18 |
| openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Fix shell view for secgroup-list https://review.openstack.org/85314 | 09:49 |
| *** haomaiw__ has quit IRC | 10:06 | |
| *** haomaiwang has joined #openstack-trove | 10:07 | |
| *** haomaiw__ has joined #openstack-trove | 10:11 | |
| *** haomaiwang has quit IRC | 10:14 | |
| *** haomaiw__ has quit IRC | 10:37 | |
| *** haomaiwa_ has joined #openstack-trove | 10:38 | |
| *** haomai___ has joined #openstack-trove | 10:44 | |
| *** haomai___ has quit IRC | 10:45 | |
| *** haomaiw__ has joined #openstack-trove | 10:46 | |
| *** haomaiwa_ has quit IRC | 10:46 | |
| *** coolsvap is now known as coolsvap|afk | 10:50 | |
| *** shivamshukla has joined #openstack-trove | 10:57 | |
| *** nosnos has quit IRC | 11:01 | |
| *** matsuhashi has quit IRC | 11:12 | |
| *** matsuhashi has joined #openstack-trove | 11:14 | |
| *** nosnos has joined #openstack-trove | 11:26 | |
| *** nosnos has quit IRC | 11:29 | |
| *** shivamshukla has quit IRC | 11:31 | |
| *** matsuhashi has quit IRC | 11:32 | |
| *** matsuhashi has joined #openstack-trove | 11:32 | |
| *** matsuhashi has quit IRC | 11:38 | |
| *** SushillKM has joined #openstack-trove | 11:46 | |
| *** SushillKM has quit IRC | 11:51 | |
| *** _shalini has quit IRC | 11:55 | |
| *** lnxnut has joined #openstack-trove | 12:08 | |
| *** pdmars has joined #openstack-trove | 12:23 | |
| *** pdmars has quit IRC | 12:24 | |
| *** pdmars has joined #openstack-trove | 12:24 | |
| *** achampion has quit IRC | 12:35 | |
| *** demorris has joined #openstack-trove | 12:37 | |
| *** flaper87 is now known as flaper87|afk | 12:44 | |
| *** Raghav_ has quit IRC | 12:45 | |
| openstackgerrit | Daniel Salinas proposed a change to openstack/trove: Implement topology api https://review.openstack.org/87970 | 12:59 |
| *** demorris has quit IRC | 13:04 | |
| *** amytron has joined #openstack-trove | 13:05 | |
| *** amytron has quit IRC | 13:10 | |
| *** jcru has joined #openstack-trove | 13:12 | |
| *** achampion has joined #openstack-trove | 13:27 | |
| *** Barker has joined #openstack-trove | 13:36 | |
| *** NehaV has joined #openstack-trove | 13:44 | |
| *** grapex has joined #openstack-trove | 14:18 | |
| *** grapex has quit IRC | 14:20 | |
| *** grapex has joined #openstack-trove | 14:20 | |
| *** demorris has joined #openstack-trove | 14:23 | |
| *** amytron has joined #openstack-trove | 14:28 | |
| openstackgerrit | Doug Shelley proposed a change to openstack/trove: Disallow multiple configuration-attach https://review.openstack.org/88591 | 14:28 |
| *** jmontemayor has joined #openstack-trove | 14:28 | |
| dougshelley66 | cp16net: can you take a look at https://review.openstack.org/#/c/88591/ | 14:29 |
| *** jmontemayor has quit IRC | 14:29 | |
| *** jmontemayor has joined #openstack-trove | 14:30 | |
| *** kevinconway has joined #openstack-trove | 14:30 | |
| *** razvanm has quit IRC | 14:30 | |
| *** kevinconway has quit IRC | 14:30 | |
| *** kevinconway has joined #openstack-trove | 14:39 | |
| *** thedodd has joined #openstack-trove | 14:46 | |
| *** NehaV has quit IRC | 14:48 | |
| *** NehaV has joined #openstack-trove | 14:48 | |
| *** razvanm has joined #openstack-trove | 14:48 | |
| cp16net | hey dougshelley66 thanks for the review | 14:50 |
| cp16net | dougshelley66: you didnt follow the example i was talking about before? | 14:51 |
| dougshelley66 | cp16net np - looking forward to your comments | 14:51 |
| dougshelley66 | cp16net: i guess misunderstood; i was attempting to do what you described | 14:52 |
| cp16net | dougshelley66: let me try again... config1 assigned to instance and stays ACTIVE, then config1 is unassigned and instance goes to RESTART_REQUIRED | 14:52 |
| cp16net | dougshelley66: no restart is called on instance | 14:53 |
| cp16net | dougshelley66: and config2 is assigned to instance | 14:53 |
| dougshelley66 | cp16net: right that is what i thought i did. On detach, i set RESTART_REQUIRED | 14:53 |
| cp16net | i would expect the same behavior to accur again | 14:53 |
| dougshelley66 | cp16net: did i do that incorrectly? | 14:54 |
| dougshelley66 | cp16net: ah i see what you are saying | 14:54 |
| cp16net | ok | 14:54 |
| dougshelley66 | that i should detach config1 and put config2 on and set restart required | 14:54 |
| dougshelley66 | that wasn't what Florian expected during the bug discussion - unless i misunderstood that too :) | 14:55 |
| cp16net | dougshelley66: i'm saying that in that senario you will get the same results as you did before with both grps applied but still requiring a restart i thnk | 14:55 |
| cp16net | but i think after you restart it should be rectified | 14:55 |
| dougshelley66 | that is certainly true | 14:56 |
| cp16net | well i think he was expecting if it required a restart you cant do anything to the instance | 14:56 |
| cp16net | i'm not sure if we have validation on those api call for what state the instance is in | 14:57 |
| cp16net | i would think we do not | 14:57 |
| dougshelley66 | ok i guess i go back to the drawing board | 14:58 |
| dougshelley66 | i was attempting to clarify what i thougth the behaviour should be in my last comment on the bug, i will try to do that again | 14:58 |
| *** NehaV has left #openstack-trove | 15:01 | |
| cp16net | well its just hole in the way we do this.. | 15:02 |
| *** mattgriffin has joined #openstack-trove | 15:03 | |
| cp16net | i think we just need to add a check for the instance state on the configuration attach method | 15:03 |
| cp16net | that would prevent someone from getting into that same state that this bug is talking about | 15:04 |
| dougshelley66 | ok so if the instance is ACTIVE, we throw the exception on 2nd config attach? | 15:04 |
| cp16net | force somoene to unassigned config 1 and then restart their service and then allow config 2 to be attached | 15:04 |
| dougshelley66 | but if the instance is in RESTART_REQUIRED, we detach first and attach second? | 15:04 |
| dougshelley66 | are you saying we should not allow config attach when instance in RESTART_REQURIED? | 15:05 |
| cp16net | if the instance.status is not ACTIVE dont allow a config attach | 15:05 |
| dougshelley66 | ok i believe that makes sense to me | 15:07 |
| dougshelley66 | i will go put that in | 15:07 |
| dougshelley66 | cp16net: thx | 15:07 |
| *** dmakogon_ is now known as denis_makogon | 15:18 | |
| *** sbfox has joined #openstack-trove | 15:34 | |
| *** sbfox has quit IRC | 15:36 | |
| *** eghobo has joined #openstack-trove | 16:01 | |
| *** ViswaV has joined #openstack-trove | 16:03 | |
| *** ViswaV_ has joined #openstack-trove | 16:04 | |
| *** ViswaV has quit IRC | 16:07 | |
| *** shakamunyi has joined #openstack-trove | 16:18 | |
| mattgriffin | vipul, you around today? | 16:21 |
| esp | amcrn: ping | 16:32 |
| *** khyati has joined #openstack-trove | 16:47 | |
| *** harlowja_away is now known as harlowja | 16:58 | |
| *** razvanm has quit IRC | 17:10 | |
| openstackgerrit | Daniel Salinas proposed a change to openstack/python-troveclient: Add instance_metadata functionality to the trove python library https://review.openstack.org/82124 | 17:15 |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade https://review.openstack.org/81410 | 17:15 |
| *** michael-yu has joined #openstack-trove | 17:16 | |
| openstackgerrit | Daniel Salinas proposed a change to openstack/python-troveclient: Add instance_metadata functionality to the trove python library https://review.openstack.org/82124 | 17:27 |
| *** razvanm has joined #openstack-trove | 17:28 | |
| openstackgerrit | Steve Leon proposed a change to openstack/trove: Fixes tests so that they pass when run on OS X https://review.openstack.org/88464 | 17:40 |
| *** amcrn has joined #openstack-trove | 17:42 | |
| *** demorris has quit IRC | 17:48 | |
| *** yogesh has joined #openstack-trove | 17:54 | |
| *** eghobo has quit IRC | 17:55 | |
| *** eghobo has joined #openstack-trove | 17:56 | |
| *** mattgriffin is now known as mattgriffin-food | 18:12 | |
| *** denis_makogon_ has joined #openstack-trove | 18:21 | |
| *** saurabhs has joined #openstack-trove | 18:22 | |
| vipul | mattgriffin-food: yes | 18:28 |
| *** demorris has joined #openstack-trove | 18:32 | |
| *** dmakogon has joined #openstack-trove | 18:34 | |
| *** denis_makogon has quit IRC | 18:34 | |
| *** dmakogon is now known as denis_makogon | 18:34 | |
| *** dmakogon_ has joined #openstack-trove | 18:35 | |
| denis_makogon | what's up, guys? | 18:35 |
| *** achampion has quit IRC | 18:37 | |
| *** mattgriffin-food has quit IRC | 18:44 | |
| *** denis_makogon_ has quit IRC | 18:52 | |
| *** mattgriffin has joined #openstack-trove | 19:18 | |
| zigo | Could someone look into this issue? https://bugs.launchpad.net/trove/+bug/1302784 | 19:24 |
| zigo | I'm not sure I should upload trove to Sid because of it. | 19:25 |
| *** shakayumi has joined #openstack-trove | 19:26 | |
| *** shakamunyi has quit IRC | 19:27 | |
| denis_makogon | zigo, don't know whu it happens, need time to research, https://github.com/openstack/trove/blob/master/trove/tests/config.py#L78 | 19:29 |
| denis_makogon | but value seems vakid | 19:29 |
| denis_makogon | *valid | 19:29 |
| mattgriffin | vipul, just fyi that i submitted a few proposals.. also included some info on the upcoming xtrabackup 2.2 which could be cool in trove | 19:36 |
| *** ViswaV_ has quit IRC | 19:36 | |
| denis_makogon | mattgriffin, it means that we would need to control the version of the backup tool | 19:37 |
| denis_makogon | mattgriffin, something like that | 19:37 |
| denis_makogon | not so long ago we had a convo about backup tools and those versioning | 19:38 |
| mattgriffin | denis_makogon, interesting | 19:39 |
| mattgriffin | ok | 19:39 |
| denis_makogon | mattgriffin, about your proposals, do you really think that there's strong need to speakh about percona 5.6 as the part of the design sessions | 19:39 |
| denis_makogon | mattgriffin, for me it looks like a simple BP, nothing else | 19:40 |
| denis_makogon | mattgriffin, also, cluster package, i know that it's ready for replication, but we still far away from it | 19:40 |
| mattgriffin | denis_makogon, you're probably right. so there doesn't need to be a proposal for each BP? | 19:40 |
| denis_makogon | mattgriffin, at now, from trove perspective there's no reason between percona 5.6 and percona-cluster-5.6 | 19:41 |
| denis_makogon | mattgriffin, design sessions are organized for feature/roadmap discussions | 19:42 |
| denis_makogon | mattgriffin, adding support of another datastore is the sub-feature, that doesn't need session, it requires BP review | 19:42 |
| denis_makogon | mattgriffin, please tell me, how differs the process of the backuping/restoring in xtrabackup 2.1 and 2.2 ? | 19:43 |
| mattgriffin | denis_makogon, ack | 19:43 |
| mattgriffin | denis_makogon, the principal differences are captured http://summit.openstack.org/cfp/details/385 | 19:43 |
| mattgriffin | denis_makogon, our plan is not to create these features for 2.1 | 19:44 |
| *** amcrn has quit IRC | 19:44 | |
| denis_makogon | mattgriffin, at least now, we could just update package and that's all | 19:45 |
| denis_makogon | mattgriffin, because we're using only tight part of the functionality of the xtrabackup | 19:45 |
| mattgriffin | denis_makogon, a group from percona will be in ATL. let's chat about how percona might be able to extend that functionality of XB | 19:46 |
| denis_makogon | mattgriffin, first we need to think what do we need, and then decide what to offer to percona guys | 19:47 |
| denis_makogon | mattgriffin, at least now we're fully load, nothing comes to my mind | 19:48 |
| mattgriffin | denis_makogon, :) ok. perhaps add it to an upcoming meeting agenda? | 19:48 |
| denis_makogon | mattgriffin, of course you can do that | 19:48 |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade https://review.openstack.org/81410 | 19:49 |
| denis_makogon | mattgriffin, but (there's always 'but'), we need some topics to discuss | 19:49 |
| denis_makogon | mattgriffin, i guess you have several days to propose topic to discuss | 19:49 |
| mattgriffin | denis_makogon, always ;) gotcha | 19:49 |
| denis_makogon | mattgriffin, cool =) | 19:49 |
| denis_makogon | mattgriffin, are you going to be at ATL > | 19:49 |
| denis_makogon | ? | 19:49 |
| mattgriffin | denis_makogon, yeah. also brining one of our consultants w/ deep PXC experience so would like to chat about how we could help there for juno | 19:51 |
| denis_makogon | mattgriffin, i guess yes, but i'll need to improve my background =) | 19:52 |
| denis_makogon | mattgriffin, also, i'd like yo invite you at http://openstacksummitmay2014atlanta.sched.org/event/88ea50f1c8d83ebe5d8a4d11a2c36e42#.U1GCTnV_t2M | 19:52 |
| *** Barker has quit IRC | 19:54 | |
| mattgriffin | denis_makogon, sweet. i'm there | 19:54 |
| denis_makogon | mattgriffin, cool =) | 19:55 |
| denis_makogon | mattgriffin, again, about your proposal, i'd suggest you to file the BPs for all of them, according to the BP template | 19:59 |
| denis_makogon | mattgriffin, and we would be able to review them next Monday, i guess | 20:00 |
| mattgriffin | denis_makogon, ok. will do. where can i find the template? | 20:00 |
| denis_makogon | mattgriffin, https://wiki.openstack.org/wiki/TroveBlueprint | 20:01 |
| *** amcrn has joined #openstack-trove | 20:02 | |
| mattgriffin | denis_makogon, thanks. i'll leave comments in my proposals pointing to the BPs | 20:02 |
| denis_makogon | mattgriffin, cool, appreciate that | 20:03 |
| mattgriffin | np | 20:03 |
| *** ViswaV has joined #openstack-trove | 20:07 | |
| *** ViswaV_ has joined #openstack-trove | 20:07 | |
| *** razvanm has quit IRC | 20:08 | |
| *** ViswaV has quit IRC | 20:11 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Added route for Admin API to support guest upgrade https://review.openstack.org/81410 | 20:12 |
| *** yogesh has quit IRC | 20:14 | |
| *** ViswaV_ has quit IRC | 20:23 | |
| *** yogesh has joined #openstack-trove | 20:28 | |
| *** yogesh has quit IRC | 20:29 | |
| *** eguz has joined #openstack-trove | 20:32 | |
| *** eguz has quit IRC | 20:32 | |
| *** ViswaV has joined #openstack-trove | 20:35 | |
| *** eghobo has quit IRC | 20:35 | |
| *** yogesh has joined #openstack-trove | 20:37 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Add stack_id for future usage https://review.openstack.org/67873 | 20:37 |
| denis_makogon | SlickNik, ping | 20:39 |
| *** michael-yu has quit IRC | 20:41 | |
| *** harlowja is now known as harlowja_away | 20:50 | |
| *** yogesh has quit IRC | 20:54 | |
| *** ramashri has joined #openstack-trove | 20:54 | |
| *** yidclare has quit IRC | 20:58 | |
| SlickNik | denis_makogon: 'sup? | 21:06 |
| denis_makogon | SlickNik, can we discuss https://review.openstack.org/#/c/86300/ ? | 21:06 |
| SlickNik | denis_makogon: Sure. | 21:07 |
| denis_makogon | SlickNik, i addressed all your comments | 21:07 |
| denis_makogon | SlickNik, and given unit test totally emulates the described situation | 21:08 |
| SlickNik | denis_makogon: I'm concerned that unless we add an integration test, how do we know that the backup size check works end-to-end? | 21:10 |
| denis_makogon | SlickNik, unit | 21:10 |
| SlickNik | denis_makogon: Unit tests don't test end-to-end scenarios. | 21:11 |
| denis_makogon | SlickNik, patch based upon models manipulations | 21:11 |
| SlickNik | eg, the datastore security groups issue that we ran into a while ago would have been caught only by the integration test. | 21:12 |
| denis_makogon | because test was ignored | 21:12 |
| denis_makogon | due to check | 21:12 |
| SlickNik | Yes I'm talking about _if_ the check hadn't been ignored incorrectly. | 21:13 |
| denis_makogon | that check was in test | 21:14 |
| denis_makogon | not in actual code | 21:14 |
| SlickNik | denis_makogon: The issue was with the actual code, not the test. It was using CONF values that didn't exist IIRC. | 21:15 |
| denis_makogon | SlickNik, test was checking : if rules exists - no need to create news | 21:15 |
| SlickNik | denis_makogon: The point of the test was to test creation of a new rule. Anyways, let's not argue about that. | 21:17 |
| denis_makogon | so, int test is the show stopper, right ? | 21:17 |
| SlickNik | denis_makogon: All I'm saying is that if we're adding code to enable anything new, let's also make a change to the integration tests to test the new addition, so that it doesn't break our end-to-end scenarios. | 21:18 |
| SlickNik | Yes, I would like an int-test to be added for that patch. | 21:19 |
| denis_makogon | SlickNik, ok, but it'll increase gate time on 20-30 mins | 21:19 |
| *** jmontemayor has quit IRC | 21:21 | |
| *** yidclare has joined #openstack-trove | 21:21 | |
| SlickNik | Not sure what you mean by show-stopper, but imho we should add an int-test. | 21:21 |
| SlickNik | Or at least a fake mode test. | 21:22 |
| SlickNik | Something that's testing the scenario, and not just mocks. | 21:22 |
| esp | SlickNik: https://review.openstack.org/#/c/81557/ | 21:23 |
| esp | please ^ | 21:23 |
| esp | SlickNik: https://review.openstack.org/#/c/81410/ | 21:24 |
| esp | and this one too pls: https://review.openstack.org/#/c/81682/ | 21:24 |
| esp | SlickNik: thx! | 21:24 |
| denis_makogon | SlickNik, ok, i'll do it | 21:25 |
| SlickNik | esp: Yes, will take a look. Thank you! | 21:25 |
| esp | cool | 21:25 |
| *** saurabhs has quit IRC | 21:25 | |
| SlickNik | denis_makogon: Thanks! | 21:26 |
| *** razvanm has joined #openstack-trove | 21:28 | |
| *** saurabhs has joined #openstack-trove | 21:29 | |
| *** yogesh has joined #openstack-trove | 21:37 | |
| *** saurabhs has quit IRC | 21:40 | |
| *** michael-yu has joined #openstack-trove | 21:40 | |
| *** harlowja_away is now known as harlowja | 21:41 | |
| *** yogesh has quit IRC | 21:43 | |
| *** saurabhs has joined #openstack-trove | 21:45 | |
| *** denis_makogon has quit IRC | 21:47 | |
| *** grapex has quit IRC | 21:50 | |
| *** sriram_tesora has joined #openstack-trove | 21:52 | |
| openstackgerrit | Auston McReynolds proposed a change to openstack/trove-integration: (WIP DO NOT MERGE) Top Secret Shenanigans https://review.openstack.org/88701 | 21:56 |
| *** pdmars has quit IRC | 21:56 | |
| *** eghobo has joined #openstack-trove | 21:59 | |
| *** eghobo has quit IRC | 21:59 | |
| *** denis_makogon has joined #openstack-trove | 22:03 | |
| *** eghobo has joined #openstack-trove | 22:04 | |
| *** eghobo has quit IRC | 22:05 | |
| *** eghobo has joined #openstack-trove | 22:05 | |
| *** yogesh has joined #openstack-trove | 22:07 | |
| *** michael-yu has quit IRC | 22:07 | |
| *** demorris has quit IRC | 22:09 | |
| *** yogesh has quit IRC | 22:09 | |
| *** thedodd has quit IRC | 22:11 | |
| *** jcru has quit IRC | 22:11 | |
| *** yogesh has joined #openstack-trove | 22:17 | |
| *** denis_makogon has quit IRC | 22:20 | |
| *** ViswaV has quit IRC | 22:20 | |
| *** ViswaV has joined #openstack-trove | 22:22 | |
| openstackgerrit | A change was merged to openstack/trove: Added separate rate limit setting for mgmt POST https://review.openstack.org/81557 | 22:25 |
| *** sriram_tesora has quit IRC | 22:26 | |
| *** kevinconway has quit IRC | 22:27 | |
| *** amytron has quit IRC | 22:29 | |
| *** saurabhs has left #openstack-trove | 22:30 | |
| *** yogesh has quit IRC | 22:34 | |
| *** michael-yu has joined #openstack-trove | 22:37 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORK IN PROGRESS) https://review.openstack.org/88349 | 22:43 |
| *** sgotliv has joined #openstack-trove | 22:56 | |
| *** sgotliv has quit IRC | 22:57 | |
| esp | vipul: https://review.openstack.org/#/c/81410/ | 23:09 |
| esp | pls ^ | 23:09 |
| vipul | esp: did you get any clarification on cast_with_consumer vs cast() | 23:10 |
| esp | ah, right. hold off on that then. | 23:10 |
| vipul | we still have the update_guest() call in there.. | 23:10 |
| vipul | i can comment on the review again.. but i don't think we should be doing a cast_with_consumer | 23:10 |
| esp | k. let’s wait on that one | 23:11 |
| esp | how about https://review.openstack.org/#/c/81682/ ? | 23:12 |
| vipul | esp: does it make sense to add a deleted column to agent_heartbeats? | 23:14 |
| vipul | i can see that table grow quite rapidly.. | 23:15 |
| vipul | we seem to have a call that does a find_by_version() -- which will be painful when that table is large w/o a deleted filter | 23:15 |
| vipul | find_all_by_version | 23:15 |
| esp | sure, why not | 23:15 |
| esp | vipul: https://github.com/openstack/trove/blob/master/trove/extensions/mgmt/host/models.py#L85 | 23:16 |
| esp | this is where the other update_guest api call is used. | 23:17 |
| vipul | so i guess my question now is.. what's the difference between update_guest and upgrade | 23:18 |
| vipul | there isn't an implementation of either in the GuestAgent | 23:18 |
| esp | update_guest appears to be more about host info | 23:18 |
| esp | would it make more sense to draft up a bug or bp to rip it out if you think it is not being used? | 23:19 |
| openstackgerrit | Timothy He proposed a change to openstack/trove: added support of resize-flavor to Redis datastore https://review.openstack.org/88709 | 23:19 |
| *** mattgriffin has quit IRC | 23:20 | |
| vipul | sure, we can do that - i think a bug is fine. Just need someone from Rax (or people that have their own private guests) if there is a reason for that to exist | 23:20 |
| esp | yep | 23:20 |
| esp | would rather not break it if it’s used | 23:20 |
| esp | vipul: I think agent heartbeats might update an existing record | 23:24 |
| esp | rather than grow forever | 23:24 |
| vipul | esp: well i mean as we create / delete instances.. those deleted instance records won't get removed right | 23:24 |
| vipul | so at worst it will be the same size as the instances table | 23:25 |
| esp | yep | 23:25 |
| esp | we can still add a delete flag | 23:25 |
| esp | doesn’t matter to me | 23:25 |
| esp | and index | 23:25 |
| vipul | I think we should.. and we should mark the agent_heartbeat as deleted on an instance-delete | 23:26 |
| vipul | in the find_all call you have.. maybe only find the non-deleted ones | 23:26 |
| vipul | which also brings up what about existing instances :) | 23:26 |
| esp | do the heartbeats need to be enabled somewhere | 23:27 |
| esp | I don’t see any records in the table | 23:27 |
| vipul | do we just assume that as heartbeats arrive.. records will get inserted as needed.. versus doing an update on existing records | 23:27 |
| vipul | esp: it's not used by anything today | 23:27 |
| esp | lol | 23:27 |
| vipul | the table exists.. but nothing writes to it | 23:27 |
| esp | I thought conductor did. hmm.. | 23:27 |
| esp | ok | 23:27 |
| vipul | it writes to service_status | 23:28 |
| esp | k | 23:28 |
| vipul | esp: so i don't know if you've already written the code taht updates that table.. but somehow we'll have to insert a record when a heartbeat arrives for the first time | 23:30 |
| vipul | or do an update if it's the N'th heartbeat | 23:30 |
| esp | https://review.openstack.org/#/c/85225/12/trove/guestagent/datastore/mysql/service.py | 23:31 |
| esp | https://github.com/openstack/trove/blob/master/trove/guestagent/datastore/service.py#L113 | 23:35 |
| esp | https://review.openstack.org/#/c/85225/12/trove/guestagent/datastore/service.py | 23:36 |
| vipul | Ok so the issue i see with using set_status here is that it will not actually write to agent_heartbeats | 23:36 |
| vipul | some conductor code will need to be changed to make that happen | 23:36 |
| esp | k | 23:36 |
| esp | so I’ll take a look at conductor and see what needs to happen | 23:37 |
| vipul | https://github.com/openstack/trove/blob/master/trove/conductor/manager.py#L78 | 23:37 |
| *** ramashri has quit IRC | 23:37 | |
| vipul | it only updates service_status today | 23:37 |
| openstackgerrit | Timothy He proposed a change to openstack/trove: Added support of resize-flavor to Redis datastore trove resize-flavor was not supported for Redis If this command is indeeded invoked, then the DB VM would be stuck at the RESIZE state forever, as the revert function (reset_configuration) is not implement https://review.openstack.org/88709 | 23:38 |
| esp | vipul: yep | 23:38 |
| esp | if payload.get('service_status') is not None: | 23:38 |
| esp | status.set_status(ServiceStatus.from_description( | 23:38 |
| esp | payload['service_status'])) | 23:38 |
| esp | status.save() | 23:38 |
| esp | https://github.com/openstack/trove/blob/master/trove/conductor/manager.py#L75 | 23:38 |
| esp | I’ll make a not to add that to the current review | 23:38 |
| *** eghobo has quit IRC | 23:39 | |
| openstackgerrit | Timothy He proposed a change to openstack/trove: Added support of resize-flavor to Redis datastore https://review.openstack.org/88709 | 23:41 |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 23:46 |
| *** ViswaV has quit IRC | 23:46 | |
| *** orzel has left #openstack-trove | 23:56 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 23:57 |
| *** khyati has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!