| *** lnxnut has quit IRC | 00:12 | |
| *** Barker has joined #openstack-trove | 00:13 | |
| *** matsuhashi has joined #openstack-trove | 00:30 | |
| *** freyes has joined #openstack-trove | 00:31 | |
| *** freyes has quit IRC | 00:36 | |
| *** freyes has joined #openstack-trove | 00:48 | |
| *** matsuhashi has quit IRC | 00:52 | |
| *** matsuhashi has joined #openstack-trove | 00:58 | |
| *** nosnos has joined #openstack-trove | 01:00 | |
| *** Barker has quit IRC | 01:01 | |
| *** ViswaV has joined #openstack-trove | 01:02 | |
| *** ViswaV has quit IRC | 01:12 | |
| *** freyes has quit IRC | 01:23 | |
| *** erkules_ has joined #openstack-trove | 01:32 | |
| *** yidclare has joined #openstack-trove | 01:32 | |
| *** erkules has quit IRC | 01:34 | |
| *** razvanm has quit IRC | 01:59 | |
| *** ViswaV has joined #openstack-trove | 01:59 | |
| *** ViswaV_ has joined #openstack-trove | 02:00 | |
| *** ViswaV has quit IRC | 02:04 | |
| openstackgerrit | Yongli He proposed a change to openstack/trove: Apply six for metaclass https://review.openstack.org/73136 | 02:04 |
|---|---|---|
| *** haomaiwang has quit IRC | 02:07 | |
| *** haomaiwang has joined #openstack-trove | 02:07 | |
| openstackgerrit | Yongli He proposed a change to openstack/trove: Use six.StringIO/BytesIO instead of StringIO.StringIO https://review.openstack.org/73911 | 02:20 |
| *** demorris has joined #openstack-trove | 02:22 | |
| *** eghobo has joined #openstack-trove | 02:51 | |
| *** demorris has quit IRC | 03:01 | |
| *** coolsvap|afk is now known as coolsvap | 03:09 | |
| *** eghobo has quit IRC | 03:15 | |
| *** ViswaV_ has quit IRC | 03:23 | |
| *** matsuhashi has quit IRC | 03:32 | |
| *** matsuhashi has joined #openstack-trove | 03:32 | |
| *** matsuhashi has quit IRC | 03:37 | |
| *** nosnos has quit IRC | 03:46 | |
| *** eghobo has joined #openstack-trove | 04:03 | |
| *** michael-yu has joined #openstack-trove | 04:04 | |
| *** michael-yu has quit IRC | 04:16 | |
| *** razvanm has joined #openstack-trove | 04:19 | |
| *** nosnos has joined #openstack-trove | 04:28 | |
| *** matsuhashi has joined #openstack-trove | 04:29 | |
| *** michael-yu has joined #openstack-trove | 05:45 | |
| *** michael-yu has quit IRC | 05:46 | |
| *** nosnos_ has joined #openstack-trove | 05:51 | |
| *** nosnos has quit IRC | 05:54 | |
| *** matsuhashi has quit IRC | 05:59 | |
| *** matsuhashi has joined #openstack-trove | 06:00 | |
| *** nosnos has joined #openstack-trove | 06:32 | |
| *** matsuhashi has quit IRC | 06:32 | |
| *** nosnos_ has quit IRC | 06:32 | |
| *** matsuhashi has joined #openstack-trove | 06:34 | |
| *** razvanm has quit IRC | 06:38 | |
| *** shivam has joined #openstack-trove | 06:43 | |
| *** haomai___ has joined #openstack-trove | 06:44 | |
| *** haomaiwang has quit IRC | 06:48 | |
| *** eghobo has quit IRC | 07:05 | |
| *** michael-yu has joined #openstack-trove | 07:14 | |
| *** haomaiwa_ has joined #openstack-trove | 07:21 | |
| *** haomai___ has quit IRC | 07:21 | |
| *** ViswaV has joined #openstack-trove | 07:24 | |
| *** ViswaV has quit IRC | 07:28 | |
| *** michael-yu has quit IRC | 07:46 | |
| *** michael-yu has joined #openstack-trove | 07:48 | |
| *** michael-yu has quit IRC | 08:15 | |
| *** denis_makogon has joined #openstack-trove | 09:18 | |
| *** ramishra has joined #openstack-trove | 09:26 | |
| *** matsuhashi has quit IRC | 09:48 | |
| *** matsuhashi has joined #openstack-trove | 09:54 | |
| *** haomaiwa_ has quit IRC | 09:55 | |
| *** haomaiwang has joined #openstack-trove | 09:56 | |
| *** coolsvap is now known as coolsvap|afk | 10:03 | |
| *** denis_makogon has quit IRC | 10:16 | |
| *** shivam has quit IRC | 10:20 | |
| *** demorris has joined #openstack-trove | 10:23 | |
| *** demorris has quit IRC | 10:51 | |
| *** freyes has joined #openstack-trove | 11:08 | |
| *** matsuhashi has quit IRC | 11:22 | |
| *** freyes has quit IRC | 11:26 | |
| *** matsuhashi has joined #openstack-trove | 11:30 | |
| *** matsuhashi has quit IRC | 11:48 | |
| *** matsuhashi has joined #openstack-trove | 11:49 | |
| *** achampio1 has joined #openstack-trove | 12:22 | |
| *** achampion has quit IRC | 12:22 | |
| *** ramishra has quit IRC | 12:40 | |
| *** matsuhashi has quit IRC | 12:42 | |
| *** matsuhashi has joined #openstack-trove | 12:44 | |
| *** matsuhashi has quit IRC | 12:51 | |
| *** casanch1 has joined #openstack-trove | 12:59 | |
| *** demorris has joined #openstack-trove | 13:02 | |
| *** ramishra has joined #openstack-trove | 13:06 | |
| *** matsuhashi has joined #openstack-trove | 13:06 | |
| *** matsuhashi has quit IRC | 13:12 | |
| *** matsuhashi has joined #openstack-trove | 13:21 | |
| *** ramishra has quit IRC | 13:39 | |
| imsplitbit | hey guys | 13:44 |
| imsplitbit | the python troveclient metadata patch is failing because someone overwrote json.dumps with a static value and didn't replace it at the end of their test | 13:44 |
| imsplitbit | just wanted to remind everyone that when you replace things for purposes of a test with mocks it's best to store the original in a variable and put it back the way you found it at the end of the test | 13:45 |
| imsplitbit | so as not to affect other peoples tests | 13:45 |
| *** Barker has joined #openstack-trove | 13:46 | |
| openstackgerrit | Daniel Salinas proposed a change to openstack/python-troveclient: Add instance_metadata functionality to the trove python library https://review.openstack.org/82124 | 13:47 |
| imsplitbit | I've patched the problem that was affecting the python troveclient metadata patch and resubmitted | 13:48 |
| imsplitbit | please review and bless if you deem it worthy | 13:48 |
| *** robertmyers has joined #openstack-trove | 13:49 | |
| *** erkules_ is now known as erkules | 13:51 | |
| *** grapex has joined #openstack-trove | 13:53 | |
| *** nosnos has quit IRC | 13:53 | |
| *** kevinconway has joined #openstack-trove | 13:55 | |
| *** kevinconway has quit IRC | 13:56 | |
| *** kevinconway has joined #openstack-trove | 14:03 | |
| *** freyes has joined #openstack-trove | 14:06 | |
| *** rwsu has joined #openstack-trove | 14:11 | |
| *** thedodd has joined #openstack-trove | 14:11 | |
| *** doddstack has joined #openstack-trove | 14:14 | |
| *** doddstack has quit IRC | 14:14 | |
| *** doddstack has joined #openstack-trove | 14:14 | |
| *** doddstack has joined #openstack-trove | 14:15 | |
| *** doddstack has quit IRC | 14:16 | |
| *** matsuhashi has quit IRC | 14:17 | |
| *** thedodd has quit IRC | 14:17 | |
| *** ramishra has joined #openstack-trove | 14:21 | |
| *** grapex has quit IRC | 14:24 | |
| *** grapex has joined #openstack-trove | 14:25 | |
| *** jcru has joined #openstack-trove | 14:28 | |
| *** jasonb365 has joined #openstack-trove | 14:28 | |
| *** Barker has quit IRC | 14:46 | |
| *** grapex has quit IRC | 14:55 | |
| *** grapex has joined #openstack-trove | 14:56 | |
| *** jasonb365 has quit IRC | 15:03 | |
| *** ViswaV has joined #openstack-trove | 15:16 | |
| *** rueb7363 has joined #openstack-trove | 15:19 | |
| *** ViswaV_ has joined #openstack-trove | 15:20 | |
| *** ViswaV has quit IRC | 15:22 | |
| *** mattgriffin has joined #openstack-trove | 15:23 | |
| openstackgerrit | Viswa Vutharkar proposed a change to openstack/trove: Adds backup/restore support for mongodb https://review.openstack.org/78339 | 15:24 |
| *** achampio1 has quit IRC | 15:32 | |
| *** achampion has joined #openstack-trove | 15:33 | |
| openstackgerrit | Viswa Vutharkar proposed a change to openstack/trove: Adds backup/restore support for mongodb https://review.openstack.org/78339 | 15:37 |
| *** freyes has quit IRC | 15:51 | |
| *** jmontemayor has joined #openstack-trove | 16:00 | |
| *** jmontemayor has quit IRC | 16:01 | |
| *** jmontemayor has joined #openstack-trove | 16:01 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Resolves volume resize issue https://review.openstack.org/80315 | 16:02 |
| *** ViswaV_ has quit IRC | 16:03 | |
| *** SushillKM has joined #openstack-trove | 16:06 | |
| *** michael-yu has joined #openstack-trove | 16:06 | |
| *** michael-yu has quit IRC | 16:12 | |
| *** michael-yu has joined #openstack-trove | 16:17 | |
| *** michael-yu has quit IRC | 16:17 | |
| *** coolsvap|afk is now known as coolsvap | 16:20 | |
| *** achampion has quit IRC | 16:20 | |
| *** achampion has joined #openstack-trove | 16:21 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Resolves volume resize issue https://review.openstack.org/80315 | 16:21 |
| *** achampion has quit IRC | 16:22 | |
| SlickNik | You forgot to take out the sudo | 16:23 |
| SushillKM | oooops | 16:23 |
| SlickNik | ^ SushillKM | 16:23 |
| SushillKM | my bad | 16:23 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Resolves volume resize issue https://review.openstack.org/80315 | 16:24 |
| ramishra | Hi All, can someone point me to trove-guestagent package for fedora or any images with trove-guestagent installed? | 16:25 |
| SlickNik | ramishra: Trove doesn't provide images that are pre-built. | 16:26 |
| SlickNik | ramishra: we have diskimage-builder elements that you can use with tripleo/diskimage-builder to build your own image, though. | 16:27 |
| SlickNik | ramishra: The image elements can be found in the trove-integration repository. | 16:28 |
| ramishra | SlickNick: Thanks...Was looking for shortcut;) | 16:28 |
| SlickNik | ramishra: The fedora dib elements for mysql can be found at: https://github.com/openstack/trove-integration/tree/master/scripts/files/elements/fedora-guest | 16:28 |
| *** ViswaV has joined #openstack-trove | 16:29 | |
| *** achampion has joined #openstack-trove | 16:32 | |
| *** sbfox has joined #openstack-trove | 16:33 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects spelling typos https://review.openstack.org/69383 | 16:40 |
| *** harlowja_away is now known as harlowja | 16:48 | |
| *** amcrn has joined #openstack-trove | 16:49 | |
| *** SushillKM has quit IRC | 16:53 | |
| *** michael-yu has joined #openstack-trove | 16:59 | |
| *** jmontemayor has quit IRC | 17:07 | |
| *** saurabhs has joined #openstack-trove | 17:08 | |
| *** sbfox has quit IRC | 17:09 | |
| *** michael-yu has quit IRC | 17:13 | |
| *** jmontemayor has joined #openstack-trove | 17:14 | |
| *** demorris has quit IRC | 17:14 | |
| *** jmontemayor has quit IRC | 17:14 | |
| *** demorris has joined #openstack-trove | 17:14 | |
| *** SushillKM has joined #openstack-trove | 17:15 | |
| *** michael-yu has joined #openstack-trove | 17:21 | |
| *** SushillKM has quit IRC | 17:22 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 17:22 |
| *** esp has joined #openstack-trove | 17:23 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 17:27 |
| imsplitbit | SlickNik: hey how do I fix the reddwarf failure on the python-troveclient patch? | 17:36 |
| imsplitbit | provisioning failed | 17:36 |
| SlickNik | imsplitbit: one sec, looking at the patch. | 17:36 |
| SlickNik | imsplitbit: looks like it had a download failure downloading updates from the ubuntu apt repo. | 17:39 |
| imsplitbit | yeah | 17:39 |
| imsplitbit | do I just submit a review with "recheck"? I thought that was for jenkins | 17:39 |
| SlickNik | imsplitbit: If you login to that jenkins box (launchpad creds) you should see an option on the left that says "retrigger" | 17:39 |
| imsplitbit | sorry its been a while for me | 17:39 |
| imsplitbit | ahhh | 17:39 |
| SlickNik | imsplitbit: No worries. | 17:39 |
| imsplitbit | gotcha | 17:39 |
| imsplitbit | I'll kick it off again | 17:40 |
| SlickNik | Sweet; let me know if you're not seeing the option. | 17:41 |
| *** eghobo has joined #openstack-trove | 17:43 | |
| imsplitbit | I wasn't but my login didn't pre-check trove membership. I logged out and rechecked it and now it worked | 17:47 |
| imsplitbit | retriggered. | 17:47 |
| imsplitbit | waiting for next execture | 17:47 |
| imsplitbit | sp | 17:47 |
| imsplitbit | it was failing jenkins tests because someone overwrote json.dumps and didn't put it back | 17:48 |
| imsplitbit | got all that patched up | 17:48 |
| SlickNik | Yup, I saw that. Thanks for fixing that. | 17:49 |
| SlickNik | Heads up folks. BP meeting in a few minutes. | 17:55 |
| SlickNik | #startmeeting BP-review | 17:58 |
| openstack | Meeting started Mon Apr 21 17:58:18 2014 UTC and is due to finish in 60 minutes. The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:58 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:58 |
| openstack | The meeting name has been set to 'bp_review' | 17:58 |
| SlickNik | #undo | 17:58 |
| amrith | SlickNik, ready when you are | 17:58 |
| SlickNik | #endmeeting | 17:59 |
| openstack | Meeting ended Mon Apr 21 17:59:23 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/bp_review/2014/bp_review.2014-04-21-17.58.html | 17:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/bp_review/2014/bp_review.2014-04-21-17.58.txt | 17:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/bp_review/2014/bp_review.2014-04-21-17.58.log.html | 17:59 |
| SlickNik | #startmeeting trove-bp-review | 17:59 |
| openstack | Meeting started Mon Apr 21 17:59:40 2014 UTC and is due to finish in 60 minutes. The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot. | 17:59 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 17:59 |
| openstack | The meeting name has been set to 'trove_bp_review' | 17:59 |
| SlickNik | okay, that's better. | 17:59 |
| SlickNik | amrith: Let's give folks a couple of minutes to trickle in | 18:00 |
| kevinconway | #topic do permissions work right on this thing? | 18:01 |
| kevinconway | darn | 18:01 |
| SlickNik | #link https://wiki.openstack.org/wiki/Meetings/TroveMeeting | 18:01 |
| *** ramishra has quit IRC | 18:02 | |
| SlickNik | kevinconway: I think only the person who started the meeting can change the topic. | 18:02 |
| esmute | kevinconway: Yeah permission is working.. i just did a /kick kevinconway and you are still here | 18:03 |
| *** sbfox has joined #openstack-trove | 18:03 | |
| SlickNik | #topic: Unify common code in guest agent configurations | 18:03 |
| SlickNik | #topic Unify common code in guest agent configurations | 18:03 |
| SlickNik | maybe not? | 18:03 |
| amrith | I'll take that as my cue | 18:03 |
| amrith | so, SnowDust and I put this thing together | 18:04 |
| amrith | subsequently, it appears that hub_cap has made some changes | 18:04 |
| amrith | and those represent the direction we may want to go | 18:04 |
| hub_cap | hey so | 18:04 |
| hub_cap | afte some thought on this, and a ton of refactoring | 18:04 |
| amrith | so, for the present, I say table this blueprint | 18:04 |
| hub_cap | im not sure i like the approach im taking | 18:04 |
| hub_cap | lets chat about it for a sec amrith | 18:04 |
| amrith | ok, sure | 18:04 |
| hub_cap | so there _will_ be datastore specific items that the api/taksmgr need to know about | 18:05 |
| hub_cap | and frankly the guest may never care about | 18:05 |
| hub_cap | let me find an exampl eof the one i was lookin at | 18:05 |
| hub_cap | hmm its been a while i dont want to waste our time | 18:05 |
| hub_cap | so to the config loading snowdust has done | 18:05 |
| *** freyes has joined #openstack-trove | 18:06 | |
| hub_cap | i think that it might be valid to have those as config options groups within the main trove config | 18:06 |
| hub_cap | cfg.mysql.blah | 18:06 |
| hub_cap | some of them dont matter, like the mount_point | 18:06 |
| hub_cap | that was an easy refactor | 18:06 |
| hub_cap | but some of them like the ports, start to look ugly in amap | 18:06 |
| *** demorris has quit IRC | 18:06 | |
| hub_cap | but the part that snowdust didnt do was the autoloading | 18:06 |
| hub_cap | i think it hsould be based on the datasotres that you have "installed", aka the ones in the database | 18:07 |
| hub_cap | not based on yet another config | 18:07 |
| hub_cap | if you don tdeploy couch, dont load its options | 18:07 |
| hub_cap | does that make sense? should be perty easy to get that list from the db and autoload based on that | 18:07 |
| robertmyers | could these be in the capabilities BP? | 18:07 |
| amrith | hub_cap, that was a little different from what I was proposing in my bp | 18:07 |
| hub_cap | robertmyers: some of them yes | 18:07 |
| *** ViswaV_ has joined #openstack-trove | 18:07 | |
| hub_cap | amrith: sure thats like a first step (what im tlkin about) | 18:08 |
| hub_cap | robertmyers: im not sure that, say, ports for a given datastore need to be in capabilities | 18:08 |
| hub_cap | root_on_create, i think yes | 18:08 |
| *** ViswaV has quit IRC | 18:08 | |
| robertmyers | ok | 18:08 |
| hub_cap | and yes i know this is less of amirths and more of snowdusts work, and what ive done last wk | 18:09 |
| SlickNik | I agree. I think the ports don't make sense in capabilities. | 18:09 |
| hub_cap | but i think we can move forward w/ some of the autoloading | 18:09 |
| amrith | so hub_cap, looks like we have to align our thoughts on this, maybe we can get it ready for discussion next week? | 18:09 |
| hub_cap | and the configuration stuff | 18:09 |
| hub_cap | yea i think so amrith | 18:09 |
| hub_cap | its perty big | 18:09 |
| amrith | SlickNik: action is mine to follow up with hub_cap | 18:09 |
| hub_cap | might even be a summit talk | 18:09 |
| SlickNik | Okay, let's table this until next week. | 18:10 |
| amrith | hub_cap/SlickNik, I agree. the thrust of my idea is around eliminating duplicated code and there are many places where we are magically defining the same constants | 18:10 |
| amrith | thx | 18:10 |
| hub_cap | yup amrith ++ | 18:10 |
| SlickNik | amrith: Sounds good. | 18:10 |
| SlickNik | #topic Adding datastore and version to the backup API | 18:10 |
| SlickNik | robertmyers, all yours | 18:11 |
| hub_cap | lol that doenst work here ;) but u konw that | 18:11 |
| hub_cap | hehe | 18:11 |
| robertmyers | sure | 18:11 |
| robertmyers | basically we want to add the datastore to the backup api | 18:11 |
| SlickNik | Yeah, I know :). I was surprised that meetbot actually responded earlier. | 18:11 |
| robertmyers | I see amcrn had some comments? | 18:12 |
| SlickNik | #link https://wiki.openstack.org/wiki/Trove/backup-metadata | 18:12 |
| SlickNik | Yes, there's a couple of comments from him at the bottom of that page. | 18:12 |
| esmute | robertmyers: As part of https://blueprints.launchpad.net/trove/+spec/cross-region-backup-availability, i am adding datastore and version to the backup table | 18:13 |
| esmute | i am not changing the backup API nor the views to return them though | 18:13 |
| esmute | perhaps we can work on this in a way we dont step on each other | 18:13 |
| robertmyers | Well, the point is for someone to be able to tell what datastore was backed up | 18:13 |
| robertmyers | SO my BP is to change the view | 18:14 |
| esmute | i will make a change where the datastore is stored in the DB when a backup is started | 18:15 |
| robertmyers | esmute: I'm fine with killing this if you do that as well | 18:15 |
| amrith | robertmyers, is the version already in someplace and your bp is just to add it to the api? | 18:15 |
| robertmyers | amrith: no, this will add it to the DB | 18:15 |
| hub_cap | ir confused a bit | 18:15 |
| hub_cap | dont u already know the datastore basd on the backup? | 18:15 |
| robertmyers | hub_cap: no | 18:15 |
| esmute | ok.. ill take this since i sorta started it.. i'll be syncing with you to make sure it covers what you had in mind | 18:15 |
| hub_cap | sure change the view, but isint it tied to an instance, aka, u can generate it | 18:16 |
| hub_cap | i dont know if we need to "store it" right? | 18:16 |
| hub_cap | or is there no link to an instnace from a backup | 18:16 |
| robertmyers | well, if you delete the instance then the info is gone | 18:16 |
| hub_cap | is it? | 18:16 |
| esmute | hub_cap: it is tied to the instance. Even if the instance is deleted, the we can find the datastore by querying the soft deleted instance | 18:16 |
| hub_cap | or is it just DELETED=true | 18:16 |
| hub_cap | right esmute | 18:16 |
| hub_cap | id rather _not_ dup the storage | 18:17 |
| robertmyers | we should not use soft deletes | 18:17 |
| esmute | but the issue comes when a backup is copy from a different region (see my BP) | 18:17 |
| hub_cap | if ew can just pull it | 18:17 |
| hub_cap | robertmyers: ummmm i sure hope yer jokin ;) | 18:17 |
| robertmyers | hub_cap: no | 18:17 |
| robertmyers | delete it gone | 18:17 |
| hub_cap | lol ok robert-conway | 18:17 |
| amrith | esmute, has a use case where we must store the version | 18:17 |
| robertmyers | hey the user requested a delete honor it | 18:17 |
| robertmyers | :) | 18:18 |
| hub_cap | smh robertmyers ;) | 18:18 |
| amcrn | considering the underlying datastore-version will be changing on the instance when migrations land, having the current datastore-version isn't useful in determining the datastore-version that the backup was spawned from. | 18:18 |
| esmute | amrith: Yes. when the backup is copied from a different region, there is no instances (active or deleted) that trove can query to find its datastore | 18:18 |
| hub_cap | i think thats valid amrith | 18:18 |
| *** coolsvap is now known as coolsvap|afk | 18:18 | |
| esmute | nor its backuptype... but that is a different story | 18:18 |
| amrith | and add to that amcrn's clarification | 18:18 |
| amrith | seems like it is decided that we must store the datastore version; am I correct? | 18:19 |
| esmute | amcrn: at least we need to know the datastore name. | 18:19 |
| esmute | *know=store | 18:19 |
| amrith | esmute, ok make that datastore name and version | 18:19 |
| amcrn | see my question/comment on the wiki; you need the datastore-version + more. | 18:19 |
| vipul | esmute: there won't be a backup in the new region either.. so how does a FKEY help you | 18:19 |
| robertmyers | amcrn: but if the instance changes version the old backup will still be the old version? | 18:19 |
| esmute | vipul: through the datastore version name | 18:19 |
| *** sbfox has quit IRC | 18:20 | |
| vipul | which you provide in the api esmute? | 18:20 |
| esmute | im hoping the datastore version name is unique :P | 18:20 |
| esmute | vipul: nop.. it will be stored in the swift metadata | 18:20 |
| amcrn | robertmyers: the backup row in the table should always know the exact datastore-version from which is spawned, regardless of whether the instance has moved on. | 18:21 |
| amcrn | which it was spawned* | 18:21 |
| cp16net | amcrn: +1 | 18:21 |
| robertmyers | amcrn: I agree | 18:21 |
| robertmyers | which is why I think we should add a row or two to the backup table | 18:21 |
| esmute | +1 robertmyers | 18:22 |
| cp16net | robertmyers: dont you mean column? | 18:22 |
| amrith | robertmyers, "a row or two"? | 18:22 |
| esmute | if not the version, at least the datastore name.. | 18:22 |
| robertmyers | or three | 18:22 |
| amrith | columns, maybe | 18:22 |
| amcrn | can someone address my point in the wiki about backup/restore strategy? | 18:22 |
| cp16net | :-P | 18:22 |
| robertmyers | cp16net: +1 | 18:22 |
| kevinconway | we should have a column table where we can insert rows | 18:22 |
| SlickNik | Yeah, I agree that we need to store this with the backup. Do we need to store the strategy as well? | 18:23 |
| robertmyers | amcrn: well, I wasn't planning on changing the restore with this BP | 18:23 |
| hub_cap | version uuid, ya? | 18:23 |
| hub_cap | thatll give u all u need | 18:23 |
| amrith | amcrn, if I understand your comment correctly, just name and version are insufficient; there is additional payload that is required. | 18:23 |
| robertmyers | this is just to store the data for future use | 18:23 |
| amrith | is that correct? | 18:23 |
| amcrn | amrith: correct | 18:23 |
| hub_cap | FUTURE PROOF robertmyers | 18:23 |
| esmute | lol | 18:24 |
| SlickNik | hub_cap: version_uuid, probably yes. | 18:24 |
| esmute | robertmyers: +1. Restore wont be changed | 18:24 |
| hub_cap | yup SlickNik thats all u need | 18:24 |
| cp16net | #agree | 18:24 |
| esmute | ok so yes to adding datastore to backup records? | 18:24 |
| amcrn | i guess we're not going to address the fact that the strategy can change at any time, and you'll have backups blowing up. | 18:25 |
| cp16net | #info just need to add the version_uuid to the backup table | 18:25 |
| robertmyers | amcrn: that seems like a new BP | 18:25 |
| amcrn | let me tl;dr my point: store datastore-version-uuid + backup/restore strategy in 3 columns. | 18:25 |
| robertmyers | amcrn: okay 3 columns it is | 18:26 |
| hub_cap | eww i see yer point, but eww amcrn | 18:26 |
| kevinconway | make it four and you have a deal | 18:26 |
| amrith | amcrn, why do you need backup_strategy in the backup? shouldn't restore strategy suffice? | 18:26 |
| hub_cap | kevinconway: one row default="troll", sound good? | 18:26 |
| esmute | amcrn: so storing the dataversion-uuid and the type? | 18:26 |
| SlickNik | amcrn: wait what's the 3rd. I understand version_uuid, backup_strategy…and? | 18:27 |
| amcrn | SlickNik: restore_strategy | 18:27 |
| kevinconway | hub_cap: we can put a hash index on it for super fast lookups | 18:27 |
| robertmyers | we already have the backup type | 18:27 |
| esmute | this is what i have so far | 18:27 |
| esmute | https://gist.github.com/anonymous/11151670 | 18:27 |
| amrith | amcrn, why do you need backup_strategy in the backup? shouldn't restore strategy suffice? | 18:27 |
| SlickNik | robertmyers: Oh yeah, I thought we had something. | 18:28 |
| hub_cap | kevinconway: ;) | 18:28 |
| amcrn | amrith: with a datastore with two competing backup_strategy's, you can't possibly know which one was used if the deployer has flipped between the two at any point in time | 18:28 |
| robertmyers | so the restore uses the backup type to look up the restore strategy | 18:28 |
| hub_cap | maybe the version should have a backup/restore strat | 18:28 |
| hub_cap | and we shouldnt allow a change inflight | 18:29 |
| hub_cap | aka once u set it in the version table, its done | 18:29 |
| hub_cap | for all of that version | 18:29 |
| kevinconway | do we have plans to offer multiple backup/restore strategies per dstore? | 18:29 |
| amcrn | hub_cap: that's another way to do it | 18:29 |
| vipul | hub_cap: +1 i don't see changing a backup strategy is something you should do | 18:29 |
| hub_cap | well it might be | 18:29 |
| hub_cap | but not in the same version | 18:29 |
| grapex | hub_cap: That's too limiting- what if people want to backup a datastore in multiple ways? | 18:29 |
| amrith | kevinconway: I believe not. hence my question. | 18:29 |
| grapex | In case there's an improvement that comes around | 18:29 |
| hub_cap | grapex: who is people? | 18:29 |
| hub_cap | operators? | 18:30 |
| grapex | Yeah | 18:30 |
| grapex | today we use xtrabackup | 18:30 |
| cp16net | maybe i want a mysqldump of my database to put it somewhere else and a xtrabackup all the other times | 18:30 |
| robertmyers | ok, i think this has been going on for a little too long now | 18:30 |
| grapex | what if super xtra backup gets released tomorrow and is incompatable | 18:30 |
| juice | grapex: +1 | 18:30 |
| SlickNik | Okay, so let's do this. We all agree on the version_uuid. | 18:30 |
| hub_cap | yes seems like the other thing is a spiral at present SlickNik | 18:30 |
| esmute | We can store the strategy in the swift metadata? So when the restore is being done, it reads this metadata and knows which strategy to use? | 18:30 |
| juice | I can see a case where the strategy has been changed and you have an old backup with the prior strategy that you want to restore | 18:30 |
| amrith | amcrn, if a backup is with xtrabackup then there's only one way to restore it. similarly if it is a snapshot there's only one (different) way to restore it | 18:30 |
| SlickNik | And we need some more definition around the multi backup-restore strategy case. | 18:30 |
| amcrn | juice: my point exactly | 18:30 |
| hub_cap | esmute: thats sane i think | 18:30 |
| juice | esmute: that works too | 18:31 |
| amrith | so, I'd suspect that for a given backup, storing just the restore strategy should suffice. | 18:31 |
| juice | the only requirement is to store the strategy along with the backup | 18:31 |
| *** sbfox has joined #openstack-trove | 18:31 | |
| juice | whether that is in the database or the swift object does it matter? | 18:31 |
| vipul | so theoretically if a backup occurred with xtrabackup 2.1 .. it shoudl be restorable with xtrabackup 2.2 | 18:31 |
| SlickNik | So let's approve this BP, and incrementally add the other case as part of another bp. | 18:31 |
| hub_cap | id also suspect that this really wont change a ton in general | 18:31 |
| kevinconway | so i think this convo has gone way outside the scope of the BP | 18:31 |
| vipul | are we saying that we can only use 2.1 restore? | 18:31 |
| juice | perhaps in esmute's scenario where you have cross region backups/restore | 18:31 |
| hub_cap | juice: its not something we need to store, its redundant, and will eventually help clog our db | 18:31 |
| hub_cap | :) | 18:31 |
| hub_cap | the app only needs to know about it on restore | 18:32 |
| esmute | SlickNik: +1 | 18:32 |
| SlickNik | I'm calling time on this one, for now. :) | 18:32 |
| hub_cap | kevinconway: ++ its a spiral | 18:32 |
| robertmyers | SlickNik: +1 | 18:32 |
| amcrn | we can approve the uuid only, the point was to dispell the rumor/idea that somehow it was sufficient | 18:32 |
| esmute | we need backup to store datasstore information... we can add the other stuff incrementally | 18:32 |
| amcrn | for all use-cases | 18:32 |
| * hub_cap hands amcrn a wrench | 18:32 | |
| kevinconway | you could always convert the version_uuid field to a json blob that contains all the other metadata later | 18:33 |
| juice | esmute: storing it in the metadata seems like a logical approach | 18:33 |
| SlickNik | amcrn: I think we need to still discuss the other case. But later. :) | 18:33 |
| SlickNik | I want to hear about: | 18:33 |
| amcrn | k | 18:33 |
| SlickNik | #topic Move the Trove Guest Agent to its own module | 18:33 |
| hub_cap | dont feed the kevinconway | 18:33 |
| robertmyers | #link https://wiki.openstack.org/wiki/Trove/MoveTroveGuest | 18:33 |
| robertmyers | lets do it | 18:33 |
| vgnbkr | Given the impact to other bps/bugs, could it be fasttracked? | 18:34 |
| robertmyers | the idea here is a baby step before moving to a separate repo | 18:34 |
| hub_cap | I LIKE IT | 18:34 |
| hub_cap | way better than tryin to rip it out wholesale | 18:34 |
| esmute | robertmyers: will trove-common be part of the guest-agent...similar to openstack-common? | 18:34 |
| robertmyers | esmute: it will need some oslo stuff | 18:35 |
| robertmyers | but for now the plan was just to copy it in plave | 18:35 |
| robertmyers | place | 18:35 |
| robertmyers | once it is in a new repo it will have its own oslo and config | 18:35 |
| cp16net | this sounds like a good idea | 18:36 |
| *** yogesh has joined #openstack-trove | 18:36 | |
| esmute | cool | 18:36 |
| juice | robertmyers: this is a good approach +1 | 18:37 |
| SlickNik | robertmyers: I'm totally on board with this. | 18:37 |
| grapex | +1 | 18:37 |
| * cp16net pushes the easy button... | 18:37 | |
| robertmyers | SlickNik: juice: cool | 18:37 |
| *** yogesh has quit IRC | 18:37 | |
| robertmyers | hahaha | 18:37 |
| SlickNik | Approved. All agree? | 18:37 |
| esp | cp16net: :) | 18:37 |
| amrith | agreed: +1 | 18:38 |
| annashen | guest agent finally gets its own nest | 18:38 |
| cp16net | esp: i really did... | 18:38 |
| cp16net | :-P | 18:38 |
| SlickNik | robertmyers: Any ideas for the timeline? Trying to address vgnbkr's comment about whether the change would be disruptive... | 18:38 |
| SlickNik | and whether we need to get this in asap. | 18:38 |
| robertmyers | Well, I can put the review up by the end of the week | 18:39 |
| kevinconway | what disruption do you expect? a copy/pasta into another dir shouldn't be too bad of a rebase | 18:39 |
| robertmyers | basically once this is approved (the reivew) it needs to be merged first | 18:39 |
| grapex | kevinconway: Eeeh, it will and it won't | 18:39 |
| grapex | I think we should prioritize moving it though | 18:40 |
| SlickNik | kevinconway: There's _always_ little things. | 18:40 |
| grapex | it will make reviewing guest agent pull requests much easier | 18:40 |
| grapex | and we will stop making stupid mistakes | 18:40 |
| SlickNik | robertmyers: done, go forth and do it. | 18:40 |
| robertmyers | SlickNik: ok | 18:40 |
| SlickNik | And thanks! :) | 18:40 |
| esmute | grapex: not so sure about your second point | 18:40 |
| SlickNik | #topic Database log files manipulations | 18:41 |
| SlickNik | denis_makagon? | 18:41 |
| kevinconway | this sounds sinister | 18:41 |
| grapex | kevinconway: The original title was "log file machinations" | 18:41 |
| esmute | going once :P | 18:41 |
| amrith | I'd +1 with that old title | 18:41 |
| amrith | SlickNik: question | 18:42 |
| amrith | the BP is set to "Needs Code Review", is that accurate? | 18:42 |
| amrith | or is the BP in need of review/approval? | 18:42 |
| SlickNik | amrith: I think that there was a gerrit patch submitted for it. | 18:42 |
| amrith | several as a matter of fact | 18:43 |
| openstackgerrit | Doug Shelley proposed a change to openstack/trove: Correct inconsistent state issues with config https://review.openstack.org/88591 | 18:43 |
| SlickNik | amrith: and gerrit updates the bp status automatically based on the Commit Message. | 18:43 |
| amrith | ok, I get it | 18:43 |
| hub_cap | SlickNik: ? | 18:43 |
| SlickNik | LEt's move on. | 18:43 |
| hub_cap | did they impl that? cuz i used to do it manually | 18:43 |
| hub_cap | aka gerrit does bugs but it dindt used to do bps | 18:43 |
| SlickNik | hub_cap: The "code review" piece has worked for me, not the "Committed" piece. | 18:44 |
| hub_cap | k | 18:44 |
| SlickNik | But it's been flakey, not sure why. | 18:44 |
| SlickNik | Next one is denis' too. | 18:45 |
| SlickNik | So let's table that till he's around. | 18:45 |
| SlickNik | #topic Add backup and restore support for single instance couchbase | 18:45 |
| hub_cap | oh this is a terrible idea | 18:45 |
| hub_cap | kidddddding | 18:45 |
| michael-yu | SlickNik - i added this one. but i think forgot to put my name | 18:45 |
| michael-yu | hup_cap: :) | 18:45 |
| hub_cap | do we really neeed to discuss this? i mean, yes we need it, approved | 18:45 |
| esmute | SlickNik: hub_cap spoke. Lets move on :P | 18:45 |
| SlickNik | I'm good with this. | 18:46 |
| SlickNik | We need to do it. Approved. | 18:46 |
| amrith | before you approve it, does it make sense to ensure it is aligned with others that are already doing b&r | 18:46 |
| amrith | too late. | 18:46 |
| robertmyers | amrith: I think the review can handle that | 18:46 |
| amrith | robertmyers, code review? | 18:47 |
| robertmyers | amrith: yes | 18:47 |
| hub_cap | robertmyers: ++ | 18:47 |
| amrith | next! | 18:47 |
| hub_cap | its pertty straight forward :) | 18:47 |
| SlickNik | #topic Populate endpoint URLs from Keystone service catalog | 18:47 |
| SlickNik | esmute: your up. | 18:47 |
| SlickNik | you're* | 18:47 |
| esmute | well.. the point is simple.. To remove the openstack endpoints from the config and get these URL from keystone catalog | 18:48 |
| kevinconway | i have a concern with this one | 18:48 |
| robertmyers | esmute: +1 | 18:48 |
| kevinconway | the BP says you are removing the config options | 18:48 |
| esmute | what is it kevinconway? | 18:48 |
| SlickNik | IIRC, matt lowery was trying to do something similar (and had a review for it at some point too, I think). | 18:48 |
| kevinconway | so this is backwards incompatible? | 18:48 |
| hub_cap | yea mat-lowery had done this | 18:48 |
| mat-lowery | There's a patch set for this https://review.openstack.org/#/c/68015/ | 18:48 |
| mat-lowery | :) | 18:48 |
| hub_cap | i think mat-lowery 's work was valid too | 18:48 |
| esmute | you can have the config there but it wont be read by trove | 18:48 |
| hub_cap | even w/ its order of how it retireved | 18:48 |
| hub_cap | *retrieved | 18:49 |
| esmute | ahh i didnt know about that patch mat-lowery | 18:49 |
| hub_cap | mat-lowery: correct me, but if there is a config it overrides the service catalot right? | 18:49 |
| mat-lowery | correct...the default (in the patch) is to get from catalog | 18:49 |
| esmute | ok.. i can abandon my BP and use mat-lowery's patch | 18:49 |
| hub_cap | wait thats the opposite of what i said hehe | 18:49 |
| hub_cap | yes esmute | 18:49 |
| vipul | yea i think the default is get from conf | 18:49 |
| vipul | according to the patch | 18:50 |
| hub_cap | yes i thought so to vipul | 18:50 |
| hub_cap | i think it was originally the opposite but we whined | 18:50 |
| robertmyers | as long as we can still override it when needed I'm fine with it | 18:50 |
| vipul | yep, looks much better mat-lowery, sorry it's been waiting in the review state for so long :( | 18:50 |
| mat-lowery | if *_url in conf, use it else use catalog | 18:50 |
| grapex | robertmyers: ditto | 18:50 |
| grapex | Here at Rax, especially in staging and other environments we don't always have the luxury of using the catalog. | 18:51 |
| cp16net | yup | 18:51 |
| hub_cap | grapex: its more likely we can use the sears catalog than our service catalog in staging | 18:51 |
| grapex | hub_cap: LOL! | 18:51 |
| robertmyers | hub_cap: lol | 18:51 |
| *** ViswaV_ has quit IRC | 18:51 | |
| SlickNik | mat-lowery: Looks good at first glance. Will review it later this afternoon. | 18:51 |
| mat-lowery | ok thanks | 18:52 |
| kevinconway | so that's awesome that mat-lowery made the thing backwards compat | 18:52 |
| hub_cap | esmute: plz give some review to it as well, to make sure it meets your needs | 18:52 |
| kevinconway | but does core have an official stance on how we plan to deprecate config options on occasions like this? | 18:52 |
| esmute | will do hub_cap. Thanks | 18:52 |
| grapex | kevinconway: I don't see why we need to deprecate them | 18:52 |
| hub_cap | kevinconway: i think its an openstak thing, like a N+1 strategy | 18:52 |
| grapex | I think the service catalog is great, if it works | 18:52 |
| robertmyers | kevinconway: it does not deprecate them | 18:52 |
| hub_cap | but for this it wont deprecate | 18:52 |
| SlickNik | kevinconway: I think they're still supported. Just optional. | 18:52 |
| grapex | but there's plenty of times you may need to override it | 18:52 |
| kevinconway | SlickNik: that's deprecated | 18:53 |
| robertmyers | kevinconway: ? | 18:53 |
| kevinconway | eventually they would be removed, yes? | 18:53 |
| *** ViswaV has joined #openstack-trove | 18:53 | |
| hub_cap | no thats optional | 18:53 |
| vipul | i hope not | 18:53 |
| grapex | like if you're trying to boot strap Trove in a vacuum, and maybe keystone or anything like it isn't set up | 18:53 |
| robertmyers | kevinconway: never | 18:53 |
| hub_cap | eventually removed is deprecated | 18:53 |
| kevinconway | deprecated doesn't mean gone | 18:53 |
| SlickNik | kevinconway: They're not going away. | 18:53 |
| hub_cap | optional is optional | 18:53 |
| kevinconway | ok so diamonds are forever? | 18:53 |
| hub_cap | some orgs will always use those optional configs | 18:53 |
| hub_cap | we will deprecate and remove non heat support for installs | 18:53 |
| grapex | kevinconway: Yes, just consider that we've gone with diamond mode | 18:53 |
| *** ViswaV_ has joined #openstack-trove | 18:54 | |
| SlickNik | Time to move on I think. :) | 18:54 |
| SlickNik | #topic Enable specification of Cinder Volume Types | 18:54 |
| SlickNik | So this one is mine. | 18:54 |
| *** ViswaV_ has joined #openstack-trove | 18:54 | |
| SlickNik | And it's an addition to the conf file to specify the volume_type to use when provisioning a cinder volume. | 18:55 |
| vgnbkr | SlickNik : I get a message that your page is private for the wiki. | 18:55 |
| SlickNik | I'm still drafting this, so I just wanted to get feedback on what people thought. | 18:55 |
| grapex | I like this idea | 18:55 |
| grapex | it should probably become a capability though so we can pick them for each datastore type | 18:55 |
| SlickNik | vgnbkr: The wiki's still not there. So it's still drafting. | 18:55 |
| vipul | SlickNik: at some point we want to tie this to datastore version? | 18:56 |
| vgnbkr | SlickNik: oh, nevermind - I didn't read the link, just clicked on it :-) | 18:56 |
| vipul | grapex: +1 | 18:56 |
| SlickNik | grapex: Yes that's the reason it's still drafting. I'm thinking about whether we should add this to capabilities when we that's added. | 18:56 |
| hub_cap | yea we need ot fasttrack capabilities | 18:56 |
| hub_cap | since we have other things that "maybe one day will be a capability" | 18:57 |
| grapex | imsplitbit: Spare thee not the whip! | 18:57 |
| hub_cap | i think k-pom has a review up | 18:57 |
| hub_cap | so maybe imsplitbit needs to whip us ;) | 18:57 |
| SlickNik | Okay, I have the feedback I was looking for. | 18:57 |
| kevinconway | where there's a whip there's a way! | 18:57 |
| *** ViswaV has quit IRC | 18:57 | |
| hub_cap | exactly kevinconway | 18:57 |
| grapex | hub_cap: hopefully not Peter Griffith style | 18:57 |
| grapex | kevinconway: lol | 18:57 |
| SlickNik | +1 on getting capabilities in soon. | 18:58 |
| SlickNik | I think that's all we have time for. | 18:58 |
| SlickNik | #endmeeting | 18:58 |
| openstack | Meeting ended Mon Apr 21 18:58:19 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:58 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-04-21-17.59.html | 18:58 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-04-21-17.59.txt | 18:58 |
| grapex | Awesome job SlickNik | 18:58 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-04-21-17.59.log.html | 18:58 |
| cp16net | nice | 18:58 |
| SlickNik | Thanks folks! | 18:58 |
| hub_cap | TIME | 18:59 |
| hub_cap | oh we got meetbot in here?!?! thats cool! i didnt even realize it | 18:59 |
| hub_cap | hehe | 18:59 |
| cp16net | hub_cap: you were late to the party | 18:59 |
| cp16net | :0P | 18:59 |
| hub_cap | cp16net: yes i am | 18:59 |
| grapex | SlickNik: Witht he meetbot does that mean we can hold the normal meetings here as well? | 19:00 |
| cp16net | i guess we technically could | 19:01 |
| SlickNik | grapex: Probably still want to do that in #openstack-meeting-alt since that's what other OpenStack folks do. | 19:02 |
| SlickNik | also CI/docs other cross project folks ofter hang out there and often jump into discussions. | 19:02 |
| grapex | SlickNik: Ok, anything to get out of typing those few characters to join it | 19:05 |
| esmute | Hi mat-lowery, i saw your patch. it looks great.. better than what i would've put there. Just one comment about the method to get the URLs from catalog. | 19:10 |
| esmute | other than that, i looks good to me | 19:10 |
| esmute | *i=it | 19:11 |
| mat-lowery | esmute: Ha. Well I had 3 months to work on it. :) | 19:11 |
| mat-lowery | I'll check out your review. | 19:12 |
| mat-lowery | Thanks. | 19:12 |
| esmute | im not that egocentric :p | 19:12 |
| mat-lowery | esmute: I replied to your review. We can do back and forth on Gerrit or here. Basically my version insists on exactly one match--otherwise you get an exception. sc.url_for() will quietly return the first of potentially multiple matches. Thoughts? | 19:17 |
| mat-lowery | By insisting on exactly one match, do we prevent deployers from using the wrong or less-than-ideal endpoint? I'm not sure. | 19:19 |
| mat-lowery | jamielennox from Keystone has argued that whether it's one or multiple matches, the fact remains that the query returned results according to your filter. But we control the filter. | 19:21 |
| mat-lowery | And the deployer can affect the filter and unknowingly get the first of multiple matches. Is this OK? This is the question I have. | 19:22 |
| *** freyes has quit IRC | 19:29 | |
| grapex | hub_cap SlickNik vipul: Does anyone remember / know why the trove-api doesn't use eventlet monkey patch the same as taskmanager, the guest, conductor etc? | 19:41 |
| grapex | For example, trove/cmd/taskmanager.py calls eventlet.monkey_patch(thread=True) if debugging isn't turned on | 19:42 |
| grapex | but trove-api's cmd script doesn't have that | 19:42 |
| grapex | it calls monkey_patch in trove/common/wsgi.py, but "all=False" which may mean threading isn't enabled | 19:43 |
| grapex | do any of you remember / know why it's different? Was this to avoid some awful wsgi issue? | 19:43 |
| * hub_cap shrugs | 19:45 | |
| *** jmontemayor has joined #openstack-trove | 19:46 | |
| *** freyes has joined #openstack-trove | 19:49 | |
| *** eghobo has quit IRC | 19:51 | |
| *** eghobo has joined #openstack-trove | 19:51 | |
| *** thedodd has joined #openstack-trove | 19:55 | |
| *** amcrn has quit IRC | 19:58 | |
| *** mattgriffin has quit IRC | 20:01 | |
| *** jmontemayor has quit IRC | 20:05 | |
| *** jmontemayor has joined #openstack-trove | 20:05 | |
| esmute | Hi mat-lowery. i think it is ok how you have it. The reason i suggested this way was because i was looking at your code and thought it was something similar that sc.url_for() does. But if the intention is to have it that way, then im fine. | 20:06 |
| *** mattgriffin has joined #openstack-trove | 20:07 | |
| esmute | i changed my review and +1'd | 20:08 |
| amrith | hub_cap, when you wanna chat re: config options and things? | 20:08 |
| amrith | hub_cap, would like to speak with you before I wade into https://review.openstack.org/#/c/86808/ | 20:09 |
| mat-lowery | esmute: Gotcha. Thanks. I haven't convinced myself that the RegionAmbiguity is always the right thing to do. I guess I could argue that because of *_url's lack of ambiguity, this patch set continues that. But some deployer could come along and say, "Just use whatever endpoint is available. I don't care." I don't know if that is a real use-case. | 20:10 |
| hub_cap | amrith: u can look @ that first, it doesnt really factor into it | 20:10 |
| hub_cap | id like to wait for snowdust too | 20:10 |
| hub_cap | so maybe tomorrow amrith ? im not sure where snowdust is, maybe its a holiday? | 20:11 |
| amrith | hub_cap, I hear snowdust snoring right now | 20:11 |
| amrith | so yes, tomorrow | 20:11 |
| hub_cap | hehe amrith | 20:12 |
| amrith | hub_cap, last I chatted with him, he was in India and I don't think there's a holiday tomorrow | 20:12 |
| amrith | but we can check tomorrow | 20:12 |
| hub_cap | ill be around most of the day except for a few hrs | 20:12 |
| amrith | likewise | 20:12 |
| amrith | late morning (eastern) may be best for all | 20:13 |
| amrith | I'll give a shout then | 20:13 |
| *** freyes has quit IRC | 20:15 | |
| *** michael-yu has quit IRC | 20:16 | |
| hub_cap | hokey amrith | 20:17 |
| *** yidclare has quit IRC | 20:20 | |
| esmute | mat-lowery: I think you are right. It is safer to have it return a non ambiguous endpoint. An openstack deployment will have multiple regions so no specifying one could lead to a compute being provisioned on the other side of the world or a volume being created in a different region. | 20:21 |
| hub_cap | and fwiw, i -2'd my own revies for the rest of this patch series amrith | 20:23 |
| hub_cap | cuz im not sure its correct :) | 20:23 |
| esmute | mat-lowery: when you can, can you put a patch to devstack to remove https://github.com/openstack-dev/devstack/blob/master/lib/trove#L150 and https://github.com/openstack-dev/devstack/blob/master/lib/trove#L170 and add a default region (RegionOne) | 20:23 |
| *** michael-yu has joined #openstack-trove | 20:26 | |
| mat-lowery | esmute: Good catch. Will do. Thanks! | 20:28 |
| esmute | Cool! | 20:29 |
| esmute | lets get it merged... because i need it :P | 20:29 |
| mat-lowery | esmute: Gotcha. | 20:31 |
| *** michael-yu has quit IRC | 20:33 | |
| *** yidclare has joined #openstack-trove | 20:40 | |
| SlickNik | peterstac: Saw your patches to tempest. Nice start! :) | 20:47 |
| SlickNik | (And thanks!) | 20:48 |
| peterstac | Thanks, we'll see how the review goes ;) | 20:55 |
| *** khyati_ has joined #openstack-trove | 21:03 | |
| peterstac | SlickNik: I've updated the etherpad https://etherpad.openstack.org/p/trove-tempest-items with my review link | 21:03 |
| peterstac | SlickNik: I'm looking at quotas and pagination (under the API section) and in poking around the existing tests it looks like they both rely on instances being created - should they be moved to the 'Guest Related' section? | 21:03 |
| SlickNik | peterstac: Yes, if that's the case (I wasn't sure if all limits testing needed instances, so I left them out). | 21:04 |
| SlickNik | peterstac: btw, looks like you're gonna need an image to use for the tests soon. | 21:07 |
| peterstac | SlickNik: Yeah, I was wondering how that was going | 21:08 |
| SlickNik | peterstac: Been busy with other things; so haven't really had a chance to look into it yet. | 21:09 |
| SlickNik | peterstac: But now I have a forcing function. :) | 21:09 |
| *** mattgriffin has quit IRC | 21:10 | |
| peterstac | SlickNik: Let me know if I can lend a hand (besides providing motivation ;) ) | 21:10 |
| SlickNik | peterstac: I'm already motivated now; Once I figure out how to make the CI/Infra pieces fit together to do this, I'll let you know. | 21:13 |
| peterstac | SlickNik: Sounds good, thx | 21:18 |
| imsplitbit | dougshelley66: where is the bp for replicaiton/topology? | 21:24 |
| grapex | SlickNik: By the way: https://bugs.launchpad.net/trove/+bug/1310785 | 21:27 |
| grapex | I'm writing a fix | 21:27 |
| grapex | we may want to mark that as Critical | 21:27 |
| *** casanch1_ has joined #openstack-trove | 21:28 | |
| *** casanch1 has quit IRC | 21:30 | |
| *** casanch1 has joined #openstack-trove | 21:30 | |
| SlickNik | grapex: Thanks for the heads up! | 21:30 |
| imsplitbit | dougshelley66: are we wrapping the topology path in with the replication-v1 bp? or should I assemble one of my own just for the /topology path and storage? | 21:30 |
| *** khyati_ has quit IRC | 21:31 | |
| *** casanch1_ has quit IRC | 21:32 | |
| *** mattgriffin has joined #openstack-trove | 21:34 | |
| *** casanch1 has quit IRC | 21:35 | |
| *** openstackstatus has quit IRC | 21:35 | |
| openstackgerrit | Tim Simpson proposed a change to openstack/trove: Make sure eventlet starts correctly https://review.openstack.org/89425 | 21:36 |
| grapex | Talk to you all tomorrow! | 21:37 |
| *** openstackstatus has joined #openstack-trove | 21:37 | |
| *** robertmyers has quit IRC | 21:37 | |
| imsplitbit | yeah I'm out too | 21:37 |
| imsplitbit | y'all have a good one | 21:37 |
| *** robertmyers has joined #openstack-trove | 21:38 | |
| *** grapex has quit IRC | 21:39 | |
| openstackgerrit | Ranjitha Vemula proposed a change to openstack/python-troveclient: Remove Duplicate ClientExceptions and Merge https://review.openstack.org/80328 | 21:40 |
| *** robertmyers has quit IRC | 21:42 | |
| dougshelley66 | imsplitbit - sorry i missed your ping | 21:45 |
| dougshelley66 | maybe we can chat with vgnbkr and glucas tomorrow about what makes sense for the BP | 21:46 |
| *** datsun180b has joined #openstack-trove | 22:05 | |
| *** kevinconway has quit IRC | 22:05 | |
| *** datsun180b has left #openstack-trove | 22:07 | |
| *** yidclare has quit IRC | 22:08 | |
| *** michael-yu has joined #openstack-trove | 22:40 | |
| *** thedodd has quit IRC | 22:42 | |
| *** mattgriffin has quit IRC | 22:49 | |
| *** eguz has joined #openstack-trove | 23:03 | |
| *** eghobo has quit IRC | 23:06 | |
| *** khyati_ has joined #openstack-trove | 23:12 | |
| *** saurabhs has left #openstack-trove | 23:15 | |
| *** jcru has quit IRC | 23:37 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Trove guestagent should not use sample conf https://review.openstack.org/88478 | 23:47 |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 23:47 |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Clean up redstack to use SERVICE_HOST https://review.openstack.org/71128 | 23:47 |
| openstackgerrit | A change was merged to openstack/trove-integration: Clean up redstack to use SERVICE_HOST https://review.openstack.org/71128 | 23:49 |
| *** openstackgerrit has quit IRC | 23:50 | |
| *** openstackgerrit has joined #openstack-trove | 23:50 | |
| *** rueb7363 has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!