*** sbfox has joined #openstack-trove | 00:00 | |
*** sbfox has quit IRC | 00:05 | |
*** eguz has joined #openstack-trove | 00:19 | |
*** ranjitha has quit IRC | 00:20 | |
*** eghobo has quit IRC | 00:23 | |
*** mattgriffin has quit IRC | 00:25 | |
*** amcrn has joined #openstack-trove | 00:34 | |
*** ViswaV has quit IRC | 00:45 | |
*** michael-yu has quit IRC | 00:48 | |
*** yidclare has quit IRC | 00:50 | |
*** harlowja has joined #openstack-trove | 01:00 | |
*** crucif0rm has quit IRC | 01:02 | |
*** khyati_ has quit IRC | 01:03 | |
*** erkules_ has joined #openstack-trove | 01:28 | |
*** erkules has quit IRC | 01:31 | |
*** eguz has quit IRC | 01:33 | |
*** nosnos has joined #openstack-trove | 01:36 | |
*** SushillKM has joined #openstack-trove | 01:57 | |
*** SushillKM has quit IRC | 02:04 | |
*** coolsvap has quit IRC | 02:05 | |
*** coolsvap has joined #openstack-trove | 02:10 | |
*** Barker has quit IRC | 02:12 | |
*** haomaiw__ has quit IRC | 02:13 | |
*** haomaiwang has joined #openstack-trove | 02:13 | |
*** rueb7363 has joined #openstack-trove | 02:18 | |
*** mattgriffin has joined #openstack-trove | 02:39 | |
*** amcrn has quit IRC | 02:41 | |
*** harlowja is now known as harlowja_away | 03:09 | |
*** mattgriffin has quit IRC | 03:18 | |
*** rueb7363 has quit IRC | 03:22 | |
*** NehaV has joined #openstack-trove | 03:23 | |
*** esp has left #openstack-trove | 03:23 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 03:24 |
---|---|---|
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 03:24 |
*** sbfox has joined #openstack-trove | 03:25 | |
*** sbfox has quit IRC | 03:27 | |
*** sbfox has joined #openstack-trove | 03:32 | |
*** ViswaV has joined #openstack-trove | 03:34 | |
*** NehaV has quit IRC | 03:34 | |
*** NehaV has joined #openstack-trove | 03:35 | |
*** ViswaV_ has joined #openstack-trove | 03:37 | |
*** ViswaV has quit IRC | 03:39 | |
*** erkules_ is now known as erkules | 03:41 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 03:44 |
*** ramishra has joined #openstack-trove | 03:46 | |
*** NehaV has quit IRC | 03:48 | |
*** _shalini has quit IRC | 03:53 | |
*** haomai___ has joined #openstack-trove | 03:55 | |
*** michael-yu has joined #openstack-trove | 03:57 | |
*** haomaiwang has quit IRC | 03:59 | |
*** michael-yu has quit IRC | 04:00 | |
*** eghobo has joined #openstack-trove | 04:01 | |
*** coolsvap has quit IRC | 04:05 | |
*** amcrn has joined #openstack-trove | 04:06 | |
*** sbfox has quit IRC | 04:06 | |
*** coolsvap has joined #openstack-trove | 04:07 | |
*** sbfox has joined #openstack-trove | 04:08 | |
cp16net | hmm anyone around? | 04:09 |
cp16net | when i am running my vm i'm not seeing all the logging from taskmanager after making changes and restarting it from the screen session | 04:11 |
cp16net | but it looks like the calls are running still | 04:11 |
cp16net | it seems like there is a thread running or something thats not being logged | 04:14 |
cp16net | kinda weird | 04:14 |
cp16net | just curious if anyone else has seen this kind of behavior | 04:15 |
*** harlowja_away is now known as harlowja | 04:18 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 04:19 |
*** ViswaV_ has quit IRC | 04:20 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS) https://review.openstack.org/88349 | 04:20 |
*** michael-yu has joined #openstack-trove | 04:23 | |
*** haomai___ has quit IRC | 04:24 | |
*** haomaiwang has joined #openstack-trove | 04:25 | |
*** yidclare has joined #openstack-trove | 04:48 | |
*** sgotliv has joined #openstack-trove | 04:53 | |
*** haomaiw__ has joined #openstack-trove | 04:54 | |
*** haomaiwang has quit IRC | 04:57 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 05:00 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: Configurations stored in the database https://review.openstack.org/79852 | 05:00 |
openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adding configuration paramters mgmt api https://review.openstack.org/79851 | 05:00 |
*** rwsu has quit IRC | 05:07 | |
*** nosnos has quit IRC | 05:08 | |
*** ashishsnigam has joined #openstack-trove | 05:15 | |
*** rwsu has joined #openstack-trove | 05:23 | |
*** sgotliv has quit IRC | 05:32 | |
*** nosnos has joined #openstack-trove | 05:35 | |
*** saurabhs has left #openstack-trove | 05:35 | |
*** eghobo has quit IRC | 05:39 | |
*** eghobo has joined #openstack-trove | 05:39 | |
*** sbfox has quit IRC | 05:42 | |
*** michael-yu has quit IRC | 05:43 | |
*** eguz has joined #openstack-trove | 05:46 | |
*** michael-yu has joined #openstack-trove | 05:47 | |
*** yogeshmehra has joined #openstack-trove | 05:47 | |
*** eghobo has quit IRC | 05:50 | |
*** NehaV has joined #openstack-trove | 05:54 | |
*** SushillKM has joined #openstack-trove | 05:58 | |
*** michael-yu has quit IRC | 06:01 | |
*** NehaV has quit IRC | 06:03 | |
*** haomaiw__ has quit IRC | 06:10 | |
*** haomaiwa_ has joined #openstack-trove | 06:10 | |
*** yogeshmehra has quit IRC | 06:11 | |
*** michael-yu has joined #openstack-trove | 06:19 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/90010 | 06:22 |
*** harlowja is now known as harlowja_away | 06:30 | |
*** michael-yu has quit IRC | 06:37 | |
*** flaper87|afk is now known as flaper87 | 06:38 | |
*** yogeshmehra has joined #openstack-trove | 06:41 | |
*** shakamunyi has quit IRC | 06:42 | |
*** ramishra has quit IRC | 06:45 | |
*** ramishra has joined #openstack-trove | 06:46 | |
openstackgerrit | Shashank Gupta proposed a change to openstack/trove: Corrected the assertion message in test_dbaas.py file https://review.openstack.org/89815 | 06:53 |
*** michael-yu has joined #openstack-trove | 07:00 | |
*** amcrn has quit IRC | 07:04 | |
*** shakamunyi has joined #openstack-trove | 07:08 | |
*** shakamunyi has quit IRC | 07:12 | |
*** michael-yu has quit IRC | 07:12 | |
*** eguz has quit IRC | 07:13 | |
openstackgerrit | Shashank Gupta proposed a change to openstack/trove: Corrected the assert message in test_dbaas.py https://review.openstack.org/89815 | 07:15 |
*** michael-yu has joined #openstack-trove | 07:16 | |
*** ramishra has quit IRC | 07:24 | |
*** michael-yu has quit IRC | 07:32 | |
*** michael-yu has joined #openstack-trove | 07:38 | |
*** sgotliv has joined #openstack-trove | 07:59 | |
*** sgotliv has quit IRC | 07:59 | |
*** michael-yu has quit IRC | 07:59 | |
*** sgotliv has joined #openstack-trove | 08:00 | |
*** shakamunyi has joined #openstack-trove | 08:08 | |
*** shakamunyi has quit IRC | 08:13 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 08:16 |
*** nosnos has quit IRC | 08:18 | |
*** yogeshmehra has quit IRC | 08:19 | |
*** michael-yu has joined #openstack-trove | 08:20 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 08:23 |
*** michael-yu_ has joined #openstack-trove | 08:31 | |
*** michael-yu has quit IRC | 08:33 | |
*** michael-yu_ is now known as michael-yu | 08:33 | |
*** michael-yu has quit IRC | 08:36 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 08:47 |
*** haomai___ has joined #openstack-trove | 09:02 | |
*** haomaiwa_ has quit IRC | 09:06 | |
*** TomasR_ has joined #openstack-trove | 09:06 | |
TomasR_ | Hi, guys, I follow the steps from this document: http://docs-draft.openstack.org/25/88225/4/check/gate-openstack-manuals-tox-doc-publish-checkbuild/6819c34/publish-docs/trunk/install-guide/install/apt/content/trove-install.html | 09:06 |
TomasR_ | On the last Step (12): I got one error with trove-conductor: | 09:07 |
TomasR_ | service trove-api restart trove-api stop/waiting trove-api start/running, process 10394 | 09:07 |
TomasR_ | service trove-taskmanager restart trove-taskmanager stop/waiting trove-taskmanager start/running, process 10644 | 09:07 |
TomasR_ | service trove-conductor restart trove-conductor: unrecognized service | 09:07 |
SlickNik | TomasR_: There is an upstream ubuntu bug with packaging. | 09:08 |
SlickNik | TomasR_: Essentially trove conductor is not being packaged. | 09:09 |
*** shakamunyi has joined #openstack-trove | 09:09 | |
TomasR_ | We used a configuration template file from https://raw.githubusercontent.com/openstack/trove/master/etc/trove/trove-guestagent.conf.sample | 09:09 |
SlickNik | TomasR_: https://bugs.launchpad.net/ubuntu/+source/openstack-trove/+bug/1308523 | 09:10 |
*** shakamunyi has quit IRC | 09:14 | |
*** denis_makogon has joined #openstack-trove | 09:21 | |
*** shivam has quit IRC | 09:26 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 09:46 |
*** shivamshukla has joined #openstack-trove | 09:46 | |
TomasR_ | Guys, when I run this command: su -s /bin/sh -c "/usr/bin/python /usr/bin/trove-conductor --config-file=/etc/trove/trove-conductor.conf" trove | 09:59 |
TomasR_ | In the log files I see: 2014-04-24 11:56:24.142 1465 TRACE trove.openstack.common.threadgroup ImportError: No module named rabbit | 09:59 |
TomasR_ | I have these packages installed: | 10:00 |
TomasR_ | aptitude search rabbit | grep pyth i A python-librabbitmq - AMQP Client using the rabbitmq-c library p python-librabbitmq:i386 - AMQP Client using the rabbitmq-c library | 10:00 |
TomasR_ | Am I missing some modules? | 10:00 |
SlickNik | TomasR_: your trove-conductor conf likely has rabbitmq settings in an incorrect format. | 10:02 |
TomasR_ | OK, let me check | 10:03 |
SlickNik | TomasR_: Use https://raw.githubusercontent.com/openstack/trove/master/etc/trove/trove-conductor.conf.sample as a guideline for your trove-conductor.conf | 10:03 |
TomasR_ | I have this: | 10:03 |
TomasR_ | [DEFAULT] verbose = True debug = True control_exchange = trove log_dir=/var/log/trove log_file=trove-conductor.log trove_auth_url = http://controller:5000/v2.0 nova_compute_url = http://controller:8774/v2 cinder_url = http://controller:8776/v1 sql_connection = mysql://trove:trove@controller/trove | 10:03 |
SlickNik | np | 10:03 |
TomasR_ | rabbit_host=controller | 10:04 |
TomasR_ | rpc_backend = rabbit | 10:04 |
*** SnowDust has joined #openstack-trove | 10:04 | |
SlickNik | remove the rpc_backend setting from the conf. | 10:05 |
SlickNik | and replace it with rpc_backend = trove.openstack.common.rpc.impl_kombu | 10:05 |
TomasR_ | ok, let me try it | 10:06 |
SlickNik | You may also need to add: | 10:06 |
SlickNik | # The RabbitMQ userid. (string value) | 10:06 |
SlickNik | #rabbit_userid=guest | 10:06 |
SlickNik | # The RabbitMQ password. (string value) | 10:06 |
SlickNik | rabbit_password=f7999d1955c5014aa32c | 10:06 |
SlickNik | # The RabbitMQ virtual host. (string value) | 10:06 |
SlickNik | #rabbit_virtual_host=/ | 10:06 |
SlickNik | depending on your rabbit conf | 10:06 |
SlickNik | (especially the password bit for your particular rabbit server) | 10:07 |
openstackgerrit | shivam shukla proposed a change to openstack/trove: Tests for heat based instance workflow https://review.openstack.org/66499 | 10:10 |
*** shakamunyi has joined #openstack-trove | 10:10 | |
TomasR_ | changing rpc_backend parameter seems to be sufficient, thanks. I got trove-conductor running now | 10:12 |
SlickNik | TomasR_: You're welcome! | 10:12 |
*** shakamunyi has quit IRC | 10:14 | |
*** nosnos has joined #openstack-trove | 10:15 | |
*** sgotliv has quit IRC | 10:19 | |
TomasR_ | Guys, one more question. "trove list" works now, but when I execute this command: | 10:25 |
TomasR_ | trove create mysqldemo 2 --size=2 --databases=DEMO --users demo:demo --datastore_version mysql-5.5 --datastore mysql | 10:25 |
TomasR_ | I get this error: | 10:25 |
TomasR_ | error: unrecognized arguments: --datastore_version mysql-5.5 --datastore mysql | 10:25 |
TomasR_ | Shall I just skip datastore_version and datastore parameters? | 10:25 |
TomasR_ | I checked in MySQL trove database directly , I have mysql-5.5 datastore version and mysql datastore listed, but some issue with trove syntax | 10:28 |
SlickNik | try using the UUIDs for them instead of the name(s) | 10:28 |
SlickNik | You should be able to skip those args as well, it should fall back to the default. | 10:29 |
SlickNik | (which should be mysql 5.5 in this setup) | 10:29 |
TomasR_ | Also: I tried creating using web interface. I now have a new menu: Databases, but I got this error: Error: There was an error submitting the form. Please try again. | 10:35 |
TomasR_ | I executed this now: trove create --size=2 --databases=DEMO --users demo:demo --availability_zone=nova mysqldemo 2 | 10:37 |
TomasR_ | ERROR: Default version for datastore 'mysql' not found. | 10:37 |
SlickNik | What's the output of "trove datastore-version-list mysql"? | 10:39 |
TomasR_ | I get syntax error: | 10:40 |
TomasR_ | error: argument <subcommand>: invalid choice: u'datastore-version-list' | 10:40 |
dougshelley66 | maybe he should start with trove datastore-list? | 10:41 |
SlickNik | The previous output seems to indicate that he's got a "mysql" datastore already, I think. | 10:43 |
SlickNik | (and it's being correctly picked up as the default) | 10:43 |
TomasR_ | This is not available either. Maybe I'm running some old / older version of trove? | 10:43 |
dougshelley66 | you are saying that trove datastore-list didn't work? | 10:44 |
SlickNik | Could also be an older version of python-troveclient. | 10:45 |
TomasR_ | I only have those commands available, when I run trove help | 10:46 |
TomasR_ | backup-create backup-delete backup-list backup-list-instance List backup-show create database-create database-delete database-list delete flavor-list flavor-show limit-list list resize-flavor resize-volume restart root-enable root-show secgroup-add-rule secgroup-delete-rule Deletes secgroup-list secgroup-show show user-create user-delete user-grant-access user-list user-revoke-access user-show user-show-access user-update-a | 10:46 |
*** sgotliv has joined #openstack-trove | 10:46 | |
dougshelley66 | certainly some things missing | 10:47 |
SlickNik | TomasR_: Yup you probably need to get a newer version of python-troveclient. :) | 10:48 |
*** sgotliv has quit IRC | 10:48 | |
dougshelley66 | did you get python-troveclient from the apt-repo in the first step? | 10:49 |
*** sgotliv has joined #openstack-trove | 10:49 | |
TomasR_ | I did this apt-get install python-trove python-troveclient python-glanceclient \ trove-common trove-api trove-taskmanager | 10:49 |
TomasR_ | As suggested in : | 10:49 |
TomasR_ | http://docs.openstack.org/icehouse/install-guide/install/apt-debian/content/trove-install.html | 10:49 |
dougshelley66 | right step #1 | 10:49 |
dougshelley66 | and you are running on 14.04? | 10:50 |
TomasR_ | cat /etc/issue Ubuntu 14.04 LTS \n \l | 10:51 |
TomasR_ | I actually followed later (draft) version of the document: | 10:51 |
TomasR_ | http://docs-draft.openstack.org/25/88225/4/check/gate-openstack-manuals-tox-doc-publish-checkbuild/6819c34/publish-docs/trunk/install-guide/install/apt/content/trove-install.html | 10:51 |
dougshelley66 | looks like we need to validate what is currently in that apt repo | 10:52 |
TomasR_ | Is the a link available with the latest packages that I can manually install using dpkg? | 10:53 |
dougshelley66 | i believe the packages are produced by Canonical so i don't know the answer to that question | 10:55 |
SlickNik | TomasR_: The latest package can be installed via pip from pypi | 10:57 |
SlickNik | TomasR_: Seems like the latest ubuntu package doesn't have the latest client bits. | 10:57 |
SlickNik | TomasR_: https://pypi.python.org/pypi/python-troveclient | 10:58 |
TomasR_ | SlickNik, thanks. I'll try to use the latest version. I need to run now and catch a train to Brussels. So I'll resume playing with trove on Friday. Thanks a lot for useful tips | 10:58 |
SlickNik | TomasR_: np, happy to help! | 10:58 |
*** mattgriffin has joined #openstack-trove | 10:59 | |
*** SnowDust has quit IRC | 11:01 | |
*** TomasR_ has quit IRC | 11:02 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 11:07 |
*** shakamunyi has joined #openstack-trove | 11:11 | |
*** shakamunyi has quit IRC | 11:15 | |
*** SushillKM has quit IRC | 11:30 | |
*** ramishra has joined #openstack-trove | 11:34 | |
*** ashestakov__ has joined #openstack-trove | 11:35 | |
*** shakamunyi has joined #openstack-trove | 11:57 | |
*** achampion has quit IRC | 11:59 | |
*** mattgriffin has quit IRC | 12:01 | |
*** pdmars has joined #openstack-trove | 12:02 | |
*** ashishsnigam has quit IRC | 12:14 | |
*** yogeshmehra has joined #openstack-trove | 12:20 | |
*** yogeshmehra has quit IRC | 12:25 | |
*** nosnos has quit IRC | 12:42 | |
*** NehaV has joined #openstack-trove | 12:44 | |
*** NehaV has quit IRC | 13:01 | |
*** SnowDust has joined #openstack-trove | 13:03 | |
*** NehaV has joined #openstack-trove | 13:06 | |
*** achampion has joined #openstack-trove | 13:09 | |
*** NehaV has quit IRC | 13:10 | |
*** NehaV has joined #openstack-trove | 13:11 | |
*** coolsvap is now known as coolsvap|afk | 13:13 | |
*** coolsvap|afk is now known as coolsvap | 13:13 | |
*** ramishra_ has joined #openstack-trove | 13:21 | |
*** casanch1 has joined #openstack-trove | 13:22 | |
*** ramishra has quit IRC | 13:22 | |
*** SnowDust has quit IRC | 13:26 | |
*** sgotliv has quit IRC | 13:38 | |
*** yogeshmehra has joined #openstack-trove | 13:41 | |
*** jcru has joined #openstack-trove | 13:46 | |
*** mattgriffin has joined #openstack-trove | 13:46 | |
*** sgotliv has joined #openstack-trove | 13:52 | |
*** setho has quit IRC | 13:53 | |
*** sgotliv has quit IRC | 13:53 | |
*** coolsvap is now known as coolsvap|afk | 13:57 | |
*** radez_g0n3 is now known as radez | 14:01 | |
*** robertmyers has joined #openstack-trove | 14:07 | |
*** yidclare has quit IRC | 14:07 | |
*** denis_makogon has quit IRC | 14:13 | |
*** thedodd has joined #openstack-trove | 14:15 | |
*** NehaV has quit IRC | 14:18 | |
*** grapex has joined #openstack-trove | 14:19 | |
*** rueb7363 has joined #openstack-trove | 14:23 | |
*** rueb7363 has quit IRC | 14:27 | |
*** grapex has quit IRC | 14:30 | |
*** grapex has joined #openstack-trove | 14:30 | |
*** kevinconway has joined #openstack-trove | 14:42 | |
*** NehaV has joined #openstack-trove | 14:45 | |
*** NehaV has quit IRC | 14:50 | |
*** NehaV has joined #openstack-trove | 14:50 | |
*** ramishra_ has quit IRC | 14:53 | |
*** yogeshmehra has quit IRC | 15:00 | |
*** ramishra has joined #openstack-trove | 15:08 | |
*** TomasR_ has joined #openstack-trove | 15:12 | |
*** coolsvap|afk is now known as coolsvap | 15:15 | |
TomasR_ | Guys, I upgraded python-troveclient to 1.0.5 version | 15:17 |
TomasR_ | I ran this multiple times: | 15:17 |
TomasR_ | su -s /bin/sh -c "trove create mysqldemo 2 --size=2 --databases=DEMO --users demo:demo --datastore_version mysql-5.5 --datastore mysql" trove | 15:17 |
TomasR_ | This command was failing and it creted 9 instances in the build state | 15:18 |
TomasR_ | I ran it now again, just to capture an error message and post here, but it worked :) | 15:18 |
*** ramishra has quit IRC | 15:20 | |
TomasR_ | OK, the command was successful, but the instance status is ERROR. So we have 9 instances in this state: | 15:21 |
TomasR_ | | d23384d6-8fc1-4f3a-b5b1-00aaddec61cb | mysqldemo | mysql | mysql-5.5 | BUILD | 2 | 2 | | 15:21 |
TomasR_ | and one instance in this state: | 15:21 |
TomasR_ | | f2d7aa98-5b65-4ca9-a175-5ef3f0ebd928 | mysqldemo | mysql | mysql-5.5 | ERROR | 2 | 2 | | 15:22 |
TomasR_ | Any suggestion how to force remove all these instances? | 15:22 |
TomasR_ | trove delete d23384d6-8fc1-4f3a-b5b1-00aaddec61cb ERROR: Instance d23384d6-8fc1-4f3a-b5b1-00aaddec61cb is not ready. | 15:23 |
TomasR_ | I was able to delete the instance with status=ERROR | 15:23 |
*** NehaV has quit IRC | 15:23 | |
*** NehaV has joined #openstack-trove | 15:24 | |
*** ashishsnigam has joined #openstack-trove | 15:25 | |
*** michael-yu has joined #openstack-trove | 15:29 | |
*** michael-yu has quit IRC | 15:35 | |
*** michael-yu has joined #openstack-trove | 15:38 | |
*** michael-yu has quit IRC | 15:45 | |
TomasR_ | I recreated trove database, so please ignore my question about deleting mysql instances that are in BUILD state. | 15:47 |
*** ViswaV has joined #openstack-trove | 15:49 | |
*** ViswaV_ has joined #openstack-trove | 15:50 | |
*** TomasR_ has quit IRC | 15:51 | |
*** sriram_tesora has joined #openstack-trove | 15:52 | |
*** michael-yu has joined #openstack-trove | 15:52 | |
*** ViswaV has quit IRC | 15:54 | |
*** michael-yu_ has joined #openstack-trove | 15:55 | |
*** michael-yu_ has quit IRC | 15:55 | |
*** david74la has joined #openstack-trove | 15:56 | |
*** michael-yu has quit IRC | 15:57 | |
david74la | hola | 15:57 |
*** ViswaV_ is now known as ViswaV | 15:57 | |
*** david74la has left #openstack-trove | 15:59 | |
*** ramishra has joined #openstack-trove | 16:05 | |
*** eghobo has joined #openstack-trove | 16:11 | |
*** sriram_tesora has quit IRC | 16:11 | |
*** sbfox has joined #openstack-trove | 16:12 | |
*** ViswaV has quit IRC | 16:12 | |
esmute | Hi all, please review when you have a chance. They are short and quick. https://review.openstack.org/#/c/81379/, https://review.openstack.org/#/c/88464/, https://review.openstack.org/#/c/89717/, https://review.openstack.org/#/c/89719/ | 16:16 |
esmute | and https://review.openstack.org/#/c/86242/ (a bit longer) | 16:17 |
*** esp has joined #openstack-trove | 16:18 | |
*** ramishra has quit IRC | 16:19 | |
*** Barker has joined #openstack-trove | 16:21 | |
*** ramishra has joined #openstack-trove | 16:22 | |
*** eguz has joined #openstack-trove | 16:23 | |
*** sbfox1 has joined #openstack-trove | 16:23 | |
*** sbfox has quit IRC | 16:23 | |
dougshelley66 | esmute - i had some questions regarding your review of https://review.openstack.org/#/c/88591/6 | 16:25 |
dougshelley66 | esmute i put them inline as comments | 16:25 |
esmute | Hi dougshelley66 | 16:25 |
esmute | yeah i am reading it now.. | 16:25 |
dougshelley66 | ah thanks | 16:25 |
*** eghobo has quit IRC | 16:27 | |
esmute | what i think is that i do understand that if you try to merge your logic to the existing fuction, it'd probaby look too big and confusing... (if you break down the 'elif' statement in https://github.com/openstack/trove/blob/master/trove/instance/models.py#L799) | 16:28 |
esmute | and we want to clean thinkgs cleaner by having them separate. | 16:28 |
*** Barker has quit IRC | 16:30 | |
mat-lowery | Mongo question for anyone: Currently in config.template, bind_ip = 127.0.0.1. During prepare, this line is changed to the VM IP. However, with start_db_with_conf_changes or reset_configuration, it's reset to 127.0.0.1 meaning that the guestagent connection test fails and it thinks it's SHUTDOWN. Do I fix this by doing the IP lookup in the aforementioned methods or is removing the bind_ip line altogether (and therefore binding to all | 16:30 |
mat-lowery | interfaces) acceptable? | 16:30 |
esmute | but at the same time, it looks sorta duplicated....and i'll be afraid that if new features/actions are implemented and they need to apply its own validation based on the status, we might have a lot of 'validate_can_perform' type of functions | 16:30 |
mat-lowery | I'd prefer to remove bind_ip altogether but wanted some security perspective. | 16:31 |
esmute | @dougshelley66 in reality, i would have prefer that the unassign_configuration() and assign_configuration() were in the configuration model and not the instance model (similar to assigning security groups). That way this specific validation method that only pertains to assigning configurations, lives in configurations | 16:32 |
esmute | but that is probably outside the scope for this bug fix | 16:32 |
dougshelley66 | esmute i would suspect that is true | 16:33 |
dougshelley66 | given those 2 methods pre-dated this bug | 16:33 |
*** Barker has joined #openstack-trove | 16:33 | |
*** ramishra has quit IRC | 16:33 | |
*** ViswaV has joined #openstack-trove | 16:33 | |
esmute | i'll +1 since you proved that my original suggestion (incorporating the assign config logic to the exisiting method) would make the function too confusing with more if/else than it probably needs | 16:34 |
dougshelley66 | esmute - ok thx - should i file a bug to move the code as you suggest? | 16:35 |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 16:42 |
esmute | dougshelley66: It is not too high prio, but it would be nice. | 16:43 |
dougshelley66 | ok np | 16:44 |
esmute | mat-lowery: I am not sure what the ramifications are for removing the bind_ip, but it seems that your former suggestion is safer (use IP lookup) | 16:49 |
*** SushillKM has joined #openstack-trove | 16:50 | |
mat-lowery | Hi esmute: I thought about that and here's my thinking: mysql already listens on all interfaces. I was going through the others to see what they do. Seeing as how the other config.templates don't have any IP addresses (that I could find), I assume I'll see the same thing with the others. | 16:51 |
mat-lowery | So my argument for #2 is "there's a precedent." Not sure if that's a valid argument. :) | 16:51 |
*** harlowja_away is now known as harlowja | 16:51 | |
esmute | yeah.. if that is the case, it was probably added to work as a default (or as a example).. | 16:57 |
*** Barker has quit IRC | 16:57 | |
esmute | if other's template dont have it, i think we can safely assume we can remove it. | 16:57 |
*** Barker has joined #openstack-trove | 17:03 | |
*** thedodd has quit IRC | 17:04 | |
mat-lowery | thanks esmute | 17:04 |
*** thedodd has joined #openstack-trove | 17:06 | |
*** SushilKM has joined #openstack-trove | 17:06 | |
*** SushillKM has quit IRC | 17:07 | |
*** coolsvap is now known as coolsvap|afk | 17:08 | |
*** SushilKM has quit IRC | 17:14 | |
*** SushillKM has joined #openstack-trove | 17:14 | |
*** ranjitha has joined #openstack-trove | 17:16 | |
*** sbfox1 has quit IRC | 17:16 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 17:16 |
*** SushillKM has quit IRC | 17:20 | |
*** mattgriffin has quit IRC | 17:27 | |
*** thedodd has quit IRC | 17:28 | |
*** SushillKM has joined #openstack-trove | 17:31 | |
*** casanch1 has quit IRC | 17:31 | |
*** mattgriffin has joined #openstack-trove | 17:31 | |
*** eguz has quit IRC | 17:35 | |
*** eghobo has joined #openstack-trove | 17:36 | |
*** NehaV1 has joined #openstack-trove | 17:37 | |
*** thedodd has joined #openstack-trove | 17:37 | |
*** NehaV2 has joined #openstack-trove | 17:37 | |
*** NehaV1 has quit IRC | 17:37 | |
*** NehaV has quit IRC | 17:39 | |
*** ranjitha has quit IRC | 17:41 | |
*** yidclare has joined #openstack-trove | 17:45 | |
juice | mat-lowery: esmute: good catch on the ip bind issue. As we move to Neutron, we will likely have multiple interfaces connected to a trove instance. We do not want the datastore to listen on interfaces/ips on the management interface, only the customer interface. | 17:46 |
juice | mat-lowery: esmute: having said that, as we work in the neutron implementation/support, this lookup of the correct interface can be handled in that patch | 17:47 |
mat-lowery | gotcha juice. thanks. | 17:51 |
*** SushilKM has joined #openstack-trove | 17:53 | |
*** ranjitha has joined #openstack-trove | 17:55 | |
*** SushillKM has quit IRC | 17:55 | |
*** SushilKM has quit IRC | 17:57 | |
*** thedodd has quit IRC | 17:59 | |
*** yogesh has joined #openstack-trove | 17:59 | |
*** thedodd has joined #openstack-trove | 18:01 | |
*** sbfox has joined #openstack-trove | 18:01 | |
*** NehaV2 has quit IRC | 18:05 | |
*** NehaV has joined #openstack-trove | 18:08 | |
*** amcrn has joined #openstack-trove | 18:09 | |
*** NehaV has quit IRC | 18:23 | |
*** NehaV has joined #openstack-trove | 18:23 | |
juice | code reviewers - if you want to join the swarm, this query in gerrit will somewhat help to find patches that are being actively reviewed but have not yet been approved (status:open project: openstack/trove label:Verified+1 label:CodeReview+1 -label:Approved) | 18:29 |
*** casanch1 has joined #openstack-trove | 18:30 | |
esmute | Thanks juice. That's useful | 18:31 |
*** ashishsnigam has quit IRC | 18:31 | |
juice | if you drop the "label: CodeReview+1" it will widen the net to get patches that are in various states of review. For some reason the "verified" doesn't seem very reliable since it does pull back -1s as well | 18:32 |
esmute | juice: i didnt get an -1s when i used that query | 18:33 |
juice | true but when you remove the "CodeReviewed" predicate, you will | 18:34 |
esmute | i think you meant 'review'? | 18:34 |
esmute | yes | 18:34 |
*** ramishra has joined #openstack-trove | 18:34 | |
*** igor__ has joined #openstack-trove | 18:35 | |
*** thedodd has quit IRC | 18:37 | |
*** ramishra has quit IRC | 18:39 | |
*** thedodd has joined #openstack-trove | 18:40 | |
*** ViswaV has quit IRC | 18:42 | |
*** doddstack has joined #openstack-trove | 18:46 | |
*** thedodd has quit IRC | 18:49 | |
openstackgerrit | Mat Lowery proposed a change to openstack/trove: Bind to all interfaces for MongoDB https://review.openstack.org/90194 | 18:51 |
*** ramishra has joined #openstack-trove | 18:55 | |
openstackgerrit | Peter Stachowski proposed a change to openstack/python-troveclient: Changed Trove CLI list headers to match Nova CLI https://review.openstack.org/89930 | 18:58 |
*** ramishra has quit IRC | 19:00 | |
*** Barker has quit IRC | 19:03 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Fixes tests so that they pass when run on OS X https://review.openstack.org/88464 | 19:07 |
annashen | grapex: can you talk more about the decorator issue that you have with importing config early? | 19:08 |
grapex | annashen: Sure | 19:09 |
grapex | annashen: Basically we need to avoid making decorator arguments driven by the test config or other dynamic variables as it makes the tests harder to reason about | 19:10 |
grapex | years back we used them all over the place to disable tests if the config wasn't set to use certain features | 19:10 |
grapex | what I discovered was that it made it very difficult to know that tests weren't running | 19:11 |
*** serverascode has quit IRC | 19:11 | |
grapex | It got pretty bad so at Rax we came to a consensus to not use them like that | 19:11 |
grapex | annashen: Does that answer your question? | 19:11 |
grapex | You can still skip tests that are based on functionality that is disabled by either not running the group | 19:11 |
grapex | or if running the group is unavoidable you can have an if statement in the test function itself which explicitly raises SkipTest | 19:12 |
grapex | SlickNik vipul: FYI: ^^ | 19:12 |
*** Barker has joined #openstack-trove | 19:12 | |
*** serverascode has joined #openstack-trove | 19:13 | |
annashen | grapex: thanks for comments | 19:14 |
annashen | grapex: thanks for sharing | 19:15 |
grapex | annashen: No problem. Let me know if you have any other questions. | 19:15 |
annashen | grapes, now i can see it is better practice, thanks | 19:16 |
*** demorris has joined #openstack-trove | 19:26 | |
*** saurabhs has joined #openstack-trove | 19:36 | |
*** ViswaV has joined #openstack-trove | 19:38 | |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Moved the apidocs from openstack/database-api https://review.openstack.org/87807 | 19:41 |
openstackgerrit | Tim Simpson proposed a change to openstack/trove: Make sure eventlet starts correctly https://review.openstack.org/89425 | 19:42 |
*** ranjitha has quit IRC | 19:43 | |
*** coolsvap|afk has quit IRC | 19:44 | |
*** ViswaV has quit IRC | 19:46 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 19:48 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Fixes test so that it passes when run on OS X https://review.openstack.org/88464 | 19:56 |
*** ramishra has joined #openstack-trove | 19:56 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Fixes test so that it passes when run on OS X https://review.openstack.org/88464 | 19:57 |
*** sbfox has quit IRC | 19:57 | |
*** ramishra has quit IRC | 20:01 | |
*** sbfox has joined #openstack-trove | 20:02 | |
*** demorris has quit IRC | 20:02 | |
*** harlowja is now known as harlowja_away | 20:06 | |
*** mattgriffin has quit IRC | 20:14 | |
*** mattgriffin has joined #openstack-trove | 20:14 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add integration test for Neutron support https://review.openstack.org/82673 | 20:18 |
*** rueb7363 has joined #openstack-trove | 20:23 | |
*** rueb7363 has quit IRC | 20:32 | |
*** casanch1_ has joined #openstack-trove | 20:32 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests https://review.openstack.org/87856 | 20:35 |
*** casanch1 has quit IRC | 20:36 | |
*** radez is now known as radez_g0n3 | 20:40 | |
hub_cap | juice: esmute around? | 20:40 |
hub_cap | lets squash this comment thing now | 20:41 |
juice | yep | 20:41 |
hub_cap | first off, 1) reasons, 2) changes are not necessary | 20:41 |
juice | emsute is here too | 20:41 |
hub_cap | really they are never necessary | 20:41 |
esmute | hub_cap: ok | 20:41 |
hub_cap | its some construct denis started | 20:41 |
juice | you mean the format? | 20:41 |
hub_cap | and no one in trove-core enforces it | 20:41 |
hub_cap | yes | 20:41 |
hub_cap | i typically, if needed, write a small paragraph after | 20:41 |
juice | true but there should be some information as to what changed and why | 20:41 |
hub_cap | https://review.openstack.org/#/c/86808/ | 20:42 |
* juice Topic/Headline | 20:42 | |
juice | return | 20:42 |
hub_cap | thats an example of a good msg, cuz i wrote it ;) | 20:42 |
juice | tab Description | 20:42 |
juice | hub_cap: of course :) | 20:42 |
esmute | so short and descriptive title (not longer so that it doesnt break pep8). And some bullet points/short sentences describing the work. Is this good enough? | 20:42 |
hub_cap | yes exactly esmute | 20:42 |
hub_cap | but the _why_ needs to come in the title | 20:42 |
hub_cap | not the _what_ persay | 20:42 |
hub_cap | so saying "fixing for os X" is not really why | 20:43 |
juice | hub_cap: i found a small typo in your commit message so I am going to -1 it | 20:43 |
hub_cap | juice: plz do | 20:43 |
juice | ;) | 20:43 |
hub_cap | separation | 20:43 |
hub_cap | i HATE having typos in my commit msgs | 20:43 |
hub_cap | it would make me quite happy for u to -1 it | 20:43 |
hub_cap | im a commit msg stickler | 20:43 |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add integration test for Neutron support https://review.openstack.org/82673 | 20:43 |
esp | I have typos in code | 20:43 |
hub_cap | lol esp it is python | 20:44 |
* esp just kidding…sorta | 20:44 | |
esmute | Ok.. this is good to know. | 20:44 |
juice | hub_cap: btw is there a code style guide/commit message style guide for openstack? | 20:44 |
hub_cap | i always find this to be a good reference esmute | 20:44 |
hub_cap | http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html | 20:44 |
esmute | ill mentioned it to denis_mokogon when he is around | 20:45 |
hub_cap | juice: there is and there isint | 20:45 |
hub_cap | https://wiki.openstack.org/wiki/GitCommitMessages | 20:45 |
hub_cap | but really its not a style guide | 20:45 |
hub_cap | wriitng good commit msgs is more than style so to speak | 20:45 |
hub_cap | and the 1) reasons 2) changes thing i have no idea why denis / snowdust do it | 20:45 |
hub_cap | but they love it | 20:46 |
hub_cap | i personally dislike it and i think a paragraph is a better explaination | 20:46 |
juice | paragraph or bullets is my pref | 20:46 |
openstackgerrit | Daniel Salinas proposed a change to openstack/trove: Add instance metadata functionality to trove https://review.openstack.org/82123 | 20:46 |
hub_cap | but u can only be a stickler to so many things before people start s/st/d you | 20:46 |
hub_cap | juice: bullets were my pref in teh day | 20:46 |
hub_cap | now i find that a small pg is nicer.. like u know what my motivation was for that commit i pasted to u | 20:47 |
hub_cap | i dont think i couldve done that in bullets | 20:47 |
hub_cap | but bullets are fine for smaller changes | 20:47 |
hub_cap | but after a while i found i was just doing things like | 20:47 |
hub_cap | * added tests | 20:47 |
hub_cap | * fixed up the api | 20:47 |
hub_cap | shit u can look @ the code to see that | 20:47 |
juice | hub_cap: good point | 20:47 |
hub_cap | so i like to give a reason (w/o putting 1) reason) | 20:47 |
juice | ok esmute: let's get that patch done :) | 20:49 |
hub_cap | https://github.com/openstack/trove/commit/475927f35d7c47a4c9fb45c06d24c825bc02a77d | 20:49 |
hub_cap | see that doesnt really tell me why | 20:49 |
hub_cap | i look at my old msgs and im ashamed of past me sometimes :) | 20:49 |
hub_cap | but u can see i used to be all about the Sentence\n\n*\n*\n* | 20:50 |
*** sbfox has quit IRC | 20:50 | |
juice | hub_cap: thanks for the time and the examples | 20:52 |
hub_cap | npnp | 20:52 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Mocks out file.open to not rely on OS dependent files https://review.openstack.org/88464 | 20:53 |
openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests https://review.openstack.org/87856 | 20:53 |
esp | mat-lowery: ping | 20:54 |
esmute | thank you juice hub_cap. Lets make sure everyone are in sync with this so that we dont get -1s because the commit messages dont suite someone's style | 20:54 |
mat-lowery | hello esp | 20:54 |
esp | hey mat-lowery, how’s it going? | 20:55 |
juice | esmute: maybe we can spend 2 minutes on this in the next meeting | 20:55 |
esp | mat-lowery: can you take another look at this at your earliest convenience? https://review.openstack.org/#/c/81682/ | 20:55 |
esmute | juice: yeah.. ill put it in the trove agenda | 20:55 |
hub_cap | esmute: if yer getting a -1 and are being told u have to add the silly reasons/changes thing, u come talk to me | 20:55 |
hub_cap | there is one person who adds it like that | 20:56 |
hub_cap | so he cant make everyone change to suit his needs :) | 20:56 |
mat-lowery | esp: Sure. | 20:56 |
esp | mat-lowery: thx! | 20:56 |
*** ramishra has joined #openstack-trove | 20:57 | |
esmute | hub_cap: Sounds good. Thank you! | 20:58 |
hub_cap | np | 20:58 |
*** harlowja_away is now known as harlowja | 21:01 | |
*** pdmars has quit IRC | 21:02 | |
*** ramishra has quit IRC | 21:02 | |
*** casanch1_ has quit IRC | 21:05 | |
*** casanch1 has joined #openstack-trove | 21:05 | |
*** casanch1 has quit IRC | 21:30 | |
*** NehaV has quit IRC | 21:48 | |
*** kevinconway has quit IRC | 21:50 | |
*** sbfox has joined #openstack-trove | 21:51 | |
*** robertmyers has quit IRC | 21:54 | |
*** michael-yu has joined #openstack-trove | 21:56 | |
*** ramishra has joined #openstack-trove | 21:58 | |
*** ramishra has quit IRC | 22:02 | |
*** saurabhs has quit IRC | 22:05 | |
*** amcrn has quit IRC | 22:08 | |
*** jcru has quit IRC | 22:09 | |
*** saurabhs has joined #openstack-trove | 22:10 | |
*** achampion has quit IRC | 22:15 | |
*** shakamunyi has quit IRC | 22:20 | |
*** yogesh has quit IRC | 22:24 | |
*** doddstack has quit IRC | 22:34 | |
*** michael-yu has quit IRC | 22:40 | |
*** michael-yu has joined #openstack-trove | 22:46 | |
*** michael-yu has quit IRC | 22:48 | |
*** michael-yu has joined #openstack-trove | 22:51 | |
*** mattgriffin has quit IRC | 22:56 | |
*** etoews has joined #openstack-trove | 22:57 | |
*** amcrn has joined #openstack-trove | 22:57 | |
*** ramishra has joined #openstack-trove | 22:58 | |
*** michael-yu_ has joined #openstack-trove | 23:01 | |
*** michael-yu has quit IRC | 23:03 | |
*** michael-yu_ is now known as michael-yu | 23:03 | |
*** ramishra has quit IRC | 23:03 | |
*** lifeless has quit IRC | 23:04 | |
*** lifeless has joined #openstack-trove | 23:05 | |
*** flaper87 is now known as flaper87|afk | 23:08 | |
*** sbfox1 has joined #openstack-trove | 23:10 | |
*** sbfox has quit IRC | 23:11 | |
*** eguz has joined #openstack-trove | 23:19 | |
*** eguz has quit IRC | 23:19 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 23:22 |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats https://review.openstack.org/81682 | 23:22 |
*** mattgriffin has joined #openstack-trove | 23:22 | |
*** achampion has joined #openstack-trove | 23:22 | |
*** eghobo has quit IRC | 23:23 | |
*** saurabhs has left #openstack-trove | 23:27 | |
*** Barker has quit IRC | 23:30 | |
*** michael-yu has quit IRC | 23:32 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS) https://review.openstack.org/88349 | 23:35 |
*** Barker has joined #openstack-trove | 23:35 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add integration test for Neutron support https://review.openstack.org/82673 | 23:36 |
*** grapex has quit IRC | 23:37 | |
openstackgerrit | Doug Shelley proposed a change to openstack/trove: Correct inconsistent state issues with config https://review.openstack.org/88591 | 23:41 |
*** ravikumar_hp has quit IRC | 23:41 | |
*** ViswaV has joined #openstack-trove | 23:45 | |
*** ViswaV_ has joined #openstack-trove | 23:45 | |
*** Barker has quit IRC | 23:47 | |
*** Barker has joined #openstack-trove | 23:48 | |
*** ViswaV has quit IRC | 23:49 | |
*** michael-yu has joined #openstack-trove | 23:50 | |
dougshelley66 | juice, esmute: would you mind looking at https://review.openstack.org/#/c/88591/ again? | 23:52 |
esmute | dougshelley66: Sure.. will do | 23:53 |
dougshelley66 | esmute many thanks | 23:53 |
*** eghobo has joined #openstack-trove | 23:55 | |
*** ramishra has joined #openstack-trove | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!