Thursday, 2014-04-24

*** sbfox has joined #openstack-trove00:00
*** sbfox has quit IRC00:05
*** eguz has joined #openstack-trove00:19
*** ranjitha has quit IRC00:20
*** eghobo has quit IRC00:23
*** mattgriffin has quit IRC00:25
*** amcrn has joined #openstack-trove00:34
*** ViswaV has quit IRC00:45
*** michael-yu has quit IRC00:48
*** yidclare has quit IRC00:50
*** harlowja has joined #openstack-trove01:00
*** crucif0rm has quit IRC01:02
*** khyati_ has quit IRC01:03
*** erkules_ has joined #openstack-trove01:28
*** erkules has quit IRC01:31
*** eguz has quit IRC01:33
*** nosnos has joined #openstack-trove01:36
*** SushillKM has joined #openstack-trove01:57
*** SushillKM has quit IRC02:04
*** coolsvap has quit IRC02:05
*** coolsvap has joined #openstack-trove02:10
*** Barker has quit IRC02:12
*** haomaiw__ has quit IRC02:13
*** haomaiwang has joined #openstack-trove02:13
*** rueb7363 has joined #openstack-trove02:18
*** mattgriffin has joined #openstack-trove02:39
*** amcrn has quit IRC02:41
*** harlowja is now known as harlowja_away03:09
*** mattgriffin has quit IRC03:18
*** rueb7363 has quit IRC03:22
*** NehaV has joined #openstack-trove03:23
*** esp has left #openstack-trove03:23
openstackgerritDan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats  https://review.openstack.org/8168203:24
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522503:24
*** sbfox has joined #openstack-trove03:25
*** sbfox has quit IRC03:27
*** sbfox has joined #openstack-trove03:32
*** ViswaV has joined #openstack-trove03:34
*** NehaV has quit IRC03:34
*** NehaV has joined #openstack-trove03:35
*** ViswaV_ has joined #openstack-trove03:37
*** ViswaV has quit IRC03:39
*** erkules_ is now known as erkules03:41
openstackgerritDan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats  https://review.openstack.org/8168203:44
*** ramishra has joined #openstack-trove03:46
*** NehaV has quit IRC03:48
*** _shalini has quit IRC03:53
*** haomai___ has joined #openstack-trove03:55
*** michael-yu has joined #openstack-trove03:57
*** haomaiwang has quit IRC03:59
*** michael-yu has quit IRC04:00
*** eghobo has joined #openstack-trove04:01
*** coolsvap has quit IRC04:05
*** amcrn has joined #openstack-trove04:06
*** sbfox has quit IRC04:06
*** coolsvap has joined #openstack-trove04:07
*** sbfox has joined #openstack-trove04:08
cp16nethmm anyone around?04:09
cp16netwhen i am running my vm i'm not seeing all the logging from taskmanager after making changes and restarting it from the screen session04:11
cp16netbut it looks like the calls are running still04:11
cp16netit seems like there is a thread running or something thats not being logged04:14
cp16netkinda weird04:14
cp16netjust curious if anyone else has seen this kind of behavior04:15
*** harlowja_away is now known as harlowja04:18
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522504:19
*** ViswaV_ has quit IRC04:20
openstackgerritAnna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS)  https://review.openstack.org/8834904:20
*** michael-yu has joined #openstack-trove04:23
*** haomai___ has quit IRC04:24
*** haomaiwang has joined #openstack-trove04:25
*** yidclare has joined #openstack-trove04:48
*** sgotliv has joined #openstack-trove04:53
*** haomaiw__ has joined #openstack-trove04:54
*** haomaiwang has quit IRC04:57
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985005:00
openstackgerritCraig Vyvial proposed a change to openstack/trove-integration: Configurations stored in the database  https://review.openstack.org/7985205:00
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adding configuration paramters mgmt api  https://review.openstack.org/7985105:00
*** rwsu has quit IRC05:07
*** nosnos has quit IRC05:08
*** ashishsnigam has joined #openstack-trove05:15
*** rwsu has joined #openstack-trove05:23
*** sgotliv has quit IRC05:32
*** nosnos has joined #openstack-trove05:35
*** saurabhs has left #openstack-trove05:35
*** eghobo has quit IRC05:39
*** eghobo has joined #openstack-trove05:39
*** sbfox has quit IRC05:42
*** michael-yu has quit IRC05:43
*** eguz has joined #openstack-trove05:46
*** michael-yu has joined #openstack-trove05:47
*** yogeshmehra has joined #openstack-trove05:47
*** eghobo has quit IRC05:50
*** NehaV has joined #openstack-trove05:54
*** SushillKM has joined #openstack-trove05:58
*** michael-yu has quit IRC06:01
*** NehaV has quit IRC06:03
*** haomaiw__ has quit IRC06:10
*** haomaiwa_ has joined #openstack-trove06:10
*** yogeshmehra has quit IRC06:11
*** michael-yu has joined #openstack-trove06:19
openstackgerritOpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex  https://review.openstack.org/9001006:22
*** harlowja is now known as harlowja_away06:30
*** michael-yu has quit IRC06:37
*** flaper87|afk is now known as flaper8706:38
*** yogeshmehra has joined #openstack-trove06:41
*** shakamunyi has quit IRC06:42
*** ramishra has quit IRC06:45
*** ramishra has joined #openstack-trove06:46
openstackgerritShashank Gupta proposed a change to openstack/trove: Corrected the assertion message in test_dbaas.py file  https://review.openstack.org/8981506:53
*** michael-yu has joined #openstack-trove07:00
*** amcrn has quit IRC07:04
*** shakamunyi has joined #openstack-trove07:08
*** shakamunyi has quit IRC07:12
*** michael-yu has quit IRC07:12
*** eguz has quit IRC07:13
openstackgerritShashank Gupta proposed a change to openstack/trove: Corrected the assert message in test_dbaas.py  https://review.openstack.org/8981507:15
*** michael-yu has joined #openstack-trove07:16
*** ramishra has quit IRC07:24
*** michael-yu has quit IRC07:32
*** michael-yu has joined #openstack-trove07:38
*** sgotliv has joined #openstack-trove07:59
*** sgotliv has quit IRC07:59
*** michael-yu has quit IRC07:59
*** sgotliv has joined #openstack-trove08:00
*** shakamunyi has joined #openstack-trove08:08
*** shakamunyi has quit IRC08:13
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812308:16
*** nosnos has quit IRC08:18
*** yogeshmehra has quit IRC08:19
*** michael-yu has joined #openstack-trove08:20
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812308:23
*** michael-yu_ has joined #openstack-trove08:31
*** michael-yu has quit IRC08:33
*** michael-yu_ is now known as michael-yu08:33
*** michael-yu has quit IRC08:36
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812308:47
*** haomai___ has joined #openstack-trove09:02
*** haomaiwa_ has quit IRC09:06
*** TomasR_ has joined #openstack-trove09:06
TomasR_Hi, guys, I follow the steps from this document: http://docs-draft.openstack.org/25/88225/4/check/gate-openstack-manuals-tox-doc-publish-checkbuild/6819c34/publish-docs/trunk/install-guide/install/apt/content/trove-install.html09:06
TomasR_On the last Step (12): I got one error with trove-conductor:09:07
TomasR_service trove-api restart trove-api stop/waiting trove-api start/running, process 1039409:07
TomasR_service trove-taskmanager restart trove-taskmanager stop/waiting trove-taskmanager start/running, process 1064409:07
TomasR_service trove-conductor restart trove-conductor: unrecognized service09:07
SlickNikTomasR_: There is an upstream ubuntu bug with packaging.09:08
SlickNikTomasR_: Essentially trove conductor is not being packaged.09:09
*** shakamunyi has joined #openstack-trove09:09
TomasR_We used a configuration template file from https://raw.githubusercontent.com/openstack/trove/master/etc/trove/trove-guestagent.conf.sample09:09
SlickNikTomasR_:  https://bugs.launchpad.net/ubuntu/+source/openstack-trove/+bug/130852309:10
*** shakamunyi has quit IRC09:14
*** denis_makogon has joined #openstack-trove09:21
*** shivam has quit IRC09:26
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812309:46
*** shivamshukla has joined #openstack-trove09:46
TomasR_Guys, when I run this command: su -s /bin/sh -c "/usr/bin/python /usr/bin/trove-conductor --config-file=/etc/trove/trove-conductor.conf" trove09:59
TomasR_In the log files I see: 2014-04-24 11:56:24.142 1465 TRACE trove.openstack.common.threadgroup ImportError: No module named rabbit09:59
TomasR_I have these packages installed:10:00
TomasR_aptitude search rabbit | grep pyth i A python-librabbitmq              - AMQP Client using the rabbitmq-c library   p   python-librabbitmq:i386         - AMQP Client using the rabbitmq-c library10:00
TomasR_Am I missing some modules?10:00
SlickNikTomasR_: your trove-conductor conf likely has rabbitmq settings in an incorrect format.10:02
TomasR_OK, let me check10:03
SlickNikTomasR_: Use https://raw.githubusercontent.com/openstack/trove/master/etc/trove/trove-conductor.conf.sample as a guideline for your trove-conductor.conf10:03
TomasR_I have this:10:03
TomasR_[DEFAULT] verbose = True debug = True control_exchange = trove log_dir=/var/log/trove log_file=trove-conductor.log trove_auth_url = http://controller:5000/v2.0 nova_compute_url = http://controller:8774/v2 cinder_url = http://controller:8776/v1 sql_connection = mysql://trove:trove@controller/trove10:03
SlickNiknp10:03
TomasR_rabbit_host=controller10:04
TomasR_rpc_backend = rabbit10:04
*** SnowDust has joined #openstack-trove10:04
SlickNikremove the rpc_backend setting from the conf.10:05
SlickNikand replace it with rpc_backend = trove.openstack.common.rpc.impl_kombu10:05
TomasR_ok, let me try it10:06
SlickNikYou may also need to add:10:06
SlickNik# The RabbitMQ userid. (string value)10:06
SlickNik#rabbit_userid=guest10:06
SlickNik# The RabbitMQ password. (string value)10:06
SlickNikrabbit_password=f7999d1955c5014aa32c10:06
SlickNik# The RabbitMQ virtual host. (string value)10:06
SlickNik#rabbit_virtual_host=/10:06
SlickNikdepending on your rabbit conf10:06
SlickNik(especially the password bit for your particular rabbit server)10:07
openstackgerritshivam shukla proposed a change to openstack/trove: Tests for heat based instance workflow  https://review.openstack.org/6649910:10
*** shakamunyi has joined #openstack-trove10:10
TomasR_changing rpc_backend parameter seems to be sufficient, thanks. I got trove-conductor running now10:12
SlickNikTomasR_: You're welcome!10:12
*** shakamunyi has quit IRC10:14
*** nosnos has joined #openstack-trove10:15
*** sgotliv has quit IRC10:19
TomasR_Guys, one more question. "trove list" works now, but when I execute this command:10:25
TomasR_trove create mysqldemo 2 --size=2 --databases=DEMO --users demo:demo --datastore_version mysql-5.5 --datastore mysql10:25
TomasR_I get this error:10:25
TomasR_error: unrecognized arguments: --datastore_version mysql-5.5 --datastore mysql10:25
TomasR_Shall I just skip datastore_version and datastore parameters?10:25
TomasR_I checked in MySQL trove database directly , I have mysql-5.5 datastore version  and mysql datastore listed, but some issue with trove syntax10:28
SlickNiktry using the UUIDs for them instead of the name(s)10:28
SlickNikYou should be able to skip those args as well, it should fall back to the default.10:29
SlickNik(which should be mysql 5.5 in this setup)10:29
TomasR_Also: I tried creating using web interface. I now have a new menu: Databases, but I got this error: Error: There was an error submitting the form. Please try again.10:35
TomasR_I executed this now: trove create --size=2 --databases=DEMO --users demo:demo --availability_zone=nova mysqldemo 210:37
TomasR_ERROR: Default version for datastore 'mysql' not found.10:37
SlickNikWhat's the output of "trove datastore-version-list mysql"?10:39
TomasR_I get syntax error:10:40
TomasR_error: argument <subcommand>: invalid choice: u'datastore-version-list'10:40
dougshelley66maybe he should start with trove datastore-list?10:41
SlickNikThe previous output seems to indicate that he's got a "mysql" datastore already, I think.10:43
SlickNik(and it's being correctly picked up as the default)10:43
TomasR_This is not available either. Maybe I'm running some old / older version of trove?10:43
dougshelley66you are saying that trove datastore-list didn't work?10:44
SlickNikCould also be an older version of python-troveclient.10:45
TomasR_I only have those commands available, when I run trove help10:46
TomasR_backup-create backup-delete backup-list backup-list-instance List backup-show create database-create database-delete database-list delete flavor-list flavor-show limit-list list resize-flavor resize-volume restart root-enable root-show secgroup-add-rule secgroup-delete-rule Deletes secgroup-list secgroup-show show user-create user-delete user-grant-access user-list user-revoke-access user-show user-show-access user-update-a10:46
*** sgotliv has joined #openstack-trove10:46
dougshelley66certainly some things missing10:47
SlickNikTomasR_: Yup you probably need to get a newer version of python-troveclient. :)10:48
*** sgotliv has quit IRC10:48
dougshelley66did you get python-troveclient from the apt-repo in the first step?10:49
*** sgotliv has joined #openstack-trove10:49
TomasR_I did this apt-get install python-trove python-troveclient python-glanceclient \   trove-common trove-api trove-taskmanager10:49
TomasR_As suggested in :10:49
TomasR_http://docs.openstack.org/icehouse/install-guide/install/apt-debian/content/trove-install.html10:49
dougshelley66right step #110:49
dougshelley66and you are running on 14.04?10:50
TomasR_cat /etc/issue Ubuntu 14.04 LTS \n \l10:51
TomasR_I actually followed later (draft) version of the document:10:51
TomasR_http://docs-draft.openstack.org/25/88225/4/check/gate-openstack-manuals-tox-doc-publish-checkbuild/6819c34/publish-docs/trunk/install-guide/install/apt/content/trove-install.html10:51
dougshelley66looks like we need to validate what is currently in that apt repo10:52
TomasR_Is the a link available with the latest packages that I can manually install using dpkg?10:53
dougshelley66i believe the packages are produced by Canonical so i don't know the answer to that question10:55
SlickNikTomasR_: The latest package can be installed via pip from pypi10:57
SlickNikTomasR_: Seems like the latest ubuntu package doesn't have the latest client bits.10:57
SlickNikTomasR_: https://pypi.python.org/pypi/python-troveclient10:58
TomasR_SlickNik, thanks. I'll try to use the latest version. I need to run now and catch a train to Brussels. So I'll resume playing with trove on Friday. Thanks a lot for useful tips10:58
SlickNikTomasR_: np, happy to help!10:58
*** mattgriffin has joined #openstack-trove10:59
*** SnowDust has quit IRC11:01
*** TomasR_ has quit IRC11:02
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install  https://review.openstack.org/7812311:07
*** shakamunyi has joined #openstack-trove11:11
*** shakamunyi has quit IRC11:15
*** SushillKM has quit IRC11:30
*** ramishra has joined #openstack-trove11:34
*** ashestakov__ has joined #openstack-trove11:35
*** shakamunyi has joined #openstack-trove11:57
*** achampion has quit IRC11:59
*** mattgriffin has quit IRC12:01
*** pdmars has joined #openstack-trove12:02
*** ashishsnigam has quit IRC12:14
*** yogeshmehra has joined #openstack-trove12:20
*** yogeshmehra has quit IRC12:25
*** nosnos has quit IRC12:42
*** NehaV has joined #openstack-trove12:44
*** NehaV has quit IRC13:01
*** SnowDust has joined #openstack-trove13:03
*** NehaV has joined #openstack-trove13:06
*** achampion has joined #openstack-trove13:09
*** NehaV has quit IRC13:10
*** NehaV has joined #openstack-trove13:11
*** coolsvap is now known as coolsvap|afk13:13
*** coolsvap|afk is now known as coolsvap13:13
*** ramishra_ has joined #openstack-trove13:21
*** casanch1 has joined #openstack-trove13:22
*** ramishra has quit IRC13:22
*** SnowDust has quit IRC13:26
*** sgotliv has quit IRC13:38
*** yogeshmehra has joined #openstack-trove13:41
*** jcru has joined #openstack-trove13:46
*** mattgriffin has joined #openstack-trove13:46
*** sgotliv has joined #openstack-trove13:52
*** setho has quit IRC13:53
*** sgotliv has quit IRC13:53
*** coolsvap is now known as coolsvap|afk13:57
*** radez_g0n3 is now known as radez14:01
*** robertmyers has joined #openstack-trove14:07
*** yidclare has quit IRC14:07
*** denis_makogon has quit IRC14:13
*** thedodd has joined #openstack-trove14:15
*** NehaV has quit IRC14:18
*** grapex has joined #openstack-trove14:19
*** rueb7363 has joined #openstack-trove14:23
*** rueb7363 has quit IRC14:27
*** grapex has quit IRC14:30
*** grapex has joined #openstack-trove14:30
*** kevinconway has joined #openstack-trove14:42
*** NehaV has joined #openstack-trove14:45
*** NehaV has quit IRC14:50
*** NehaV has joined #openstack-trove14:50
*** ramishra_ has quit IRC14:53
*** yogeshmehra has quit IRC15:00
*** ramishra has joined #openstack-trove15:08
*** TomasR_ has joined #openstack-trove15:12
*** coolsvap|afk is now known as coolsvap15:15
TomasR_Guys, I upgraded python-troveclient to 1.0.5 version15:17
TomasR_I ran this multiple times:15:17
TomasR_su -s /bin/sh -c "trove create mysqldemo 2 --size=2 --databases=DEMO --users demo:demo --datastore_version mysql-5.5 --datastore mysql" trove15:17
TomasR_This command was failing and it creted 9 instances in the build state15:18
TomasR_I ran it now again, just to capture an error message and post here, but it worked :)15:18
*** ramishra has quit IRC15:20
TomasR_OK, the command was successful, but the instance status is ERROR. So we have 9 instances in this state:15:21
TomasR_| d23384d6-8fc1-4f3a-b5b1-00aaddec61cb |    mysqldemo    |   mysql   |     mysql-5.5     | BUILD  |     2     |  2   |15:21
TomasR_and one instance in this state:15:21
TomasR_| f2d7aa98-5b65-4ca9-a175-5ef3f0ebd928 |    mysqldemo    |   mysql   |     mysql-5.5     | ERROR  |     2     |  2   |15:22
TomasR_Any suggestion how to force remove all these instances?15:22
TomasR_trove delete d23384d6-8fc1-4f3a-b5b1-00aaddec61cb ERROR: Instance d23384d6-8fc1-4f3a-b5b1-00aaddec61cb is not ready.15:23
TomasR_I was able to delete the instance with status=ERROR15:23
*** NehaV has quit IRC15:23
*** NehaV has joined #openstack-trove15:24
*** ashishsnigam has joined #openstack-trove15:25
*** michael-yu has joined #openstack-trove15:29
*** michael-yu has quit IRC15:35
*** michael-yu has joined #openstack-trove15:38
*** michael-yu has quit IRC15:45
TomasR_I recreated trove database, so please ignore my question about deleting mysql instances that are in BUILD state.15:47
*** ViswaV has joined #openstack-trove15:49
*** ViswaV_ has joined #openstack-trove15:50
*** TomasR_ has quit IRC15:51
*** sriram_tesora has joined #openstack-trove15:52
*** michael-yu has joined #openstack-trove15:52
*** ViswaV has quit IRC15:54
*** michael-yu_ has joined #openstack-trove15:55
*** michael-yu_ has quit IRC15:55
*** david74la has joined #openstack-trove15:56
*** michael-yu has quit IRC15:57
david74lahola15:57
*** ViswaV_ is now known as ViswaV15:57
*** david74la has left #openstack-trove15:59
*** ramishra has joined #openstack-trove16:05
*** eghobo has joined #openstack-trove16:11
*** sriram_tesora has quit IRC16:11
*** sbfox has joined #openstack-trove16:12
*** ViswaV has quit IRC16:12
esmuteHi all, please review when you have a chance. They are short and quick. https://review.openstack.org/#/c/81379/, https://review.openstack.org/#/c/88464/, https://review.openstack.org/#/c/89717/, https://review.openstack.org/#/c/89719/16:16
esmuteand https://review.openstack.org/#/c/86242/ (a bit longer)16:17
*** esp has joined #openstack-trove16:18
*** ramishra has quit IRC16:19
*** Barker has joined #openstack-trove16:21
*** ramishra has joined #openstack-trove16:22
*** eguz has joined #openstack-trove16:23
*** sbfox1 has joined #openstack-trove16:23
*** sbfox has quit IRC16:23
dougshelley66esmute - i had some questions regarding your review of https://review.openstack.org/#/c/88591/616:25
dougshelley66esmute i put them inline as comments16:25
esmuteHi dougshelley6616:25
esmuteyeah i am reading it now..16:25
dougshelley66ah thanks16:25
*** eghobo has quit IRC16:27
esmutewhat i think is that i do understand that if you try to merge your logic to the existing fuction, it'd probaby look too big and confusing... (if you break down the 'elif' statement in https://github.com/openstack/trove/blob/master/trove/instance/models.py#L799)16:28
esmuteand we want to clean thinkgs cleaner by having them separate.16:28
*** Barker has quit IRC16:30
mat-loweryMongo question for anyone: Currently in config.template, bind_ip = 127.0.0.1. During prepare, this line is changed to the VM IP. However, with start_db_with_conf_changes or reset_configuration, it's reset to 127.0.0.1 meaning that the guestagent connection test fails and it thinks it's SHUTDOWN. Do I fix this by doing the IP lookup in the aforementioned methods or is removing the bind_ip line altogether (and therefore binding to all16:30
mat-lowery interfaces) acceptable?16:30
esmutebut at the same time, it looks sorta duplicated....and i'll be afraid that if new features/actions are implemented and they need to apply its own validation based on the status, we might have a lot of 'validate_can_perform' type of functions16:30
mat-loweryI'd prefer to remove bind_ip altogether but wanted some security perspective.16:31
esmute@dougshelley66 in reality, i would have prefer that the unassign_configuration() and assign_configuration() were in the configuration model and not the instance model (similar to assigning security groups). That way this specific validation method that only pertains to assigning configurations, lives in configurations16:32
esmutebut that is probably outside the scope for this bug fix16:32
dougshelley66esmute i would suspect that is true16:33
dougshelley66given those 2 methods pre-dated this bug16:33
*** Barker has joined #openstack-trove16:33
*** ramishra has quit IRC16:33
*** ViswaV has joined #openstack-trove16:33
esmutei'll +1 since you proved that my original suggestion (incorporating the assign config logic to the exisiting method) would make the function too confusing with more if/else than it probably needs16:34
dougshelley66esmute - ok thx - should i file a bug to move the code as you suggest?16:35
openstackgerritDan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats  https://review.openstack.org/8168216:42
esmutedougshelley66: It is not too high prio, but it would be nice.16:43
dougshelley66ok np16:44
esmutemat-lowery: I am not sure what the ramifications are for removing the bind_ip, but it seems that your former suggestion is safer (use IP lookup)16:49
*** SushillKM has joined #openstack-trove16:50
mat-loweryHi esmute: I thought about that and here's my thinking: mysql already listens on all interfaces. I was going through the others to see what they do. Seeing as how the other config.templates don't have any IP addresses (that I could find), I assume I'll see the same thing with the others.16:51
mat-lowerySo my argument for #2 is "there's a precedent." Not sure if that's a valid argument. :)16:51
*** harlowja_away is now known as harlowja16:51
esmuteyeah.. if that is the case, it was probably added to work as a default (or as a example)..16:57
*** Barker has quit IRC16:57
esmuteif other's template dont have it, i think we can safely assume we can remove it.16:57
*** Barker has joined #openstack-trove17:03
*** thedodd has quit IRC17:04
mat-lowerythanks esmute17:04
*** thedodd has joined #openstack-trove17:06
*** SushilKM has joined #openstack-trove17:06
*** SushillKM has quit IRC17:07
*** coolsvap is now known as coolsvap|afk17:08
*** SushilKM has quit IRC17:14
*** SushillKM has joined #openstack-trove17:14
*** ranjitha has joined #openstack-trove17:16
*** sbfox1 has quit IRC17:16
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522517:16
*** SushillKM has quit IRC17:20
*** mattgriffin has quit IRC17:27
*** thedodd has quit IRC17:28
*** SushillKM has joined #openstack-trove17:31
*** casanch1 has quit IRC17:31
*** mattgriffin has joined #openstack-trove17:31
*** eguz has quit IRC17:35
*** eghobo has joined #openstack-trove17:36
*** NehaV1 has joined #openstack-trove17:37
*** thedodd has joined #openstack-trove17:37
*** NehaV2 has joined #openstack-trove17:37
*** NehaV1 has quit IRC17:37
*** NehaV has quit IRC17:39
*** ranjitha has quit IRC17:41
*** yidclare has joined #openstack-trove17:45
juicemat-lowery: esmute: good catch on the ip bind issue.  As we move to Neutron, we will likely have multiple interfaces connected to a trove instance.  We do not want the datastore to listen on interfaces/ips on the management interface, only the customer interface.17:46
juicemat-lowery: esmute: having said that, as we work in the neutron implementation/support, this lookup of the correct interface can be handled in that patch17:47
mat-lowerygotcha juice. thanks.17:51
*** SushilKM has joined #openstack-trove17:53
*** ranjitha has joined #openstack-trove17:55
*** SushillKM has quit IRC17:55
*** SushilKM has quit IRC17:57
*** thedodd has quit IRC17:59
*** yogesh has joined #openstack-trove17:59
*** thedodd has joined #openstack-trove18:01
*** sbfox has joined #openstack-trove18:01
*** NehaV2 has quit IRC18:05
*** NehaV has joined #openstack-trove18:08
*** amcrn has joined #openstack-trove18:09
*** NehaV has quit IRC18:23
*** NehaV has joined #openstack-trove18:23
juicecode reviewers - if you want to join the swarm, this query in gerrit will somewhat help to find patches that are being actively reviewed but have not yet been approved (status:open project: openstack/trove label:Verified+1 label:CodeReview+1 -label:Approved)18:29
*** casanch1 has joined #openstack-trove18:30
esmuteThanks juice. That's useful18:31
*** ashishsnigam has quit IRC18:31
juiceif you drop the "label: CodeReview+1" it will widen the net to get patches that are in various states of review.  For some reason the "verified" doesn't seem very reliable since it does pull back -1s as well18:32
esmutejuice: i didnt get an -1s when i used that query18:33
juicetrue but when you remove the "CodeReviewed" predicate, you will18:34
esmutei think you meant 'review'?18:34
esmuteyes18:34
*** ramishra has joined #openstack-trove18:34
*** igor__ has joined #openstack-trove18:35
*** thedodd has quit IRC18:37
*** ramishra has quit IRC18:39
*** thedodd has joined #openstack-trove18:40
*** ViswaV has quit IRC18:42
*** doddstack has joined #openstack-trove18:46
*** thedodd has quit IRC18:49
openstackgerritMat Lowery proposed a change to openstack/trove: Bind to all interfaces for MongoDB  https://review.openstack.org/9019418:51
*** ramishra has joined #openstack-trove18:55
openstackgerritPeter Stachowski proposed a change to openstack/python-troveclient: Changed Trove CLI list headers to match Nova CLI  https://review.openstack.org/8993018:58
*** ramishra has quit IRC19:00
*** Barker has quit IRC19:03
openstackgerritSteve Leon proposed a change to openstack/trove: Fixes tests so that they pass when run on OS X  https://review.openstack.org/8846419:07
annashengrapex: can you talk more about the decorator issue that you have with importing config early?19:08
grapexannashen: Sure19:09
grapexannashen: Basically we need to avoid making decorator arguments driven by the test config or other dynamic variables as it makes the tests harder to reason about19:10
grapexyears back we used them all over the place to disable tests if the config wasn't set to use certain features19:10
grapexwhat I discovered was that it made it very difficult to know that tests weren't running19:11
*** serverascode has quit IRC19:11
grapexIt got pretty bad so at Rax we came to a consensus to not use them like that19:11
grapexannashen: Does that answer your question?19:11
grapexYou can still skip tests that are based on functionality that is disabled by either not running the group19:11
grapexor if running the group is unavoidable you can have an if statement in the test function itself which explicitly raises SkipTest19:12
grapexSlickNik vipul: FYI: ^^19:12
*** Barker has joined #openstack-trove19:12
*** serverascode has joined #openstack-trove19:13
annashengrapex: thanks for comments19:14
annashengrapex: thanks for sharing19:15
grapexannashen: No problem. Let me know if you have any other questions.19:15
annashengrapes, now i can see it is better practice, thanks19:16
*** demorris has joined #openstack-trove19:26
*** saurabhs has joined #openstack-trove19:36
*** ViswaV has joined #openstack-trove19:38
openstackgerritTim Simpson proposed a change to openstack/trove: Moved the apidocs from openstack/database-api  https://review.openstack.org/8780719:41
openstackgerritTim Simpson proposed a change to openstack/trove: Make sure eventlet starts correctly  https://review.openstack.org/8942519:42
*** ranjitha has quit IRC19:43
*** coolsvap|afk has quit IRC19:44
*** ViswaV has quit IRC19:46
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985019:48
openstackgerritSteve Leon proposed a change to openstack/trove: Fixes test so that it passes when run on OS X  https://review.openstack.org/8846419:56
*** ramishra has joined #openstack-trove19:56
openstackgerritSteve Leon proposed a change to openstack/trove: Fixes test so that it passes when run on OS X  https://review.openstack.org/8846419:57
*** sbfox has quit IRC19:57
*** ramishra has quit IRC20:01
*** sbfox has joined #openstack-trove20:02
*** demorris has quit IRC20:02
*** harlowja is now known as harlowja_away20:06
*** mattgriffin has quit IRC20:14
*** mattgriffin has joined #openstack-trove20:14
openstackgerritAnna Shen proposed a change to openstack/trove: Add integration test for Neutron support  https://review.openstack.org/8267320:18
*** rueb7363 has joined #openstack-trove20:23
*** rueb7363 has quit IRC20:32
*** casanch1_ has joined #openstack-trove20:32
openstackgerritAnna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests  https://review.openstack.org/8785620:35
*** casanch1 has quit IRC20:36
*** radez is now known as radez_g0n320:40
hub_capjuice: esmute around?20:40
hub_caplets squash this comment thing now20:41
juiceyep20:41
hub_capfirst off, 1) reasons, 2) changes are not necessary20:41
juiceemsute is here too20:41
hub_capreally they are never necessary20:41
esmutehub_cap: ok20:41
hub_capits some construct denis started20:41
juiceyou mean the format?20:41
hub_capand no one in trove-core enforces it20:41
hub_capyes20:41
hub_capi typically, if needed, write a small paragraph after20:41
juicetrue but there should be some information as to what changed and why20:41
hub_caphttps://review.openstack.org/#/c/86808/20:42
* juice Topic/Headline20:42
juicereturn20:42
hub_capthats an example of a good msg, cuz i wrote it ;)20:42
juicetab Description20:42
juicehub_cap: of course :)20:42
esmuteso short and descriptive title (not longer so that it doesnt break pep8). And some bullet points/short sentences describing the work. Is this good enough?20:42
hub_capyes exactly esmute20:42
hub_capbut the _why_ needs to come in the title20:42
hub_capnot the _what_ persay20:42
hub_capso saying "fixing for os X" is not really why20:43
juicehub_cap: i found a small typo in your commit message so I am going to -1 it20:43
hub_capjuice: plz do20:43
juice;)20:43
hub_capseparation20:43
hub_capi HATE having typos in my commit msgs20:43
hub_capit would make me quite happy for u to -1 it20:43
hub_capim a commit msg stickler20:43
openstackgerritAnna Shen proposed a change to openstack/trove: Add integration test for Neutron support  https://review.openstack.org/8267320:43
espI have typos in code20:43
hub_caplol esp it is python20:44
* esp just kidding…sorta20:44
esmuteOk.. this is good to know.20:44
juicehub_cap: btw is there a code style guide/commit message style guide for openstack?20:44
hub_capi always find this to be a good reference esmute20:44
hub_caphttp://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html20:44
esmuteill mentioned it to denis_mokogon when he is around20:45
hub_capjuice: there is and there isint20:45
hub_caphttps://wiki.openstack.org/wiki/GitCommitMessages20:45
hub_capbut really its not a style guide20:45
hub_capwriitng good commit msgs is more than style so to speak20:45
hub_capand the 1) reasons 2) changes thing i have no idea why denis / snowdust do it20:45
hub_capbut they love it20:46
hub_capi personally dislike it and i think a paragraph is a better explaination20:46
juiceparagraph or bullets is my pref20:46
openstackgerritDaniel Salinas proposed a change to openstack/trove: Add instance metadata functionality to trove  https://review.openstack.org/8212320:46
hub_capbut u can only be a stickler to so many things before people start s/st/d you20:46
hub_capjuice: bullets were my pref in teh day20:46
hub_capnow i find that a small pg is nicer.. like u know what my motivation was for that commit i pasted to u20:47
hub_capi dont think i couldve done that in bullets20:47
hub_capbut bullets are fine for smaller changes20:47
hub_capbut after a while i found i was just doing things like20:47
hub_cap* added tests20:47
hub_cap* fixed up the api20:47
hub_capshit u can look @ the code to see that20:47
juicehub_cap: good point20:47
hub_capso i like to give a reason (w/o putting 1) reason)20:47
juiceok esmute: let's get that patch done :)20:49
hub_caphttps://github.com/openstack/trove/commit/475927f35d7c47a4c9fb45c06d24c825bc02a77d20:49
hub_capsee that doesnt really tell me why20:49
hub_capi look at my old msgs and im ashamed of past me sometimes :)20:49
hub_capbut u can see i used to be all about the Sentence\n\n*\n*\n*20:50
*** sbfox has quit IRC20:50
juicehub_cap: thanks for the time and the examples20:52
hub_capnpnp20:52
openstackgerritSteve Leon proposed a change to openstack/trove: Mocks out file.open to not rely on OS dependent files  https://review.openstack.org/8846420:53
openstackgerritAnna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests  https://review.openstack.org/8785620:53
espmat-lowery: ping20:54
esmutethank you juice hub_cap. Lets make sure everyone are in sync with this so that we dont get -1s because the commit messages dont suite someone's style20:54
mat-loweryhello esp20:54
esphey mat-lowery, how’s it going?20:55
juiceesmute: maybe we can spend 2 minutes on this in the next meeting20:55
espmat-lowery: can you take another look at this at your earliest convenience?  https://review.openstack.org/#/c/81682/20:55
esmutejuice: yeah.. ill put it in the trove agenda20:55
hub_capesmute: if yer getting a -1 and are being told u have to add the silly reasons/changes thing, u come talk to me20:55
hub_capthere is one person who adds it like that20:56
hub_capso he cant make everyone change to suit his needs :)20:56
mat-loweryesp: Sure.20:56
espmat-lowery: thx!20:56
*** ramishra has joined #openstack-trove20:57
esmutehub_cap: Sounds good. Thank you!20:58
hub_capnp20:58
*** harlowja_away is now known as harlowja21:01
*** pdmars has quit IRC21:02
*** ramishra has quit IRC21:02
*** casanch1_ has quit IRC21:05
*** casanch1 has joined #openstack-trove21:05
*** casanch1 has quit IRC21:30
*** NehaV has quit IRC21:48
*** kevinconway has quit IRC21:50
*** sbfox has joined #openstack-trove21:51
*** robertmyers has quit IRC21:54
*** michael-yu has joined #openstack-trove21:56
*** ramishra has joined #openstack-trove21:58
*** ramishra has quit IRC22:02
*** saurabhs has quit IRC22:05
*** amcrn has quit IRC22:08
*** jcru has quit IRC22:09
*** saurabhs has joined #openstack-trove22:10
*** achampion has quit IRC22:15
*** shakamunyi has quit IRC22:20
*** yogesh has quit IRC22:24
*** doddstack has quit IRC22:34
*** michael-yu has quit IRC22:40
*** michael-yu has joined #openstack-trove22:46
*** michael-yu has quit IRC22:48
*** michael-yu has joined #openstack-trove22:51
*** mattgriffin has quit IRC22:56
*** etoews has joined #openstack-trove22:57
*** amcrn has joined #openstack-trove22:57
*** ramishra has joined #openstack-trove22:58
*** michael-yu_ has joined #openstack-trove23:01
*** michael-yu has quit IRC23:03
*** michael-yu_ is now known as michael-yu23:03
*** ramishra has quit IRC23:03
*** lifeless has quit IRC23:04
*** lifeless has joined #openstack-trove23:05
*** flaper87 is now known as flaper87|afk23:08
*** sbfox1 has joined #openstack-trove23:10
*** sbfox has quit IRC23:11
*** eguz has joined #openstack-trove23:19
*** eguz has quit IRC23:19
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522523:22
openstackgerritDan Nguyen proposed a change to openstack/trove: Add a new column and indexes to agent_heartbeats  https://review.openstack.org/8168223:22
*** mattgriffin has joined #openstack-trove23:22
*** achampion has joined #openstack-trove23:22
*** eghobo has quit IRC23:23
*** saurabhs has left #openstack-trove23:27
*** Barker has quit IRC23:30
*** michael-yu has quit IRC23:32
openstackgerritAnna Shen proposed a change to openstack/trove: Add neutron support (WORKINPROGRESS)  https://review.openstack.org/8834923:35
*** Barker has joined #openstack-trove23:35
openstackgerritAnna Shen proposed a change to openstack/trove: Add integration test for Neutron support  https://review.openstack.org/8267323:36
*** grapex has quit IRC23:37
openstackgerritDoug Shelley proposed a change to openstack/trove: Correct inconsistent state issues with config  https://review.openstack.org/8859123:41
*** ravikumar_hp has quit IRC23:41
*** ViswaV has joined #openstack-trove23:45
*** ViswaV_ has joined #openstack-trove23:45
*** Barker has quit IRC23:47
*** Barker has joined #openstack-trove23:48
*** ViswaV has quit IRC23:49
*** michael-yu has joined #openstack-trove23:50
dougshelley66juice, esmute: would you mind looking at https://review.openstack.org/#/c/88591/ again?23:52
esmutedougshelley66: Sure.. will do23:53
dougshelley66esmute many thanks23:53
*** eghobo has joined #openstack-trove23:55
*** ramishra has joined #openstack-trove23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!