| *** sbfox has quit IRC | 00:06 | |
| openstackgerrit | A change was merged to openstack/trove: Consider datastore version when generating configs https://review.openstack.org/91556 | 00:15 |
|---|---|---|
| *** matsuhashi has joined #openstack-trove | 00:23 | |
| *** igor_ has joined #openstack-trove | 00:30 | |
| *** igor_ has quit IRC | 00:34 | |
| *** ramashri has joined #openstack-trove | 00:40 | |
| *** saurabhs has quit IRC | 00:40 | |
| *** arborism has quit IRC | 00:48 | |
| *** mattgriffin has quit IRC | 00:55 | |
| *** ramashri has quit IRC | 01:19 | |
| *** igor_ has joined #openstack-trove | 01:31 | |
| *** igor_ has quit IRC | 01:35 | |
| *** nosnos has joined #openstack-trove | 01:35 | |
| *** Barker has quit IRC | 01:38 | |
| *** PeterSchwaller has joined #openstack-trove | 01:49 | |
| *** michael-yu has quit IRC | 01:56 | |
| *** PeterS has quit IRC | 01:58 | |
| *** AniketJ has quit IRC | 01:58 | |
| *** AniketJ has joined #openstack-trove | 02:00 | |
| *** michael-yu has joined #openstack-trove | 02:03 | |
| *** michael-yu has quit IRC | 02:04 | |
| *** achampion has joined #openstack-trove | 02:18 | |
| *** igor_ has joined #openstack-trove | 02:32 | |
| *** haomaiwa_ has joined #openstack-trove | 02:32 | |
| *** igor_ has quit IRC | 02:36 | |
| *** haomaiwa_ has quit IRC | 02:38 | |
| *** jasonb365 has joined #openstack-trove | 02:43 | |
| *** harlowja_ is now known as harlowja_away | 02:55 | |
| *** jasonb365 has quit IRC | 02:58 | |
| *** AniketJee has joined #openstack-trove | 02:58 | |
| *** nosnos has quit IRC | 03:03 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/trove: Really remove admin_token from configs https://review.openstack.org/95057 | 03:04 |
| *** mattgriffin has joined #openstack-trove | 03:10 | |
| *** AniketJee has quit IRC | 03:13 | |
| *** AniketJee has joined #openstack-trove | 03:13 | |
| *** radez is now known as radez_g0n3 | 03:14 | |
| *** matsuhashi has quit IRC | 03:29 | |
| *** eghobo has joined #openstack-trove | 03:32 | |
| *** igor_ has joined #openstack-trove | 03:32 | |
| *** haomaiwa_ has joined #openstack-trove | 03:34 | |
| *** matsuhashi has joined #openstack-trove | 03:36 | |
| *** igor_ has quit IRC | 03:37 | |
| *** haomaiwa_ has quit IRC | 03:39 | |
| *** matsuhashi has quit IRC | 03:43 | |
| *** matsuhashi has joined #openstack-trove | 03:43 | |
| *** matsuhas_ has joined #openstack-trove | 03:45 | |
| *** matsuhashi has quit IRC | 03:45 | |
| *** nosnos has joined #openstack-trove | 03:45 | |
| *** AniketJee has quit IRC | 03:55 | |
| *** coolsvap|afk is now known as coolsvap | 04:05 | |
| *** sbfox has joined #openstack-trove | 04:11 | |
| *** sgotliv has joined #openstack-trove | 04:20 | |
| *** ViswaV has joined #openstack-trove | 04:25 | |
| *** ViswaV_ has joined #openstack-trove | 04:26 | |
| *** edmund has quit IRC | 04:28 | |
| *** eghobo has quit IRC | 04:28 | |
| *** edmund has joined #openstack-trove | 04:28 | |
| openstackgerrit | Shalini khandelwal proposed a change to openstack/trove-integration: Corrected conditional check for invalid SERVICE_TYPE https://review.openstack.org/92058 | 04:29 |
| *** ViswaV has quit IRC | 04:29 | |
| *** mattgriffin has quit IRC | 04:29 | |
| *** matsuhas_ has quit IRC | 04:34 | |
| *** matsuhashi has joined #openstack-trove | 04:43 | |
| *** eghobo has joined #openstack-trove | 04:44 | |
| openstackgerrit | A change was merged to openstack/python-troveclient: Enabled F821, H306, H402, and H404 flake8 rule https://review.openstack.org/66369 | 04:59 |
| *** edmund has quit IRC | 05:11 | |
| *** edmund has joined #openstack-trove | 05:11 | |
| *** LIYUEZHOU has joined #openstack-trove | 05:14 | |
| *** eghobo has quit IRC | 05:15 | |
| *** eguz has joined #openstack-trove | 05:15 | |
| *** eghobo has joined #openstack-trove | 05:15 | |
| *** eghobo has quit IRC | 05:15 | |
| *** eguz has quit IRC | 05:20 | |
| *** edmund1 has joined #openstack-trove | 05:21 | |
| *** edmund has quit IRC | 05:23 | |
| *** ramishra has joined #openstack-trove | 05:31 | |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/trove: Update database-api to follow OpenStack conventions https://review.openstack.org/94989 | 05:32 |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/trove: Update database-api to follow OpenStack conventions https://review.openstack.org/94989 | 05:33 |
| *** igor_ has joined #openstack-trove | 05:34 | |
| *** igor_ has quit IRC | 05:38 | |
| *** eghobo has joined #openstack-trove | 05:42 | |
| *** sgotliv has quit IRC | 05:48 | |
| *** sgotliv has joined #openstack-trove | 05:49 | |
| *** global_ has joined #openstack-trove | 05:49 | |
| *** global_ is now known as shalini_ | 05:49 | |
| *** edmund has joined #openstack-trove | 05:54 | |
| *** edmund1 has quit IRC | 05:54 | |
| *** ramishra has quit IRC | 05:57 | |
| *** eghobo has quit IRC | 05:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/95082 | 06:06 |
| *** ViswaV_ has quit IRC | 06:11 | |
| *** Longgeek has joined #openstack-trove | 06:20 | |
| *** edmund has quit IRC | 06:29 | |
| *** yogeshmehra has joined #openstack-trove | 06:43 | |
| *** yogeshmehra has quit IRC | 06:46 | |
| *** yogeshmehra has joined #openstack-trove | 06:46 | |
| *** yogeshmehra has quit IRC | 06:50 | |
| *** sgotliv has quit IRC | 06:51 | |
| *** AJaeger has left #openstack-trove | 06:51 | |
| *** AniketJee has joined #openstack-trove | 06:59 | |
| *** yogeshmehra has joined #openstack-trove | 07:00 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Corrects trove-client output https://review.openstack.org/95094 | 07:14 |
| *** AniketJee has quit IRC | 07:22 | |
| *** AniketJee has joined #openstack-trove | 07:23 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects spelling errors https://review.openstack.org/69383 | 07:25 |
| *** amcrn has joined #openstack-trove | 07:28 | |
| *** sbfox has quit IRC | 07:32 | |
| *** AniketJ has quit IRC | 07:36 | |
| *** SushillKM has joined #openstack-trove | 07:40 | |
| *** igor has joined #openstack-trove | 07:42 | |
| *** haomaiwang has joined #openstack-trove | 07:42 | |
| *** AniketJee has quit IRC | 07:42 | |
| *** AniketJee has joined #openstack-trove | 07:43 | |
| *** haomaiwang has quit IRC | 07:47 | |
| *** yogeshmehra has quit IRC | 07:57 | |
| *** rwsu has quit IRC | 07:58 | |
| *** yogeshmehra has joined #openstack-trove | 07:58 | |
| *** AniketJee has quit IRC | 08:00 | |
| *** yogeshmehra has quit IRC | 08:02 | |
| openstackgerrit | A change was merged to openstack/trove-integration: Corrected conditional check for invalid SERVICE_TYPE https://review.openstack.org/92058 | 08:18 |
| *** sgotliv has joined #openstack-trove | 08:26 | |
| *** amcrn has quit IRC | 08:37 | |
| shalini_ | hey SlikNik !! | 08:41 |
| *** sgotliv has quit IRC | 08:44 | |
| *** matsuhashi has quit IRC | 08:48 | |
| *** matsuhashi has joined #openstack-trove | 09:16 | |
| *** dmakogon_ is now known as denis_makogon | 09:23 | |
| denis_makogon | shalini_, i've misspelled SlickNik's nick | 09:24 |
| shalini_ | denis_makogon, so there should be you in place of 'I'. | 09:27 |
| *** flaper87|afk is now known as flaper87 | 09:28 | |
| denis_makogon | shalini_, yup, i meant "you" | 09:29 |
| *** flaper87 is now known as flaper87|afk | 09:39 | |
| *** nosnos has quit IRC | 09:45 | |
| *** flaper87|afk is now known as flaper87 | 09:54 | |
| openstackgerrit | A change was merged to openstack/python-troveclient: replaced e.message https://review.openstack.org/93605 | 10:04 |
| *** matsuhashi has quit IRC | 10:12 | |
| *** makkie_ has left #openstack-trove | 10:15 | |
| *** matsuhas_ has joined #openstack-trove | 10:15 | |
| *** openstackstatus has quit IRC | 10:20 | |
| *** openstack has joined #openstack-trove | 10:21 | |
| *** openstackstatus has joined #openstack-trove | 10:22 | |
| *** ChanServ sets mode: +v openstackstatus | 10:22 | |
| *** lathiat has quit IRC | 10:23 | |
| *** lathiat has joined #openstack-trove | 10:24 | |
| *** demorris has joined #openstack-trove | 10:28 | |
| *** fifieldt has quit IRC | 10:31 | |
| *** coolsvap is now known as coolsvap|afk | 10:38 | |
| *** demorris has quit IRC | 10:43 | |
| *** flaper87 is now known as flaper87|afk | 10:43 | |
| *** demorris has joined #openstack-trove | 10:44 | |
| *** demorris has quit IRC | 10:49 | |
| *** matsuhas_ has quit IRC | 10:55 | |
| *** matsuhashi has joined #openstack-trove | 10:57 | |
| *** matsuhashi has quit IRC | 10:58 | |
| *** matsuhashi has joined #openstack-trove | 10:58 | |
| *** matsuhashi has quit IRC | 10:58 | |
| *** matsuhashi has joined #openstack-trove | 10:59 | |
| *** igor_ has joined #openstack-trove | 11:05 | |
| *** igor has quit IRC | 11:08 | |
| *** haomaiwang has joined #openstack-trove | 11:49 | |
| openstackgerrit | Zu Qiang proposed a change to openstack/trove-integration: Reset the no_proxy when the node is installed behind a proxy https://review.openstack.org/94892 | 11:53 |
| *** haomaiwang has quit IRC | 11:59 | |
| *** matsuhashi has quit IRC | 12:20 | |
| *** pdmars has joined #openstack-trove | 12:21 | |
| *** matsuhashi has joined #openstack-trove | 12:21 | |
| *** pdmars has quit IRC | 12:24 | |
| *** ViswaV has joined #openstack-trove | 12:26 | |
| *** matsuhashi has quit IRC | 12:26 | |
| *** ViswaV has quit IRC | 12:26 | |
| *** pdmars has joined #openstack-trove | 12:27 | |
| *** tvoran has joined #openstack-trove | 12:37 | |
| *** matsuhashi has joined #openstack-trove | 12:37 | |
| *** matsuhashi has quit IRC | 12:38 | |
| *** matsuhashi has joined #openstack-trove | 12:38 | |
| *** matsuhashi has quit IRC | 12:38 | |
| *** matsuhashi has joined #openstack-trove | 12:39 | |
| *** sgotliv has joined #openstack-trove | 12:40 | |
| *** tvoran has quit IRC | 12:42 | |
| *** tvoran has joined #openstack-trove | 12:42 | |
| *** matsuhashi has quit IRC | 12:43 | |
| *** sgotliv has quit IRC | 12:48 | |
| *** radez_g0n3 is now known as radez | 12:51 | |
| *** radez is now known as radez_g0n3 | 12:52 | |
| *** radez_g0n3 is now known as radez | 12:52 | |
| *** miqui has joined #openstack-trove | 12:54 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Corrects condition to check valid SERVICE_TYPE https://review.openstack.org/95154 | 12:55 |
| *** haomaiwang has joined #openstack-trove | 12:56 | |
| *** haomaiwang has quit IRC | 13:13 | |
| *** LIYUEZHOU has quit IRC | 13:14 | |
| *** achampion has quit IRC | 13:17 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Add stack_id to base instance model https://review.openstack.org/67873 | 13:26 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Refactor taskmanager. Split heat/native/migration code path https://review.openstack.org/91331 | 13:26 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Corrects condition to check valid SERVICE_TYPE https://review.openstack.org/95154 | 13:28 |
| *** SushilKM has joined #openstack-trove | 13:30 | |
| *** SushillKM has quit IRC | 13:30 | |
| *** NehaV has joined #openstack-trove | 13:33 | |
| *** mrsnivvel has quit IRC | 13:33 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Refactor taskmanager. Split heat/native/migration code path https://review.openstack.org/91331 | 13:36 |
| *** amytron has joined #openstack-trove | 13:43 | |
| *** jasonb365 has joined #openstack-trove | 13:43 | |
| *** SushilKM has quit IRC | 13:49 | |
| *** jasonb365 has quit IRC | 13:49 | |
| *** sbfox has joined #openstack-trove | 13:59 | |
| *** mattgriffin has joined #openstack-trove | 14:05 | |
| *** denis_makogon has quit IRC | 14:06 | |
| *** robertmyers has joined #openstack-trove | 14:07 | |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Refactor taskmanager. Split heat/native/migration code path https://review.openstack.org/91331 | 14:07 |
| *** rwsu has joined #openstack-trove | 14:08 | |
| *** haomaiwa_ has joined #openstack-trove | 14:09 | |
| *** achampion has joined #openstack-trove | 14:13 | |
| *** sbfox has quit IRC | 14:14 | |
| *** NehaV has quit IRC | 14:15 | |
| *** NehaV has joined #openstack-trove | 14:16 | |
| *** ramashri has joined #openstack-trove | 14:17 | |
| *** ramashri has quit IRC | 14:21 | |
| *** edmund has joined #openstack-trove | 14:23 | |
| *** liyuezho has joined #openstack-trove | 14:30 | |
| *** haomaiwa_ has quit IRC | 14:31 | |
| *** liyuezho has quit IRC | 14:33 | |
| *** liyuezhou has joined #openstack-trove | 14:33 | |
| *** grapex has joined #openstack-trove | 14:36 | |
| *** grapex has quit IRC | 14:37 | |
| *** grapex has joined #openstack-trove | 14:38 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: Configurations stored in the database https://review.openstack.org/79852 | 14:43 |
| *** thedodd has joined #openstack-trove | 14:46 | |
| *** coolsvap|afk is now known as coolsvap | 14:48 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adding configuration paramters mgmt api https://review.openstack.org/79851 | 14:53 |
| *** igor_ has quit IRC | 15:09 | |
| *** liyuezhou has quit IRC | 15:11 | |
| *** liyuezhou has joined #openstack-trove | 15:18 | |
| *** saurabhs has joined #openstack-trove | 15:21 | |
| *** haomaiwa_ has joined #openstack-trove | 15:28 | |
| *** rueben has joined #openstack-trove | 15:29 | |
| *** Barker has joined #openstack-trove | 15:29 | |
| *** jasonb365 has joined #openstack-trove | 15:29 | |
| *** rueben has quit IRC | 15:37 | |
| *** rueben has joined #openstack-trove | 15:38 | |
| *** rueben_ has joined #openstack-trove | 15:39 | |
| *** rueben has quit IRC | 15:42 | |
| *** haomaiwa_ has quit IRC | 15:48 | |
| *** eghobo has joined #openstack-trove | 15:51 | |
| *** demorris has joined #openstack-trove | 15:53 | |
| *** cweid_ has joined #openstack-trove | 15:54 | |
| *** grapex has quit IRC | 15:58 | |
| *** grapex has joined #openstack-trove | 15:58 | |
| *** AniketJee has joined #openstack-trove | 16:03 | |
| *** AniketJee has quit IRC | 16:04 | |
| *** liyuezhou has quit IRC | 16:05 | |
| *** ViswaV has joined #openstack-trove | 16:39 | |
| *** ViswaV_ has joined #openstack-trove | 16:40 | |
| *** ViswaV has quit IRC | 16:41 | |
| *** radez is now known as radez_g0n3 | 16:46 | |
| *** radez_g0n3 is now known as radez | 16:49 | |
| *** esmute has quit IRC | 16:51 | |
| *** michael-yu has joined #openstack-trove | 16:52 | |
| *** michael-yu has quit IRC | 16:53 | |
| *** harlowja_away is now known as harlowja_ | 16:55 | |
| *** michael-yu has joined #openstack-trove | 16:56 | |
| *** rueben_ has quit IRC | 16:56 | |
| *** michael-yu has quit IRC | 16:56 | |
| *** michael-yu has joined #openstack-trove | 16:57 | |
| *** Longgeek_ has joined #openstack-trove | 16:58 | |
| *** Longgeek has quit IRC | 17:01 | |
| *** yogeshmehra has joined #openstack-trove | 17:02 | |
| *** tvoran has quit IRC | 17:09 | |
| *** sgotliv has joined #openstack-trove | 17:10 | |
| *** esmute has joined #openstack-trove | 17:10 | |
| *** sbfox has joined #openstack-trove | 17:11 | |
| *** SushilKM has joined #openstack-trove | 17:12 | |
| *** Longgeek_ has quit IRC | 17:13 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Corrects trove-client output https://review.openstack.org/95094 | 17:15 |
| SushilKM | hello hub_cap | 17:19 |
| hub_cap | howdy | 17:19 |
| SushilKM | am fine, how abt u | 17:19 |
| SushilKM | wanted to check u on this review https://review.openstack.org/#/c/66849/2/trove/tests/util/users.py | 17:20 |
| SlickNik | In a meeting, can't talk now. Check back later. | 17:21 |
| hub_cap | i have little context now, but it looks like i was agreing w esp in what to do SushilKM | 17:21 |
| hub_cap | so id say ask him / do what he says ;) | 17:21 |
| esp | yo | 17:22 |
| hub_cap | supg | 17:22 |
| SushilKM | okies .... | 17:22 |
| esp | not much.. | 17:22 |
| SushilKM | hey esp so can u recall about that review | 17:26 |
| esp | yep SushilKM | 17:26 |
| * esp lookiing at it | 17:26 | |
| *** SushillKM has joined #openstack-trove | 17:30 | |
| *** SushilKM has quit IRC | 17:31 | |
| *** amcrn has joined #openstack-trove | 17:33 | |
| *** sgotliv has quit IRC | 17:37 | |
| *** sgotliv has joined #openstack-trove | 17:37 | |
| *** tvoran has joined #openstack-trove | 17:38 | |
| esp | SushillKM: sorry was on a call, so if I remember correctly I was thinking that since the __init__ takes more params than what we originally show in __str__ in would be good to include those if they are present. (excluding the auth_key) | 17:42 |
| SushillKM | so what i understand from this is that remove the extra arguments/members from init which are not in __str__ | 17:44 |
| SushillKM | or is it reverse of this | 17:45 |
| SushillKM | to include them in __str__ | 17:45 |
| *** coolsvap is now known as coolsvap|afk | 17:46 | |
| *** rueben has joined #openstack-trove | 17:46 | |
| *** SushillKM has quit IRC | 17:49 | |
| *** SushillKM has joined #openstack-trove | 17:51 | |
| *** radez is now known as radez_g0n3 | 18:10 | |
| *** radez_g0n3 is now known as radez | 18:12 | |
| *** yidclare has joined #openstack-trove | 18:22 | |
| SushillKM | hey esp r u there | 18:26 |
| esp | SushillKM: sorta :) | 18:27 |
| esp | what’s up? | 18:27 |
| *** radez is now known as radez_g0n3 | 18:27 | |
| SushillKM | https://github.com/openstack/trove/blob/master/trove/tests/util/users.py#L44 already puts in the services in __str__ | 18:27 |
| SushillKM | and tenant is same as tenant_id | 18:27 |
| SushillKM | so would you still look for me to add them in the __str__ method of ServiceUser class | 18:28 |
| esp | I’m don’t think tenant is the same as tenant_id. where do you get that from ? | 18:30 |
| SushillKM | i m saying about their values | 18:31 |
| SushillKM | like here | 18:33 |
| SushillKM | https://github.com/openstack/trove/blob/master/etc/tests/localhost.test.conf#L26-L27 | 18:33 |
| SushillKM | what say .... | 18:34 |
| esp | yeah, in the local.test.conf today that’s true but they are different params for sure right? I don’t think it should be assumed that they will always be the same value | 18:34 |
| SushillKM | still if needed i can ammend that | 18:34 |
| SushillKM | okies so tenant needs to be there | 18:35 |
| esp | yep, if you amend it I think that’s all that needs to be done | 18:35 |
| SushillKM | cool | 18:35 |
| esp | thx SushillKM :) | 18:35 |
| SushillKM | i m updating that in a few mins | 18:35 |
| SushillKM | :) | 18:35 |
| *** NehaV has quit IRC | 18:43 | |
| *** NehaV has joined #openstack-trove | 18:44 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 18:49 |
| *** radez_g0n3 is now known as radez | 18:58 | |
| openstackgerrit | A change was merged to openstack/trove: Imported Translations from Transifex https://review.openstack.org/95082 | 18:58 |
| *** rueben has quit IRC | 19:02 | |
| *** rueben has joined #openstack-trove | 19:04 | |
| *** michael-yu has quit IRC | 19:10 | |
| *** yogeshmehra has quit IRC | 19:11 | |
| *** yogeshmehra has joined #openstack-trove | 19:11 | |
| *** michael-yu has joined #openstack-trove | 19:14 | |
| *** cweid_ has quit IRC | 19:24 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Cleans up ServiceUser.__str__ method https://review.openstack.org/66849 | 19:24 |
| *** cweid has quit IRC | 19:24 | |
| *** cweid has joined #openstack-trove | 19:27 | |
| *** jdbarry_ has joined #openstack-trove | 19:27 | |
| SushillKM | hey esp i have updated https://review.openstack.org/#/c/66849 please review the same ... | 19:28 |
| SushillKM | :) | 19:28 |
| *** thedodd has quit IRC | 19:31 | |
| cp16net | amcrn: so i am a little scared about making one of these changes to my datastore review | 19:34 |
| cp16net | amcrn: "should be configuration_parameters not configuration-parameters" | 19:34 |
| amcrn | cp16net: why? | 19:35 |
| cp16net | amcrn: i know someone is going to kill me for changing that from someone that is parsing the data | 19:35 |
| cp16net | amcrn: because it was part of the spec... | 19:36 |
| amcrn | cp16net: meaning you've already deployed this change prior to it being merged? so if it changes, you've got downstream tools that rely on it? | 19:36 |
| cp16net | meaning this was returned the other way when the config groups was first deployed | 19:37 |
| cp16net | because it just spit out the json file | 19:37 |
| amcrn | oh, really? | 19:37 |
| cp16net | yeah... | 19:37 |
| cp16net | because it was the json file format that was technically the contract before for the parameters | 19:37 |
| amcrn | i think i'm confused, where is configuration-parameter being returned today? | 19:37 |
| amcrn | in the api | 19:38 |
| cp16net | from reading the validtion-rules.json file | 19:38 |
| amcrn | why can't the file and the api contracts differ? | 19:38 |
| cp16net | https://github.com/openstack/trove/blob/master/trove/configuration/service.py#L257 | 19:39 |
| cp16net | amcrn: because it literally was being returned | 19:39 |
| cp16net | you change the file the output would chnage | 19:39 |
| cp16net | so maybe we could say that _not_ contract but i dunno | 19:40 |
| amcrn | i think there's a slight misunderstand regarding my comment; i'm merely positioning that any facing apis use underscores vs. hyphens | 19:40 |
| cp16net | it was the response | 19:40 |
| amcrn | the rest of the internals can be different | 19:40 |
| cp16net | thats the problem | 19:40 |
| *** sbfox has quit IRC | 19:40 | |
| cp16net | its change the response that was returned | 19:40 |
| cp16net | changing* | 19:41 |
| amcrn | what reponse are we referring to? | 19:41 |
| amcrn | configuration-create? | 19:41 |
| cp16net | configuration-parameter-list | 19:41 |
| amcrn | so that, today, returns a payload with "configuration-parameters" vs. "configuration_parameters" | 19:41 |
| amcrn | ? | 19:41 |
| cp16net | yes | 19:41 |
| amcrn | :/ | 19:42 |
| cp16net | btw i'm not saying that your comment is not valid | 19:42 |
| amcrn | then we can't change it; ok, i see what you're saying | 19:42 |
| amcrn | wasn't aware of that (and didn't notice it) | 19:42 |
| cp16net | and i started making the change until i saw i was changing the view | 19:42 |
| amcrn | gotcha. thanks for walking me through that. i'll add a note to the review saying "disregard, there's already prior art" | 19:42 |
| cp16net | yeah i think it was an oversight | 19:42 |
| *** michael-yu has quit IRC | 19:43 | |
| cp16net | v2! | 19:43 |
| cp16net | :-P | 19:43 |
| amcrn | haha | 19:43 |
| amcrn | cp16net a qq while we're on the topic of this review | 19:43 |
| cp16net | need to just add it to the laundry list of stuff | 19:43 |
| cp16net | sure | 19:43 |
| *** sbfox has joined #openstack-trove | 19:43 | |
| amcrn | my comment regarding the loading of the file was on-point, right? | 19:43 |
| amcrn | or am i missing why that still needs to be loaded | 19:43 |
| cp16net | yes | 19:43 |
| cp16net | i f'd up that apparently | 19:43 |
| amcrn | lol | 19:43 |
| amcrn | ok, was just making sure it wasn't left for some reason like maybe cross-comparing against the values in the db or something | 19:44 |
| cp16net | it was a great idea to change the name of the file | 19:44 |
| cp16net | i thought i covered all those places | 19:44 |
| cp16net | i changed one and missed another | 19:44 |
| amcrn | one other scenario to test is the deletion (aka deleted=0) of a parameter, but there's an instance with a configuration-group with that parameter already set. | 19:45 |
| cp16net | thanks for looking it over because after looking at this same code for like 6 months its all blending together and i make mental notes that miss apparently | 19:45 |
| cp16net | LOL | 19:45 |
| cp16net | i made a mental note of that one as well | 19:45 |
| amcrn | saweeet | 19:45 |
| *** radez is now known as radez_g0n3 | 19:46 | |
| *** SushillKM has quit IRC | 19:46 | |
| *** jdbarry_ has quit IRC | 20:01 | |
| *** thedodd has joined #openstack-trove | 20:02 | |
| *** cweid has quit IRC | 20:03 | |
| iccha1 | SlickNik: amcrn cp16net vipul if the core would like to approve this. changes made based on prev meeting discussions https://blueprints.launchpad.net/trove/+spec/datastore-visibility | 20:11 |
| *** yidclare has quit IRC | 20:12 | |
| *** ViswaV_ has quit IRC | 20:16 | |
| *** michael-yu has joined #openstack-trove | 20:17 | |
| *** ViswaV has joined #openstack-trove | 20:18 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests https://review.openstack.org/87856 | 20:18 |
| *** rueben has quit IRC | 20:19 | |
| *** yogeshme_ has joined #openstack-trove | 20:21 | |
| *** yogeshmehra has quit IRC | 20:24 | |
| *** demorris has quit IRC | 20:26 | |
| *** yogeshme_ has quit IRC | 20:27 | |
| openstackgerrit | A change was merged to openstack/python-troveclient: Corrects trove-client output https://review.openstack.org/95094 | 20:27 |
| *** yogeshmehra has joined #openstack-trove | 20:28 | |
| *** demorris has joined #openstack-trove | 20:28 | |
| *** rueben has joined #openstack-trove | 20:30 | |
| *** doddstack has joined #openstack-trove | 20:33 | |
| -openstackstatus- NOTICE: Gerrit will be offline for about 20 minutes in order to rename some projects starting at 21:00 UTC. | 20:34 | |
| *** thedodd has quit IRC | 20:35 | |
| SlickNik | iccha1: Thanks for the update. Will take a look. | 20:36 |
| *** grapex_ has joined #openstack-trove | 20:41 | |
| iccha1 | SlickNik: do we have bp meeting on monday? | 20:41 |
| *** grapex has quit IRC | 20:44 | |
| *** yogeshmehra has quit IRC | 20:45 | |
| SlickNik | iccha1: Nope, it's memorial day and most people will be out. | 20:45 |
| SlickNik | iccha1: I'll send out an email on the Mailing List about it. | 20:45 |
| iccha1 | okie thanks SlickNik ! | 20:45 |
| *** achampion has quit IRC | 20:52 | |
| *** pdmars has quit IRC | 20:56 | |
| cp16net | amcrn: you still around? | 20:58 |
| amcrn | cp16net: yep | 20:58 |
| *** cweid has joined #openstack-trove | 20:59 | |
| cp16net | amcrn: not sure what the "precendent" is on deleted having a default set for the database | 20:59 |
| cp16net | i see both | 20:59 |
| cp16net | 2 files have defaults and 2 files dont | 20:59 |
| cp16net | files that dont have it: | 21:00 |
| cp16net | https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/012_backup.py | 21:00 |
| cp16net | https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/009_add_deleted_flag_to_instances.py | 21:00 |
| cp16net | files that do: | 21:00 |
| *** hub_cap has quit IRC | 21:00 | |
| cp16net | https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/020_configurations.py | 21:00 |
| cp16net | https://github.com/openstack/trove/blob/master/trove/db/sqlalchemy/migrate_repo/versions/013_add_security_group_artifacts.py | 21:00 |
| * cp16net shruggs is there really is a precedent | 21:01 | |
| amcrn | i believe the correct precedent is to not default it, and that's for indexing reasons | 21:06 |
| amcrn | there's a super long old mailing list thread about it, but i don't have it on me | 21:06 |
| cp16net | oh... | 21:09 |
| cp16net | thats cool i was just looking because i know i just copy pasta parts of that | 21:09 |
| cp16net | so i wasnt sure | 21:09 |
| cp16net | i'll make those changes. | 21:11 |
| dougshelley66 | cp16net - is "pasta parts" a technical term :) | 21:12 |
| cp16net | dougshelly66: its in my repertoire | 21:13 |
| *** rueben has quit IRC | 21:13 | |
| *** grapex_ has quit IRC | 21:14 | |
| *** Barker has quit IRC | 21:16 | |
| *** edmund has quit IRC | 21:21 | |
| *** rueben has joined #openstack-trove | 21:25 | |
| *** cweid has quit IRC | 21:31 | |
| *** cweid has joined #openstack-trove | 21:33 | |
| -openstackstatus- NOTICE: Gerrit is offline in order to rename some projects. ETA: 22:00. | 21:36 | |
| *** ChanServ changes topic to "Gerrit is offline in order to rename some projects. ETA: 22:00." | 21:36 | |
| *** amytron has quit IRC | 21:44 | |
| *** demorris has quit IRC | 21:45 | |
| *** cweid has quit IRC | 21:45 | |
| *** cweid has joined #openstack-trove | 21:49 | |
| *** rueben has quit IRC | 21:54 | |
| *** rueben has joined #openstack-trove | 21:54 | |
| *** grapex has joined #openstack-trove | 21:57 | |
| *** grapex has quit IRC | 21:57 | |
| *** grapex has joined #openstack-trove | 21:57 | |
| *** harlowja_ is now known as harlowja_away | 21:59 | |
| *** doddstack has quit IRC | 22:11 | |
| *** sbfox1 has joined #openstack-trove | 22:11 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support https://review.openstack.org/88349 | 22:11 |
| *** sbfox has quit IRC | 22:12 | |
| *** openstackgerrit has quit IRC | 22:14 | |
| *** openstackgerrit has joined #openstack-trove | 22:14 | |
| *** openstackstatus has quit IRC | 22:18 | |
| *** openstack has joined #openstack-trove | 22:18 | |
| *** harlowja_away is now known as harlowja_ | 22:19 | |
| *** openstackstatus has joined #openstack-trove | 22:20 | |
| *** ChanServ sets mode: +v openstackstatus | 22:20 | |
| *** sbfox1 has quit IRC | 22:26 | |
| *** ChanServ changes topic to "Trove Openstack Database as a Service | Docs https://github.com/openstack/trove | Channel Logs http://eavesdrop.openstack.org/irclogs/ | IRC must read http://sackheads.org/~bnaylor/spew/away_msgs.html" | 22:29 | |
| *** hub_cap has joined #openstack-trove | 22:30 | |
| *** rueben has quit IRC | 22:33 | |
| *** robertmyers has quit IRC | 22:34 | |
| *** robertmyers has joined #openstack-trove | 22:34 | |
| *** robertmyers has quit IRC | 22:39 | |
| *** michael-yu has quit IRC | 22:40 | |
| *** jasonb365 has quit IRC | 22:40 | |
| *** tvoran has quit IRC | 22:40 | |
| *** mattgriffin has quit IRC | 22:51 | |
| *** michael-yu has joined #openstack-trove | 22:55 | |
| *** eguz has joined #openstack-trove | 23:02 | |
| *** eghobo has quit IRC | 23:06 | |
| *** achampion has joined #openstack-trove | 23:14 | |
| *** mattgriffin has joined #openstack-trove | 23:30 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add neutron switch for int tests https://review.openstack.org/87856 | 23:37 |
| openstackgerrit | Anna Shen proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 23:37 |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support https://review.openstack.org/88349 | 23:39 |
| *** demorris has joined #openstack-trove | 23:39 | |
| *** michael-yu has quit IRC | 23:41 | |
| openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support https://review.openstack.org/88349 | 23:52 |
| *** michael-yu has joined #openstack-trove | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!