*** michael-yu has joined #openstack-trove | 00:01 | |
*** grapex has quit IRC | 00:05 | |
*** mattgriffin has joined #openstack-trove | 00:09 | |
*** matsuhashi has joined #openstack-trove | 00:20 | |
*** ramishra has joined #openstack-trove | 00:28 | |
*** ranjitha has quit IRC | 00:30 | |
*** ramishra has quit IRC | 00:32 | |
*** ViswaV has quit IRC | 00:33 | |
*** nosnos has joined #openstack-trove | 00:43 | |
*** michael-yu has quit IRC | 00:49 | |
*** makkie has joined #openstack-trove | 00:58 | |
*** ramashri has quit IRC | 01:04 | |
*** yidclare has quit IRC | 01:05 | |
*** mattgriffin has quit IRC | 01:21 | |
*** eguz has joined #openstack-trove | 01:25 | |
*** ramishra has joined #openstack-trove | 01:29 | |
*** eghobo has quit IRC | 01:29 | |
*** ramishra has quit IRC | 01:34 | |
*** eguz has quit IRC | 01:42 | |
makkie | hi | 01:46 |
---|---|---|
makkie | i need one more core reviewers' +2 for my small patch. | 01:47 |
makkie | #link https://review.openstack.org/#/c/99001/ | 01:47 |
makkie | can i request it here? are they around? | 01:47 |
*** haomaiwa_ has joined #openstack-trove | 02:00 | |
*** haomaiwa_ has quit IRC | 02:05 | |
*** matsuhashi has quit IRC | 02:07 | |
*** matsuhashi has joined #openstack-trove | 02:08 | |
*** matsuhashi has quit IRC | 02:08 | |
*** matsuhashi has joined #openstack-trove | 02:08 | |
*** Longgeek has joined #openstack-trove | 02:16 | |
*** jcru has joined #openstack-trove | 02:24 | |
*** ramishra has joined #openstack-trove | 02:29 | |
*** achampion has quit IRC | 02:32 | |
*** ramishra has quit IRC | 02:35 | |
*** ramishra has joined #openstack-trove | 02:38 | |
*** mattgriffin has joined #openstack-trove | 02:50 | |
*** ramishra has quit IRC | 02:51 | |
*** ramishra_ has joined #openstack-trove | 02:56 | |
*** achampion has joined #openstack-trove | 02:58 | |
*** rhodgin has joined #openstack-trove | 03:00 | |
*** ramishra has joined #openstack-trove | 03:00 | |
*** ramishra_ has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-trove | 03:01 | |
*** achampion has quit IRC | 03:03 | |
*** haomaiwang has quit IRC | 03:05 | |
*** rwsu has quit IRC | 03:27 | |
*** mattgriffin has quit IRC | 03:31 | |
*** ramishra has quit IRC | 03:33 | |
*** matsuhashi has quit IRC | 03:38 | |
*** matsuhashi has joined #openstack-trove | 03:39 | |
*** yidclare has joined #openstack-trove | 03:41 | |
*** matsuhashi has quit IRC | 03:45 | |
*** matsuhashi has joined #openstack-trove | 03:45 | |
*** matsuhashi has quit IRC | 03:46 | |
*** yidclare has quit IRC | 03:52 | |
*** haomaiwa_ has joined #openstack-trove | 03:53 | |
*** Longgeek has quit IRC | 03:56 | |
*** Longgeek has joined #openstack-trove | 03:57 | |
*** haomaiwa_ has quit IRC | 03:58 | |
*** serverascode has quit IRC | 03:59 | |
*** nosnos has quit IRC | 04:02 | |
*** serverascode has joined #openstack-trove | 04:02 | |
*** Longgeek has quit IRC | 04:15 | |
*** Longgeek has joined #openstack-trove | 04:17 | |
*** Longgeek has quit IRC | 04:17 | |
*** Longgeek has joined #openstack-trove | 04:19 | |
*** matsuhashi has joined #openstack-trove | 04:37 | |
*** denis_makogon has joined #openstack-trove | 04:42 | |
*** nosnos has joined #openstack-trove | 04:43 | |
*** jcru has quit IRC | 04:48 | |
*** juantwo has joined #openstack-trove | 04:49 | |
*** juantwo_ has quit IRC | 04:52 | |
*** haomaiwa_ has joined #openstack-trove | 04:54 | |
*** juantwo has quit IRC | 04:56 | |
*** matsuhashi has quit IRC | 04:56 | |
*** matsuhashi has joined #openstack-trove | 04:57 | |
*** haomaiwa_ has quit IRC | 04:58 | |
*** achampion has joined #openstack-trove | 05:05 | |
*** haomaiwa_ has joined #openstack-trove | 05:07 | |
*** achampion has quit IRC | 05:12 | |
*** sgotliv has joined #openstack-trove | 05:14 | |
*** sgotliv has quit IRC | 05:51 | |
*** Longgeek has quit IRC | 05:56 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/100083 | 06:07 |
*** Longgeek has joined #openstack-trove | 06:11 | |
*** michael-yu has joined #openstack-trove | 06:21 | |
*** haomaiwa_ has quit IRC | 06:52 | |
*** haomaiwang has joined #openstack-trove | 06:52 | |
*** michael-yu has quit IRC | 06:54 | |
*** achampion has joined #openstack-trove | 07:03 | |
*** haomaiw__ has joined #openstack-trove | 07:04 | |
*** haomaiwang has quit IRC | 07:08 | |
*** flaper87|afk is now known as flaper87 | 07:15 | |
*** denis_makogon has quit IRC | 07:15 | |
*** ajc_ has joined #openstack-trove | 07:17 | |
*** imsplitb1t has joined #openstack-trove | 07:25 | |
*** imsplitbit has quit IRC | 07:27 | |
*** annashe__ has quit IRC | 07:28 | |
*** annashe__ has joined #openstack-trove | 07:28 | |
*** achampion has quit IRC | 07:30 | |
*** annashe__ has quit IRC | 07:33 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 08:09 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 08:10 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 08:12 |
*** haomaiw__ has quit IRC | 08:16 | |
*** isviridov|away is now known as isviridov | 08:43 | |
*** nosnos has quit IRC | 08:44 | |
*** nosnos has joined #openstack-trove | 08:46 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix updated timestamp for SecurityGroup model https://review.openstack.org/97510 | 08:48 |
*** julienvey has joined #openstack-trove | 08:54 | |
*** openstackgerrit has quit IRC | 09:14 | |
*** nosnos has quit IRC | 09:40 | |
*** matsuhashi has quit IRC | 09:44 | |
*** matsuhashi has joined #openstack-trove | 09:44 | |
*** matsuhashi has quit IRC | 09:46 | |
*** matsuhashi has joined #openstack-trove | 09:47 | |
*** coolsvap|afk is now known as coolsvap | 09:55 | |
*** coolsvap is now known as coolsvap|afk | 10:15 | |
*** julienvey has quit IRC | 10:28 | |
*** coolsvap|afk is now known as coolsvap | 10:32 | |
*** boden has joined #openstack-trove | 10:50 | |
*** sgotliv has joined #openstack-trove | 10:55 | |
*** coolsvap is now known as coolsvap|afk | 10:57 | |
*** matsuhashi has quit IRC | 11:00 | |
*** matsuhashi has joined #openstack-trove | 11:01 | |
*** matsuhashi has quit IRC | 11:05 | |
*** haomaiwa_ has joined #openstack-trove | 11:12 | |
*** setho2 has joined #openstack-trove | 11:14 | |
*** setho has quit IRC | 11:14 | |
*** dmakogon_ has quit IRC | 11:15 | |
*** dmakogon_ has joined #openstack-trove | 11:15 | |
*** matsuhashi has joined #openstack-trove | 11:16 | |
*** haomaiwa_ has quit IRC | 11:39 | |
*** haomaiwa_ has joined #openstack-trove | 11:40 | |
dougshelley66 | dmakogon_, yt? | 11:43 |
*** dmakogon_ is now known as denis_makogon | 11:43 | |
denis_makogon | dougshelley66, yes | 11:43 |
dougshelley66 | denis_makogon, just looking at https://review.openstack.org/#/c/98985/ | 11:43 |
dougshelley66 | denis_makogon, and https://review.openstack.org/#/c/98988/ | 11:44 |
dougshelley66 | denis_makogon, are you expecting the output to look like this? https://gist.github.com/dshelley66/b9dc73ab9bb5224962a5 | 11:44 |
denis_makogon | dougshelley66, yes | 11:44 |
dougshelley66 | denis_makogon, i believe the order of the attributes in show is incorrect | 11:45 |
dougshelley66 | shouldn't the id and name be first | 11:45 |
denis_makogon | dougshelley66, for which shell command ? | 11:45 |
dougshelley66 | trove configuration-show | 11:45 |
dougshelley66 | the second one in that gist | 11:45 |
denis_makogon | dougshelley66, i don't think that i'm able to control the order of the values | 11:46 |
dougshelley66 | denis_makogon, ok I thought it was that order before, let me revert the patch and check | 11:47 |
denis_makogon | dougshelley66, attr order is manageable only for list shell commands | 11:47 |
dougshelley66 | denis_makogon, ok it looks like it ds version id first - i guess i didn't notice because ID was closer to the top | 11:48 |
*** ajc_ has quit IRC | 11:50 | |
*** ajc_ has joined #openstack-trove | 11:50 | |
dougshelley66 | denis_makogon, one other question | 11:51 |
dougshelley66 | in https://review.openstack.org/#/c/98985/8/trove/configuration/views.py,cm | 11:51 |
dougshelley66 | denis_makogon, i don't understand why you added ds version and ds to the interface for ConfigurationView | 11:52 |
dougshelley66 | denis_makogon, it looks like they are already part of "configuration" | 11:52 |
dougshelley66 | denis_makogon, is there a case where ConfigurationView is constructed outside of DetailConfigurationView? | 11:53 |
denis_makogon | dougshelley66, because only datastore version is the part of configuration | 11:53 |
denis_makogon | dougshelley66, yes, ConfigurationsView | 11:53 |
dougshelley66 | denis_makogon, ok - i see | 11:53 |
*** julienvey has joined #openstack-trove | 11:54 | |
*** ajc_ has quit IRC | 11:55 | |
dougshelley66 | denis_makogon, it just seems unfortunate that those attributes have to be tacked onto the ConfigurationView interface in that way | 11:55 |
dougshelley66 | denis_makogon, when in some cases they could already be in the configuration object | 11:55 |
*** haomaiwa_ has quit IRC | 11:56 | |
*** haomaiw__ has joined #openstack-trove | 11:56 | |
*** sgotliv has quit IRC | 11:57 | |
denis_makogon | dougshelley66, but they are not in configuration object, since it's totally enough to have datastore version id there so we can retrieve regular dstore/dversion objects | 12:01 |
*** juantwo has joined #openstack-trove | 12:02 | |
*** juantwo has quit IRC | 12:06 | |
*** juantwo has joined #openstack-trove | 12:06 | |
*** Longgeek has quit IRC | 12:07 | |
*** Longgeek has joined #openstack-trove | 12:08 | |
*** Longgeek has quit IRC | 12:13 | |
*** matsuhashi has quit IRC | 12:13 | |
*** matsuhashi has joined #openstack-trove | 12:14 | |
*** pdmars has joined #openstack-trove | 12:17 | |
*** matsuhas_ has joined #openstack-trove | 12:18 | |
*** matsuhashi has quit IRC | 12:18 | |
*** pdmars has quit IRC | 12:19 | |
*** pdmars has joined #openstack-trove | 12:19 | |
*** coolsvap|afk is now known as coolsvap | 12:38 | |
*** Longgeek has joined #openstack-trove | 13:02 | |
*** imsplitb1t is now known as imsplitbit | 13:03 | |
*** Longgeek has quit IRC | 13:04 | |
*** haomaiw__ has quit IRC | 13:13 | |
*** sgotliv has joined #openstack-trove | 13:13 | |
*** haomaiwang has joined #openstack-trove | 13:14 | |
*** miqui has joined #openstack-trove | 13:20 | |
*** tvoran has joined #openstack-trove | 13:24 | |
*** Longgeek has joined #openstack-trove | 13:28 | |
*** flaper87 is now known as flaper87|afk | 13:31 | |
*** julienvey has quit IRC | 13:35 | |
*** mattgriffin has joined #openstack-trove | 13:36 | |
*** rhodgin has quit IRC | 13:37 | |
*** kevinconway has joined #openstack-trove | 13:42 | |
*** kevinconway has quit IRC | 13:44 | |
*** kevinconway has joined #openstack-trove | 13:46 | |
*** anteaya has quit IRC | 13:51 | |
*** kevinconway has quit IRC | 13:52 | |
*** iartarisi has joined #openstack-trove | 13:52 | |
iartarisi | Hi! Where can I find a sample database image to use with trove? | 13:52 |
*** anteaya has joined #openstack-trove | 13:52 | |
*** robertmyers has joined #openstack-trove | 13:53 | |
*** sgotliv has quit IRC | 13:55 | |
*** julienvey has joined #openstack-trove | 14:00 | |
imsplitbit | iartarisi: I don't know the specific location but if you look at deploying trove with devstack there is an image builder process that will happen and make an image that will work with trove | 14:01 |
*** ranjitha has joined #openstack-trove | 14:02 | |
*** jcru has joined #openstack-trove | 14:02 | |
*** kevinconway has joined #openstack-trove | 14:02 | |
iartarisi | imsplitbit: ok, thanks | 14:05 |
*** ranjitha has quit IRC | 14:12 | |
*** amytron has joined #openstack-trove | 14:12 | |
*** matsuhas_ has quit IRC | 14:17 | |
*** jmontemayor has joined #openstack-trove | 14:19 | |
*** grapex has joined #openstack-trove | 14:19 | |
*** grapex has quit IRC | 14:20 | |
*** grapex has joined #openstack-trove | 14:20 | |
*** rhodgin has joined #openstack-trove | 14:22 | |
*** matsuhashi has joined #openstack-trove | 14:23 | |
*** yidclare has joined #openstack-trove | 14:23 | |
*** jcru has quit IRC | 14:26 | |
*** yidclare has quit IRC | 14:26 | |
*** jcru has joined #openstack-trove | 14:27 | |
*** matsuhashi has quit IRC | 14:33 | |
*** matsuhashi has joined #openstack-trove | 14:33 | |
*** rwsu has joined #openstack-trove | 14:34 | |
*** matsuhashi has quit IRC | 14:38 | |
*** matsuhashi has joined #openstack-trove | 14:40 | |
*** haomaiwang has quit IRC | 14:52 | |
*** michael-yu has joined #openstack-trove | 14:59 | |
*** shayneburgess has joined #openstack-trove | 15:00 | |
*** haomaiwang has joined #openstack-trove | 15:05 | |
*** matsuhashi has quit IRC | 15:07 | |
*** matsuhashi has joined #openstack-trove | 15:07 | |
*** haomai___ has joined #openstack-trove | 15:07 | |
*** haomaiwang has quit IRC | 15:10 | |
*** matsuhashi has quit IRC | 15:11 | |
*** michael-yu has quit IRC | 15:12 | |
*** coolsvap is now known as coolsvap|afk | 15:27 | |
*** denis_makogon_ has joined #openstack-trove | 15:28 | |
*** denis_makogon has quit IRC | 15:32 | |
*** denis_makogon_ is now known as denis_makogon | 15:32 | |
*** dmakogon_ has joined #openstack-trove | 15:33 | |
*** jmontemayor has quit IRC | 15:33 | |
*** shayneburgess has quit IRC | 15:34 | |
*** jmontemayor has joined #openstack-trove | 15:36 | |
denis_makogon | amrith, take a look at https://review.openstack.org/#/c/97194/ | 15:38 |
*** ramishra has joined #openstack-trove | 15:38 | |
*** ramishra_ has joined #openstack-trove | 15:41 | |
*** ramishra has quit IRC | 15:43 | |
*** eghobo has joined #openstack-trove | 15:52 | |
*** eghobo has quit IRC | 15:52 | |
*** annashe__ has joined #openstack-trove | 15:52 | |
*** eghobo has joined #openstack-trove | 15:53 | |
*** eghobo has quit IRC | 15:53 | |
*** eghobo has joined #openstack-trove | 15:54 | |
*** Longgeek has quit IRC | 16:02 | |
*** robe5515 has joined #openstack-trove | 16:05 | |
*** shayneburgess has joined #openstack-trove | 16:16 | |
*** shayneburgess has quit IRC | 16:20 | |
*** iartarisi has quit IRC | 16:23 | |
*** annashe__ has quit IRC | 16:26 | |
*** annashe__ has joined #openstack-trove | 16:27 | |
*** ViswaV has joined #openstack-trove | 16:28 | |
*** coolsvap|afk is now known as coolsvap | 16:31 | |
*** annashe__ has quit IRC | 16:31 | |
*** julienvey has quit IRC | 16:32 | |
*** ViswaV has quit IRC | 16:43 | |
*** shayneburgess has joined #openstack-trove | 16:46 | |
*** dkehn_ has joined #openstack-trove | 16:52 | |
*** dkehn_ is now known as dkehnx2 | 16:53 | |
*** dkehnx2 is now known as dkehnc | 16:53 | |
*** dkehnc has quit IRC | 16:54 | |
*** dkehnc has joined #openstack-trove | 16:55 | |
*** dkehnx has quit IRC | 16:55 | |
*** dkehnc is now known as dkehnx | 16:56 | |
*** robertmyers has quit IRC | 16:59 | |
*** robertmyers has joined #openstack-trove | 17:00 | |
*** mattgriffin has quit IRC | 17:01 | |
*** isviridov is now known as isviridov|away | 17:01 | |
*** haomai___ has quit IRC | 17:02 | |
*** robe5515 has quit IRC | 17:02 | |
*** ViswaV has joined #openstack-trove | 17:03 | |
*** ramashri has joined #openstack-trove | 17:04 | |
*** ViswaV has quit IRC | 17:04 | |
*** ViswaV_ has joined #openstack-trove | 17:04 | |
*** ViswaV has joined #openstack-trove | 17:05 | |
*** ViswaV_ has quit IRC | 17:05 | |
*** michael-yu has joined #openstack-trove | 17:06 | |
*** ViswaV has quit IRC | 17:06 | |
*** ViswaV has joined #openstack-trove | 17:06 | |
*** ViswaV_ has joined #openstack-trove | 17:07 | |
*** dkehn_ has joined #openstack-trove | 17:08 | |
*** ViswaV__ has joined #openstack-trove | 17:09 | |
*** ViswaV_ has quit IRC | 17:09 | |
*** shayneburgess has quit IRC | 17:09 | |
*** ViswaV_ has joined #openstack-trove | 17:10 | |
*** ViswaV__ has quit IRC | 17:10 | |
*** ViswaV has quit IRC | 17:11 | |
*** dkehnx has quit IRC | 17:11 | |
*** mattgriffin has joined #openstack-trove | 17:13 | |
amrith | denis_makogon, re 97194 it looks like gate failed. I'll wait for you to confirm that you are OK with the change(s). | 17:16 |
denis_makogon | amrith, code is ok, rdjenkins failed due to configuration tests again | 17:19 |
*** annashe__ has joined #openstack-trove | 17:19 | |
*** grapex_ has joined #openstack-trove | 17:24 | |
*** grapex_ has quit IRC | 17:27 | |
*** shayneburgess has joined #openstack-trove | 17:27 | |
*** grapex has quit IRC | 17:27 | |
*** grapex has joined #openstack-trove | 17:28 | |
*** grapex has quit IRC | 17:30 | |
*** grapex has joined #openstack-trove | 17:30 | |
*** michael-yu has quit IRC | 17:31 | |
*** michael-yu has joined #openstack-trove | 17:32 | |
*** ramashri has quit IRC | 17:32 | |
*** ramashri has joined #openstack-trove | 17:33 | |
*** ramishra_ has quit IRC | 17:34 | |
*** yidclare has joined #openstack-trove | 17:34 | |
*** rueben has joined #openstack-trove | 17:34 | |
*** thedodd has joined #openstack-trove | 17:35 | |
*** eghobo has quit IRC | 17:37 | |
*** eguz has joined #openstack-trove | 17:37 | |
*** shayneburgess has quit IRC | 17:38 | |
amrith | denis_makogon, I don't think the code is right | 17:39 |
amrith | it doesn't do what was discussed yesterday | 17:40 |
amrith | I'll post comments in the review or we can discuss here. | 17:40 |
amrith | I'm in and out so if I don't immediately reply to irc, give it a couple of minutes | 17:40 |
amrith | denis_makogon ^^ | 17:40 |
*** ramashri_ has joined #openstack-trove | 17:42 | |
*** shayneburgess has joined #openstack-trove | 17:42 | |
*** ramashri has quit IRC | 17:45 | |
*** rueben_ has joined #openstack-trove | 17:49 | |
*** eguz has quit IRC | 17:49 | |
*** eghobo has joined #openstack-trove | 17:50 | |
*** rueben has quit IRC | 17:53 | |
*** shayneburgess has quit IRC | 17:54 | |
*** dkehn_ is now known as dkehnx | 17:58 | |
*** doddstack has joined #openstack-trove | 17:59 | |
*** thedodd has quit IRC | 18:00 | |
*** jcru has quit IRC | 18:08 | |
*** juantwo has quit IRC | 18:08 | |
*** boden has quit IRC | 18:08 | |
*** yidclare has quit IRC | 18:08 | |
*** grapex has quit IRC | 18:08 | |
*** robertmyers has quit IRC | 18:08 | |
*** rhodgin has quit IRC | 18:08 | |
*** tvoran has quit IRC | 18:08 | |
*** jcooley has quit IRC | 18:08 | |
*** konetzed has quit IRC | 18:08 | |
*** eghobo has quit IRC | 18:08 | |
*** rueben_ has quit IRC | 18:08 | |
*** mat-lowery has quit IRC | 18:08 | |
*** peterstac has quit IRC | 18:08 | |
*** Robe has quit IRC | 18:08 | |
*** zacksh has quit IRC | 18:08 | |
*** zigo has quit IRC | 18:08 | |
*** erik_x1 has quit IRC | 18:08 | |
*** vgnbkr has quit IRC | 18:08 | |
*** k-pom has quit IRC | 18:08 | |
*** abramley has quit IRC | 18:08 | |
*** eghobo has joined #openstack-trove | 18:10 | |
*** rueben_ has joined #openstack-trove | 18:10 | |
*** yidclare has joined #openstack-trove | 18:10 | |
*** grapex has joined #openstack-trove | 18:10 | |
*** robertmyers has joined #openstack-trove | 18:10 | |
*** jcru has joined #openstack-trove | 18:10 | |
*** rhodgin has joined #openstack-trove | 18:10 | |
*** tvoran has joined #openstack-trove | 18:10 | |
*** juantwo has joined #openstack-trove | 18:10 | |
*** boden has joined #openstack-trove | 18:10 | |
*** jcooley has joined #openstack-trove | 18:10 | |
*** konetzed has joined #openstack-trove | 18:10 | |
*** mat-lowery has joined #openstack-trove | 18:10 | |
*** peterstac has joined #openstack-trove | 18:10 | |
*** Robe has joined #openstack-trove | 18:10 | |
*** abramley has joined #openstack-trove | 18:10 | |
*** k-pom has joined #openstack-trove | 18:10 | |
*** vgnbkr has joined #openstack-trove | 18:10 | |
*** erik_x1 has joined #openstack-trove | 18:10 | |
*** zigo has joined #openstack-trove | 18:10 | |
*** zacksh has joined #openstack-trove | 18:10 | |
*** jcru has quit IRC | 18:14 | |
*** juantwo has quit IRC | 18:14 | |
*** boden has quit IRC | 18:14 | |
*** yidclare has quit IRC | 18:14 | |
*** grapex has quit IRC | 18:14 | |
*** robertmyers has quit IRC | 18:14 | |
*** rhodgin has quit IRC | 18:14 | |
*** tvoran has quit IRC | 18:14 | |
*** jcooley has quit IRC | 18:14 | |
*** konetzed has quit IRC | 18:14 | |
*** eghobo has quit IRC | 18:14 | |
*** rueben_ has quit IRC | 18:14 | |
*** mat-lowery has quit IRC | 18:14 | |
*** peterstac has quit IRC | 18:14 | |
*** Robe has quit IRC | 18:14 | |
*** zacksh has quit IRC | 18:14 | |
*** zigo has quit IRC | 18:14 | |
*** erik_x1 has quit IRC | 18:14 | |
*** vgnbkr has quit IRC | 18:14 | |
*** k-pom has quit IRC | 18:14 | |
*** abramley has quit IRC | 18:14 | |
*** ViswaV_ has quit IRC | 18:15 | |
*** eghobo has joined #openstack-trove | 18:16 | |
*** rueben_ has joined #openstack-trove | 18:16 | |
*** yidclare has joined #openstack-trove | 18:16 | |
*** grapex has joined #openstack-trove | 18:16 | |
*** robertmyers has joined #openstack-trove | 18:16 | |
*** jcru has joined #openstack-trove | 18:16 | |
*** rhodgin has joined #openstack-trove | 18:16 | |
*** tvoran has joined #openstack-trove | 18:16 | |
*** juantwo has joined #openstack-trove | 18:16 | |
*** boden has joined #openstack-trove | 18:16 | |
*** jcooley has joined #openstack-trove | 18:16 | |
*** konetzed has joined #openstack-trove | 18:16 | |
*** mat-lowery has joined #openstack-trove | 18:16 | |
*** peterstac has joined #openstack-trove | 18:16 | |
*** Robe has joined #openstack-trove | 18:16 | |
*** abramley has joined #openstack-trove | 18:16 | |
*** k-pom has joined #openstack-trove | 18:16 | |
*** vgnbkr has joined #openstack-trove | 18:16 | |
*** erik_x1 has joined #openstack-trove | 18:16 | |
*** zigo has joined #openstack-trove | 18:16 | |
*** zacksh has joined #openstack-trove | 18:16 | |
*** dkehn_ has joined #openstack-trove | 18:25 | |
*** dkehn_ has quit IRC | 18:27 | |
*** dkehnx has quit IRC | 18:28 | |
*** dkehn_ has joined #openstack-trove | 18:28 | |
*** boden has quit IRC | 18:33 | |
*** jcru has quit IRC | 18:33 | |
*** boden has joined #openstack-trove | 18:34 | |
*** yidclare has quit IRC | 18:50 | |
*** ViswaV has joined #openstack-trove | 18:53 | |
*** ViswaV_ has joined #openstack-trove | 18:55 | |
*** ViswaV has quit IRC | 18:55 | |
*** ViswaV has joined #openstack-trove | 18:56 | |
*** ViswaV_ has quit IRC | 18:56 | |
*** ekarlso has quit IRC | 19:01 | |
*** sgotliv has joined #openstack-trove | 19:03 | |
*** ekarlso has joined #openstack-trove | 19:05 | |
*** ViswaV has quit IRC | 19:06 | |
*** haomaiwang has joined #openstack-trove | 19:09 | |
*** dkehn_ has quit IRC | 19:24 | |
*** rueben_ has quit IRC | 19:25 | |
*** julienvey has joined #openstack-trove | 19:27 | |
*** ViswaV has joined #openstack-trove | 19:32 | |
*** michael-yu has quit IRC | 19:32 | |
*** rueben has joined #openstack-trove | 19:34 | |
*** dkehn_ has joined #openstack-trove | 19:35 | |
*** dkehn_ has quit IRC | 19:36 | |
*** dkehn_ has joined #openstack-trove | 19:37 | |
*** dkehn_ is now known as dkehnx | 19:37 | |
*** ramashri_ has quit IRC | 19:40 | |
denis_makogon | amrith, ping | 19:40 |
amrith | yes denis_makogon | 19:42 |
denis_makogon | amrith, about your comments. First of all, we have _only_ three ways to create instance, _only_ in two places server status poller is needed, stack-based instance doesn't need compute instance status poller | 19:44 |
denis_makogon | amrith, i do agree, that i missed ..._create_server_volume(...) method to add compute instance status poller | 19:46 |
amrith | denis_makogon is that a question or a statement? | 19:46 |
denis_makogon | amrith, and that's it | 19:46 |
denis_makogon | amrith, those are statements | 19:47 |
amrith | denis_makogon, ok. in that case they are incorrect statements. | 19:47 |
denis_makogon | amrith, why is that ? | 19:47 |
amrith | what about _create_server_volume()? | 19:47 |
amrith | isn't that the fourth? | 19:47 |
denis_makogon | amrith, i said that i missed that, i'll add poller there, and that's it | 19:48 |
denis_makogon | amrith, nope | 19:48 |
amrith | ok, never mind. why don't you submit new code and I'll look at it. | 19:48 |
amrith | thanks denis_makogon | 19:48 |
denis_makogon | _create_server is used by _create_server_volume_individually | 19:48 |
denis_makogon | amrith, _create_server is not used anywhere else | 19:48 |
denis_makogon | amrith, taskmanager has only 3 ways to deliver instance, nothing else | 19:49 |
amrith | denis_makogon, I believe I said that in my review comments. I said "One of them is _create_server and the only thing that calls that is _create_server_volume_individually" | 19:49 |
amrith | in any event, you agree that there's something you have to change. You'll change it. you'll submit it, I'll look at it then. Right now I have to go and put ice on my leg. | 19:50 |
amrith | toodles! | 19:50 |
amrith | isn't it kind-of-late in the day where you are? | 19:50 |
denis_makogon | amrith, i was confused with incorrect statement that trove can deliver instance in four ways | 19:50 |
amrith | don't you ever sleep | 19:50 |
denis_makogon | three ways: https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L188-L213 | 19:51 |
denis_makogon | amrith, it's late but not for me | 19:51 |
*** dkehn_ has joined #openstack-trove | 19:58 | |
*** boden has quit IRC | 20:00 | |
*** dkehn_ has quit IRC | 20:00 | |
*** dkehn_ has joined #openstack-trove | 20:00 | |
*** dkehnx has quit IRC | 20:00 | |
*** denis_makogon has quit IRC | 20:05 | |
*** pdmars has quit IRC | 20:06 | |
*** rueben has quit IRC | 20:07 | |
*** jmontemayor has quit IRC | 20:12 | |
*** tvoran has quit IRC | 20:20 | |
*** ramashri has joined #openstack-trove | 20:22 | |
*** michael-yu has joined #openstack-trove | 20:26 | |
*** tvoran has joined #openstack-trove | 20:29 | |
*** ViswaV has quit IRC | 20:29 | |
*** ViswaV has joined #openstack-trove | 20:29 | |
*** haomaiwang has quit IRC | 20:32 | |
*** yidclare has joined #openstack-trove | 20:36 | |
*** michael-yu has quit IRC | 20:39 | |
*** rueben has joined #openstack-trove | 20:48 | |
*** ramashri has quit IRC | 20:50 | |
*** ramashri has joined #openstack-trove | 20:51 | |
*** michael-yu has joined #openstack-trove | 20:54 | |
*** tvoran has quit IRC | 21:01 | |
*** tvoran has joined #openstack-trove | 21:05 | |
*** coolsvap is now known as coolsvap|afk | 21:09 | |
*** juantwo has quit IRC | 21:10 | |
*** robe5515 has joined #openstack-trove | 21:12 | |
*** robe5515 has quit IRC | 21:15 | |
*** robe5515 has joined #openstack-trove | 21:15 | |
*** robe5515_ has joined #openstack-trove | 21:17 | |
*** robe5515 has quit IRC | 21:20 | |
*** robe5515 has joined #openstack-trove | 21:20 | |
*** rueben_ has joined #openstack-trove | 21:20 | |
*** robe5515_ has quit IRC | 21:21 | |
*** rueben has quit IRC | 21:24 | |
*** grapex has quit IRC | 21:28 | |
*** robe5515 has quit IRC | 21:30 | |
*** robertmyers has quit IRC | 21:30 | |
*** ramashri has quit IRC | 21:30 | |
*** sgotliv has quit IRC | 21:30 | |
*** robertmyers has joined #openstack-trove | 21:30 | |
*** ramashri has joined #openstack-trove | 21:31 | |
*** dkehn_ is now known as dkehnx | 21:32 | |
*** openstackgerrit has joined #openstack-trove | 21:34 | |
*** robertmyers has quit IRC | 21:35 | |
openstackgerrit | amrith proposed a change to openstack/trove: Two messages in exceptions.py not setup for localization https://review.openstack.org/101301 | 21:42 |
*** grapex has joined #openstack-trove | 21:46 | |
*** dkehn_ has joined #openstack-trove | 21:48 | |
*** dkehn_ has quit IRC | 21:49 | |
*** dkehn_ has joined #openstack-trove | 21:49 | |
*** tvoran has quit IRC | 21:49 | |
*** dkehnx has quit IRC | 21:50 | |
*** grapex has quit IRC | 21:56 | |
*** achampion has joined #openstack-trove | 22:00 | |
*** michael-yu has quit IRC | 22:03 | |
*** michael-yu has joined #openstack-trove | 22:07 | |
*** yidclare has quit IRC | 22:07 | |
*** tvoran has joined #openstack-trove | 22:10 | |
*** tvoran has quit IRC | 22:10 | |
*** annashe__ has quit IRC | 22:13 | |
*** annashe__ has joined #openstack-trove | 22:13 | |
*** annashe__ has quit IRC | 22:18 | |
*** julienvey has quit IRC | 22:26 | |
*** mattgriffin has quit IRC | 22:28 | |
*** ViswaV has quit IRC | 22:33 | |
*** ViswaV has joined #openstack-trove | 22:34 | |
*** openstackgerrit has quit IRC | 22:34 | |
*** 20WAAHXAJ has joined #openstack-trove | 22:35 | |
*** ViswaV has quit IRC | 22:35 | |
*** ViswaV has joined #openstack-trove | 22:35 | |
*** ViswaV has quit IRC | 22:36 | |
*** ViswaV has joined #openstack-trove | 22:36 | |
*** doddstack has quit IRC | 22:37 | |
*** rueben_ has quit IRC | 22:44 | |
*** rueben has joined #openstack-trove | 22:45 | |
*** yidclare has joined #openstack-trove | 22:45 | |
*** openstack has joined #openstack-trove | 22:50 | |
*** rueben has quit IRC | 22:58 | |
*** michael-yu has quit IRC | 23:08 | |
*** ViswaV has quit IRC | 23:09 | |
*** ViswaV has joined #openstack-trove | 23:10 | |
*** ViswaV has quit IRC | 23:11 | |
*** ViswaV has joined #openstack-trove | 23:16 | |
*** annashe__ has joined #openstack-trove | 23:19 | |
*** dkehn_ is now known as dkehnx | 23:20 | |
*** 20WAAHXAJ has quit IRC | 23:29 | |
*** openstackgerrit has joined #openstack-trove | 23:30 | |
*** amytron has quit IRC | 23:32 | |
*** yidclare has quit IRC | 23:36 | |
*** julienvey has joined #openstack-trove | 23:37 | |
*** julienvey has quit IRC | 23:41 | |
*** rhodgin has quit IRC | 23:49 | |
*** dkehn_ has joined #openstack-trove | 23:50 | |
*** dkehn_ has quit IRC | 23:51 | |
*** dkehn_ has joined #openstack-trove | 23:51 | |
*** dkehnx has quit IRC | 23:51 | |
*** kevinconway has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!