*** shayneburgess has joined #openstack-trove | 00:39 | |
*** shayneburgess has quit IRC | 00:39 | |
*** eghobo has quit IRC | 01:19 | |
*** nosnos has joined #openstack-trove | 01:37 | |
openstackgerrit | A change was merged to openstack/trove: Added route for Admin API to support guest upgrade https://review.openstack.org/81410 | 01:54 |
---|---|---|
*** miqui_ has quit IRC | 02:11 | |
*** ViswaV has joined #openstack-trove | 02:35 | |
*** achampion has quit IRC | 02:37 | |
*** achampion has joined #openstack-trove | 02:46 | |
*** ramishra has joined #openstack-trove | 02:57 | |
*** coolsvap|afk is now known as coolsvap | 03:05 | |
*** mrsnivvel has joined #openstack-trove | 03:07 | |
*** yidclare has joined #openstack-trove | 03:22 | |
*** jeraldv has joined #openstack-trove | 03:23 | |
*** nosnos has quit IRC | 03:25 | |
*** ViswaV has quit IRC | 03:38 | |
*** ViswaV has joined #openstack-trove | 03:39 | |
*** coolsvap is now known as coolsvap|afk | 04:00 | |
*** nosnos has joined #openstack-trove | 04:02 | |
*** yidclare has quit IRC | 04:02 | |
*** eghobo has joined #openstack-trove | 04:06 | |
*** robertmyers has quit IRC | 04:19 | |
*** juantwo has quit IRC | 04:20 | |
*** robertmyers has joined #openstack-trove | 04:21 | |
*** robertmyers has quit IRC | 04:26 | |
*** robertmyers has joined #openstack-trove | 04:26 | |
*** robertmyers has quit IRC | 04:31 | |
*** eghobo has quit IRC | 04:37 | |
*** eghobo has joined #openstack-trove | 04:40 | |
*** ajc_ has joined #openstack-trove | 04:52 | |
*** sgotliv has joined #openstack-trove | 05:25 | |
*** coolsvap|afk is now known as coolsvap | 05:30 | |
openstackgerrit | A change was merged to openstack/trove: Add CONTRIBUTING.rst https://review.openstack.org/103787 | 05:34 |
*** annashen_ has quit IRC | 05:36 | |
*** Longgeek has joined #openstack-trove | 05:45 | |
openstackgerrit | A change was merged to openstack/trove: Imported Translations from Transifex https://review.openstack.org/104757 | 05:45 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/105070 | 06:05 |
*** sgotliv has quit IRC | 06:10 | |
*** eghobo has quit IRC | 06:15 | |
*** eghobo has joined #openstack-trove | 06:15 | |
*** eghobo has quit IRC | 06:16 | |
*** ramishra has quit IRC | 06:23 | |
*** ramishra_ has joined #openstack-trove | 06:28 | |
*** annashen_ has joined #openstack-trove | 06:42 | |
*** annashen_ has quit IRC | 06:53 | |
openstackgerrit | A change was merged to openstack/trove: Logging audit for trove/db module https://review.openstack.org/103953 | 06:56 |
*** haomaiwa_ has joined #openstack-trove | 07:05 | |
*** flaper87|afk is now known as flaper87 | 07:24 | |
*** mariusv has quit IRC | 08:17 | |
*** mariusv has joined #openstack-trove | 08:19 | |
*** sgotliv has joined #openstack-trove | 08:25 | |
*** robertmyers has joined #openstack-trove | 08:28 | |
*** robertmyers has quit IRC | 08:32 | |
*** ramishra_ has quit IRC | 08:33 | |
*** coolsvap is now known as coolsvap|afk | 08:52 | |
*** ramishra has joined #openstack-trove | 08:52 | |
*** coolsvap|afk is now known as coolsvap | 09:04 | |
openstackgerrit | Shalini khandelwal proposed a change to openstack/trove-integration: Initial support for Vertica Datastore in trove https://review.openstack.org/89804 | 09:27 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted https://review.openstack.org/102838 | 10:02 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occures https://review.openstack.org/102262 | 10:02 |
*** sgotliv has quit IRC | 10:22 | |
*** haomaiwa_ has quit IRC | 10:38 | |
*** haomaiwa_ has joined #openstack-trove | 10:38 | |
*** demorris has quit IRC | 10:40 | |
*** boden has joined #openstack-trove | 10:49 | |
openstackgerrit | Shalini khandelwal proposed a change to openstack/trove: Initial support for Vertica Datastore in trove https://review.openstack.org/91761 | 10:51 |
*** haomaiwa_ has quit IRC | 10:57 | |
*** haomai___ has joined #openstack-trove | 10:57 | |
*** sgotliv has joined #openstack-trove | 11:06 | |
*** coolsvap is now known as coolsvap|afk | 11:08 | |
openstackgerrit | Shashank Gupta proposed a change to openstack/trove: Backup/Restore feature for Vertica Datastore https://review.openstack.org/95759 | 11:15 |
*** coolsvap|afk is now known as coolsvap | 11:16 | |
*** demorris has joined #openstack-trove | 11:18 | |
*** ramishra has quit IRC | 11:43 | |
*** coolsvap is now known as coolsvap|afk | 11:46 | |
*** demorris has quit IRC | 11:48 | |
*** juantwo has joined #openstack-trove | 11:55 | |
*** sgotliv has quit IRC | 12:04 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted https://review.openstack.org/102838 | 12:10 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occures https://review.openstack.org/102262 | 12:10 |
*** sgotliv has joined #openstack-trove | 12:17 | |
*** setho has joined #openstack-trove | 12:26 | |
*** serverascode has quit IRC | 12:28 | |
*** coolsvapl has joined #openstack-trove | 12:30 | |
*** zacksh has quit IRC | 12:30 | |
*** zacksh has joined #openstack-trove | 12:30 | |
*** setho2 has quit IRC | 12:30 | |
*** coolsvap|afk has quit IRC | 12:30 | |
*** coolsvapl has quit IRC | 12:31 | |
*** coolsvapl has joined #openstack-trove | 12:31 | |
*** serverascode has joined #openstack-trove | 12:31 | |
*** ajc_ has quit IRC | 12:33 | |
*** radez_g0n3 is now known as radez | 12:34 | |
*** ramishra has joined #openstack-trove | 12:36 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 12:38 |
*** juantwo has quit IRC | 12:56 | |
*** juantwo has joined #openstack-trove | 12:57 | |
*** nosnos has quit IRC | 13:02 | |
*** tvoran has joined #openstack-trove | 13:08 | |
*** miqui has joined #openstack-trove | 13:17 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/105175 | 13:33 |
*** demorris has joined #openstack-trove | 13:34 | |
*** jasond` has joined #openstack-trove | 13:49 | |
jasond` | hi, where is the trove API documentation? | 13:49 |
denis_makogon | jasond`, https://github.com/openstack/trove/tree/master/apidocs/src | 13:56 |
jasond` | denis_makogon: is there a human-readable version somewhere? | 13:58 |
denis_makogon | jasond`, actually, don't know, but i'll try to find it for you | 13:58 |
jasond` | denis_makogon: i can probably just use the rackspace cloud databases doc. thanks though | 13:59 |
denis_makogon | jasond`, np | 13:59 |
jasond` | the link here is stale BTW http://docs.openstack.org/developer/trove/ | 13:59 |
*** grapex has joined #openstack-trove | 14:00 | |
denis_makogon | jasond`, but there's no API docs =) | 14:01 |
*** grapex has quit IRC | 14:01 | |
*** grapex has joined #openstack-trove | 14:01 | |
*** grapex_ has joined #openstack-trove | 14:02 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 14:03 |
*** grapex has quit IRC | 14:06 | |
*** yidclare has joined #openstack-trove | 14:10 | |
*** robertmyers has joined #openstack-trove | 14:16 | |
*** yidclare has quit IRC | 14:18 | |
*** mattgriffin has joined #openstack-trove | 14:25 | |
*** karimb has joined #openstack-trove | 14:29 | |
*** Longgeek has quit IRC | 14:34 | |
*** sgotliv has quit IRC | 14:35 | |
*** Longgeek has joined #openstack-trove | 14:36 | |
*** juantwo has quit IRC | 14:42 | |
*** juantwo has joined #openstack-trove | 14:42 | |
*** juantwo has quit IRC | 14:44 | |
*** juantwo has joined #openstack-trove | 14:45 | |
*** IvanZ has joined #openstack-trove | 14:58 | |
*** ramishra has quit IRC | 15:02 | |
*** demorris_ has joined #openstack-trove | 15:04 | |
*** demorris has quit IRC | 15:04 | |
*** demorris_ is now known as demorris | 15:04 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix Cassandra service status definition https://review.openstack.org/99424 | 15:12 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix Cassandra service status definition https://review.openstack.org/99424 | 15:17 |
*** karimb has quit IRC | 15:18 | |
*** ramishra has joined #openstack-trove | 15:18 | |
*** thedodd has joined #openstack-trove | 15:21 | |
*** doddstack has joined #openstack-trove | 15:24 | |
*** thedodd has quit IRC | 15:26 | |
*** ViswaV_ has joined #openstack-trove | 15:30 | |
*** ViswaV has quit IRC | 15:32 | |
*** coolsvapl is now known as coolsvap | 15:37 | |
*** Longgeek has quit IRC | 15:39 | |
*** rwsu has joined #openstack-trove | 15:47 | |
*** shayneburgess has joined #openstack-trove | 15:49 | |
*** IvanZ has quit IRC | 15:50 | |
*** IvanZ has joined #openstack-trove | 15:52 | |
*** IvanZ has quit IRC | 16:03 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted https://review.openstack.org/102838 | 16:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occures https://review.openstack.org/102262 | 16:03 |
*** juantwo has quit IRC | 16:04 | |
*** juantwo has joined #openstack-trove | 16:05 | |
*** nehav has joined #openstack-trove | 16:08 | |
*** doddstack has quit IRC | 16:16 | |
*** coolsvap is now known as coolsvap|afk | 16:16 | |
*** cweid has joined #openstack-trove | 16:18 | |
denis_makogon | cores, take a look at https://bugs.launchpad.net/trove/+bug/1338660 | 16:20 |
*** edmund has joined #openstack-trove | 16:23 | |
*** annashen_ has joined #openstack-trove | 16:25 | |
*** thedodd has joined #openstack-trove | 16:34 | |
*** edmund has quit IRC | 16:35 | |
*** juantwo has quit IRC | 16:41 | |
*** juantwo has joined #openstack-trove | 16:43 | |
SlickNik | Hi folks — it's an hour before the BP meeting, and I don't see anything on the agenda at https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting. | 17:05 |
SlickNik | So I'm canceling the meeting for this week to give you back the hour. | 17:05 |
denis_makogon | SlickNik, take a look at https://bugs.launchpad.net/trove/+bug/1338660 | 17:05 |
SlickNik | denis_makogon: That link seems to say that it affects NFS mounts. Yet we don't use NFS? | 17:09 |
denis_makogon | SlickNik, nfs was in a discussion, but bug happens in simple devstack installation | 17:10 |
denis_makogon | SlickNik, i'm only pointing that same thing happens inside dev box | 17:10 |
SlickNik | denis_makogon: Does it only affect cassandra? How ofter does it happen? | 17:11 |
denis_makogon | SlickNik, i was able to reproduce this bug 2-3 time today | 17:11 |
SlickNik | denis_makogon: According to that link, the copy succeeded even though rsync errored out. If that's the case, is this even a bug? | 17:11 |
denis_makogon | SlickNik, yes, because, exit code 24 for rsync also valid | 17:12 |
denis_makogon | SlickNik, this issue happens with temporary SSTables | 17:12 |
SlickNik | denis_makogon: Then perhaps the file is actually going away — and this has nothing to do with NFS. | 17:13 |
denis_makogon | SlickNik, yes, nothing about nfs, it's all about rsync, link was like an appendix to bug-report | 17:14 |
*** thedodd has quit IRC | 17:28 | |
*** ramishra has quit IRC | 17:33 | |
*** yidclare has joined #openstack-trove | 17:34 | |
*** eghobo has joined #openstack-trove | 17:35 | |
*** miqui has quit IRC | 17:45 | |
*** miqui has joined #openstack-trove | 17:49 | |
openstackgerrit | Matt Riedemann proposed a change to openstack/trove: Use (# of CPUs) api/conductor workers by default https://review.openstack.org/103239 | 17:54 |
amrith | denis_makogon, is this error happening on startup? i.e. when launching a trove instance with volume support? | 18:02 |
*** jmontemayor has joined #openstack-trove | 18:06 | |
*** jmontemayor_ has joined #openstack-trove | 18:07 | |
esp | ping grapex_ | 18:10 |
*** jmontemayor has quit IRC | 18:10 | |
*** eghobo has quit IRC | 18:11 | |
*** thedodd has joined #openstack-trove | 18:14 | |
*** eghobo has joined #openstack-trove | 18:22 | |
*** jmontemayor_ has quit IRC | 18:22 | |
*** eghobo has quit IRC | 18:23 | |
grapex_ | esp: yo | 18:23 |
*** eghobo has joined #openstack-trove | 18:24 | |
esp | howdy grapex_ , wanted to ask if you think I should abandon this change and upload a new patch https://review.openstack.org/#/c/85225/ | 18:25 |
grapex_ | esp: Sorry... let me review this for a bit so I can remember where it was | 18:27 |
grapex_ | Either way I'm good | 18:27 |
grapex_ | If it's a new patch we lose history | 18:27 |
grapex_ | What would be the upshot? Other than it would seem cleaner | 18:27 |
grapex_ | ... I really wish Gerrit would show what changed between what patch and another, without all the other stuff that was checked in | 18:27 |
esp | k, np grapex_ just wanted to make sure I asked ya before I did something wrong… | 18:28 |
*** eghobo has quit IRC | 18:28 | |
esp | it’s something new I’m trying out | 18:29 |
grapex_ | It would benefit me personally if you uploaded a new patch esp but I don't know if that would be a good precedent, so I'm good either way. SlickNik would have a good answer there for what the official stance is. | 18:29 |
esp | k, I’ll check with Slick :) thx! | 18:29 |
*** ViswaV_ has quit IRC | 18:32 | |
*** miqui has quit IRC | 18:32 | |
*** sgotliv has joined #openstack-trove | 18:32 | |
*** ViswaV has joined #openstack-trove | 18:33 | |
*** amcrn has joined #openstack-trove | 18:34 | |
*** rueben has joined #openstack-trove | 18:38 | |
*** radez is now known as radez_g0n3 | 18:39 | |
*** miqui has joined #openstack-trove | 18:41 | |
*** nehav has left #openstack-trove | 18:42 | |
*** cweid has quit IRC | 18:46 | |
*** cweid has joined #openstack-trove | 18:48 | |
openstackgerrit | A change was merged to openstack/trove-integration: Fix signature for launching int-tests https://review.openstack.org/103201 | 18:49 |
*** rueben has quit IRC | 18:53 | |
*** eghobo has joined #openstack-trove | 18:56 | |
*** eghobo has quit IRC | 18:57 | |
*** eghobo has joined #openstack-trove | 18:58 | |
SlickNik | esp: I'm fine either way. Feel free to do whatever makes your workflow easier. If you do decide to start a new review, just make sure that you put in a code review comment with a link to the last review, though. So it's there for posterity. | 19:00 |
*** radez_g0n3 is now known as radez | 19:00 | |
esp | k, thx SlickNik I may upload a clean patch before abandoning the other to see if it helps. | 19:01 |
esp | SlickNik: I’m madly debugging oslo.messagin atm | 19:02 |
esp | getting closer | 19:02 |
*** ViswaV_ has joined #openstack-trove | 19:04 | |
*** ViswaV has quit IRC | 19:05 | |
grapex_ | esp: Let me know if you make a new patch | 19:06 |
grapex_ | as I'm commenting on the old one. :/ | 19:06 |
grapex_ | But I'm good either way | 19:06 |
grapex_ | I like parts of Gerrit, but I wish it would focus more on the conversation like GitHub does | 19:06 |
grapex_ | Its so painful to dig through old patch sets and figure out what the conversation was... | 19:07 |
grapex_ | esp: One thing maybe have a discussion about here is there are a lot of subclasses in this pull request that don't do anything. | 19:08 |
grapex_ | esp: In a language with a compiler having interfaces is a good thing as it allows the compiler to pin down exactly what the code needs- so if you get the signature of a method wrong, the compiler tells you. But there is no compiler, so the best some of these ABC classes will do is tell you the class is wrong as it's being instantiated, which might be after you've spent ten minutes setting up a VM, making an instance, | 19:09 |
grapex_ | and trying to run an upgrade. | 19:09 |
grapex_ | esp: So my opinion is that the ABC classes and all these subclasses should go away, and be replaced with the simple "driver" pattern used everywhere, were some random class is instantiated using ImportClass. | 19:11 |
grapex_ | SlickNik vipul amcrn: I'm curious if you all see it that way too or have other opinions here. | 19:11 |
*** yidclare has quit IRC | 19:12 | |
*** michael-yu has joined #openstack-trove | 19:13 | |
amcrn | grapex_: agreed. i generally avoid subclassing even in java unless absolutely necessary, especially in large codebases with dozens of active developers. | 19:15 |
*** denis_makogon has quit IRC | 19:33 | |
*** denis_makogon_ is now known as denis_makogon | 19:33 | |
*** dmakogon_ has joined #openstack-trove | 19:33 | |
denis_makogon | amrith, yes, it happens when instance was provisioned with volume | 19:33 |
amrith | ok, I know the problem, will send you info. | 19:34 |
amrith | I have a fix if you want me to submit it | 19:34 |
amrith | feel free to assign bug to me. | 19:34 |
amrith | denis_makogon, ^^ | 19:34 |
denis_makogon | amrith, of course, feel free to fix it | 19:34 |
amrith | ok, will reassign bug to myself if that's OK with you. thx | 19:35 |
amrith | pl configm | 19:35 |
amrith | confirm | 19:35 |
amrith | thx | 19:35 |
denis_makogon | amrith, i guess that the simplest fix is to extend exec with appropriate attribute 'check_exit_code' for processutils | 19:35 |
denis_makogon | amrith, i'm fine that you taking it | 19:35 |
amrith | thanks, will send you code for review | 19:35 |
denis_makogon | amrith, how do you plan to fix it? | 19:35 |
amrith | let me get you a link, one second | 19:36 |
denis_makogon | amrith, ok | 19:37 |
denis_makogon | amrith, tomorrow i'll submit new patch for cassandra backup/restore, take a look at it when you'll have time | 19:37 |
amrith | ok, thanks | 19:37 |
amrith | so in datastore/cassandra/manager.py there is a call to device.migrate_data() | 19:38 |
amrith | at the point when this happens, cassandra is up and running | 19:38 |
amrith | this is not good | 19:38 |
amrith | so after selc.app.install_if_needed(packages) | 19:38 |
amrith | and before attempting to migrate the data | 19:38 |
amrith | the database should be stopped | 19:38 |
amrith | that's it | 19:38 |
denis_makogon | amcrn, it'll increase time for provisioning | 19:39 |
denis_makogon | amcrn, and will set datastore to SHUTDOWN state | 19:39 |
denis_makogon | amcrn, sorry =) | 19:39 |
*** amcrn is now known as ghost_of_amcrn | 19:39 | |
ghost_of_amcrn | ;) | 19:39 |
denis_makogon | amrith, so, it's not quite good, i think | 19:39 |
amrith | no, no, speak with ghost_of_amcrn ;) | 19:39 |
ghost_of_amcrn | no worries denis_makogon :) | 19:39 |
amrith | take a look at the code once I submit | 19:40 |
denis_makogon | amrith, there's a fix for cassandra status definition, https://review.openstack.org/#/c/99424/3, so i think you should try your code with it | 19:41 |
denis_makogon | amrith, why exit code extension doesn't work for you? | 19:42 |
amrith | because that's not a fix | 19:43 |
denis_makogon | amrith, since rsync remembers temporary SST files | 19:43 |
denis_makogon | amrith, why is that? | 19:43 |
denis_makogon | amrith, according to tons of topics related to rsync - exit code 24 is also valid | 19:44 |
amrith | because the problem is that you are attempting to rsync a filesystem while it is being changed. | 19:44 |
amrith | and rsync is not atomic | 19:44 |
amrith | in the case of the topic you found, that may have been acceptable | 19:44 |
amrith | I will put details in the bug and in the commit message, feel free to review and provide input. | 19:45 |
denis_makogon | amrith, actually i'm not happy with the way how does datastore application and status works, since guest tries to define status of datastore when packages are not even installed | 19:46 |
denis_makogon | amrith, so, that's why possibly, cassandra instance will be marked as SHUTDOWN until everything will be ready (FS migrations, restoring, etc.) | 19:47 |
denis_makogon | amrith, what do you think? | 19:48 |
amrith | What do I think about what? that you don't like something (your first comment) or why cassandra may be marked SHUTDOWN. | 19:50 |
amrith | About the latter, I don't know | 19:50 |
amrith | maybe it will | 19:50 |
amrith | maybe it won't | 19:50 |
amrith | I don't know for sure | 19:50 |
amrith | but, looking at the code | 19:50 |
amrith | mongodb and mysql already do this (what I'm suggesting) | 19:50 |
amrith | and redis doesn't appear to have this notion at all | 19:51 |
amrith | so, let me make the change and then you can comment | 19:51 |
amrith | ok? | 19:51 |
denis_makogon | amrith, ok | 19:51 |
denis_makogon | i wonder if it's possible to split up deployment process with status definition | 19:52 |
denis_makogon | so, guest datastore application will do deployment first, then it'll start to define actual status | 19:52 |
denis_makogon | prepare call can/might be splitted into two different parts | 19:53 |
denis_makogon | something like guest_api().deploy(...) and only then call prepare | 19:54 |
*** michael-yu has quit IRC | 19:54 | |
*** yidclare has joined #openstack-trove | 20:04 | |
ghost_of_amcrn | grapex_ esp: regarding "Partially implements guest agent upgrade strategy" (i.e. https://review.openstack.org/#/c/85225/), did we consider baking the version into metadata and/or a file within the package itself? this would avoid the necessity in passing the instance_version in the payload. | 20:07 |
*** ghost_of_amcrn is now known as amcrn | 20:07 | |
*** boden has quit IRC | 20:10 | |
esp | amcrn: that’s probably a good idea. we can totally drop the instance version from the payload | 20:13 |
esp | amcrn: one of the things grapex_ pointed out was that we should allow for alternative ways to retrieve the version within trove | 20:13 |
grapex_ | ghost_of_amcrn esp: Yep- originally the implementation got it from pip | 20:14 |
esp | the reference imple in this patch uses package_resource | 20:14 |
esp | but I can see other projects use pbr | 20:14 |
grapex_ | In my experience relying on the packaging mechanism isn't as sure-fire as somehow baking it into the code you're deploying | 20:14 |
amcrn | esp: could we standardize on an idea like: whether it's pip or <whatever>, in the root of the package there must be a file called "version.txt" (or somewhere in the code as grapex suggests above) | 20:14 |
grapex_ | Though that's with Sneaky Pete which is a binary. Still I'd love it if baking it into the code itself was possible | 20:15 |
esp | amcrn + grapex_: yeah we can figure something out. not sure I will get to it any time soon though some maybe we can do a follow up if this patch is good enough. | 20:16 |
amcrn | grapex_: as an aside, i think the next iteration of your guest should be named Predictable Pete; Sneaky is somewhat derogatory. | 20:16 |
esp | I’m getting close on the oslo.messaging stuff | 20:16 |
amcrn | or Pleasant Pete | 20:16 |
grapex_ | amcrn: You can say that about a dozen more times | 20:17 |
esp | lol, yeah be called sneaky doesn’t really build trust | 20:17 |
amcrn | esp: thing is, i'm not sure we can do that in another patch, because it'd be considered a breaking change to reject instance_version | 20:17 |
grapex_ | amcrn: Its one of the worst names for anything ever | 20:17 |
grapex_ | hub_cap named it after a bottle of beer in a paper bag | 20:18 |
*** rueben has joined #openstack-trove | 20:18 | |
grapex_ | which is kind of awesome, but nobody knows that | 20:18 |
esp | amcrn: k, i’ll try get through my tasks and circle back on the version.txt thing or embedded version “string” | 20:18 |
grapex_ | It wasn't until later when we tragically found out that the word "Sneaky" has a negative connotation in English | 20:18 |
amcrn | grapex_: do you think to ease some of esp's pain that we could merge it and break the contract by maybe having the upgrade feature turned off by default with a comment saying "we reserve the right to break this, it's a wip" | 20:19 |
amcrn | because i have a feeling this version-in-the-package thing might be a decent amount of work/thought | 20:19 |
esp | grapex_: at least it was a short name, it could have been “Puff the Magic Dragon” or something hideous like that | 20:20 |
amcrn | grapex_: lol, the backstory on that is hilarious | 20:20 |
grapex_ | amcrn: Sure | 20:20 |
grapex_ | Iff we do agree we can change it | 20:20 |
esp | grapex_: I’ll sign my name in Vipul’s blood | 20:20 |
grapex_ | amcrn: I really like that idea, I feel like too often we tie our own hands around here to the first draft of ideas or code | 20:20 |
grapex_ | esp: Ha ha! Good joke esp | 20:21 |
* grapex_ picks up phone to call FBI | 20:21 | |
amcrn | perfect-o, so once that abc stuff gets removed, it's good to go | 20:21 |
esp | grapex_: he uses my blood all the time.. | 20:21 |
amcrn | esp: is that how vipul gains his powers? | 20:21 |
grapex_ | esp: It's good to know you two are close. | 20:21 |
esp | amcrn: I like to think so | 20:21 |
* amcrn calls up WB to kick-start a new series | 20:22 | |
* esp dreams up an episode of Buffy the Vampire slayer feature esp and vipul | 20:24 | |
grapex_ | amcrn: Finally a show that combines pale hipster vampires with pale hipster software developers | 20:24 |
esp | lol | 20:25 |
grapex_ | The product managers should be werewolves | 20:25 |
amcrn | Person A: "I want to suck your blood!"......... Person B: "VC Firm XYZ already did that in our last round of funding!" <Insert Laugh Track> | 20:25 |
grapex_ | I guess upper management would be demons or something | 20:25 |
openstackgerrit | A change was merged to openstack/trove: Imported Translations from Transifex https://review.openstack.org/105070 | 20:25 |
vipul | haha natural enemies! | 20:26 |
grapex_ | amcrn: lol! | 20:26 |
esp | ooh, our product dude does have were wolve like eye brows | 20:26 |
amcrn | lol | 20:26 |
grapex_ | esp: lol | 20:26 |
grapex_ | I know his pain | 20:26 |
esp | haha | 20:26 |
esp | I would send a pic but I don’t want to start us down that road | 20:27 |
grapex_ | One time I saw Timothy Dalton in public and he yelled out "what's up Bert!" | 20:27 |
openstackgerrit | Peter Stachowski proposed a change to openstack/trove: Fixed '--version' for trove processes/utilities https://review.openstack.org/105266 | 20:28 |
*** michael-yu has joined #openstack-trove | 20:28 | |
denis_makogon | amrith, ping | 20:41 |
denis_makogon | amrith, do you really think that your comments are real reason for -1? https://review.openstack.org/#/c/97510/13 | 20:42 |
*** rueben has quit IRC | 20:43 | |
denis_makogon | amrith, there's no difference (only 9 sec), so, it's like whishlist things, so, are there any significant reasons to hold this patchset? | 20:45 |
*** denis_makogon has quit IRC | 20:47 | |
*** miqui has quit IRC | 20:49 | |
*** juantwo has quit IRC | 21:00 | |
*** rueben has joined #openstack-trove | 21:02 | |
openstackgerrit | A change was merged to openstack/trove: Add guestagent API calls for replication https://review.openstack.org/91904 | 21:05 |
*** flaper87 is now known as flaper87|afk | 21:17 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Updates RPC API to use oslo.messaging https://review.openstack.org/94484 | 21:23 |
*** sgotliv has quit IRC | 21:23 | |
*** radez is now known as radez_g0n3 | 21:26 | |
*** karimb has joined #openstack-trove | 21:30 | |
esp | SlickNik: ping | 21:30 |
SlickNik | esp: what's up? | 21:31 |
esp | SlickNik: hey dude, was wondering if you prefer a separate bp for trove-int regarding the oslo work | 21:33 |
esp | I need to add oslo.messaging to guest agent in trove-int | 21:33 |
esp | https://blueprints.launchpad.net/trove/+spec/rpc-versioning - that’s the one for trove | 21:35 |
SlickNik | esp: Just use the same BP | 21:35 |
SlickNik | (in the patchset you submit for the change to trove-integration) | 21:36 |
esp | thx SlickNik | 21:36 |
SlickNik | np, that should simplify things. | 21:36 |
*** jasond` has quit IRC | 21:36 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove-integration: Add oslo.messaging to guestagent image https://review.openstack.org/105282 | 21:39 |
*** michael-yu has quit IRC | 21:43 | |
*** shayneburgess has left #openstack-trove | 21:56 | |
*** michael-yu has joined #openstack-trove | 22:00 | |
*** rueben has quit IRC | 22:11 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Updates RPC API to use oslo.messaging https://review.openstack.org/94484 | 22:15 |
*** robertmyers has quit IRC | 22:16 | |
*** yidclare has quit IRC | 22:18 | |
*** yidclare has joined #openstack-trove | 22:19 | |
*** juantwo has joined #openstack-trove | 22:24 | |
*** karimb has quit IRC | 22:24 | |
*** juantwo has quit IRC | 22:30 | |
*** juantwo has joined #openstack-trove | 22:31 | |
*** yidclare has quit IRC | 22:32 | |
*** yidclare has joined #openstack-trove | 22:32 | |
*** yidclare has quit IRC | 22:33 | |
*** thedodd has quit IRC | 22:38 | |
openstackgerrit | Simon Chang proposed a change to openstack/trove: Adjusted audit logging for trove.instance module https://review.openstack.org/105294 | 22:39 |
*** demorris has quit IRC | 22:51 | |
*** mattgriffin has quit IRC | 23:00 | |
*** tvoran has quit IRC | 23:00 | |
*** grapex_ has quit IRC | 23:18 | |
amrith | dmakogon_, you there? | 23:39 |
amrith | denis, you asked about why I -1'ed https://review.openstack.org/#/c/97510/13 | 23:48 |
amrith | Currently, int-tests runs for about <> minutes. Adding another 18s to it may appear insignificant but realize that this is 18s for each person who runs int-tests, 18s on each iteration through gate and so on. It may appear like an insignificant amount of time but if each test just added a second here and a second there, pretty soon you are seeing a significant increase in the time for int-tests as a whole. | 23:48 |
amrith | Second, in an earlier version of the code you had 20s and I asked why. You reduced it to 1s. Now you've increased it to 10s. What I'd like to know is this; if someone tells me that I have to wait an extra 18s each time I run int-tests, I'd like to know that it is for a good reason. If you were, say, waiting 10s and then checking to make sure that the delta between the timestamps was 10s, that's one thing. But, we're just | 23:48 |
amrith | sitting there for 10s for no good reason. | 23:48 |
amrith | So, maybe you think this is a wishlist, that's fine. But is there a reason for the 10s; that's the question. Why not 1? | 23:48 |
*** michael-yu has quit IRC | 23:55 | |
*** michael-yu has joined #openstack-trove | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!