| *** jeraldv has quit IRC | 00:52 | |
| *** nosnos has joined #openstack-trove | 01:49 | |
| *** nosnos has quit IRC | 02:09 | |
| *** georgelorch has quit IRC | 02:20 | |
| *** georgelorch has joined #openstack-trove | 02:21 | |
| *** haomaiw__ has quit IRC | 02:27 | |
| *** haomaiwa_ has joined #openstack-trove | 02:27 | |
| *** haomaiw__ has joined #openstack-trove | 02:42 | |
| *** haomaiwa_ has quit IRC | 02:44 | |
| *** ramishra has joined #openstack-trove | 03:07 | |
| *** eghobo has joined #openstack-trove | 04:04 | |
| *** haomaiw__ has quit IRC | 04:14 | |
| *** haomaiwa_ has joined #openstack-trove | 04:14 | |
| *** eghobo has quit IRC | 04:18 | |
| *** eghobo has joined #openstack-trove | 04:19 | |
| *** robertmyers has quit IRC | 04:21 | |
| *** nosnos has joined #openstack-trove | 04:26 | |
| *** haomaiw__ has joined #openstack-trove | 04:30 | |
| *** haomaiwa_ has quit IRC | 04:32 | |
| *** eghobo has quit IRC | 04:51 | |
| *** juantwo has quit IRC | 04:55 | |
| *** k4n0 has joined #openstack-trove | 05:13 | |
| *** eghobo has joined #openstack-trove | 05:28 | |
| *** haomaiw__ has quit IRC | 05:41 | |
| *** haomaiwang has joined #openstack-trove | 05:41 | |
| *** georgelorch has quit IRC | 05:44 | |
| *** georgelorch has joined #openstack-trove | 05:46 | |
| *** haomaiw__ has joined #openstack-trove | 05:47 | |
| *** flaper87|afk is now known as flaper87 | 05:47 | |
| *** haomaiwang has quit IRC | 05:51 | |
| *** ramishra has quit IRC | 06:03 | |
| *** nosnos has quit IRC | 06:20 | |
| *** robertmyers has joined #openstack-trove | 06:22 | |
| *** ramishra has joined #openstack-trove | 06:26 | |
| *** robertmyers has quit IRC | 06:27 | |
| *** georgelorch2 has joined #openstack-trove | 06:31 | |
| *** georgelorch has quit IRC | 06:32 | |
| *** eguz has joined #openstack-trove | 07:01 | |
| *** eguz has quit IRC | 07:03 | |
| *** haomaiw__ has quit IRC | 07:03 | |
| *** haomaiwang has joined #openstack-trove | 07:04 | |
| *** eghobo has quit IRC | 07:05 | |
| *** mariusv_ is now known as mariusv | 07:07 | |
| *** mat-lowery_ has quit IRC | 07:08 | |
| *** mat-lowery has joined #openstack-trove | 07:09 | |
| *** georgelorch has joined #openstack-trove | 07:16 | |
| *** georgelorch2 has quit IRC | 07:17 | |
| openstackgerrit | A change was merged to openstack/trove: Fixed '--version' for trove processes/utilities https://review.openstack.org/105266 | 08:03 |
|---|---|---|
| *** haomai___ has joined #openstack-trove | 08:23 | |
| *** robertmyers has joined #openstack-trove | 08:23 | |
| *** haomaiwang has quit IRC | 08:27 | |
| *** robertmyers has quit IRC | 08:27 | |
| *** karimb has joined #openstack-trove | 08:42 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add support for a neutron-based install https://review.openstack.org/78123 | 08:56 |
| *** ramishra has quit IRC | 08:58 | |
| *** Longgeek has joined #openstack-trove | 09:03 | |
| *** ramishra has joined #openstack-trove | 09:06 | |
| *** haomai___ has quit IRC | 09:08 | |
| *** haomaiwang has joined #openstack-trove | 09:08 | |
| *** haomaiw__ has joined #openstack-trove | 09:09 | |
| *** haomaiwang has quit IRC | 09:13 | |
| *** haomaiwa_ has joined #openstack-trove | 09:18 | |
| *** haomaiwa_ has quit IRC | 09:19 | |
| *** haomaiw__ has quit IRC | 09:19 | |
| *** haomaiwa_ has joined #openstack-trove | 09:19 | |
| openstackgerrit | A change was merged to openstack/trove: Add instance IP to /instances https://review.openstack.org/105632 | 09:35 |
| *** ramishra has quit IRC | 09:43 | |
| *** ramishra has joined #openstack-trove | 09:45 | |
| *** mariusv has quit IRC | 09:49 | |
| *** mariusv has joined #openstack-trove | 09:49 | |
| *** k4n0 has quit IRC | 09:57 | |
| *** setho has quit IRC | 09:58 | |
| *** Longgeek has quit IRC | 10:00 | |
| *** Longgeek has joined #openstack-trove | 10:03 | |
| *** k4n0 has joined #openstack-trove | 10:10 | |
| *** ramishra has quit IRC | 10:14 | |
| openstackgerrit | A change was merged to openstack/trove: Stop cassandra during configuration and volume migration https://review.openstack.org/106127 | 10:20 |
| *** ramishra has joined #openstack-trove | 10:20 | |
| *** haomaiw__ has joined #openstack-trove | 10:23 | |
| *** haomaiwa_ has quit IRC | 10:25 | |
| *** k4n0 has quit IRC | 10:35 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Fixes redundant get call in a few places https://review.openstack.org/87038 | 10:42 |
| openstackgerrit | amrith proposed a change to openstack/trove: Move usage_timeout out of guest options https://review.openstack.org/87040 | 10:53 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Fix incremental backups feature validation https://review.openstack.org/106065 | 10:57 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Fix parent backup state validation https://review.openstack.org/106050 | 10:57 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted https://review.openstack.org/102838 | 10:57 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occures https://review.openstack.org/102262 | 10:57 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Fix backup state check while restoring an instance https://review.openstack.org/106042 | 10:57 |
| *** Longgeek has quit IRC | 11:05 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Removal of uneeded guest mount_point from taskmgr https://review.openstack.org/86808 | 11:24 |
| *** Longgeek has joined #openstack-trove | 11:36 | |
| *** Longgeek has quit IRC | 11:42 | |
| *** juantwo has joined #openstack-trove | 12:08 | |
| *** Longgeek has joined #openstack-trove | 12:08 | |
| *** juantwo has quit IRC | 12:10 | |
| *** juantwo has joined #openstack-trove | 12:11 | |
| *** Longgeek has quit IRC | 12:17 | |
| *** radez_g0n3 is now known as radez | 12:22 | |
| *** achampion has quit IRC | 12:32 | |
| *** pdmars has joined #openstack-trove | 12:33 | |
| *** kevinconway has joined #openstack-trove | 12:35 | |
| *** pdmars has quit IRC | 12:38 | |
| *** pdmars has joined #openstack-trove | 12:39 | |
| *** ramishra has quit IRC | 12:39 | |
| *** Longgeek has joined #openstack-trove | 12:53 | |
| *** miqui has joined #openstack-trove | 13:01 | |
| *** Longgeek has quit IRC | 13:07 | |
| *** Longgeek has joined #openstack-trove | 13:07 | |
| *** ramishra has joined #openstack-trove | 13:08 | |
| *** Longgeek has quit IRC | 13:09 | |
| *** Longgeek has joined #openstack-trove | 13:13 | |
| *** tvoran has joined #openstack-trove | 13:19 | |
| *** fifieldt has quit IRC | 13:45 | |
| *** jcru has joined #openstack-trove | 13:52 | |
| *** robertmyers has joined #openstack-trove | 13:55 | |
| *** grapex_ has joined #openstack-trove | 14:04 | |
| *** jcru has quit IRC | 14:25 | |
| *** jcru has joined #openstack-trove | 14:26 | |
| *** Barker has joined #openstack-trove | 14:39 | |
| *** Longgeek has quit IRC | 14:45 | |
| *** robertmy_ has joined #openstack-trove | 14:45 | |
| *** robertmy_ has quit IRC | 14:51 | |
| *** thedodd has joined #openstack-trove | 14:54 | |
| *** grapex_ has quit IRC | 14:55 | |
| *** grapex has joined #openstack-trove | 14:55 | |
| glucas | SlickNik, vipul, since you reviewed earlier patch sets for these: FYI that https://review.openstack.org/#/c/100381 and https://review.openstack.org/#/c/102423/ depend on each other for tests to pass. I suspect they won't show up on dashboards, since the reddwarf tests fail. | 14:58 |
| *** johnma has joined #openstack-trove | 15:02 | |
| *** edmund has joined #openstack-trove | 15:02 | |
| *** rueben has joined #openstack-trove | 15:03 | |
| *** rueben has quit IRC | 15:07 | |
| openstackgerrit | A change was merged to openstack/trove: Remove setuptools_git requirement https://review.openstack.org/106479 | 15:08 |
| *** grapex_ has joined #openstack-trove | 15:20 | |
| denis_makogon | glucas, ping | 15:21 |
| denis_makogon | glucas, one question about reddwarf patch, have you tried to mention only conf dir ? I suppose it should work too if you do next: "exec su -c "/home/GUEST_USERNAME/trove/contrib/trove-guestagent --config-dir=/etc/trove/conf.d" | 15:23 |
| *** ViswaV has joined #openstack-trove | 15:23 | |
| denis_makogon | glucas, seems like oslo.config will recursively load all files that are placed under --conf-dor=${CONF_PATH} | 15:24 |
| denis_makogon | *--conf-dir | 15:24 |
| *** ViswaV_ has joined #openstack-trove | 15:24 | |
| glucas | denis_makogon: Yeah, I had that thought too -- but it doesn't work for me. The guest_info needs to be read first and specifying the dir doesn't guarantee any specific order, from what I saw. | 15:24 |
| *** grapex has quit IRC | 15:24 | |
| denis_makogon | glucas, what if guest_info will be injected as guest_info.config ? | 15:25 |
| glucas | denis_makogon: Hm, I can experiment with it. I belive the guest_info is read, it's just that the trove-guestagent.conf is read first. | 15:26 |
| denis_makogon | glucas, i'm looking at trove/common/cfg.py and digging into parse_args method | 15:27 |
| denis_makogon | glucas, def find_config_files(project=None, prog=None, extension='.conf'): | 15:27 |
| *** ViswaV has quit IRC | 15:28 | |
| *** grapex has joined #openstack-trove | 15:28 | |
| denis_makogon | glucas, i was right, config files should have extension *.conf | 15:28 |
| glucas | denis_makogon: ahh... perhaps I misinterpreted the issue I was seeing before then! Let me try that out. | 15:28 |
| denis_makogon | glucas, let me give you a link or at least gist =) | 15:28 |
| denis_makogon | glucas, https://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L509-L544 | 15:29 |
| glucas | denis_makogon: ok, thanks | 15:29 |
| glucas | denis_makogon: So will test this out to confirm everything is OK and will update the patch set -- I agree it is cleaner if the init script just specifies the dir. Thanks! | 15:30 |
| denis_makogon | glucas, np | 15:30 |
| *** grapex_ has quit IRC | 15:32 | |
| *** boden has joined #openstack-trove | 15:35 | |
| *** ViswaV_ has quit IRC | 15:40 | |
| cp16net | SlickNik: btw i just added a bp to the empty meeting today | 15:41 |
| boden | cp16net + SlickNik -- I'm adding something too | 15:41 |
| cp16net | boden: we might have been too late :-/ | 15:42 |
| *** rueben has joined #openstack-trove | 15:42 | |
| boden | cp16net -- understood... | 15:42 |
| *** ViswaV has joined #openstack-trove | 15:51 | |
| *** denis_makogon has quit IRC | 15:57 | |
| *** karimb has quit IRC | 15:59 | |
| *** eghobo has joined #openstack-trove | 16:00 | |
| *** Barker has quit IRC | 16:01 | |
| *** eghobo has quit IRC | 16:03 | |
| *** eghobo has joined #openstack-trove | 16:10 | |
| *** eghobo has quit IRC | 16:21 | |
| *** eghobo has joined #openstack-trove | 16:24 | |
| *** eghobo has quit IRC | 16:25 | |
| *** eghobo has joined #openstack-trove | 16:25 | |
| *** radez is now known as radez_g0n3 | 16:36 | |
| *** kevinconway has quit IRC | 16:44 | |
| *** kevinconway has joined #openstack-trove | 16:45 | |
| *** kevinconway has quit IRC | 16:50 | |
| *** Guest33108 is now known as bhunter71 | 16:56 | |
| johnma | Hello, We are planning on building a prototype to add support for a new datastore type and I need some help to understand how much work is involved. At this point I know that we need to write a guest agent specific to the datastore but apart from that can someone help me understand what else is required? Thank you | 17:05 |
| *** ViswaV_ has joined #openstack-trove | 17:08 | |
| *** ViswaV has quit IRC | 17:08 | |
| esmute | Hi johnma, you pretty much needs to create a manager that implements all the guestagent API. https://github.com/openstack/trove/blob/master/trove/guestagent/api.py | 17:17 |
| esmute | Take a look at how other datastore are implemented in https://github.com/openstack/trove/tree/master/trove/guestagent/datastore | 17:17 |
| esmute | That should give you some reference of how to get started | 17:18 |
| *** Barker has joined #openstack-trove | 17:18 | |
| *** yidclare has joined #openstack-trove | 17:19 | |
| amrith | esmute, johnma ... another approach is to look at the reviews for vertica and postgresql that are currently under way. | 17:19 |
| esp | johnma: yep, agree with esmute, you may want to look at the cfg.py and work form there | 17:19 |
| johnma | awesome. Thank you esmute. I will go through these links | 17:19 |
| esp | *from | 17:19 |
| *** radez_g0n3 is now known as radez | 17:20 | |
| johnma | cool. Thanks amrith, esp and esmute. Does anyone have a rough idea of how long it might take to enable a datastore type. For the prototype, lets say at a minimum to enable users to create instances and some basic tasks like that not the full features list | 17:21 |
| johnma | I am trying to size a bare minimum feature list for prototyping purposes | 17:22 |
| esp | johnma: I think that depends a little on your datastore. if you pick one that has similarity to an existing implementation that *might* go quicker | 17:22 |
| johnma | this is to prototype DB2 to be specific | 17:23 |
| amrith | operative word 'might'. also depends on what capabilities you want to support in db2 | 17:23 |
| esp | johnma: gotcha | 17:23 |
| esp | amrith: +1 | 17:23 |
| esmute | johnma: Also, take a look at https://github.com/openstack/trove-integration/tree/master/scripts/files/elements. You would need to create an element to add your datastore to the image | 17:24 |
| esp | johnma: I was secretly hoping you were gonna say postgres :) | 17:24 |
| amrith | and then there's the work to make and support a guest image for your datastore | 17:24 |
| esmute | once your image is baked with your datastore install, you can start implementing the guest agent features. If you omit, backups and other bigger feature, your prototype should not take too long | 17:25 |
| amrith | johnma, there's more to it than meets the eye | 17:25 |
| SlickNik | cp16net / boden: I was going to have a meeting anyway, to check in with folks. So all is well. | 17:25 |
| johnma | right now we just want to go for the bare minimum. I would say create an instance, create users and maybe backup. I think whats more important is to be able to show how DB2 is integrated with Trove and how it works. | 17:26 |
| johnma | esmute: Sorry to disappoint :). Yeah, its that one DB2 unfortunately :) | 17:26 |
| *** ViswaV_ is now known as ViswaV | 17:27 | |
| esmute | i think you dissapointed esp. Not me. :P | 17:27 |
| johnma | oh yes esp for sure :) | 17:27 |
| esp | johnma: I would make a rough guess at somewhere between 4-8 weeks (so 6 weeks) but others may have a better feel for it. | 17:28 |
| esp | johnma: don’t worry my life is full of disappointments, I’m used to it ;) | 17:28 |
| johnma | esmute: I think thats what I am looking for in terms of the bigger features to implement. Understood that backups is a bug feature. So what are some of the easier features to implement | 17:29 |
| esmute | johnma: I would start with able to create a db2 instance, being able to access to it, and delete them. Once you get that working, you can do more things like create/list/delete users, db; and backup and restore | 17:32 |
| *** michael-yu has joined #openstack-trove | 17:32 | |
| johnma | sounds good esmute. Thanks alot . I appreciate it . This really helps | 17:33 |
| esmute | cool.. let us know how that goes. Feel free to ask us any questions or send us gist of your work | 17:35 |
| johnma | Thank you esp. I appreciate it :) | 17:37 |
| esp | np johnma | 17:39 |
| *** ramishra has quit IRC | 17:46 | |
| *** amcrn has joined #openstack-trove | 17:49 | |
| *** juantwo_ has joined #openstack-trove | 17:54 | |
| *** juantwo has quit IRC | 17:58 | |
| SlickNik | #startmeeting trove-bp-review | 18:00 |
| openstack | Meeting started Mon Jul 14 18:00:23 2014 UTC and is due to finish in 60 minutes. The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:00 |
| openstack | The meeting name has been set to 'trove_bp_review' | 18:00 |
| grapex | o/ | 18:00 |
| amcrn | o/ | 18:00 |
| dougshelley66 | o/ | 18:00 |
| boden | o/ | 18:00 |
| glucas | \o | 18:00 |
| amrith | o| | 18:00 |
| SlickNik | Agenda for the meeting at: | 18:01 |
| esmute | \o/ | 18:01 |
| SlickNik | #link https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting | 18:01 |
| tvoran | o/ | 18:01 |
| esp | o/ | 18:02 |
| vipul | o/ | 18:02 |
| schang | o/ | 18:02 |
| SlickNik | #topic New API call to get the default configuration values for a specific datastore version flavor without an instance | 18:03 |
| SlickNik | cp16net: around? | 18:03 |
| *** nehav1 has joined #openstack-trove | 18:03 | |
| cp16net | SlickNik: yeah | 18:04 |
| cp16net | i'm here | 18:04 |
| peterstac | o/ | 18:04 |
| * cp16net was off in lala land for a min :-P | 18:04 | |
| SlickNik | So I had a couple of questions. | 18:05 |
| grapex | Is that the place Loney Tunes characters go when they say "ooh la la!" | 18:05 |
| grapex | ? | 18:05 |
| cp16net | yeah so this was asked from some ui devs that wanted to present the defaults of a configuration that isnt attached to an instance | 18:05 |
| SlickNik | This is just a call to get the default config params per flavor, right — no tackling setting of defaults? | 18:05 |
| cp16net | the idea i have is to read the template based on flavor/datastore version and present it to the user | 18:06 |
| cp16net | SlickNik: so yeah just a simple GET call for these vaues | 18:07 |
| cp16net | values* | 18:07 |
| cp16net | any questions about the use case? | 18:08 |
| vipul | So i have 2 things about the proposal | 18:08 |
| vipul | 1. i don't agree with the URL -- why do you have flavor_id as part of the URL | 18:08 |
| vipul | 2. we call the defaults that ocme back on an instance 'parameters'.. should this be named similarly | 18:08 |
| vipul | i.e GET /instances/{instance_id}/parameters | 18:09 |
| cp16net | 1. so based on a template it could change per flavor size (memory settings) | 18:09 |
| cp16net | 2. i would agree with you on that. | 18:09 |
| grapex | cp16net vipul: regarding #1, would it be acceptable if it was in their but the path put flavor right after the dv_id? | 18:09 |
| vipul | so is there another way to specify flavor outside of the path? | 18:09 |
| grapex | So that would be /datastore/version/{dv_id}/{flavor_id}/parameters | 18:10 |
| vipul | grapex: that would be better.. configuration/{flavor_id} makes it seem like flavor_id should be the id of configuration | 18:10 |
| grapex | vipul: In many ways it is. Operators can already specify a configuration template using a flavor | 18:11 |
| grapex | What if in addition to that | 18:11 |
| cp16net | grapex: brings up a point that i noticed for some calls like this one | 18:11 |
| cp16net | we are not really following a RESTy call here | 18:11 |
| cp16net | its more like a shim to get the data we need | 18:11 |
| vipul | yea.. ideally it would be a filter via query string | 18:12 |
| cp16net | filters are just a pain in the arse with how they work today | 18:12 |
| grapex | vipul: I think there's some issues here though because an operator can create templates for each flavor. To me that means they deserve a complete REST path | 18:12 |
| amcrn | cp16net: i just added a filter for clustering; there's a bit of a trick to it, i can give you some pointers | 18:13 |
| vipul | somethign like /datastore/version/{dv_id}/parameters may return something generic.. but /datastore/version/{dv_id}/parameters?flavor_id=xxx woudl return something specific to that flavor | 18:13 |
| cp16net | amcrn: ok | 18:13 |
| grapex | vipul cp16net: So I'm curious why considering the pairing of a datastore version and a flavor in a rest url would be a bad thing. | 18:13 |
| *** annashen_ has joined #openstack-trove | 18:13 | |
| vipul | do configuration groups belong to datastore_version + flavor, or do they belong to datastore versions | 18:14 |
| cp16net | i dont think its a "bad thing" but just the relationship between the noun and ids dont match | 18:14 |
| grapex | vipul: They do both | 18:14 |
| cp16net | ds_version and instance | 18:14 |
| cp16net | rather and/or | 18:15 |
| grapex | cp16net: But you added code so an operator can uniquely identify a config via a ds_version and a flavor | 18:15 |
| cp16net | grapex: correct | 18:15 |
| vipul | the fact that you can get defaults per flavor doesn't necessarily mean that they are full on resources that a flavor owns | 18:15 |
| vipul | like cp16net said, the full on resource actually belongs to an instance + datastore | 18:16 |
| cp16net | #info https://github.com/openstack/trove/blob/master/trove/templates/mysql/config.template#L16 | 18:16 |
| cp16net | or i guess that shoul dhave been a link | 18:16 |
| cp16net | #link https://github.com/openstack/trove/blob/master/trove/templates/mysql/config.template#L16 | 18:16 |
| grapex | vipul: but we're not talking about instance + ds_version but the default templates which are grouped via ds_version and, optionally, flavors | 18:16 |
| cp16net | so this default template has a different key_buffer_size per flavor | 18:17 |
| cp16net | even tho the template is the "base" one | 18:17 |
| cp16net | so you still need a flavor | 18:17 |
| grapex | Ok- so let's go with the query parameter. If you don't specify it, what would you see for "key_buffer_size"? | 18:18 |
| esmute | what about /datastore/version/{dv_id}/configuration/flavor/{flavor_id}? It is a bit verbose.. but more resty | 18:18 |
| grapex | In the call to get defaults from the API, what would that look like if a flavor wasn't specified? | 18:18 |
| cp16net | an exception | 18:18 |
| *** radez is now known as radez_g0n3 | 18:18 | |
| cp16net | (i assume) | 18:19 |
| cp16net | robertmyers: might know better | 18:19 |
| grapex | Look at this: https://github.com/openstack/trove/blob/master/trove/common/template.py#L87 | 18:19 |
| SlickNik | So apart from figuring out the right URI for this, are folks good with the BP? | 18:19 |
| amcrn | cp16net: to go back to the purpose of this change, i'm not sure why this is necessary if the user can change the value after it's been deployed. if they know the available memory (via flavor), they can tweak the buffer_pool_size to their heart's content. | 18:19 |
| grapex | according to that logic, the three required parameters are the datastore version info, the flavor, and the server_id (which is just a unique id). So this command would need the first two as input and not the third | 18:20 |
| cp16net | amcrn: the idea is to show a user from a ui what the "default" is | 18:20 |
| cp16net | then they can tweak it all they want | 18:20 |
| amcrn | so, other than that being a nicety, can you explain why showing the default will change user behavior? | 18:20 |
| *** shakamunyi has joined #openstack-trove | 18:20 | |
| cp16net | think about it as fields you can change but the default is greyed out or something | 18:20 |
| amcrn | because it feels it will drive up capacity usage because they think they can't change the value post-deployment. | 18:21 |
| SlickNik | grapex / cp16net: Can these defaults just as easily be part of the documentation? | 18:21 |
| cp16net | amcrn: its really a niceity that was requested | 18:21 |
| grapex | cp16net: Is this so if someone changes their instance to some strange config values they can later view what the normal ones were | 18:21 |
| cp16net | SlickNik: they could not be generated automatically | 18:21 |
| cp16net | if they are tweaked in a template file | 18:21 |
| grapex | SlickNik: Sure, but these are values that might be tweaked more often that other deployment settings | 18:22 |
| cp16net | +1 to grapex comment as well | 18:22 |
| cp16net | the event of OH CRAP i screwed it up | 18:22 |
| cp16net | revert and hopfully someone can fix it on their own | 18:23 |
| amcrn | as a user, if see that configuration-parameter 'x' is defaulted to 'y' with a flavor, i'm going to naturally keep bumping the flavor until it meets my needs, unless the ui is very clear that i can change this configuration-parameters post-deployment. this situation might be good for deployers making money on larger flavors, but for internal deployments, it might be encouraging behavior that's unnecessary. | 18:23 |
| dougshelley66 | doesn't it also seem useful to know what values will be set if you don't have a config group or detach a config group? | 18:23 |
| amcrn | so in short, i'd have to see mocks to be sure whether this is a good idea from a ui-perspective. | 18:23 |
| grapex | amcrn: ah | 18:24 |
| amcrn | and my english is terrible this morning, apologies. | 18:24 |
| grapex | I don't think the intention is people look up what each flavor provides so much as, when they change config values on an instance in a UI, they can see what the default settings were | 18:24 |
| amcrn | grapex: oh, so this is more for a configuration-group view vs. Launch Instance modal? | 18:24 |
| grapex | amcrn: I think so. cp16net is that correct? | 18:25 |
| cp16net | yes this is for config-group | 18:25 |
| cp16net | because you can create a config group without an instance | 18:25 |
| amcrn | consider my concern squashed then, thanks for the clarification. | 18:25 |
| cp16net | ok cool thanks grapex for helping clarify | 18:26 |
| SlickNik | cp16net / grapex: But you can get the defaults from the instance if one is already created today, right? | 18:26 |
| cp16net | yes | 18:26 |
| SlickNik | I thought that this was for the scenario where an instance has *not* been created yet. | 18:26 |
| cp16net | yes | 18:26 |
| grapex | Hmm... that seems like overkill to me, as there will be two paths to get the same data. cp16net there's only one path shown in the wiki | 18:27 |
| cp16net | or maybe you dont want to create instance with 16GB just to find out what the memory settings are for mysql | 18:27 |
| cp16net | thats another use case | 18:27 |
| cp16net | grapex: the other path already exists | 18:27 |
| amcrn | given that deployers can change these templates, i'd agree that having an api to return the default parameter values makes sense. | 18:27 |
| cp16net | #link https://github.com/openstack/trove/blob/master/trove/common/api.py#L92 | 18:28 |
| grapex | cp16net: Oh, sorry. :( | 18:28 |
| cp16net | grapex: ^^ | 18:28 |
| nehav1 | yes thats correct this scenario is when no instance is tied to the configuration groups. This api call will allow users to see the defaults and the parameters that can be tweaked | 18:28 |
| vipul | yea, agree the use case seems valid.. | 18:28 |
| cp16net | ok so everyone agrees with the use cases | 18:28 |
| vipul | did we agree on URI ? sorry was away for a bit | 18:28 |
| cp16net | so the only issue we have is the URI | 18:29 |
| amcrn | => /{tenant_id}/datastores/versions/{version}/parameters?flavor_id=<x> and /{tenant_id}/datastores/versions/{version}/parameters/{name}?flavor_id=<x> looks good to me. | 18:29 |
| vipul | +1 to query string approach | 18:29 |
| glucas | sorry.. on the use case, do you really want to pick a flavor and see the values or do you want to see the formula? | 18:30 |
| cp16net | so 1 question... what happens when no query string is suppiled | 18:30 |
| grapex | So... I'm ok with the query string approach as I don't worship at the alter of REST. But I feel like I never got a good answer on what the result would look like if a flavor wasn't used. | 18:30 |
| vipul | i thik you can return the formula if there is no query string | 18:30 |
| SlickNik | glucas: What if there isn't a formula and it's hard coded per flavor? | 18:30 |
| grapex | vipul: As in return the non-interpolated jinja template values? | 18:30 |
| vipul | :) that's an option | 18:31 |
| grapex | Return "[!please use query string]" | 18:31 |
| glucas | SlickNik: Hm, OK. Didn't see that case in the example I was looking at. | 18:31 |
| amcrn | grapex: not sure i understand the question, because both of those routes exist today | 18:31 |
| SlickNik | Okay, I think we've spent some time on this already. | 18:31 |
| SlickNik | And need to move on. | 18:31 |
| cp16net | that could be gross | 18:31 |
| SlickNik | cp16net: I think all of us agree on the use-case. | 18:31 |
| SlickNik | And the requirements for the BP. | 18:32 |
| grapex | SlickNik: Ok. I'm satisfied either way so long as there's tests proving usage isn't crazy. | 18:32 |
| cp16net | because the template file *can* be made many different ways | 18:32 |
| cp16net | not just the formulas of the fields | 18:32 |
| SlickNik | So I think we're good approving it. I trust we can come up with the right URI as part of the follow-up, and code review. | 18:32 |
| SlickNik | Folks okay with that? | 18:32 |
| glucas | +1 | 18:33 |
| grapex | SlickNik: +1 | 18:33 |
| vipul | yep +1 | 18:33 |
| dougshelley66 | +1 | 18:33 |
| cp16net | +1 | 18:33 |
| amcrn | +1 | 18:33 |
| peterstac | +1 | 18:33 |
| boden | +1 | 18:33 |
| SlickNik | Okay, let's move on. | 18:33 |
| cp16net | thanks | 18:33 |
| SlickNik | #topic configurable db plugins | 18:33 |
| SlickNik | boden: I agree with your assessment on this one | 18:34 |
| grapex | So we're talking about dropping it? | 18:34 |
| boden | yes | 18:34 |
| SlickNik | #info (boden) Based on our previous discussion I propose we drop this BP as (a) no other projects expose this level of integration and (b) this couples consumers into an internal impl detail which is not guaranteed to be supported long term. | 18:34 |
| SlickNik | Anyone have anything to add for this one? | 18:35 |
| vipul | so is thre anything to review on this? | 18:35 |
| boden | vipul -- no code | 18:35 |
| dougshelley66 | does that mean we vote -1 :) | 18:35 |
| grapex | dougshelley66: lol | 18:35 |
| SlickNik | Nope, I think boden was just closing the loop. | 18:35 |
| SlickNik | Thanks boden. | 18:35 |
| SlickNik | #topic multiple API extension paths | 18:35 |
| cp16net | ok thanks for the follow up | 18:35 |
| SlickNik | #link https://blueprints.launchpad.net/trove/+spec/extensions-update | 18:35 |
| boden | prelude -- this one may need a flished out BP in wiki, just wanting to get some initial thoughts | 18:35 |
| boden | so right now the conf supports api_extensions_path to point to the API route extension classes | 18:36 |
| boden | but it only supports a single path -- where the trove extensions already exist... | 18:36 |
| boden | if as a consumer I want to add some custom extensions I have to copy them into the path where the trove extensions live... what I'm proposing is a comma list conf property to support multipel extension paths | 18:37 |
| boden | again -- I will write this up more formally if folks think this is the proper approach | 18:37 |
| grapex | I don't think there will be any dissension on this one. Btw, are we still importing files based on the physical file path or did that get fixed so its using true Python imports now? I can't remember. | 18:38 |
| SlickNik | Seems like a reasonable approach to me. Would like to see it fleshed out. | 18:38 |
| glucas | grapex: still using a file path I believe | 18:38 |
| vipul | how about if we're doing this.. we migrate to stevedore | 18:38 |
| SlickNik | grapex: I believe we're still using file paths, not python modules. | 18:38 |
| grapex | This Steve Dore is a popular guy | 18:39 |
| boden | SlickNik -- agreed... however do you agree this would be separate from the 'extensions update' BP? | 18:39 |
| cp16net | yeah i was waiting for that... | 18:39 |
| cp16net | :_P | 18:39 |
| vipul | haha yea.. he gets around | 18:39 |
| amcrn | i vote we use steveholt | 18:39 |
| grapex | amcrn: +1000 | 18:39 |
| grapex | Let's propose it for Oslo | 18:39 |
| SlickNik | lol | 18:39 |
| vipul | #link http://stevedore.readthedocs.org/en/latest/ | 18:40 |
| cp16net | i think we should have that as a separate task | 18:40 |
| grapex | SlickNik vipul: Saying this should be with Steve Dore is close to saying the extension thing *can't* be fixed unless it changes entirely to stevedore | 18:40 |
| vipul | it's the way most of the porjects manage extension | 18:40 |
| SlickNik | boden: I think it would be different from that. | 18:40 |
| *** miqui has quit IRC | 18:40 | |
| *** mattgriffin has joined #openstack-trove | 18:40 | |
| boden | SlickNik -- I will write it up as a separate BP + wiki then | 18:40 |
| SlickNik | boden: but a lot of our extensions code is taken from old nova code, that needs a refresh. | 18:40 |
| cp16net | boden: nice | 18:40 |
| vipul | grapex: yea maybe it's too much to require that.. it is a suggestion.. if it's simple to migrate to.. we should do it | 18:41 |
| grapex | I agree we should use it. Although the next thing I think is "great, this will screw up our deployments the moment it lands..." How easy would it be to add stevedore and keep backwards compatibility to avoid that? | 18:41 |
| vipul | i'm fine with doing it as a separete thing too | 18:41 |
| amcrn | i'd agree to keep the two separate | 18:41 |
| boden | ok | 18:41 |
| cp16net | so i think its a quick win to change the option to a list_opt to support multiple paths for extentions | 18:41 |
| vipul | the more we specialize our extensions, the harder it becomes to migrate off | 18:41 |
| cp16net | ... althoughi really hate the list_opt | 18:41 |
| grapex | I want to move to stevedore too btw, I know robertmyers would be happy. :) | 18:41 |
| SlickNik | boden: Can you look into doing this vs. updating the extensions to use stevedore to see how much more work it is, as you flesh out the bp? | 18:42 |
| boden | SlickNik -- can / wikk do | 18:42 |
| boden | *will* | 18:43 |
| SlickNik | boden: Then based on that we can decide if we want to tackle one vs. both, and the order of things. | 18:43 |
| SlickNik | boden: Thanks! | 18:43 |
| *** rueben has quit IRC | 18:44 | |
| SlickNik | #topic Open Discussion | 18:44 |
| SlickNik | did folks have anything BP related? | 18:44 |
| SlickNik | Looks like not. | 18:45 |
| SlickNik | #endmeeting | 18:46 |
| openstack | Meeting ended Mon Jul 14 18:46:07 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:46 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-14-18.00.html | 18:46 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-14-18.00.txt | 18:46 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-14-18.00.log.html | 18:46 |
| SlickNik | Thanks all! | 18:46 |
| amcrn | thanks | 18:46 |
| cp16net | thanks :) | 18:46 |
| vipul | thx | 18:46 |
| boden | SlickNik -- so regarding that BP we will drop -- shall I move it to " | 18:47 |
| *** miqui has joined #openstack-trove | 18:47 | |
| *** miqui has quit IRC | 18:48 | |
| *** miqui has joined #openstack-trove | 18:48 | |
| cp16net | boden: yes move it to blank | 18:48 |
| cp16net | lol | 18:48 |
| *** miqui has quit IRC | 18:48 | |
| *** miqui has joined #openstack-trove | 18:49 | |
| SlickNik | boden: I'm taking care of it as we speak. Marked it as "Obsolete" | 18:49 |
| cp16net | i think its closed or something | 18:49 |
| SlickNik | cp16net: I just did. | 18:49 |
| cp16net | ok :) | 18:49 |
| *** rwsu has joined #openstack-trove | 18:51 | |
| openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/106843 | 18:56 |
| *** amcrn has quit IRC | 19:00 | |
| *** nehav has joined #openstack-trove | 19:01 | |
| *** thedodd has quit IRC | 19:01 | |
| *** radez_g0n3 is now known as radez | 19:03 | |
| *** nehav1 has quit IRC | 19:03 | |
| *** miqui has quit IRC | 19:18 | |
| *** michael-yu has quit IRC | 19:22 | |
| *** michael-yu has joined #openstack-trove | 19:23 | |
| openstackgerrit | Simon Chang proposed a change to openstack/trove: Adjusted audit logging for trove.instance module https://review.openstack.org/105294 | 19:23 |
| *** achampion has joined #openstack-trove | 19:23 | |
| *** amcrn has joined #openstack-trove | 19:31 | |
| *** denis_makogon has joined #openstack-trove | 19:33 | |
| *** michael-yu has quit IRC | 19:36 | |
| *** cweid has quit IRC | 19:39 | |
| *** cweid has joined #openstack-trove | 19:46 | |
| SlickNik | denis_makogon: around? | 20:04 |
| denis_makogon | SlickNik, yes | 20:05 |
| SlickNik | denis_makogon: Just wanted to check with you on the status of https://blueprints.launchpad.net/trove/+spec/dbinstance-log | 20:05 |
| SlickNik | denis_makogon: dougshelley66 mentioned that schang had some cycles to work on fleshing out the BP / implementation in case you weren't actively looking at it. | 20:06 |
| denis_makogon | SlickNik, i was waiting for approvement from cores, that's why i didn't started it yet | 20:07 |
| SlickNik | denis_makogon: If I recall correctly, the design spec needed changes based on the comments from the review. | 20:08 |
| denis_makogon | SlickNik, as i can recall, i've addressed all comments that were raised(i've co-worked with vipul and he said that it's ok) | 20:10 |
| denis_makogon | SlickNik, but, as i said, it was long time ago, i guess, i'd have to request spec re-reviewing from cores | 20:11 |
| SlickNik | denis_makogon: So from the sound of it, we are ready to bring it up at the next BP meeting? | 20:12 |
| denis_makogon | SlickNik, yes, we did it, twice, and at the last time, it was almost-there, and right after the meeting i asked vipul to help me with fixing/addressing all comments, and we did it | 20:13 |
| *** boden has quit IRC | 20:13 | |
| vipul | +1 i think we should review it next week -- i recall denis_makogon fixed a lot of the issues we had | 20:13 |
| SlickNik | Okay, can you add it to the agenda for next monday's meeting please? I'll go through it, and if things look good, we can run with it. | 20:14 |
| denis_makogon | SlickNik, vipul i will put it into agenda | 20:14 |
| SlickNik | Thanks denis_makogon! | 20:14 |
| *** michael-yu has joined #openstack-trove | 20:17 | |
| glucas | denis_makogon: I added a comment to https://review.openstack.org/#/c/100381/ about the guest_info change. There is a backward-compatibility concern, I think. | 20:22 |
| *** miqui has joined #openstack-trove | 20:22 | |
| glucas | if we think there is a requirement to be able to use existing trove guest images without modifying upstart/init scripts | 20:22 |
| denis_makogon | guys, can you do me a favor and take a look at https://blueprints.launchpad.net/trove/+spec/incremental-backup-sequence-force-delete untill next week and leave comments at whiteboard | 20:23 |
| denis_makogon | glucas, if that so, we can do multiple injection, guest_info and guest_info.config | 20:23 |
| denis_makogon | glucas, those files would be the same and upstart scripts would be backward compatible | 20:24 |
| denis_makogon | glucas, just need to mention why do we do file duplication, i suppose | 20:24 |
| denis_makogon | SlickNik, vipul done, i updated agenda | 20:25 |
| glucas | denis_makogon: hm. So existing images would still work and read guest_info... but at least new images could use only --config-dir. That seems OK. | 20:25 |
| glucas | do we have any mechanism for deprecating things... Would be good to stop duplicating the file in K release, for example. | 20:26 |
| denis_makogon | glucas, if it would not break any existing deployments than it works for me too | 20:26 |
| denis_makogon | glucas, good question, i guess we don't have it at all, since we're too young to deprecate something =) | 20:27 |
| glucas | denis_makogon: yeah. If we go with duplicating the guest_info I could put in a bug to remove the duplication in some future release, at least. | 20:30 |
| denis_makogon | glucas, don't forget to add bug serial number inside comments near the code | 20:30 |
| *** nehav3 has joined #openstack-trove | 20:32 | |
| *** achampion has quit IRC | 20:32 | |
| *** nehav has quit IRC | 20:34 | |
| *** amcrn has quit IRC | 20:39 | |
| denis_makogon | guys, i've got question, have anyone tried to use HTTPS for Trove ? | 20:40 |
| denis_makogon | another question, is it ok, if user A can see/use instances/backups that was provisioned by user B? All users belongs to the same tenant C | 20:41 |
| *** radez is now known as radez_g0n3 | 20:43 | |
| denis_makogon | shouldn't we pin resources to certain users that lives in certain tenant? | 20:43 |
| SlickNik | denis_makogon: All resources are owned per-tenant, so if the two users belong to the same tenant C, they will be able to view/use common resources belonging to tenant C (by design). | 20:43 |
| denis_makogon | SlickNik, ok. | 20:44 |
| denis_makogon | SlickNik, and what about HTTPS ? | 20:45 |
| *** edmund has quit IRC | 20:46 | |
| SlickNik | denis_makogon: I believe there's a way of switching the trove-api to use HTTPS if you configure the correct oslo params, but I haven't tried it out myself. | 20:52 |
| *** yidclare has left #openstack-trove | 20:53 | |
| denis_makogon | SlickNik, will take a look at, also, all services that Trove uses are supporting HTTPS, but there's no way to enable HTTPS for them inside Trove itself | 20:55 |
| *** juantwo_ has quit IRC | 20:58 | |
| *** arborism has joined #openstack-trove | 20:59 | |
| *** arborism is now known as amcrn | 20:59 | |
| *** nehav3 has quit IRC | 21:05 | |
| *** pdmars has quit IRC | 21:10 | |
| *** Barker has quit IRC | 21:27 | |
| *** openstackgerrit has quit IRC | 21:31 | |
| *** openstackgerrit has joined #openstack-trove | 21:31 | |
| *** nehav has joined #openstack-trove | 21:37 | |
| *** juantwo has joined #openstack-trove | 21:39 | |
| *** juantwo has quit IRC | 21:40 | |
| *** shakamunyi has quit IRC | 21:40 | |
| *** juantwo has joined #openstack-trove | 21:40 | |
| *** annashen_ has quit IRC | 22:00 | |
| *** jcru has quit IRC | 22:06 | |
| *** nehav has quit IRC | 22:11 | |
| *** denis_makogon has quit IRC | 22:11 | |
| *** flaper87 is now known as flaper87|afk | 22:20 | |
| *** robertmyers has quit IRC | 22:24 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Mysql guest agent functionality for replication https://review.openstack.org/98147 | 22:35 |
| *** tvoran has quit IRC | 22:43 | |
| *** grapex has quit IRC | 22:53 | |
| *** grapex has joined #openstack-trove | 22:54 | |
| *** annashen_ has joined #openstack-trove | 22:58 | |
| *** grapex has quit IRC | 22:59 | |
| *** mattgriffin has quit IRC | 23:03 | |
| *** Barker has joined #openstack-trove | 23:34 | |
| *** nosnos has joined #openstack-trove | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!