Monday, 2014-07-21

*** peopleme1ge has joined #openstack-trove00:11
*** peoplemerge has quit IRC00:12
*** demorris has joined #openstack-trove00:40
*** juantwo has quit IRC01:16
*** demorris has quit IRC01:24
*** robertmyers has joined #openstack-trove02:34
*** demorris has joined #openstack-trove03:13
*** eghobo has joined #openstack-trove03:17
*** robertmyers has quit IRC03:47
*** demorris has quit IRC03:52
*** eghobo has quit IRC04:16
*** ramishra has joined #openstack-trove04:16
*** eghobo has joined #openstack-trove04:17
*** achampion has quit IRC04:19
*** ramishra has quit IRC04:34
*** ramishra has joined #openstack-trove04:42
*** eghobo has quit IRC05:13
*** Longgeek has joined #openstack-trove05:15
*** michael-yu has joined #openstack-trove05:32
*** flaper87|afk is now known as flaper8705:46
*** michael-yu_ has joined #openstack-trove06:09
*** michael-yu has quit IRC06:12
*** michael-yu_ is now known as michael-yu06:12
*** flaper87 is now known as flaper87|afk06:12
*** k4n0 has joined #openstack-trove06:16
*** michael-yu has quit IRC06:20
*** dkehnx has quit IRC06:35
*** dkehnx has joined #openstack-trove06:35
*** eghobo has joined #openstack-trove06:41
*** eghobo has quit IRC06:42
*** Longgeek has quit IRC07:26
*** Longgeek has joined #openstack-trove07:28
*** ramishra has quit IRC07:59
*** boblebauce has joined #openstack-trove08:12
*** isviridov is now known as isviridov|vacati08:14
*** boden has joined #openstack-trove08:23
*** boden has quit IRC08:32
*** ramishra has joined #openstack-trove08:53
*** sgotliv has joined #openstack-trove09:33
*** sgotliv has quit IRC10:00
*** georgelorch2 has joined #openstack-trove10:07
*** georgelorch3 has quit IRC10:08
*** boden has joined #openstack-trove10:42
*** ramishra has quit IRC11:07
*** ramishra has joined #openstack-trove11:08
*** demorris has joined #openstack-trove11:18
*** denis_makogon has joined #openstack-trove11:32
*** IanGovett has joined #openstack-trove11:36
*** ramishra has quit IRC11:46
amrithdenis_makogon, yt?12:08
denis_makogonamrith, yes12:09
amrithdenis_makogon, would you please review your comments to https://review.openstack.org/#/c/108215/ and https://review.openstack.org/#/c/108216/. It is hard to understand (to me) what you want changed. It would help considerably if you were more precise in the nature of the change you would like.12:10
amrithfor example, in https://review.openstack.org/#/c/108216/ you "are thinking" about changing the default for a parameter from logging=None to logging=logging.DEBUG. But, I'm trying to do the same kind of thing that is done all over openstack.12:11
amrithso, are you recommending that I do something different from the rest of openstack (in many many places), and certainly different from what this function is doing?12:11
amrithin https://review.openstack.org/#/c/108215/ you ask that I do proper multi-string formatting. What would you like? I'm emitting a bash script the exact same way in which it is done in two other places in that file.12:12
amrithso, please help us understand what your thinking is by being a bit more specific so we can incorporate your feedback. otherwise it just sits there delaying the review process and we go back and forth with patch sets that may or many not reflect what you want/intend/thought of/hoped for/desired. etc.,12:13
*** demorris has quit IRC12:13
amrithdenis_makogon, ^^12:13
*** juantwo has joined #openstack-trove12:13
denis_makogonamrith, "other OpenStack" sound more than weired for me12:14
amrithI don't understand what you are saying. again, please speak more 'plainly'. what is weired (what is weired) about it?12:15
denis_makogondenis_makogon, one module doesn't mean whole ecosystem, but i will leave it for  oslo cores, they would made the last decision12:15
amrithlet me observe that in 579 places in trove, we have parameter=None as the default.12:16
*** juantwo has quit IRC12:17
amrithso, would you please send an email to, say openstack-dev with your proposal? it isn't for oslo-core, what you are proposing is for openstack at large.12:17
denis_makogonamrith, different situation, different project, different behavior12:18
*** juantwo has joined #openstack-trove12:18
amrithI'd strongly urge you to send your proposal to the openstack dev community with your sugegstion. I agree, it could reduce lines of code.12:18
denis_makogonamrith, i'm not interested in it12:18
denis_makogonamrith, i don't like to follow strange patterns, just because someone did like that long time ago and he thought that it was ok12:19
amrithinteresting. you are ok -1'ing a change and proposing something that isn't done anywhere else in that source file, but not interested enough to actually follow through?12:19
amrithdenis_makogon, I'm not a python "guru", you clearly have an opinion about it. why not do something about it? if it is strange, why not make that something we can all benefit from?12:20
*** IanGovett has quit IRC12:20
amrithanyway, what about the multi-line formatting? is it something like this where you think it is a strange pattern?12:21
denis_makogonamrith, because staying focused on 1-2 projects is more productive than spreading myself to tons of them12:21
*** pdmars has joined #openstack-trove12:21
denis_makogonamrith, yes12:21
amrithdenis_makogon, so why not make that clear in your comment? what's the pattern you would like?12:22
denis_makogonamrith, triple quotes are used only for docstrings mostly, python has more appropriate ways to format lines12:22
amrithhow would you like these lines wrapped?12:22
amrithso, please share, how does one do this?12:23
denis_makogonamrith, i already left comment with an example of lines should be wrapped https://review.openstack.org/#/c/108215/2/tests/unit/test_processutils.py,cm12:23
*** ramishra has joined #openstack-trove12:23
denis_makogonamrith, also, testing thing, testtools has perfect method called `assertRaises`, it returns raised exception object, so, you don't have to write try:except blocks to catch the certain exception12:25
amrithI'm trying your code out12:25
denis_makogonamrith, could you please fix test assertions too ?12:25
*** georgelorch2 has quit IRC12:26
amrithone at a time12:26
amrithyour proposed code doesn't work12:26
amrithso we'll leave that alone12:26
*** georgelorch2 has joined #openstack-trove12:26
amrithas for the assertion, if you observe, the intent of the test is not to see whether a particular assertion is raised or not (which is what assertRaises does)12:26
amrithinstead, it is to actually cause the assertion12:26
amrithand interrogate the contents of the thrown exception12:27
amrithsorry, cause the exception and interrogate the contents of the exception12:27
denis_makogonamrith,  actually it does12:27
amrithbut again, if you know how to make assertRaises() do that, I'm certainly interested in knowing.12:27
*** k4n0 has quit IRC12:28
denis_makogonamrith, i will leave comment, and while i'm doing it, you could find where i missed formatting symbol at previous comment12:28
amrithYes, please do. that would help.12:29
denis_makogonamrith, https://gist.github.com/denismakogon/0ed14d89b752630c427312:30
amriththe code you propose in this gist above does not do what the test is intending to test.12:31
amrithI want to make sure that the assertion does NOT contain the string you have ...12:31
amrithanywhere in it12:32
amrithsecond, your assertRaises() does not account for other variables in the exception.12:32
amrithso sorry, your code doesn't accomplish what I'm trying to test.12:33
amrithgot to run now, thanks for your help.12:33
denis_makogonamrith, i does _actually_ what you've wrote at the patchset, but it avoids try:except block which should not be in tests, find appropriate way with use of assertRaises12:34
amrithno it does not12:34
amrithit tests that an exception is thrown and you provide some things in the exception12:34
amrithbut there are others12:34
amrithplease tell me how assertRaises tests for 'password="secret"' not in err.cmd12:35
amrithare you proposing that I keep all the code 19-26 as well? or just 15-17?12:36
denis_makogonamrith, see https://gist.github.com/denismakogon/0ed14d89b752630c427312:38
amrithI'll fix the formatting on line 11, sounds good.12:39
amrithif that's what you want12:39
amrithso why does the rest of the source file not do this? and should I conform to the same thing that the rest of the file uses?12:39
amrithanyway, please propose that in your comments. I'll take a look12:40
*** radez_g0n3 is now known as radez12:40
denis_makogonamrith, we should do our best on what we do and do not look at stinky(sometimes) code that was committed long time ago12:40
*** IanGovett has joined #openstack-trove13:22
*** achampion has joined #openstack-trove13:31
*** tvoran has joined #openstack-trove13:31
*** demorris has joined #openstack-trove13:33
*** georgelorch2 has quit IRC13:39
*** georgelorch has joined #openstack-trove13:39
*** IanGovett_ has joined #openstack-trove13:57
*** IanGovett_ has left #openstack-trove13:57
*** robertmyers has joined #openstack-trove14:08
*** mattgriffin has joined #openstack-trove14:09
*** boden has quit IRC14:10
*** georgelorch has quit IRC14:11
*** georgelorch has joined #openstack-trove14:11
denis_makogonamrith, could you please fix https://review.openstack.org/#/c/107726/5/trove/guestagent/api.py,cm14:24
amrithI could14:27
amrithwhat is it?14:28
amrithhard to read it while driving ;)14:28
*** grapex has joined #openstack-trove14:30
*** rwsu has joined #openstack-trove14:32
*** Longgeek has quit IRC14:34
denis_makogonamrith, the message contains work "calling" even if it's in _cast(...) method14:36
denis_makogon*word14:36
denis_makogoncores, and other guys who's interested in, just letting you, i've added patch for devstack, see https://review.openstack.org/#/c/108371/, and for infra, see https://review.openstack.org/#/c/100601/ - all this patches are related to heat based testing14:41
*** Barker has joined #openstack-trove14:41
*** yidclare has joined #openstack-trove14:45
*** yidclare has quit IRC14:47
*** openstackgerrit has joined #openstack-trove14:48
*** openstackgerrit has quit IRC14:48
*** thedodd has joined #openstack-trove14:49
*** doddstack has joined #openstack-trove14:52
*** thedodd has quit IRC14:54
*** openstackgerrit has joined #openstack-trove15:02
imsplitbithello everyone!15:02
juantwowow, hi imsplitbit15:02
imsplitbithad a few minutes before I had to get started working, though I'd reach out and see how everyoen is15:03
*** IanGovett has left #openstack-trove15:04
*** rueben has joined #openstack-trove15:06
juantwoimsplitbit: how are you liking the new digs?15:06
imsplitbitlovin it15:07
ruebenimsplitbit: o/15:07
imsplitbitespecially now that I don't have to work with rueben...15:07
imsplitbitoh...15:07
imsplitbitawkward15:07
rueben;(15:07
juantwolol15:07
ruebenhaha15:07
imsplitbithi rueben15:07
imsplitbit:D15:07
ruebencweid: tells me the only reason I got rueben on freenode is because I spell my name wrong15:08
ruebenso lots of love...15:09
ruebengonna have to grab lunch.  You're still in town right?15:09
cp16netimsplitbit: omg he speaks15:12
imsplitbityou go work for a startup and see how often you can come up for air15:13
imsplitbit:)15:13
cp16netdrowning huh?15:13
imsplitbitdoesn't feel like it15:13
imsplitbitbut I'm def more busy15:13
imsplitbitwhich is crazy cause I always felt like I was busy before15:14
imsplitbit:)15:14
cp16netyeah i bet15:14
*** IanGovett has joined #openstack-trove15:18
dougshelley66imsplitbit, hi there - good to hear from you! liking the startup life?15:21
boblebauceHi. I created a Wiki page for the rootwrap-for-guest blueprint : https://wiki.openstack.org/wiki/Trove/Blueprints/rootwrap-for-guest15:22
boblebauceIs it possible to update the https://blueprints.launchpad.net/trove/+spec/rootwrap-for-guest page to link to the Wiki entry please ?15:23
boblebauceAnd possibly update the assignee :)15:23
*** juantwo_ has joined #openstack-trove15:25
boblebauceAny chance to review this BP for the today's meeting ?15:25
*** grapex has quit IRC15:25
*** grapex has joined #openstack-trove15:25
*** ramishra has quit IRC15:26
*** ramishra has joined #openstack-trove15:26
*** juantwo has quit IRC15:28
*** ramishra has quit IRC15:30
*** grapex_ has joined #openstack-trove15:32
*** grapex has quit IRC15:34
dougshelley66boblebauce, just add your info to here https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting15:34
boblebaucedougshelley66: I'm adding it right now, thanks15:34
*** jmontemayor has joined #openstack-trove15:35
*** grapex has joined #openstack-trove15:35
*** grapex_ has quit IRC15:37
*** grapex has quit IRC15:37
*** edmund has joined #openstack-trove15:38
*** grapex_ has joined #openstack-trove15:38
*** redthrux has joined #openstack-trove15:38
*** ramishra has joined #openstack-trove15:46
*** eghobo has joined #openstack-trove15:47
denis_makogonboblebauce, are you there ?15:48
*** ramishra has quit IRC15:49
denis_makogonboblebauce, hope you are, please update blueprint by setting specification URL, https://wiki.openstack.org/wiki/Trove/Blueprints/rootwrap-for-guest15:49
boblebaucedenis_makogon: I'm there15:50
denis_makogonboblebauce, nice =)15:50
boblebaucedenis_makogon: I can't modify it, I don't have the permissions to edit the launchpad bp15:50
denis_makogonboblebauce, as i can see you also cannot modify blueprint =), i update whiteboard of it15:50
denis_makogonboblebauce, i see, that's why i update BP whiteboard15:51
boblebaucedenis_makogon: thanks15:51
denis_makogonboblebauce, np15:51
*** eghobo has quit IRC15:54
*** shakamunyi has joined #openstack-trove15:54
*** doddstack has quit IRC15:54
*** eghobo has joined #openstack-trove15:55
openstackgerritChristian Berendt proposed a change to openstack/trove: Enable hacking check H306  https://review.openstack.org/10841715:57
*** ViswaV_ has joined #openstack-trove15:58
*** ViswaV has quit IRC16:00
*** thedodd has joined #openstack-trove16:09
openstackgerritCraig Vyvial proposed a change to openstack/trove: parse the mysql cnf file for password  https://review.openstack.org/10410716:09
*** boblebauce has left #openstack-trove16:10
*** Barker has quit IRC16:21
*** Barker has joined #openstack-trove16:23
*** rueben has quit IRC16:30
openstackgerritamrith proposed a change to openstack/trove: Logging audit for trove/guestagent module  https://review.openstack.org/10772616:33
openstackgerritDenis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup  https://review.openstack.org/10810116:37
openstackgerritamrith proposed a change to openstack/trove: Logging audit for guestagent/redis  https://review.openstack.org/10780516:38
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10684316:42
openstackgerritDenis M. proposed a change to openstack/trove: Update backup state when guest error occurs  https://review.openstack.org/10226216:44
denis_makogonamrith, ping16:44
openstackgerritamrith proposed a change to openstack/trove: Logging audit for guestagent/redis  https://review.openstack.org/10780516:56
*** IanGovett has left #openstack-trove16:57
*** IanGovett has joined #openstack-trove16:57
openstackgerritAnna Shen proposed a change to openstack/trove: Add neutron support  https://review.openstack.org/8834916:59
*** annashen_ has joined #openstack-trove17:01
openstackgerritDenis M. proposed a change to openstack/trove: Fix incremental backups feature validation  https://review.openstack.org/10606517:03
openstackgerritDenis M. proposed a change to openstack/trove: Fix parent backup state validation  https://review.openstack.org/10605017:03
openstackgerritDenis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup  https://review.openstack.org/10810117:03
openstackgerritDenis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted  https://review.openstack.org/10283817:03
openstackgerritDenis M. proposed a change to openstack/trove: Update backup state when guest error occurs  https://review.openstack.org/10226217:03
openstackgerritDenis M. proposed a change to openstack/trove: Fix backup state check while restoring an instance  https://review.openstack.org/10604217:03
*** ViswaV has joined #openstack-trove17:03
openstackgerritCraig Vyvial proposed a change to openstack/trove: guestagent contract for packages should be a list  https://review.openstack.org/10410817:05
*** ViswaV_ has quit IRC17:06
denis_makogonSlickNik, are you there ?17:07
*** ViswaV_ has joined #openstack-trove17:09
*** ViswaV has quit IRC17:12
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10684317:12
openstackgerritDenis M. proposed a change to openstack/trove-integration: Enabling Heat provisioning based on ENV for Trove  https://review.openstack.org/10844317:18
*** jcru has joined #openstack-trove17:20
openstackgerritRamashri Umale proposed a change to openstack/trove: Adds backup/restore support for mongodb  https://review.openstack.org/7833917:21
*** demorris has quit IRC17:22
*** jcru has quit IRC17:23
*** saurabhs has joined #openstack-trove17:27
*** tvoran has quit IRC17:32
openstackgerritDenis M. proposed a change to openstack/trove: Support full backup/restore for Cassandra  https://review.openstack.org/7755117:38
*** peopleme1ge is now known as peoplemerge17:40
*** thedodd has quit IRC17:40
SlickNikdenis_makogon: Yes, what's up?17:44
denis_makogonSlickNik, just wanted to talk to you about heat gates17:44
denis_makogonSlickNik, i've submitted 3 patches: devstack, integration, infra17:45
*** jcru has joined #openstack-trove17:45
*** shakamunyi_ has joined #openstack-trove17:45
denis_makogonSlickNik, redstack https://review.openstack.org/#/c/108443/17:45
denis_makogonSlickNik, devstack https://review.openstack.org/#/c/108371/17:45
denis_makogonSlickNik, infra https://review.openstack.org/#/c/100601/17:46
denis_makogonneed your thoughts and patient reviewing17:46
*** shakamunyi has quit IRC17:49
SlickNikdenis_makogon: Okay, will probably get to them after the j2 cut. Right now, the j2 work items are keeping me pretty busy.17:49
denis_makogonSlickNik, ok17:50
openstackgerritSteve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM  https://review.openstack.org/8624217:55
*** grapex_ has quit IRC17:57
*** grapex has joined #openstack-trove17:57
*** thedodd has joined #openstack-trove17:58
SlickNik#startmeeting trove-bp-review18:00
openstackMeeting started Mon Jul 21 18:00:04 2014 UTC and is due to finish in 60 minutes.  The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot.18:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.18:00
openstackThe meeting name has been set to 'trove_bp_review'18:00
denis_makogono/18:00
SlickNikgiving folks a few minutes to trickle in18:00
SlickNikAgenda at:18:01
SlickNik#link https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting18:01
dougshelley66o/18:02
vgnbkro/18:02
schango/18:02
peterstaco/18:02
grapexo/18:02
SlickNikdenis_makogon: You have 3 BPs scheduled. In the interest of fairness - and time, we'll discuss the first one, move on to boblebauce's bp, and then come back to the other two.18:03
denis_makogonSlickNik, of course18:03
*** Riddhi has joined #openstack-trove18:03
icchao/18:03
amritho/18:04
SlickNik#topic Datastore log files operations18:04
SlickNik#link https://blueprints.launchpad.net/trove/+spec/dbinstance-log18:04
denis_makogonso, it's mine18:04
denis_makogonwe've did reviewing of it, twice already18:04
denis_makogonthe last concerns were related to HTTP routes, payloads18:04
denis_makogoni've did alot with vipul to flesh it out18:05
annashen_o/18:05
vgnbkrYes.  Can you point out where you have addressed SlickNik's concerns as listed on the whiteboard?  I couldn't find where they were addressed.18:05
denis_makogonso, and this review request was raised to kill this beast finally, since it should be in Juno release18:05
*** demorris has joined #openstack-trove18:06
*** boblebauce has joined #openstack-trove18:06
amrithsorry, I don't get it. is the review to accept the proposal or kill the proposal?18:06
denis_makogonamrith, review request =)18:06
grapexI didn't know we needed formal meetings to stop the progress on features in Trove.18:07
amrithvgnbkr +118:07
denis_makogonvgnbkr, cases are described in Justification section18:07
grapexj/k18:07
vgnbkrSo I wasn't clear how audit fit into all this. Are you planning to enable auditing somehow?18:08
SlickNikThis review is to get the proposal accepted.18:08
denis_makogonvgnbkr, all concerns  are not fitting into first proposal, but itss a good start to accomplish goals18:08
vipulI thinkt he audit stuff just needs to be taken out.. to avoid confusion on what is being propsed18:09
denis_makogonvgnbkr, audit will be accomplished by 3d party tools, our task to pull logs out of instance, since we cannot access instance through ssh or whatever18:09
sbadiao/18:09
SlickNikdenis_makogon: I don't think this is a very good proposal for Audit requirements — I can see this as a good convenience to developers (i.e. I want to find out the contents of my slow-query logs, for example).18:09
vipulthis proposal is pretty simple.. provide a mechanism to ship datastore logs out of Trove instances18:09
denis_makogonvipul, yes, that's what i was trying to say18:10
vipuli think the extra wording confuses that message denis_makogon18:10
denis_makogonvipul, i see18:10
SlickNikdenis_makogon: Yes, in that case, please remove the requirements section about "audit", since it doesn't look like this is aiming to tackle that.18:11
denis_makogonso, as vipul said, initial proposal is simple - provide a mechanism to ship logs from instance to storage18:11
denis_makogondone18:12
amrithone minor nit, my browser has a plugin that detects plagarism (vestiges of being a teacher) and it flagged this page. Turns out there's some chunks that have been copied without attribution. Justification: Database Audit was copied from an article http://www.comwise.com.my/learn-about-database-security-auditing-tools/. If that's the case, we should attribute the content.18:12
vipullet's just delete that section too -- not necessary to talk about auditing why/how/at all18:13
denis_makogondone and done18:13
vgnbkrDoes it include operations to enable logging?  i.e., to create the log files that the user wants to see?18:13
*** amcrn has joined #openstack-trove18:13
denis_makogonvgnbkr, its up to configurations API18:14
denis_makogonvgnbkr, by use of configurations API, user will be able to enable/disable logging configuration18:14
denis_makogonvgnbkr, spec states about it18:15
denis_makogonvgnbkr, API section18:15
denis_makogonvgnbkr, https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperationV1#How_does_it_works18:15
SlickNikdenis_makogon: So what's the behavior if the configuration group has logging disabled?18:16
vgnbkrI did read that, but it really wasn't very clear what you were getting at there.18:16
denis_makogonSlickNik, user would not be able to pull logs, because they are not enabled by the applied configuration18:16
SlickNikdenis_makogon: There likely needs to be a new error response to the client, I take it? That's something that's part of the API contract and should be called out.18:17
SlickNikdenis_makogon: Also the "Public API" section confuses me. It states:18:18
SlickNikThree new resources, log-create, log-show will be exposed as part of the Trove API.18:18
SlickNikThe log-show is used to provide an ability to list all available(availability defined by Trove) database logging filenames per instance.18:18
SlickNikThe log-create is used to provide an ability to save database logging file into the Swift container, required attribute - instance.18:18
denis_makogonSlickNik, user will see an empty log ist18:18
denis_makogon*list18:18
SlickNikdenis_makogon: That is not good UX — for there is no indication that this feature is tied to config groups at all! They would never guess how to enable it.18:19
*** rueben has joined #openstack-trove18:19
SlickNikdenis_makogon: That section says "three" but lists only "two".18:19
*** dkehn_ has joined #openstack-trove18:20
denis_makogonSlickNik, fixed, actually two18:20
SlickNikdenis_makogon: What's the API response on error — (eg. when swift is not accessible?)18:21
*** tvoran has joined #openstack-trove18:21
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10845918:21
denis_makogonSlickNik, design was taken from backups API, user will receive 403 Forbidden18:21
*** kevinconway has joined #openstack-trove18:22
SlickNikdenis_makogon: The spec does not call that out.18:22
vipuldenis_makogon, SlickNik -- we shouldn't be editing this spec on the fly as we find issues.. i think it's better for everyone if Denis goes back.. and addresses all these points18:22
denis_makogonSlickNik, i see18:22
SlickNikdenis_makogon: In general, the spec needs to cover these issues.18:22
*** dkehnx has quit IRC18:23
denis_makogonskipping18:23
SlickNikdenis_makogon: I find it concerning that after going through multiple iterations for multiple specs, you still come back with specs that are missing key parts of the API information.18:23
denis_makogonSlickNik, each time new concern are being raised, which weren't asked ever before18:24
denis_makogonlet's just skip it18:24
SlickNikdenis_makogon: not every concern should have to be called out. Let's talk offline about how we can achieve writing better specs from the get-go, so as to reduce churn at these meetings.18:26
SlickNik#topic Use oslo-rootwrap18:26
SlickNik#link https://blueprints.launchpad.net/trove/+spec/rootwrap-for-guest18:27
SlickNikboblebauce: around?18:27
*** thedodd has quit IRC18:28
robertmyershmm, the review linked to that BP has noting to do with root wrap18:28
sbadiaI'm here (I work with boblebauce)18:28
openstackgerritRamashri Umale proposed a change to openstack/trove: Adds backup/restore support for mongodb  https://review.openstack.org/7833918:29
sbadiarobertmyers: yes, the review linked is more a code cleanup18:29
amrithSlickNik, I'd agreed to work with boblebauce about this. I think I'll have to do some more.18:29
amrithDidn't realize this was coming up today18:30
amrithelse I'd have chatted with him about it18:30
robertmyersyeah, root wrap will be a major change18:30
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10845918:30
amrithyes18:31
amrithI think what boblebauce is proposing is much smaller18:31
robertmyersyes, that is just bug fix18:31
amrithI'll work with him about this. that was supposed to be just a 'sample'.18:31
robertmyersthe BP is a major overhaul18:31
amrithbut I think there's more work to be done before this can be reviewed.18:31
SlickNikamrith / sbadia: So I think we all agree that the BP is worth tackling. While coming up with the spec, we need to look at a couple of things:18:31
SlickNik- What other OpenStack projects do? There is root-wrap code in oslo, how do we leverage this18:31
SlickNik- What would the impact of these changes be?18:31
kevinconwayamrith: a sample? is the first one free?18:32
amrithSlickNik, a couple of things18:32
amrith(and I'll get to kevinconway's comment in a second)18:32
amrithone thing I'd like is to hold the bp in vipul's name till we reach agreement on what is to be done18:32
amrithand I'll get you the answers to the questions you pose above.18:32
amrithkevinconway, the second is half-price.18:33
amrith;18:33
amrith;)18:33
amrithI've been looking at other projects over the weekend18:33
cp16netsounds like half a product tho :-P18:33
amrithand not all have done this migration, I think.18:33
amrithso, I'll follow-up on my action item from the meeting on 07-1918:34
amrithand get back to y'all18:34
amrithunless sbadia has other thoughts, I'd call time on this one.18:34
icchayeah i think it was rejected in glance18:34
icchadont rem why18:34
sbadiaamrith: nop, it's ok18:35
amrithiccha, some projects rejected it because of scope pre-icehouse18:35
sbadiaindeed18:35
SlickNikamrith: I think nova is the one that has it done. Depending on the scope / impact, I'm okay with punting this based on other priorities.18:35
robertmyersI'm not sure if root wrap will work nicely with our guest18:35
robertmyersspecifically backups and restores18:35
robertmyerswe call subprocess directly18:35
amrithcan we agree that this is not targeted for juno (grin)18:35
amrithany +1's on that?18:35
SlickNikamrith: It isn't targeted for juno, already18:36
boblebauceHello18:36
SlickNikamrith: Milestone target: ongoing18:36
SlickNikSeries: Accepted for future18:36
amrithok. boblebauce sorry I dropped the ball on this one. we should chat; maybe after this meeting. I know we chatted a bit after the last meeting but, my apologies.18:37
boblebauceamrith: no problem !18:37
SlickNikOkay, let's keep moving.18:38
SlickNik#topic Disk space validation coefficient18:38
SlickNik#link https://blueprints.launchpad.net/trove/+spec/restore-disk-space-coefficient18:38
kevinconwaythis sounds like a fun math equation18:39
denis_makogonSo, there's a bug report related to validation of disk space18:39
denis_makogonkevinconway, it is18:39
vgnbkrSo this is a feature to detect when an operation would fail, and fail more gracefully.  Shouldn't we instead be looking to make the functionality work?18:39
denis_makogonvgnbkr, there's a problem with backuping/restoring tools18:40
denis_makogonvgnbkr, most of them can't do streaming18:40
denis_makogonvgnbkr, but mysqldump, xtrabackup can18:40
robertmyersdenis_makogon: is that the problem?18:40
kevinconwayit's more than streaming isn't it? you can't stream 20 gigs into a 1 gig disk18:40
robertmyerskevinconway: +118:40
vgnbkrRight.  So shouldn't we make a non-streaming backup/restore work in all cases?  Can't we address the diskspace issue somehow?  Perhaps mounting a temp volume?18:40
amrithwhat do you mean by streaming?18:41
vgnbkrBackup/restore by default streams the backup directly to swift, without storing it on the local drive.18:42
amrithyou get a file, you have to restore it. what does streaming mean?18:42
denis_makogonamrith, writing data directly into stdout without any specific preparations18:42
robertmyersso streaming only make backups take less memory18:42
SlickNikrobertmyers: +118:42
robertmyersnot sure how this applies to restore18:42
denis_makogonamrith, robertmyers, the problem is in the size of provided disk, you can't restore 20G to 1G disk, but you can deployers can configure Trove to accept size of disk that can be calculated with specific coefficient18:43
kevinconwayyeah seems like the issue is with all backups that exceed the disk space of the instance18:43
SlickNikamrith: streaming = writing the backup to swift directly so that the backup doesn't take up space on local disk.18:43
robertmyersdenis_makogon: so we should require at least a 20g in that case18:43
kevinconwayso denis_makogon is looking for a way to prevent failed builds due to a backup being too big. is that correct?18:43
SlickNikamrith: at least that's the implication here.18:43
amrithI hear two very different problems being described.18:44
amrithone is a restore problem.18:44
robertmyersI thought there was already a review for this18:44
amrithone is a backup problem.18:44
amrithso q to denis_makogon ... you appear to be solving the restore problem. yes?18:44
denis_makogonkevinconway, not at all, its all about quota on size of disk18:44
denis_makogonamrith, yes18:44
amrithok, so if this is a restore problem, then ...18:45
amriththis is an extension of the bug you are fixing18:45
denis_makogonso, if you want to restore X Gb, you would need to use X * per_datastore_coefficient disk size18:45
amrithwhere we said a backup is ~ size of on disk storage18:45
robertmyersamrith: +118:45
amrithbut you are looking to do some multiplication18:45
amrithto deal with the fact that the backup may be compressed18:46
amrithor some such18:46
denis_makogonamrith, that's why it's configurable per datastore18:46
denis_makogonamrith, deployer/dev knows how much additional space will be used by one or another strategy18:46
amriththere's a backup on swift18:47
robertmyersdenis_makogon: so a person backing up a 10g volume would need a 20g volume if the coefficient is 2?18:47
amrithit gets mounted and accessible18:47
robertmyersseems a little hight18:47
denis_makogonamrith, for mysql coefficient is 1 of course, because it can accept data as stream directly18:47
robertmyershigh18:47
amrithso someone has to guess how much disk space is needed in total for this backup inclusive of any intermedite files that may be required18:47
denis_makogonrobertmyers, yes18:47
robertmyersthat doesn't seem like a solution18:48
amrithI don't get it.18:48
amrithhow do I know that a compressed backup of 10GB can fit in a database of 10GB with indexes and stuff like that?18:48
amrithas robertmyers says, this doesn't sound like a solution to me.18:48
denis_makogonamrith, you can't know18:48
SlickNikdenis_makogon: This seems to me to be a bad idea. Seems to me like this propagates the idea of having "voodoo numbers" in our conf settings that doesn't really solve anything concrete.18:49
robertmyersso, let it fail I say18:49
amrithI'd rather we do something like tag the size of the instance volume that generated the abckup and let the user base the size of the new instance on that as a recommendation.18:49
denis_makogonif it's bad - lets skip it and find more appropriate solution18:50
amrithmagic numbers: -118:50
kevinconwayamrith: it's like a box delivered to you in the desert. you don't know what's in it so you have to guess and ask "What's in the booox?"18:50
vgnbkramrith: so then the user would be stuck paying indefinitely for storage that was used only to do the restore, no?18:50
amrithno, it's a hint18:50
amritha user can say restore this for me, pick a size you think is appropriate18:50
amrithor a user can say restore on size X GB, and it may fail18:50
amrithor we can do the obvious 'du' before we do the dump and record that size, rounded up etc.,18:51
amrithand use that as the starting point18:51
SlickNikIIRC, we do store the size of the data on disk, as part of the backup.18:51
robertmyersSlickNik: yes18:51
amrithSlickNik, I think we store the size of the backup file18:51
robertmyersamrith: no18:51
amrithok18:51
robertmyersvolume used18:52
SlickNikamrith: No - we also store the size of the data on the volume.18:52
amrithvolume size (total) or space used?18:52
robertmyersso we should just require at least that much18:52
denis_makogonhow user can know how much space he needs to restore a backup ?18:52
SlickNikand that should be a good enough hint of what volume size should be used.18:52
robertmyersamrith: space used18:52
robertmyersSlickNik: +118:52
denis_makogonuser is not able to know that strategy X takes up to two times of backup size18:52
amrithOK, then that's a start18:52
amrithlet's now get to the issue of streaming vs. non-streaming18:53
robertmyersdenis_makogon: add documentation18:53
robertmyersfor the users18:53
amrithfor mysql; the total space used is sufficient as a starting point18:53
amrithfor others you may have to stage an intermediate hunk of stuff in (say) /tmp18:53
amrithis that what denis_makogon is referring to as 'streaming' and 'non-streaming'?18:53
robertmyersI question whether this is an issue for other datastores18:54
robertmyersI think this would apply to mysql too18:54
amrithrobertmyers, I'll defer to the author of the proposal on that.18:54
robertmyersmysqldump does not stream18:54
denis_makogonamrith, i was referring to the tools that cannot accept data as income stream18:54
amrithI'm just trying to figure out what's being requested here18:54
robertmyersdenis_makogon: look at xtrabackup18:55
robertmyersit doesn't stream it directly in18:55
amrithso in effect, denis_makogon is making a proposal for the case of a solution that cannot do what mysql does18:55
robertmyersit loads it on disk first18:55
denis_makogonrobertmyers, xtrabackup can do data streaming18:55
amrithor that needs an intermediate space18:55
robertmyersdenis_makogon: look again18:55
robertmyersstream out18:55
robertmyersthe stream in is just a temp space that is not the actual restore18:56
amrithso robertmyers I think we agreed that we're talking about sreaming 'in' only18:56
amrithi.e. restore18:56
robertmyersyeah and I'm saying it doesn't even apply to mysql18:56
robertmyersin our current form18:56
SlickNikOkay, time check here.18:57
amrithSlickNik +118:57
denis_makogoni'll mark it as obsolete18:57
SlickNikdenis_makogon: Once again, I think the lack of clarity in the actual spec is causing a lot of confusion as to what's actually being proposed here.18:57
denis_makogonok18:58
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10684318:58
SlickNikdenis_makogon: and what the problem that we are trying to address really _is_18:58
SlickNikOkay, thanks.18:58
SlickNik#endmeeting18:59
openstackMeeting ended Mon Jul 21 18:59:19 2014 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)18:59
*** denis_makogon has quit IRC18:59
openstackMinutes:        http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.html18:59
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.txt18:59
grapexThanks SlickNik!18:59
openstackLog:            http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.log.html18:59
SlickNikThat's all the time that we have for this week.18:59
SlickNikThanks folks.18:59
cp16netcool thanks18:59
*** thedodd has joined #openstack-trove19:02
openstackgerritDenis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup  https://review.openstack.org/10810119:02
openstackgerritSuthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available  https://review.openstack.org/10684319:03
openstackgerritJoe Cruz proposed a change to openstack/trove: Make configuration tests configurable by datastore  https://review.openstack.org/10297219:04
*** redthrux has quit IRC19:05
*** demorris_ has joined #openstack-trove19:17
*** demorris has quit IRC19:17
*** demorris_ is now known as demorris19:17
*** ViswaV_ has quit IRC19:25
openstackgerritSimon Chang proposed a change to openstack/trove: Adjusted audit logging for taskmanager module  https://review.openstack.org/10802019:27
*** grapex has quit IRC19:31
*** demorris has quit IRC19:37
*** grapex has joined #openstack-trove19:38
*** ViswaV has joined #openstack-trove19:40
*** redthrux has joined #openstack-trove19:47
*** amrith has left #openstack-trove19:48
*** amrith has joined #openstack-trove19:48
*** jcru_ has joined #openstack-trove19:49
*** jcru has quit IRC19:52
*** jcru_ has quit IRC19:56
*** jcru has joined #openstack-trove19:56
*** jcru has quit IRC19:57
*** mrsnivvel has quit IRC20:01
*** ViswaV has quit IRC20:02
*** jmontemayor has quit IRC20:06
openstackgerritDan Nguyen proposed a change to openstack/trove: Implements guest agent upgrade pip strategy  https://review.openstack.org/8522520:12
*** jmontemayor has joined #openstack-trove20:30
*** ViswaV has joined #openstack-trove20:30
*** ViswaV_ has joined #openstack-trove20:31
*** ViswaV has quit IRC20:35
*** ViswaV_ has quit IRC20:44
openstackgerritGreg Lucas proposed a change to openstack/trove: Inject guest conf files to configurable location  https://review.openstack.org/10038120:49
*** ViswaV has joined #openstack-trove20:55
*** jmontemayor has quit IRC21:02
*** ViswaV has quit IRC21:12
*** jmontemayor has joined #openstack-trove21:16
*** saurabhs has quit IRC21:16
*** saurabhs has joined #openstack-trove21:19
*** freyes_ has joined #openstack-trove21:23
*** shakamunyi_ has quit IRC21:24
*** IanGovett has quit IRC21:26
*** freyes_ has quit IRC21:27
*** saurabhs has quit IRC21:29
*** rueben has quit IRC21:31
*** juantwo_ has quit IRC21:32
*** kevinconway has quit IRC21:36
*** freyes_ has joined #openstack-trove21:40
*** redthrux has quit IRC21:47
*** demorris has joined #openstack-trove22:00
*** rwsu has quit IRC22:02
*** annashen_ has quit IRC22:10
*** robertmyers has quit IRC22:14
*** Barker has quit IRC22:16
*** grapex has quit IRC22:30
*** ViswaV has joined #openstack-trove22:33
*** ViswaV_ has joined #openstack-trove22:34
*** esp has left #openstack-trove22:36
*** esp has joined #openstack-trove22:36
openstackgerritCraig Vyvial proposed a change to openstack/trove: parse the mysql cnf file for password  https://review.openstack.org/10410722:37
*** ViswaV has quit IRC22:37
*** thedodd has quit IRC22:41
*** edmund has quit IRC22:42
*** pdmars has quit IRC22:46
*** pdmars has joined #openstack-trove22:47
*** achampion has quit IRC22:48
*** pdmars has quit IRC22:52
*** shakamunyi_ has joined #openstack-trove22:53
openstackgerritSteve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM  https://review.openstack.org/8624222:58
*** freyes_ has quit IRC23:06
*** demorris has quit IRC23:09
*** Riddhi has quit IRC23:12
*** shakamunyi_ has quit IRC23:33
*** achampion has joined #openstack-trove23:44
*** ViswaV_ has quit IRC23:58
*** eghobo has quit IRC23:58
*** ViswaV has joined #openstack-trove23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!