*** julienvey has joined #openstack-trove | 00:05 | |
*** boblebauce has left #openstack-trove | 00:07 | |
*** julienvey has quit IRC | 00:10 | |
openstackgerrit | amrith proposed a change to openstack/trove: Merge from oslo-incubator https://review.openstack.org/111870 | 00:17 |
---|---|---|
*** mattgriffin has joined #openstack-trove | 00:25 | |
*** amrith is now known as amrith_ | 00:27 | |
*** amrith_ is now known as amrith | 00:27 | |
openstackgerrit | amrith proposed a change to openstack/trove: Merge from oslo-incubator https://review.openstack.org/111870 | 00:29 |
*** michael-yu has quit IRC | 00:34 | |
*** ViswaV has joined #openstack-trove | 00:36 | |
*** michael-yu has joined #openstack-trove | 00:37 | |
*** Riddhi has joined #openstack-trove | 00:39 | |
*** shakamunyi has quit IRC | 00:43 | |
*** amcrn has quit IRC | 00:51 | |
*** julienvey has joined #openstack-trove | 01:06 | |
*** topshare has joined #openstack-trove | 01:07 | |
*** michael-yu has quit IRC | 01:08 | |
*** julienvey has quit IRC | 01:10 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Use guestagent conf set up by devstack https://review.openstack.org/103681 | 01:11 |
*** tvoran has joined #openstack-trove | 01:12 | |
*** julienvey has joined #openstack-trove | 01:21 | |
*** ViswaV has quit IRC | 01:21 | |
*** julienvey has quit IRC | 01:25 | |
*** eghobo has quit IRC | 01:33 | |
*** ramashri has quit IRC | 01:35 | |
*** mattgriffin has quit IRC | 01:44 | |
*** nosnos has joined #openstack-trove | 01:50 | |
*** mattgriffin has joined #openstack-trove | 01:50 | |
*** mattgriffin has quit IRC | 01:50 | |
*** shakamunyi has joined #openstack-trove | 01:53 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Use netifaces to lookup IP address on guest agent https://review.openstack.org/111887 | 01:56 |
*** mattgriffin has joined #openstack-trove | 01:57 | |
*** haomaiw__ has quit IRC | 02:02 | |
*** haomaiwang has joined #openstack-trove | 02:02 | |
*** mattgriffin has quit IRC | 02:03 | |
*** mattgriffin has joined #openstack-trove | 02:05 | |
*** georgelorch has quit IRC | 02:07 | |
*** shakamunyi has quit IRC | 02:07 | |
*** georgelorch has joined #openstack-trove | 02:08 | |
*** Riddhi has quit IRC | 02:08 | |
*** michael-yu has joined #openstack-trove | 02:11 | |
*** michael-yu has quit IRC | 02:11 | |
*** haomaiw__ has joined #openstack-trove | 02:14 | |
*** haomaiw__ has quit IRC | 02:17 | |
*** haomaiwang has quit IRC | 02:18 | |
*** haomaiwang has joined #openstack-trove | 02:18 | |
*** julienvey has joined #openstack-trove | 02:21 | |
*** shakamunyi has joined #openstack-trove | 02:22 | |
*** julienvey has quit IRC | 02:26 | |
*** dkehnx has quit IRC | 02:30 | |
*** dkehnx has joined #openstack-trove | 02:31 | |
*** haomaiw__ has joined #openstack-trove | 02:33 | |
*** ramashri has joined #openstack-trove | 02:35 | |
*** haomaiwang has quit IRC | 02:35 | |
*** ramashri has quit IRC | 02:39 | |
*** ramashri has joined #openstack-trove | 02:39 | |
*** edmund has joined #openstack-trove | 02:52 | |
*** edmund has quit IRC | 03:02 | |
*** edmund has joined #openstack-trove | 03:04 | |
*** michael-yu has joined #openstack-trove | 03:05 | |
*** michael-yu has quit IRC | 03:05 | |
*** ramishra has joined #openstack-trove | 03:08 | |
*** topshare has quit IRC | 03:20 | |
*** julienvey has joined #openstack-trove | 03:22 | |
*** juantwo_ has quit IRC | 03:25 | |
*** juantwo has joined #openstack-trove | 03:26 | |
*** julienvey has quit IRC | 03:27 | |
*** topshare has joined #openstack-trove | 03:31 | |
*** edmund has quit IRC | 03:36 | |
*** eghobo has joined #openstack-trove | 03:37 | |
*** michael-yu has joined #openstack-trove | 03:45 | |
*** michael-yu has quit IRC | 03:47 | |
*** michael-yu has joined #openstack-trove | 03:53 | |
*** michael-yu has quit IRC | 03:53 | |
openstackgerrit | A change was merged to openstack/trove: Moved core int-test groups from trove-int to trove https://review.openstack.org/107860 | 03:56 |
*** michael-yu has joined #openstack-trove | 04:03 | |
*** michael-yu has quit IRC | 04:06 | |
*** Riddhi has joined #openstack-trove | 04:09 | |
*** michael-yu has joined #openstack-trove | 04:16 | |
*** eghobo has quit IRC | 04:22 | |
*** eghobo has joined #openstack-trove | 04:23 | |
*** julienvey has joined #openstack-trove | 04:23 | |
*** julienvey has quit IRC | 04:27 | |
*** rushiagr__ has joined #openstack-trove | 04:43 | |
*** k4n0 has joined #openstack-trove | 04:43 | |
*** michael-yu has quit IRC | 04:45 | |
*** michael-yu has joined #openstack-trove | 04:54 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 05:01 |
openstackgerrit | Craig Vyvial proposed a change to openstack/python-troveclient: adding configuration parameters mgmt api https://review.openstack.org/79851 | 05:01 |
*** Riddhi has quit IRC | 05:02 | |
*** mattgriffin has quit IRC | 05:04 | |
*** ramishra has quit IRC | 05:05 | |
*** ramishra_ has joined #openstack-trove | 05:05 | |
*** juantwo has quit IRC | 05:09 | |
*** juantwo has joined #openstack-trove | 05:10 | |
*** mattgriffin has joined #openstack-trove | 05:11 | |
*** juantwo has quit IRC | 05:14 | |
*** tvoran has quit IRC | 05:15 | |
*** eguz has joined #openstack-trove | 05:21 | |
*** julienvey has joined #openstack-trove | 05:24 | |
*** eghobo has quit IRC | 05:25 | |
*** rushiagr__ is now known as rushiagr | 05:27 | |
*** julienvey has quit IRC | 05:28 | |
*** rushiagr has quit IRC | 05:28 | |
*** rushiagr has joined #openstack-trove | 05:29 | |
*** mattgriffin has quit IRC | 05:32 | |
*** Longgeek has joined #openstack-trove | 05:33 | |
*** shakamunyi has quit IRC | 05:42 | |
*** flaper87|afk is now known as flaper87 | 05:56 | |
*** eguz has quit IRC | 06:01 | |
*** topshare has quit IRC | 06:04 | |
openstackgerrit | Greg Lucas proposed a change to openstack/trove: Mysql guest agent functionality for replication https://review.openstack.org/98147 | 06:05 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/108899 | 06:07 |
*** topshare has joined #openstack-trove | 06:09 | |
*** shakamunyi has joined #openstack-trove | 06:09 | |
*** ramashri has quit IRC | 06:16 | |
*** zacksh has quit IRC | 06:18 | |
*** zacksh has joined #openstack-trove | 06:19 | |
*** shakamunyi has quit IRC | 06:24 | |
*** ViswaV has joined #openstack-trove | 06:24 | |
*** julienvey has joined #openstack-trove | 06:24 | |
*** Longgeek has quit IRC | 06:28 | |
*** Longgeek has joined #openstack-trove | 06:28 | |
*** ViswaV has quit IRC | 06:28 | |
*** Longgeek has quit IRC | 06:29 | |
*** Longgeek_ has joined #openstack-trove | 06:29 | |
*** julienvey has quit IRC | 06:29 | |
*** Longgeek_ has quit IRC | 06:31 | |
*** flaper87 is now known as flaper87|afk | 06:41 | |
*** Longgeek has joined #openstack-trove | 06:42 | |
*** iartarisi has joined #openstack-trove | 06:49 | |
*** shakamunyi has joined #openstack-trove | 06:50 | |
*** shakamunyi has quit IRC | 06:58 | |
openstackgerrit | Ionut Artarisi proposed a change to openstack/trove: allow both ipv4 and ipv6 hostnames by default https://review.openstack.org/109219 | 06:59 |
*** michael-yu has quit IRC | 07:04 | |
*** julienvey has joined #openstack-trove | 07:25 | |
*** ajayaa has joined #openstack-trove | 07:29 | |
*** julienvey has quit IRC | 07:29 | |
ajayaa | Hi. I am trying to create a db with "trove create aj 2 --size 5". But it fails to build with error "Trove instance status description: Build error: guestagent timeout." | 07:31 |
ajayaa | Any idea what might be going wrong. | 07:31 |
*** boblebauce has joined #openstack-trove | 07:35 | |
*** boblebauce has quit IRC | 07:44 | |
*** ajayaa has quit IRC | 07:48 | |
*** shakamunyi has joined #openstack-trove | 07:55 | |
*** boden has joined #openstack-trove | 07:58 | |
*** rwsu has quit IRC | 07:59 | |
*** shakamunyi has quit IRC | 08:10 | |
*** julienvey has joined #openstack-trove | 08:10 | |
*** topshare has quit IRC | 08:13 | |
*** ajayaa has joined #openstack-trove | 08:16 | |
*** topshare has joined #openstack-trove | 08:20 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Add netifaces as a dependency for the guest agent https://review.openstack.org/111961 | 09:11 |
*** boblebauce has joined #openstack-trove | 09:11 | |
*** Longgeek has quit IRC | 09:14 | |
*** ramishra_ has quit IRC | 09:15 | |
*** ramishra has joined #openstack-trove | 09:15 | |
*** ramishra has quit IRC | 09:20 | |
openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove-integration: Fixed dependency on trove for int-tests https://review.openstack.org/107868 | 09:21 |
*** Longgeek has joined #openstack-trove | 09:22 | |
amrith | ajayaa, are you able to launch a nova instance on the same configuration? | 09:46 |
*** boblebauce has quit IRC | 09:46 | |
ajayaa | amrith: yes | 09:50 |
*** dmakogon_ is now known as denis_makogon | 09:54 | |
ajayaa | amrith: The guest agent resides in the vm being created. How do I make sure that the guest agent is working and functional? | 09:54 |
denis_makogon | ajayaa, hello, what type of images have you used ? | 09:55 |
ajayaa | The one specified in redstack. ubuntu_mysql | 09:55 |
ajayaa | denis_makogen, | 09:55 |
denis_makogon | ajayaa, can you log into VM via SSH ? | 09:56 |
denis_makogon | ajayaa, i guess there's a problem in connectivity between compute host and VM | 09:57 |
*** shakamunyi has joined #openstack-trove | 09:57 | |
denis_makogon | ajayaa, and upstart scripts were failed due connectivity issue | 09:57 |
ajayaa | denis_makogon, let me see. | 09:58 |
denis_makogon | ajayaa, sure, ping me after | 09:58 |
*** ramishra has joined #openstack-trove | 09:58 | |
*** boblebauce has joined #openstack-trove | 09:58 | |
*** shakamunyi has quit IRC | 10:01 | |
*** flaper87|afk is now known as flaper87 | 10:01 | |
ajayaa | denis_makogon, Can I specify a ssh key while doing "trove create"? | 10:15 |
*** flaper87 is now known as flaper87|afk | 10:16 | |
denis_makogon | ajayaa, now | 10:20 |
denis_makogon | ajayaa, no | 10:20 |
denis_makogon | ajayaa, redstack is configured in to be a host that would be used to rsync code from | 10:20 |
denis_makogon | ajayaa, have you checked guest logs? | 10:21 |
denis_makogon | ajayaa, log is in /tmp/logfile.txt | 10:21 |
ajayaa | denis_makogon, I don't see a file called /tmp/logfile.txt. BTW I did "redstack install" once to install trove components and then using stack.sh to get the environment up. | 10:24 |
denis_makogon | ajayaa, you need to do also "./restack kick-start mysql" | 10:24 |
denis_makogon | ajayaa, it seems that i was right, the easiest way to fix your problem is to reboot your redstack VM | 10:25 |
ajayaa | denis_makogon, what does ./redstack kick-start mysql do? | 10:27 |
denis_makogon | ajayaa, it's additional command for redstack script | 10:27 |
denis_makogon | ajayaa, https://github.com/openstack/trove-integration#kick-start-the-buildtest-initbuild-image-commands | 10:27 |
*** rushiagr has quit IRC | 10:40 | |
openstackgerrit | A change was merged to openstack/trove: Imported Translations from Transifex https://review.openstack.org/108899 | 10:40 |
*** rushiagr has joined #openstack-trove | 10:40 | |
*** Longgeek has quit IRC | 10:41 | |
*** Longgeek has joined #openstack-trove | 10:42 | |
*** Longgeek has quit IRC | 10:44 | |
*** Longgeek has joined #openstack-trove | 10:46 | |
*** rushiagr has quit IRC | 10:50 | |
*** rushiagr_ has joined #openstack-trove | 10:50 | |
*** ajayaa has quit IRC | 10:58 | |
*** ajayaa has joined #openstack-trove | 11:02 | |
*** achampion has joined #openstack-trove | 11:07 | |
*** nosnos has quit IRC | 11:10 | |
*** topshare has quit IRC | 11:14 | |
openstackgerrit | amrith proposed a change to openstack/trove: Move usage_timeout out of guest options https://review.openstack.org/87040 | 11:27 |
*** flaper87|afk is now known as flaper87 | 11:33 | |
*** ajayaa has quit IRC | 11:42 | |
*** shakamunyi has joined #openstack-trove | 11:47 | |
*** flaper87 is now known as flaper87|afk | 11:54 | |
*** juantwo has joined #openstack-trove | 11:57 | |
*** shakamunyi has quit IRC | 11:58 | |
*** juantwo has quit IRC | 11:58 | |
*** juantwo has joined #openstack-trove | 11:59 | |
*** ajayaa has joined #openstack-trove | 12:02 | |
*** denis_makogon has quit IRC | 12:14 | |
*** pdmars has joined #openstack-trove | 12:18 | |
*** pdmars has quit IRC | 12:20 | |
*** pdmars has joined #openstack-trove | 12:21 | |
*** IanGovett has joined #openstack-trove | 12:25 | |
ajayaa | denis_makogon, I am still facing problem while creating an instance. Reboot does not help | 12:28 |
*** ajayaa has quit IRC | 12:32 | |
*** flaper87|afk is now known as flaper87 | 12:34 | |
*** edmund has joined #openstack-trove | 12:37 | |
openstackgerrit | boden proposed a change to openstack/trove: Load trove API extensions using stevedore https://review.openstack.org/111714 | 12:40 |
*** miqui has joined #openstack-trove | 12:42 | |
*** radez_g0n3 is now known as radez | 12:43 | |
*** boblebauce has quit IRC | 12:44 | |
*** boblebauce has joined #openstack-trove | 12:49 | |
*** k4n0 has quit IRC | 12:50 | |
openstackgerrit | amrith proposed a change to openstack/trove: Removal of uneeded guest mount_point from taskmgr https://review.openstack.org/86808 | 12:50 |
*** jasondotstar has joined #openstack-trove | 13:03 | |
*** boblebauce has quit IRC | 13:04 | |
*** ajaya has joined #openstack-trove | 13:07 | |
*** ajaya is now known as ajayaa | 13:07 | |
*** edmund has quit IRC | 13:07 | |
*** james_li has joined #openstack-trove | 13:10 | |
*** IanGovett has quit IRC | 13:14 | |
*** konetzed has quit IRC | 13:14 | |
*** juantwo has quit IRC | 13:14 | |
*** iartarisi has quit IRC | 13:14 | |
*** spiffxp_ has quit IRC | 13:14 | |
*** abramley has quit IRC | 13:14 | |
*** kpom has quit IRC | 13:14 | |
*** IanGovett has joined #openstack-trove | 13:15 | |
*** juantwo has joined #openstack-trove | 13:15 | |
*** iartarisi has joined #openstack-trove | 13:15 | |
*** konetzed has joined #openstack-trove | 13:15 | |
*** spiffxp_ has joined #openstack-trove | 13:15 | |
*** abramley has joined #openstack-trove | 13:15 | |
*** kpom has joined #openstack-trove | 13:15 | |
*** james_li has quit IRC | 13:18 | |
*** mrsnivvel has quit IRC | 13:19 | |
*** zacksh has quit IRC | 13:21 | |
*** zacksh has joined #openstack-trove | 13:22 | |
*** adam_g has quit IRC | 13:25 | |
*** tvoran has joined #openstack-trove | 13:25 | |
*** kevinconway has joined #openstack-trove | 13:26 | |
*** topshare has joined #openstack-trove | 13:26 | |
*** mattgriffin has joined #openstack-trove | 13:29 | |
*** adam_g has joined #openstack-trove | 13:29 | |
*** adam_g has quit IRC | 13:30 | |
*** adam_g has joined #openstack-trove | 13:30 | |
*** grapex has joined #openstack-trove | 13:37 | |
*** grapex_ has joined #openstack-trove | 13:38 | |
*** Barker has joined #openstack-trove | 13:41 | |
*** shakamunyi has joined #openstack-trove | 13:41 | |
*** Barker has quit IRC | 13:42 | |
*** grapex has quit IRC | 13:42 | |
*** Barker has joined #openstack-trove | 13:42 | |
*** Barker has quit IRC | 13:47 | |
*** boblebauce has joined #openstack-trove | 13:47 | |
*** shakamunyi has quit IRC | 13:49 | |
*** Barker has joined #openstack-trove | 13:54 | |
*** flaper87 is now known as flaper87|afk | 13:57 | |
*** Barker has quit IRC | 13:58 | |
*** Barker has joined #openstack-trove | 14:01 | |
*** Barker has quit IRC | 14:03 | |
*** grapex_ has quit IRC | 14:04 | |
*** flaper87|afk is now known as flaper87 | 14:06 | |
*** jcru has joined #openstack-trove | 14:06 | |
*** shakamunyi has joined #openstack-trove | 14:10 | |
*** ajayaa has quit IRC | 14:22 | |
*** denis_makogon has joined #openstack-trove | 14:24 | |
*** rushiagr_ has quit IRC | 14:25 | |
*** jmontemayor has joined #openstack-trove | 14:29 | |
*** ramishra has quit IRC | 14:31 | |
*** ramishra has joined #openstack-trove | 14:32 | |
*** shakamunyi has quit IRC | 14:32 | |
openstackgerrit | Pavlo Shchelokovskyy proposed a change to openstack/trove: Use native Heat template format and resources https://review.openstack.org/112035 | 14:33 |
*** ramishra has quit IRC | 14:34 | |
*** ramishra has joined #openstack-trove | 14:34 | |
*** ramishra has quit IRC | 14:37 | |
*** Longgeek has quit IRC | 14:41 | |
*** topshare has quit IRC | 14:41 | |
*** tvoran_ has joined #openstack-trove | 14:47 | |
*** tvoran_ has quit IRC | 14:47 | |
*** tvoran_ has joined #openstack-trove | 14:48 | |
*** tvoran has quit IRC | 14:48 | |
*** ramashri has joined #openstack-trove | 14:49 | |
*** ramashri has quit IRC | 14:54 | |
*** ramashri has joined #openstack-trove | 14:55 | |
*** cweid has quit IRC | 15:06 | |
*** topshare has joined #openstack-trove | 15:09 | |
*** shakamunyi has joined #openstack-trove | 15:12 | |
*** thedodd has joined #openstack-trove | 15:14 | |
*** doddstack has joined #openstack-trove | 15:25 | |
*** thedodd has quit IRC | 15:26 | |
*** shakamunyi has quit IRC | 15:28 | |
*** rushiagr_ has joined #openstack-trove | 15:34 | |
*** ramishra has joined #openstack-trove | 15:40 | |
*** achampio1 has joined #openstack-trove | 15:43 | |
*** achampion has quit IRC | 15:43 | |
*** tvoran_ has quit IRC | 15:44 | |
*** ramashri has quit IRC | 15:44 | |
*** tvoran has joined #openstack-trove | 15:46 | |
*** kevinconway has quit IRC | 15:55 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 15:55 |
*** kevinconway has joined #openstack-trove | 15:58 | |
*** Barker has joined #openstack-trove | 15:59 | |
amrith | SlickNik, yt? | 15:59 |
*** jmontemayor has quit IRC | 16:05 | |
*** Barker has quit IRC | 16:07 | |
*** topshare has quit IRC | 16:08 | |
*** Barker has joined #openstack-trove | 16:11 | |
*** achampio1 has quit IRC | 16:12 | |
*** michael-yu has joined #openstack-trove | 16:14 | |
*** achampion has joined #openstack-trove | 16:14 | |
*** openstackstatus has quit IRC | 16:17 | |
*** openstack has joined #openstack-trove | 16:17 | |
*** jmontemayor has joined #openstack-trove | 16:17 | |
*** eghobo has joined #openstack-trove | 16:17 | |
*** openstackstatus has joined #openstack-trove | 16:18 | |
*** ChanServ sets mode: +v openstackstatus | 16:18 | |
*** tvoran has quit IRC | 16:19 | |
*** ramashri has joined #openstack-trove | 16:20 | |
*** tvoran has joined #openstack-trove | 16:21 | |
*** tvoran has quit IRC | 16:22 | |
*** tvoran has joined #openstack-trove | 16:23 | |
*** michael-yu has quit IRC | 16:23 | |
*** Barker has quit IRC | 16:27 | |
*** iartarisi has quit IRC | 16:28 | |
*** ViswaV has joined #openstack-trove | 16:29 | |
*** ViswaV_ has joined #openstack-trove | 16:30 | |
*** doddstack has quit IRC | 16:30 | |
*** ViswaV has quit IRC | 16:34 | |
*** rwsu has joined #openstack-trove | 16:43 | |
*** michael-yu has joined #openstack-trove | 16:45 | |
*** ViswaV_ has quit IRC | 16:46 | |
*** edmund has joined #openstack-trove | 16:46 | |
*** michael-yu has quit IRC | 16:48 | |
*** ViswaV has joined #openstack-trove | 16:50 | |
*** flaper87 is now known as flaper87|afk | 16:51 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/trove: Updated from global requirements https://review.openstack.org/111529 | 16:55 |
SlickNik | amrith: what's up? | 16:55 |
amrith | SlickNik, you may have seen the chatter on openstack-oslo | 16:56 |
amrith | I've been chatting with them about 1347337 | 16:56 |
amrith | and the thinking is that there's some issue with the way monkey patching is being done | 16:56 |
amrith | the problem is intermittent | 16:56 |
amrith | but when the monkey patching goes wrong, this problem occurs. | 16:56 |
amrith | I'm able to show that at times when the failure occurs, monkey patching of eventlet didn't complete properly | 16:57 |
amrith | A candidate fix is to be more aggressive about monkey_patching() | 16:57 |
SlickNik | amrith: reading the scrollback from the oslo channel. | 16:57 |
amrith | every place which calls import eventlet must immediately follow with the monkey_patch | 16:57 |
amrith | that seems to fix the problem. | 16:57 |
amrith | I now have backtraces generated from within execute() when monkey patching hasn't worked properly | 16:58 |
amrith | and sure enough we get the failure that we've been seeing | 16:58 |
amrith | I'll shut up for a second and let you get caught up | 16:58 |
* amrith shuts up | 16:58 | |
*** kevinconway has quit IRC | 16:59 | |
amrith | SlickNik, I'll be right back, just have to get something out of the microwave | 17:01 |
SlickNik | amrith: sounds good | 17:01 |
* SlickNik is still reading scrollback | 17:01 | |
* amrith am back | 17:06 | |
*** ajayaa has joined #openstack-trove | 17:07 | |
amrith | SlickNik, lmk when you are caught up. | 17:15 |
SlickNik | amrith: caught up now. | 17:17 |
*** michael-yu has joined #openstack-trove | 17:17 | |
amrith | ok ... yes, we did type a lot ;) | 17:17 |
SlickNik | amrith: looking at places where eventlet gets imported and monkey patched in the codebase :) | 17:17 |
amrith | there are several. | 17:17 |
SlickNik | yup that's what I'm finding. I wonder what the reasoning was for not monkey patching it immediately after the import in some cases. | 17:18 |
amrith | in trove ... cmd/guest.py and cmd/common.py | 17:18 |
amrith | So, I've tested with a change where I monkey_patch() immediately after every import of eventlet | 17:19 |
amrith | and with that, the problem goes away (or at least, it hasn't appeared) | 17:19 |
amrith | but the problem isn't 100% reproducible | 17:19 |
amrith | so I'm reluctant to call this proposal anything more than hack #2 | 17:19 |
amrith | I'm certainly going to submit code to oslo-incubator to remove the retries | 17:20 |
*** ramishra has quit IRC | 17:21 | |
*** ramishra has joined #openstack-trove | 17:22 | |
amrith | but I'm not sure about your thoughts on the hack to just force the monkey_patch ... | 17:22 |
amrith | my primary concern is that the problem is not 100% reproducible | 17:22 |
amrith | and so that means that we're not really sure why it is that sometimes we can end up not properly patched. | 17:22 |
SlickNik | amrith: That seems reasonable (i.e. moving the monkey-patch closer to the import when we do the monkey patching) | 17:23 |
amrith | well, with that, I can still make the problem occur | 17:23 |
amrith | I've made it not occur by adding monkeypatch to a bunch of places that import eventlet | 17:23 |
SlickNik | Ah, I see. I didn't catch that subtlety intially. | 17:24 |
SlickNik | amrith: So grapex might have a bit more context into this since he wrote a lot of the eventlet, and monkey patching code initially. | 17:24 |
amrith | ok, I'll ping him. he doesn't appear to be online now. | 17:25 |
SlickNik | amrith: Let's run this by him when he's around as well — he might have some more insight into it. | 17:25 |
SlickNik | ^^ grapex | 17:25 |
amrith | one question for you though | 17:25 |
amrith | when I run tox -e py27 | 17:25 |
amrith | is the test run single threaded or multi-threaded? | 17:26 |
*** ramishra has quit IRC | 17:26 | |
SlickNik | The unit tests run using testr, which run multi-threaded, I believe.. | 17:26 |
amrith | and as an aside, trove/tests/unittests/guestagent/test_volume.py | 17:27 |
amrith | appears to leave a turd in /tmp | 17:27 |
SlickNik | (by default) | 17:27 |
amrith | ok. | 17:27 |
amrith | I'm not sure how to delete that file but it is basically an /etc/fstab | 17:27 |
amrith | that gets left in /tmp | 17:27 |
amrith | and if you run tox -e py27 over and over again, overnight ... you get a lot of files in /tmp ;( | 17:27 |
SlickNik | Hmmm, not sure which test is writing that. | 17:32 |
amrith | not sure which test. | 17:32 |
amrith | I changed /dev/vdb to /dev/vdc in two places in that file and the new files created had vdc | 17:32 |
amrith | so I'm sure it's something in there. | 17:32 |
SlickNik | guestagent/volume.py writes fstab content to a NamedTemporaryFile | 17:33 |
*** ramashri has quit IRC | 17:33 | |
*** ramashri has joined #openstack-trove | 17:34 | |
SlickNik | So it's likely a test in tests/unittests/guestagent/test_volume.py that's writing the file that's not being cleaned up. | 17:34 |
amrith | oh, I'm sure it is in there ;) | 17:34 |
amrith | oh, wait | 17:35 |
amrith | yes, that's the place. | 17:35 |
SlickNik | You could try running those tests in isolation to confirm. | 17:35 |
amrith | wait, how? | 17:36 |
amrith | I'd love to do that | 17:36 |
amrith | and just run the mongo prepare test | 17:36 |
amrith | in isolation | 17:36 |
SlickNik | I use: "python -m subunit.run discover <path(dir)-to-tests-to-run-in-isolation>" while in the tox virtualenv | 17:38 |
amrith | ok, I can do that | 17:38 |
*** ramashri has quit IRC | 17:42 | |
*** ramashri has joined #openstack-trove | 17:42 | |
*** rushiagr_ has quit IRC | 17:43 | |
*** amcrn has joined #openstack-trove | 17:43 | |
*** heitor has joined #openstack-trove | 17:56 | |
*** heitor is now known as htrmeira | 17:56 | |
*** htrmeira has quit IRC | 17:58 | |
cp16net | sweet i got the tests passing again | 18:09 |
cp16net | https://rdjenkins.dyndns.org/job/multi-patch-test/26/? | 18:09 |
cp16net | https://review.openstack.org/#/q/topic:bp/configuration-parameters-in-db,n,z | 18:10 |
cp16net | w00t w00t | 18:10 |
*** Barker has joined #openstack-trove | 18:11 | |
*** julienvey has quit IRC | 18:26 | |
*** ViswaV has quit IRC | 18:27 | |
*** ViswaV has joined #openstack-trove | 18:27 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 18:33 |
SlickNik | cp16net: w00t! Nice job. | 18:34 |
*** kevinconway has joined #openstack-trove | 18:34 | |
*** georgelorch has quit IRC | 18:40 | |
*** ramishra has joined #openstack-trove | 18:40 | |
*** georgelorch has joined #openstack-trove | 18:41 | |
*** ViswaV has quit IRC | 18:42 | |
*** james_li has joined #openstack-trove | 18:49 | |
*** georgelorch has quit IRC | 18:49 | |
*** georgelorch has joined #openstack-trove | 18:50 | |
*** htrmeira has joined #openstack-trove | 18:55 | |
*** Barker has quit IRC | 18:57 | |
*** Barker has joined #openstack-trove | 19:03 | |
*** ajayaa has quit IRC | 19:03 | |
*** Barker has quit IRC | 19:07 | |
*** julienvey has joined #openstack-trove | 19:13 | |
*** tkatarki has joined #openstack-trove | 19:15 | |
*** rwsu has quit IRC | 19:18 | |
*** julienvey has quit IRC | 19:20 | |
*** ViswaV has joined #openstack-trove | 19:22 | |
*** julienvey has joined #openstack-trove | 19:22 | |
*** ramishra has quit IRC | 19:23 | |
openstackgerrit | amrith proposed a change to openstack/trove: guestagent/test_volume.py leaves a file in /tmp https://review.openstack.org/112118 | 19:30 |
*** tkatarki has quit IRC | 19:31 | |
amrith | SlickNik, ... https://review.openstack.org/#/c/112118/ | 19:33 |
amrith | thx | 19:33 |
*** tvoran_ has joined #openstack-trove | 19:34 | |
*** tvoran has quit IRC | 19:37 | |
openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/redis https://review.openstack.org/107805 | 19:45 |
*** denis_makogon_ has joined #openstack-trove | 19:46 | |
*** denis_makogon has quit IRC | 19:46 | |
*** denis_makogon_ is now known as denis_makogon | 19:46 | |
*** dmakogon_ has joined #openstack-trove | 19:46 | |
openstackgerrit | amrith proposed a change to openstack/trove: Merge from oslo-incubator https://review.openstack.org/111870 | 19:52 |
*** rwsu has joined #openstack-trove | 19:54 | |
*** IanGovett has quit IRC | 19:59 | |
*** ViswaV has quit IRC | 20:03 | |
*** michael-yu has quit IRC | 20:14 | |
*** tvoran_ is now known as tvoran | 20:21 | |
*** ViswaV has joined #openstack-trove | 20:25 | |
openstackgerrit | amrith proposed a change to openstack/trove: Merge from oslo-incubator https://review.openstack.org/111870 | 20:26 |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db https://review.openstack.org/79850 | 20:26 |
*** boden has quit IRC | 20:33 | |
*** james_li has quit IRC | 20:34 | |
*** ViswaV has quit IRC | 20:36 | |
*** james_li has joined #openstack-trove | 20:36 | |
*** juantwo has quit IRC | 20:41 | |
*** radez is now known as radez_g0n3 | 20:42 | |
*** michael-yu has joined #openstack-trove | 20:43 | |
amrith | cp16net, yt? | 20:43 |
cp16net | yeah what up | 20:43 |
amrith | got some tums. Greg's and your comment in https://review.openstack.org/#/c/112118/1 gave me some heartburn. | 20:44 |
amrith | I don't think the proposal is 'nice'. | 20:44 |
amrith | here's why | 20:44 |
amrith | the contract is that if you set 'deleted=true' the temp file is deleted 'ON CLOSE' | 20:44 |
*** htrmeira has quit IRC | 20:44 | |
cp16net | yeah | 20:45 |
amrith | And I don't feel happy running install to copy a file that I'm holding open into /etc/fstab | 20:45 |
cp16net | tab that exe over | 20:45 |
amrith | ;) | 20:45 |
cp16net | put it in the with | 20:45 |
cp16net | then it will clean it up after its all done | 20:45 |
cp16net | right/ | 20:45 |
cp16net | ? | 20:45 |
amrith | not | 20:45 |
amrith | so if I tab it in | 20:45 |
amrith | execute() will spawn a sub-process | 20:46 |
amrith | to run install | 20:46 |
amrith | and that install will try and copy which file? | 20:46 |
amrith | the named temp file which I'm holding open | 20:46 |
amrith | and potentially unflushed ;) | 20:46 |
amrith | the last thing I want is a partial /etc/fstab | 20:46 |
amrith | that would be yucky | 20:46 |
amrith | now, I doubt you'll have an /etc/fstab that is over a block | 20:46 |
cp16net | you could tempfstab.flush() | 20:46 |
cp16net | then exe? | 20:47 |
amrith | but the concept of holding a file open while copying it doesn't make me feel happy | 20:47 |
*** IanGovett has joined #openstack-trove | 20:47 | |
amrith | I'm sure we could do that | 20:47 |
amrith | and it'll work fine | 20:47 |
amrith | till it fails ;) | 20:47 |
cp16net | thats what the code is dont know tho is it not? | 20:47 |
amrith | as it is seems straightforward | 20:47 |
amrith | don't get the last comment. | 20:47 |
cp16net | so lets back up a min | 20:49 |
amrith | ok | 20:49 |
cp16net | you changed the exe to os.remove | 20:49 |
amrith | yes | 20:49 |
*** julienvey has quit IRC | 20:49 | |
cp16net | because the exe statement wasnt cleaning up the file | 20:49 |
amrith | when it was mocked | 20:49 |
amrith | by the calling test | 20:49 |
amrith | the calling test was mocking execute | 20:49 |
amrith | therefore execute() wasn't actually getting called | 20:50 |
cp16net | oh i c | 20:51 |
amrith | here's the offending code. | 20:51 |
amrith | https://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_volume.py#L173-L181 | 20:51 |
cp16net | yeah i see what you mean | 20:51 |
* cp16net thinking | 20:51 | |
cp16net | gears are grinding | 20:51 |
amrith | in fairness, I don't see the point of this test ;) | 20:52 |
amrith | what's it testing? | 20:52 |
amrith | that execute() was called twice? | 20:52 |
cp16net | yeah and "test coverage" | 20:52 |
amrith | hmmm | 20:53 |
amrith | anyhow, that's why I changed it the way I did to the remove. I hadn't thought of what Greg and you suggested. But I'm not happy with that for the reasons I mentioned above. | 20:54 |
amrith | it seems dubious. | 20:54 |
cp16net | ok i get it | 20:54 |
cp16net | now fix the tests ;-) | 20:54 |
amrith | I don't think the test failure was because of my change ;) | 20:55 |
amrith | but I'll check | 20:55 |
cp16net | cant tell | 20:56 |
cp16net | something with the guest | 20:56 |
amrith | proboscis.case.MethodTest (tearDown) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (setUp) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_create_user_and_dbs) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_no_access) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_grant_full_access) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_grant_ghostdbs) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_grant_ghostusers) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_grant_idempotence) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_revoke_all_access) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_revoke_ghostdbs) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_revoke_ghostusers) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_revoke_non_idempotence) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_revoke_one_database) ... ok | 20:57 |
amrith | proboscis.case.MethodTest (test_grant_full_access_ignore_databases) ... ok | 20:57 |
amrith | I'll check | 20:57 |
amrith | not sure why it failed jenkins. twice, for two different reasons. | 20:57 |
cp16net | reddwarf tests failed | 21:01 |
cp16net | lol | 21:01 |
* cp16net doesnt know | 21:01 | |
cp16net | some times you have to hope you are up wind of ci | 21:01 |
cp16net | :-P | 21:01 |
*** coolsvap has quit IRC | 21:08 | |
*** pdmars has quit IRC | 21:13 | |
*** coolsvap has joined #openstack-trove | 21:15 | |
*** openstackgerrit has quit IRC | 21:16 | |
*** openstackgerrit has joined #openstack-trove | 21:16 | |
*** jasondotstar has quit IRC | 21:20 | |
*** denis_makogon has quit IRC | 21:26 | |
amrith | int-tests passed on my pc ;) | 21:28 |
amrith | waiting for jenkins to bless | 21:28 |
*** boden has joined #openstack-trove | 21:38 | |
*** tkatarki has joined #openstack-trove | 21:45 | |
*** julienvey has joined #openstack-trove | 21:50 | |
*** boden has quit IRC | 21:50 | |
*** tkatarki has quit IRC | 21:50 | |
*** julienvey has quit IRC | 21:54 | |
*** julienvey has joined #openstack-trove | 22:22 | |
*** julienvey has quit IRC | 22:27 | |
*** juantwo has joined #openstack-trove | 22:30 | |
*** juantwo has quit IRC | 22:30 | |
*** juantwo has joined #openstack-trove | 22:30 | |
*** mattgriffin has quit IRC | 22:56 | |
*** kevinconway has quit IRC | 23:01 | |
amrith | cp16net, yt? | 23:22 |
amrith | waiting on your +1 now ... | 23:22 |
amrith | thx | 23:22 |
openstackgerrit | Joe Cruz proposed a change to openstack/trove: Add instance metadata functionality to trove https://review.openstack.org/82123 | 23:23 |
*** julienvey has joined #openstack-trove | 23:23 | |
*** julienvey has quit IRC | 23:28 | |
openstackgerrit | amrith proposed a change to openstack/trove: Move usage_timeout out of guest options https://review.openstack.org/87040 | 23:30 |
*** jcru has quit IRC | 23:31 | |
*** achampion has quit IRC | 23:35 | |
*** james_li has quit IRC | 23:54 | |
openstackgerrit | A change was merged to openstack/trove: Sync service.py from oslo-incubator with deps https://review.openstack.org/110718 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!