Tuesday, 2014-08-05

*** julienvey has joined #openstack-trove00:05
*** boblebauce has left #openstack-trove00:07
*** julienvey has quit IRC00:10
openstackgerritamrith proposed a change to openstack/trove: Merge from oslo-incubator  https://review.openstack.org/11187000:17
*** mattgriffin has joined #openstack-trove00:25
*** amrith is now known as amrith_00:27
*** amrith_ is now known as amrith00:27
openstackgerritamrith proposed a change to openstack/trove: Merge from oslo-incubator  https://review.openstack.org/11187000:29
*** michael-yu has quit IRC00:34
*** ViswaV has joined #openstack-trove00:36
*** michael-yu has joined #openstack-trove00:37
*** Riddhi has joined #openstack-trove00:39
*** shakamunyi has quit IRC00:43
*** amcrn has quit IRC00:51
*** julienvey has joined #openstack-trove01:06
*** topshare has joined #openstack-trove01:07
*** michael-yu has quit IRC01:08
*** julienvey has quit IRC01:10
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Use guestagent conf set up by devstack  https://review.openstack.org/10368101:11
*** tvoran has joined #openstack-trove01:12
*** julienvey has joined #openstack-trove01:21
*** ViswaV has quit IRC01:21
*** julienvey has quit IRC01:25
*** eghobo has quit IRC01:33
*** ramashri has quit IRC01:35
*** mattgriffin has quit IRC01:44
*** nosnos has joined #openstack-trove01:50
*** mattgriffin has joined #openstack-trove01:50
*** mattgriffin has quit IRC01:50
*** shakamunyi has joined #openstack-trove01:53
openstackgerritNikhil Manchanda proposed a change to openstack/trove: Use netifaces to lookup IP address on guest agent  https://review.openstack.org/11188701:56
*** mattgriffin has joined #openstack-trove01:57
*** haomaiw__ has quit IRC02:02
*** haomaiwang has joined #openstack-trove02:02
*** mattgriffin has quit IRC02:03
*** mattgriffin has joined #openstack-trove02:05
*** georgelorch has quit IRC02:07
*** shakamunyi has quit IRC02:07
*** georgelorch has joined #openstack-trove02:08
*** Riddhi has quit IRC02:08
*** michael-yu has joined #openstack-trove02:11
*** michael-yu has quit IRC02:11
*** haomaiw__ has joined #openstack-trove02:14
*** haomaiw__ has quit IRC02:17
*** haomaiwang has quit IRC02:18
*** haomaiwang has joined #openstack-trove02:18
*** julienvey has joined #openstack-trove02:21
*** shakamunyi has joined #openstack-trove02:22
*** julienvey has quit IRC02:26
*** dkehnx has quit IRC02:30
*** dkehnx has joined #openstack-trove02:31
*** haomaiw__ has joined #openstack-trove02:33
*** ramashri has joined #openstack-trove02:35
*** haomaiwang has quit IRC02:35
*** ramashri has quit IRC02:39
*** ramashri has joined #openstack-trove02:39
*** edmund has joined #openstack-trove02:52
*** edmund has quit IRC03:02
*** edmund has joined #openstack-trove03:04
*** michael-yu has joined #openstack-trove03:05
*** michael-yu has quit IRC03:05
*** ramishra has joined #openstack-trove03:08
*** topshare has quit IRC03:20
*** julienvey has joined #openstack-trove03:22
*** juantwo_ has quit IRC03:25
*** juantwo has joined #openstack-trove03:26
*** julienvey has quit IRC03:27
*** topshare has joined #openstack-trove03:31
*** edmund has quit IRC03:36
*** eghobo has joined #openstack-trove03:37
*** michael-yu has joined #openstack-trove03:45
*** michael-yu has quit IRC03:47
*** michael-yu has joined #openstack-trove03:53
*** michael-yu has quit IRC03:53
openstackgerritA change was merged to openstack/trove: Moved core int-test groups from trove-int to trove  https://review.openstack.org/10786003:56
*** michael-yu has joined #openstack-trove04:03
*** michael-yu has quit IRC04:06
*** Riddhi has joined #openstack-trove04:09
*** michael-yu has joined #openstack-trove04:16
*** eghobo has quit IRC04:22
*** eghobo has joined #openstack-trove04:23
*** julienvey has joined #openstack-trove04:23
*** julienvey has quit IRC04:27
*** rushiagr__ has joined #openstack-trove04:43
*** k4n0 has joined #openstack-trove04:43
*** michael-yu has quit IRC04:45
*** michael-yu has joined #openstack-trove04:54
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985005:01
openstackgerritCraig Vyvial proposed a change to openstack/python-troveclient: adding configuration parameters mgmt api  https://review.openstack.org/7985105:01
*** Riddhi has quit IRC05:02
*** mattgriffin has quit IRC05:04
*** ramishra has quit IRC05:05
*** ramishra_ has joined #openstack-trove05:05
*** juantwo has quit IRC05:09
*** juantwo has joined #openstack-trove05:10
*** mattgriffin has joined #openstack-trove05:11
*** juantwo has quit IRC05:14
*** tvoran has quit IRC05:15
*** eguz has joined #openstack-trove05:21
*** julienvey has joined #openstack-trove05:24
*** eghobo has quit IRC05:25
*** rushiagr__ is now known as rushiagr05:27
*** julienvey has quit IRC05:28
*** rushiagr has quit IRC05:28
*** rushiagr has joined #openstack-trove05:29
*** mattgriffin has quit IRC05:32
*** Longgeek has joined #openstack-trove05:33
*** shakamunyi has quit IRC05:42
*** flaper87|afk is now known as flaper8705:56
*** eguz has quit IRC06:01
*** topshare has quit IRC06:04
openstackgerritGreg Lucas proposed a change to openstack/trove: Mysql guest agent functionality for replication  https://review.openstack.org/9814706:05
openstackgerritOpenStack Proposal Bot proposed a change to openstack/trove: Imported Translations from Transifex  https://review.openstack.org/10889906:07
*** topshare has joined #openstack-trove06:09
*** shakamunyi has joined #openstack-trove06:09
*** ramashri has quit IRC06:16
*** zacksh has quit IRC06:18
*** zacksh has joined #openstack-trove06:19
*** shakamunyi has quit IRC06:24
*** ViswaV has joined #openstack-trove06:24
*** julienvey has joined #openstack-trove06:24
*** Longgeek has quit IRC06:28
*** Longgeek has joined #openstack-trove06:28
*** ViswaV has quit IRC06:28
*** Longgeek has quit IRC06:29
*** Longgeek_ has joined #openstack-trove06:29
*** julienvey has quit IRC06:29
*** Longgeek_ has quit IRC06:31
*** flaper87 is now known as flaper87|afk06:41
*** Longgeek has joined #openstack-trove06:42
*** iartarisi has joined #openstack-trove06:49
*** shakamunyi has joined #openstack-trove06:50
*** shakamunyi has quit IRC06:58
openstackgerritIonut Artarisi proposed a change to openstack/trove: allow both ipv4 and ipv6 hostnames by default  https://review.openstack.org/10921906:59
*** michael-yu has quit IRC07:04
*** julienvey has joined #openstack-trove07:25
*** ajayaa has joined #openstack-trove07:29
*** julienvey has quit IRC07:29
ajayaaHi. I am trying to create a db with "trove create aj 2 --size 5". But it fails to build with error "Trove instance status description: Build error: guestagent timeout."07:31
ajayaaAny idea what might be going wrong.07:31
*** boblebauce has joined #openstack-trove07:35
*** boblebauce has quit IRC07:44
*** ajayaa has quit IRC07:48
*** shakamunyi has joined #openstack-trove07:55
*** boden has joined #openstack-trove07:58
*** rwsu has quit IRC07:59
*** shakamunyi has quit IRC08:10
*** julienvey has joined #openstack-trove08:10
*** topshare has quit IRC08:13
*** ajayaa has joined #openstack-trove08:16
*** topshare has joined #openstack-trove08:20
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Add netifaces as a dependency for the guest agent  https://review.openstack.org/11196109:11
*** boblebauce has joined #openstack-trove09:11
*** Longgeek has quit IRC09:14
*** ramishra_ has quit IRC09:15
*** ramishra has joined #openstack-trove09:15
*** ramishra has quit IRC09:20
openstackgerritNikhil Manchanda proposed a change to openstack/trove-integration: Fixed dependency on trove for int-tests  https://review.openstack.org/10786809:21
*** Longgeek has joined #openstack-trove09:22
amrithajayaa, are you able to launch a nova instance on the same configuration?09:46
*** boblebauce has quit IRC09:46
ajayaaamrith: yes09:50
*** dmakogon_ is now known as denis_makogon09:54
ajayaaamrith: The guest agent resides in the vm being created. How do I make sure that the guest agent is working and functional?09:54
denis_makogonajayaa, hello, what type of images have you used ?09:55
ajayaaThe one specified in redstack. ubuntu_mysql09:55
ajayaadenis_makogen,09:55
denis_makogonajayaa, can you log into VM via SSH ?09:56
denis_makogonajayaa, i guess there's a problem in connectivity between compute host and VM09:57
*** shakamunyi has joined #openstack-trove09:57
denis_makogonajayaa, and upstart scripts were failed due connectivity issue09:57
ajayaadenis_makogon, let me see.09:58
denis_makogonajayaa, sure, ping me after09:58
*** ramishra has joined #openstack-trove09:58
*** boblebauce has joined #openstack-trove09:58
*** shakamunyi has quit IRC10:01
*** flaper87|afk is now known as flaper8710:01
ajayaadenis_makogon, Can I specify a ssh key while doing "trove create"?10:15
*** flaper87 is now known as flaper87|afk10:16
denis_makogonajayaa, now10:20
denis_makogonajayaa, no10:20
denis_makogonajayaa, redstack is configured in to be a host that would be used to rsync code from10:20
denis_makogonajayaa, have you checked guest logs?10:21
denis_makogonajayaa, log is in /tmp/logfile.txt10:21
ajayaadenis_makogon, I don't see a file called /tmp/logfile.txt. BTW I did "redstack install" once to install trove components and then using stack.sh to get the environment up.10:24
denis_makogonajayaa, you need to do also "./restack kick-start mysql"10:24
denis_makogonajayaa, it seems that i was right, the easiest way to fix your problem is to reboot your redstack VM10:25
ajayaadenis_makogon, what does ./redstack kick-start mysql do?10:27
denis_makogonajayaa, it's additional command for redstack script10:27
denis_makogonajayaa, https://github.com/openstack/trove-integration#kick-start-the-buildtest-initbuild-image-commands10:27
*** rushiagr has quit IRC10:40
openstackgerritA change was merged to openstack/trove: Imported Translations from Transifex  https://review.openstack.org/10889910:40
*** rushiagr has joined #openstack-trove10:40
*** Longgeek has quit IRC10:41
*** Longgeek has joined #openstack-trove10:42
*** Longgeek has quit IRC10:44
*** Longgeek has joined #openstack-trove10:46
*** rushiagr has quit IRC10:50
*** rushiagr_ has joined #openstack-trove10:50
*** ajayaa has quit IRC10:58
*** ajayaa has joined #openstack-trove11:02
*** achampion has joined #openstack-trove11:07
*** nosnos has quit IRC11:10
*** topshare has quit IRC11:14
openstackgerritamrith proposed a change to openstack/trove: Move usage_timeout out of guest options  https://review.openstack.org/8704011:27
*** flaper87|afk is now known as flaper8711:33
*** ajayaa has quit IRC11:42
*** shakamunyi has joined #openstack-trove11:47
*** flaper87 is now known as flaper87|afk11:54
*** juantwo has joined #openstack-trove11:57
*** shakamunyi has quit IRC11:58
*** juantwo has quit IRC11:58
*** juantwo has joined #openstack-trove11:59
*** ajayaa has joined #openstack-trove12:02
*** denis_makogon has quit IRC12:14
*** pdmars has joined #openstack-trove12:18
*** pdmars has quit IRC12:20
*** pdmars has joined #openstack-trove12:21
*** IanGovett has joined #openstack-trove12:25
ajayaadenis_makogon, I am still facing problem while creating an instance. Reboot does not help12:28
*** ajayaa has quit IRC12:32
*** flaper87|afk is now known as flaper8712:34
*** edmund has joined #openstack-trove12:37
openstackgerritboden proposed a change to openstack/trove: Load trove API extensions using stevedore  https://review.openstack.org/11171412:40
*** miqui has joined #openstack-trove12:42
*** radez_g0n3 is now known as radez12:43
*** boblebauce has quit IRC12:44
*** boblebauce has joined #openstack-trove12:49
*** k4n0 has quit IRC12:50
openstackgerritamrith proposed a change to openstack/trove: Removal of uneeded guest mount_point from taskmgr  https://review.openstack.org/8680812:50
*** jasondotstar has joined #openstack-trove13:03
*** boblebauce has quit IRC13:04
*** ajaya has joined #openstack-trove13:07
*** ajaya is now known as ajayaa13:07
*** edmund has quit IRC13:07
*** james_li has joined #openstack-trove13:10
*** IanGovett has quit IRC13:14
*** konetzed has quit IRC13:14
*** juantwo has quit IRC13:14
*** iartarisi has quit IRC13:14
*** spiffxp_ has quit IRC13:14
*** abramley has quit IRC13:14
*** kpom has quit IRC13:14
*** IanGovett has joined #openstack-trove13:15
*** juantwo has joined #openstack-trove13:15
*** iartarisi has joined #openstack-trove13:15
*** konetzed has joined #openstack-trove13:15
*** spiffxp_ has joined #openstack-trove13:15
*** abramley has joined #openstack-trove13:15
*** kpom has joined #openstack-trove13:15
*** james_li has quit IRC13:18
*** mrsnivvel has quit IRC13:19
*** zacksh has quit IRC13:21
*** zacksh has joined #openstack-trove13:22
*** adam_g has quit IRC13:25
*** tvoran has joined #openstack-trove13:25
*** kevinconway has joined #openstack-trove13:26
*** topshare has joined #openstack-trove13:26
*** mattgriffin has joined #openstack-trove13:29
*** adam_g has joined #openstack-trove13:29
*** adam_g has quit IRC13:30
*** adam_g has joined #openstack-trove13:30
*** grapex has joined #openstack-trove13:37
*** grapex_ has joined #openstack-trove13:38
*** Barker has joined #openstack-trove13:41
*** shakamunyi has joined #openstack-trove13:41
*** Barker has quit IRC13:42
*** grapex has quit IRC13:42
*** Barker has joined #openstack-trove13:42
*** Barker has quit IRC13:47
*** boblebauce has joined #openstack-trove13:47
*** shakamunyi has quit IRC13:49
*** Barker has joined #openstack-trove13:54
*** flaper87 is now known as flaper87|afk13:57
*** Barker has quit IRC13:58
*** Barker has joined #openstack-trove14:01
*** Barker has quit IRC14:03
*** grapex_ has quit IRC14:04
*** flaper87|afk is now known as flaper8714:06
*** jcru has joined #openstack-trove14:06
*** shakamunyi has joined #openstack-trove14:10
*** ajayaa has quit IRC14:22
*** denis_makogon has joined #openstack-trove14:24
*** rushiagr_ has quit IRC14:25
*** jmontemayor has joined #openstack-trove14:29
*** ramishra has quit IRC14:31
*** ramishra has joined #openstack-trove14:32
*** shakamunyi has quit IRC14:32
openstackgerritPavlo Shchelokovskyy proposed a change to openstack/trove: Use native Heat template format and resources  https://review.openstack.org/11203514:33
*** ramishra has quit IRC14:34
*** ramishra has joined #openstack-trove14:34
*** ramishra has quit IRC14:37
*** Longgeek has quit IRC14:41
*** topshare has quit IRC14:41
*** tvoran_ has joined #openstack-trove14:47
*** tvoran_ has quit IRC14:47
*** tvoran_ has joined #openstack-trove14:48
*** tvoran has quit IRC14:48
*** ramashri has joined #openstack-trove14:49
*** ramashri has quit IRC14:54
*** ramashri has joined #openstack-trove14:55
*** cweid has quit IRC15:06
*** topshare has joined #openstack-trove15:09
*** shakamunyi has joined #openstack-trove15:12
*** thedodd has joined #openstack-trove15:14
*** doddstack has joined #openstack-trove15:25
*** thedodd has quit IRC15:26
*** shakamunyi has quit IRC15:28
*** rushiagr_ has joined #openstack-trove15:34
*** ramishra has joined #openstack-trove15:40
*** achampio1 has joined #openstack-trove15:43
*** achampion has quit IRC15:43
*** tvoran_ has quit IRC15:44
*** ramashri has quit IRC15:44
*** tvoran has joined #openstack-trove15:46
*** kevinconway has quit IRC15:55
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985015:55
*** kevinconway has joined #openstack-trove15:58
*** Barker has joined #openstack-trove15:59
amrithSlickNik, yt?15:59
*** jmontemayor has quit IRC16:05
*** Barker has quit IRC16:07
*** topshare has quit IRC16:08
*** Barker has joined #openstack-trove16:11
*** achampio1 has quit IRC16:12
*** michael-yu has joined #openstack-trove16:14
*** achampion has joined #openstack-trove16:14
*** openstackstatus has quit IRC16:17
*** openstack has joined #openstack-trove16:17
*** jmontemayor has joined #openstack-trove16:17
*** eghobo has joined #openstack-trove16:17
*** openstackstatus has joined #openstack-trove16:18
*** ChanServ sets mode: +v openstackstatus16:18
*** tvoran has quit IRC16:19
*** ramashri has joined #openstack-trove16:20
*** tvoran has joined #openstack-trove16:21
*** tvoran has quit IRC16:22
*** tvoran has joined #openstack-trove16:23
*** michael-yu has quit IRC16:23
*** Barker has quit IRC16:27
*** iartarisi has quit IRC16:28
*** ViswaV has joined #openstack-trove16:29
*** ViswaV_ has joined #openstack-trove16:30
*** doddstack has quit IRC16:30
*** ViswaV has quit IRC16:34
*** rwsu has joined #openstack-trove16:43
*** michael-yu has joined #openstack-trove16:45
*** ViswaV_ has quit IRC16:46
*** edmund has joined #openstack-trove16:46
*** michael-yu has quit IRC16:48
*** ViswaV has joined #openstack-trove16:50
*** flaper87 is now known as flaper87|afk16:51
openstackgerritOpenStack Proposal Bot proposed a change to openstack/trove: Updated from global requirements  https://review.openstack.org/11152916:55
SlickNikamrith: what's up?16:55
amrithSlickNik, you may have seen the chatter on openstack-oslo16:56
amrithI've been chatting with them about 134733716:56
amrithand the thinking is that there's some issue with the way monkey patching is being done16:56
amriththe problem is intermittent16:56
amrithbut when the monkey patching goes wrong, this problem occurs.16:56
amrithI'm able to show that at times when the failure occurs, monkey patching of eventlet didn't complete properly16:57
amrithA candidate fix is to be more aggressive about monkey_patching()16:57
SlickNikamrith: reading the scrollback from the oslo channel.16:57
amrithevery place which calls import eventlet must immediately follow with the monkey_patch16:57
amriththat seems to fix the problem.16:57
amrithI now have backtraces generated from within execute() when monkey patching hasn't worked properly16:58
amrithand sure enough we get the failure that we've been seeing16:58
amrithI'll shut up for a second and let you get caught up16:58
* amrith shuts up16:58
*** kevinconway has quit IRC16:59
amrithSlickNik, I'll be right back, just have to get something out of the microwave17:01
SlickNikamrith: sounds good17:01
* SlickNik is still reading scrollback 17:01
* amrith am back17:06
*** ajayaa has joined #openstack-trove17:07
amrithSlickNik, lmk when you are caught up.17:15
SlickNikamrith: caught up now.17:17
*** michael-yu has joined #openstack-trove17:17
amrithok ... yes, we did type a lot ;)17:17
SlickNikamrith: looking at places where eventlet gets imported and monkey patched in the codebase :)17:17
amriththere are several.17:17
SlickNikyup that's what I'm finding. I wonder what the reasoning was for not monkey patching it immediately after the import in some cases.17:18
amrithin trove ... cmd/guest.py and cmd/common.py17:18
amrithSo, I've tested with a change where I monkey_patch() immediately after every import of eventlet17:19
amrithand with that, the problem goes away (or at least, it hasn't appeared)17:19
amrithbut the problem isn't 100% reproducible17:19
amrithso I'm reluctant to call this proposal anything more than hack #217:19
amrithI'm certainly going to submit code to oslo-incubator to remove the retries17:20
*** ramishra has quit IRC17:21
*** ramishra has joined #openstack-trove17:22
amrithbut I'm not sure about your thoughts on the hack to just force the monkey_patch ...17:22
amrithmy primary concern is that the problem is not 100% reproducible17:22
amrithand so that means that we're not really sure why it is that sometimes we can end up not properly patched.17:22
SlickNikamrith: That seems reasonable (i.e. moving the monkey-patch closer to the import when we do the monkey patching)17:23
amrithwell, with that, I can still make the problem occur17:23
amrithI've made it not occur by adding monkeypatch to a bunch of places that import eventlet17:23
SlickNikAh, I see. I didn't catch that subtlety intially.17:24
SlickNikamrith: So grapex might have a bit more context into this since he wrote a lot of the eventlet, and monkey patching code initially.17:24
amrithok, I'll ping him. he doesn't appear to be online now.17:25
SlickNikamrith: Let's run this by him when he's around as well — he might have some more insight into it.17:25
SlickNik^^ grapex17:25
amrithone question for you though17:25
amrithwhen I run tox -e py2717:25
amrithis the test run single threaded or multi-threaded?17:26
*** ramishra has quit IRC17:26
SlickNikThe unit tests run using testr, which run multi-threaded, I believe..17:26
amrithand as an aside, trove/tests/unittests/guestagent/test_volume.py17:27
amrith appears to leave a turd in /tmp17:27
SlickNik(by default)17:27
amrithok.17:27
amrithI'm not sure how to delete that file but it is basically an /etc/fstab17:27
amriththat gets left in /tmp17:27
amrithand if you run tox -e py27 over and over again, overnight ... you get a lot of files in /tmp ;(17:27
SlickNikHmmm, not sure which test is writing that.17:32
amrithnot sure which test.17:32
amrithI changed /dev/vdb to /dev/vdc in two places in that file and the new files created had vdc17:32
amrithso I'm sure it's something in there.17:32
SlickNikguestagent/volume.py writes fstab content to a NamedTemporaryFile17:33
*** ramashri has quit IRC17:33
*** ramashri has joined #openstack-trove17:34
SlickNikSo it's likely a test in tests/unittests/guestagent/test_volume.py that's writing the file that's not being cleaned up.17:34
amrithoh, I'm sure it is in there ;)17:34
amrithoh, wait17:35
amrithyes, that's the place.17:35
SlickNikYou could try running those tests in isolation to confirm.17:35
amrithwait, how?17:36
amrithI'd love to do that17:36
amrithand just run the mongo prepare test17:36
amrithin isolation17:36
SlickNikI use: "python -m subunit.run discover <path(dir)-to-tests-to-run-in-isolation>" while in the tox virtualenv17:38
amrithok, I can do that17:38
*** ramashri has quit IRC17:42
*** ramashri has joined #openstack-trove17:42
*** rushiagr_ has quit IRC17:43
*** amcrn has joined #openstack-trove17:43
*** heitor has joined #openstack-trove17:56
*** heitor is now known as htrmeira17:56
*** htrmeira has quit IRC17:58
cp16netsweet i got the tests passing again18:09
cp16nethttps://rdjenkins.dyndns.org/job/multi-patch-test/26/?18:09
cp16nethttps://review.openstack.org/#/q/topic:bp/configuration-parameters-in-db,n,z18:10
cp16netw00t w00t18:10
*** Barker has joined #openstack-trove18:11
*** julienvey has quit IRC18:26
*** ViswaV has quit IRC18:27
*** ViswaV has joined #openstack-trove18:27
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985018:33
SlickNikcp16net: w00t! Nice job.18:34
*** kevinconway has joined #openstack-trove18:34
*** georgelorch has quit IRC18:40
*** ramishra has joined #openstack-trove18:40
*** georgelorch has joined #openstack-trove18:41
*** ViswaV has quit IRC18:42
*** james_li has joined #openstack-trove18:49
*** georgelorch has quit IRC18:49
*** georgelorch has joined #openstack-trove18:50
*** htrmeira has joined #openstack-trove18:55
*** Barker has quit IRC18:57
*** Barker has joined #openstack-trove19:03
*** ajayaa has quit IRC19:03
*** Barker has quit IRC19:07
*** julienvey has joined #openstack-trove19:13
*** tkatarki has joined #openstack-trove19:15
*** rwsu has quit IRC19:18
*** julienvey has quit IRC19:20
*** ViswaV has joined #openstack-trove19:22
*** julienvey has joined #openstack-trove19:22
*** ramishra has quit IRC19:23
openstackgerritamrith proposed a change to openstack/trove: guestagent/test_volume.py leaves a file in /tmp  https://review.openstack.org/11211819:30
*** tkatarki has quit IRC19:31
amrithSlickNik, ... https://review.openstack.org/#/c/112118/19:33
amriththx19:33
*** tvoran_ has joined #openstack-trove19:34
*** tvoran has quit IRC19:37
openstackgerritamrith proposed a change to openstack/trove: Logging audit for guestagent/redis  https://review.openstack.org/10780519:45
*** denis_makogon_ has joined #openstack-trove19:46
*** denis_makogon has quit IRC19:46
*** denis_makogon_ is now known as denis_makogon19:46
*** dmakogon_ has joined #openstack-trove19:46
openstackgerritamrith proposed a change to openstack/trove: Merge from oslo-incubator  https://review.openstack.org/11187019:52
*** rwsu has joined #openstack-trove19:54
*** IanGovett has quit IRC19:59
*** ViswaV has quit IRC20:03
*** michael-yu has quit IRC20:14
*** tvoran_ is now known as tvoran20:21
*** ViswaV has joined #openstack-trove20:25
openstackgerritamrith proposed a change to openstack/trove: Merge from oslo-incubator  https://review.openstack.org/11187020:26
openstackgerritCraig Vyvial proposed a change to openstack/trove: Datastore Configuration Parameters stored in db  https://review.openstack.org/7985020:26
*** boden has quit IRC20:33
*** james_li has quit IRC20:34
*** ViswaV has quit IRC20:36
*** james_li has joined #openstack-trove20:36
*** juantwo has quit IRC20:41
*** radez is now known as radez_g0n320:42
*** michael-yu has joined #openstack-trove20:43
amrithcp16net, yt?20:43
cp16netyeah what up20:43
amrithgot some tums. Greg's and your comment in https://review.openstack.org/#/c/112118/1 gave me some heartburn.20:44
amrithI don't think the proposal is 'nice'.20:44
amrithhere's why20:44
amriththe contract is that if you set 'deleted=true' the temp file is deleted 'ON CLOSE'20:44
*** htrmeira has quit IRC20:44
cp16netyeah20:45
amrithAnd I don't feel happy running install to copy a file that I'm holding open into /etc/fstab20:45
cp16nettab that exe over20:45
amrith;)20:45
cp16netput it in the with20:45
cp16netthen it will clean it up after its all done20:45
cp16netright/20:45
cp16net?20:45
amrithnot20:45
amrithso if I tab it in20:45
amrithexecute() will spawn a sub-process20:46
amrithto run install20:46
amrithand that install will try and copy which file?20:46
amriththe named temp file which I'm holding open20:46
amrithand potentially unflushed ;)20:46
amriththe last thing I want is a partial /etc/fstab20:46
amriththat would be yucky20:46
amrithnow, I doubt you'll have an /etc/fstab that is over a block20:46
cp16netyou could tempfstab.flush()20:46
cp16netthen exe?20:47
amrithbut the concept of holding a file open while copying it doesn't make me feel happy20:47
*** IanGovett has joined #openstack-trove20:47
amrithI'm sure we could do that20:47
amrithand it'll work fine20:47
amrithtill it fails ;)20:47
cp16netthats what the code is dont know tho is it not?20:47
amrithas it is seems straightforward20:47
amrithdon't get the last comment.20:47
cp16netso lets back up a min20:49
amrithok20:49
cp16netyou changed the exe to os.remove20:49
amrithyes20:49
*** julienvey has quit IRC20:49
cp16netbecause the exe statement wasnt cleaning up the file20:49
amrithwhen it was mocked20:49
amrithby the calling test20:49
amriththe calling test was mocking execute20:49
amriththerefore execute() wasn't actually getting called20:50
cp16netoh i c20:51
amrithhere's the offending code.20:51
amrithhttps://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_volume.py#L173-L18120:51
cp16netyeah i see what you mean20:51
* cp16net thinking20:51
cp16netgears are grinding20:51
amrithin fairness, I don't see the point of this test ;)20:52
amrithwhat's it testing?20:52
amriththat execute() was called twice?20:52
cp16netyeah and "test coverage"20:52
amrithhmmm20:53
amrithanyhow, that's why I changed it the way I did to the remove. I hadn't thought of what Greg and you suggested. But I'm not happy with that for the reasons I mentioned above.20:54
amrithit seems dubious.20:54
cp16netok i get it20:54
cp16netnow fix the tests ;-)20:54
amrithI don't think the test failure was because of my change ;)20:55
amrithbut I'll check20:55
cp16netcant tell20:56
cp16netsomething with the guest20:56
amrithproboscis.case.MethodTest (tearDown) ... ok20:57
amrithproboscis.case.MethodTest (setUp) ... ok20:57
amrithproboscis.case.MethodTest (test_create_user_and_dbs) ... ok20:57
amrithproboscis.case.MethodTest (test_no_access) ... ok20:57
amrithproboscis.case.MethodTest (test_grant_full_access) ... ok20:57
amrithproboscis.case.MethodTest (test_grant_ghostdbs) ... ok20:57
amrithproboscis.case.MethodTest (test_grant_ghostusers) ... ok20:57
amrithproboscis.case.MethodTest (test_grant_idempotence) ... ok20:57
amrithproboscis.case.MethodTest (test_revoke_all_access) ... ok20:57
amrithproboscis.case.MethodTest (test_revoke_ghostdbs) ... ok20:57
amrithproboscis.case.MethodTest (test_revoke_ghostusers) ... ok20:57
amrithproboscis.case.MethodTest (test_revoke_non_idempotence) ... ok20:57
amrithproboscis.case.MethodTest (test_revoke_one_database) ... ok20:57
amrithproboscis.case.MethodTest (test_grant_full_access_ignore_databases) ... ok20:57
amrithI'll check20:57
amrithnot sure why it failed jenkins. twice, for two different reasons.20:57
cp16netreddwarf tests failed21:01
cp16netlol21:01
* cp16net doesnt know21:01
cp16netsome times you have to hope you are up wind of ci21:01
cp16net:-P21:01
*** coolsvap has quit IRC21:08
*** pdmars has quit IRC21:13
*** coolsvap has joined #openstack-trove21:15
*** openstackgerrit has quit IRC21:16
*** openstackgerrit has joined #openstack-trove21:16
*** jasondotstar has quit IRC21:20
*** denis_makogon has quit IRC21:26
amrithint-tests passed on my pc ;)21:28
amrithwaiting for jenkins to bless21:28
*** boden has joined #openstack-trove21:38
*** tkatarki has joined #openstack-trove21:45
*** julienvey has joined #openstack-trove21:50
*** boden has quit IRC21:50
*** tkatarki has quit IRC21:50
*** julienvey has quit IRC21:54
*** julienvey has joined #openstack-trove22:22
*** julienvey has quit IRC22:27
*** juantwo has joined #openstack-trove22:30
*** juantwo has quit IRC22:30
*** juantwo has joined #openstack-trove22:30
*** mattgriffin has quit IRC22:56
*** kevinconway has quit IRC23:01
amrithcp16net, yt?23:22
amrithwaiting on your +1 now ...23:22
amriththx23:22
openstackgerritJoe Cruz proposed a change to openstack/trove: Add instance metadata functionality to trove  https://review.openstack.org/8212323:23
*** julienvey has joined #openstack-trove23:23
*** julienvey has quit IRC23:28
openstackgerritamrith proposed a change to openstack/trove: Move usage_timeout out of guest options  https://review.openstack.org/8704023:30
*** jcru has quit IRC23:31
*** achampion has quit IRC23:35
*** james_li has quit IRC23:54
openstackgerritA change was merged to openstack/trove: Sync service.py from oslo-incubator with deps  https://review.openstack.org/11071823:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!