| *** tvoran_ has quit IRC | 00:00 | |
| *** tvoran_ has joined #openstack-trove | 00:01 | |
| *** tvoran__ has joined #openstack-trove | 00:03 | |
| *** tvoran_ has quit IRC | 00:03 | |
| *** tvoran has quit IRC | 00:03 | |
| *** tvoran has joined #openstack-trove | 00:05 | |
| *** tvoran_ has joined #openstack-trove | 00:07 | |
| *** tvoran__ has quit IRC | 00:07 | |
| *** tvoran_ has quit IRC | 00:08 | |
| *** tvoran_ has joined #openstack-trove | 00:08 | |
| *** tvoran has quit IRC | 00:09 | |
| *** tvoran_ has quit IRC | 00:10 | |
| *** tvoran has joined #openstack-trove | 00:10 | |
| *** tvoran has quit IRC | 00:12 | |
| *** tvoran has joined #openstack-trove | 00:12 | |
| *** tvoran_ has joined #openstack-trove | 00:14 | |
| *** tvoran has quit IRC | 00:14 | |
| *** tvoran has joined #openstack-trove | 00:15 | |
| *** tvoran__ has joined #openstack-trove | 00:17 | |
| *** tvoran has quit IRC | 00:17 | |
| *** tvoran_ has quit IRC | 00:18 | |
| *** tvoran has joined #openstack-trove | 00:19 | |
| *** tvoran__ has quit IRC | 00:21 | |
| *** ramashri has quit IRC | 00:22 | |
| *** tvoran has quit IRC | 00:23 | |
| *** ramashri has joined #openstack-trove | 00:31 | |
| openstackgerrit | amrith proposed a change to openstack/trove: make backup_incremental_strategy a datastore specific option https://review.openstack.org/113155 | 01:03 |
|---|---|---|
| openstackgerrit | amrith proposed a change to openstack/trove: In some cases, guest agents may leave temporary config files https://review.openstack.org/112672 | 01:08 |
| openstackgerrit | amrith proposed a change to openstack/trove: Correct monkey patching in GuestAgentBackupTest https://review.openstack.org/112911 | 01:10 |
| openstackgerrit | amrith proposed a change to openstack/trove: Correct monkey patching in GuestAgentBackupTest https://review.openstack.org/112911 | 01:11 |
| openstackgerrit | amrith proposed a change to openstack/trove: Correct monkey patching in GuestAgentBackupTest https://review.openstack.org/112911 | 01:14 |
| amrith | denis_makogon, pdmars, iccha, cp16net, glucas at ur convenience please re-review https://review.openstack.org/#/c/112911/; I revised the commit message, and added the word "bug" before bug numbers | 01:14 |
| amrith | as recommended by denis_makogon so that they become links. | 01:15 |
| *** tvoran has joined #openstack-trove | 01:17 | |
| *** tvoran_ has joined #openstack-trove | 01:18 | |
| *** tvoran_ has quit IRC | 01:18 | |
| *** tvoran has quit IRC | 01:21 | |
| *** tvoran has joined #openstack-trove | 01:28 | |
| *** nosnos has joined #openstack-trove | 01:40 | |
| *** robertmyers has joined #openstack-trove | 01:54 | |
| *** ramashri has quit IRC | 02:11 | |
| *** ramashri has joined #openstack-trove | 02:15 | |
| *** tvoran has quit IRC | 02:55 | |
| *** robertmyers has quit IRC | 03:11 | |
| *** robertmyers has joined #openstack-trove | 03:19 | |
| *** tvoran has joined #openstack-trove | 03:20 | |
| *** nosnos has quit IRC | 03:22 | |
| *** tvoran has quit IRC | 03:32 | |
| *** tvoran has joined #openstack-trove | 03:33 | |
| *** robertmyers has quit IRC | 03:44 | |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Snapshot component for replication https://review.openstack.org/109687 | 03:45 |
| *** tvoran has quit IRC | 03:53 | |
| *** ramashri has quit IRC | 03:56 | |
| *** eghobo has joined #openstack-trove | 03:56 | |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Snapshot component for replication https://review.openstack.org/109687 | 03:59 |
| *** tvoran has joined #openstack-trove | 04:01 | |
| *** Barker has joined #openstack-trove | 04:06 | |
| *** nosnos has joined #openstack-trove | 04:10 | |
| *** Barker has quit IRC | 04:14 | |
| *** georgelorch has quit IRC | 04:42 | |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Augment Mysql status checking for replication https://review.openstack.org/112689 | 04:43 |
| *** georgelorch has joined #openstack-trove | 04:43 | |
| *** eghobo has quit IRC | 04:44 | |
| *** tvoran has quit IRC | 04:53 | |
| *** juantwo has quit IRC | 05:01 | |
| *** ViswaV has joined #openstack-trove | 05:01 | |
| *** sgotliv has joined #openstack-trove | 05:05 | |
| *** mrsnivvel has joined #openstack-trove | 05:15 | |
| *** Longgeek has joined #openstack-trove | 05:24 | |
| *** k4n0 has joined #openstack-trove | 05:38 | |
| *** tshefi_ has joined #openstack-trove | 05:39 | |
| *** denis_makogon_ has joined #openstack-trove | 05:43 | |
| *** robertmyers has joined #openstack-trove | 05:45 | |
| *** grapex_ has quit IRC | 05:46 | |
| *** robertmyers has quit IRC | 05:50 | |
| *** sgotliv has quit IRC | 05:54 | |
| *** grapex has joined #openstack-trove | 06:18 | |
| *** grapex has quit IRC | 06:26 | |
| *** zigo has quit IRC | 06:31 | |
| *** zigo has joined #openstack-trove | 06:36 | |
| *** ajayaa has joined #openstack-trove | 06:44 | |
| *** ViswaV has quit IRC | 06:52 | |
| *** grapex has joined #openstack-trove | 06:52 | |
| *** julienvey has joined #openstack-trove | 06:53 | |
| *** grapex has quit IRC | 06:57 | |
| *** robertmyers has joined #openstack-trove | 07:46 | |
| *** sgotliv has joined #openstack-trove | 07:48 | |
| *** rushiagr_away is now known as rushiagr | 07:48 | |
| *** robertmyers has quit IRC | 07:50 | |
| *** grapex has joined #openstack-trove | 07:53 | |
| *** grapex has quit IRC | 07:57 | |
| *** rushiagr is now known as rushiagr_away | 08:15 | |
| *** rushiagr_away is now known as rushiagr | 08:16 | |
| *** fifieldt__ has quit IRC | 08:16 | |
| *** fifieldt__ has joined #openstack-trove | 08:17 | |
| *** nosnos has quit IRC | 08:19 | |
| *** nosnos has joined #openstack-trove | 08:21 | |
| *** boblebauce has joined #openstack-trove | 08:28 | |
| *** rushiagr is now known as rushiagr_away | 08:29 | |
| *** boden has joined #openstack-trove | 08:41 | |
| *** k4n0 has quit IRC | 08:42 | |
| *** grapex has joined #openstack-trove | 08:53 | |
| *** grapex has quit IRC | 08:58 | |
| *** k4n0 has joined #openstack-trove | 08:59 | |
| *** ajayaa has quit IRC | 09:16 | |
| *** boblebauce has quit IRC | 09:19 | |
| *** ajayaa has joined #openstack-trove | 09:28 | |
| *** boblebauce has joined #openstack-trove | 09:39 | |
| *** Longgeek has quit IRC | 10:02 | |
| *** Longgeek has joined #openstack-trove | 10:03 | |
| *** Longgeek has quit IRC | 10:07 | |
| *** Longgeek has joined #openstack-trove | 10:07 | |
| *** ajayaa has quit IRC | 10:09 | |
| *** ramishra has joined #openstack-trove | 10:18 | |
| *** ramishra has quit IRC | 10:19 | |
| *** ramishra has joined #openstack-trove | 10:20 | |
| *** ajayaa has joined #openstack-trove | 10:25 | |
| *** k4n0 has quit IRC | 10:27 | |
| *** Longgeek has quit IRC | 10:32 | |
| *** Longgeek has joined #openstack-trove | 10:32 | |
| *** Longgeek has quit IRC | 10:32 | |
| *** Longgeek has joined #openstack-trove | 10:32 | |
| *** Longgeek has quit IRC | 10:36 | |
| *** sgotliv has quit IRC | 10:36 | |
| openstackgerrit | Li Ma proposed a change to openstack/trove: Port oslo.config.generator to automatically generate trove conf files https://review.openstack.org/113219 | 10:46 |
| *** ramishra has quit IRC | 10:49 | |
| *** rushiagr_away is now known as rushiagr | 10:51 | |
| openstackgerrit | Li Ma proposed a change to openstack/trove: Port oslo.config.generator to automatically generate trove conf files https://review.openstack.org/113219 | 10:54 |
| *** grapex has joined #openstack-trove | 10:54 | |
| *** Longgeek has joined #openstack-trove | 10:58 | |
| *** k4n0 has joined #openstack-trove | 10:59 | |
| *** grapex has quit IRC | 10:59 | |
| *** rushiagr is now known as rushiagr_away | 11:04 | |
| *** ramishra has joined #openstack-trove | 11:07 | |
| *** ramishra has quit IRC | 11:08 | |
| *** ramishra has joined #openstack-trove | 11:08 | |
| *** ramishra has quit IRC | 11:08 | |
| *** ramishra has joined #openstack-trove | 11:09 | |
| *** sgotliv has joined #openstack-trove | 11:12 | |
| *** sgotliv has quit IRC | 11:18 | |
| *** sgotliv has joined #openstack-trove | 11:18 | |
| *** IanGovett has joined #openstack-trove | 11:28 | |
| *** Longgeek has quit IRC | 11:29 | |
| *** Longgeek has joined #openstack-trove | 11:43 | |
| *** tkatarki has joined #openstack-trove | 12:02 | |
| *** tkatarki has quit IRC | 12:07 | |
| *** Longgeek has quit IRC | 12:12 | |
| *** juantwo has joined #openstack-trove | 12:13 | |
| *** Longgeek has joined #openstack-trove | 12:13 | |
| *** juantwo has quit IRC | 12:14 | |
| *** juantwo has joined #openstack-trove | 12:14 | |
| *** zigo has quit IRC | 12:17 | |
| *** zigo has joined #openstack-trove | 12:18 | |
| *** nosnos has quit IRC | 12:31 | |
| *** Barker has joined #openstack-trove | 12:39 | |
| *** tkatarki has joined #openstack-trove | 12:48 | |
| *** tkatarki has quit IRC | 12:50 | |
| *** Longgeek_ has joined #openstack-trove | 12:55 | |
| *** rushiagr_away is now known as rushiagr | 12:56 | |
| *** Longgeek has quit IRC | 12:59 | |
| openstackgerrit | Li Ma proposed a change to openstack/trove: Port oslo.config.generator to automatically generate trove conf files https://review.openstack.org/113219 | 13:00 |
| *** miqui has joined #openstack-trove | 13:22 | |
| *** tvoran has joined #openstack-trove | 13:35 | |
| *** tkatarki has joined #openstack-trove | 13:43 | |
| *** tkatarki has quit IRC | 13:55 | |
| *** tkatarki has joined #openstack-trove | 14:00 | |
| *** tvoran has quit IRC | 14:00 | |
| *** Riddhi has joined #openstack-trove | 14:11 | |
| *** Riddhi has quit IRC | 14:11 | |
| *** tkatarki has quit IRC | 14:18 | |
| *** tkatarki has joined #openstack-trove | 14:18 | |
| *** tvoran has joined #openstack-trove | 14:29 | |
| *** robertmyers has joined #openstack-trove | 14:30 | |
| *** pdmars has joined #openstack-trove | 14:31 | |
| *** k4n0 has quit IRC | 14:33 | |
| *** mattgriffin has joined #openstack-trove | 14:33 | |
| *** robertmyers has quit IRC | 14:34 | |
| *** rwsu has joined #openstack-trove | 14:34 | |
| *** robertmyers has joined #openstack-trove | 14:34 | |
| *** grapex has joined #openstack-trove | 14:34 | |
| *** ajayaa has quit IRC | 14:36 | |
| iccha | glucas: hello! | 14:42 |
| *** sgotliv has quit IRC | 14:46 | |
| *** tkatarki has quit IRC | 14:46 | |
| *** rushiagr is now known as rushiagr_away | 14:47 | |
| *** pdmars has quit IRC | 14:49 | |
| *** pdmars has joined #openstack-trove | 14:50 | |
| *** grapex__ has joined #openstack-trove | 14:52 | |
| *** james_li has joined #openstack-trove | 14:53 | |
| *** grapex has quit IRC | 14:55 | |
| *** zigo has quit IRC | 14:58 | |
| *** tkatarki has joined #openstack-trove | 14:58 | |
| *** radez_g0n3 is now known as radez | 14:58 | |
| *** zigo has joined #openstack-trove | 14:59 | |
| *** grapex__ has quit IRC | 15:00 | |
| *** ViswaV has joined #openstack-trove | 15:01 | |
| glucas | iccha: hi there | 15:07 |
| *** jmontemayor has joined #openstack-trove | 15:08 | |
| *** grapex has joined #openstack-trove | 15:09 | |
| iccha | glucas: yeah so it looked liek the replication.cnf changes were not applied. when i moved the config to my.cnf and restarted manuyally it worked. so checking out which inspite | 15:10 |
| iccha | includedirs why its not including the replication.cnf | 15:12 |
| iccha | thats my update on testing | 15:12 |
| *** jasondotstar has joined #openstack-trove | 15:14 | |
| *** jcru has joined #openstack-trove | 15:17 | |
| amrith | iccha, thanks for kicking my patchset with rdjenkins. I only changed the commit message ... | 15:18 |
| *** IanGovett has quit IRC | 15:19 | |
| iccha | amrith: yeah jenkins was failing for no reason, thats why rekicked it | 15:23 |
| *** ramashri has joined #openstack-trove | 15:23 | |
| *** tshefi_ has quit IRC | 15:24 | |
| *** grapex has quit IRC | 15:29 | |
| *** ViswaV has quit IRC | 15:29 | |
| *** ViswaV has joined #openstack-trove | 15:30 | |
| *** ViswaV has quit IRC | 15:31 | |
| *** Riddhi has joined #openstack-trove | 15:34 | |
| *** kevinconway has joined #openstack-trove | 15:45 | |
| *** ramishra_ has joined #openstack-trove | 15:50 | |
| *** rushiagr_away is now known as rushiagr | 15:51 | |
| *** ramishra has quit IRC | 15:51 | |
| *** ajayaa has joined #openstack-trove | 15:52 | |
| *** tvoran has quit IRC | 16:03 | |
| *** tvoran has joined #openstack-trove | 16:04 | |
| *** tvoran has quit IRC | 16:04 | |
| *** tvoran has joined #openstack-trove | 16:05 | |
| *** ramishra_ has quit IRC | 16:19 | |
| *** openstack has joined #openstack-trove | 16:32 | |
| *** robertmyers has quit IRC | 16:37 | |
| *** robertmyers has joined #openstack-trove | 16:38 | |
| *** IanGovett has joined #openstack-trove | 16:42 | |
| *** amcrn has joined #openstack-trove | 16:42 | |
| *** ViswaV has joined #openstack-trove | 16:43 | |
| *** ViswaV_ has joined #openstack-trove | 16:44 | |
| *** ViswaV has quit IRC | 16:48 | |
| SlickNik | Hey guys. | 16:59 |
| *** boblebauce has quit IRC | 16:59 | |
| SlickNik | We don't have any items on the agenda for the BP meeting today (https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting#Aug_11_Meeting) | 16:59 |
| cp16net | nope | 17:00 |
| SlickNik | So I'm planning to cancel, so that folks can have the hour back. | 17:01 |
| cp16net | sounds like a plan | 17:01 |
| cp16net | SlickNik: so if i recall you moved all the test groups to trove right? | 17:01 |
| *** grapex has joined #openstack-trove | 17:02 | |
| SlickNik | cp16net: Just the trove related ones. (There was an extension / dns related one that was part of trove-int that I left there, IIRC) | 17:02 |
| SlickNik | cp16net: So that now when we need to add a new test group for a new feature, we only need to make the changes in one repo. | 17:03 |
| cp16net | ok | 17:03 |
| *** julienvey has quit IRC | 17:06 | |
| *** zacksh has quit IRC | 17:16 | |
| *** zacksh has joined #openstack-trove | 17:17 | |
| *** ViswaV_ has quit IRC | 17:17 | |
| iccha | thanks SlickNik | 17:21 |
| *** ViswaV has joined #openstack-trove | 17:21 | |
| iccha | glucas: vgnbkr added some comments on the review | 17:21 |
| iccha | good work guys | 17:21 |
| iccha | we are getting so close :) | 17:21 |
| *** jcru has quit IRC | 17:22 | |
| glucas | iccha: Getting there... | 17:23 |
| *** jcru has joined #openstack-trove | 17:23 | |
| denis_makogon_ | glucas, i've added 6 cases when given implementation wouldn't work, so, could you please address them asap ? | 17:29 |
| *** ViswaV has quit IRC | 17:30 | |
| glucas | denis_makogon: I'm looking those over, agreed there are failure cases we are not currently checking for. | 17:31 |
| denis_makogon_ | glucas, the most interesting question is, who's rule "slave of id" or "backup id" ? | 17:33 |
| glucas | denis_makogon_: Right... We had some discussion early on about whether it should be possible to create a replication slave from an existing backup; or whether we should always take a snapshot of the master. | 17:35 |
| denis_makogon_ | glucas, the valid way - take backup once it's needed, since we could fall into inconsistent state | 17:36 |
| denis_makogon_ | glucas, master has X data, but slave was restored from backup that contains X-1 data | 17:37 |
| *** Longgeek_ has quit IRC | 17:37 | |
| glucas | denis_makogon_: Right, so that would imply that if you pass 'slave of' we ignore 'backup id' and create a new backup. | 17:39 |
| glucas | (or warn/error, not necessarily ignore) | 17:40 |
| denis_makogon_ | glucas, sure, for cursory glance looks valid | 17:40 |
| *** tvoran has quit IRC | 17:41 | |
| *** amcrn has quit IRC | 17:46 | |
| openstackgerrit | Greg Lucas proposed a change to openstack/trove: Fix debug log message causing error https://review.openstack.org/113328 | 17:49 |
| amrith | denis_makogon, since you are online, got any new thoughts on https://review.openstack.org/#/c/112911/? | 17:51 |
| *** grapex has quit IRC | 17:53 | |
| *** amcrn has joined #openstack-trove | 17:54 | |
| *** amcrn has quit IRC | 17:57 | |
| *** amcrn has joined #openstack-trove | 18:03 | |
| *** boblebauce has joined #openstack-trove | 18:05 | |
| denis_makogon_ | amrith, what about "Fix setUp/tearDown workflow for GuestAgentBackupTest" ? | 18:06 |
| *** ViswaV has joined #openstack-trove | 18:06 | |
| *** ViswaV_ has joined #openstack-trove | 18:07 | |
| *** esp has joined #openstack-trove | 18:08 | |
| amrith | Do you have any suggestions about the code itself? | 18:08 |
| denis_makogon_ | amrith, no, code looks more than cool | 18:09 |
| amrith | ok, so your only objection is with the commit message title. you don't like "correct monkey patching in <test name>" | 18:09 |
| denis_makogon_ | amrith, only commit title needs to be re-worded | 18:09 |
| denis_makogon_ | amrith, yes | 18:09 |
| amrith | well, with all due respect, that's your opinion. | 18:09 |
| amrith | you can't (I don't believe) point to anything wrong with this commit message, you are proposing another commit message that may work just as well. Is that all? | 18:10 |
| amrith | If that's the case, I thank you for your review of the code. | 18:11 |
| amrith | we can agree to disagree about the commit message. | 18:11 |
| *** ViswaV has quit IRC | 18:11 | |
| peterstac | denis_makogon: Your message is also too long: #link https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure | 18:11 |
| denis_makogon_ | peterstac, nope, hacking allows to use commit titles up to 71, 50 is recommended, but not strongly restricted | 18:14 |
| amrith | denis_makogon_, I'm not very good at all this but I think it says "The first line should be limited to 50 characters and should not end with a period". | 18:14 |
| denis_makogon_ | amrith, you can take a look at hacking code | 18:15 |
| *** tvoran has joined #openstack-trove | 18:15 | |
| amrith | In any event, I will update the bug with the comment that your sole objection is to the commit title, and for that you believe that it is proper to -1 the change. thanks. | 18:15 |
| denis_makogon_ | amrith, in this case, yes. thanks | 18:16 |
| *** georgelorch has quit IRC | 18:16 | |
| *** georgelorch has joined #openstack-trove | 18:17 | |
| *** coolsvap has quit IRC | 18:17 | |
| amrith | denis_makogon_, thank you for your input. | 18:18 |
| denis_makogon_ | amrith, thank you too | 18:19 |
| vipul | why are we arguing about commit messages :D | 18:21 |
| *** grapex_ has joined #openstack-trove | 18:22 | |
| peterstac | vipul: +1 | 18:22 |
| vipul | honestly... let's just review patches for code.. if the bots don't complain about the other fluff.. i personally don't care about fixing them | 18:22 |
| vipul | denis_makogon, amrith ^ | 18:23 |
| amrith | vipul, ostensibly because the code appears fine | 18:23 |
| amrith | and there's a -1 sitting on the review | 18:23 |
| *** coolsvap has joined #openstack-trove | 18:23 | |
| amrith | I wasn't sure whether denis had objections to the code or not, and honestly the change I'm making appears simple but the more eyes I can get on the code, the better. | 18:24 |
| amrith | cp16net, iccha and pdmars looked at the code last week | 18:24 |
| amrith | and it seemed fine | 18:24 |
| vipul | denis_makogon_ we talked about this at the summit.. a commit message is not deserving of a -1 | 18:24 |
| amrith | but denis_makogon_ had comments on the review (again on the commit message). | 18:24 |
| amrith | and I tried to fix them | 18:24 |
| amrith | but I can't seem to win. | 18:24 |
| amrith | if it isn't this verbiage, then it's the other verbiage that's not acceptable | 18:25 |
| amrith | first it was "not monkey patch" call it a "stub" | 18:25 |
| amrith | ok, once I disproved that theory | 18:25 |
| amrith | it was change the title to "what you are doing". | 18:25 |
| amrith | I'd like to get this hunk of code in so that we can finally put to rest the myriad of failures we've had on gate | 18:26 |
| amrith | pdmars' change addressed part of it. | 18:26 |
| amrith | this is the other half | 18:26 |
| denis_makogon_ | vipul, of course, i was there, and i remember, if commit message/title doesn't reflect actual changes - it should be updated, thought | 18:26 |
| vipul | come on guys.. we have a backlog of changes that never seems to go down.. and we're just making the problem worse? | 18:26 |
| amrith | and it's hung up because we can't seem to get agreement on grammar. | 18:26 |
| amrith | vipul, I agree. | 18:26 |
| amrith | what would you like me to do? | 18:26 |
| amrith | I'll do it. | 18:26 |
| denis_makogon_ | nobody looking for trouble here =) | 18:26 |
| vipul | denis_makogon please remove the -1.. you can object to verbiage or whatever, but don't put a -1 | 18:27 |
| vipul | put a 0 | 18:27 |
| vipul | cores can decide whether that actually needs to be changed or not | 18:27 |
| denis_makogon_ | vipul, done, but i feel concerned about commit title | 18:28 |
| vipul | yep, that's the point of the 'comment' section.. voice concerns over those things.. | 18:29 |
| iccha | denis_makogon_: i know you have the best intentions, but generally when we have comments which are subjective or just out opinion which doesnt impact functonality of code, it is recommended to have 0 and write comments | 18:31 |
| cp16net | i agree with vipul | 18:31 |
| amrith | vipul, iccha, cp16net +1 ... | 18:32 |
| grapex_ | amrith +1 to vipul iccha and cp16net's +1 | 18:32 |
| dougshelley66 | grapex_, +1 | 18:32 |
| vipul | i'm glad we all agree :D | 18:33 |
| vipul | thanks for changing it denis_makogon_ | 18:33 |
| amrith | now, if only jenkins would cooperate and put a +1 on the change (which hasn't changed since Friday) maybe we can all get it emrged? | 18:33 |
| amrith | ;) | 18:33 |
| *** ajayaa has quit IRC | 18:39 | |
| iccha | glucas: any concerns/questions over the comments made in review? | 18:42 |
| *** rushiagr is now known as rushiagr_away | 18:44 | |
| *** ViswaV_ has quit IRC | 18:54 | |
| amrith | anyone know what's up with zuul? jobs have been hanging around for 6+ hours now ... | 18:59 |
| glucas | iccha: No, I think the comments are clear, thanks. On the volume size vs data size thing, you're not concerned that the volume on the master might be largely empty and we reject what would be a valid attempt to create a smaller volume slave? | 19:04 |
| iccha | glucas: so the assumption i am making is someone has assigned say a 2GB volume because they expect the data to grow that much | 19:05 |
| iccha | instead of having to resize the slaves we want to make sure they handle the growth of data on master | 19:05 |
| iccha | but its not a hard concern | 19:05 |
| iccha | that was just my thinking | 19:05 |
| glucas | iccha: OK, thanks. | 19:13 |
| *** grapex_ has quit IRC | 19:14 | |
| amrith | hello folks, could I get some eyes on this trivial review. It is a regression; I broke this while doing the guestagent audit logging stuff. glucas has also just hit it. https://review.openstack.org/#/c/112634/ | 19:18 |
| amrith | thx iccha | 19:19 |
| iccha | thank you for quick turn around and fixing bugs amrith :) | 19:19 |
| amrith | in this case, it is pottery barn rules, right? | 19:20 |
| cp16net | amrith: i just approved it | 19:20 |
| cp16net | i cant beleive you missed that! j/k | 19:20 |
| amrith | cp16net, thx | 19:20 |
| kevinconway | amrith: i don't like the commit message | 19:21 |
| robertmyers | hahaha | 19:21 |
| cp16net | kevinconway: +2 :-P | 19:21 |
| glucas | amrith, cp16net: thanks, I just abandoned the changeset and closed a duplicate bug I had raised for the same thing. | 19:21 |
| cp16net | glucas: np | 19:22 |
| amrith | glucas, you could review my change now ;) | 19:22 |
| glucas | amrith: too late, it's already approved! | 19:22 |
| *** james_li has quit IRC | 19:25 | |
| glucas | so actually, a question about that one... When I run tox things worked fine, but running e.g. nosetests I was getting a test failure (VolumeDeviceTest) for that. | 19:26 |
| amrith | but glucas ... your approval means so much to me (where's the heart emoticon) | 19:26 |
| iccha | <3 | 19:26 |
| glucas | I guess tox is not enabling debug logging... | 19:26 |
| iccha | the irc way | 19:26 |
| *** jmontemayor_ has joined #openstack-trove | 19:26 | |
| amrith | ah, that's how ... good to know | 19:26 |
| amrith | glucas, yes. if you recall this was where I hit it a couple of days ago | 19:27 |
| amrith | when we were running nose | 19:27 |
| amrith | was it Friday? | 19:27 |
| kevinconway | amrith: sounds like you had a cold | 19:27 |
| amrith | YOUCH! | 19:27 |
| amrith | I didn't realize "when we were running nose" could come out that way ;) | 19:27 |
| *** jmontemayor has quit IRC | 19:27 | |
| amrith | not runny nose ... | 19:27 |
| cp16net | i hope your nose didnt out run you | 19:28 |
| iccha | glucas: it must be a pain rebasing the snapshot code with the guest agent because of all the naming changes | 19:28 |
| cp16net | that would be embarassing | 19:28 |
| amrith | cp16net, you've seen me. a golf cart can out run me. for that matter, a parked car can outrun me. | 19:29 |
| glucas | iccha: Yes indeed! Also the various 'logging audits' are a pain. | 19:29 |
| glucas | would be great to get at least that base patch set merged. | 19:29 |
| iccha | yeah i agree glucas | 19:30 |
| iccha | i think we are very close | 19:30 |
| iccha | and maybe set an acceptable level and we can change other things in future patches | 19:30 |
| iccha | i am yet to get it running on my box, thats all I am waiting for | 19:31 |
| dougshelley66 | iccha, I just set it up today and got a master and slave going pretty quickly | 19:32 |
| dougshelley66 | iccha, are you trying something more than that, at this piont | 19:32 |
| iccha | dougshelley66: are yall using the reddwarf vm? | 19:32 |
| dougshelley66 | yes; i'm using redstack/devstack on vm workstation | 19:33 |
| dougshelley66 | iccha, sorry vmware workstation | 19:33 |
| vgnbkr | iccha, are you by any chance using a different version of mysql? | 19:34 |
| iccha | yes using 5.6 | 19:35 |
| iccha | also i would really like us to use hostnames instead of ips | 19:35 |
| vgnbkr | Ah, maybe that's why the .cnf stuff didn't work for you? | 19:35 |
| iccha | yeah debugging that vgnbkr | 19:35 |
| dougshelley66 | iccha, i was using 5.5 | 19:35 |
| *** jmontemayor_ has quit IRC | 19:36 | |
| dougshelley66 | iccha, did you try it will 5.5 at all? | 19:36 |
| iccha | dougshelley66: not yet, maybe i should | 19:36 |
| dougshelley66 | iccha, might be good to see if you can get it going with the version we had been developing with | 19:37 |
| *** grapex has joined #openstack-trove | 19:38 | |
| *** ramashri has quit IRC | 19:39 | |
| *** jmontemayor has joined #openstack-trove | 19:40 | |
| *** flaper87|afk is now known as flaper87 | 19:40 | |
| *** james_li has joined #openstack-trove | 19:45 | |
| *** achampion has joined #openstack-trove | 19:59 | |
| *** james_li has quit IRC | 20:06 | |
| *** boden has quit IRC | 20:10 | |
| amrith | folks on core, https://review.openstack.org/#/c/112911/ has been blessed by Jenkins and Red Dwarf. Before they change their mind, would you please review ... | 20:12 |
| *** flaper87 is now known as flaper87|afk | 20:14 | |
| *** ramashri has joined #openstack-trove | 20:20 | |
| openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Sync Kombu Reconnect Patch from Oslo https://review.openstack.org/107829 | 20:22 |
| iccha | glucas: i found out what was wrong | 20:29 |
| iccha | dougshelley66: | 20:29 |
| iccha | we set replication.cnf to 711 , but it should be 744 | 20:29 |
| iccha | the mysql process was not able to read it | 20:29 |
| glucas | iccha: interesting, not sure why that is different in your testing than in ours. | 20:31 |
| iccha | 711 gives it execution not read | 20:31 |
| glucas | The existing code for overrides uses 711 as well. | 20:32 |
| glucas | Do overrides not work for you either? | 20:32 |
| *** ramashri has quit IRC | 20:32 | |
| iccha | i dont have anything in my overrudes file | 20:33 |
| iccha | so it never got tested | 20:33 |
| *** james_li has joined #openstack-trove | 20:33 | |
| *** ramashri has joined #openstack-trove | 20:33 | |
| *** amcrn has quit IRC | 20:33 | |
| *** amcrn has joined #openstack-trove | 20:33 | |
| glucas | iccha: OK, we can take a look. Still wondering why it works fine here. | 20:34 |
| *** miqui has quit IRC | 20:35 | |
| iccha | glucas: so apparently we(rs) run the guestagent as trove and openstack runs it as root | 20:36 |
| iccha | thats why i ran into it | 20:36 |
| glucas | iccha: bingo, that makes sense | 20:36 |
| iccha | phew! | 20:36 |
| *** radez is now known as radez_g0n3 | 20:38 | |
| *** james_li has quit IRC | 20:38 | |
| glucas | iccha: thanks for tracking it down. :) | 20:40 |
| *** james_li has joined #openstack-trove | 20:51 | |
| *** pdmars has quit IRC | 20:59 | |
| *** juantwo has quit IRC | 21:01 | |
| *** ramashri has quit IRC | 21:26 | |
| *** amcrn has quit IRC | 21:26 | |
| *** ramashri has joined #openstack-trove | 21:26 | |
| *** amcrn has joined #openstack-trove | 21:27 | |
| *** ramashri has quit IRC | 21:28 | |
| *** ramashri has joined #openstack-trove | 21:28 | |
| *** tkatarki has quit IRC | 21:32 | |
| *** ViswaV has joined #openstack-trove | 21:33 | |
| *** ViswaV has quit IRC | 21:34 | |
| *** ViswaV has joined #openstack-trove | 21:34 | |
| *** tkatarki has joined #openstack-trove | 21:37 | |
| iccha | team work for the win glucas ! :) | 21:44 |
| iccha | glucas: ping me whenever u have the new patch up , will keep testing | 21:44 |
| *** robertmyers has quit IRC | 21:44 | |
| *** demorris has joined #openstack-trove | 21:45 | |
| *** grapex has quit IRC | 21:48 | |
| *** ViswaV has quit IRC | 21:52 | |
| *** eghobo has joined #openstack-trove | 21:57 | |
| *** ViswaV has joined #openstack-trove | 22:01 | |
| *** ViswaV_ has joined #openstack-trove | 22:02 | |
| *** arist has quit IRC | 22:05 | |
| *** ViswaV has quit IRC | 22:06 | |
| *** arist has joined #openstack-trove | 22:06 | |
| *** james_li has quit IRC | 22:15 | |
| *** james_li has joined #openstack-trove | 22:19 | |
| *** achampion has quit IRC | 22:21 | |
| *** tkatarki has quit IRC | 22:22 | |
| *** demorris has quit IRC | 22:22 | |
| *** tkatarki has joined #openstack-trove | 22:28 | |
| *** eguz has joined #openstack-trove | 22:30 | |
| *** eghobo has quit IRC | 22:33 | |
| *** mattgriffin has quit IRC | 22:37 | |
| *** juantwo has joined #openstack-trove | 22:39 | |
| *** denis_makogon_ has quit IRC | 22:39 | |
| *** juantwo has quit IRC | 22:40 | |
| *** juantwo has joined #openstack-trove | 22:41 | |
| *** tkatarki has quit IRC | 22:43 | |
| *** ViswaV has joined #openstack-trove | 22:45 | |
| *** ViswaV_ has quit IRC | 22:45 | |
| *** james_li has quit IRC | 22:48 | |
| *** eguz has quit IRC | 22:51 | |
| *** eghobo has joined #openstack-trove | 22:54 | |
| *** eghobo has quit IRC | 23:00 | |
| *** eghobo has joined #openstack-trove | 23:00 | |
| *** Riddhi has quit IRC | 23:05 | |
| *** Riddhi has joined #openstack-trove | 23:06 | |
| *** Riddhi has quit IRC | 23:07 | |
| *** Riddhi has joined #openstack-trove | 23:08 | |
| *** Riddhi has quit IRC | 23:13 | |
| *** ViswaV has quit IRC | 23:19 | |
| *** ViswaV_ has joined #openstack-trove | 23:19 | |
| *** kevinconway has quit IRC | 23:19 | |
| *** jmontemayor has quit IRC | 23:21 | |
| *** ViswaV_ has quit IRC | 23:23 | |
| SlickNik | glucas / iccha: thanks for soldiering on with the replication patches. | 23:24 |
| SlickNik | My macbook died on me this morning, and I've been running around trying to figure out what to do about it. | 23:25 |
| *** tkatarki has joined #openstack-trove | 23:26 | |
| *** boblebauce has quit IRC | 23:27 | |
| *** achampion has joined #openstack-trove | 23:32 | |
| *** mattgriffin has joined #openstack-trove | 23:33 | |
| *** tkatarki has quit IRC | 23:36 | |
| *** boblebauce has joined #openstack-trove | 23:39 | |
| *** mattgriffin has quit IRC | 23:54 | |
| *** jcru has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!