Wednesday, 2014-08-27

*** amcrn has quit IRC00:00
*** tkatarki has quit IRC00:00
*** tkatarki has joined #openstack-trove00:02
*** ramashri has quit IRC00:03
*** georgelorch has quit IRC00:08
*** ramashri has joined #openstack-trove00:10
*** ViswaV has quit IRC00:11
*** tkatarki has quit IRC00:14
*** tkatarki has joined #openstack-trove00:14
*** annashen has joined #openstack-trove00:25
*** georgelorch has joined #openstack-trove00:37
*** vkmc has quit IRC00:41
*** Barker has joined #openstack-trove00:49
*** grapex has joined #openstack-trove00:50
*** Barker has quit IRC00:52
*** annashen has quit IRC00:53
*** grapex has quit IRC00:54
*** jasonb365 has joined #openstack-trove00:55
*** ViswaV has joined #openstack-trove00:57
*** ViswaV has quit IRC00:59
*** todd_dsm has joined #openstack-trove01:00
*** ViswaV has joined #openstack-trove01:00
*** tkatarki has quit IRC01:05
*** ramashri has quit IRC01:09
*** Riddhi has joined #openstack-trove01:10
*** ramashri has joined #openstack-trove01:10
*** RicoLin has joined #openstack-trove01:23
*** eghobo has quit IRC01:25
*** eghobo has joined #openstack-trove01:26
*** topshare has joined #openstack-trove01:29
*** shakamunyi has quit IRC01:29
*** annashen has joined #openstack-trove01:30
*** annashen has quit IRC01:32
*** topshare has quit IRC01:33
*** jasonb365 has quit IRC01:34
*** shakamunyi has joined #openstack-trove01:36
*** ViswaV has quit IRC01:40
*** topshare has joined #openstack-trove01:50
*** todd_dsm has quit IRC01:52
*** eguz has joined #openstack-trove01:54
*** eguz has quit IRC01:54
*** todd_dsm has joined #openstack-trove01:55
*** Riddhi has quit IRC01:56
*** nosnos has joined #openstack-trove01:56
*** eghobo has quit IRC01:58
*** topshare has quit IRC01:59
*** topshare has joined #openstack-trove02:03
*** topshare has quit IRC02:03
*** todd_dsm has quit IRC02:15
*** ramashri has quit IRC02:18
*** todd_dsm has joined #openstack-trove02:19
*** todd_dsm has quit IRC02:20
*** jasonb365 has joined #openstack-trove02:25
*** edmund has joined #openstack-trove02:26
*** haomaiwang has joined #openstack-trove02:27
*** haomaiwang has quit IRC02:34
*** haomaiwang has joined #openstack-trove02:35
*** haomai___ has joined #openstack-trove02:43
*** harlowja is now known as harlowja_away02:44
*** haomaiwang has quit IRC02:46
*** nosnos has quit IRC03:23
*** Riddhi has joined #openstack-trove03:24
*** nosnos has joined #openstack-trove03:24
*** nosnos has quit IRC03:28
*** harlowja_away has quit IRC03:29
*** annashen has joined #openstack-trove03:39
*** grapex has joined #openstack-trove03:51
*** nosnos has joined #openstack-trove03:53
*** grapex has quit IRC03:56
*** eghobo has joined #openstack-trove04:04
*** eghobo has quit IRC04:12
*** georgelorch has quit IRC04:14
*** ramishra has joined #openstack-trove04:17
*** jasonb365 has quit IRC04:19
*** Riddhi has quit IRC04:26
*** todd_dsm has joined #openstack-trove04:26
*** georgelorch has joined #openstack-trove04:29
*** eghobo has joined #openstack-trove04:42
*** ramishra has quit IRC04:46
*** ramishra has joined #openstack-trove04:46
*** ramishra has quit IRC04:48
*** ramishra has joined #openstack-trove04:49
zhiyanamrith: he! still around?04:50
*** ajayaa has joined #openstack-trove05:02
*** juantwo has quit IRC05:07
*** ViswaV has joined #openstack-trove05:32
*** ViswaV_ has joined #openstack-trove05:33
*** ViswaV has quit IRC05:36
*** todd_dsm has quit IRC05:51
*** grapex has joined #openstack-trove05:52
*** haomai___ has quit IRC05:53
*** grapex has quit IRC05:57
*** k4n0 has joined #openstack-trove05:59
*** vigneshvar has joined #openstack-trove06:01
*** ajayaa has quit IRC06:05
*** ramishra has quit IRC06:11
*** ramishra has joined #openstack-trove06:12
*** flaper87|afk is now known as flaper8706:15
*** Longgeek has joined #openstack-trove06:20
*** haomaiwang has joined #openstack-trove06:20
*** julienvey has joined #openstack-trove06:24
*** ajayaa has joined #openstack-trove06:26
*** ramishra has quit IRC06:41
*** dkehn_ has quit IRC06:43
*** dkehnx has quit IRC06:43
*** eghobo has quit IRC06:44
*** dkehn has joined #openstack-trove06:44
*** dkehn_ has joined #openstack-trove06:45
*** grapex has joined #openstack-trove06:53
*** grapex has quit IRC06:57
*** nosnos has quit IRC07:04
*** nosnos_ has joined #openstack-trove07:04
*** freyes has quit IRC07:09
*** freyes has joined #openstack-trove07:10
*** sgotliv has joined #openstack-trove07:14
*** dkehn_ has quit IRC07:31
*** dkehn has quit IRC07:32
*** ViswaV_ has quit IRC07:35
*** ViswaV has joined #openstack-trove07:45
*** ViswaV has quit IRC07:54
*** shakayumi has joined #openstack-trove08:01
*** mikehn_ has joined #openstack-trove08:03
*** blipp_ has joined #openstack-trove08:04
*** imsplitb1t has joined #openstack-trove08:05
*** dmakogon_ has joined #openstack-trove08:06
*** annashen has quit IRC08:08
*** SergeyLukjanov2 has joined #openstack-trove08:09
*** shakamunyi has quit IRC08:10
*** mikehn has quit IRC08:10
*** RicoLin has quit IRC08:10
*** blipp has quit IRC08:10
*** denis_makogon has quit IRC08:10
*** imsplitbit has quit IRC08:10
*** SergeyLukjanov has quit IRC08:10
*** SergeyLukjanov2 is now known as SergeyLukjanov08:10
*** iartarisi has joined #openstack-trove08:14
*** haomaiwang has quit IRC08:14
*** haomaiwang has joined #openstack-trove08:15
*** RicoLin has joined #openstack-trove08:15
*** RicoLin has quit IRC08:15
*** RicoLin has joined #openstack-trove08:16
*** boblebauce has joined #openstack-trove08:17
*** flaper87 is now known as flaper87|afk08:17
*** Longgeek has quit IRC08:20
*** Longgeek has joined #openstack-trove08:21
*** haomaiw__ has joined #openstack-trove08:24
*** Longgeek has quit IRC08:25
*** haomaiwang has quit IRC08:27
*** haomaiw__ has quit IRC08:29
*** haomaiwang has joined #openstack-trove08:35
*** shakayumi has quit IRC08:40
*** dkehn has joined #openstack-trove08:42
*** Longgeek has joined #openstack-trove08:43
*** nosnos_ has quit IRC08:45
*** dkehn_ has joined #openstack-trove08:45
*** nosnos has joined #openstack-trove08:46
*** nosnos has quit IRC08:50
*** isviridov|away is now known as isviridov08:51
*** grapex has joined #openstack-trove08:54
*** grapex has quit IRC08:59
*** shakayumi has joined #openstack-trove09:06
*** shakayumi has quit IRC09:10
*** nosnos has joined #openstack-trove09:11
*** blipp_ has quit IRC09:12
*** haomaiwang has quit IRC09:25
*** blipp has joined #openstack-trove09:26
*** blipp has quit IRC09:32
*** blipp has joined #openstack-trove09:32
*** haomaiwang has joined #openstack-trove09:37
*** Longgeek has quit IRC09:50
*** sgotliv has quit IRC09:52
*** rushiagr_away is now known as rushiagr09:58
*** shakayumi has joined #openstack-trove10:06
amrithzhiyan, yes ...10:09
*** shakayumi has quit IRC10:11
*** Longgeek has joined #openstack-trove10:16
*** sgotliv has joined #openstack-trove10:27
*** rushiagr is now known as rushiagr_away10:30
*** Longgeek has quit IRC10:32
*** sgotliv has quit IRC10:40
*** flaper87|afk is now known as flaper8710:47
*** tkatarki has joined #openstack-trove10:48
*** sgotliv has joined #openstack-trove10:54
*** Longgeek has joined #openstack-trove11:00
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-trove11:01
*** tkatarki has quit IRC11:02
*** haomaiwang has quit IRC11:05
*** dmakogon_ is now known as denis_makogon11:05
*** haomaiwang has joined #openstack-trove11:05
denis_makogoniccha, glucas i filed another one bug for snapshotting, see https://bugs.launchpad.net/trove/+bug/136206211:06
*** haomaiwa_ has joined #openstack-trove11:06
*** shakayumi has joined #openstack-trove11:07
*** haomaiwang has quit IRC11:10
*** shakayumi has quit IRC11:11
*** flaper87 is now known as flaper87|afk11:14
*** nosnos has quit IRC11:20
*** tkatarki has joined #openstack-trove11:20
*** nosnos has joined #openstack-trove11:20
*** flaper87|afk is now known as flaper8711:23
*** IanGovett has joined #openstack-trove11:24
*** tkatarki has quit IRC11:24
*** nosnos has quit IRC11:25
*** tkatarki has joined #openstack-trove11:32
*** ramishra has joined #openstack-trove11:33
*** tkatarki has quit IRC11:42
*** flaper87 is now known as flaper87|afk11:42
*** flaper87|afk is now known as flaper8711:44
*** ramishra has quit IRC11:53
*** ramishra has joined #openstack-trove11:54
*** grapex has joined #openstack-trove11:55
*** ramishra has quit IRC11:58
*** grapex has quit IRC12:00
*** achampion has quit IRC12:03
*** achampion has joined #openstack-trove12:03
*** tkatarki has joined #openstack-trove12:03
*** shakayumi has joined #openstack-trove12:08
*** juantwo has joined #openstack-trove12:08
*** ajayaa has quit IRC12:08
*** vkmc has joined #openstack-trove12:09
*** juantwo has quit IRC12:10
*** juantwo has joined #openstack-trove12:10
*** shakayumi has quit IRC12:12
*** flaper87 is now known as flaper87|afk12:14
*** tkatarki has quit IRC12:17
*** tkatarki has joined #openstack-trove12:18
*** flaper87|afk is now known as flaper8712:18
*** sgotliv has quit IRC12:19
*** sgotliv has joined #openstack-trove12:20
*** Isotopp_ is now known as Isotopp12:23
*** ajayaa has joined #openstack-trove12:29
*** tkatarki has quit IRC12:30
*** tkatarki has joined #openstack-trove12:31
*** tkatarki has quit IRC12:32
*** PierreRambaud has quit IRC12:36
*** GoT has joined #openstack-trove12:36
vigneshvaramrith: hi.12:38
*** todd_dsm has joined #openstack-trove12:39
vigneshvaramrith: i just need few minutes of your time when you are free . To discuss on https://review.openstack.org/#/c/112532/12:43
vigneshvaramrith: will try to discuss with nick when he is available12:43
*** grapex has joined #openstack-trove12:56
*** topshare has joined #openstack-trove12:57
*** grapex has quit IRC13:01
*** achampion has quit IRC13:01
*** jasondotstar has joined #openstack-trove13:02
*** shakayumi has joined #openstack-trove13:08
zhiyanamrith: hey!13:11
zhiyanamrith: when you ok could pls help review osprofiler trove integration change ? =)13:11
zhiyanamrith: https://review.openstack.org/#/c/116653/ ^^13:12
*** ajayaa has quit IRC13:13
*** shakayumi has quit IRC13:13
*** Barker has joined #openstack-trove13:26
*** GoT is now known as PierreRambaud13:26
*** ajayaa has joined #openstack-trove13:32
*** pdmars has joined #openstack-trove13:38
amrithvigneshvar, ping ...13:38
amrithzhiyan, ping ...13:38
zhiyanamrith: hi =)13:39
*** shakayumi has joined #openstack-trove13:40
amrithzhiyan, I will look at the patch. I'm kind-of unsure about it, first what value it brings, second whether there is sufficient information for me to try it out and actually see the thing in action.13:40
amrithzhiyan, I will definitely try and look at the patch today. I'm on the hook for some changes in the next day or so, as soon as I can get those submitted I promise to look at this and other reviews.13:40
zhiyanamrith: sure, pls try it. then i believe you can see the benefits ^13:41
*** vigneshvar has quit IRC13:41
zhiyanamrith: and thanks13:41
*** shakayumi is now known as shakamunyi13:41
zhiyanamrith: if you got any blocker, pls let ping me, i can give a quick feedback to help try it out normally13:42
*** jasonb365 has joined #openstack-trove13:43
*** robertmyers has joined #openstack-trove13:44
amrithzhiyan, is there some documentation I should be reading13:44
zhiyanamrith: yep, probably i think you can take a glance at the bp/idea proposal in oslo-spec13:45
zhiyan1 sec13:45
zhiyanamrith: https://review.openstack.org/#/c/103825/ ^13:46
zhiyanamrith: btw, currently Glance and Cinder projects have already integrated with it.13:47
zhiyanamrith: the change for other projects is wip13:47
zhiyanlike trove =) and heat13:47
*** mattgriffin has joined #openstack-trove13:48
*** robertmyers has quit IRC13:48
*** tomblank has joined #openstack-trove13:54
*** achampion has joined #openstack-trove13:54
*** robertmyers has joined #openstack-trove13:56
*** shakamunyi has quit IRC13:58
*** edmund has quit IRC13:59
*** ajayaa has quit IRC14:03
*** ajayaa has joined #openstack-trove14:04
*** topshare has quit IRC14:05
*** topshare has joined #openstack-trove14:07
*** shakamunyi has joined #openstack-trove14:11
*** ajayaa has quit IRC14:16
*** iccha_ has joined #openstack-trove14:19
iccha_glucas: i have some bandwidth so let me know if i can help with any of the replication bugs14:19
*** jcru has joined #openstack-trove14:20
*** shakamunyi has quit IRC14:22
*** shakamunyi has joined #openstack-trove14:23
*** iccha_ has quit IRC14:35
*** Riddhi has joined #openstack-trove14:39
*** robertmy_ has joined #openstack-trove14:39
*** shakamunyi has quit IRC14:40
*** jmontemayor has joined #openstack-trove14:40
*** juantwo has quit IRC14:40
*** juantwo has joined #openstack-trove14:40
*** kevinconway has joined #openstack-trove14:40
*** tomblank has quit IRC14:41
*** robertmyers has quit IRC14:42
*** juantwo has quit IRC14:43
*** juantwo has joined #openstack-trove14:43
*** grapex has joined #openstack-trove14:44
denis_makogoniccha, i guess we're free to take any of those14:44
denis_makogonglucas, iccha are you there ?14:45
denis_makogonglucas, iccha, i know the way in which we can deal with users/schemes, volume/flavors whe attempting to create a slave14:47
denis_makogonglucas, iccha, we can provide another one client call that would be used to create a slave, but under the hood this call is nothing else than simple POST against /instances route (create call)14:49
*** jmontemayor has quit IRC14:49
denis_makogonthis would give an ability to reduce amount of additional validation logic to Trove API14:50
*** tomblank has joined #openstack-trove14:50
glucasdenis_makogon: you mean a variation of create without all the usual options?14:50
denis_makogonglucas, yes14:50
*** jmontemayor has joined #openstack-trove14:51
denis_makogonglucas, it'll work for all of us and will eliminate lots of filed bugs14:53
denis_makogonglucas, sorry, if this idea was proposed at mid-cycle meeting, i wan't aware of it since there's no report14:53
*** openstackgerrit has joined #openstack-trove14:54
*** todd_dsm has quit IRC14:54
*** mattgriffin has quit IRC14:54
*** flaper87 is now known as flaper87|afk14:56
*** flaper87|afk is now known as flaper8714:56
*** Longgeek has quit IRC14:56
*** vigneshvar has joined #openstack-trove14:56
*** mattgriffin has joined #openstack-trove14:58
glucasdenis_makogon: no, that wasn't discussed.15:00
denis_makogonglucas, great =)15:01
*** edmund has joined #openstack-trove15:02
glucasdenis_makogon: would have to look at how different the set of args would be. We did discuss that it is a legitimate use case to make a slave with a smaller volume or flavor than than the master.15:02
glucase.g. read slaves won't have all the same logs, won't need as much ram, etc15:02
denis_makogonglucas, agreed, user should be able to pass at least different flavor, not sure about volume15:03
glucasbut we do want to prevent creating users or schemas as part of a slave create15:03
*** topshare has quit IRC15:05
openstackgerritamrith proposed a change to openstack/trove: Update contributing.rst to include guidelines on Code Review  https://review.openstack.org/11577815:05
glucasiccha, vgnbkr, SlickNik: ^^ be curious what others think about a 'replica-create' command with different arg validation that calls down to the existing create impl.15:06
denis_makogonglucas, my proposal perfectly fits into it =)15:06
*** topshare has joined #openstack-trove15:07
*** topshare has quit IRC15:07
*** topshare has joined #openstack-trove15:08
*** dkehn has quit IRC15:16
*** tkatarki has joined #openstack-trove15:17
*** georgelorch has quit IRC15:18
*** georgelorch has joined #openstack-trove15:18
denis_makogonglucas, i found another one bug15:19
denis_makogonglucas, what happening when we're deleting root master ?15:19
*** dkehn__ has joined #openstack-trove15:19
denis_makogonglucas, according to given code, correct me if i'm wrong, we would have N detached slaves that are useless, right ?15:19
*** spiffxp- has quit IRC15:19
*** achampion has quit IRC15:22
*** peoplemerge has quit IRC15:22
*** spiffxp_ has joined #openstack-trove15:22
*** dkehn__ is now known as dkehnx15:22
*** Longgeek has joined #openstack-trove15:22
*** achampion has joined #openstack-trove15:22
*** peoplemerge has joined #openstack-trove15:22
*** Longgeek has quit IRC15:22
amrithvigneshvar, yt?15:23
*** kevinconway has quit IRC15:23
vigneshvaramrith: yes15:25
amrithvigneshvar, hello.15:25
amrithI'm looking at your chkin15:25
vigneshvaramrith: hi. Ya i guess i got deviated15:26
amrithaccording to this chkin, you are adding HTTP_PROXY.15:26
amrithshould it be added for ALL sudo's?15:26
vigneshvaramrith: i have thought about it but felt it must added to places where only network related stuff is going on15:27
vigneshvaramrith: Like nick said i think my patch does not satisfy the bug15:28
amrithI see15:28
amrithyes15:28
amrithI think I understand the issue that SlickNik is raising15:28
vigneshvaramrith: should i open another bug, and apply the current patch15:29
amrithno, you don't need to open another bug15:30
amrithLet me review the other commit (94892). i read it a long time ago and don't know exactly what that fix proposed15:30
*** juice has quit IRC15:30
amrithI'll ping you after.15:30
vigneshvaramrith: sure thanks for your time15:31
amrithno problem. happy to help15:31
vigneshvaramrith: just a doubt, like http_proxy variable, no_proxy nbeeds to be set by the user himself ? or should that be automated15:32
amrithGood question, I don't know for sure but I think the setting should be automated.15:32
vigneshvaramrith: ok sure i will look from that askpect thanks15:32
amrithwill check what is being attempted and ping you.15:32
vigneshvaramrith: ok :)15:33
amrithOne thing I'd suggest is that you review the old chkins that the other person proposed.15:33
*** annashen has joined #openstack-trove15:33
glucasdenis_makogon: I wouldn't call that a bug really... But there is currently no special handling for this case.15:33
amrithmaybe that'll give you an indication of what he/she was thinking.15:33
denis_makogonglucas, take a look at how we deal with incremental backups while deleting one from the chain, so i think that this is a bug15:34
*** openstack has joined #openstack-trove16:18
*** ViswaV has joined #openstack-trove16:21
*** eghobo has joined #openstack-trove16:22
*** eghobo has quit IRC16:23
*** eghobo has joined #openstack-trove16:23
*** georgelorch has quit IRC16:25
*** annashen has quit IRC16:26
*** jasonb365 has quit IRC16:28
icchaglucas: SlickNik do you want to sometime today touchbase on the high priorty replication bugs and see if there is an order we would like to work on them? also if we want to distribute the work16:32
openstackgerritDenis M. proposed a change to openstack/trove: Apply recursive initial master lookup while replica provisioning  https://review.openstack.org/11729816:33
*** boblebauce has left #openstack-trove16:33
glucasdenis_makogon: backups are a bit different, right? You're not doing a cascading delete of running instances that may have clients connected.16:33
icchadenis_makogon: should we even allow recurrsive calls?16:33
denis_makogonglucas, but if you're deleting master - you'r getting into trouble =)16:33
denis_makogoniccha, sure16:34
denis_makogoniccha, about backup - of course, because incremental sequence matters16:34
denis_makogoniccha, same thing is for replication set, if we're deleting master, we should delete all slaves once and for all16:35
denis_makogonglucas, iccha, SlickNik, you can count on me, i'd like to help with those bugs16:35
openstackgerritDenis M. proposed a change to openstack/trove: Apply recursive initial master lookup while replica provisioning  https://review.openstack.org/11729816:37
openstackgerritDenis M. proposed a change to openstack/trove: Fix master status validation while replica provisioning  https://review.openstack.org/11725516:37
*** georgelorch has joined #openstack-trove16:37
jedixIs there a way to remove a datastore from trove with trove-manage?16:37
icchaawesome thanks denis_makogon16:37
icchadenis_makogon: i dont know if we should delete them or dettach them, can u add ur bugs to etherpad denis16:38
*** ViswaV has quit IRC16:39
icchaglucas: also i know ur changing name to replica but since api call is merged we cant change it in reponse16:40
iccha*repsonse16:40
denis_makogoniccha, i didn't file it yet, just wanted to ask glucas before doing that16:40
*** kevinconway has joined #openstack-trove16:41
denis_makogoniccha, i'm leaving, gonna be too late today, so i'm going to miss meeting =(16:41
denis_makogoniccha, API is not released yet16:41
denis_makogoniccha, so we can change everything we want before H316:42
denis_makogonJ316:42
denis_makogoncu, guys, later16:42
icchagotcha thanks denis_makogon . yeah we dont have in todays meeting agenda uyet. whenevr u re free add your thoughts to etherpad. maybe new subtitle needs to be prioritized16:42
*** rushiagr_away is now known as rushiagr16:43
*** kevinconway has quit IRC16:45
icchathe api did get merged denis_makogon glucas https://review.openstack.org/#/c/105758/16:45
*** georgelorch has quit IRC16:45
jedixHow do I specify a volume size for trove create?  I'm getting "ERROR: Volume size was not specified."16:46
icchajedix: are u using the client16:46
*** todd_dsm has joined #openstack-trove16:46
icchajedix: if yes --size 116:47
jedixiccha: I am16:47
jedixwhat is the unit of size?16:47
jedixsigh, status == error.16:48
icchajedix: size is in gb16:48
icchajedix: do u have cinder running for volumes16:48
glucasjedix:  --size <size>   Size of the instance disk volume in GB.16:48
jedixiccha: yes.16:49
jedixChecking for db [id=d76cd864-840a-4f87-bd87-5839fdf0c706, compute_instance_id=None]16:49
icchajedix: restart service cinder-volume restart16:49
jedixCannot find compute instance None for instance16:49
jedixiccha: how do I restart an instance in ERROR state?  it's saying it's not ready when I run trove restart <id>16:51
icchajedix: yeah u cannot restart an instance in error status16:51
icchajedix:  u ll have to delete it and create a new one16:51
jedixiccha: okay, thanks16:52
jedixiccha: is there a way to verify cinder connectivity?16:52
jedixCannot find compute instance None for instance16:52
jedix(again)16:52
icchajedix: u can look at logs16:53
icchaand see where it is erroring16:53
jedixthat's what the log says..16:55
jedixcannot find compute instance None16:55
icchajedix: can u look at nova-compute logs16:56
icchagrep for error16:56
jedixiccha: no errors there..16:57
icchajedix: can u look cinder logs16:57
*** vigneshvar has quit IRC16:57
*** jcru has quit IRC16:57
*** tomblank has quit IRC16:57
jedixoh wow.. yeah, there's errors there.16:58
*** georgelorch has joined #openstack-trove16:58
*** jcru has joined #openstack-trove16:59
*** jcru has quit IRC17:04
*** harlowja has joined #openstack-trove17:04
openstackgerritGreg Lucas proposed a change to openstack/trove: Add detach-replica support  https://review.openstack.org/10198117:04
*** ViswaV has joined #openstack-trove17:06
*** tomblank has joined #openstack-trove17:08
*** georgelorch has quit IRC17:09
*** jmontemayor has quit IRC17:12
*** mattgriffin has quit IRC17:15
*** ViswaV has quit IRC17:19
glucasiccha: Your earlier comment about slave vs. replica -- are you saying that because we have a merged commit we can no longer make an API change? I was expecting that we could continue to do so for Juno since the code is unreleased (and noone could actually have been using this API until a few days ago, if at all...)17:20
*** jmontemayor has joined #openstack-trove17:21
*** georgelorch has joined #openstack-trove17:21
openstackgerritGreg Lucas proposed a change to openstack/trove: Add detach-replica support  https://review.openstack.org/10198117:25
*** saurabhs has joined #openstack-trove17:25
*** arborism has joined #openstack-trove17:26
*** arborism has quit IRC17:26
*** amcrn has joined #openstack-trove17:27
*** jcru has joined #openstack-trove17:28
*** tomblank has quit IRC17:29
*** annashen has joined #openstack-trove17:32
*** jcru has quit IRC17:32
SlickNikiccha: +1 about quickly catching up on where we are with the bugs. Is after this morning's Trove meeting a good time for you guys?17:39
SlickNik^replication related bugs.17:39
SlickNikalso glucas / iccha: I think we're okay to fast follow with a quick API change if we feel like that's the right thing to do — since this code hasn't yet been released.17:40
*** mattgriffin has joined #openstack-trove17:49
*** tomblank has joined #openstack-trove17:51
openstackgerritamrith proposed a change to openstack/trove: In some cases, guest agents may leave temporary config files  https://review.openstack.org/11267217:52
*** ViswaV has joined #openstack-trove17:56
*** ViswaV_ has joined #openstack-trove17:57
*** ranjitha has joined #openstack-trove17:57
icchaSlickNik: yes lets sync up after trove meeting17:58
*** kevinconway has joined #openstack-trove17:58
*** jcru has joined #openstack-trove18:00
*** ViswaV has quit IRC18:00
*** jasonb365 has joined #openstack-trove18:02
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367518:03
*** vigneshvar has joined #openstack-trove18:03
openstackgerritSteve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM  https://review.openstack.org/8624218:06
*** Barker has quit IRC18:07
openstackgerritAuston McReynolds proposed a change to openstack/python-troveclient: Clusters troveclient Implementation  https://review.openstack.org/11371018:08
*** Barker has joined #openstack-trove18:10
*** robertmy_ is now known as robertmyers18:11
*** sriram_tesora has joined #openstack-trove18:14
*** rushiagr is now known as rushiagr_away18:16
openstackgerritMat Lowery proposed a change to openstack/trove: Clusters TaskManager Implementation  https://review.openstack.org/11369218:21
*** RicoLin has quit IRC18:21
openstackgerritRamashri Umale proposed a change to openstack/trove: Clusters Guest Implementation  https://review.openstack.org/11372818:24
*** ViswaV_ has quit IRC18:32
*** esp has left #openstack-trove18:33
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367518:33
icchaSlickNik: looks like the blueprint associated with this review dispappeared https://review.openstack.org/#/c/107117/18:34
icchacant find it18:34
openstackgerritSimon Chang proposed a change to openstack/trove: Fixed database migration script issues  https://review.openstack.org/11358218:34
SlickNikiccha: huh. That's very weird.18:34
icchaSlickNik: ok found it https://blueprints.launchpad.net/trove/+spec/per-datastore-volume-support it needs to be targetted18:38
icchaits already merged18:38
icchajust wanted to make sure it is included18:39
*** vigneshvar has quit IRC18:39
*** annashen has quit IRC18:40
icchaSlickNik: glucas around to talk about https://etherpad.openstack.org/p/trove-replication-bugs ?18:41
glucasdougshelley66: ^^18:41
dougshelley66glucas, i'm here18:42
SlickNikiccha: yes, one sec.18:42
*** zigo has quit IRC18:43
*** Barker has quit IRC18:43
*** annashen has joined #openstack-trove18:44
SlickNikiccha: when I try to create a bp, it tells me that one with the same name exists. But if I search for it, nothing comes up.18:45
icchaSlickNik: yeah i had the same issue. finnaly dug up link from my emails18:46
*** harlowja has quit IRC18:46
SlickNikHere it is: https://blueprints.launchpad.net/trove/+spec/per-datastore-volume-support18:46
*** zigo has joined #openstack-trove18:46
*** harlowja has joined #openstack-trove18:46
icchaSlickNik: thanks, wanted to  make sure its approved and targetted since the code is already merged18:47
icchabtw SlickNik tomblank is our new manager. forgot to introduce during the meeting :)18:47
SlickNikYup, thanks for that. Approved, and targeted appropriately now.18:48
SlickNikHi tomblank!18:48
tomblankhey SlickNik….18:48
dougshelley66Hi tomblank18:48
openstackgerritamrith proposed a change to openstack/trove: In some cases, guest agents may leave temporary config files  https://review.openstack.org/11267218:48
tomblankHey dougshelley66 and all18:49
*** julienvey has quit IRC18:51
*** sgotliv has joined #openstack-trove18:53
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367518:54
*** ViswaV has joined #openstack-trove18:54
*** todd_dsm has quit IRC19:02
*** georgelorch has quit IRC19:04
openstackgerritMat Lowery proposed a change to openstack/trove: Clusters TaskManager Implementation  https://review.openstack.org/11369219:05
*** annashen has quit IRC19:08
*** Barker has joined #openstack-trove19:09
icchaglucas: vgnbkr is there any of the bugs assined to yall you would like me to pick up ?19:10
openstackgerritRamashri Umale proposed a change to openstack/trove: Clusters Guest Implementation  https://review.openstack.org/11372819:10
dougshelley66iccha, yes19:10
dougshelley66can you take the metadata one19:11
dougshelley66https://bugs.launchpad.net/trove/+bug/135936319:11
icchasure dougshelley6619:11
dougshelley66thx19:11
icchadougshelley66: also i spoke to some of my managers and they said deleting backup is not a priority for now if we want to focus on other bugs19:13
*** denis_makogon_ has joined #openstack-trove19:13
dougshelley66iccha, i would have thought for a cloud provider not leaving the backup around would be important but thanks for the info19:14
denis_makogon_glucas, iccha https://bugs.launchpad.net/trove/+bug/136229919:14
denis_makogon_SlickNik, around?19:15
vgnbkrApparently it also reflects poorly in Horizon having all these useless "backups" showing up.19:15
icchadougshelley66: that doesnt mean we dont do it :) just in comparison to marking slave read only and replication password bugs19:15
dougshelley66iccha, ok thanks for the clarification19:16
icchavgnbkr: dougshelley66 i am all for doing it though19:16
denis_makogon_vgnbkr, we can add some sort of flag/description to backup entity to mark it as "replication use only"19:16
dougshelley66iccha, would you like to take the delete backup one?19:17
vgnbkrdenis_makogon_: Sure, but wouldn't it be just as easy to delete them?19:17
icchasure dougshelley6619:17
denis_makogon_vgnbkr, sure19:17
denis_makogon_iccha, dougshelley66, one comment about deleting backup19:18
denis_makogon_iccha, dougshelley66, i'd suggest to remove use of user quotas, since backup appears to be alive very short period of time19:18
denis_makogon_glucas, would you take this one https://bugs.launchpad.net/trove/+bug/1362299 ?19:19
icchadenis_makogon_: vgnbkr dougshelley66 i say we we forbid deletes on a master unless user has detached all slaves19:20
denis_makogon_if noone has objections i'd like to take this one - Snapshot on incremental backup on existing backup19:20
*** georgelorch has joined #openstack-trove19:21
denis_makogon_iccha, sound ok for me19:21
*** PeterSchwaller has joined #openstack-trove19:22
denis_makogon_iccha, glucas, dougshelley66, what about API call for "replica-delete <master_id> ?19:22
vgnbkrI suggest keeping user quotas.  The snapshots, though transient, could be huge and exist for weeks.19:22
denis_makogon_vgnbkr, snapshot exists only if it's not deleted19:23
denis_makogon_vgnbkr, i guess we've planned to drop snapshot once slave is up, right?19:24
vgnbkrdenis_makogon_: right, but it could take weeks to take a backup then restore it.19:24
*** grapex has quit IRC19:24
denis_makogon_vgnbkr, in this case, completely agreed19:24
*** grapex has joined #openstack-trove19:24
icchadenis_makogon_: vgnbkr do we want to make it optional to keep the backup around then?19:25
*** PeterSchwaller__ has quit IRC19:25
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367519:25
vgnbkrdenis_makogon_: I've already been giving thought to the incremental snapshot and it is my idea.  Do you mind if I see it through?19:25
denis_makogon_does only once consider on adding tests for mysql bulk load and do testing for backups/replication ?19:26
denis_makogon_*any one19:26
denis_makogon_vgnbkr, of course19:26
dougshelley66denis_makogon, SlickNik, iccha, vgnbkr, glucas we should make a decision around the replica_* apis19:26
vgnbkriccha: I have no problem with keeping the snapshot/backup around, but wonder if it would really be useful.19:26
vgnbkrdenis_makogon_: thanks.19:26
denis_makogon_vgnbkr, np19:27
icchadenis_makogon_: vgnbkr we are talking about a lot of things parallel. do we want to quickly scan the etherpad in order?19:27
icchahttps://etherpad.openstack.org/p/trove-replication-bugs19:27
denis_makogon_iccha, vgnbkr, dougshelley66 lets do this19:27
dougshelley66iccha, i think we are good with the first 519:28
icchadougshelley66: and one on time outs as well?19:28
vgnbkrCan everyone fill in their name on that etherpad?19:28
denis_makogon_so, if everyone is ok with first 519:28
dougshelley66so the "Different usage..." and the "Method that pulls"19:28
dougshelley66they are somewhat related19:28
* SlickNik is back and looking at the etherpad19:29
denis_makogon_dougshelley66, i agree, since "different usage" states about proposing additional polling timeout for restoring, and "method that pulls" talking about changing the type of API call (from call to cast)19:31
icchafor backup metadat one anyone have prefer for what kind of metadata is added?19:31
denis_makogon_dougshelley66, they are all about timeouts19:31
dougshelley66denis_makogon, right, that is why i puinted that out19:31
vgnbkriccha: What sort of backup metadata do you require?  You suggested that just having "replication" in the name or description was not sufficient, but I don't recall why.19:32
icchavgnbkr: just so billing can look at a specific field in the notification19:33
*** denis_makogon has quit IRC19:33
*** denis_makogon_ is now known as denis_makogon19:33
*** dmakogon_ has joined #openstack-trove19:34
denis_makogoniccha, i've just helped me to remind what we have missed - notifications19:34
glucassorry folks, was pulled away for something else.. catching up on dsicussion here / etherpad19:39
*** todd_dsm has joined #openstack-trove19:40
denis_makogondougshelley66, SlickNik, glucas, vgnbkr, guys, what about adding API call that deletes whole replication set?19:41
denis_makogonfor now to delete replication set we need to detach all slaves, delete them, then delete the master19:41
icchadenis_makogon: i think thats the safer ption19:41
icchaso the user is aware of the consequences of deleting the master19:42
*** ranjitha has quit IRC19:42
icchamanually detaching everything first should be the recommded behavior in my opinion19:42
SlickNikiccha: +1, I agree.19:42
denis_makogoniccha, as i can forsee, we need both cases19:42
SlickNikdenis_makogon: For replication (at least for async mysql replication), the mental model is disparate instances sharing some data.19:43
openstackgerritMat Lowery proposed a change to openstack/trove: Clusters TaskManager Implementation  https://review.openstack.org/11369219:43
SlickNikThere really isn't a concept of a "set" — that sort of mental modal is more suited for clustering imho.19:44
openstackgerritAuston McReynolds proposed a change to openstack/python-troveclient: Clusters troveclient Implementation  https://review.openstack.org/11371019:44
denis_makogonSlickNik, but it's too close to read scale out replica set19:44
dougshelley66ok i will type over here19:45
dougshelley66so for https://bugs.launchpad.net/trove/+bug/1362062 are we going to do the huge=maxint thing as a workaround?19:46
denis_makogondougshelley66, as temp solution19:46
dougshelley66because i think the proper fix is larger than we have time for in J19:46
glucasdougshelley66: +119:46
denis_makogoni feel concerned not having one API call that eliminates master and its deps, because of need to delete 3 node replica we need to use 2 calls to detach, 3 calls to delete19:47
SlickNikdougshelley66: I'd be okay with that fix in Juno, but we should track the issue for Kilo.19:47
denis_makogonSlickNik, ++19:47
dougshelley66SlickNik, agreed19:48
*** todd_dsm has quit IRC19:48
glucasdenis_makogon: I think we need the 'atomic' blocks of the API to be right, users can always script multi-step actions (and we can layer them in to the API later)19:48
dougshelley66do we need a new bug for that? is the temp/workaround fixed un https://bugs.launchpad.net/trove/+bug/136206219:48
glucasdenis_makogon: similar arguments were made when we originally proposed creating multiple slaves in one call.19:49
denis_makogonglucas, muliple create call can cause lots of troubles, but how can delete call for all of them can cause something bad ?19:50
icchadenis_makogon: you lose data19:50
SlickNikdenis_makogon: There really isn't a concept of an entity called a "set" in this case, so what resource do you call the delete against? IMO it murkies the API.19:50
*** sgotliv has quit IRC19:50
dougshelley66SlickNik, +119:50
denis_makogonok19:51
dougshelley66So do we all think we have a handle on the "High" list?19:51
icchayeah looks good to me19:52
SlickNikgoing through it again right now, one sec.19:52
*** julienvey has joined #openstack-trove19:52
SlickNikLooks good to me.19:52
dougshelley66SlickNik, how would you like to track the workaround and the Kilo work for it?19:53
SlickNikOf that list, I think I'd like the slave - replica terminology one merge before juno-3, but the rest of the bugsfixes can come before the RC is cut.19:53
SlickNik^glucas, I think you're already aware, but just in case.19:54
denis_makogoniccha, https://bugs.launchpad.net/trove/+bug/1362299 i already filed bug for you19:54
icchathanks denis_makogon19:54
denis_makogoniccha, np19:54
SlickNikdougshelley66: File a bugs for the Kilo work, and I'll triage and assign it to trove-next (until kilo is created).19:55
jedixIs there no way to drop the Legacy MySQL datastore?19:55
dougshelley66ok so vgnbkr filed a bug for the workaround; we will then move the "Method..." item and discussion lower on the list19:55
glucasSlickNik: OK, I'll work on that!19:55
denis_makogonjedix, nope, sorry19:55
jedixdenis_makogon: np,  Is there a way to set the default one?19:55
jedixinstead of having to do --datastore <id> every time?19:56
denis_makogonjedix, yes, there's a option for Trove API service, called defaul_datastore19:56
*** julienvey has quit IRC19:56
denis_makogonif it's not mentioned we don't have to use --datastore19:56
jedixit tells me I have to when I try to create something19:57
SlickNikdougshelley66: what's the bug for the workaround that vgnbkr filed?19:57
dougshelley66it is on the etherpad19:58
dougshelley66https://bugs.launchpad.net/trove/+bug/136231019:58
*** todd_dsm has joined #openstack-trove19:58
denis_makogonjedix, have you updated conf file for trove-api?19:58
*** jmontemayor has quit IRC20:00
jedixupdated since when?  I'm using git id c9173f22e91c1f15179a8163b6c4748d53db4f0f20:00
jedixdenis_makogon: I did just add default_datastore postgresql to my trove.conf and that seems to have fixed my issue20:00
jedix(I'm using postgresql + kevinconway patch set 13)20:00
*** jmontemayor has joined #openstack-trove20:00
dougshelley66SlickNik, since you have the other timeout one do you want to take this one20:01
denis_makogonjedix, that's what i've said - add default_datastore to trove.conf20:01
denis_makogonSlickNik, are there any plans to write meetup report ?20:01
SlickNikdougshelley66: Sure I can take care of this as well.20:01
dougshelley66SlickNik, thx20:01
dougshelley66SlickNik, while i have you on the line :) can you triage this one: https://bugs.launchpad.net/trove/+bug/136138920:01
*** tomblank_ has joined #openstack-trove20:02
jedixdenis_makogon: oh, I was looking for trove-api <command>20:02
SlickNikdenis_makogon: I'm in the process of writing one — plan to send it out this evening.20:02
jedixdenis_makogon: thanks!20:02
denis_makogonjedix, np20:02
*** tomblank has quit IRC20:02
*** tomblank_ is now known as tomblank20:02
denis_makogonSlickNik, sound awesome20:02
denis_makogon*sounds20:02
*** sgotliv has joined #openstack-trove20:02
SlickNikdougshelley66: We should probably involve the folks from RAX in the conversation for that — since they made the call to not delete the tables on downgrade in the first place, I want to make sure we're not overlooking anything.20:03
dougshelley66SlickNik, ok makes sense - schang should talk to cp16net20:04
SlickNik^ cp16net / grapex20:04
*** kevinconway has quit IRC20:04
*** jmontemayor has quit IRC20:05
*** jmontemayor has joined #openstack-trove20:08
*** kevinconway has joined #openstack-trove20:08
*** esp has joined #openstack-trove20:10
*** todd_dsm has quit IRC20:12
*** ViswaV has quit IRC20:15
openstackgerritGreg Lucas proposed a change to openstack/trove: Add detach-replica support  https://review.openstack.org/10198120:16
cp16netsure20:18
cp16neti'm here20:18
cp16neti'm catching up...20:18
schangcp16net: This bug was created and stating config tables should be dropped on downgrade https://bugs.launchpad.net/trove/+bug/1361389.20:18
schangcp16net: The main reason behind the dropping table proposal is that the config tables may contain corrupted data, which may cause subsequent issues on upgrades and therefore should be dropped on downgrade.20:19
schangcp16net: I notice you implemented the original downgrade code. Can you provide insights? Thanks!20:19
cp16netOH...20:19
cp16netyeah i recall why we decided that20:20
cp16netwe thought at the time if we needed to backout of the configurations we didnt want to delete all the user's config groups they created20:21
cp16netseems a bit destructive20:21
*** todd_dsm has joined #openstack-trove20:22
schangcp16net: But the other downgrade scripts are dropping the tables being created, and some of those tables too contain user created data (e.g. 012_backup.py). Your thoughts?20:27
*** sgotliv has quit IRC20:27
openstackgerritRiddhi Shah proposed a change to openstack/trove: Associate flavor types with datastore versions  https://review.openstack.org/10982420:27
cp16netschang: i think now that configurations has been used for a while and deployed i doubt that there is a need to rollback like it was when we first merged the feature20:28
schangcp16net: so I guess it's OK to proceed with dropping the config tables on downgrade as proposed?20:32
cp16neti dont see an issue with it. (we wont be dropping those tables) :)20:32
denis_makogonSlickNik, could you please take a look ? https://bugs.launchpad.net/trove/+bug/136231820:33
cp16netschang: if there was another person that poked at the configs alot was amcrn20:34
amcrnschang: we've avoided dropping the tables for quite a few schema upgrades; we pivoted on our thinking probably in the late teens (015_ and onward)20:35
*** pdmars has quit IRC20:39
*** georgelorch has quit IRC20:46
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367520:47
schangamcrn: I just double checked, the create_tables in upgrade for all 31 migration scripts are paired with drop_tables in downgrade. Am I missing something?20:48
amcrnschang: we haven't added a new table in a long time :)20:49
amcrnif you've got corrupted data, just drop the table manually20:49
schangamcrn: also, the dropping doesn't seem to be new (015_ and onward), it's pretty consistant across the board.20:49
*** ranjitha has joined #openstack-trove20:50
amcrnschang: for example, in our clusters in-flight patch, it doesn't make sense that on a downgrade you drop the entire table; there's no way to reconstruct the data20:51
vgnbkrEither way, the upgrade needs to work.  If you don't want to have the downgrade delete tables, then the upgrade needs to do more than just ignore exceptions.20:52
*** julienvey has joined #openstack-trove20:53
vgnbkrThe upgrade needs to validate the existence of the tables, their shape, and the validity of any data existing in the tables.20:54
*** julienvey has quit IRC20:54
*** julienvey has joined #openstack-trove20:54
*** juantwo has quit IRC20:55
amcrnvgnbkr: if you want to write a 300 line upgrade script, go for it ;)20:56
amcrnfairly impossible considering the existing constraints aren't named20:56
amcrnyou'd have to write some pretty in-depth logic to assert everything20:56
schangamcrn: We also have been adding tables recently ... the most recent one is at 028, where the new_agent_heartbeats table is added, and that migration script also drops the table on downgrade.20:57
amcrnschang: heartbeat data can be dropped and rebuilt within 3 seconds20:57
amcrnor whatever the heartbeat push interval is (i don't remember)20:58
*** ViswaV has joined #openstack-trove20:59
*** julienvey has quit IRC20:59
vgnbkramcrn: Right, that's why we suggested deleting the tables.  How is it acceptable to have upgrade methods that silently fail, or leave corrupted data generated by errors in future versions?21:00
amcrnit's probably also worth mentioning that i've never met a single person that has done a downgrade in production21:00
vgnbkrGreat, then let's get rid of the downgrade functionality and have the upgrade methods work properly.21:00
amcrnvgnbkr: if you want to wrap every statement separately in an upgrade, that's fine.21:00
amcrnbut your comment suggested you'd actually assert the state21:01
*** georgelorch has joined #openstack-trove21:01
amcrnthe former is reasonable, the latter is nearly impossible (when considering you've got postgres + mysql + sqlite to contend with)21:01
vgnbkrSo what is the usecase for someone doing a downgrade, then an upgrade, but not expecting things to have been reset?21:03
*** ViswaV has quit IRC21:04
*** ViswaV_ has joined #openstack-trove21:04
*** sriram_tesora has quit IRC21:04
*** ViswaV_ has quit IRC21:04
amcrnyou're probably talking to the wrong person, because i think the whole downgrade idea is an anti-pattern21:04
amcrnjust because the tables drop and the rows drop doesn't mean the computes and volumes and security-groups and <etc> magically disappear21:05
amcrnunraveling indexes and constraints on a downgrade are relatively safe, but anything else is asking for trouble21:05
vgnbkrI agree, so why would we have upgrade implemented improperly to support a questionable feature?21:06
amcrnvgnbkr: because someone ran into this problem in their deployment21:06
amcrnwe can't state "in trove, we don't subscribe to the notion of a downgrade at all, best of luck"21:07
openstackgerritMat Lowery proposed a change to openstack/trove: Clusters TaskManager Implementation  https://review.openstack.org/11369221:07
*** georgelorch has quit IRC21:07
vgnbkrThat's OK, too, but upgrade needs to work.21:08
amcrnvgnbkr: if you submitted a patch that wrapped every single side-effecting statement in an upgrade() with its own try/catch, i'd +2 it21:08
amcrni'm sure someone could come up with a more clever way of writing it; something more pythonic21:09
kevinconwaywhich review are you two talking about?21:09
vgnbkrBut that wouldn't solve the problem.  The issue isn't about which line causes the exception, rather making sure that the initial upgrade works.21:10
amcrnto be curious, what's your vested interest in this? are you actually going to ever run a downgrade?21:10
amcrnand if so, why.21:10
vgnbkrNo, I agree with you that downgrade is stupid.  I just think upgrade should work in all cases.21:11
amcrnif you never downgrade, an upgrade will always work, no?21:12
amcrnor are you arguing that we're possibly swallowing things in say 019_ and continuing onto 020_21:12
vgnbkrNo, that was my original point.  Eating the exception means that an error would leave the database in an unknown state and silently move on.21:12
vgnbkrRight.21:13
amcrnwell, because we're stuck supporting the "downgrade then upgrade back" scenario, not sure how to fix it.21:13
*** tomblank has quit IRC21:13
amcrnsince the migration table does not have a history21:13
amcrnit's a single row21:13
vgnbkrIf we want to say "downgrade at your own risk", OK, but upgrade must work in all cases in the initial upgrade.21:13
*** robertmyers has quit IRC21:13
vgnbkrWell, work or throw an exception to stop the upgrade process - we can't just silently move on.21:14
amcrnvgnbkr: the problem is, at a point in time, you can't tell whether a person is on 015_ because they downgraded, or because that's what the last version was when they last ran db_sync21:14
*** kevinconway has left #openstack-trove21:15
amcrnif migrate_version had a prior_version column, then we could easily guarantee an upgrade works as expected21:16
vgnbkrOK, so then at a minimum, explicitly check for the existence of the tables - relying on exceptions isn't the way to do it.21:17
*** kevinconway has joined #openstack-trove21:18
*** georgelorch has joined #openstack-trove21:19
*** jmontemayor has quit IRC21:19
amcrnvgnbkr: seems like a reasonable compromise21:20
openstackgerritRamashri Umale proposed a change to openstack/trove: Clusters Guest Implementation  https://review.openstack.org/11372821:22
vgnbkrOK, simon will not drop the tables, but won't execute the CREATE statements if the tables already exist.21:23
vgnbkrIf the upgrade does not execute CREATE because the table already exists, it should log a message.  Wondering if it should be INFO or WARN?21:23
*** jmontemayor has joined #openstack-trove21:24
amcrnmy hunch: warn21:24
vgnbkrMine, too.  Thanks.21:24
schangok then, I'll submit a new patch.21:24
*** julienvey has joined #openstack-trove21:26
*** achampion has quit IRC21:27
*** ViswaV has joined #openstack-trove21:27
*** jasondotstar has quit IRC21:28
*** achampion has joined #openstack-trove21:30
*** IanGovett has quit IRC21:39
openstackgerritRiddhi Shah proposed a change to openstack/python-troveclient: Drop config group option in update instance patch call  https://review.openstack.org/11636921:41
*** ViswaV has quit IRC21:41
denis_makogonamcrn, hey, are you there ?21:42
amcrndenis_makogon: what's up21:43
*** georgelorch has quit IRC21:51
* SlickNik reads scrollback21:51
*** georgelorch has joined #openstack-trove21:51
*** Riddhi has quit IRC21:51
*** Riddhi has joined #openstack-trove21:53
*** achampion has quit IRC21:54
*** georgelorch has quit IRC21:56
schangSlickNik: I think https://bugs.launchpad.net/trove/+bug/1361389 can be triaged. I've put the discussions summary in the comment of the bug.22:02
*** tkatarki has quit IRC22:05
*** ranjitha has quit IRC22:06
*** Riddhi has quit IRC22:08
*** tkatarki has joined #openstack-trove22:08
*** georgelorch has joined #openstack-trove22:12
*** julienvey has quit IRC22:13
*** harlowja_ has joined #openstack-trove22:13
*** Barker has quit IRC22:14
*** harlowja_ has quit IRC22:15
*** harlowja_ has joined #openstack-trove22:15
*** harlowja has quit IRC22:16
openstackgerritDenis M. proposed a change to openstack/trove: Support full backup/restore for Cassandra  https://review.openstack.org/7755122:18
*** tomblank has joined #openstack-trove22:21
*** arist has quit IRC22:23
*** arist has joined #openstack-trove22:23
*** ViswaV has joined #openstack-trove22:30
*** ViswaV_ has joined #openstack-trove22:31
denis_makogonamrith, hey, could you please address my comment here https://review.openstack.org/#/c/113155/3 ?22:34
*** ViswaV has quit IRC22:34
*** sriram_tesora has joined #openstack-trove22:35
*** tkatarki has quit IRC22:36
*** jcru has quit IRC22:37
*** tkatarki has joined #openstack-trove22:37
*** denis_makogon has quit IRC22:42
*** tkatarki has quit IRC22:43
*** tkatarki has joined #openstack-trove22:45
*** jasonb365 has quit IRC22:50
*** kevinconway has quit IRC22:50
*** tkatarki has quit IRC23:01
*** tkatarki has joined #openstack-trove23:01
*** tkatarki has quit IRC23:04
*** mattgriffin has quit IRC23:04
openstackgerritMat Lowery proposed a change to openstack/trove: Clusters TaskManager Implementation  https://review.openstack.org/11369223:05
*** Riddhi has joined #openstack-trove23:06
openstackgerritRamashri Umale proposed a change to openstack/trove: Clusters Guest Implementation  https://review.openstack.org/11372823:10
*** tkatarki has joined #openstack-trove23:11
*** tkatarki has quit IRC23:18
*** edmund has quit IRC23:18
*** tkatarki has joined #openstack-trove23:21
*** tkatarki has quit IRC23:24
*** tkatarki has joined #openstack-trove23:25
*** tkatarki has quit IRC23:25
openstackgerritSimon Chang proposed a change to openstack/trove: Test tables existence on v20 upgrade  https://review.openstack.org/11729123:31
*** jmontemayor has quit IRC23:39
*** juantwo has joined #openstack-trove23:45
*** RicoLin has joined #openstack-trove23:50
*** ViswaV_ has quit IRC23:53
openstackgerritAuston McReynolds proposed a change to openstack/trove: Clusters API Implementation  https://review.openstack.org/11367523:54
*** esp has left #openstack-trove23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!