| *** nosnos has joined #openstack-trove | 01:44 | |
| *** IanGovett has joined #openstack-trove | 01:48 | |
| *** haomaiwa_ has quit IRC | 01:55 | |
| *** IanGovett has quit IRC | 01:56 | |
| *** haomaiwa_ has joined #openstack-trove | 02:11 | |
| *** haomaiwa_ has quit IRC | 02:26 | |
| *** erkules_ has joined #openstack-trove | 02:27 | |
| *** haomaiw__ has joined #openstack-trove | 02:28 | |
| *** tomblank has joined #openstack-trove | 02:28 | |
| *** erkules has quit IRC | 02:29 | |
| *** haomaiw__ has quit IRC | 02:37 | |
| *** haomaiwang has joined #openstack-trove | 02:38 | |
| *** haomaiw__ has joined #openstack-trove | 02:43 | |
| *** haomaiwang has quit IRC | 02:43 | |
| *** haomaiw__ has quit IRC | 03:05 | |
| *** haomaiwang has joined #openstack-trove | 03:05 | |
| *** haomaiwang has quit IRC | 03:07 | |
| *** haomaiwa_ has joined #openstack-trove | 03:08 | |
| *** haomaiwa_ has quit IRC | 03:09 | |
| *** haomaiwa_ has joined #openstack-trove | 03:09 | |
| *** rushiagr_away is now known as rushiagr | 03:15 | |
| *** rushiagr is now known as rushiagr_away | 03:21 | |
| *** haomaiwa_ has quit IRC | 03:22 | |
| *** haomaiwa_ has joined #openstack-trove | 03:23 | |
| *** rushiagr_away is now known as rushiagr | 03:25 | |
| *** haomaiwa_ has quit IRC | 03:31 | |
| *** haomaiwang has joined #openstack-trove | 03:31 | |
| *** haomaiwang has quit IRC | 03:44 | |
| *** haomai___ has joined #openstack-trove | 03:44 | |
| *** haomai___ has quit IRC | 03:50 | |
| *** haomaiwang has joined #openstack-trove | 03:50 | |
| *** nosnos has quit IRC | 03:52 | |
| *** haomaiwang has quit IRC | 03:55 | |
| *** vkmc has quit IRC | 03:55 | |
| *** haomaiwang has joined #openstack-trove | 03:56 | |
| *** haomaiwang has quit IRC | 04:12 | |
| *** haomaiwang has joined #openstack-trove | 04:12 | |
| *** haomaiwang has quit IRC | 04:13 | |
| *** haomaiwang has joined #openstack-trove | 04:14 | |
| *** haomaiwang has quit IRC | 04:29 | |
| *** haomaiwang has joined #openstack-trove | 04:29 | |
| *** haomaiw__ has joined #openstack-trove | 04:42 | |
| *** haomaiwang has quit IRC | 04:42 | |
| *** nosnos has joined #openstack-trove | 04:44 | |
| *** exploreshaifali has joined #openstack-trove | 04:50 | |
| *** haomaiw__ has quit IRC | 04:50 | |
| *** haomaiwa_ has joined #openstack-trove | 04:51 | |
| *** haomaiwa_ has quit IRC | 04:54 | |
| *** haomaiwang has joined #openstack-trove | 04:54 | |
| *** rushiagr is now known as rushiagr_away | 04:55 | |
| *** haomaiwang has quit IRC | 05:00 | |
| *** haomaiwa_ has joined #openstack-trove | 05:01 | |
| *** haomaiwa_ has quit IRC | 05:15 | |
| *** haomaiwang has joined #openstack-trove | 05:16 | |
| *** haomaiwang has quit IRC | 05:17 | |
| *** haomaiw__ has joined #openstack-trove | 05:17 | |
| *** haomaiwa_ has joined #openstack-trove | 05:18 | |
| *** haomaiw__ has quit IRC | 05:18 | |
| *** ajayaa has joined #openstack-trove | 05:29 | |
| *** sgotliv has joined #openstack-trove | 05:36 | |
| *** rushiagr_away is now known as rushiagr | 05:40 | |
| *** haomaiwa_ has quit IRC | 05:43 | |
| *** haomaiwa_ has joined #openstack-trove | 05:44 | |
| *** haomaiw__ has joined #openstack-trove | 05:49 | |
| *** haomaiwa_ has quit IRC | 05:49 | |
| *** nosnos has quit IRC | 05:58 | |
| *** nosnos has joined #openstack-trove | 05:58 | |
| *** haomaiwang has joined #openstack-trove | 06:01 | |
| *** haomaiw__ has quit IRC | 06:01 | |
| *** Riddhi has quit IRC | 06:02 | |
| *** haomaiwang has quit IRC | 06:05 | |
| *** haomaiwa_ has joined #openstack-trove | 06:07 | |
| *** haomaiwa_ has quit IRC | 06:15 | |
| *** haomaiwa_ has joined #openstack-trove | 06:16 | |
| *** erkules_ is now known as erkules | 06:16 | |
| *** haomaiwa_ has quit IRC | 06:18 | |
| *** haomaiwang has joined #openstack-trove | 06:19 | |
| *** ajayaa has quit IRC | 06:20 | |
| *** Longgeek has joined #openstack-trove | 06:21 | |
| *** rushiagr is now known as rushiagr_away | 06:25 | |
| *** Longgeek has quit IRC | 06:25 | |
| *** haomaiwang has quit IRC | 06:26 | |
| *** haomaiwang has joined #openstack-trove | 06:26 | |
| *** nosnos_ has joined #openstack-trove | 06:29 | |
| *** nosnos has quit IRC | 06:29 | |
| *** haomaiwang has quit IRC | 06:30 | |
| *** haomaiwa_ has joined #openstack-trove | 06:31 | |
| *** sgotliv has quit IRC | 06:43 | |
| *** tomblank has quit IRC | 06:45 | |
| *** vigneshvar has joined #openstack-trove | 06:47 | |
| *** haomaiwa_ has quit IRC | 06:47 | |
| *** Longgeek has joined #openstack-trove | 06:53 | |
| *** Longgeek has quit IRC | 06:54 | |
| *** Longgeek has joined #openstack-trove | 06:54 | |
| *** rushiagr_away is now known as rushiagr | 06:54 | |
| *** ajayaa has joined #openstack-trove | 06:54 | |
| *** Longgeek has quit IRC | 06:55 | |
| *** Longgeek has joined #openstack-trove | 06:55 | |
| *** Longgeek has quit IRC | 06:57 | |
| *** Longgeek_ has joined #openstack-trove | 06:57 | |
| *** Longgeek_ has quit IRC | 06:59 | |
| *** haomaiwang has joined #openstack-trove | 07:00 | |
| *** Longgeek has joined #openstack-trove | 07:01 | |
| *** Longgeek has quit IRC | 07:02 | |
| *** k4n0 has joined #openstack-trove | 07:24 | |
| *** exploreshaifali has quit IRC | 07:56 | |
| *** Longgeek has joined #openstack-trove | 08:03 | |
| *** Longgeek has quit IRC | 08:08 | |
| *** romainh has joined #openstack-trove | 08:31 | |
| *** sgotliv has joined #openstack-trove | 08:36 | |
| *** boblebauce has joined #openstack-trove | 08:51 | |
| *** ekarlso- has quit IRC | 08:52 | |
| *** Longgeek has joined #openstack-trove | 08:57 | |
| *** Longgeek_ has joined #openstack-trove | 09:08 | |
| *** Longgeek_ has quit IRC | 09:09 | |
| *** Longgeek_ has joined #openstack-trove | 09:09 | |
| *** Longgeek has quit IRC | 09:10 | |
| *** ekarlso- has joined #openstack-trove | 09:10 | |
| *** sgotliv has quit IRC | 09:30 | |
| *** nosnos_ has quit IRC | 09:31 | |
| *** nosnos has joined #openstack-trove | 09:31 | |
| *** openstackgerrit has quit IRC | 09:50 | |
| *** openstackgerrit has joined #openstack-trove | 09:50 | |
| *** nosnos has quit IRC | 09:52 | |
| *** Longgeek_ has quit IRC | 09:57 | |
| *** Longgeek has joined #openstack-trove | 09:58 | |
| *** nosnos has joined #openstack-trove | 09:58 | |
| *** sgotliv has joined #openstack-trove | 10:07 | |
| *** Longgeek_ has joined #openstack-trove | 10:15 | |
| *** Longgeek has quit IRC | 10:18 | |
| *** haomaiwang has quit IRC | 10:46 | |
| *** Longgeek_ has quit IRC | 11:00 | |
| *** exploreshaifali has joined #openstack-trove | 11:07 | |
| *** Longgeek has joined #openstack-trove | 11:09 | |
| *** vkmc has joined #openstack-trove | 11:23 | |
| *** sgotliv has quit IRC | 11:28 | |
| *** vigneshvar has quit IRC | 11:33 | |
| *** sgotliv has joined #openstack-trove | 11:40 | |
| *** Longgeek has quit IRC | 11:50 | |
| *** Longgeek has joined #openstack-trove | 11:53 | |
| *** nosnos has quit IRC | 12:09 | |
| *** nosnos has joined #openstack-trove | 12:11 | |
| *** exploreshaifali has quit IRC | 12:12 | |
| *** IanGovett has joined #openstack-trove | 12:19 | |
| *** nosnos has quit IRC | 12:29 | |
| *** nosnos has joined #openstack-trove | 12:37 | |
| *** amrith is now known as _amrith_ | 12:41 | |
| *** nosnos has quit IRC | 12:45 | |
| *** tvoran has quit IRC | 13:33 | |
| *** dmakogon_ is now known as denis_makogon | 13:36 | |
| *** tvoran has joined #openstack-trove | 13:36 | |
| *** haomaiwang has joined #openstack-trove | 13:44 | |
| *** grapex has joined #openstack-trove | 13:48 | |
| *** grapex_ has joined #openstack-trove | 13:50 | |
| *** grapex has quit IRC | 13:53 | |
| *** jcru has joined #openstack-trove | 13:54 | |
| *** pboros has joined #openstack-trove | 14:04 | |
| *** tomblank has joined #openstack-trove | 14:19 | |
| *** Longgeek_ has joined #openstack-trove | 14:32 | |
| *** Longgeek has quit IRC | 14:33 | |
| *** jasonb365 has joined #openstack-trove | 14:34 | |
| *** robertmyers has quit IRC | 14:42 | |
| openstackgerrit | Doug Shelley proposed openstack/trove-specs: Amend spec for add-instance-name-to-cli https://review.openstack.org/137846 | 14:58 |
|---|---|---|
| *** mattgriffin has joined #openstack-trove | 15:02 | |
| *** exploreshaifali has joined #openstack-trove | 15:14 | |
| *** k4n0 has quit IRC | 15:16 | |
| *** robertmyers has joined #openstack-trove | 15:20 | |
| openstackgerrit | mariam john proposed openstack/trove: Rename attrs_exist() to contains_allowed_attrs() https://review.openstack.org/121018 | 15:34 |
| *** thedodd has joined #openstack-trove | 15:35 | |
| *** Barker has joined #openstack-trove | 15:37 | |
| *** boblebauce has quit IRC | 15:38 | |
| *** exploreshaifali has quit IRC | 15:39 | |
| *** _amrith_ is now known as amrith | 15:39 | |
| *** Riddhi has joined #openstack-trove | 15:44 | |
| *** Riddhi has quit IRC | 15:59 | |
| *** boblebauce has joined #openstack-trove | 16:11 | |
| *** thedodd has quit IRC | 16:15 | |
| *** Riddhi has joined #openstack-trove | 16:28 | |
| *** Riddhi has quit IRC | 16:29 | |
| *** Riddhi has joined #openstack-trove | 16:30 | |
| dougshelley66 | denis_makogon, are you there? | 16:33 |
| *** exploreshaifali has joined #openstack-trove | 16:33 | |
| *** radez_g0n3 is now known as radez | 16:36 | |
| denis_makogon | dougshelley66, yes, hi there =) | 16:39 |
| dougshelley66 | I was looking to help out with https://review.openstack.org/#/c/82123/ | 16:39 |
| dougshelley66 | you seem to have picked that up along with jcru | 16:39 |
| dougshelley66 | I will take a shot at converting the wiki spec to rst, if that is ok | 16:40 |
| denis_makogon | i already did that =) | 16:40 |
| denis_makogon | https://review.openstack.org/#/c/136577/ | 16:40 |
| denis_makogon | but there's no assignee | 16:40 |
| denis_makogon | it is totally ok | 16:41 |
| denis_makogon | i guess we need to discuss what metadata really means for us | 16:41 |
| denis_makogon | i added alternative version of my own view of metadata | 16:41 |
| dougshelley66 | ah sorry i missed that spec | 16:42 |
| denis_makogon | np | 16:42 |
| denis_makogon | dougshelley66, you still can take it | 16:42 |
| dougshelley66 | denis_makogon, so i haven't read the 2 specs yet (instance-metadata vs metadata-alternative) | 16:43 |
| dougshelley66 | what is the difference? | 16:43 |
| dougshelley66 | are you proposing an new design/implementation | 16:43 |
| denis_makogon | yes | 16:43 |
| denis_makogon | it is different from what it was | 16:43 |
| denis_makogon | from my point of view, metadata should be generic to any of Trove resources | 16:44 |
| dougshelley66 | so the existing code patch in review would be abandoned? assuming there was support for the new approach? | 16:44 |
| denis_makogon | for example, the difference is in how metadata is being stored and pinned to instance (if needed) | 16:44 |
| denis_makogon | dougshelley66, i don't know for sure | 16:44 |
| denis_makogon | it is not up to me to decide how metadata should look, it is up to us as community | 16:45 |
| dougshelley66 | i understand that - i was just asking for your opinion based on the alternate spec | 16:46 |
| denis_makogon | ah, i see | 16:46 |
| denis_makogon | as for me, yes, i think that initial design is not what we actually want | 16:47 |
| *** mattgriffin has quit IRC | 16:47 | |
| denis_makogon | for example, i want to assign metadata into backup entity as hits how to take a backup (partial or full) | 16:47 |
| dougshelley66 | denis_makogon, let me read in more detail - but in general i agree | 16:51 |
| denis_makogon | sure | 16:51 |
| denis_makogon | let me know what you think about it | 16:51 |
| *** mattgriffin has joined #openstack-trove | 17:02 | |
| openstackgerrit | mariam john proposed openstack/trove: Rename attrs_exist() to contains_allowed_attrs() https://review.openstack.org/121018 | 17:02 |
| *** jdandrea has quit IRC | 17:06 | |
| *** jdaggett_ is now known as jdaggett | 17:07 | |
| *** Longgeek_ has quit IRC | 17:11 | |
| *** exploreshaifali has quit IRC | 17:25 | |
| *** Barker has quit IRC | 17:27 | |
| *** johnma has joined #openstack-trove | 17:28 | |
| *** sgotliv has quit IRC | 17:34 | |
| *** romainh has left #openstack-trove | 17:36 | |
| *** nshah has joined #openstack-trove | 17:42 | |
| *** Longgeek has joined #openstack-trove | 17:43 | |
| *** Longgeek has quit IRC | 17:52 | |
| *** annashen has joined #openstack-trove | 17:57 | |
| *** tomblank has quit IRC | 17:59 | |
| *** boblebauce has quit IRC | 17:59 | |
| *** tomblank has joined #openstack-trove | 18:01 | |
| *** lifeless has quit IRC | 18:10 | |
| *** lifeless has joined #openstack-trove | 18:23 | |
| amrith | grapex_, yt? | 18:27 |
| grapex_ | amrith: hi | 18:27 |
| amrith | hiya, quick question for you. | 18:27 |
| amrith | I checked out a fresh trove/master | 18:27 |
| grapex_ | amrith: Shoot | 18:28 |
| openstackgerrit | Robert Myers proposed openstack/trove: Add missing api example for incremental backups https://review.openstack.org/138142 | 18:28 |
| amrith | ran tox -e py27 | 18:28 |
| amrith | and I get 9 modified apidocs files | 18:28 |
| amrith | I assume that this means someone made changes and didn't chkin their apidocs? | 18:28 |
| grapex_ | amrith: Curses! | 18:28 |
| grapex_ | rmyers and I were just discussing this and had hoped to contribute the fix first | 18:28 |
| amrith | I know | 18:28 |
| amrith | I can do it | 18:29 |
| amrith | I have a change good to go with these files | 18:29 |
| amrith | if you'd like | 18:29 |
| grapex_ | amrith: This is pretty embarassing | 18:29 |
| amrith | better me than you in that case ;) | 18:29 |
| grapex_ | https://github.com/openstack/trove/blob/master/trove/tests/examples/client.py#L192 | 18:29 |
| grapex_ | Line 192 needs to be uncommented it | 18:29 |
| grapex_ | I did that right before the patch went through | 18:29 |
| grapex_ | Well, probably a week before it went through | 18:29 |
| robertmyers | amrith grapex_ : https://review.openstack.org/#/c/138142/ | 18:30 |
| amrith | oh, OK | 18:30 |
| grapex_ | robertmyers: Oh nice, quick job on that. | 18:30 |
| amrith | your change is better than mine | 18:30 |
| robertmyers | :) | 18:30 |
| robertmyers | well I did some extra | 18:30 |
| grapex_ | amrith: Another bummer is the code I was working off of was before cp16net's most recent change tot he configs, so the snippets were generated wrong | 18:30 |
| amrith | But ... I'm not getting all of these changes | 18:30 |
| amrith | only 9 | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameter-for-datastore-version-response-json.txt | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameter-for-datastore-version-response.json | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameter-without-datastore-version-response-json.txt | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameter-without-datastore-version-response.json | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameters-for-datastore-version-response-json.txt | 18:31 |
| robertmyers | all I really wanted was incremental | 18:31 |
| grapex_ | so roberymyers patch changes those too | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameters-for-datastore-version-response.json | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameters-without-datastore-version-response-json.txt | 18:31 |
| amrith | modified: apidocs/src/samples/db-configuration-parameters-without-datastore-version-response.json | 18:31 |
| amrith | modified: apidocs/src/samples/db-mgmt-list-hosts-response.json | 18:31 |
| amrith | ah yes | 18:31 |
| amrith | and some more | 18:31 |
| grapex_ | amrith: robertmyers added incremental backups snippets too | 18:31 |
| amrith | ok, understood | 18:31 |
| grapex_ | so there's more than 9 files being changed | 18:31 |
| amrith | I see that some of the changes replace min_size with min and max_size with max. This sounds familiar | 18:33 |
| amrith | is this going to break an API or something? | 18:33 |
| amrith | wasn't there some talk about this already? | 18:33 |
| grapex_ | amrith: I believe thats what cp16net fixed | 18:34 |
| SlickNik | robertmyers: Thanks for that patch — I noticed this same thing over the weekend. | 18:34 |
| grapex_ | It was a break before | 18:34 |
| grapex_ | since I had an earlier version before cp16net's patch, I generated them the old way | 18:35 |
| grapex_ | and since the code to confirm nothing changed was commentedout, it didn't detect that the new snippets weren't the same- its just been generating them | 18:35 |
| *** denis_makogon_ has joined #openstack-trove | 18:36 | |
| amrith | will the gate tests now fail if there is such a mismatch? [hoping the answer is yes] | 18:36 |
| *** rushiagr is now known as rushiagr_away | 18:37 | |
| SlickNik | amrith: according to https://review.openstack.org/#/c/138142/1/trove/tests/examples/client.py,cm it should now fail in that case. | 18:37 |
| amrith | yes, I'm just trying that out | 18:37 |
| amrith | removed the commented line | 18:37 |
| amrith | i.e uncommented | 18:38 |
| amrith | the line | 18:38 |
| amrith | and I get a failure. | 18:38 |
| amrith | good. | 18:38 |
| robertmyers | SlickNik: np | 18:38 |
| grapex_ | amirth: yep.... that was a pretty costly extra character on my part. | 18:39 |
| *** sgotliv has joined #openstack-trove | 18:40 | |
| *** jdandrea has joined #openstack-trove | 18:42 | |
| *** sgotliv has quit IRC | 18:45 | |
| amrith | grapex, I understand that hash is expensive in most places but cheaper in washington and denver. | 19:00 |
| *** tomblank has quit IRC | 19:01 | |
| *** Barker has joined #openstack-trove | 19:04 | |
| *** tomblank has joined #openstack-trove | 19:07 | |
| *** nshah has quit IRC | 19:08 | |
| *** Riddhi_ has joined #openstack-trove | 19:16 | |
| *** Riddhi has quit IRC | 19:16 | |
| *** jasonb365_ has joined #openstack-trove | 19:18 | |
| *** jasonb365 has quit IRC | 19:19 | |
| *** jasonb365_ is now known as jasonb365 | 19:19 | |
| *** Longgeek has joined #openstack-trove | 19:21 | |
| *** Longgeek has quit IRC | 19:22 | |
| *** denis_makogon has quit IRC | 19:24 | |
| *** denis_makogon_ is now known as denis_makogon | 19:24 | |
| *** dmakogon_ has joined #openstack-trove | 19:24 | |
| *** sgotliv has joined #openstack-trove | 19:25 | |
| *** dloi_ has joined #openstack-trove | 19:28 | |
| *** dloi_ has quit IRC | 19:32 | |
| *** tomblank_ has joined #openstack-trove | 19:40 | |
| *** tomblank has quit IRC | 19:41 | |
| *** tomblank_ is now known as tomblank | 19:41 | |
| *** ajayaa has quit IRC | 19:54 | |
| *** grapex_ has quit IRC | 19:56 | |
| *** grapex has joined #openstack-trove | 19:57 | |
| *** exploreshaifali has joined #openstack-trove | 19:58 | |
| *** grapex has quit IRC | 20:02 | |
| openstackgerrit | Merged openstack/trove: Rename attrs_exist() to contains_allowed_attrs() https://review.openstack.org/121018 | 20:17 |
| *** denis_makogon has quit IRC | 20:18 | |
| *** boblebauce has joined #openstack-trove | 20:19 | |
| *** amcrn has joined #openstack-trove | 20:25 | |
| iccha | amrith: SlickNik | 20:28 |
| iccha | https://review.openstack.org/#/c/119771/ | 20:29 |
| amrith | iccha, I'll take a look | 20:35 |
| iccha | thanks amrith | 20:36 |
| SlickNik | iccha: In the middle of something right now — will take a look when I get a chance. Thanks! | 20:36 |
| iccha | ok thanks SlickNik | 20:38 |
| *** sriram_tesora has joined #openstack-trove | 20:44 | |
| *** jasonb365 has quit IRC | 20:45 | |
| amrith | iccha, SlickNik some comments on that review. I've +1'ed it. I'll let you decide whether you think the change should merge or not. | 20:55 |
| iccha | amrith: SlickNik this patch has been held up pretty long. i suggest we just merge this for now and any serious concerns can be another patch | 20:57 |
| amrith | iccha, there are a lot of patches that have been around for a long time. I don't think vintage is a reason to merge something. of course, if someone else believes otherwise, so be it. | 21:01 |
| iccha | i dont see a major issue with this patch is what I meant amrith | 21:02 |
| amrith | yes, and therefore you +2'ed the patch. | 21:03 |
| amrith | ;) | 21:03 |
| amrith | ttyl, have to get in a car now | 21:03 |
| iccha | amrith: dont text and drive ! Lo | 21:06 |
| *** amrith is now known as _amrith_ | 21:12 | |
| *** georgelorch has quit IRC | 21:13 | |
| *** dkehn has quit IRC | 21:17 | |
| *** dkehn has joined #openstack-trove | 21:19 | |
| *** alexiz has joined #openstack-trove | 21:20 | |
| *** mattgrif_ has joined #openstack-trove | 21:20 | |
| *** georgelorch has joined #openstack-trove | 21:20 | |
| *** haomaiw__ has joined #openstack-trove | 21:23 | |
| openstackgerrit | Robert Myers proposed openstack/trove: Add missing api example for incremental backups https://review.openstack.org/138142 | 21:24 |
| *** amcrn_ has joined #openstack-trove | 21:26 | |
| *** fesp has joined #openstack-trove | 21:28 | |
| *** amcrn has quit IRC | 21:35 | |
| *** mattgriffin has quit IRC | 21:35 | |
| *** haomaiwang has quit IRC | 21:35 | |
| *** flaper87 has quit IRC | 21:35 | |
| *** shakayumi has quit IRC | 21:35 | |
| *** russellb has quit IRC | 21:35 | |
| *** fesp is now known as flaper87 | 21:35 | |
| *** nshah has joined #openstack-trove | 21:35 | |
| *** annashen has quit IRC | 21:51 | |
| openstackgerrit | Robert Myers proposed openstack/trove: Add missing api example for incremental backups https://review.openstack.org/138142 | 21:52 |
| *** jcru has quit IRC | 21:58 | |
| *** jasonb365 has joined #openstack-trove | 22:05 | |
| *** tomblank has quit IRC | 22:05 | |
| openstackgerrit | Riddhi Shah proposed openstack/trove: Add datastore and version validation step for replica provisioning https://review.openstack.org/119079 | 22:07 |
| adam_g | does anyone know what the intent of test_database_create_after_create() is @ http://git.openstack.org/cgit/openstack/trove/tree/trove/tests/api/instances.py#n807 ? i believe ive hit a bug with this test but cant be sure since its not clear what its assertion is | 22:08 |
| adam_g | it *looks* like its testing that database creation will fail because the database has already been created, but it seems to currently only be testing that database cannot be created because the instance is not ready | 22:11 |
| SlickNik | adam_g: It tries to test whether it can create a database (on the mysql instance) immediately after the instance has been created, but before the instance has had a chance to turn ACTIVE. | 22:12 |
| adam_g | SlickNik, ah, okay | 22:13 |
| SlickNik | It's confusing since the term "database" (depending on the context) is sometimes used to refer to the instance itself — but it this case it's referring to mysql db (schema) creation. | 22:16 |
| adam_g | SlickNik, yeah, makes sense once i knew what it was trying to test. and that the tests it depends on are very explicit--in that, if you make changes to something running first, there will be cascading effects. | 22:20 |
| *** boblebauce has quit IRC | 22:25 | |
| *** exploreshaifali has quit IRC | 22:26 | |
| openstackgerrit | Adam Gandelman proposed openstack/trove: Support string flavor IDs https://review.openstack.org/115811 | 22:44 |
| *** robertmyers has quit IRC | 22:45 | |
| *** pboros has quit IRC | 22:49 | |
| *** radez is now known as radez_afk | 22:56 | |
| *** annashen has joined #openstack-trove | 23:01 | |
| *** jasonb365 has quit IRC | 23:09 | |
| esp | amcrn_: ping | 23:22 |
| *** annashen has quit IRC | 23:44 | |
| *** mattgrif_ has quit IRC | 23:49 | |
| *** robertmyers has joined #openstack-trove | 23:49 | |
| openstackgerrit | Bob Thyne proposed openstack/python-troveclient: Adds support for Keystone V3 API https://review.openstack.org/134126 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!