Monday, 2015-08-31

« Sunday, 2015-08-30 Index Tuesday, 2015-09-01 »
openstackgerritSaurabh Surana proposed openstack/trove: Update Management Console user and password  https://review.openstack.org/20867000:19
openstackgerritSaurabh Surana proposed openstack/trove: Add support for extended_properties for clusters  https://review.openstack.org/20693100:20
openstackgerritSaurabh Surana proposed openstack/trove: Enable root on cluster creation  https://review.openstack.org/21536800:20
*** mingdang1 has quit IRC00:26
*** haomaiwang has quit IRC00:35
*** imandhan has joined #openstack-trove00:54
*** chlong has joined #openstack-trove00:55
*** zhangjn has joined #openstack-trove01:20
*** erkules_ has joined #openstack-trove01:23
*** erkules has quit IRC01:26
*** mingdang1 has joined #openstack-trove01:31
*** zhangjn has quit IRC01:40
*** haomaiwang has joined #openstack-trove01:40
*** zhangjn has joined #openstack-trove01:41
*** chlong has quit IRC01:49
openstackgerritPetr Malik proposed openstack/trove: Add instance create int-tests  https://review.openstack.org/21737101:54
openstackgerritPetr Malik proposed openstack/trove: Add user and database actions int-tests  https://review.openstack.org/21009401:55
*** imandhan has quit IRC01:59
*** arist has quit IRC02:05
*** arist has joined #openstack-trove02:06
openstackgerritPetr Malik proposed openstack/trove: Expect ValidationError on an empty user update  https://review.openstack.org/21870102:10
openstackgerritPetr Malik proposed openstack/python-troveclient: Use more appropriate exceptions for validation  https://review.openstack.org/21000402:10
*** zhangjn has quit IRC02:19
*** imandhan has joined #openstack-trove02:58
*** imandhan has quit IRC03:00
*** haomaiwang has quit IRC03:03
*** haomaiw__ has joined #openstack-trove03:03
*** eglute has quit IRC03:25
*** eglute has joined #openstack-trove03:31
*** links has joined #openstack-trove03:40
*** imandhan has joined #openstack-trove03:59
*** imandhan has quit IRC04:01
*** sgotliv has joined #openstack-trove04:29
*** zhangjn has joined #openstack-trove04:37
*** sabeen1 has joined #openstack-trove04:40
*** sgotliv has quit IRC04:43
*** sabeen1 has quit IRC04:49
*** ig0r__ has joined #openstack-trove04:58
*** ig0r_ has quit IRC04:59
*** imandhan has joined #openstack-trove05:00
*** imandhan has quit IRC05:01
openstackgerritMerged openstack/trove-integration: Percona Xtradb Cluster image building scripts  https://review.openstack.org/20807405:12
openstackgerritPetr Malik proposed openstack/trove: Expect ValidationError on an empty user update  https://review.openstack.org/21870105:13
*** imandhan has joined #openstack-trove05:13
*** sabeen1 has joined #openstack-trove05:13
*** mingdang1 has quit IRC05:23
*** mingdang1 has joined #openstack-trove05:32
*** sabeen2 has joined #openstack-trove05:39
*** sabeen1 has quit IRC05:39
*** saurabhs has joined #openstack-trove05:40
*** imandhan has quit IRC05:42
*** imandhan has joined #openstack-trove05:43
*** imandhan has quit IRC06:04
*** zhangjn has quit IRC06:45
*** zhangjn has joined #openstack-trove06:45
*** sabeen2 has quit IRC07:18
*** zhangjn has quit IRC07:28
*** sgotliv has joined #openstack-trove07:47
openstackgerritCraig Vyvial proposed openstack/trove: Percona Xtradb Cluster implementation  https://review.openstack.org/20807308:02
*** zhangjn has joined #openstack-trove08:10
*** zhangjn has quit IRC08:45
*** tosky has joined #openstack-trove09:04
*** erkules_ is now known as erkules09:04
*** erkules has joined #openstack-trove09:04
*** IanGovett has joined #openstack-trove09:08
*** zhangjn has joined #openstack-trove09:23
*** zhangjn has quit IRC09:27
*** ig0r_ has joined #openstack-trove09:37
*** ig0r__ has quit IRC09:39
*** zhangjn has joined #openstack-trove09:39
*** zhangjn has quit IRC09:41
*** mingdang1 has quit IRC10:59
*** haomaiw__ has quit IRC11:15
*** sgotliv has quit IRC11:31
*** mingdang1 has joined #openstack-trove11:40
*** openstackgerrit has quit IRC11:46
*** openstackgerrit has joined #openstack-trove11:46
*** k4n0 has joined #openstack-trove11:48
*** sgotliv has joined #openstack-trove11:48
*** IanGovett1 has joined #openstack-trove12:05
*** IanGovett has quit IRC12:05
*** sgotliv has quit IRC12:09
*** crobertsrh has joined #openstack-trove12:34
*** k4n0 has quit IRC12:34
*** pmackinn has joined #openstack-trove12:36
*** haomaiwa_ has joined #openstack-trove12:37
*** sgotliv has joined #openstack-trove12:47
*** k4n0 has joined #openstack-trove12:48
*** sgotliv has quit IRC12:57
*** sabeen1 has joined #openstack-trove13:11
*** amrith is now known as _amrith_13:13
*** sgotliv has joined #openstack-trove13:14
*** kbyrne has quit IRC13:19
*** k4n0 has quit IRC13:27
*** links has quit IRC13:30
*** kbyrne has joined #openstack-trove13:32
*** IanGovett1 has quit IRC13:35
*** k4n0 has joined #openstack-trove13:40
*** k4n0 has quit IRC13:44
*** k4n0 has joined #openstack-trove13:45
*** k4n0 has quit IRC13:50
*** k4n0 has joined #openstack-trove13:57
openstackgerritCraig Vyvial proposed openstack/trove: Percona Xtradb Cluster implementation  https://review.openstack.org/20807313:58
*** zhangjn has joined #openstack-trove13:59
*** zhangjn has quit IRC13:59
openstackgerritVictoria Martinez de la Cruz proposed openstack/trove: Add support for MariaDB datastore in Trove  https://review.openstack.org/21745113:59
*** zhangjn has joined #openstack-trove14:00
*** IanGovett has joined #openstack-trove14:01
*** zhangjn has quit IRC14:09
openstackgerritCraig Vyvial proposed openstack/trove: Percona Xtradb Cluster implementation  https://review.openstack.org/20807314:09
*** mingdang1 has quit IRC14:14
*** zhangjn has joined #openstack-trove14:17
openstackgerritCraig Vyvial proposed openstack/trove: Percona Xtradb Cluster implementation  https://review.openstack.org/20807314:21
*** zhangjn has quit IRC14:21
*** _amrith_ is now known as amrith14:25
*** hietler has joined #openstack-trove14:34
openstackgerritPetr Malik proposed openstack/trove: Expect ValidationError on an empty user update  https://review.openstack.org/21870114:46
*** jwiles_ has joined #openstack-trove14:49
*** zhangjn has joined #openstack-trove14:49
*** hietler is now known as _bhi_14:51
*** nexusz99 has joined #openstack-trove14:57
pmalik_Hi. Having a few rather simple reviews in flight.15:01
pmalik_Would be great to get some reviews on them so that we can get them off the list.15:01
pmalik_Thanks. :-)15:01
pmalik_https://review.openstack.org/#/c/218382/15:01
pmalik_https://review.openstack.org/#/c/217387/15:01
pmalik_https://review.openstack.org/#/c/213399/15:01
*** csoukup has joined #openstack-trove15:01
pmalik_https://review.openstack.org/#/c/214782/15:01
pmalik_^^^ vkmc, cp16net peterstac amrith edmondk SlickNik15:01
vkmcpmalik_, thanks, will check now15:01
SlickNikpmalik_: will take a look. Thanks!15:02
vkmcpmalik_, SlickNik, could you also check https://review.openstack.org/#/c/217451/315:07
pmackinncp16net, craig, you snuck your pxc redstack change in before mine15:09
* pmackinn shakes fist at cp16net 15:09
cp16netlol15:09
cp16neti didnt sneak anything15:09
cp16neti didnt expect that to get merged until after the the main cluster code was done15:10
cp16netits not that big of a change tho with trove-int15:10
* pmackinn climbs back down into the rebase hole 15:10
cp16netlets not focus on bugs right now15:11
SlickNikcp16net: Yes, we've got the next two weeks to focus on getting bug-fixes merged.15:12
cp16netwe need to get the blueprint feature code in by tomorrow15:12
vkmcD:15:12
cp16netat least the features we've slated to lib-315:13
SlickNikYup, I've updated https://launchpad.net/trove/+milestone/liberty-3 to reflect this.15:13
cp16netvkmc: l-3 will be cut this week and its a bad idea to get new feature code merged after then15:14
cp16net:)15:14
vkmccp16net, I know, that's exactly why I'm D:'ing15:15
vkmchaha15:15
cp16nethehe15:15
cp16netok :-P15:15
cp16neti'm :-P'ing15:15
SlickNikI talk to ttx tomorrow, but probably have a bit more time than tomorrow (probably till wed/thursday to cut lib-3)15:15
SlickNikWe'll need it to ensure we get through the gate craziness.15:15
cp16netgate didnt look so bad this morning15:16
cp16netbut i bet that will change in the next few hours15:16
SlickNikYup, with the FF it always gets crazy.15:16
cp16netyeqah15:16
*** nexusz99 has quit IRC15:21
*** thedodd has joined #openstack-trove15:23
*** haomaiwa_ has quit IRC15:29
*** k4n0 has quit IRC15:29
*** david-ly_ has joined #openstack-trove15:31
sushilkmhello all reviewers, luking for reviews on https://review.openstack.org/#/c/195153/ and https://review.openstack.org/#/c/214510/ the patches for Datastore Registration API15:32
*** david-ly_ is now known as david-lyle_15:33
*** david-lyle has quit IRC15:33
*** david-lyle_ is now known as david-lyle15:35
*** amrith is now known as _amrith_15:37
*** IanGovett1 has joined #openstack-trove15:43
*** IanGovett has quit IRC15:43
*** zhangjn has quit IRC15:54
*** sgotliv has quit IRC15:55
*** saurabhs has quit IRC16:02
*** _amrith_ is now known as amrith16:03
*** IanGovett1 has quit IRC16:05
*** IanGovett has joined #openstack-trove16:06
*** IanGovett1 has joined #openstack-trove16:10
*** IanGovett has quit IRC16:10
*** c_soukup has joined #openstack-trove16:16
*** csoukup has quit IRC16:19
*** ashleighfarnham has joined #openstack-trove16:31
*** ashleighfarnham has quit IRC16:31
*** ashleighfarnham has joined #openstack-trove16:31
*** lifeless has quit IRC16:34
openstackgerritVictoria Martinez de la Cruz proposed openstack/trove: Add support for MariaDB datastore in Trove  https://review.openstack.org/21745116:34
*** ramashri has joined #openstack-trove16:34
*** rjaiswal has joined #openstack-trove16:41
*** lifeless has joined #openstack-trove16:41
*** imandhan has joined #openstack-trove16:50
*** jwiles_ has quit IRC16:53
*** bhunter71 has joined #openstack-trove17:02
*** c_soukup has quit IRC17:03
*** exploreshaifali has joined #openstack-trove17:04
*** IanGovett1 has quit IRC17:08
*** saurabhs has joined #openstack-trove17:09
*** saurabhs has left #openstack-trove17:11
*** csoukup has joined #openstack-trove17:23
*** IanGovett has joined #openstack-trove17:24
cp16netamrith: SlickNik vkmc got this passing in the gate now https://review.openstack.org/#/c/20807317:32
amrithcp16net, neat!17:33
amrithpassing the gate is a surprisingly easy thing nowadays ;)17:34
amrithI hear17:34
cp16netamrith: compared to a few days ago... yes.17:38
cp16netbtw did we mark that bug that was reverted?17:39
*** saurabhs has joined #openstack-trove17:40
*** saurabhs1 has joined #openstack-trove17:41
cp16netfrom the looks of it there was no bug reported for that change17:42
openstackgerritPeter Stachowski proposed openstack/trove: Add Redis backup/restore functionality  https://review.openstack.org/18589217:42
*** ig0r__ has joined #openstack-trove17:43
*** amrith is now known as _amrith_17:43
*** ashleighfarnham has quit IRC17:44
*** saurabhs has quit IRC17:44
*** ig0r_ has quit IRC17:46
*** saurabhs1 has quit IRC17:47
atomic77cp16net, glad to see you survived the rebase :)17:48
cp16netyeah it was rough17:48
cp16netits still not prefect as you mentioned in the review but its working :-D17:48
*** ashleighfarnham has joined #openstack-trove17:50
cp16netand i put all the pxc specific changes in its own manager so now it shouldnt cause any issues or extra calls not needed for mysql17:50
atomic77well the refactor was far from perfect as well :) i'm at least glad to see that there does seem to be a fair bit of code reuse17:50
atomic77i would have been a bit concerned about the approach we took if the PXC service module was reimplementing everything :D17:51
*** saurabhs has joined #openstack-trove17:54
*** csoukup has quit IRC17:59
*** csoukup has joined #openstack-trove18:04
*** _bhi_ has quit IRC18:07
cp16net_amrith_: can you review the clustering patch? plz18:16
cp16netatomic77: thanks for looking over the patch :)18:16
cp16netedmondk: peterstac: vkmc: can you look over my clustering feature change? https://review.openstack.org/#/c/20807318:18
vkmccp16net, will do, this time for realz, thanks18:19
cp16netvkmc: ok i know its a big patch but now after the refactor its less intrusive to the mysql manager.18:21
*** exploreshaifali has quit IRC18:28
*** sgotliv has joined #openstack-trove18:42
*** _amrith_ is now known as amrith18:43
openstackgerritPete MacKinnon proposed openstack/trove-integration: Modifications for Fedora 21 support in redstack  https://review.openstack.org/21419518:44
*** ig0r__ has quit IRC18:48
*** sabeen1 has quit IRC18:59
openstackgerritJonathan Halterman proposed openstack/trove: Enable root on cluster creation  https://review.openstack.org/21536819:12
openstackgerritJonathan Halterman proposed openstack/trove: Root enablement for Vertica clusters/instances  https://review.openstack.org/21899019:12
openstackgerritJonathan Halterman proposed openstack/trove: Add support for extended_properties for clusters  https://review.openstack.org/21899119:12
openstackgerritEdmond Kotowski proposed openstack/trove: Fix instance from alternating status on create  https://review.openstack.org/21540219:17
*** exploreshaifali has joined #openstack-trove19:33
openstackgerritamrith proposed openstack/trove: Move ignore_dbs and ignore_users out of DEFAULT  https://review.openstack.org/20783319:39
*** ramashri has quit IRC19:40
*** sharikapongubala has joined #openstack-trove19:41
mvandijkSlickNik, I see a couple of new features being added for clusters19:53
mvandijkI think the implementations are too Vertica-centric and that they should have been discussed first19:54
mvandijkconsidering the work put into them I understand that we don't want to have to redo the work19:54
mvandijkand so the simplest change I would like is for the options to be made into cluster-create params instead of being in the databag19:55
mvandijki think root password/enablement and floating ip for management consoles are generic enough19:55
mvandijkI know that we did agree that a databag is inevitable but I think those options are common/important enough to be separate19:56
*** david-lyle has quit IRC20:01
*** david-lyle has joined #openstack-trove20:06
openstackgerritVictoria Martinez de la Cruz proposed openstack/trove-integration: MariaDB 5.5 image building scripts  https://review.openstack.org/21179120:11
*** thedodd has quit IRC20:11
openstackgerritVictoria Martinez de la Cruz proposed openstack/trove-integration: MariaDB 5.5 image building scripts  https://review.openstack.org/21179120:14
*** ramashri has joined #openstack-trove20:16
openstackgerritJonathan Halterman proposed openstack/trove: Enable root on cluster creation  https://review.openstack.org/21536820:16
cp16netvkmc: hey is libmariadbclient18 a thing?20:18
vkmccp16net, yup20:18
vkmchttp://packages.ubuntu.com/trusty/libmariadbclient1820:19
cp16neti thought it was libmysqlclient1820:19
cp16netpinned to the mariadb repo20:19
vkmcme too, in fact, not sure what libmariadbclient18 differs from libmysqlclient1820:20
cp16netok20:20
*** rjaiswal has quit IRC20:20
cp16netwe need to go through this list https://etherpad.openstack.org/p/TroveLibertyPriorities20:30
cp16netupdate it as nessesary20:31
cp16netwe got tons of stuff and not much time left20:31
openstackgerritEdmond Kotowski proposed openstack/trove: Fix instance from alternating status on create  https://review.openstack.org/21540220:44
edmondkpeterstac, I manually tested the status toggle fix with mysql, redis, and mongo and it no longer alternated status20:47
peterstacedmondk: I'll run some quick tests on my Redis machine - it'd probably be good to get this bug fix in sooner rather than later :)20:50
edmondkjust sent another patch set up with checking the NEW status value20:51
edmondkyeah I want this patch in as soon as we can get it because it on our environment all of the int tests fail because of this toggle state problem20:51
edmondkpeterstac, I am assuming the gate will take at least 20 hours :)20:52
peterstacThe only issue might be if self.status = None (it'll evaluate to 'true' in that case), but maybe not important20:52
saurabhsHi All, we have prepared both the root-enable on cluster patches (for trove and python-troveclient) We did lot of testing over last couple of days  to make sure we don't break any backwards compatibility. Also we left old root-enable tests in place and added more test for new root-enable-with-password. So will request you all please review these two patches20:54
saurabhshttps://review.openstack.org/#/c/204271/20:54
saurabhshttps://review.openstack.org/#/c/218548/20:54
*** crobertsrh is now known as _crobertsrh20:54
saurabhspeterstac edmondk cp16net ^^20:55
saurabhstrying to get these merged asap20:55
cp16netsaurabhs: ok we are working through the priority features before the freeze20:58
edmondkcp16net, reviewing percona clustering now21:00
openstackgerritMayuri Ganguly proposed openstack/trove: Update Management Console user and password  https://review.openstack.org/20867021:03
mvandijksaurabhs, the spec hasn't been approved, we need to agree on that first21:04
mvandijkblueprint sry21:04
saurabhsmvandijk so for root-enable on cluster both blueprint(https://blueprints.launchpad.net/openstack/?searchtext=vertica-cluster-user-features) and  spec (https://review.openstack.org/#/c/172161/) is approved21:07
saurabhsmvandijk for vertica floating ip, I agree the spec has not made progress that well21:08
mvandijkI stand corrected. I mentioned above that I am concerned that the changes to the api cluster-create were not discussed in the docs. Looks like you guys just went ahead and decided on using 'extended-properties' without getting any feedback.21:14
mvandijksaurabhs, ^21:14
saurabhsmvandijk you are correct about extended proprties changes, slicknik suggested that those are already discussed in the community and he has received agreement from most members. I am not sure why we didn't do spec for that.21:19
*** mayurig has joined #openstack-trove21:20
mvandijksaurabhs, yes we discussed it as a tool for datastore specific options, but for these two I think they could be standalone options, but it seems too late to voice that opinion :)21:21
saurabhsmvandikj I hear you, we should do a better job a this in future. Do you have any specific concerns about that implementation through?21:23
saurabhsmvandikj the extended_properties change is still different that root-enable on cluster (changes for extended_propeties are on the cluster-create api).21:24
saurabhsthe blueprint, specs and the reviews I posted above are specificially for root-enable on cluster, which is the different action and we are trying to get that merged for liberty as spec for that has merged and its pretty straightfoward because its an action that is already supported for instances21:24
saurabhshttps://review.openstack.org/#/c/196913/21:24
saurabhshttps://review.openstack.org/#/c/218548/21:24
mvandijksaurabhs, right I know they are different and the root-enable on cluster API has been agreed upon, it was the cluster-create change I had comments about21:29
*** mayurig has quit IRC21:30
*** mayurig has joined #openstack-trove21:31
*** sgotliv has quit IRC21:41
*** IanGovett has quit IRC21:57
*** sabeen has joined #openstack-trove21:58
*** sharikapongubala has quit IRC22:02
*** sharikapongubala has joined #openstack-trove22:03
*** thedodd has joined #openstack-trove22:05
edmondkneed final +2 on percona cluster review: https://review.openstack.org/#/c/208073/22:28
vkmccp16net, https://review.openstack.org/#/c/208073/21/trove/templates/pxc/replica.config.template,cm why are you enabling bin logging in the replica?22:49
cp16netvkmc: i copied all the mysql templates22:50
vkmccp16net, fair enough22:50
cp16netthere are no tests for making it a replica yet either22:51
cp16neti'm sure there will be holes in pxc but this was to CRUD a cluster22:52
cp16netminus the U22:52
cp16netlol22:52
cp16netthat will come along with the grow shrink22:53
vkmcits ok, its a huge change already22:54
vkmcI'm asking just for curiosity22:54
cp16netnp22:54
vkmcnot very experienced in real, production, mysql deployments22:54
cp16netno worries22:55
*** csoukup has quit IRC22:56
cp16netany other curiosities about the review?22:56
vkmcmmh no, it looks very good22:57
vkmchave my pxc cluster already22:57
vkmc:D22:57
vkmcreading the code one more time, but seems good to go22:57
cp16netahh you tested it?22:58
openstackgerritSaurabh Surana proposed openstack/trove: Add floating ip to vertica master node  https://review.openstack.org/20757822:58
vkmccp16net, yup!22:59
cp16netgreat. glad i didnt just make stuff up :-P22:59
vkmchaha22:59
edmondkpeterstac, check gate passed for toggle status fix and I think is ready for review: https://review.openstack.org/#/c/215402/23:01
cp16netedmondk:  i see it23:03
cp16netedmondk: quick q on that change23:03
cp16netso the status was flipping for just mongo or for mysql as well?23:04
*** exploreshaifali has quit IRC23:04
cp16netreason i ask is b/c i havnt seen mysql do that before23:04
*** ashleighfarnham has quit IRC23:04
*** tosky has quit IRC23:06
*** ramashri has quit IRC23:11
*** thedodd has quit IRC23:12
cp16netoh it was a race condition if the prepare was slower than the first status check i bet23:20
vkmcwhat's up with cloud-images.ubuntu.com/trusty/current23:25
vkmc?23:25
cp16netis it slow?23:28
cp16netor timeing out?23:28
vkmcforbidden23:29
vkmccannot create images with trove-integration23:29
cp16netoh i just hit it in my browser and was the same23:29
vkmcthis shouldn't affect the gates though23:29
cp16netyeah it shouldnt*23:30
cp16neti recall seeing this for a little bit of time before23:30
cp16netmaybe the owner is updating and thats how they do it23:30
cp16net?23:30
cp16neti built one last night when i was testing not today tho23:31
*** ramashri has joined #openstack-trove23:40
vkmcyeah it seems so23:40
cp16netvkmc: need anything else from me other than a drink for a +2? :-P23:43
vkmccp16net, I could use a drink haha23:43
vkmcthanks, I'm finishing re reading the pxc manager23:44
cp16netwell damn i just hit the issue with the image as well...23:51
cp16netboo23:51
*** ramashri has quit IRC23:53
cp16netoh it looks like that dir doesnt exist right now for trusty on the server23:53
*** ramashri has joined #openstack-trove23:56
*** mayurig has quit IRC23:58
« Sunday, 2015-08-30 Index Tuesday, 2015-09-01 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!