| vkmc | waiting for the gate to finish | 00:00 |
|---|---|---|
| vkmc | looks good though | 00:00 |
| SlickNik | vkmc ++ | 00:00 |
| SlickNik | Thanks | 00:00 |
| vkmc | thanks for working on it :) | 00:01 |
| vkmc | how do you usually test the gate changes? I always wondered | 00:01 |
| *** peterstac-m has joined #openstack-trove | 00:02 | |
| SlickNik | Depends, if it's an easy fix, usually make the change and test in the gate. If it's more involved, I usually set up a devstack-gate environment. | 00:02 |
| SlickNik | vkmc: https://github.com/openstack-infra/devstack-gate/blob/master/README.rst has some good documentation that describes how to go about it. | 00:03 |
| peterstac-m | SlickNik looks like it failed again | 00:03 |
| vkmc | SlickNik, thanks for the link | 00:03 |
| peterstac-m | We may need to link the file into /etc/openstack | 00:04 |
| SlickNik | peterstac: https://review.openstack.org/#/c/226549/ succeeded | 00:04 |
| SlickNik | So I cleaned up the review | 00:04 |
| SlickNik | and resubmitted | 00:04 |
| SlickNik | peterstac: Look at: https://jenkins03.openstack.org/job/gate-trove-functional-dsvm-mysql/818/console | 00:05 |
| peterstac-m | SlickNik sorry I'm on my phone now - must have clicked the wrong link :( | 00:07 |
| SlickNik | no worries. I figured you were on the phone (your -m suffix gave you away :)) | 00:07 |
| peterstac-m | Ah right :D | 00:07 |
| *** exploreshaifali has quit IRC | 00:33 | |
| *** davideagnello has quit IRC | 00:37 | |
| *** davideagnello has joined #openstack-trove | 00:37 | |
| *** davideagnello has quit IRC | 00:49 | |
| *** davideagnello has joined #openstack-trove | 00:49 | |
| *** pmackinn has quit IRC | 01:15 | |
| *** sabeen has joined #openstack-trove | 01:30 | |
| *** peterstac-m has quit IRC | 01:31 | |
| cp16net | peterstac: SlickNik nice! | 01:37 |
| cp16net | looks like it should pass now | 01:38 |
| cp16net | i workflowed it so that it should go through once it passes the check | 01:53 |
| *** haomaiwang has joined #openstack-trove | 01:58 | |
| *** haomaiwang has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-trove | 02:01 | |
| *** imandhan has joined #openstack-trove | 02:27 | |
| cp16net | just passed! :) | 02:56 |
| *** pmackinn has joined #openstack-trove | 03:00 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwa_ has joined #openstack-trove | 03:01 | |
| *** david-lyle has joined #openstack-trove | 03:13 | |
| *** imandhan has quit IRC | 03:22 | |
| *** imandhan has joined #openstack-trove | 03:23 | |
| *** imandhan has quit IRC | 03:27 | |
| *** haomaiwa_ has quit IRC | 04:01 | |
| *** imandhan has joined #openstack-trove | 04:01 | |
| *** haomaiwang has joined #openstack-trove | 04:01 | |
| openstackgerrit | Merged openstack/trove-integration: Fix glance image upload in the gate https://review.openstack.org/226549 | 04:24 |
| *** imandhan has quit IRC | 04:28 | |
| SlickNik | cp16net: ossum, thanks! | 04:29 |
| cp16net | :) | 04:29 |
| cp16net | SlickNik: went over the list on the etherpad and applied rechecks as needed | 04:30 |
| cp16net | SlickNik: thanks for resolving the gate btw :) | 04:31 |
| cp16net | i think i have a way to reproduce the gate node now | 04:31 |
| SlickNik | No worries. I had to step out to dinner, so thanks for merging that + applying the needed rechecks :) | 04:32 |
| cp16net | SlickNik: did you triage all the bugs that needed to be completed for the release this week? | 04:35 |
| SlickNik | cp16net: Yes — that's what the etherpad for reviews is based off of — https://bugs.launchpad.net/trove/+milestone/liberty-rc1 is what the list looks like right now. | 04:37 |
| cp16net | ok cool | 04:37 |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-trove | 05:01 | |
| *** georgelorch has quit IRC | 05:09 | |
| *** georgelorch has joined #openstack-trove | 05:16 | |
| *** ashleighfarnham has joined #openstack-trove | 05:44 | |
| *** pmackinn has quit IRC | 06:00 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-trove | 06:01 | |
| *** ashleighfarnham has quit IRC | 06:32 | |
| *** sabeen has quit IRC | 06:41 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-trove | 07:01 | |
| openstackgerrit | Merged openstack/trove-specs: Change ignore-errors to ignore_errors https://review.openstack.org/225841 | 07:01 |
| openstackgerrit | Merged openstack/trove: Add support for extended_properties for clusters https://review.openstack.org/206931 | 07:33 |
| *** k4n0 has joined #openstack-trove | 07:51 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-trove | 08:01 | |
| *** haomaiwang has quit IRC | 08:10 | |
| *** haomaiwa_ has joined #openstack-trove | 08:12 | |
| openstackgerrit | Merged openstack/trove-integration: Fix install - update list of oslo libraries https://review.openstack.org/223843 | 08:35 |
| *** haomaiwa_ has quit IRC | 09:01 | |
| *** 16WAAB8UT has joined #openstack-trove | 09:01 | |
| *** tosky has joined #openstack-trove | 09:36 | |
| openstackgerrit | Merged openstack/trove: Fix Mongo report_root call to have correct args https://review.openstack.org/226479 | 09:55 |
| *** 16WAAB8UT has quit IRC | 10:01 | |
| *** 6JTAB3MXI has joined #openstack-trove | 10:01 | |
| *** IanGovett has joined #openstack-trove | 10:16 | |
| *** exploreshaifali has joined #openstack-trove | 10:51 | |
| *** shaikapsar has joined #openstack-trove | 10:54 | |
| shaikapsar | do we have a way to mange rabbitmq credential update in trove-guestagent.conf file in trove DB Instances ? | 10:58 |
| *** 6JTAB3MXI has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-trove | 11:01 | |
| shaikapsar | I need to modify the RabbitMQ user credentials as per my company policy, How I can update the new password in trove-guestagent.conf in Trove database instances ? | 11:01 |
| dougshelley66 | shaikapsar, is the requirement that each guest instance have different rabbitmq credentials? | 11:14 |
| *** haomaiwang has quit IRC | 11:22 | |
| shaikapsar | We are setting only one user for all the guest instances | 11:24 |
| *** shakamunyi has quit IRC | 11:25 | |
| *** tosky has quit IRC | 11:34 | |
| *** tosky has joined #openstack-trove | 11:34 | |
| *** k4n0 has quit IRC | 11:46 | |
| *** exploreshaifali has quit IRC | 11:56 | |
| *** pmackinn has joined #openstack-trove | 12:00 | |
| *** _crobertsrh is now known as crobertsrh | 12:42 | |
| *** csoukup has joined #openstack-trove | 12:43 | |
| *** tosky has quit IRC | 12:47 | |
| *** csoukup has quit IRC | 13:00 | |
| *** haomaiwang has joined #openstack-trove | 13:08 | |
| *** tomblank has joined #openstack-trove | 13:11 | |
| dougshelley66 | shaikapsar, then you should be able to just update trove-guestagent.conf on the taskmanager node as that file is passed to the guest during create | 13:15 |
| *** tosky has joined #openstack-trove | 13:16 | |
| shaikapsar | ok, what about existing DB instance created? | 13:17 |
| *** shaikapsar has quit IRC | 13:27 | |
| *** tosky has quit IRC | 13:29 | |
| dougshelley66 | shaikapsar, I don't know of a way currently to push down a new conf file to a running instance | 13:33 |
| *** tosky has joined #openstack-trove | 13:36 | |
| *** imandhan has joined #openstack-trove | 13:48 | |
| *** _amrith_ is now known as amrith | 13:54 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-trove | 14:01 | |
| *** csoukup has joined #openstack-trove | 14:06 | |
| *** exploreshaifali has joined #openstack-trove | 14:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove: Updated from global requirements https://review.openstack.org/221938 | 14:14 |
| *** tomblank_ has joined #openstack-trove | 14:29 | |
| *** tomblank has quit IRC | 14:32 | |
| *** tomblank_ is now known as tomblank | 14:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove: Imported Translations from Zanata https://review.openstack.org/226827 | 14:34 |
| *** exploreshaifali has quit IRC | 14:44 | |
| *** haomaiwang has quit IRC | 14:47 | |
| *** pmackinn has quit IRC | 15:13 | |
| *** sabeen has joined #openstack-trove | 15:19 | |
| *** sabeen2 has joined #openstack-trove | 15:21 | |
| *** sabeen has quit IRC | 15:24 | |
| *** amrith is now known as _amrith_ | 15:35 | |
| *** sabeen2 has quit IRC | 15:53 | |
| *** _amrith_ is now known as amrith | 15:59 | |
| *** sabeen has joined #openstack-trove | 16:00 | |
| *** pmackinn has joined #openstack-trove | 16:01 | |
| *** ashleighfarnham has joined #openstack-trove | 16:07 | |
| *** amit213 has quit IRC | 16:17 | |
| *** amit213 has joined #openstack-trove | 16:17 | |
| *** amrith is now known as _amrith_ | 16:19 | |
| *** imandhan has quit IRC | 16:48 | |
| *** exploreshaifali has joined #openstack-trove | 16:57 | |
| *** _amrith_ is now known as amrith | 17:09 | |
| *** tosky has quit IRC | 17:53 | |
| pmalik | .? | 18:02 |
| vkmc | .¿ | 18:02 |
| *** saurabhs has joined #openstack-trove | 18:03 | |
| *** amrith is now known as _amrith_ | 18:04 | |
| *** imandhan has joined #openstack-trove | 18:08 | |
| *** cweid has joined #openstack-trove | 18:38 | |
| *** sgotliv has joined #openstack-trove | 18:40 | |
| *** sabeen has quit IRC | 18:44 | |
| *** sabeen has joined #openstack-trove | 18:48 | |
| openstackgerrit | Merged openstack/trove: Updated from global requirements https://review.openstack.org/221938 | 18:49 |
| openstackgerrit | Merged openstack/trove: Fixes the mgmt.test_datastores errors https://review.openstack.org/220419 | 18:51 |
| SlickNik | vgnbkr: Do you know if the patch that cp16net? put up fixed the issue. Do you have a link to the said patch? | 18:57 |
| cp16net | i think my patch was for a different issue | 18:58 |
| cp16net | but related to reusing the ENGINE global var | 18:59 |
| cp16net | https://github.com/openstack/trove/blame/master/trove/guestagent/datastore/mysql/service_base.py#L1037 | 19:00 |
| cp16net | it was related to reseting the admin password method | 19:00 |
| cp16net | when syncing the passwords for a cluster | 19:00 |
| cp16net | the secure method is doing something similar in that reguard tho | 19:01 |
| SlickNik | Ah, I see. | 19:02 |
| cp16net | vgnbkr: you should replace those 2 lines from reset_admin_password with your new method as well. | 19:05 |
| SlickNik | So here's what I'm thinking. Given that this condition is pretty rare (low severity), the fact that the fix for https://bugs.launchpad.net/trove/+bug/1484653 needs some work (unit tests need to be added), and that this patch needs some TLC for the merge conflict, I'm okay with moving it out to Mitaka. What say? | 19:06 |
| openstack | Launchpad bug 1484653 in Trove "mysql guest caches ENGINE before password set" [Medium,In progress] - Assigned to Morgan Jones (6-morgan) | 19:06 |
| openstackgerrit | Merged openstack/trove: Fix Postgres services management https://review.openstack.org/224879 | 19:06 |
| cp16net | that sounds good to me. (i havnt seen this except when i was doing cluster work) | 19:07 |
| *** exploreshaifali has quit IRC | 19:15 | |
| vgnbkr | SlickNik, cp16net : re ENGINE: Noted. | 19:17 |
| *** jwiles_ has joined #openstack-trove | 19:41 | |
| cp16net | vkmc or peterstac mind looking at this? | 19:56 |
| cp16net | thx | 19:57 |
| vkmc | cp16net, define this | 19:57 |
| cp16net | LOL | 19:58 |
| vkmc | haha | 19:58 |
| cp16net | must have been telepathy because you approved it right after i said that | 19:58 |
| vkmc | oh! the SlickNik patch for the remote.py | 19:59 |
| cp16net | yup | 19:59 |
| vkmc | yeah it looks good and we also tested it in an environment :) | 19:59 |
| vkmc | pmackinn, ^ | 19:59 |
| cp16net | nice | 19:59 |
| *** vkmc is now known as vkmc-afk | 20:32 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Add MySQL int-test helper client https://review.openstack.org/224363 | 20:33 |
| openstackgerrit | Petr Malik proposed openstack/trove: Add MySQL int-test helper client https://review.openstack.org/224363 | 20:34 |
| *** jwiles_ has quit IRC | 20:34 | |
| peterstac | cp16net, SlickNik I made a few comments on https://review.openstack.org/#/c/193010 | 20:39 |
| *** pmackinn has quit IRC | 20:43 | |
| *** IanGovett has quit IRC | 20:45 | |
| *** _amrith_ is now known as amrith | 20:46 | |
| *** tomblank has quit IRC | 20:47 | |
| cp16net | peterstac: i see those comments. but i also heard from vkmc-afk that pmackinn tested it | 20:47 |
| peterstac | cp16net, yeah, not sure how that is. Unless you can pass in a tenant_name for the tenant_id field | 20:48 |
| peterstac | I remember a changeset a little while back supposedly fixing that bug | 20:48 |
| peterstac | now the CONF param has come back | 20:49 |
| openstackgerrit | Craig Vyvial proposed openstack/trove: Allow more instances than cluster_member_count for pxc https://review.openstack.org/222468 | 20:50 |
| cp16net | i recall something as well | 20:51 |
| cp16net | but i think it was because the conf was phased out somewhere | 20:51 |
| cp16net | i want to say for notifications or something like that | 20:51 |
| peterstac | here's the changeset: https://review.openstack.org/#/c/164224/ | 20:52 |
| *** eglute has quit IRC | 20:55 | |
| *** eglute has joined #openstack-trove | 20:55 | |
| cp16net | peterstac: so yeah it was removed because that param was not used | 20:56 |
| *** crobertsrh is now known as _crobertsrh | 20:57 | |
| cp16net | edmondk: re: Should this be named ClusterNumInstancesNotGreaterorEqual? | 20:58 |
| cp16net | how about instead ClusterNumInstancesNotLargeEnough | 20:59 |
| cp16net | context for others: https://review.openstack.org/#/c/222468/3/trove/common/strategies/cluster/experimental/pxc/api.py,cm | 20:59 |
| peterstac | cp16net, I'll ask atomic77 to take a look at the changeset, since he made the tenant_name -> tenant_id change | 21:00 |
| cp16net | sounds good | 21:00 |
| SlickNik | peterstac / cp16net: Just saw your messages. | 21:00 |
| peterstac | SlickNik, can you shed some light on the topic? :) | 21:00 |
| SlickNik | I now recall that previous novaclient change. | 21:00 |
| cp16net | it might be related to an older novaclient? | 21:01 |
| *** arist has quit IRC | 21:01 | |
| SlickNik | peterstac / cp16net: Not 100% sure, looking into it. | 21:01 |
| cp16net | k | 21:01 |
| *** arist has joined #openstack-trove | 21:01 | |
| cp16net | thx SlickNik | 21:01 |
| peterstac | SlickNik, thx! | 21:05 |
| *** tomblank has joined #openstack-trove | 21:07 | |
| *** tomblank has quit IRC | 21:09 | |
| SlickNik | So looking at the nova-client code, that should the third parameter corresponds to project_id | 21:17 |
| SlickNik | Which is what gets set in the HTTP headers as X-Auth-Project-Id | 21:18 |
| SlickNik | https://github.com/openstack/python-novaclient/blob/4d1def5f97ad0a43a3fed563b94ae2f83a856b1b/novaclient/client.py#L421-L422 | 21:18 |
| SlickNik | And this actually needs to be the tenant name! | 21:18 |
| SlickNik | So what we have in the remote is correct. | 21:18 |
| SlickNik | ^cp16net, peterstac | 21:20 |
| *** amrith is now known as _amrith_ | 21:22 | |
| edmondk | cp16net, yeah I think that's more clear | 21:27 |
| edmondk | ClusterNumInstancesInvalid | 21:27 |
| edmondk | would also work | 21:27 |
| openstackgerrit | Merged openstack/trove: Enable deploying Trove instances into single tenant https://review.openstack.org/193010 | 21:33 |
| openstackgerrit | Craig Vyvial proposed openstack/trove: Allow more instances than cluster_member_count for pxc https://review.openstack.org/222468 | 21:36 |
| *** vkmc-afk is now known as vkmc | 21:54 | |
| vkmc | there was a bug in nova client | 21:54 |
| vkmc | with that | 21:54 |
| vkmc | it doesn't use the id, it uses the name | 21:54 |
| vkmc | I remember we had a warning in Trove taskmanager logs for that as well | 21:54 |
| SlickNik | vkmc: yeah, that's what I'm seeing as well. Even though nova calls it "project-id" it's actually the project (tenant) name. | 21:55 |
| vkmc | yup | 21:56 |
| *** vkmc has quit IRC | 22:05 | |
| *** vkmc has joined #openstack-trove | 22:06 | |
| *** imandhan has quit IRC | 22:11 | |
| *** openstackgerrit has quit IRC | 22:16 | |
| *** openstackgerrit has joined #openstack-trove | 22:16 | |
| openstackgerrit | Craig Vyvial proposed openstack/trove: Allow more instances than cluster_member_count for pxc https://review.openstack.org/222468 | 22:16 |
| pmalik | SlickNik, cp16net vkmc sushilkm _amrith_ Hi, could we possibly get some more eyes at this bugfix? https://review.openstack.org/#/c/218382/ Thanks. :-) | 22:24 |
| vkmc | sure thing | 22:24 |
| *** imandhan has joined #openstack-trove | 22:24 | |
| *** csoukup has quit IRC | 22:32 | |
| *** sabeen has quit IRC | 22:46 | |
| *** imandhan has quit IRC | 22:53 | |
| openstackgerrit | Nikhil Manchanda proposed openstack/trove: Open Mitaka Development https://review.openstack.org/227049 | 23:29 |
| *** cweid has quit IRC | 23:32 | |
| *** saurabhs has quit IRC | 23:32 | |
| SlickNik | cp16net: your new patch is failing python2.7 tests | 23:37 |
| SlickNik | Can you please take a look at https://jenkins04.openstack.org/job/gate-trove-python27/289/console when you get a chance? | 23:37 |
| SlickNik | It's currently the only patch that hasn't merged for RC1 :) | 23:37 |
| SlickNik | I think it just needs a rebase — I can take care of that. | 23:41 |
| *** saurabhs has joined #openstack-trove | 23:44 | |
| *** saurabhs has quit IRC | 23:44 | |
| openstackgerrit | Nikhil Manchanda proposed openstack/trove: Allow more instances than cluster_member_count for pxc https://review.openstack.org/222468 | 23:46 |
| *** sandrelymv has joined #openstack-trove | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!