| *** sabeen1 has quit IRC | 00:02 | |
| *** bapalm has quit IRC | 00:03 | |
| *** ashleighfarnham has quit IRC | 00:04 | |
| *** bapalm has joined #openstack-trove | 00:04 | |
| *** ashleighfarnham has joined #openstack-trove | 00:04 | |
| *** ashleighfarnham has quit IRC | 00:05 | |
| *** ashleighfarnham has joined #openstack-trove | 00:06 | |
| *** ashleighfarnham has quit IRC | 00:10 | |
| *** mingdang1 has joined #openstack-trove | 00:31 | |
| *** ViswaV has joined #openstack-trove | 00:36 | |
| *** sabeen has joined #openstack-trove | 01:41 | |
| *** exploreshaifali has quit IRC | 01:42 | |
| *** _imandhan_ has quit IRC | 01:51 | |
| *** imandhan has joined #openstack-trove | 01:52 | |
| *** imandhan has quit IRC | 01:57 | |
| *** _amrith_ is now known as amrith | 02:14 | |
| cp16net | hey amrith | 02:16 |
|---|---|---|
| cp16net | reading over one of the reviews right now reminds me of a bug that i dont know if it was fixed reguarding backups with mysql | 02:17 |
| cp16net | has anyone seen the instance state get stuck in BACKUP if the backup procsess on the guest dies for a random reason? i.e. out of memory ram or local disk. | 02:19 |
| amrith | cp16net, hello | 02:20 |
| amrith | question 1: which review. | 02:20 |
| amrith | question 2: got beer? | 02:20 |
| cp16net | review doesnt really matter | 02:21 |
| cp16net | my question was an abstract one | 02:21 |
| amrith | ok, let me think. | 02:21 |
| cp16net | but the review i was looking at was https://review.openstack.org/#/c/243247 | 02:21 |
| amrith | no I don't remember a bug regarding stuck in backup state recently but in the way back machine I remember something that denis was doing related to OOM | 02:22 |
| amrith | cp16net, that wasn't one of my reviews but I see what you mean, that the review is immaterial. you just thought about it while looking at this review. | 02:22 |
| cp16net | yep | 02:23 |
| *** haomaiwang has joined #openstack-trove | 02:32 | |
| *** ViswaV has quit IRC | 02:35 | |
| *** haomaiwang has quit IRC | 02:37 | |
| *** haomaiwang has joined #openstack-trove | 02:38 | |
| amrith | cp16net, is this the bug you are thinking about? | 03:02 |
| amrith | https://bugs.launchpad.net/trove/+bug/1252897 | 03:02 |
| openstack | Launchpad bug 1252897 in Trove "Instances can be stuck in BACKUP status" [Low,In progress] - Assigned to Nikhil Manchanda (slicknik) | 03:02 |
| amrith | best I could come up with | 03:03 |
| amrith | anyway, got to run now | 03:03 |
| SlickNik | Wow, that's still assigned to me? | 03:04 |
| *** amrith is now known as _amrith_ | 03:22 | |
| cp16net | no i think it would something else | 03:38 |
| cp16net | yeah slow progress... :-P | 03:38 |
| *** swebb has quit IRC | 04:07 | |
| *** swebb has joined #openstack-trove | 04:12 | |
| *** imandhan has joined #openstack-trove | 04:35 | |
| openstackgerrit | Ishita Mandhan proposed openstack/trove: Addition of DB2 backup & restore functionality https://review.openstack.org/246709 | 05:03 |
| *** stevemar_ has quit IRC | 05:34 | |
| *** stevemar_ has joined #openstack-trove | 05:35 | |
| *** stevemar_ has quit IRC | 05:38 | |
| *** ShrutiJ has joined #openstack-trove | 05:40 | |
| *** haomaiwang has quit IRC | 05:46 | |
| *** pmackinn has quit IRC | 05:56 | |
| *** haomaiwang has joined #openstack-trove | 05:59 | |
| *** imandhan_ has joined #openstack-trove | 06:00 | |
| *** sabeen has quit IRC | 06:03 | |
| *** haomaiwang has quit IRC | 06:14 | |
| *** haomaiwa_ has joined #openstack-trove | 06:18 | |
| *** rcernin has joined #openstack-trove | 06:30 | |
| *** haomaiwa_ has quit IRC | 06:43 | |
| *** tornopil has quit IRC | 06:46 | |
| *** haomaiwang has joined #openstack-trove | 06:53 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-trove | 07:02 | |
| *** tornopil has joined #openstack-trove | 07:20 | |
| *** haomaiwang has quit IRC | 07:25 | |
| *** haomaiwang has joined #openstack-trove | 07:26 | |
| *** imandhan has quit IRC | 07:44 | |
| *** csoukup has joined #openstack-trove | 07:50 | |
| *** ShrutiJ has quit IRC | 07:50 | |
| *** haomaiwang has quit IRC | 07:59 | |
| *** csoukup has quit IRC | 08:00 | |
| *** haomaiwang has joined #openstack-trove | 08:02 | |
| *** imandhan_ has quit IRC | 08:07 | |
| *** imandhan has joined #openstack-trove | 08:44 | |
| *** imandhan has quit IRC | 08:49 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-trove | 09:01 | |
| *** k4n0 has joined #openstack-trove | 09:06 | |
| *** haomaiwang has quit IRC | 09:25 | |
| *** haomaiwang has joined #openstack-trove | 09:27 | |
| *** sgotliv has joined #openstack-trove | 09:34 | |
| *** haomaiwang has quit IRC | 09:37 | |
| *** haomaiwang has joined #openstack-trove | 09:42 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Experimental datastores use new service commands https://review.openstack.org/245399 | 09:47 |
| *** denismakogon has joined #openstack-trove | 10:04 | |
| *** imandhan has joined #openstack-trove | 10:09 | |
| *** haomaiwang has quit IRC | 10:10 | |
| *** imandhan has quit IRC | 10:13 | |
| *** haomaiwang has joined #openstack-trove | 10:16 | |
| *** haomaiwang has quit IRC | 10:28 | |
| *** haomaiwang has joined #openstack-trove | 10:28 | |
| *** mingdang1 has quit IRC | 10:56 | |
| *** mingdang1 has joined #openstack-trove | 11:02 | |
| *** haomaiwang has quit IRC | 11:08 | |
| *** mingdang1 has quit IRC | 11:11 | |
| *** denismakogon has quit IRC | 11:47 | |
| *** haomaiwa_ has joined #openstack-trove | 12:05 | |
| *** _amrith_ is now known as amrith | 12:14 | |
| *** denismakogon has joined #openstack-trove | 12:37 | |
| *** tellesnobrega is now known as tellesnobrega_af | 13:10 | |
| *** johnma has joined #openstack-trove | 13:11 | |
| *** tornopil has quit IRC | 13:13 | |
| *** pmackinn has joined #openstack-trove | 13:21 | |
| *** mingdang1 has joined #openstack-trove | 13:32 | |
| *** amrith is now known as _amrith_ | 13:43 | |
| *** sgotliv has quit IRC | 13:47 | |
| *** tellesnobrega_af has quit IRC | 14:02 | |
| *** tellesnobrega_af has joined #openstack-trove | 14:02 | |
| *** tellesno` has joined #openstack-trove | 14:02 | |
| *** tellesno` is now known as tellesnobrega_af | 14:02 | |
| *** imandhan has joined #openstack-trove | 14:10 | |
| *** stevemar_ has joined #openstack-trove | 14:13 | |
| *** bhaskarduvvuri has joined #openstack-trove | 14:14 | |
| *** imandhan has quit IRC | 14:14 | |
| *** tellesnobrega_af is now known as tellesnobrega | 14:30 | |
| *** _amrith_ is now known as amrith | 15:05 | |
| *** stevemar_ has quit IRC | 15:10 | |
| *** haomaiwa_ has quit IRC | 15:12 | |
| *** bhaskarduvvuri has quit IRC | 15:13 | |
| *** mingdang1 has quit IRC | 15:22 | |
| amrith | vkmc, yt? | 15:27 |
| vkmc | amrith, hey! | 15:28 |
| amrith | re: https://review.openstack.org/#/c/245845/1 | 15:28 |
| amrith | Please read the CONTRIBUTING.rst for Trove. | 15:28 |
| amrith | A rating of 0 on a code review is indicated if: | 15:28 |
| amrith | The reason why you believe that the proposed change needs improvement is merely an opinion, | 15:28 |
| amrith | You have a question, or need a clarification from the author, | 15:28 |
| amrith | The proposed change is functional but you believe that there is a different, better, or more appropriate way in which to achieve the end result being sought by the proposed change, | 15:28 |
| amrith | There are 500+ places in the trove code base where variables include the name slave or slave_of | 15:29 |
| amrith | if you want to fix that, please go ahead. | 15:29 |
| amrith | The stated intent of the bug I'm fixing is to remove it in user visible interfaces. | 15:29 |
| amrith | changing variable names or suggestions to use more intuitive variable names don't constitute a reason to -1 a change. | 15:29 |
| vkmc | I -1'd it to have a chat about it | 15:30 |
| amrith | sorry, I dont' think -1 is a way to chat about things. | 15:30 |
| amrith | if you want to chat about it, chat about it. | 15:30 |
| vkmc | as said in the review, if you think this patch is urgent and/or you consider that shouldn't be fixed in this patchset, then we can move it forward | 15:30 |
| amrith | it has nothing to do with urgency | 15:30 |
| vkmc | not really, I won't leave a +1 if I don't think some patch is ready to move forward | 15:31 |
| amrith | sounds good, leave a 0 | 15:31 |
| amrith | you are not required to +1 something | 15:31 |
| amrith | I'm just pointing out that your -1 is not a reasonable one (IMHO) | 15:31 |
| amrith | if everyone feels otherwise, I'll abandon the patch set till someone wants to fix it. | 15:31 |
| *** k4n0 has quit IRC | 15:32 | |
| *** tornopil has joined #openstack-trove | 15:32 | |
| vkmc | the reasoning behind that -1 (and not 0) is because I think the PS affects the quality of the code | 15:32 |
| vkmc | we have two options | 15:32 |
| vkmc | or we fix the vars naming in that ps, or we file a bug and do it later on | 15:32 |
| amrith | that is an opinion. | 15:32 |
| vkmc | well, reviews are about opinions, right? | 15:33 |
| amrith | feel free to file a bug if you want. | 15:33 |
| amrith | NO | 15:33 |
| amrith | review comments with -1 are not opinions | 15:33 |
| amrith | please read CONTRIBUTING.rst. | 15:33 |
| amrith | "The reason why you believe that the proposed change needs improvement is merely an opinion" | 15:33 |
| amrith | we have a third option, feel free to submit a new patchset which fixes the spelling. | 15:34 |
| amrith | if you feel so strongly about it, go ahead. | 15:34 |
| vkmc | sure :) | 15:34 |
| amrith | and do it across the code base while you are about it. | 15:34 |
| *** rcernin has quit IRC | 15:34 | |
| vkmc | will do | 15:35 |
| vkmc | sed'ing the code should be enough | 15:36 |
| vkmc | and will make future contributors really happy since they will be able to understand the code | 15:36 |
| amrith | sed'ing through the code is not sufficient as you will discover. | 15:38 |
| amrith | been there, done that, have the tourist map to prove it. | 15:40 |
| vkmc | all right, let's see what it can be done | 15:40 |
| vkmc | thanks for working on it amrith! | 15:40 |
| amrith | no, thank you for volunteering to do it! oh, while you are about it, there's the variable naming on the client side as well ;) | 15:42 |
| amrith | i assume that in the meanwhile my patches can go ahead while you work on this? | 15:43 |
| amrith | or am I wrong? | 15:43 |
| vkmc | sure :) | 15:43 |
| amrith | your -1 please ... | 15:44 |
| vkmc | removed! | 15:47 |
| *** tornopil has quit IRC | 15:49 | |
| dougshelley66 | vkmc amrith well i have an opinion... | 15:49 |
| amrith | go ahead | 15:50 |
| amrith | opinions are great | 15:50 |
| dougshelley66 | sometimes the best change to the code is no change | 15:50 |
| amrith | In this case, I agree. hence I made no change (to the variable names). The user visible part was an abomination which we had agreed to fix to clean up the API. | 15:52 |
| amrith | but, I see the argument for not changing that either. | 15:52 |
| *** tellesnobrega is now known as tellesnobrega_af | 15:52 | |
| amrith | and I'd be fine with that too. | 15:52 |
| *** tellesnobrega_af is now known as tellesnobrega | 15:52 | |
| *** stevemar_ has joined #openstack-trove | 15:52 | |
| amrith | So if your comment on both reviews was that they are collectively a waste of time, I respect that (and would abandon both of them). | 15:53 |
| vkmc | I just want to make sure we keep the consistency on what we are doing | 15:55 |
| vkmc | I understand the concern though | 15:55 |
| *** bhaskarduvvuri has joined #openstack-trove | 15:58 | |
| *** stevemar_ has quit IRC | 15:58 | |
| *** stevemar_ has joined #openstack-trove | 15:59 | |
| *** rcernin has joined #openstack-trove | 16:00 | |
| *** rcernin is now known as rcernin|dinner | 16:00 | |
| *** superflyy has joined #openstack-trove | 16:07 | |
| *** imandhan has joined #openstack-trove | 16:11 | |
| bhaskarduvvuri | I have a question on current images. Is there anyway, we can use a normal ubuntu image, add trove-guestagent.conf in conf.d folder and then let Trove server upload the file? | 16:14 |
| *** imandhan has quit IRC | 16:15 | |
| *** stevemar_ has quit IRC | 16:26 | |
| *** sabeen1 has joined #openstack-trove | 16:39 | |
| *** stevemar_ has joined #openstack-trove | 16:39 | |
| *** denismakogon has quit IRC | 16:40 | |
| *** rcernin|dinner is now known as rcernin | 16:42 | |
| *** amrith is now known as _amrith_ | 16:42 | |
| *** superflyy has quit IRC | 16:43 | |
| *** stevemar_ has quit IRC | 16:44 | |
| *** denismakogon has joined #openstack-trove | 16:44 | |
| *** stevemar_ has joined #openstack-trove | 16:45 | |
| *** denismakogon has quit IRC | 16:48 | |
| *** stevemar_ has quit IRC | 16:59 | |
| *** stevemar_ has joined #openstack-trove | 17:00 | |
| openstackgerrit | Merged openstack/trove: Refactor the datastore manager classes (more) https://review.openstack.org/234462 | 17:04 |
| *** stevemar_ has quit IRC | 17:04 | |
| *** sabeen3 has joined #openstack-trove | 17:12 | |
| *** sabeen1 has quit IRC | 17:12 | |
| *** bhaskarduvvuri has quit IRC | 17:15 | |
| *** denismakogon has joined #openstack-trove | 17:35 | |
| *** ViswaV has joined #openstack-trove | 17:35 | |
| openstackgerrit | Craig Vyvial proposed openstack/trove: fix mongo create database https://review.openstack.org/246590 | 17:37 |
| *** ViswaV has quit IRC | 17:40 | |
| *** ViswaV has joined #openstack-trove | 17:41 | |
| *** itisha has joined #openstack-trove | 17:46 | |
| *** _amrith_ is now known as amrith | 17:52 | |
| *** denismakogon has quit IRC | 17:55 | |
| *** ashleighfarnham has joined #openstack-trove | 17:58 | |
| *** _hanhart has joined #openstack-trove | 18:04 | |
| openstackgerrit | Merged openstack/trove: Delete python bytecode before every test run https://review.openstack.org/246064 | 18:08 |
| *** imandhan has joined #openstack-trove | 18:11 | |
| *** _hanhart has quit IRC | 18:19 | |
| *** stevemar_ has joined #openstack-trove | 18:46 | |
| *** stevemar_ has quit IRC | 18:48 | |
| *** stevemar_ has joined #openstack-trove | 18:48 | |
| amrith | cp16net, SlickNik, vkmc, edmondk, peterstac ... we should pay attention to https://review.openstack.org/#/c/182445/ | 18:54 |
| *** sabeen3 has quit IRC | 19:03 | |
| *** denismakogon has joined #openstack-trove | 19:04 | |
| openstackgerrit | Matthew Van Dijk proposed openstack/trove: Add better input checking for MongoDB https://review.openstack.org/247744 | 19:04 |
| peterstac | amrith, That shouldn't affect us, as long as it's implemented correctly, tho, right? | 19:09 |
| *** rjaiswal has joined #openstack-trove | 19:11 | |
| amrith | peterstac, yes but we in Trove also use the same paradigm of managing deltas and can suffer the same kind(s) of issues that Nova is talking about. | 19:12 |
| *** arist has quit IRC | 19:12 | |
| *** arist has joined #openstack-trove | 19:12 | |
| peterstac | Ah, I get it | 19:12 |
| peterstac | So if what they do works, we can mimic it ... | 19:13 |
| *** stevemar_ has quit IRC | 19:13 | |
| *** stevemar_ has joined #openstack-trove | 19:16 | |
| *** sabeen1 has joined #openstack-trove | 19:20 | |
| amrith | yes, we should at least pay attention to it, I think. it may be useful to learn from it. | 19:21 |
| openstackgerrit | Petr Malik proposed openstack/trove: Finish cluster int-tests https://review.openstack.org/244176 | 19:23 |
| *** denismakogon has quit IRC | 19:26 | |
| cp16net | yeah i'm curious how the end product of that will look | 19:34 |
| dougshelley66 | does anyone know of any available doc/blog posts/notes on how to configure the trove api endpoint for SSL? | 19:55 |
| openstackgerrit | Petr Malik proposed openstack/trove-specs: PostgreSQL Configuration Groups https://review.openstack.org/245893 | 20:03 |
| openstackgerrit | Petr Malik proposed openstack/trove-specs: PostgreSQL Configuration Groups https://review.openstack.org/245893 | 20:05 |
| pmalik | SlickNik vkmc cp16net edmondk Hi! Waiting for one more +2. Thx. https://review.openstack.org/#/c/243247/ | 20:06 |
| amrith | cp16net, I'm curious as well. | 20:14 |
| amrith | It is barbacue time! | 20:14 |
| cp16net | bar-b-q you mean | 20:17 |
| amrith | bbq | 20:33 |
| amrith | you are invited cp16net | 20:33 |
| cp16net | amrith: i dunno if it would live up to my standards :-P | 20:34 |
| amrith | you don't know till you try | 20:34 |
| dougshelley66 | it might be vegetarian bbq | 20:40 |
| dougshelley66 | i suspect that makes now sense to someone from Texas | 20:41 |
| cp16net | those 2 words dont belong together | 20:41 |
| cp16net | vegetarian + bbq | 20:41 |
| atomic77 | cp16net, you caused my irc client to crash! | 20:42 |
| atomic77 | the above operation is apparently unsupported :) | 20:42 |
| cp16net | lol | 20:43 |
| openstackgerrit | Petr Malik proposed openstack/trove-specs: PostgreSQL Configuration Groups https://review.openstack.org/245893 | 20:43 |
| cp16net | can not compute | 20:43 |
| openstackgerrit | Petr Malik proposed openstack/trove-specs: PostgreSQL Configuration Groups https://review.openstack.org/245893 | 20:46 |
| *** johnma has quit IRC | 20:55 | |
| *** openstackstatus has quit IRC | 21:02 | |
| *** openstack has joined #openstack-trove | 21:03 | |
| *** openstackstatus has joined #openstack-trove | 21:05 | |
| *** ChanServ sets mode: +v openstackstatus | 21:05 | |
| *** rjaiswal has quit IRC | 21:15 | |
| amrith | vegetarian bbq makes so much sense | 21:28 |
| *** stevemar_ has quit IRC | 21:31 | |
| *** amrith is now known as _amrith_ | 21:39 | |
| *** _amrith_ is now known as amrith | 21:39 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Experimental datastores use new service commands https://review.openstack.org/245399 | 21:42 |
| *** denismakogon has joined #openstack-trove | 21:43 | |
| *** rcernin has quit IRC | 21:50 | |
| *** denismakogon has quit IRC | 21:51 | |
| *** denismakogon has joined #openstack-trove | 21:53 | |
| *** amrith is now known as _amrith_ | 21:56 | |
| *** bhaskarduvvuri has joined #openstack-trove | 22:00 | |
| *** denismak_ has joined #openstack-trove | 22:06 | |
| *** denismakogon has quit IRC | 22:08 | |
| *** denismakogon has joined #openstack-trove | 22:09 | |
| *** denismak_ has quit IRC | 22:11 | |
| *** bhaskarduvvuri has quit IRC | 22:13 | |
| *** ashleighfarnham has quit IRC | 22:14 | |
| *** denismak_ has joined #openstack-trove | 22:21 | |
| *** tellesnobrega is now known as tellesnobrega_af | 22:22 | |
| *** tellesnobrega_af is now known as tellesnobrega | 22:23 | |
| *** denismakogon has quit IRC | 22:23 | |
| *** denismakogon has joined #openstack-trove | 22:26 | |
| *** denismak_ has quit IRC | 22:28 | |
| *** denismak_ has joined #openstack-trove | 22:31 | |
| *** denismakogon has quit IRC | 22:32 | |
| *** ashleighfarnham has joined #openstack-trove | 22:33 | |
| *** denismakogon has joined #openstack-trove | 22:36 | |
| *** denismak_ has quit IRC | 22:38 | |
| *** denismak_ has joined #openstack-trove | 22:42 | |
| *** denismakogon has quit IRC | 22:43 | |
| *** denismakogon has joined #openstack-trove | 22:44 | |
| *** denismak_ has quit IRC | 22:46 | |
| *** denismakogon has quit IRC | 22:48 | |
| *** denismakogon has joined #openstack-trove | 22:49 | |
| *** denismakogon has quit IRC | 22:54 | |
| *** stevemar_ has joined #openstack-trove | 23:04 | |
| *** stevemar_ has quit IRC | 23:04 | |
| *** sabeen1 has quit IRC | 23:08 | |
| *** denismakogon has joined #openstack-trove | 23:38 | |
| *** denismakogon has quit IRC | 23:42 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!