*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-trove | 00:01 | |
*** tosky has quit IRC | 00:34 | |
*** bapalm has quit IRC | 00:37 | |
*** bapalm has joined #openstack-trove | 00:54 | |
*** cheneydc has joined #openstack-trove | 01:00 | |
*** haomaiwang has quit IRC | 01:01 | |
*** haomaiwang has joined #openstack-trove | 01:01 | |
openstackgerrit | Matt Riedemann proposed openstack/python-troveclient: Revert "Time to get rid of any last vestiges of slave_of" https://review.openstack.org/290048 | 01:14 |
---|---|---|
*** mriedem has joined #openstack-trove | 01:14 | |
mriedem | this should fix the trove issues for stable/liberty once it's released https://review.openstack.org/#/c/290048/ | 01:15 |
mriedem | that adds slave_of back into the client, but emits a deprecation warning if it's used | 01:15 |
mriedem | cp16net: ^ | 01:16 |
*** imandhan has quit IRC | 01:28 | |
*** imandhan has joined #openstack-trove | 01:28 | |
*** haomaiwang has quit IRC | 01:32 | |
*** imandhan has quit IRC | 01:33 | |
openstackgerrit | Merged openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/289726 | 01:36 |
openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Client support for instance module feature https://review.openstack.org/290177 | 01:38 |
*** _amrith_ is now known as amrith | 01:55 | |
*** ashleighfarnham has quit IRC | 01:55 | |
*** mriedem has left #openstack-trove | 02:03 | |
*** imandhan has joined #openstack-trove | 02:17 | |
openstackgerrit | amrith proposed openstack/trove: Block pymongo version 3.1 https://review.openstack.org/290236 | 02:17 |
*** haomaiwang has joined #openstack-trove | 02:20 | |
*** haomaiwang has quit IRC | 02:24 | |
*** haomaiwa_ has joined #openstack-trove | 02:25 | |
*** haomaiwa_ has quit IRC | 02:26 | |
*** haomaiwa_ has joined #openstack-trove | 02:26 | |
*** haomaiwa_ has quit IRC | 02:27 | |
*** 20WAAIE7U has joined #openstack-trove | 02:27 | |
*** 20WAAIE7U has quit IRC | 02:28 | |
*** haomaiwa_ has joined #openstack-trove | 02:28 | |
*** haomaiwa_ has quit IRC | 02:29 | |
*** haomaiwang has joined #openstack-trove | 02:29 | |
*** haomaiwang has quit IRC | 02:30 | |
*** haomaiwang has joined #openstack-trove | 02:30 | |
*** haomaiwang has quit IRC | 02:31 | |
*** haomaiwang has joined #openstack-trove | 02:31 | |
*** haomaiwang has quit IRC | 02:32 | |
*** haomaiwang has joined #openstack-trove | 02:32 | |
*** haomaiwang has quit IRC | 02:33 | |
*** haomaiwang has joined #openstack-trove | 02:33 | |
*** haomaiwang has quit IRC | 02:34 | |
amrith | vkmc, johnma, SlickNik, cp16net, peterstac ... anyone there? would you +2 https://review.openstack.org/290236? I'll wait a bit and if no one else is around, I'll push it over the line. | 02:39 |
*** pmackinn has quit IRC | 02:40 | |
*** mingdang1 has joined #openstack-trove | 02:42 | |
*** csoukup has joined #openstack-trove | 02:43 | |
peterstac | no rush - the requirements changeset needs to merge first and it hasn't be approved yet | 02:46 |
*** csoukup has quit IRC | 02:47 | |
*** itisha has quit IRC | 02:59 | |
amrith | thanks peterstac | 02:59 |
*** tqtran has quit IRC | 03:00 | |
amrith | yes, as soon as the change on requirements merges, I can kick this over theline. | 03:00 |
*** haomaiwang has joined #openstack-trove | 03:14 | |
*** imandhan has quit IRC | 03:16 | |
*** csoukup has joined #openstack-trove | 03:33 | |
*** haomaiwang has quit IRC | 03:40 | |
*** haomaiw__ has joined #openstack-trove | 03:40 | |
*** csoukup has quit IRC | 03:45 | |
*** amrith has left #openstack-trove | 03:51 | |
*** amrith has joined #openstack-trove | 03:52 | |
amrith | peterstac, the change on trove passed tests. once the g-r change merges, I'll push this change over the line. | 03:52 |
peterstac | amrith, sounds good | 03:52 |
peterstac | it passed the check, but is still waiting the wf+1 | 03:53 |
amrith | yes, I'm not wf +1'ing it now because that'll just cause it to go and wait for the g-r change to merge. | 03:55 |
amrith | I'll have to recheck again anyway (I think) | 03:55 |
amrith | so may as well wait and let others review it. | 03:56 |
amrith | that's my thinking... | 03:56 |
amrith | g'night | 03:56 |
peterstac | later | 03:57 |
*** links has joined #openstack-trove | 04:03 | |
*** amrith is now known as _amrith_ | 04:10 | |
*** imandhan has joined #openstack-trove | 04:17 | |
*** imandhan has quit IRC | 04:22 | |
*** fifieldt has joined #openstack-trove | 04:47 | |
*** pbelamge has joined #openstack-trove | 04:52 | |
*** imandhan has joined #openstack-trove | 05:03 | |
openstackgerrit | Peter Stachowski proposed openstack/trove: Server support for instance module feature https://review.openstack.org/290275 | 05:24 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/290287 | 06:08 |
*** rcernin has joined #openstack-trove | 06:09 | |
*** sgotliv has joined #openstack-trove | 06:17 | |
*** imandhan has quit IRC | 06:37 | |
*** chlong has quit IRC | 06:54 | |
*** chlong has joined #openstack-trove | 07:07 | |
*** sgotliv has quit IRC | 07:14 | |
*** eglute has quit IRC | 07:35 | |
*** itisha has joined #openstack-trove | 08:07 | |
*** sgotliv has joined #openstack-trove | 08:38 | |
*** openstackgerrit has quit IRC | 08:47 | |
*** openstackgerrit has joined #openstack-trove | 08:47 | |
*** links has quit IRC | 08:55 | |
*** bapalm has quit IRC | 09:14 | |
*** eglute has joined #openstack-trove | 09:24 | |
*** bapalm has joined #openstack-trove | 09:27 | |
*** jengeb has joined #openstack-trove | 09:30 | |
*** _amrith_ is now known as amrith | 09:41 | |
*** cheneydc has quit IRC | 10:00 | |
*** tosky has joined #openstack-trove | 10:41 | |
*** haomaiw__ has quit IRC | 10:45 | |
*** jengeb1 has joined #openstack-trove | 11:07 | |
*** jengeb has quit IRC | 11:12 | |
*** mingdang1 has quit IRC | 11:27 | |
*** chlong has quit IRC | 11:42 | |
*** links has joined #openstack-trove | 11:48 | |
*** amrith is now known as _amrith_ | 11:51 | |
*** chlong has joined #openstack-trove | 12:14 | |
*** nshah_ has joined #openstack-trove | 12:25 | |
*** nshah has quit IRC | 12:27 | |
*** jengeb1 has quit IRC | 12:27 | |
*** chlong has quit IRC | 12:27 | |
*** pmalik has quit IRC | 12:27 | |
*** nshah_ is now known as nshah | 12:27 | |
*** bapalm has quit IRC | 12:27 | |
*** pmalik_ has joined #openstack-trove | 12:27 | |
*** bapalm has joined #openstack-trove | 12:27 | |
*** chlong has joined #openstack-trove | 12:40 | |
*** jengeb has joined #openstack-trove | 12:40 | |
*** jengeb has quit IRC | 12:53 | |
*** pmackinn has joined #openstack-trove | 13:06 | |
*** _amrith_ is now known as amrith | 13:20 | |
*** links has quit IRC | 13:35 | |
*** jengeb has joined #openstack-trove | 13:40 | |
*** jengeb has quit IRC | 13:54 | |
*** fifieldt has quit IRC | 14:16 | |
*** mingdang1 has joined #openstack-trove | 14:28 | |
*** mingdang1 has quit IRC | 14:32 | |
*** ewilson has joined #openstack-trove | 14:33 | |
*** ewilson has quit IRC | 14:34 | |
*** pmackinn has quit IRC | 14:37 | |
*** pmackinn has joined #openstack-trove | 14:38 | |
*** jengeb has joined #openstack-trove | 14:47 | |
pmackinn | https://blogs.microsoft.com/blog/2016/03/07/announcing-sql-server-on-linux/ | 14:47 |
*** haomaiwang has joined #openstack-trove | 14:49 | |
*** haomaiwang has quit IRC | 15:01 | |
*** haomaiwa_ has joined #openstack-trove | 15:01 | |
*** pbelamge has quit IRC | 15:15 | |
amrith | pmackinn, have you ordered your SQL Server books yet ;) | 15:15 |
openstackgerrit | Matthew Van Dijk proposed openstack/trove: Add MongoDB cluster root-enable support https://review.openstack.org/290581 | 15:25 |
*** johnma has joined #openstack-trove | 15:25 | |
*** jengeb1 has joined #openstack-trove | 15:30 | |
*** jengeb has quit IRC | 15:32 | |
pmackinn | amrith, ubuntu-only preview! where's the love, i ask? | 15:50 |
*** pmackinn has quit IRC | 15:51 | |
*** haomaiwa_ has quit IRC | 16:01 | |
*** haomaiwang has joined #openstack-trove | 16:01 | |
*** itisha has quit IRC | 16:19 | |
*** ediardo has joined #openstack-trove | 16:25 | |
*** haomaiwang has quit IRC | 16:53 | |
*** pmackinn has joined #openstack-trove | 16:56 | |
*** jengeb1 has quit IRC | 16:57 | |
*** tosky has quit IRC | 16:57 | |
*** haomaiwang has joined #openstack-trove | 17:00 | |
*** haomaiwang has quit IRC | 17:01 | |
*** ashleighfarnham has joined #openstack-trove | 17:01 | |
*** ashleigh_ has joined #openstack-trove | 17:06 | |
*** ashleighfarnham has quit IRC | 17:06 | |
*** haomaiwa_ has joined #openstack-trove | 17:08 | |
*** rcernin has quit IRC | 17:09 | |
*** ediardo has quit IRC | 17:10 | |
*** tellesnobrega has joined #openstack-trove | 17:17 | |
*** jengeb has joined #openstack-trove | 17:17 | |
*** jengeb1 has joined #openstack-trove | 17:20 | |
*** jengeb has quit IRC | 17:22 | |
*** ewilson has joined #openstack-trove | 17:27 | |
*** sgotliv has quit IRC | 17:31 | |
*** imandhan has joined #openstack-trove | 18:00 | |
amrith | trove meeting starting in #openstack-meeting-alt now | 18:00 |
amrith | bring popcorn ... | 18:00 |
*** haomaiwa_ has quit IRC | 18:01 | |
*** 20WAAIK4T has joined #openstack-trove | 18:01 | |
*** tosky has joined #openstack-trove | 18:05 | |
openstackgerrit | Petr Malik proposed openstack/trove: PG test-helper create matching db for test user https://review.openstack.org/278115 | 18:07 |
pmalik_ | Hi. This already had +2 from cp16net It was held back because of a merge conflict. I have been running some Postgres tests. It would be nice to have it in. Thx. | 18:09 |
pmalik_ | https://review.openstack.org/#/c/278115/ | 18:09 |
pmalik_ | ^^^ peterstac, amrith, SlickNik, vkmc, johnma | 18:10 |
johnma | sure pmalik | 18:11 |
*** bhaskarduvvuri has joined #openstack-trove | 18:12 | |
openstackgerrit | Petr Malik proposed openstack/trove: PG test-helper create matching db for test user https://review.openstack.org/278115 | 18:29 |
openstackgerrit | Petr Malik proposed openstack/trove: Update the root scenario tests https://review.openstack.org/283754 | 18:31 |
openstackgerrit | Petr Malik proposed openstack/trove: Update the root scenario tests https://review.openstack.org/283754 | 18:35 |
openstackgerrit | Merged openstack/trove: Block pymongo version 3.1 https://review.openstack.org/290236 | 18:37 |
krotscheck | I've got a mitaka bug that needs some eyeballs, any takers? https://review.openstack.org/#/c/288543/ | 18:38 |
*** bhaskarduvvuri has quit IRC | 18:53 | |
*** 20WAAIK4T has quit IRC | 19:01 | |
*** haomaiwa_ has joined #openstack-trove | 19:01 | |
pmackinn | what did we decide about TODO in new changes? | 19:06 |
*** jengeb1 has quit IRC | 19:06 | |
*** jengeb has joined #openstack-trove | 19:08 | |
krotscheck | Avoid if possible? | 19:09 |
peterstac | amrith, been reviewing https://review.openstack.org/#/c/290048 wrt the slave_of issue, and I think it's the way to go | 19:10 |
amrith | there are 4 changes | 19:10 |
peterstac | (probably what we should have done in the first place when it was deprecated) | 19:10 |
amrith | I'd appreciate your thoughts on the lot | 19:10 |
amrith | I've got concerns about some of them. | 19:10 |
amrith | as indicated in my email(s). | 19:10 |
peterstac | Well, once that change goes in, all we have to do is blacklist 2.1.0 and we're good, no? | 19:10 |
amrith | well, that's what I thought | 19:11 |
amrith | but that's not what the 4th change from Matt does. | 19:11 |
amrith | I don't think | 19:11 |
amrith | and it doesn't revert the API change. | 19:11 |
amrith | which also SHOULD, I think, be reverted. | 19:11 |
peterstac | the ReST API change? why do we need to revert that? | 19:12 |
peterstac | (I only see two changesets from Matt in your starred list ...) | 19:13 |
*** haomaiwa_ has quit IRC | 19:13 | |
amrith | I see 4. | 19:13 |
amrith | see my email | 19:13 |
dougshelley66 | peterstac if the assertion is that someone could be using slave_of via a liberty era client, one could also assume that someone could be calling the REST api with slave_of | 19:13 |
amrith | to openstack-dev | 19:13 |
amrith | what dougshelley66 said | 19:13 |
amrith | but my question is this, how do I deprecate a REST API? | 19:14 |
dougshelley66 | if you agree if the former, you kind of have to agree with the latter | 19:14 |
amrith | I can't send back a warning ... | 19:14 |
*** haomaiwa_ has joined #openstack-trove | 19:14 | |
peterstac | that's what v2.0 is for I guess | 19:14 |
dougshelley66 | yup | 19:14 |
*** tqtran has joined #openstack-trove | 19:15 | |
peterstac | well, whether or not the ReST API is reverted, we (at a minimum) should revert the client, no? | 19:18 |
krotscheck | amrith: I think keystone is doing something like that, and there was an api-wg spec out there. Lemme dig. | 19:18 |
peterstac | I was going to +2 the changeset https://review.openstack.org/#/c/290048 | 19:18 |
amrith | hold up peterstac | 19:18 |
*** haomaiwa_ has quit IRC | 20:01 | |
*** haomaiwang has joined #openstack-trove | 20:01 | |
*** jengeb has quit IRC | 20:12 | |
amrith | krotscheck, not ignoring your request for a review earlier. Just trying to wrap up a couple of other issues | 20:21 |
amrith | trove folks, I've added https://review.openstack.org/#/c/288543/ (from krotscheck) to https://review.openstack.org/#/q/is:starred+status:open | 20:22 |
krotscheck | amrith: Saw that. Was trying to help. | 20:22 |
krotscheck | amrith: From keystone - it looks like they just log a deprecation warning in the logfile. | 20:22 |
krotscheck | amrith, quote: dolphm: krotscheck: the clients log warnings client-side, the API should be advertised as deprecated on the root endpoint at some point (i think the status is still "stable" for us), and the servers log usage as deprecation warnings | 20:22 |
krotscheck | So, that's how you deprecate a REST api. | 20:22 |
amrith | krotscheck, thanks | 20:23 |
amrith | matt (mriedm) is going to be sending up a change with this so I'll look for this. | 20:23 |
*** tellesnobrega is now known as tellesnobrega_af | 20:30 | |
*** tellesnobrega_af is now known as tellesnobrega | 20:39 | |
*** ediardo has joined #openstack-trove | 20:54 | |
*** tqtran has quit IRC | 20:54 | |
*** tqtran has joined #openstack-trove | 20:55 | |
*** sgotliv has joined #openstack-trove | 20:57 | |
*** haomaiwang has quit IRC | 21:01 | |
*** haomaiwang has joined #openstack-trove | 21:01 | |
*** sgotliv has quit IRC | 21:03 | |
*** pmackinn_ has joined #openstack-trove | 21:09 | |
*** pmackinn has quit IRC | 21:10 | |
openstackgerrit | Peter Stachowski proposed openstack/trove: Server support for instance module feature https://review.openstack.org/290275 | 21:42 |
*** arist has quit IRC | 21:42 | |
openstackgerrit | Matt Riedemann proposed openstack/trove: Revert "Time to get rid of most vestiges of slave_of" https://review.openstack.org/290871 | 21:42 |
*** arist has joined #openstack-trove | 21:43 | |
openstackgerrit | Matt Riedemann proposed openstack/trove: Revert "Time to get rid of most vestiges of slave_of" https://review.openstack.org/290871 | 21:48 |
*** ashleigh_ has quit IRC | 21:54 | |
*** ashleighfarnham has joined #openstack-trove | 21:57 | |
*** pmackinn_ has quit IRC | 22:00 | |
*** ediardo has quit IRC | 22:00 | |
*** haomaiwang has quit IRC | 22:01 | |
*** haomaiwang has joined #openstack-trove | 22:01 | |
openstackgerrit | Peter Stachowski proposed openstack/trove: Server support for instance module feature https://review.openstack.org/290275 | 22:11 |
amrith | folks, can someone (vkmc, johnma, peterstac, SlickNik, cp16net) please look at https://review.openstack.org/#/c/290048/ and +2/+1 if possible. it is a revert of the client side code for slave_of. | 22:12 |
*** ewilson has quit IRC | 22:17 | |
*** david-lyle has quit IRC | 22:19 | |
*** david-lyle has joined #openstack-trove | 22:20 | |
*** amrith is now known as _amrith_ | 22:24 | |
*** mariusv has quit IRC | 23:01 | |
*** haomaiwang has quit IRC | 23:01 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!