| *** haomaiwa_ has quit IRC | 00:01 | |
| *** davideagnello has joined #openstack-trove | 00:01 | |
| *** haomaiwa_ has joined #openstack-trove | 00:01 | |
| *** imandhan has joined #openstack-trove | 00:03 | |
| *** davideag_ has joined #openstack-trove | 00:15 | |
| *** davideagnello has quit IRC | 00:15 | |
| *** imandhan has quit IRC | 00:17 | |
| *** _amrith_ is now known as amrith | 00:57 | |
| *** cheneydc has joined #openstack-trove | 00:59 | |
| *** haomaiwa_ has quit IRC | 01:01 | |
| *** haomaiwang has joined #openstack-trove | 01:01 | |
| *** haomai___ has joined #openstack-trove | 01:06 | |
| *** haomaiwang has quit IRC | 01:08 | |
| *** tqtran has quit IRC | 01:14 | |
| *** mingdang1 has joined #openstack-trove | 01:19 | |
| *** mingdang1 has quit IRC | 01:54 | |
| *** amrith is now known as _amrith_ | 01:59 | |
| *** pmackinn has quit IRC | 02:00 | |
| *** haomai___ has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-trove | 02:01 | |
| *** haomaiwang has quit IRC | 02:03 | |
| *** 7F1AAMJH0 has joined #openstack-trove | 02:08 | |
| *** tqtran has joined #openstack-trove | 02:12 | |
| *** 7F1AAMJH0 has quit IRC | 02:13 | |
| *** tqtran has quit IRC | 02:17 | |
| *** ediardo has quit IRC | 02:18 | |
| *** tellesnobrega is now known as tellesnobrega_af | 02:40 | |
| *** tellesnobrega_af is now known as tellesnobrega | 02:41 | |
| *** lifeless has quit IRC | 02:43 | |
| *** lifeless has joined #openstack-trove | 02:44 | |
| *** haomaiwang has joined #openstack-trove | 02:52 | |
| *** _amrith_ is now known as amrith | 02:59 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-trove | 03:01 | |
| *** tqtran has joined #openstack-trove | 03:13 | |
| *** links has joined #openstack-trove | 03:13 | |
| *** tqtran has quit IRC | 03:17 | |
| *** imandhan has joined #openstack-trove | 03:42 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** 7GHAAMTT3 has joined #openstack-trove | 04:01 | |
| *** sgotliv has quit IRC | 04:19 | |
| *** sgotliv has joined #openstack-trove | 04:20 | |
| *** ediardo has joined #openstack-trove | 04:42 | |
| *** 7GHAAMTT3 has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-trove | 05:01 | |
| *** pcaruana has quit IRC | 05:09 | |
| *** ediardo has quit IRC | 05:10 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-trove | 06:01 | |
| *** sgotliv has quit IRC | 06:17 | |
| *** tesseract has joined #openstack-trove | 06:19 | |
| *** tesseract is now known as Guest58782 | 06:19 | |
| *** Ravikiran_K has joined #openstack-trove | 06:22 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-trove | 07:01 | |
| *** tqtran has joined #openstack-trove | 07:14 | |
| *** tqtran has quit IRC | 07:18 | |
| *** rcernin has joined #openstack-trove | 07:36 | |
| *** mingdang1 has joined #openstack-trove | 07:37 | |
| *** haomaiwang has quit IRC | 07:39 | |
| *** mingdang1 has quit IRC | 07:39 | |
| *** mingdang1 has joined #openstack-trove | 07:40 | |
| *** haomaiwang has joined #openstack-trove | 07:43 | |
| *** haomaiwang has quit IRC | 07:48 | |
| *** pcaruana has joined #openstack-trove | 07:48 | |
| *** haomaiwa_ has joined #openstack-trove | 07:53 | |
| *** sgotliv has joined #openstack-trove | 07:53 | |
| *** haomaiwa_ has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-trove | 08:01 | |
| *** haypo has joined #openstack-trove | 08:18 | |
| haypo | amrith: hello | 08:18 |
|---|---|---|
| *** mingdang1 has quit IRC | 08:21 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-trove | 09:01 | |
| *** tosky has joined #openstack-trove | 09:06 | |
| *** barclaac has quit IRC | 09:11 | |
| *** barclaac has joined #openstack-trove | 09:14 | |
| *** lifeless has quit IRC | 09:39 | |
| *** lifeless has joined #openstack-trove | 09:40 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-trove | 10:01 | |
| *** cheneydc has quit IRC | 10:02 | |
| *** tqtran has joined #openstack-trove | 10:15 | |
| *** tqtran has quit IRC | 10:20 | |
| *** flaper87 has quit IRC | 10:36 | |
| *** flaper87 has joined #openstack-trove | 10:36 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwang has joined #openstack-trove | 11:01 | |
| *** tellesnobrega is now known as tellesnobrega_af | 11:05 | |
| *** Ravikiran_K has quit IRC | 11:17 | |
| *** flwang has joined #openstack-trove | 11:25 | |
| *** mingdang1 has joined #openstack-trove | 11:33 | |
| amrith | haypo, hello | 11:44 |
| haypo | amrith: hey. i would like to talk about https://review.openstack.org/#/c/297888/ | 11:47 |
| haypo | amrith: i don't think that it's a good idea to have two versions of the code, one for py2, one for py3 | 11:52 |
| haypo | amrith: do you expect regressions from my change? maybe i should explain better the effect of the change on py2? | 11:53 |
| haypo | (already done in comments, but maybe i should enhance the commit message) | 11:53 |
| amrith | one second haypo, timeslicing a bit here. | 11:53 |
| *** haomaiwang has quit IRC | 12:01 | |
| *** pmackinn has joined #openstack-trove | 12:01 | |
| amrith | hi haypo, I'm back | 12:01 |
| *** haomaiwa_ has joined #openstack-trove | 12:01 | |
| amrith | I read your comments. | 12:01 |
| amrith | here is my concern, and it may be the case that your change does not cause this problem, but I want to be sure. | 12:02 |
| amrith | assume that in one version of code, we have functions encrypt() and decrypt() | 12:02 |
| amrith | and encrypt() was used to store some data which is at rest. | 12:02 |
| amrith | suppose you fix encrypt() and decrypt() in some way, after upgrading, you should still be able to decrypt() all the old data. | 12:03 |
| amrith | my concern is that your change(s) are in that realm, and I'd like to see tests that can ensure that this doesn't introduce a regression; data becoming unecryptable. | 12:03 |
| amrith | sorry, un-decryptable. | 12:03 |
| amrith | haypo ^^ does this question make sense or am I missing something very basic? | 12:05 |
| haypo | amrith: they are already unit tests, i don't think that it's worth to add new tests | 12:09 |
| haypo | amrith: IMHO my change adds a new feature on py2, unicode is now supported | 12:09 |
| amrith | but the unit tests only test code in either the old version or the new version. | 12:09 |
| haypo | amrith: if you want new tests, they should be on unicode strings, so check that unicode is encoded to utf-8 as expected | 12:10 |
| haypo | amrith: i don't understand what do you mean by "old" and "new" version. my change only adds something like: | 12:11 |
| haypo | if isinstance(data, unicode): | 12:11 |
| haypo | data = data.encode('utf-8') | 12:11 |
| haypo | if you pass str (bytes), it does nothing | 12:12 |
| haypo | (i'm talking about python 2 here) | 12:12 |
| amrith | haypo, by old version I mean code before your fix and by new version I mean code with your fix. | 12:16 |
| amrith | these functions are used to encrypt data and then store them in files, or the database. | 12:16 |
| amrith | therefore data could be encrypted using the current code and later attempt to be decrypted using the new code. | 12:16 |
| amrith | if these functions don't function identically, you are missing an upgrade step here ... | 12:16 |
| haypo | amrith: my change doesn't break backward compatibility | 12:16 |
| amrith | please tell me what you mean by backward compatibility. | 12:17 |
| haypo | amrith: if you pass bytes, it's a no-op | 12:17 |
| haypo | amrith: i mean that data encrypted by the old version is decryptable by the new version (for example) | 12:17 |
| haypo | amrith: data encrypted by the new version can be decrypted by the old version | 12:18 |
| haypo | etc. | 12:18 |
| haypo | amrith: the real question is if trove sometimes pass Unicode strings with non-ASCII characters | 12:18 |
| haypo | i don't think so, since you will likely get an unicode error in this case with the old version ;) | 12:18 |
| amrith | given where these routines may have been used, it is possible but I'm not sure. | 12:18 |
| openstackgerrit | amrith proposed openstack/trove: Address change in Route v2.3 https://review.openstack.org/298419 | 12:19 |
| amrith | haypo, to be clear. I'm not able to give you a concrete example of "here, this is something that will break". hence the concern on my part. | 12:20 |
| amrith | I don't understand all the possible ways in which crypto_utils has been used, nor the complete import of your change. so let others weigh in as well? | 12:20 |
| haypo | with python 2: | 12:21 |
| haypo | >>> trove.common.crypto_utils.encrypt_data(u'data', u'key') | 12:21 |
| haypo | 'oMfvEWglTIacQ4ql\x06\xba\xa1?\x0e\xec<:\xdc\xad\x9d\xf9\x05\xdc\xea\x82' | 12:21 |
| haypo | with the current code, you *can* pass unicode string if they are encodable to ASCII | 12:21 |
| haypo | >>> trove.common.crypto_utils.encrypt_data(u'data', u'key\xff') | 12:21 |
| haypo | UnicodeEncodeError: 'ascii' codec can't encode character u'\xff' in position 3: ordinal not in range(128) | 12:21 |
| haypo | but you *cannot | 12:21 |
| haypo | but you *cannot* pass Unicode string with non-ASCII character | 12:21 |
| haypo | amrith: it confirms my guess, my code has *no* effect on python 2 :-) it only adds a new feature. you are now able to encode arbitrary Unicode on python 2, it's first encoded to UTF-8 | 12:22 |
| haypo | amrith: you can decode such string using the old code, as soon as you accepted UTF-8 encoded byte string | 12:22 |
| haypo | amrith: currently, Unicode is encoded to ASCII. But UTF-8 is a superset of ASCII. Data encoded to DATA is decodable from UTF-8 | 12:23 |
| haypo | oops | 12:23 |
| haypo | Data encoded to ASCII is decodable from UTF-8 | 12:23 |
| amrith | I take your word for it, let's see what other reviewers feel, shall we? I'll also spend some time working with your new code to understand better. | 12:23 |
| haypo | amrith: unicode is an hard problem. i know that very well. i fixed unicode issues in python 3 (the interpreter, C code, stdlib, etc.) during several years :-) (i'm a python core developer) | 12:24 |
| haypo | amrith: i even wrote http://unicodebook.readthedocs.org/ /o\ | 12:24 |
| amrith | That's very good, and reassuring to know. thanks. | 12:25 |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port crypto_utils to Python 3 https://review.openstack.org/297888 | 12:30 |
| haypo | amrith: ^^ i completed the commit message to try to reasure you :) | 12:31 |
| haypo | "I'd like to see tests that can ensure that this doesn't introduce a regression; data becoming unecryptable." which kinds of test do you expect? | 12:32 |
| haypo | amrith: ^^ | 12:32 |
| haypo | amrith: do you expect a test with encrypted data + the key and ensure that you can still decode data? | 12:33 |
| haypo | amrith: right now i only see tests like data == decrypt(encrypt(data)) | 12:33 |
| amrith | haypo, I'm looking for some way to mitigate the concern (either tests or code inspection) that existing encrypted data doesn't become undecryptable | 12:35 |
| haypo | amrith: i can add new tests if you want, but i would like to understand what you expect first :=) | 12:35 |
| amrith | haypo, we're looking for you in #openstack-release :) | 12:37 |
| amrith | haypo, please don't add anything at this stage. let's see what other reviewers feel. I will go with their counsel. | 12:39 |
| *** Ravikiran_K has joined #openstack-trove | 12:49 | |
| *** pmackinn has quit IRC | 12:59 | |
| *** haomaiwa_ has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-trove | 13:01 | |
| *** pmackinn has joined #openstack-trove | 13:02 | |
| *** links has quit IRC | 13:02 | |
| haypo | amrith: i don't understand why Random.new() data is encoded by encode_data(), AES accepts arbitrary binary data | 13:19 |
| haypo | amrith: i fear that encode_data() reduces the quality of the IV (less random) | 13:19 |
| *** haomaiwang has quit IRC | 13:22 | |
| *** amrith is now known as _amrith_ | 13:35 | |
| haypo | hum, there is also a major performance issue in _find_mock_refs() of trove/tests/unittests/trove_testtools.py | 13:43 |
| *** mingdang1 has quit IRC | 13:45 | |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port crypto_utils to Python 3 https://review.openstack.org/297888 | 13:46 |
| *** haypo has left #openstack-trove | 13:50 | |
| *** sgotliv has quit IRC | 14:03 | |
| *** tqtran has joined #openstack-trove | 14:17 | |
| *** tellesnobrega_af is now known as tellesnobrega | 14:19 | |
| *** sgotliv has joined #openstack-trove | 14:20 | |
| *** tqtran has quit IRC | 14:21 | |
| *** _amrith_ is now known as amrith | 14:24 | |
| cp16net | flaper87: yt? | 14:31 |
| flaper87 | cp16net: yes | 14:31 |
| *** dims has joined #openstack-trove | 14:32 | |
| cp16net | mind seeing if you approve this for stable/mitaka? https://review.openstack.org/#/c/297564/ | 14:32 |
| cp16net | flaper87: i'd like to get this merged so i can cut the RC2 for trove-dashboard today | 14:35 |
| flaper87 | cp16net: looking into it! | 14:36 |
| cp16net | it looks like the final patch we need. thanks! :) | 14:36 |
| *** boden has joined #openstack-trove | 14:36 | |
| *** haomaiwang has joined #openstack-trove | 14:43 | |
| flaper87 | cp16net: done | 14:52 |
| flaper87 | :) | 14:52 |
| *** tosky has quit IRC | 14:53 | |
| *** boden has left #openstack-trove | 14:57 | |
| *** tosky has joined #openstack-trove | 14:57 | |
| cp16net | flaper87: thanks! | 15:00 |
| flaper87 | anytime | 15:00 |
| *** haomaiwang has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-trove | 15:01 | |
| *** Ravikiran_K has quit IRC | 15:04 | |
| *** openstackgerrit has quit IRC | 15:06 | |
| *** openstackgerrit has joined #openstack-trove | 15:06 | |
| *** tellesnobrega is now known as tellesnobrega_af | 15:12 | |
| cp16net | alright trove-dashboard rc2 is in the pipeline to be released | 15:22 |
| cp16net | zigo: ^^ your change is in there now | 15:22 |
| *** rcernin has quit IRC | 15:27 | |
| *** links has joined #openstack-trove | 15:32 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-trove | 16:01 | |
| *** Guest58782 has quit IRC | 16:03 | |
| *** links has quit IRC | 16:04 | |
| openstackgerrit | amrith proposed openstack/trove: Trove's tox tests should respect upper-constraints.txt https://review.openstack.org/298850 | 16:09 |
| *** tellesnobrega_af is now known as tellesnobrega | 16:16 | |
| *** tqtran has joined #openstack-trove | 16:30 | |
| *** haomaiwang has quit IRC | 16:32 | |
| *** haomaiwa_ has joined #openstack-trove | 16:34 | |
| *** haomaiwa_ has quit IRC | 16:37 | |
| *** haomaiwang has joined #openstack-trove | 16:38 | |
| *** Ravikiran_K has joined #openstack-trove | 16:41 | |
| *** haomaiwang has quit IRC | 16:42 | |
| *** pcaruana has quit IRC | 16:48 | |
| *** sgotliv has quit IRC | 16:59 | |
| *** zhiyan has quit IRC | 17:07 | |
| *** pmalik has quit IRC | 17:07 | |
| *** shakamunyi has quit IRC | 17:07 | |
| *** eglute has quit IRC | 17:07 | |
| *** vkmc has quit IRC | 17:07 | |
| *** tosky has quit IRC | 17:07 | |
| *** mfisch has quit IRC | 17:07 | |
| *** eglute has joined #openstack-trove | 17:07 | |
| *** barra204 has joined #openstack-trove | 17:07 | |
| *** pmalik_ has joined #openstack-trove | 17:07 | |
| *** tosky_ has joined #openstack-trove | 17:07 | |
| *** mfisch has joined #openstack-trove | 17:07 | |
| *** mfisch is now known as Guest28049 | 17:08 | |
| *** vkmc has joined #openstack-trove | 17:09 | |
| openstackgerrit | amrith proposed openstack/trove: Trove's tox tests should respect upper-constraints.txt https://review.openstack.org/298850 | 17:12 |
| *** zhiyan has joined #openstack-trove | 17:17 | |
| *** amrith is now known as _amrith_ | 17:29 | |
| *** arist has quit IRC | 17:39 | |
| *** arist has joined #openstack-trove | 17:40 | |
| *** tosky_ has quit IRC | 17:53 | |
| *** pcaruana has joined #openstack-trove | 18:02 | |
| *** _amrith_ is now known as amrith | 18:19 | |
| *** david-lyle has quit IRC | 18:45 | |
| *** david-lyle has joined #openstack-trove | 18:46 | |
| openstackgerrit | Peter Stachowski proposed openstack/python-troveclient: Fixed output of cluster-create in CLI https://review.openstack.org/298932 | 18:47 |
| *** Guest28049 is now known as mfisch | 19:01 | |
| *** mfisch is now known as Guest82454 | 19:01 | |
| *** Guest82454 has quit IRC | 19:02 | |
| *** Guest82454 has joined #openstack-trove | 19:02 | |
| *** Guest82454 is now known as mfisch | 19:03 | |
| *** krotscheck is now known as krotscheck_dcm | 19:07 | |
| *** haypo has joined #openstack-trove | 19:19 | |
| haypo | peterstac: hi. i saw your useful review on https://review.openstack.org/#/c/297888/ thanks | 19:21 |
| haypo | peterstac: i replied with new questions :) | 19:21 |
| *** dalees` has quit IRC | 19:25 | |
| peterstac | haypo, ok, I'll take a look :) | 19:33 |
| haypo | peterstac: it would be nice to start to have a working py3 gate, so focus on the first change | 19:34 |
| haypo | peterstac: do you have anything against https://review.openstack.org/#/c/279098/3 ? :) | 19:34 |
| openstackgerrit | Victor Stinner proposed openstack/trove: Port more common unit tests to Python 3 https://review.openstack.org/298952 | 19:35 |
| peterstac | Yeah, I think I looked at that a while back (around the time we decided to push it into Newton) | 19:35 |
| peterstac | I think it's fine | 19:35 |
| peterstac | (I noticed the crypto_utils one because I worked on that, and I remember how difficult it was to get it right) | 19:36 |
| haypo | peterstac: i discussed recently with amrith who is ok to start for newton. my plan is my blueprint linked in my changes, https://blueprints.launchpad.net/trove/+spec/trove-python3 | 19:36 |
| haypo | ah, it looks like you have a mitaka branch, so we can start to work on py3 ;) | 19:36 |
| peterstac | yep | 19:37 |
| haypo | peterstac: by the way, i think that encode_data() on the key is useless and reduces the entropy of the key | 19:37 |
| haypo | i should propose a separated change for that | 19:37 |
| peterstac | probably correct - I can't remember why I added that at this point though | 19:37 |
| peterstac | (I hope I had a reason ;) ) | 19:37 |
| haypo | (i don't understand neither why data is encoded *twice* to base64, but that's a different topic, it's not easy to change this part, and it doesn't affect security) | 19:37 |
| *** dalees` has joined #openstack-trove | 19:38 | |
| peterstac | basically the scenario is that data is taken from a file (or passed into the python API) and needs to be stored in the db | 19:39 |
| peterstac | since it has to be sent over the wire, it's b64 encoded to facilitate that | 19:39 |
| peterstac | once it's encrypted it's encoded again to store it into the db | 19:40 |
| haypo | peterstac: yeah, i now that base64 solves many issues ;) | 19:40 |
| haypo | peterstac: but it's encoded twice to base64, i don't understand why :-p | 19:40 |
| peterstac | (mainly because Trove doesn't have code support for blobs, and I didn't have time to sort that out ;) - but it does support Text) | 19:40 |
| haypo | AES accepts arbitrary binary data as input | 19:40 |
| peterstac | sure, but then I'd have to decode it first (since it comes across the wire as b64), then encrypt it, then re-encode it for the db | 19:43 |
| peterstac | I just decided to skip the first decode | 19:43 |
| peterstac | or maybe you're thinking of something else - what part of the code are you referring to? | 19:43 |
| *** dims has left #openstack-trove | 19:45 | |
| *** sgotliv has joined #openstack-trove | 19:48 | |
| haypo | peterstac: according to unit tests, it looks like trove uses: data_for_db = base64(encrypt(base64(data_from_file), key)) | 19:48 |
| haypo | peterstac: my question is, why not using directly: data_for_db = base64(encrypt(data_from_file, key)) | 19:49 |
| peterstac | because the data_from_file is sent over the wire to the server | 19:50 |
| peterstac | and the client doesn't have the key to encrypt the data | 19:50 |
| peterstac | (first) | 19:50 |
| peterstac | since it was already encoded, I chose to leave it that way | 19:51 |
| haypo | "data_from_file is sent over the wire to the server" hum ok | 19:51 |
| peterstac | or in other words, the client python API needs to convert it to a format that can be sent to the trove ReST server | 19:52 |
| peterstac | maybe there's a better way, but that's what I came up with :) | 19:52 |
| haypo | in a previous job, i recall that we used something like wire_data = to_xml(base64(data)). worst serialization ever :) but the whole communication was based on XML-RPC, and we failed to find how to serialize BLOB using the <![CDATA[ thing | 19:53 |
| haypo | peterstac: when i read the code for the first time, it wasn't obvious that data already comes encoded | 19:53 |
| peterstac | Yeah, I should probably have added a few more comments :) | 19:55 |
| *** ediardo has joined #openstack-trove | 19:57 | |
| *** Ravikiran_K has quit IRC | 19:59 | |
| haypo | peterstac: do you know if data coming from the client comes as text or binary on python3? | 19:59 |
| peterstac | from the CLI, it'll read the file as binary, and convert it to b64/utf-8 encoded | 20:00 |
| peterstac | but from the python API, it could be a string also, so it also runs through the same convertion | 20:01 |
| peterstac | so the ReST server should always receive b64/utf-8 encoded data | 20:01 |
| haypo | peterstac: but then it goes through oslo messaging, i guess? i would like to know if you expect bytes or text (unicode) at the server side | 20:02 |
| haypo | IMHO we should accept bytes & unicode and simply encode unicode to utf-8 | 20:02 |
| haypo | you may want to encode to ASCII to be pedantic, it's just that utf-8 is simpler (ex: there is the to_utf8() function in oslo.utils) | 20:03 |
| peterstac | how do you accept bytes from a ReST call? | 20:03 |
| peterstac | I just assumed it had to be encoded to fit into the data payload | 20:04 |
| peterstac | If you're speaking of the client, that's essentially what it does | 20:07 |
| peterstac | our client does have py34 tests so I had to jump through a lot of hoops already to get that to work | 20:07 |
| peterstac | (which is why the Base64Codec looks the way it does) | 20:08 |
| openstackgerrit | amrith proposed openstack/trove: Trove's tox tests should respect upper-constraints.txt https://review.openstack.org/298850 | 20:17 |
| amrith | cp16net, peterstac, vkmc, johnma, ... we need to merge https://review.openstack.org/298984 and https://review.openstack.org/#/c/298858/ for mitaka before thursday so we can cut an RC2. | 21:15 |
| amrith | the corresponding changes have worked on master | 21:15 |
| vkmc | yep, checking out | 21:16 |
| amrith | thanks. the change to g-r won't be till after mitaka is released. | 21:16 |
| amrith | see also the neutron solution ... https://review.openstack.org/#/c/298855/1 | 21:17 |
| amrith | looks familiar? | 21:17 |
| amrith | I don't see the need to fix mappers; I've posted a comment on the neutron review. | 21:22 |
| johnma | will look at amrith | 21:26 |
| vkmc | why there is a new change? | 21:29 |
| vkmc | https://review.openstack.org/#/c/298984/1 == https://review.openstack.org/#/c/298419/1 right? | 21:29 |
| vkmc | https://review.openstack.org/#/c/298984/ looks good | 21:32 |
| *** cweid has joined #openstack-trove | 21:33 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Replication/cluster locality https://review.openstack.org/298994 | 21:39 |
| *** cweid has quit IRC | 22:08 | |
| *** sgotliv has quit IRC | 22:35 | |
| *** haypo has left #openstack-trove | 22:43 | |
| *** mingdang1 has joined #openstack-trove | 23:26 | |
| *** mingdang1 has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!