Thursday, 2016-04-28

« Wednesday, 2016-04-27 Index Friday, 2016-04-29 »
openstackgerritMerged openstack/python-troveclient: configuration-* cli allow name of configuration group entered  https://review.openstack.org/23399800:03
*** rmevans has joined #openstack-trove00:26
openstackgerritSTEW TY proposed openstack/trove-integration: change vertica config parameter  https://review.openstack.org/31062400:35
pmalikstewie925 Hi. This is what the 'Depends-On' tag is for. In your case the 'trove-integration' change depends on the 'trove' change. You put 'Depends-On: I22040085a24de1d0e5fd3132802aca684387477d' to the commit message on you 'trove-integration' patch set (the ID is the Change-Id of other patch set). P.00:39
stewie925hey pmalik00:40
stewie925this is the gerrit review for the trove-integration fix -> https://review.openstack.org/31062400:40
stewie925so I need to do a git commit amend to add the depends-On line that you suggested?00:41
stewie925I am also wondering why the reviewers list is empty there - normally gerrit knows to generate reviewers00:41
stewie925maybe you could assist in shedding light on why the reviewers list is empty00:42
pmalikstewie925 See for instance this: https://review.openstack.org/#/c/286317/ The change depends on two other patch sets (one from trove-integration repo and one from requirements repo)00:42
stewie925oh thank you for sharing that gerrit link with the 'depends-on'00:43
pmalikstewie925 I think the reviewers appear only when somebody reviews (+/-) the change.00:43
stewie925but am still wondering if the missing reviewers list should be a cause for concern - or do I just 'manually' add the reviewers?00:44
stewie925I see - but I am at least expecting Jenkins (testing) automatically added as a reviewer, right?00:44
stewie925i'll go ahead and add the dependsOn - hopefully it will trigger gerrit to assign the reviewers :)00:45
stewie925brb00:45
openstackgerritSTEW TY proposed openstack/trove-integration: change vertica config parameter  https://review.openstack.org/31062400:48
*** rmevans has quit IRC00:49
stewie925updated gerrit with depends-on00:49
stewie925thank you pmalik!00:49
*** cheneydc has joined #openstack-trove00:55
*** jinxing has joined #openstack-trove01:03
*** stewie925 has quit IRC01:13
*** stevemar has joined #openstack-trove01:38
*** haomaiwang has joined #openstack-trove02:13
*** mingdang1 has joined #openstack-trove02:13
*** tqtran has joined #openstack-trove02:50
*** tqtran has quit IRC02:50
*** rmevans has joined #openstack-trove03:12
*** mingdang1 has quit IRC05:09
*** rmevans has quit IRC05:20
*** jinxing has quit IRC05:26
*** jinxing has joined #openstack-trove05:38
*** jinxing has quit IRC05:52
*** stevemar has quit IRC05:52
*** jinxing has joined #openstack-trove05:54
*** cheneydc has quit IRC06:09
openstackgerritOpenStack Proposal Bot proposed openstack/trove-dashboard: Imported Translations from Zanata  https://review.openstack.org/30965406:16
*** haomaiwang has quit IRC06:20
*** cheneydc has joined #openstack-trove06:23
*** mingdang1 has joined #openstack-trove06:29
*** mugsie has quit IRC07:19
*** jinxing has quit IRC07:40
*** flwang has quit IRC07:41
*** jinxing has joined #openstack-trove07:48
*** flwang has joined #openstack-trove07:52
*** dmk0202 has joined #openstack-trove08:10
*** mingdang1 has quit IRC09:04
*** mingdang1 has joined #openstack-trove09:10
*** jinxing has quit IRC09:34
*** jinxing has joined #openstack-trove09:39
*** rcernin has joined #openstack-trove09:44
*** tosky has joined #openstack-trove09:46
*** cheneydc has quit IRC09:59
*** jinxing has quit IRC10:04
*** jinxing has joined #openstack-trove10:13
*** tosky has quit IRC10:24
*** tosky has joined #openstack-trove10:33
*** tosky has quit IRC11:05
*** haomaiwang has joined #openstack-trove11:09
*** haomaiwang has quit IRC11:14
*** jinxing has quit IRC11:26
*** jinxing has joined #openstack-trove11:33
*** jinxing has quit IRC11:37
*** tosky has joined #openstack-trove11:43
*** haypo has joined #openstack-trove11:50
haypohi. it looks like you are busy with the summit ;) just in case, there are Python 3 patches which already got a first +2 and are waiting for your review (or even approval!): https://review.openstack.org/#/q/status:open+project:openstack/trove+branch:master+topic:bp/trove-python311:53
haypo_amrith_: did you talk about Python 3 at the summit yet?11:54
*** cheneydc has joined #openstack-trove12:26
*** cheneydc has quit IRC12:26
*** cguadall has joined #openstack-trove12:41
*** cguadall_ has quit IRC12:44
*** haomaiwang has joined #openstack-trove12:58
*** haomaiwang has quit IRC13:02
*** arist has quit IRC13:13
*** arist has joined #openstack-trove13:14
*** _amrith_ is now known as amrith13:26
amrithhaypo, yes we did13:27
amrithdone yesterday13:27
haypoamrith: nice. any feedback? how is the summit going?13:29
amrithhaypo, summit is going well13:29
amrithwe decided to make the py34 changes a voting gate13:29
amrithI'm pushing the change up for that right now13:29
haypo"we decided to make the py34 changes a voting gate" ah? it was already decided one week ago on the IRC meeting no? my change is already merged, the gate is voting13:30
amrithdid it?13:30
amrithsure did13:31
amrithcool13:31
amrithjust looked at a recent build and py34 is voting13:31
amrithso we decided it again :)13:31
amrithgood thing we came to the same conclusion ...13:31
amrithother than that, nothing specific to the python3 project13:31
*** amrith is now known as _amrith_13:42
*** jinxing has joined #openstack-trove13:55
*** _amrith_ is now known as amrith13:58
*** miqui has joined #openstack-trove14:11
*** david-lyle has joined #openstack-trove14:11
*** mingdang1 has quit IRC14:13
*** miqui|2 has joined #openstack-trove14:16
*** miqui has quit IRC14:16
*** miqui has joined #openstack-trove14:24
*** miqui|2 has quit IRC14:24
*** miqui|2 has joined #openstack-trove14:28
*** miqui has quit IRC14:29
*** miqui has joined #openstack-trove14:32
*** miqui|2 has quit IRC14:33
*** david-lyle has quit IRC14:35
*** david-lyle has joined #openstack-trove14:36
*** amrith is now known as _amrith_14:39
*** miqui|2 has joined #openstack-trove14:40
*** miqui has quit IRC14:40
*** miqui|2 has quit IRC14:41
*** david-lyle has quit IRC14:41
*** miqui has joined #openstack-trove14:41
*** david-lyle has joined #openstack-trove14:49
*** _amrith_ is now known as amrith14:52
*** pmackinn has joined #openstack-trove14:55
*** dmk0202 has quit IRC15:06
*** khushbu_ has joined #openstack-trove15:14
*** khushbu_ has quit IRC15:25
*** david-lyle has quit IRC15:31
*** amrith is now known as _amrith_15:37
*** imandhan has joined #openstack-trove15:43
*** _amrith_ is now known as amrith15:56
*** david-lyle has joined #openstack-trove16:00
*** imandhan has quit IRC16:12
*** haomaiwang has joined #openstack-trove16:17
*** imandhan has joined #openstack-trove16:30
*** imandhan has quit IRC16:42
*** pmackinn has quit IRC16:44
*** david-lyle has quit IRC16:46
*** pmackinn has joined #openstack-trove16:49
*** imandhan has joined #openstack-trove16:50
*** amrith is now known as _amrith_16:51
*** _amrith_ is now known as amrith16:51
*** ewilson has joined #openstack-trove16:57
*** haomaiwang has quit IRC17:10
*** haomaiwang has joined #openstack-trove17:12
*** ewilson has quit IRC17:13
*** mingdang1 has joined #openstack-trove17:14
*** ewilson has joined #openstack-trove17:14
*** haomaiwang has quit IRC17:17
*** ewilson has quit IRC17:18
*** mingdang1 has quit IRC17:18
*** stewie925 has joined #openstack-trove17:19
stewie925hello all17:19
stewie925I have a question about git branching17:19
stewie925I just finished working on a trove bug (awaiting merge) and took on a new bug which turns out to be another trove bug17:19
stewie925so I want to separate the bug2 fix with the bug1 fix ->  I understand that's where the usefulness of  'git branch' comes in17:20
stewie925so I am creating a new branch called bug2 - question is how do I commit this bug2 fix 'separate' from the bug1 fix17:22
*** ewilson has joined #openstack-trove17:22
*** imandhan has quit IRC17:23
stewie925I didnt create a branch for bug1 fix, so changes for bug1 are in branch master17:24
stewie925will git be able to treat 'branch-bug2'  as separate from 'branch-master' , and thus I can do a new commit for branch-bug2 (i.e., Closes-Bug: #<bug2> and a new change-id assigned to this)?17:27
toskystewie925: this is not about git, but about gerrit17:28
toskygerrit works with individual patches, that are than merged into the target branch17:28
stewie925hi tosky, thanks for the correction - yes gerrit not git17:28
toskyso when you submit a review, you push all the changes from the current version of the branch you changed17:29
toskyif you create a branch for bug2 now, it will be on top of the changes for bug117:30
stewie925so <branch-bug2> will contain the changes that i made for bug1 , is that right?17:31
toskyso if you execute git review from bug2, it will ask you to submit two patches17:31
toskyyes, you can easily check it with a graphical tool like qgit, for example, or git log --graph17:31
toskygit review will send the two patches to gerrit, which needs to be merged in the right order17:32
toskyif you want to submit two independent patches, you need to create two branches on top of master17:32
toskyyou can do it even now; from your modified master, create a branch for bug117:32
*** ewilson has quit IRC17:32
stewie925ohhhh now I understand - thats a good idea  tosky17:33
toskybut then your master will be still your modified one17:33
stewie925I should make it a habit of creating branches from now on - just started doing bug fixes a couple weeks ago17:33
toskythen you can reset it (git reset --hard origin/master - please backup your changes before doing it, not responsible for data loss :)17:34
toskyand remember that you can create a branch based on the origin version of master even now17:34
stewie925exactly....17:34
stewie925just to clarify...17:34
toskyif you see the documentation of git branch, something like `git branch mynewbranch origin/master` will create mynewbranch on top of origin/master17:35
*** pmackinn has quit IRC17:35
stewie925so if i had created branch-bug1  right after git cloning,   then I created branch-bug2 for the second bug fix, then these two branches would have been INDEPENDENT of each other17:35
toskyyes17:36
toskyagain, git log --graph and/or qgit or gitk shows the image better than how I can describe it :)17:36
toskyif you see the documentation of git branch, something like `git branch mynewbranch origin/master` will create mynewbranch on top of origin/master17:36
toskyjust for the record17:36
stewie925thank you so much for your explanation, tosky17:37
stewie925next time I will always create a branch for any future fix17:37
toskystewie925: a good git reference (open source book, available also in printed version) is https://git-scm.com/book/en/v217:37
* stewie925 clicks on the link 17:38
* stewie925 thanks tosky profusely for this helpful tip17:39
toskywell, for the logs, not totally "open source" as it is CC-BY-NC-ND, but still, a really good resource that can be easily used17:39
stewie925:)17:40
*** amrith is now known as _amrith_17:43
*** rcernin has quit IRC17:43
*** alejandrito has joined #openstack-trove18:00
*** alejandrito_ has joined #openstack-trove18:03
*** alejandrito__ has joined #openstack-trove18:04
*** tosky has quit IRC18:06
*** stewie925 has quit IRC18:06
*** stewie925 has joined #openstack-trove18:08
*** rcernin has joined #openstack-trove18:17
*** alejandrito_ has quit IRC18:19
*** alejandrito has quit IRC18:19
*** alejandrito__ has quit IRC18:19
*** _amrith_ is now known as amrith18:19
*** alejandrito has joined #openstack-trove18:20
*** david-lyle has joined #openstack-trove18:24
*** ewilson has joined #openstack-trove18:27
stewie925test18:34
*** pmackinn has joined #openstack-trove18:36
*** elmiko has left #openstack-trove18:49
*** rcernin has quit IRC18:50
stewie925hi tosky18:53
stewie925when doing the 'git reset --hard origin/master' it doesnt really matter which branch you are in, correct?18:53
stewie925and doing the above command will bring me back to the original state of the master branch - i.e., the initial git clone state18:54
stewie925correction - doing the above command will bring 'the master branch' back to the original state - i.e., the initial git clone state18:56
*** barclaac has quit IRC19:07
*** barclaac has joined #openstack-trove19:11
*** pmackinn has quit IRC19:13
*** pmackinn has joined #openstack-trove19:15
*** david-lyle has quit IRC19:15
*** ewilson has quit IRC19:18
*** ewilson has joined #openstack-trove19:19
dougshelley66https://docs.google.com/presentation/d/1z8OF8QSX_q151_sV3B0CNoRuy_55DAHkI1c04CpssWk/edit#slide=id.g10f0a5a2fa_0_019:22
pmackinnhttps://docs.google.com/presentation/d/1z8OF8QSX_q151_sV3B0CNoRuy_55DAHkI1c04CpssWk/present#slide=id.p419:22
*** rcernin has joined #openstack-trove19:39
*** stewie925 has quit IRC19:59
*** ewilson has quit IRC20:05
*** pmackinn has quit IRC20:06
*** stewie925 has joined #openstack-trove20:09
stewie925hi amrith20:20
stewie925I have a question with https://bugs.launchpad.net/trove/+bug/154452220:20
openstackLaunchpad bug 1544522 in OpenStack DBaaS (Trove) "Don't use Mock.called_once_with that does not exist" [Undecided,Confirmed] - Assigned to STEW TY (stewie925)20:21
*** ewilson has joined #openstack-trove20:27
amrithstewie925, post the question here I'll get to it ... may not be able to answer in real time20:33
*** stewie925 has quit IRC20:47
*** stewie925 has joined #openstack-trove20:51
*** amrith is now known as _amrith_20:55
*** _amrith_ is now known as amrith21:08
*** david-lyle has joined #openstack-trove21:12
stewie925sorry amrith I got disconnected ... regarding bug/1544522 - do I simply find the ".called_once_with" and replace them with ".assert_called_once_with" ?21:18
openstackgerritDoug Shelley proposed openstack/trove: Postgresql Streaming Replication  https://review.openstack.org/28871221:30
*** miqui has quit IRC21:32
*** alejandrito has quit IRC21:34
amrithstewie925, this bug has been fixed in a number of other projects so I suggest you see what was done there.21:34
stewie925hi amrith, thanks.... after I asked the question I did see that a fix was made on trove but abandoned...21:35
stewie925https://review.openstack.org/#/c/281232/221:36
*** ewilson has quit IRC21:41
openstackgerritDoug Shelley proposed openstack/trove: Postgresql Incremental Backup and Restore  https://review.openstack.org/25916721:43
stewie925hello peterstac21:52
*** rcernin has quit IRC21:53
*** amrith is now known as _amrith_21:55
*** _amrith_ is now known as amrith21:59
*** amit213 has quit IRC22:37
*** amit213 has joined #openstack-trove22:38
*** stewie925 has quit IRC22:40
*** amrith is now known as _amrith_22:48
*** david-lyle has quit IRC22:50
*** stewie925_ has joined #openstack-trove22:56
stewie925_hello guys I have a question on git branch23:03
stewie925_I created multiple branches - each to contain only specific changes for a bug  (branch-1 for bug1, branch-2 for bug2...)23:04
stewie925_so I made a change on branch-2 for bug223:04
stewie925_but when I tried to switch over to branch-1 -  I see that the changes i made on branch-2  now shows up on branch-123:05
stewie925_turns out it was due to 'git checkout' that I did - how do I undo?23:05
*** stewie925 has joined #openstack-trove23:23
*** jinxing has quit IRC23:27
« Wednesday, 2016-04-27 Index Friday, 2016-04-29 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!