| *** chlong has joined #openstack-trove | 00:19 | |
| *** cheneydc has joined #openstack-trove | 00:56 | |
| *** itlinux has quit IRC | 01:08 | |
| *** itlinux has joined #openstack-trove | 01:18 | |
| *** itlinux has quit IRC | 01:23 | |
| *** itlinux has joined #openstack-trove | 01:25 | |
| *** itlinux has quit IRC | 01:26 | |
| *** itlinux has joined #openstack-trove | 01:35 | |
| *** chlong has quit IRC | 01:56 | |
| *** itlinux has quit IRC | 02:04 | |
| *** itlinux has joined #openstack-trove | 02:05 | |
| *** itlinux has quit IRC | 02:10 | |
| *** itlinux has joined #openstack-trove | 03:03 | |
| *** sgotliv has joined #openstack-trove | 03:21 | |
| *** links has joined #openstack-trove | 03:49 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove-integration: Add another 'fault' flavor https://review.openstack.org/316566 | 04:23 |
|---|---|---|
| openstackgerrit | Peter Stachowski proposed openstack/trove: Persist error messages and display on 'show' https://review.openstack.org/313791 | 04:24 |
| *** rcernin has joined #openstack-trove | 05:16 | |
| *** johnma has joined #openstack-trove | 05:16 | |
| *** rcernin has quit IRC | 05:21 | |
| *** rcernin has joined #openstack-trove | 05:38 | |
| *** dmk0202 has joined #openstack-trove | 08:32 | |
| *** sgotliv_ has joined #openstack-trove | 08:49 | |
| *** sgotliv has quit IRC | 08:52 | |
| *** tosky has joined #openstack-trove | 09:58 | |
| *** cheneydc has quit IRC | 10:00 | |
| *** _hanhart has quit IRC | 11:13 | |
| *** Ravikiran_K has joined #openstack-trove | 12:22 | |
| *** amrith is now known as _amrith_ | 12:53 | |
| *** miqui has joined #openstack-trove | 12:55 | |
| *** links has quit IRC | 12:55 | |
| *** ewilson has joined #openstack-trove | 12:56 | |
| *** pmackinn has joined #openstack-trove | 13:06 | |
| *** johnma has quit IRC | 13:48 | |
| *** _amrith_ is now known as amrith | 13:54 | |
| *** pmackinn_ has joined #openstack-trove | 14:03 | |
| *** pmackinn has quit IRC | 14:05 | |
| *** imandhan has joined #openstack-trove | 14:13 | |
| *** links has joined #openstack-trove | 14:15 | |
| *** Ravikiran_K has quit IRC | 14:58 | |
| *** haypo has joined #openstack-trove | 15:02 | |
| *** itlinux has quit IRC | 15:02 | |
| *** itlinux has joined #openstack-trove | 15:18 | |
| *** imandhan has quit IRC | 15:27 | |
| *** imandhan has joined #openstack-trove | 15:28 | |
| *** imandhan has quit IRC | 15:32 | |
| *** dmk0202 has quit IRC | 15:44 | |
| *** ewilson has quit IRC | 15:46 | |
| *** ewilson has joined #openstack-trove | 15:50 | |
| *** johnma has joined #openstack-trove | 15:57 | |
| *** imandhan has joined #openstack-trove | 15:58 | |
| *** tosky has quit IRC | 15:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove: Updated from global requirements https://review.openstack.org/316960 | 16:03 |
| *** stewie925 has joined #openstack-trove | 16:03 | |
| stewie925 | hi pmalik good afternoon | 16:04 |
| *** Ravikiran_K has joined #openstack-trove | 16:05 | |
| stewie925 | I'd like to request your input regarding https://review.openstack.org/#/c/312611/ | 16:07 |
| stewie925 | there are still some issues with initializing the mock() in the setup method- when you have a chance to look into this, thank you | 16:09 |
| *** imandhan has quit IRC | 16:18 | |
| *** imandhan has joined #openstack-trove | 16:24 | |
| pmalik | stewie925 Hi. Sorry for late reply. The code looks good. This mocking stuff can sometimes get really convoluted. Keep in mind that the method got mocked at the beginning of the module before while now we are mocking it only for selected tests. It may happen that some other 'seemingly unrelated' tests start failing because they used to assume the heartbeat would be mocked. I will have to check it out and try myself, but w | 16:41 |
| pmalik | as away working on something else recently. I'll take a look soon. P. | 16:41 |
| stewie925 | thank you pmalik! :) | 16:42 |
| *** links has quit IRC | 16:47 | |
| pmalik | stewie925 I just tried to run it locally. I don't see why the actual calls are suddenly different. It may be caused by some interaction between tests/variables... | 16:48 |
| stewie925 | oh I see... | 16:50 |
| *** Shri has joined #openstack-trove | 16:58 | |
| *** Shri has quit IRC | 17:04 | |
| *** Shri has joined #openstack-trove | 17:04 | |
| *** ShridharR has joined #openstack-trove | 17:04 | |
| amrith | mordred, your change https://review.openstack.org/#/c/314032/1 like the rest of our gate are waiting for https://review.openstack.org/#/c/316789/ | 17:05 |
| amrith | we use dib in our gate | 17:05 |
| pmalik | stewie925 amrith You know what. Those new failures (i.e. instance_id = None and sent time on the actual call) may have always been there. Keep in mind that the tests were not really testing anything before. Rather than being a mock issue this may be a general test issue or even a valid bug in our code. | 17:07 |
| amrith | yes pmalik I realized that :) | 17:07 |
| amrith | and that made my head hurt | 17:07 |
| amrith | so I decided to do something else less dangerous (like bull fighting) :) | 17:08 |
| amrith | I'm not sure how to fix that without a singificant amount of work. | 17:08 |
| mordred | amrith: ah! ok. I'll stop poking it | 17:09 |
| *** tosky has joined #openstack-trove | 17:09 | |
| amrith | mordred, np. I'll be in your neck of the woods August 3. | 17:10 |
| amrith | (not july 3 as earlier planned) | 17:10 |
| *** david-lyle_ has quit IRC | 17:12 | |
| *** david-lyle has joined #openstack-trove | 17:13 | |
| stewie925 | sorry to hear that pmalik and amrith - given that the fix may take a significant amount of work and time, should we abandon this fix in the meantime? | 17:14 |
| amrith | stewie925, no. I saw we try to figure out how to fix it | 17:14 |
| stewie925 | thank you, thank makes sense | 17:15 |
| *** cweid has joined #openstack-trove | 17:18 | |
| stewie925 | in the meantime I have the renaming of 'called_once_with" to "assert_called_once_with" on my local machine, I have not committed that due to the errors we are seeing :) | 17:19 |
| *** rcernin has quit IRC | 17:47 | |
| *** ShridharR has quit IRC | 18:08 | |
| *** Shri has quit IRC | 18:08 | |
| *** delattec has joined #openstack-trove | 18:09 | |
| *** cdelatte has quit IRC | 18:12 | |
| *** delatte has joined #openstack-trove | 18:14 | |
| *** Ravikiran_K has quit IRC | 18:16 | |
| *** delattec has quit IRC | 18:17 | |
| openstackgerrit | Duk Loi proposed openstack/trove-dashboard: Trove add support for log retrieval https://review.openstack.org/289564 | 18:23 |
| openstackgerrit | Merged openstack/trove-dashboard: Delegate network panel to instance network panel https://review.openstack.org/315045 | 18:26 |
| openstackgerrit | Duk Loi proposed openstack/trove-dashboard: Add support for instance datastore-flavors https://review.openstack.org/286159 | 18:55 |
| *** arist has quit IRC | 19:01 | |
| *** arist has joined #openstack-trove | 19:02 | |
| *** tqtran has joined #openstack-trove | 19:04 | |
| *** stewie925 has quit IRC | 19:11 | |
| openstackgerrit | Duk Loi proposed openstack/trove-dashboard: Get all instances to populate master pulldown https://review.openstack.org/286164 | 19:12 |
| *** Shri has joined #openstack-trove | 19:16 | |
| *** ShridharR has joined #openstack-trove | 19:16 | |
| *** rcernin has joined #openstack-trove | 19:42 | |
| openstackgerrit | Laurel Michaels proposed openstack/trove: Adds the api-ref migrated RST + YAML files https://review.openstack.org/316381 | 19:44 |
| *** dmk0202 has joined #openstack-trove | 20:14 | |
| *** amrith is now known as _amrith_ | 20:18 | |
| *** johnma has quit IRC | 20:35 | |
| *** CIA has quit IRC | 20:51 | |
| *** ShridharR has quit IRC | 21:01 | |
| *** Shri has quit IRC | 21:01 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Cleanup guestagent models https://review.openstack.org/278074 | 21:03 |
| *** ewilson has quit IRC | 21:04 | |
| *** ewilson has joined #openstack-trove | 21:05 | |
| *** sgotliv_ has quit IRC | 21:13 | |
| *** cweid has quit IRC | 21:21 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Repl tests retrieve configs via test_helper https://review.openstack.org/317097 | 21:31 |
| *** _amrith_ is now known as amrith | 21:39 | |
| *** ewilson has quit IRC | 21:40 | |
| *** miqui has quit IRC | 22:04 | |
| *** dmk0202 has quit IRC | 22:10 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Disable connection pooling in sql test helper https://review.openstack.org/317112 | 22:18 |
| *** imandhan has quit IRC | 22:58 | |
| *** imandhan has joined #openstack-trove | 22:58 | |
| *** imandhan has quit IRC | 23:02 | |
| *** itisha has joined #openstack-trove | 23:03 | |
| *** ShridharR has joined #openstack-trove | 23:06 | |
| *** rcernin has quit IRC | 23:08 | |
| *** tqtran has quit IRC | 23:26 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!