| openstackgerrit | PanFengyun proposed openstack/trove: Add Python 3.5 classifier and venv https://review.openstack.org/341877 | 00:11 |
|---|---|---|
| *** Ravikiran_K has quit IRC | 00:32 | |
| *** imandhan has quit IRC | 00:49 | |
| *** imandhan has joined #openstack-trove | 00:49 | |
| *** imandhan has quit IRC | 00:54 | |
| *** itlinux has quit IRC | 01:45 | |
| *** kfox1111 has quit IRC | 01:51 | |
| openstackgerrit | gecong proposed openstack/trove: Replace assertEqual(None, *) with assertIsNone in tests https://review.openstack.org/342509 | 01:57 |
| *** pmackinn has quit IRC | 02:01 | |
| *** pmackinn has joined #openstack-trove | 02:09 | |
| *** links has joined #openstack-trove | 02:16 | |
| *** ewilson has joined #openstack-trove | 02:39 | |
| *** chlong has joined #openstack-trove | 02:56 | |
| *** links has quit IRC | 03:33 | |
| *** ewilson has quit IRC | 04:32 | |
| *** links has joined #openstack-trove | 04:39 | |
| *** tonyb has joined #openstack-trove | 05:15 | |
| tonyb | peterstac: ping? | 05:16 |
| tonyb | anyone else that can help me understand the trove gate? | 05:16 |
| *** gouthamr_ has quit IRC | 05:17 | |
| *** itisha has quit IRC | 05:20 | |
| *** pmackinn has quit IRC | 05:21 | |
| *** arist has quit IRC | 05:41 | |
| *** arist has joined #openstack-trove | 05:42 | |
| *** rcernin has joined #openstack-trove | 06:18 | |
| *** openstackgerrit has quit IRC | 06:33 | |
| *** openstackgerrit has joined #openstack-trove | 06:33 | |
| *** chlong has quit IRC | 06:38 | |
| *** coolsvap has joined #openstack-trove | 06:46 | |
| *** tesseract- has joined #openstack-trove | 07:15 | |
| *** pcaruana has joined #openstack-trove | 07:27 | |
| *** coolsvap has quit IRC | 07:31 | |
| *** coolsvap has joined #openstack-trove | 07:31 | |
| *** coolsvap has quit IRC | 07:37 | |
| *** coolsvap has joined #openstack-trove | 07:37 | |
| *** Ravikiran_K has joined #openstack-trove | 07:44 | |
| *** haypo has joined #openstack-trove | 09:08 | |
| haypo | hello. i wrote a patch which simply enables 2 unit tests which already pass on Python 3: https://review.openstack.org/#/c/338956/ | 09:10 |
| haypo | the patch doesn't touch any code: it just removes 2 lines from blacklist-py3.txt. the CI confirmed that the tests pass | 09:10 |
| haypo | the change https://review.openstack.org/#/c/336052/ is also waiting for your review ;) | 09:10 |
| *** tosky has joined #openstack-trove | 09:44 | |
| *** rcernin has quit IRC | 10:26 | |
| *** rcernin has joined #openstack-trove | 10:45 | |
| *** rcernin is now known as rcernin|lunch | 10:46 | |
| *** sgotliv has joined #openstack-trove | 10:53 | |
| *** sgotliv has quit IRC | 11:09 | |
| *** cdelatte has joined #openstack-trove | 11:22 | |
| *** gouthamr has joined #openstack-trove | 12:28 | |
| *** coolsvap is now known as coolsvap|afk | 12:43 | |
| *** ewilson has joined #openstack-trove | 12:51 | |
| *** pmackinn has joined #openstack-trove | 13:08 | |
| *** pmackinn has quit IRC | 13:28 | |
| *** pmackinn has joined #openstack-trove | 13:29 | |
| *** trevormc has joined #openstack-trove | 13:48 | |
| *** itisha has joined #openstack-trove | 13:57 | |
| openstackgerrit | amrith proposed openstack/trove: added release note for requirement change https://review.openstack.org/342876 | 14:04 |
| *** xb_ has quit IRC | 14:19 | |
| -openstackstatus- NOTICE: Gerrit is restarting to correct memory/performance issues. | 14:19 | |
| *** pmackinn has quit IRC | 14:22 | |
| *** pmackinn has joined #openstack-trove | 14:23 | |
| *** links has quit IRC | 14:27 | |
| *** ewilson has quit IRC | 14:30 | |
| *** dasTor has quit IRC | 14:57 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Add support for module ordering on apply https://review.openstack.org/341208 | 15:33 |
| *** itlinux has joined #openstack-trove | 15:34 | |
| *** links has joined #openstack-trove | 15:45 | |
| openstackgerrit | Merged openstack/trove-specs: Quota Update https://review.openstack.org/332885 | 15:48 |
| *** coolsvap|afk has quit IRC | 15:50 | |
| *** coolsvap|afk has joined #openstack-trove | 15:51 | |
| *** coolsvap|afk is now known as coolsvap | 15:51 | |
| *** sampilla has joined #openstack-trove | 16:02 | |
| sampilla | petersac: I was running some tox tests after making some changes to the test_dbaas.py file (for bug #1474100), using the previous review as a starting point (https://review.openstack.org/#/c/230371/) and am getting Exceptions like : "... needs to be unmocked". I am thinking it may be a multi-threading issue. Have any thoughts? | 16:02 |
| openstack | bug 1474100 in OpenStack DBaaS (Trove) "Mistyped input in test_dbass invalidates some unit tests" [Medium,Confirmed] https://launchpad.net/bugs/1474100 - Assigned to Samuel Pilla (samuel.pilla) | 16:02 |
| *** tesseract- has quit IRC | 16:16 | |
| *** rcernin|lunch has quit IRC | 16:18 | |
| *** pcaruana has quit IRC | 16:20 | |
| *** cdelatte has quit IRC | 16:29 | |
| *** pmackinn has quit IRC | 16:32 | |
| *** pmackinn has joined #openstack-trove | 16:33 | |
| *** Ravikiran_K has quit IRC | 16:35 | |
| amrith | peterstac, johnma I'm forcing this to merge; py27 and pep8 passed which is all that really matters for this change https://review.openstack.org/#/c/342876/1 | 17:05 |
| amrith | fyi: recheck has to be a comment by itself; you can't post a comment that says "are you bloody kidding me; recheck" | 17:06 |
| peterstac | recheck has to be the first part of the message I believe | 17:07 |
| peterstac | so 'recheck are you kidding me' might work ;) | 17:08 |
| peterstac | also the gate is still broken | 17:08 |
| peterstac | I'm getting ready to push up a changeset that fixes it from our end | 17:08 |
| amrith | oh, goody ... | 17:10 |
| amrith | I'll let tonyb know (I guess tagging him is equivalent to that) | 17:10 |
| amrith | tonyb, the tag on mitaka has to wait till peterstac does his magic | 17:11 |
| openstackgerrit | Peter Stachowski proposed openstack/trove-integration: [fix gate] Use upper-constraints on image build https://review.openstack.org/342971 | 17:14 |
| peterstac | amrith ^^^^ I tested that with Ubuntu, but only on master - hopefully my branch code works too :) | 17:15 |
| amrith | peterstac, I posted a comment on it | 17:18 |
| amrith | may be that you don't want to address that now | 17:19 |
| amrith | maybe you want to address the issue a different way; pinning a version in the requirements file that is in trove-integration (smaller footprint of change) | 17:19 |
| amrith | you decide | 17:19 |
| peterstac | amrith, I'm not sure what you want me to change - the requirements stuff works at the moment, doesn't it? | 17:20 |
| amrith | for some value of 'works' :) | 17:22 |
| amrith | I'm saying you don't have to introduce u-c into the mix; you could fix this problem by just pinning in requirements if you wanted. | 17:23 |
| *** sgotliv has joined #openstack-trove | 17:23 | |
| peterstac | sure, but since trove-int isn't versioned there's not much else we can do | 17:23 |
| peterstac | but that would mean manually bumping up the requirements every time something changed | 17:23 |
| peterstac | (it would give us a chance to vet the changes first, mind you, but more work to do in general) | 17:24 |
| *** tosky has quit IRC | 17:25 | |
| amrith | yes, and true. let's see what johnma feels | 17:27 |
| *** Ravikiran_K has joined #openstack-trove | 17:28 | |
| *** catintheroof has joined #openstack-trove | 17:48 | |
| *** links has quit IRC | 17:52 | |
| sampilla | peterstac: I was running some tox tests after making some changes to the test_dbaas.py file (for bug #1474100), using the previous review as a starting point (https://review.openstack.org/#/c/230371/) and am getting Exceptions like : "... needs to be unmocked". I am thinking it may be a multi-threading issue. Have any thoughts? (Sorry, misspelled the handle first time) | 17:53 |
| openstack | bug 1474100 in OpenStack DBaaS (Trove) "Mistyped input in test_dbass invalidates some unit tests" [Medium,Confirmed] https://launchpad.net/bugs/1474100 - Assigned to Samuel Pilla (samuel.pilla) | 17:53 |
| *** haypo has left #openstack-trove | 17:54 | |
| peterstac | sampilla, typically that error is because something is mocked and then not unmocked | 17:56 |
| *** catintheroof has quit IRC | 17:56 | |
| sampilla | Ok, I am starting to get familiar with mocking, so I'll start looking into that further. Thanks! | 17:57 |
| peterstac | there are a bunch of patterns for mocking correctly - see http://docs.openstack.org/developer/trove/dev/testing.html | 17:58 |
| peterstac | (I think a couple are a bit out-of-date, but they're not incorrect - there's just a slightly better way of doing some) | 17:58 |
| *** rcernin has joined #openstack-trove | 17:59 | |
| peterstac | sampilla, no prob | 18:00 |
| johnma | peterstac, amrith: if we are using upper-constraints, then do we really need the requirements.txt file? | 18:10 |
| peterstac | johnma, yes I think we still do. It provides the lower limit and exclusions. | 18:11 |
| *** sgotliv has quit IRC | 18:12 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Clarify unittest documentation https://review.openstack.org/343020 | 18:28 |
| openstackgerrit | Peter Stachowski proposed openstack/trove-integration: [fix gate] Use upper-constraints on image build https://review.openstack.org/342971 | 18:30 |
| openstackgerrit | Merged openstack/trove-specs: Add support for module ordering on apply https://review.openstack.org/341208 | 19:03 |
| openstackgerrit | Merged openstack/trove-specs: Add configuration group management for DB2 https://review.openstack.org/327355 | 19:03 |
| openstackgerrit | Petr Malik proposed openstack/trove: Fix concurrency issue with Python 3.4 test https://review.openstack.org/343048 | 19:35 |
| *** imandhan has joined #openstack-trove | 19:37 | |
| *** imandhan has quit IRC | 20:09 | |
| *** imandhan has joined #openstack-trove | 20:09 | |
| *** imandhan has quit IRC | 20:19 | |
| *** sampilla has quit IRC | 20:25 | |
| *** imandhan has joined #openstack-trove | 20:26 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Scheduled Backup Specification https://review.openstack.org/329510 | 20:33 |
| *** imandhan has quit IRC | 20:34 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Clarify unittest documentation https://review.openstack.org/343020 | 20:37 |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Scheduled Backup Specification https://review.openstack.org/329510 | 20:42 |
| *** imandhan has joined #openstack-trove | 20:43 | |
| *** Ravikiran_K has quit IRC | 20:43 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Scheduled Backup Specification https://review.openstack.org/329510 | 20:46 |
| peterstac | johnma, I've addressed your concerns in vgnbkr's spec as best I can (he's on vacation at the moment) | 20:46 |
| peterstac | let me know if you think it needs more tweaking https://review.openstack.org/#/c/329510/ | 20:46 |
| johnma | thanks peterstac, I was going to ask about it. Let me review it now. | 20:47 |
| openstackgerrit | Peter Stachowski proposed openstack/trove-specs: Scheduled Backup Specification https://review.openstack.org/329510 | 20:48 |
| peterstac | johnma, ok, thx (I just added one more link to the spec :) ) | 20:48 |
| johnma | awesome, thanks | 20:48 |
| *** gouthamr has quit IRC | 20:51 | |
| *** imandhan has quit IRC | 20:53 | |
| *** imandhan has joined #openstack-trove | 20:57 | |
| *** imandhan has quit IRC | 21:09 | |
| *** imandhan has joined #openstack-trove | 21:17 | |
| *** pmackinn has quit IRC | 21:27 | |
| *** trevormc has quit IRC | 21:32 | |
| *** imandhan has quit IRC | 21:38 | |
| *** imandhan has joined #openstack-trove | 21:46 | |
| *** imandhan has quit IRC | 21:56 | |
| *** imandhan has joined #openstack-trove | 22:05 | |
| openstackgerrit | Merged openstack/trove-specs: Scheduled Backup Specification https://review.openstack.org/329510 | 22:09 |
| *** pmackinn has joined #openstack-trove | 22:10 | |
| *** pmackinn has quit IRC | 22:15 | |
| *** imandhan has quit IRC | 22:20 | |
| *** imandhan has joined #openstack-trove | 22:26 | |
| *** imandhan has quit IRC | 22:42 | |
| *** imandhan has joined #openstack-trove | 22:46 | |
| *** imandhan has quit IRC | 23:12 | |
| *** imandhan has joined #openstack-trove | 23:21 | |
| *** rcernin has quit IRC | 23:30 | |
| *** imandhan has quit IRC | 23:34 | |
| *** imandhan has joined #openstack-trove | 23:35 | |
| *** imandhan has quit IRC | 23:39 | |
| *** imandhan has joined #openstack-trove | 23:44 | |
| openstackgerrit | Merged openstack/trove-integration: [fix gate] Use upper-constraints on image build https://review.openstack.org/342971 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!