| phuong | amrith: yes, I will update follow your comments | 00:01 |
|---|---|---|
| amrith | phuong, what is the benefit of changing the names of the variables to be something not intuitive? | 00:02 |
| phuong | amrith: just my mistake in naming a variable, I will update the variable name | 00:03 |
| amrith | phuong, furthermore, these imports of modules occur all over Trove. If this is something important (and I don't believe that it is because it is not a hacking check that we enforce) then I'd expect that it be changed in more places. | 00:10 |
| amrith | In any event, I'm dubious about the value of this change. | 00:10 |
| amrith | it does not, I don't believe, make trove materially better. | 00:10 |
| amrith | it doesn't fix a 'bug' | 00:10 |
| amrith | it doesn't add a new feature | 00:11 |
| amrith | it doesn't make it easier for people to use Trove | 00:11 |
| phuong | yes, it is for cleaning code only | 00:11 |
| *** johnbabers has quit IRC | 00:12 | |
| phuong | amrith: follow the guideline of Openstack: http://docs.openstack.org/developer/hacking/#imports | 00:12 |
| amrith | is there a hacking rule for this? | 00:13 |
| amrith | Does Trove explicitly ignore that rule | 00:13 |
| amrith | see tox.ini | 00:14 |
| phuong | if Trove explicitly ignore that rule, I think this patch is not neccessary | 00:15 |
| amrith | well, is there a hacking rule? | 00:15 |
| amrith | I don't know | 00:15 |
| amrith | but if there was, that would be the route I'd take | 00:16 |
| amrith | disable the ignore and see what broke | 00:16 |
| amrith | and it will be quite widespread | 00:16 |
| amrith | also, I wouldn't encourge your patch unless at the end of it, you enable the hacking rule | 00:16 |
| amrith | otherwise every three months, someone has to go in and do this cleanup manually | 00:16 |
| phuong | amrith: about a rule, I am not sure how to create it because even in nova or neutron I still see this style of code happen | 00:19 |
| phuong | amrith: I think core reviewer should remember it and check while reviewing | 00:21 |
| *** phuong has quit IRC | 00:49 | |
| openstackgerrit | Masaki Matsushita proposed openstack/python-troveclient: Use strutils.to_slug() instead of utils.slugify() https://review.openstack.org/365430 | 00:58 |
| openstackgerrit | Masaki Matsushita proposed openstack/python-troveclient: Use strutils.to_slug() instead of utils.slugify() https://review.openstack.org/365430 | 01:17 |
| *** dkehn has joined #openstack-trove | 02:09 | |
| *** zhugaoxiao has quit IRC | 03:14 | |
| *** zhugaoxiao has joined #openstack-trove | 03:14 | |
| *** diga has joined #openstack-trove | 03:51 | |
| *** dkehn_ has joined #openstack-trove | 03:51 | |
| *** links has joined #openstack-trove | 04:39 | |
| *** itisha has quit IRC | 05:11 | |
| *** hoonetorg has quit IRC | 05:48 | |
| *** hoonetorg has joined #openstack-trove | 06:12 | |
| *** pcaruana has joined #openstack-trove | 06:48 | |
| *** dkehn_ has quit IRC | 06:56 | |
| *** tesseract- has joined #openstack-trove | 07:00 | |
| *** dkehn_ has joined #openstack-trove | 07:01 | |
| *** songjian has joined #openstack-trove | 07:13 | |
| songjian | Here, http://docs.openstack.org/developer/trove/dev/trove_api_extensions.html, warnging to as: No documentation found in accounttrove. Extensions. Routes. The account: the account... Let's have backup address on API? | 07:13 |
| songjian | I seem to have found, http: //developer.openstack.org/api-ref-database-v1.html | 07:17 |
| *** drifterza has joined #openstack-trove | 07:26 | |
| *** Ravikiran_K has joined #openstack-trove | 07:50 | |
| *** songjian has quit IRC | 08:39 | |
| *** songjian has joined #openstack-trove | 08:39 | |
| openstackgerrit | Merged openstack/trove-image-builder: Cleanup tox.ini https://review.openstack.org/360992 | 08:47 |
| *** songjian has quit IRC | 08:52 | |
| *** songjian has joined #openstack-trove | 08:52 | |
| openstackgerrit | Ha Van Tu proposed openstack/trove: Remove unused parameters https://review.openstack.org/365956 | 09:00 |
| openstackgerrit | amrith proposed openstack/trove-integration: Revert two commits https://review.openstack.org/365960 | 09:03 |
| *** kiteall has joined #openstack-trove | 09:34 | |
| amrith | all: the trove gate is broken (see https://bugs.launchpad.net/trove/+bug/1620546). Please don't bother with rechecks, they will fail | 10:02 |
| openstack | Launchpad bug 1620546 in OpenStack DBaaS (Trove) "trove guests don't launch; error in keystone import" [Critical,New] - Assigned to Amrith (amrith) | 10:02 |
| openstackgerrit | amrith proposed openstack/trove-integration: missing requirements of keystoneclient https://review.openstack.org/366036 | 10:27 |
| amrith | peterstac, johnma please review https://review.openstack.org/366036; it should fix the broken gate. | 11:16 |
| *** cdelatte has joined #openstack-trove | 11:19 | |
| amrith | thx johnma | 11:19 |
| amrith | just saw your review | 11:19 |
| *** dkehn_ has quit IRC | 11:23 | |
| johnma | amrith, np. just curious, was this library never in that file | 11:23 |
| amrith | g'morning johnma. this lib wasn't in that file as far as I can see. but something else must've depended on it and therefore caused it to get installed. | 11:23 |
| amrith | and when that dependency changed, the cascading effect was that it didn't get installed on the guest. | 11:24 |
| johnma | GM amrith. | 11:24 |
| amrith | I put some debug output from past runs into the bug | 11:25 |
| amrith | showing what was getting installed | 11:25 |
| amrith | in the last successful run and in the current failing runs | 11:25 |
| johnma | I saw that, didnt read through the whole log though. Thanks amrith for taking care of this. I hit this exact same issue yesterday but figured it was something wrong with my env so switched to another system. That was the easy thing to do :) | 11:30 |
| amrith | interesting, and it worked on the other system? | 11:30 |
| amrith | maybe because you already had a guest built? | 11:30 |
| *** dkehn_ has joined #openstack-trove | 11:35 | |
| johnma | yes amrith, I has an older one on the other system, so I could carry on with testing. | 11:43 |
| amrith | thx, that explains it. | 11:43 |
| *** songjian has quit IRC | 12:45 | |
| *** pcaruana has quit IRC | 12:50 | |
| *** diga has quit IRC | 12:59 | |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Extract RPMPackagerMixin https://review.openstack.org/366140 | 13:47 |
| *** johnbabers has joined #openstack-trove | 13:51 | |
| *** kiteall has quit IRC | 14:00 | |
| *** trevormc has joined #openstack-trove | 14:17 | |
| *** links has quit IRC | 14:21 | |
| *** zigo has quit IRC | 14:25 | |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Add ZypperPackagerMixin to guestagent https://review.openstack.org/366165 | 14:25 |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Add ZypperPackagerMixin to guestagent https://review.openstack.org/366165 | 14:28 |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Extract RPMPackagerMixin https://review.openstack.org/366140 | 14:28 |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Add ZypperPackagerMixin to guestagent https://review.openstack.org/366165 | 14:29 |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Extract RPMPackagerMixin https://review.openstack.org/366140 | 14:29 |
| openstackgerrit | Thomas Bechtold proposed openstack/trove: Add ZypperPackagerMixin to guestagent https://review.openstack.org/366165 | 14:31 |
| *** zigo has joined #openstack-trove | 14:32 | |
| *** zigo is now known as Guest39147 | 14:33 | |
| *** Guest39147 has quit IRC | 14:39 | |
| *** zigo_ has joined #openstack-trove | 14:42 | |
| *** johnbabers has quit IRC | 14:43 | |
| *** zigo_ has quit IRC | 14:47 | |
| *** zigo_ has joined #openstack-trove | 14:48 | |
| *** georgelorch2 is now known as georgelorch | 14:53 | |
| *** dkehn_ has quit IRC | 14:57 | |
| *** miqui has joined #openstack-trove | 14:59 | |
| *** dkehn_ has joined #openstack-trove | 15:10 | |
| *** gouthamr has joined #openstack-trove | 15:10 | |
| *** gouthamr_ has joined #openstack-trove | 15:12 | |
| *** gouthamr has quit IRC | 15:15 | |
| *** zigo_ is now known as zigo | 15:20 | |
| *** pcaruana has joined #openstack-trove | 15:42 | |
| openstackgerrit | Merged openstack/trove-integration: missing requirements of keystoneclient https://review.openstack.org/366036 | 15:44 |
| *** dkehn__ has joined #openstack-trove | 15:54 | |
| *** dkehn__ has quit IRC | 16:09 | |
| *** georgelorch has quit IRC | 16:18 | |
| *** gouthamr_ has quit IRC | 16:20 | |
| *** georgelorch has joined #openstack-trove | 16:23 | |
| amrith | peterstac, yt? | 16:23 |
| amrith | you can recheck things that you've been waiting on | 16:23 |
| amrith | they should pass now (I hope) | 16:24 |
| *** drifterza has quit IRC | 16:26 | |
| *** dkehn__ has joined #openstack-trove | 16:30 | |
| *** stevemar has quit IRC | 16:31 | |
| *** gouthamr has joined #openstack-trove | 16:33 | |
| *** hogepodge has quit IRC | 16:58 | |
| *** hogepodge has joined #openstack-trove | 17:03 | |
| *** pmackinn has joined #openstack-trove | 17:08 | |
| *** stevemar has joined #openstack-trove | 17:26 | |
| *** tqtran has joined #openstack-trove | 17:31 | |
| *** harlowja has joined #openstack-trove | 17:38 | |
| *** Ravikiran_K has quit IRC | 17:40 | |
| peterstac | hi amrith | 17:52 |
| peterstac | yes, I did a bunch of rechecks | 17:53 |
| amrith | got a second to chat? | 17:56 |
| *** ewilson has joined #openstack-trove | 17:57 | |
| *** dkehn__ has quit IRC | 18:03 | |
| *** dkehn_ has quit IRC | 18:03 | |
| *** dkehn has quit IRC | 18:03 | |
| *** dkehn has joined #openstack-trove | 18:09 | |
| *** dkehn__ has joined #openstack-trove | 18:15 | |
| *** dkehn_ has joined #openstack-trove | 18:15 | |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove-dashboard: [WIP] Add cluster support for affinity/anti-affinity https://review.openstack.org/353699 | 18:27 |
| *** xb_ has quit IRC | 18:59 | |
| *** xb_ has joined #openstack-trove | 19:01 | |
| *** trevormc has quit IRC | 19:07 | |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove-dashboard: Use proper check for inactive datastore version https://review.openstack.org/357315 | 19:08 |
| *** pcaruana has quit IRC | 19:11 | |
| openstackgerrit | mariam john proposed openstack/trove: Implement full online backups for DB2 https://review.openstack.org/364431 | 19:13 |
| openstackgerrit | mariam john proposed openstack/trove: Implement full online backups for DB2 https://review.openstack.org/364431 | 19:17 |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove-dashboard: Add availability zone to launch instance https://review.openstack.org/354134 | 19:24 |
| *** tesseract- has quit IRC | 19:25 | |
| *** xb_ has quit IRC | 19:25 | |
| *** xb_ has joined #openstack-trove | 19:27 | |
| *** schang_ has joined #openstack-trove | 19:28 | |
| *** schang_ has quit IRC | 19:30 | |
| *** rcernin has joined #openstack-trove | 19:41 | |
| *** xb_ has quit IRC | 19:44 | |
| *** xb_ has joined #openstack-trove | 19:45 | |
| *** rcernin has quit IRC | 19:48 | |
| *** xb_ has quit IRC | 19:52 | |
| *** tqtran has quit IRC | 19:55 | |
| *** xb_ has joined #openstack-trove | 20:13 | |
| *** tqtran has joined #openstack-trove | 20:34 | |
| *** cdelatte has quit IRC | 20:44 | |
| *** xb_ has quit IRC | 21:00 | |
| *** xb_ has joined #openstack-trove | 21:11 | |
| *** ewilson has quit IRC | 21:15 | |
| *** stevemar has quit IRC | 21:52 | |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove: Add --incremental flag to backup-create https://review.openstack.org/348548 | 21:53 |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove: Add --incremental flag to backup-create https://review.openstack.org/348548 | 21:55 |
| openstackgerrit | Ali Asgar Adil proposed openstack/trove: Add command to delete BUILD instances and clusters https://review.openstack.org/343931 | 21:55 |
| *** miqui has quit IRC | 22:05 | |
| *** stevemar has joined #openstack-trove | 22:24 | |
| *** stevemar has quit IRC | 22:26 | |
| *** stevemar has joined #openstack-trove | 22:26 | |
| *** stevemar has quit IRC | 22:31 | |
| *** stevemar has joined #openstack-trove | 23:07 | |
| *** bapalm has quit IRC | 23:35 | |
| *** bapalm has joined #openstack-trove | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!