Wednesday, 2016-09-14

*** trevormc has quit IRC00:05
*** imandhan has quit IRC00:08
openstackgerritMerged openstack/trove: Implement full online backups for DB2  https://review.openstack.org/36443100:09
*** imandhan has joined #openstack-trove00:10
*** tqtran has quit IRC00:25
*** itlinux has quit IRC00:40
*** itlinux has joined #openstack-trove00:41
*** itlinux has quit IRC00:56
openstackgerritliuqing proposed openstack/trove: [install-guide]add more information for trove-guestagent.conf  https://review.openstack.org/36912500:57
*** cheneydc has joined #openstack-trove00:59
*** itlinux has joined #openstack-trove01:00
peterstacpmalik, already +2'd it01:03
*** johnbabers has joined #openstack-trove01:09
*** johnbabers has quit IRC01:17
*** gouthamr has quit IRC01:17
*** johnbabers has joined #openstack-trove01:26
*** cheneydc has quit IRC01:27
*** itlinux has quit IRC01:39
*** itlinux has joined #openstack-trove01:46
*** itlinux has quit IRC01:56
*** johnbabers has quit IRC02:00
openstackgerritMerged openstack/trove: Allow for invalid packet sequence in keepalive  https://review.openstack.org/36234702:38
amrithpeterstac, johnma ^^02:43
peterstacyep, saw it02:46
peterstacdo we want to get https://review.openstack.org/#/c/357293/ in?02:46
*** stevemar_ is now known as stevemar02:49
*** itlinux has joined #openstack-trove02:57
*** itlinux has quit IRC03:07
openstackgerritPeter Stachowski proposed openstack/trove-integration: Enhance 'redstack clean' regarding modules  https://review.openstack.org/36453903:10
amrithpeterstac, I was going to look at it in the morning. I added it to the list for rc203:12
peterstacok, sounds good03:12
openstackgerritjian.song proposed openstack/trove: Concentrated test_validate_xx_configuration to a new method  https://review.openstack.org/36925203:19
*** tqtran has joined #openstack-trove03:22
*** songjian has joined #openstack-trove03:25
*** tqtran has quit IRC03:26
*** imandhan has quit IRC03:32
*** songjian has quit IRC03:35
*** songjian has joined #openstack-trove03:36
openstackgerritamrith proposed openstack/trove-integration: DNM: Test kvm-ok within a CI infrastructure  https://review.openstack.org/36980603:38
*** himani has joined #openstack-trove03:41
*** khushbu_ has joined #openstack-trove03:41
*** itlinux has joined #openstack-trove03:46
*** itlinux has quit IRC03:56
*** songjian has quit IRC04:04
*** songjian has joined #openstack-trove04:04
*** songjian has quit IRC04:10
*** songjian has joined #openstack-trove04:10
openstackgerritClark Boylan proposed openstack/trove-integration: DNM: hacks to create and upload raw image  https://review.openstack.org/36980904:15
*** imandhan has joined #openstack-trove04:25
*** diga has joined #openstack-trove04:28
*** _imandhan_ has joined #openstack-trove04:29
*** songjian has quit IRC04:30
*** songjian has joined #openstack-trove04:31
*** imandhan has quit IRC04:32
*** itlinux has joined #openstack-trove04:37
*** imandhan has joined #openstack-trove04:46
*** itlinux has quit IRC04:47
openstackgerritamrith proposed openstack/trove-integration: DNM: check if this causes lxc  https://review.openstack.org/36981304:48
*** _imandhan_ has quit IRC04:49
*** khushbu_ has quit IRC04:57
*** imandhan has quit IRC04:57
*** imandhan has joined #openstack-trove04:58
*** khushbu_ has joined #openstack-trove04:59
*** _imandhan_ has joined #openstack-trove05:05
*** imandhan has quit IRC05:07
*** songjian has quit IRC05:10
*** greghaynes has joined #openstack-trove05:26
*** pmackinn has quit IRC05:27
*** rcernin has joined #openstack-trove05:33
*** khushbu_ has quit IRC05:37
*** itlinux has joined #openstack-trove05:47
*** itlinux has quit IRC06:01
openstackgerritjian.song proposed openstack/trove: Concentrated test_validate_xx_configuration to a new method  https://review.openstack.org/36925206:06
*** songjian has joined #openstack-trove06:06
openstackgerritOpenStack Proposal Bot proposed openstack/trove-dashboard: Imported Translations from Zanata  https://review.openstack.org/36984206:17
*** songjian has quit IRC06:26
*** songjian has joined #openstack-trove06:27
*** pcaruana has joined #openstack-trove06:32
*** itlinux has joined #openstack-trove06:36
*** imandhan has joined #openstack-trove06:44
*** itlinux has quit IRC06:46
*** _imandhan_ has quit IRC06:48
*** tesseract- has joined #openstack-trove06:57
*** _imandhan_ has joined #openstack-trove07:01
*** imandhan has quit IRC07:04
*** drifterza has joined #openstack-trove07:14
*** _imandhan_ has quit IRC07:16
*** imandhan has joined #openstack-trove07:17
*** Ravikiran_K has joined #openstack-trove07:19
*** imandhan has quit IRC07:23
*** imandhan has joined #openstack-trove07:24
*** tqtran has joined #openstack-trove07:26
*** imandhan has quit IRC07:30
*** tqtran has quit IRC07:31
*** imandhan has joined #openstack-trove07:31
*** songjian has quit IRC07:39
openstackgerritJanice-Chen proposed openstack/trove: Fix for get volume_type failure for cluster_create in CLI  https://review.openstack.org/36987307:46
*** _imandhan_ has joined #openstack-trove07:47
*** imandhan has quit IRC07:50
openstackgerritjian.song proposed openstack/trove: Delete some unnecessary initial value = None  https://review.openstack.org/36987507:55
*** itlinux has joined #openstack-trove07:55
*** _imandhan_ has quit IRC08:01
*** imandhan has joined #openstack-trove08:02
*** itlinux has quit IRC08:05
*** khushbu_ has joined #openstack-trove08:12
openstackgerritjian.song proposed openstack/trove: Delete some unnecessary initial value = None  https://review.openstack.org/36987508:22
openstackgerritjian.song proposed openstack/trove: Delete some unnecessary initial value = None  https://review.openstack.org/36987508:24
*** songjian has joined #openstack-trove08:30
*** songjian has quit IRC08:32
*** imandhan has quit IRC08:38
*** songjian has joined #openstack-trove08:38
*** khushbu_ has quit IRC08:43
*** himani has quit IRC09:05
*** itlinux has joined #openstack-trove09:06
*** himani has joined #openstack-trove09:13
*** itlinux has quit IRC09:16
openstackgerritjian.song proposed openstack/trove: Delete some unnecessary initial value = None  https://review.openstack.org/36987509:23
openstackgerritjian.song proposed openstack/trove: Repeat definition blacklist  https://review.openstack.org/36997009:27
*** tqtran has joined #openstack-trove09:28
*** tqtran has quit IRC09:32
himaniHi core-members, I am new to this project and I want to contribute in this. If you know some bugs to get started with then please let me know.09:34
openstackgerritjian.song proposed openstack/trove: Delete unused method verify_errors  https://review.openstack.org/36997809:40
*** songjian has quit IRC09:41
*** tosky has joined #openstack-trove09:41
*** itlinux has joined #openstack-trove10:17
*** itlinux has quit IRC10:28
*** songjian has joined #openstack-trove10:37
songjianjohnma,hi,I have two commit ,all of them have two +2,could you please help me to review it,thanks a lot...https://review.openstack.org/#/c/362810/     https://review.openstack.org/#/c/363365/10:40
*** NBziouech has joined #openstack-trove10:43
*** khushbu_ has joined #openstack-trove10:49
johnmasongjian: done, thank you10:56
*** itlinux has joined #openstack-trove10:58
johnmahimani: Welcome to the group and thank you for your interest in Trove.10:58
dougshelley66himani welcome!10:59
dougshelley66himani have you been able to run through redstack setup and complete int-tests?11:00
*** cdelatte has joined #openstack-trove11:00
openstackgerritMerged openstack/trove: Add support for modules in cluster create/grow  https://review.openstack.org/31323211:00
dougshelley66that is a good pre-requisite to beginning to work on bugs11:00
dougshelley66let us know if you need help with that11:00
johnmahimani: you can always look for bugs at https://bugs.launchpad.net/trove and look for the ones tagged: Low hanging fruit. They are supposed to be the easy ones but there arent that many. In the coming days, will try to triage some bugs and tag some more11:02
*** himani has quit IRC11:03
*** himani has joined #openstack-trove11:06
johnmahimani: also, here is a list of reviews that were abandoned for various reasons: https://review.openstack.org/#/q/project:openstack/trove+status:abandoned. You can go through them and see if there is anything that interests you and restore it and continue to work on it. Of course11:06
openstackgerritMerged openstack/trove: Cassandra fix lost keyspace(s) after cluster grow  https://review.openstack.org/35729311:08
*** itlinux has quit IRC11:09
songjianjohnma,thx11:10
himanijohnma: thank you.11:12
*** khushbu_ has quit IRC11:18
*** diga has quit IRC11:18
*** himani has quit IRC11:27
*** tqtran has joined #openstack-trove11:29
*** tqtran has quit IRC11:34
*** openstackgerrit has quit IRC11:34
*** openstackgerrit has joined #openstack-trove11:34
*** songjian has quit IRC11:48
*** pmackinn has joined #openstack-trove11:50
*** drifterza has quit IRC11:55
*** drifterza has joined #openstack-trove12:07
*** itlinux has joined #openstack-trove12:09
*** gouthamr has joined #openstack-trove12:09
openstackgerritMerged openstack/trove: Update #noqa for out 79 character  https://review.openstack.org/36336512:11
amrithjohnma, dougshelley66 g'morning12:14
amrithplease see https://review.openstack.org/#/c/369823/ and https://review.openstack.org/#/c/369825/12:15
amrithdougshelley66, we will have to have speaks12:15
*** itlinux has quit IRC12:20
peterstacamrith, I think we're looking good - maybe we should get https://review.openstack.org/#/c/353699/ in too since the server side merged ...12:24
openstackgerritMerged openstack/trove-dashboard: Imported Translations from Zanata  https://review.openstack.org/36984212:28
amrithpeterstac, johnma ... the releasenotes in the release tagging commit come from the release notes that people put into commits.12:33
amrithif they don't put them on commits, they don't make it on the release commit12:34
amrithalso peterstac johnma dougshelley66 if the real fix for the issue https://review.openstack.org/#/c/369873/1 is what this commit proposes, I think we should take it for rc112:36
amrithI didn't understand what the guy was talking about in his bug12:36
amrithbut the fix sure looks like something we should take for rc112:36
*** 17WAAMUGO has joined #openstack-trove13:00
*** drifterza has quit IRC13:04
*** 17WAAMUGO has quit IRC13:05
openstackgerritamrith proposed openstack/trove: Cluster code looks for wrong field in request for volume type  https://review.openstack.org/36987313:14
amrithpeterstac, let's discuss this morning and figure out what we want to do.13:16
amrithjohnma ^^13:16
*** itlinux has joined #openstack-trove13:20
*** johnbabers has joined #openstack-trove13:31
*** tqtran has joined #openstack-trove13:31
*** itlinux has quit IRC13:34
*** johnbabers has quit IRC13:34
*** johnbabers has joined #openstack-trove13:35
*** zhugaoxiao has quit IRC13:35
*** tqtran has quit IRC13:35
johnmaamrith, peterstac: sorry just got back.13:58
johnmaamrith: regarding what makes it to the release notes, that makes sense.14:05
amrithjohnma, saw your updates to the rc1 review14:05
amrithI'll add the release notes14:06
amrithand make the change to online14:06
amrithI went through the trove-dashboard rc1 commit14:06
amrithand realized that not many people tagged release notes for trove-dashboard commits14:06
amrithso I actuall crawled through the list and added some14:06
amrithto make it look 'respectable' for a release :)14:06
johnma:)14:06
amrithso it isn't as though not having release notes means we don't add one ...14:07
amrithif there are others that you think we should reference for trove, please post comments14:07
amrithI'll add them to the highlights section.14:07
johnmawell the ones I mentioned in my earlier comments on the trove rc1 release notes14:07
johnmaI think pretty much the ones I mentioned dont have release notes - like postgresql incremental backup, scheduled backup14:08
amriththx johnma14:09
amrithI'm just reading pmalik's comment on https://review.openstack.org/36987314:10
amrithand I'm not sure I agree14:10
amrithpmalik, yt?14:10
*** trevormc has joined #openstack-trove14:19
peterstacamrith, looks like 369873 is a valid fix (as you and pmalik agreed on in the bug)14:28
amrithpeterstac, I'm looking to see if we can add a test14:29
amrithto make sure that this is right, and stays right14:29
amrithbut I think that may be overkill for this timeframe14:29
peterstacyeah - also I'm not sure how we can test 'shouldn't pull off the wrong value' as you can always do that :)14:30
*** itlinux has joined #openstack-trove14:35
*** spilla has joined #openstack-trove14:42
peterstacamrith, johnma, Does it makes sense to get https://review.openstack.org/#/c/353699 in too, since the cluster locality stuff merged?14:43
johnmapeterstac: I am actually testing it right now14:44
peterstacah, great thanks!14:44
*** johnbabers has quit IRC14:47
*** johnbabers has joined #openstack-trove14:47
amriththx peterstac I think we can make sure that it constructs the right nova call but let's leave that for now.14:50
amrithshould get this into rc1, as a priority14:50
amrithso once it merges, I'll take the new hash, update the release notes and push the trove thing. once the thing that mariam is testing is done, I'll get the dashboard hash.14:51
amrithsound good?14:51
peterstacsounds good14:51
peterstacon a good note - check out all the green on the test runs here! https://review.openstack.org/#/c/362347/14:53
johnmathe dashboard change is approved.15:09
johnmapeterstac: that's pretty neat.15:10
openstackgerritMerged openstack/trove-dashboard: Add cluster support for affinity/anti-affinity  https://review.openstack.org/35369915:12
*** pmackinn has quit IRC15:19
openstackgerritMerged openstack/trove-integration: Replace assertEqual(None, *) with assertIsNone  https://review.openstack.org/36281015:29
*** rcernin has quit IRC15:34
*** pcaruana has quit IRC15:40
*** johnbabers has quit IRC15:41
*** johnbabers has joined #openstack-trove15:42
*** johnbabers has quit IRC15:57
*** johnbabers has joined #openstack-trove15:57
*** johnbabers has quit IRC16:03
*** johnbabers has joined #openstack-trove16:09
*** johnbabers has quit IRC16:12
*** georgelorch has quit IRC16:17
*** georgelorch has joined #openstack-trove16:17
amrithpeterstac, johnma see above   https://review.openstack.org/353699. that's it for dashboard, yes?16:21
*** johnbabers has joined #openstack-trove16:21
johnmaI believe so amrith.16:21
*** johnbabers has quit IRC16:23
*** johnbabers has joined #openstack-trove16:24
peterstacthe only other outstanding one is https://review.openstack.org/#/c/358693/16:24
peterstacbut I don't know how critical it is (doesn't seem like it is)16:25
*** rcernin has joined #openstack-trove16:34
*** johnbabers has quit IRC16:34
*** tesseract- has quit IRC16:35
openstackgerritMerged openstack/trove: Cluster code looks for wrong field in request for volume type  https://review.openstack.org/36987316:35
*** johnbabers has joined #openstack-trove16:36
amrithgood deal ...16:36
*** johnbabers has quit IRC16:40
*** pmackinn has joined #openstack-trove16:46
*** johnbabers has joined #openstack-trove16:49
amrithpeterstac, johnma rc1 commits are back up (still WF-1) till trove meeting16:53
johnmasoudns good. thanks amrith16:54
amrithwould you both please take a look at https://review.openstack.org/#/c/367640/16:55
amriththe _ changes in taht commit at least should, I think, make it into newton16:55
amriththe lint stuff is only for test16:55
amrithand I'd like to add a gate job for that if possible16:56
*** tosky has quit IRC16:56
*** pmackinn has quit IRC17:00
*** pmackinn has joined #openstack-trove17:02
peterstacamrith, I'll take a look at that now17:10
peterstacalso we might want to get in some of the 'easier' reviews that are left (to avoid backporting them to stable/newton once we cut RC1)17:10
peterstacfor example: https://review.openstack.org/#/c/368184/17:11
peterstacjohnma ^^^17:11
johnmasorry missed the messages. Let me take a look at them now17:11
amriththat won't address your issue because when we cut RC1, the master/newton split will happen17:11
amrithI'm not looking to add more stuff to RC1; is that what you are advocating?17:12
peterstacalso: https://review.openstack.org/#/c/36760717:12
amrithI'm open to the idea if we can get them in there17:12
amrithwhy not put taht list into the meeting agenda17:12
peterstacamrith, yes I was thinking of getting more stuff into RC1 :)17:12
*** pmackinn has quit IRC17:16
*** tqtran has joined #openstack-trove17:34
*** NBziouech has quit IRC17:37
*** tqtran has quit IRC17:38
*** Alexey_Abashkin has joined #openstack-trove17:38
amrith7lb of sugar in a 12 oz bag17:39
*** itlinux has quit IRC17:39
*** AlexeyAbashkin has quit IRC17:41
amrithlet's talk about it17:41
amrithin 19m17:41
amrithjohnma, yt?17:48
amrithpeterstac, yt?17:49
peterstacok - I put any remaining changereqs that seem ready into the meeting agenda - there's only 6 more that might still make it IMO17:50
peterstacamrith, here17:50
amrithpeterstac, one issue ..17:50
amrithI tried to get https://review.openstack.org/#/c/367640/ ready for chkin17:50
amrithand address johnma's comment17:50
amrithand in the process, I figured I'd check if anything new got into the system since I build by 'exclusion file'17:51
amrithand the tool picked up this:17:51
amrithERROR: trove/guestagent/datastore/experimental/db2/service.py 256: E1101 no-member, DB2App._update_dbm_config: Instance of 'str' has no 'is_warning' member17:51
amrithwhich, I think, is a real problem17:51
amrith256 is the line number17:51
amriththis is something, potentially in johnma's new code.17:51
amritherr would be a string17:51
peterstacright - I checked out the code instead of cherry-picking it when I tested it17:52
amrithwell, same difference17:52
amriththis code is an exception path17:52
peterstacso it worked for me17:52
amrithhmm17:52
amrithwonder how17:52
peterstacI should have rebased it so it would check the latest and greatest17:52
peterstacI did that, and running it again ...17:53
peterstacyep, there are a few more errors17:54
*** tqtran has joined #openstack-trove17:54
peterstacwell, we can always fix them once we have a non-voting gate job17:55
amrithyes17:55
*** songjian has joined #openstack-trove17:56
amrithso I've pushed up a change with only a change to the readme for now17:56
amrithwe can handle the update to the known errors independently17:56
*** hongbin has joined #openstack-trove18:03
*** drifterza has joined #openstack-trove18:03
*** pmackinn has joined #openstack-trove18:08
*** drifterza has quit IRC18:13
*** nshah has left #openstack-trove18:13
*** nshah has joined #openstack-trove18:13
*** nshah has left #openstack-trove18:13
*** NBziouech has joined #openstack-trove18:23
*** imandhan has joined #openstack-trove18:42
openstackgerritjian.song proposed openstack/trove: Concentrated test_validate_xx_configuration to a new method  https://review.openstack.org/36925218:47
amrithsorry songjian ... just -1'ed that with a suggested change.18:51
amrithsorry for making you do this many times.18:51
*** imandhan has quit IRC18:53
openstackgerritjian.song proposed openstack/trove: Concentrated test_validate_xx_configuration to a new method  https://review.openstack.org/36925218:54
amrithjohnma, will look for the is_warning() fix and try it out19:01
*** songjian has quit IRC19:01
*** imandhan has joined #openstack-trove19:02
*** pcaruana has joined #openstack-trove19:07
*** johnbabers has quit IRC19:10
*** johnbabers has joined #openstack-trove19:15
openstackgerritMerged openstack/trove: Insulate TroveContext from oslo.context changes  https://review.openstack.org/36760719:17
openstackgerritMerged openstack/trove: Separate database and user create in prepare  https://review.openstack.org/36818419:19
*** imandhan has quit IRC19:24
*** imandhan has joined #openstack-trove19:29
openstackgerritmariam john proposed openstack/trove: Handle the exceptions and errors correctly for DB2  https://review.openstack.org/37039719:33
amrithjohnma, ping ...19:34
johnmayes amrith19:34
amrithjust looking at your code, have a question for you.19:34
johnmayes19:35
amrithsorry, looked at it again19:36
amrithlooks good19:36
amriththanks19:36
amrithwas wondering whether you should do something wiht out and err19:36
amrithbut it looks like in other places we don't19:36
amrithso it looks good19:36
amrithwill wait for the tests to finish and +219:36
johnmaright. there isn't any more processing to be done with those. so it didn't make sense to19:37
johnmathanks amrith19:37
johnmaiamrith, peterstac: is there anything else I can help with. I need to step out for a bit but will be back soon.19:38
amrithno worries johnma19:38
amrithI think we're good for now19:38
johnmaawesome19:39
*** _imandhan_ has joined #openstack-trove19:39
*** imandhan has quit IRC19:42
*** johnbabers has quit IRC19:45
*** hoonetorg has quit IRC19:53
*** can8dnSix has joined #openstack-trove19:55
*** johnbabers has joined #openstack-trove19:56
*** pcaruana has quit IRC20:00
*** gouthamr has quit IRC20:07
*** Ravikiran_K has quit IRC20:07
*** hoonetorg has joined #openstack-trove20:08
*** can8dnSix has quit IRC20:08
*** can8dnSix has joined #openstack-trove20:13
openstackgerritMerged openstack/trove: Stop adding ServiceAvailable group option  https://review.openstack.org/36696320:32
openstackgerritMerged openstack/trove: Deprecate 'guest_log_long_query_time'  https://review.openstack.org/31123720:33
*** rcernin has quit IRC20:36
*** miqui has joined #openstack-trove20:39
*** rcernin has joined #openstack-trove20:40
*** rcernin has quit IRC20:41
*** rcernin has joined #openstack-trove20:41
*** rcernin has quit IRC20:42
*** rcernin has joined #openstack-trove20:42
*** gouthamr has joined #openstack-trove20:44
openstackgerritMerged openstack/trove: Call GuestError with proper options  https://review.openstack.org/36379620:51
openstackgerritPeter Stachowski proposed openstack/trove-integration: Enhance 'redstack clean' regarding modules  https://review.openstack.org/36453920:55
*** _imandhan_ has quit IRC20:58
*** can8dnSix has quit IRC20:59
*** arist has quit IRC20:59
*** arist has joined #openstack-trove21:00
*** imandhan has joined #openstack-trove21:15
openstackgerritPeter Stachowski proposed openstack/trove-integration: Enhance 'redstack clean' regarding modules  https://review.openstack.org/36453921:15
openstackgerritamrith proposed openstack/trove: Handle the exceptions and errors correctly for DB2  https://review.openstack.org/37039721:19
*** johnbabers has quit IRC21:32
*** pmackinn has quit IRC21:43
*** miqui has quit IRC22:05
openstackgerritMerged openstack/trove: initial chkin of pylint  https://review.openstack.org/36764022:09
*** trevormc has quit IRC22:26
*** rcernin has quit IRC22:43
*** imandhan has quit IRC22:50
*** imandhan has joined #openstack-trove22:51
*** imandhan has quit IRC22:52
*** imandhan has joined #openstack-trove22:52
*** hongbin has quit IRC23:20
amrithjohnma, peterstac what's the verdict?23:52
amrithgot with what we have?23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!