| amrith | peterstac, yt? | 00:05 |
|---|---|---|
| *** johnbabers has quit IRC | 00:29 | |
| *** acaraion has quit IRC | 00:29 | |
| *** cheneydc has joined #openstack-trove | 00:55 | |
| *** cheneydc has quit IRC | 00:57 | |
| *** gouthamr_ has quit IRC | 01:05 | |
| *** imandhan has joined #openstack-trove | 01:10 | |
| *** gouthamr has joined #openstack-trove | 01:42 | |
| *** imandhan has quit IRC | 01:48 | |
| *** imandhan has joined #openstack-trove | 01:49 | |
| *** imandhan has quit IRC | 01:53 | |
| *** dkehn has quit IRC | 01:56 | |
| *** dkehn has joined #openstack-trove | 02:07 | |
| openstackgerrit | jian.song proposed openstack/trove: Fix pylint Error:PGSQL_RECOVERY_CONFIG https://review.openstack.org/372211 | 03:19 |
| *** gouthamr has quit IRC | 03:52 | |
| *** himani has joined #openstack-trove | 04:09 | |
| openstackgerrit | jian.song proposed openstack/trove: Fix error:_find_users https://review.openstack.org/372218 | 04:10 |
| openstackgerrit | jian.song proposed openstack/trove: Fix error:_find_users https://review.openstack.org/372218 | 04:13 |
| *** pcaruana has quit IRC | 05:05 | |
| *** rcernin has joined #openstack-trove | 06:03 | |
| openstackgerrit | jian.song proposed openstack/trove: Fix pylint Error:PGSQL_RECOVERY_CONFIG https://review.openstack.org/372211 | 06:07 |
| openstackgerrit | jian.song proposed openstack/trove: Fix error:_find_users https://review.openstack.org/372218 | 06:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/372242 | 06:15 |
| *** pcaruana has joined #openstack-trove | 06:17 | |
| openstackgerrit | jian.song proposed openstack/trove: Fix error:_find_users https://review.openstack.org/372218 | 06:35 |
| *** songjian has joined #openstack-trove | 06:44 | |
| *** Ravikiran_K has joined #openstack-trove | 06:51 | |
| *** drifterza has joined #openstack-trove | 07:15 | |
| *** songjian has quit IRC | 07:20 | |
| *** drifterza has quit IRC | 07:40 | |
| *** drifterza has joined #openstack-trove | 07:40 | |
| *** amitkqed has quit IRC | 07:53 | |
| *** amitkqed has joined #openstack-trove | 07:54 | |
| *** Ravikiran_K has quit IRC | 08:30 | |
| *** Ravikiran_K has joined #openstack-trove | 08:32 | |
| *** tosky has joined #openstack-trove | 09:09 | |
| *** songjian has joined #openstack-trove | 09:17 | |
| *** tosky has quit IRC | 09:34 | |
| *** songjian has quit IRC | 09:35 | |
| *** songjian has joined #openstack-trove | 09:35 | |
| *** tosky has joined #openstack-trove | 09:41 | |
| *** Ravikiran_K has quit IRC | 09:51 | |
| *** hoonetorg has quit IRC | 09:56 | |
| *** hoonetorg has joined #openstack-trove | 09:57 | |
| *** Ravikiran_K has joined #openstack-trove | 10:08 | |
| *** openstackstatus has quit IRC | 10:28 | |
| *** mpotdar has quit IRC | 11:04 | |
| *** lte4all has joined #openstack-trove | 11:07 | |
| *** mpotdar has joined #openstack-trove | 11:10 | |
| *** Ravikiran_K has quit IRC | 11:11 | |
| *** hoonetorg has quit IRC | 11:23 | |
| *** lte4all has quit IRC | 11:24 | |
| *** lte4all has joined #openstack-trove | 11:25 | |
| *** hoonetorg has joined #openstack-trove | 11:56 | |
| *** hoonetorg has quit IRC | 11:57 | |
| *** hoonetorg has joined #openstack-trove | 11:58 | |
| openstackgerrit | Merged openstack/trove-dashboard: Imported Translations from Zanata https://review.openstack.org/372242 | 11:59 |
| *** songjian has quit IRC | 12:01 | |
| *** songjian has joined #openstack-trove | 12:02 | |
| *** porunov has joined #openstack-trove | 12:03 | |
| *** porunov has left #openstack-trove | 12:05 | |
| *** pmackinn has joined #openstack-trove | 12:16 | |
| openstackgerrit | amrith proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 12:30 |
| *** Ravikiran_K has joined #openstack-trove | 12:36 | |
| *** david-lyle has joined #openstack-trove | 12:38 | |
| *** david-lyle has quit IRC | 12:43 | |
| *** songjian has quit IRC | 12:59 | |
| *** songjian has joined #openstack-trove | 13:00 | |
| *** songjian has quit IRC | 13:02 | |
| *** gouthamr has joined #openstack-trove | 13:09 | |
| *** drifterza has quit IRC | 13:33 | |
| *** hongbin has joined #openstack-trove | 13:38 | |
| peterstac | amrith, hi | 14:02 |
| amrith | yo | 14:34 |
| amrith | see ^^ | 14:34 |
| amrith | is that what you were talking about? | 14:34 |
| *** openstackgerrit has quit IRC | 14:37 | |
| *** openstackgerrit has joined #openstack-trove | 14:37 | |
| *** david-lyle has joined #openstack-trove | 14:40 | |
| *** david-lyle has quit IRC | 14:45 | |
| *** trevormc has joined #openstack-trove | 14:50 | |
| openstackgerrit | amrith proposed openstack/trove: Fix pylint Error:PGSQL_RECOVERY_CONFIG https://review.openstack.org/372211 | 15:00 |
| *** pcaruana has quit IRC | 15:07 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Merge Postgresql service modules https://review.openstack.org/346082 | 15:10 |
| *** lte4all has quit IRC | 15:16 | |
| *** johnma has joined #openstack-trove | 15:20 | |
| *** rcernin has quit IRC | 15:30 | |
| *** david-lyle has joined #openstack-trove | 15:32 | |
| openstackgerrit | amrith proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 16:16 |
| amrith | peterstac, johnma please see ^^ | 16:18 |
| amrith | I think this addresses the things we have been seeing so far | 16:18 |
| peterstac | amrith, testing it now ... | 16:18 |
| amrith | thx peterstac | 16:19 |
| amrith | I only sorted the config file | 16:19 |
| amrith | it will still generate the same errors we currently know of | 16:19 |
| amrith | but some errors that have been fixed have been eliminated | 16:19 |
| amrith | should we flag that as an error too? | 16:19 |
| amrith | I am concerned that trove-pylint.config will become a hot spot for merge conflicts | 16:21 |
| peterstac | Well, once it gets cleaned up properly, it shouldn't change much right? I mean there might be new 'false positives' but the old ones will still need to remain | 16:25 |
| peterstac | So if it's easy to check for errors that have been fixed, maybe it might make sense | 16:26 |
| peterstac | but if it's a lot of work, might not be worth it ... | 16:26 |
| *** markstur_ is now known as markstur | 16:44 | |
| *** rcernin has joined #openstack-trove | 16:51 | |
| amrith | peterstac, yes | 16:52 |
| amrith | it shouldn't change much | 16:52 |
| amrith | at some point, I hope we'll beging to get rid of any existing errors (not false positives) taht are currently being ignored. | 16:52 |
| amrith | it is possible to check for errors that don't exist any longer, I'll see about pushing a change for that | 16:53 |
| amrith | i entered https://bugs.launchpad.net/trove/+bug/1625171 to track that | 16:53 |
| openstack | Launchpad bug 1625171 in OpenStack DBaaS (Trove) "improve pylint and detect when errors (ignored) have been fixed and no longer occur" [Undecided,New] - Assigned to Amrith (amrith) | 16:53 |
| amrith | dloi, peterstac, johnma please review https://review.openstack.org/#/c/370975/ | 16:59 |
| *** imandhan has joined #openstack-trove | 17:05 | |
| *** imandhan has quit IRC | 17:09 | |
| openstackgerrit | Merged openstack/trove: Fix call to to_mb https://review.openstack.org/372152 | 17:14 |
| *** harlowja has joined #openstack-trove | 17:30 | |
| *** tqtran has joined #openstack-trove | 17:36 | |
| *** tosky has quit IRC | 18:07 | |
| openstackgerrit | Akihiro Motoki proposed openstack/trove-dashboard: Remove double closing <strong> tag in a template https://review.openstack.org/372683 | 18:25 |
| *** drifterza has joined #openstack-trove | 18:27 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Merge Postgresql service modules https://review.openstack.org/346082 | 18:31 |
| *** drifterza has quit IRC | 18:45 | |
| *** drifterza has joined #openstack-trove | 18:46 | |
| *** trevormc has quit IRC | 18:54 | |
| openstackgerrit | Merged openstack/trove: Fix pylint Error:PGSQL_RECOVERY_CONFIG https://review.openstack.org/372211 | 19:00 |
| *** trevormc has joined #openstack-trove | 19:01 | |
| *** imandhan has joined #openstack-trove | 19:01 | |
| amrith | peterstac, SlickNik, johnma, cp16net ... backport to newton for this change from master. https://review.openstack.org/#/c/372706/ | 19:04 |
| *** miqui has joined #openstack-trove | 19:06 | |
| peterstac | amrith, this also should go, right? - https://review.openstack.org/#/c/372707/ | 19:07 |
| amrith | yup, done | 19:12 |
| openstackgerrit | amrith proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 19:14 |
| amrith | peterstac, does this ^^ address your comments? | 19:14 |
| peterstac | yes | 19:15 |
| *** drifterza has quit IRC | 19:15 | |
| peterstac | The only other thing I've found is the file number changes | 19:15 |
| peterstac | is that required in the config file? | 19:15 |
| peterstac | (the tests seem to run fine if they're wrong, so I'm not sure) | 19:15 |
| peterstac | for example, if I add a comment at the beginning of trove/backup/models.py | 19:16 |
| peterstac | all the entries have the line number changed | 19:16 |
| peterstac | (if I run rebuild) | 19:17 |
| peterstac | but it still works if they're not correct | 19:17 |
| amrith | the file numbers aren't checked | 19:18 |
| peterstac | so I was wondering if we could just leave that out of the file entirely ... | 19:18 |
| amrith | I have them there for some silly reason | 19:18 |
| amrith | oh, yes ... | 19:18 |
| amrith | if I want to track where a particular issue is, and detect when an issue is addressed | 19:19 |
| amrith | otherwise, I'd need a refcount | 19:19 |
| amrith | I figured a line number was easy enough | 19:19 |
| amrith | but ... all the line numbers changing is annoying | 19:19 |
| amrith | I can omit it | 19:19 |
| amrith | want me to do that? | 19:19 |
| amrith | see ignore() around lines149 | 19:20 |
| amrith | line 149 | 19:21 |
| amrith | it stores the error (ignored message) two ways | 19:21 |
| amrith | one is by error number | 19:21 |
| amrith | other is error name | 19:21 |
| amrith | this was all so people could add things manually if they wanted :) | 19:21 |
| amrith | but we seem to be going away from that. | 19:21 |
| amrith | how about making the line number removal independent? | 19:22 |
| peterstac | sure | 19:23 |
| peterstac | (one more thing though - some doc lines should be changed wrt rebuild) | 19:23 |
| peterstac | (sorry I didn't catch it before) | 19:23 |
| peterstac | looking at that code now, but I think it's identical ... | 19:25 |
| peterstac | fcm_ignore1 and fcm_ignore2 and the compare ... (block 147-154) | 19:27 |
| *** lte4all has joined #openstack-trove | 19:39 | |
| *** gouthamr has quit IRC | 19:41 | |
| *** lte4all has quit IRC | 19:41 | |
| openstackgerrit | amrith proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 19:49 |
| *** trevormc has quit IRC | 19:50 | |
| amrith | fixed the doc line | 19:50 |
| amrith | don't need the -- | 19:50 |
| amrith | that's a mistake | 19:51 |
| amrith | copy-pasta | 19:51 |
| amrith | peter, please check now | 19:56 |
| openstackgerrit | amrith proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 19:56 |
| amrith | the fcm code in ignore() should now do what you were pointint to | 19:56 |
| *** trevormc has joined #openstack-trove | 19:56 | |
| openstackgerrit | tamil vanan proposed openstack/trove-dashboard: Removing Duplicate </strong> tag https://review.openstack.org/372751 | 20:34 |
| openstackgerrit | tamil vanan proposed openstack/trove-dashboard: Removing Duplicate </strong> tag https://review.openstack.org/372751 | 20:36 |
| *** imandhan has quit IRC | 20:36 | |
| *** imandhan has joined #openstack-trove | 20:37 | |
| *** imandhan has quit IRC | 20:41 | |
| openstackgerrit | Peter Stachowski proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 20:52 |
| openstackgerrit | Peter Stachowski proposed openstack/trove: improve pylint; generate errors and config in sorted order https://review.openstack.org/372448 | 21:04 |
| peterstac | amrith, I decided to remove the line nums and regen the config file (since I think the remaining two issues are false positives) ^^^ | 21:05 |
| *** arist has quit IRC | 21:05 | |
| peterstac | (tweaked a bit of the README file too, as per the other changes) | 21:05 |
| peterstac | let me know if you're ok with that | 21:05 |
| peterstac | otherwise I think we're looking pretty good | 21:05 |
| *** arist has joined #openstack-trove | 21:06 | |
| peterstac | (the pylint test should now pass the check queue) | 21:06 |
| *** miqui has quit IRC | 21:39 | |
| *** harlowja has quit IRC | 21:51 | |
| *** pmackinn has quit IRC | 21:51 | |
| *** georgelorch has quit IRC | 21:51 | |
| *** georgelorch has joined #openstack-trove | 21:51 | |
| *** pmackinn has joined #openstack-trove | 21:51 | |
| *** harlowja has joined #openstack-trove | 21:56 | |
| *** rcernin has quit IRC | 22:27 | |
| *** himani has quit IRC | 22:41 | |
| *** trevormc has quit IRC | 22:45 | |
| openstackgerrit | Merged openstack/trove-dashboard: Update release notes https://review.openstack.org/372164 | 22:57 |
| *** hongbin has quit IRC | 23:05 | |
| openstackgerrit | Petr Malik proposed openstack/trove: Merge Postgresql service modules https://review.openstack.org/346082 | 23:23 |
| *** openstackgerrit has quit IRC | 23:42 | |
| *** openstackgerrit has joined #openstack-trove | 23:46 | |
| *** openstackgerrit has quit IRC | 23:51 | |
| *** hogepodge has quit IRC | 23:53 | |
| *** esmute has joined #openstack-trove | 23:54 | |
| *** openstackgerrit has joined #openstack-trove | 23:54 | |
| *** esmute has quit IRC | 23:55 | |
| *** hogepodge has joined #openstack-trove | 23:56 | |
| *** johnbabers has joined #openstack-trove | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!