dougshelley66 | ah well that isn't good | 00:02 |
---|---|---|
dougshelley66 | in fact that is your problem | 00:02 |
*** hongbin has quit IRC | 00:02 | |
dougshelley66 | that means that the version of oslo.context on your guest is different from on your control plane | 00:02 |
dougshelley66 | i think we fixed that kind of problem during newton | 00:03 |
*** james_li has joined #openstack-trove | 01:32 | |
*** james_li has quit IRC | 01:32 | |
*** james_li has joined #openstack-trove | 01:48 | |
*** james_li has quit IRC | 01:48 | |
*** tqtran has quit IRC | 02:18 | |
dougshelley66 | i'm running trove module-list and i see this http://pastebin.com/T5UVZGR8 | 02:20 |
dougshelley66 | peterstac ^^^ | 02:20 |
openstackgerrit | zhangyanxian proposed openstack/trove: Fix import method to follow community guideline https://review.openstack.org/405739 | 02:26 |
openstackgerrit | zhangyanxian proposed openstack/trove: Fix import method to follow community guideline https://review.openstack.org/405739 | 02:27 |
openstackgerrit | zhangyanxian proposed openstack/trove: Fix import method to follow community guideline https://review.openstack.org/405739 | 02:29 |
openstackgerrit | Merged openstack/trove: Show team and repo badges on README https://review.openstack.org/402547 | 02:40 |
*** links has joined #openstack-trove | 03:52 | |
*** chhavi has joined #openstack-trove | 05:01 | |
*** gouthamr has joined #openstack-trove | 05:43 | |
*** gouthamr has quit IRC | 06:05 | |
*** gouthamr has joined #openstack-trove | 06:23 | |
*** openstackgerrit has quit IRC | 06:33 | |
*** rcernin has joined #openstack-trove | 07:40 | |
*** chhavi has quit IRC | 08:46 | |
*** chhavi has joined #openstack-trove | 08:48 | |
*** zhugaoxiao has joined #openstack-trove | 09:16 | |
*** Madkiss has quit IRC | 09:35 | |
*** Madkiss has joined #openstack-trove | 09:35 | |
*** Madkiss has quit IRC | 09:35 | |
*** Madkiss has joined #openstack-trove | 09:35 | |
*** chhavi has quit IRC | 09:41 | |
*** rcernin has quit IRC | 09:49 | |
*** rcernin has joined #openstack-trove | 09:50 | |
*** dalees has joined #openstack-trove | 09:51 | |
*** zhugaoxiao has quit IRC | 09:54 | |
*** chhavi has joined #openstack-trove | 10:17 | |
*** tesseract has joined #openstack-trove | 10:27 | |
*** tesseract is now known as Guest79986 | 10:27 | |
*** johnma has quit IRC | 10:32 | |
*** johnma has joined #openstack-trove | 10:34 | |
*** tosky has joined #openstack-trove | 11:08 | |
*** gcb has quit IRC | 11:41 | |
*** chhavi has quit IRC | 11:42 | |
*** chhavi has joined #openstack-trove | 11:46 | |
*** gcb has joined #openstack-trove | 12:01 | |
*** rcernin has quit IRC | 12:12 | |
*** rcernin has joined #openstack-trove | 12:15 | |
*** gcb has quit IRC | 12:58 | |
*** chhavi has quit IRC | 13:02 | |
*** rcernin has quit IRC | 13:06 | |
*** rcernin has joined #openstack-trove | 13:08 | |
*** links has quit IRC | 13:17 | |
*** chhavi has joined #openstack-trove | 13:21 | |
*** johnbabers has joined #openstack-trove | 13:24 | |
*** johnbabers has quit IRC | 13:30 | |
*** johnbabers has joined #openstack-trove | 13:51 | |
*** trevormc has joined #openstack-trove | 13:55 | |
*** johnbabe_ has joined #openstack-trove | 14:02 | |
*** johnbabers has quit IRC | 14:06 | |
*** johnbabe_ has quit IRC | 14:11 | |
*** gcb has joined #openstack-trove | 14:18 | |
*** rcernin has quit IRC | 14:33 | |
*** rcernin has joined #openstack-trove | 14:41 | |
*** johnbabers has joined #openstack-trove | 14:48 | |
*** gouthamr_ has joined #openstack-trove | 14:48 | |
*** gouthamr has quit IRC | 14:49 | |
*** openstackgerrit has joined #openstack-trove | 14:54 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Fix i18n translation in common 1/5 https://review.openstack.org/406158 | 14:54 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to common 2/5 https://review.openstack.org/406159 | 14:55 |
*** rcernin has quit IRC | 14:55 | |
stevemar | amrith: thanks for your trove<->OSC spec and keeping to the OSC principles | 14:56 |
amrith | stevemar, thx | 14:57 |
stevemar | amrith: i see *you* get what we're trying to do :) | 14:57 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n tranlastion to common 3/5 https://review.openstack.org/406161 | 14:57 |
amrith | was telling trevormc yesterday that I'd like to see an openstack command in ocata | 14:57 |
stevemar | totally | 14:57 |
amrith | with a confined and consistent implementation | 14:57 |
amrith | that we can extend on later | 14:57 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n tranlation to common 4/5 https://review.openstack.org/406162 | 14:57 |
stevemar | yes, big thanks to trevormc for creating a spec and cc'ing us on it | 14:57 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation common 5/5 https://review.openstack.org/406164 | 14:57 |
amrith | we've been failing at this (I think) in past releases because we were attempting to boil the ocean and tie it with the project to redo the front end api. | 14:58 |
stevemar | i wish some of the other projects had done that so we don't have some of the fracturing we have today | 14:58 |
amrith | oh? | 14:58 |
*** rcernin has joined #openstack-trove | 14:58 | |
amrith | but the prime rule in openstack is be consistent. So shouldn't we do that (like other projects) for consistency? | 14:58 |
amrith | <stevemar curses into his keyboard> | 14:59 |
* trevormc is lurking | 14:59 | |
stevemar | amrith: some of the early adopters don't quite match up, but that is partly our fault for not having good enough guidelines | 14:59 |
stevemar | amrith: like congress prefixed all their commands with congress *smh* | 14:59 |
amrith | but ... we should follow those (bad) examples, no? | 14:59 |
amrith | for consistency | 14:59 |
* stevemar throws a fish at amrith | 14:59 | |
* amrith is vegetarian, sells fish for a profit | 14:59 | |
amrith | thx stevemar how's the baby; please say hi to the boss. | 15:00 |
stevemar | lol | 15:01 |
stevemar | he's good, napping right now | 15:01 |
amrith | cool. trevormc thx for doing the osc thing ... | 15:06 |
trevormc | amrith, np I enjoy doing it | 15:06 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation common 5/5 https://review.openstack.org/406164 | 15:07 |
openstackgerrit | amrith proposed openstack/trove: allow unauthenticated packages to be installed https://review.openstack.org/406170 | 15:12 |
trevormc | amrith about your comment on "showing how positional arguments map between commands" or something like that.... is this what you meant? | 15:14 |
trevormc | trove backup-create <instance> <name> openstack database backup create <instance> <name> | 15:14 |
amrith | trevormc, yes. that's basically it. I think it would be a bit much to ask for BNF :) | 15:16 |
amrith | however, instance could be instance or name, yes? | 15:16 |
trevormc | yes | 15:16 |
trevormc | instance name or ID | 15:17 |
trevormc | ``<instance>`` ID or name of the instance. ``<name>`` Name of the backup. | 15:17 |
*** chhavi has quit IRC | 15:17 | |
trevormc | im using http://git.openstack.org/cgit/openstack/openstack-manuals/tree/doc/cli-reference/source/trove.rst#n508 as reference | 15:17 |
trevormc | #n473 for create | 15:17 |
*** chhavi has joined #openstack-trove | 15:17 | |
*** openstackgerrit has quit IRC | 15:33 | |
*** hongbin has joined #openstack-trove | 15:39 | |
*** chhavi has quit IRC | 15:41 | |
*** miqui has joined #openstack-trove | 15:43 | |
*** johnbabers has quit IRC | 15:46 | |
*** chlong has joined #openstack-trove | 15:47 | |
*** johnbabers has joined #openstack-trove | 15:48 | |
*** Guest79986 has quit IRC | 15:54 | |
*** rcernin has quit IRC | 16:05 | |
*** khushbu has joined #openstack-trove | 16:07 | |
*** khushbu has quit IRC | 16:13 | |
*** david-lyle_ has joined #openstack-trove | 16:17 | |
*** david-lyle has quit IRC | 16:19 | |
*** khushbu_ has joined #openstack-trove | 16:20 | |
*** chlong has quit IRC | 16:20 | |
*** chlong has joined #openstack-trove | 16:20 | |
*** gcb has quit IRC | 16:20 | |
*** gouthamr_ has quit IRC | 16:37 | |
*** gouthamr has joined #openstack-trove | 16:37 | |
*** tqtran has joined #openstack-trove | 16:38 | |
*** gouthamr has quit IRC | 16:41 | |
*** gouthamr has joined #openstack-trove | 16:41 | |
*** rcernin has joined #openstack-trove | 16:45 | |
*** openstackgerrit has joined #openstack-trove | 16:46 | |
openstackgerrit | Trevor McCasland proposed openstack/trove-specs: Spec for openstack client support https://review.openstack.org/391871 | 16:46 |
*** tqtran_ has joined #openstack-trove | 16:50 | |
*** tqtran has quit IRC | 16:53 | |
*** johnbabers has quit IRC | 16:54 | |
*** chhavi has joined #openstack-trove | 16:57 | |
*** chlong has quit IRC | 17:02 | |
*** johnbabers has joined #openstack-trove | 17:13 | |
*** johnbabers has quit IRC | 17:17 | |
*** chhavi has quit IRC | 17:22 | |
*** johnbabers has joined #openstack-trove | 17:33 | |
*** james_li has joined #openstack-trove | 17:38 | |
*** chlong has joined #openstack-trove | 17:41 | |
*** gouthamr has quit IRC | 17:44 | |
*** gouthamr has joined #openstack-trove | 17:44 | |
*** rcernin has quit IRC | 17:45 | |
*** rcernin has joined #openstack-trove | 17:46 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation in extenstions 1/6 https://review.openstack.org/406267 | 17:48 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to extenstions 2/6 https://review.openstack.org/406268 | 17:49 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to extensions 3/6 https://review.openstack.org/406269 | 17:50 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to extensions 4/6 https://review.openstack.org/406270 | 17:50 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to extensions 5/6 https://review.openstack.org/406271 | 17:51 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation checks to extenstions 6/6 https://review.openstack.org/406272 | 17:51 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to extenstions 2/6 https://review.openstack.org/406268 | 17:53 |
*** johnbabers has quit IRC | 17:54 | |
*** johnbabers has joined #openstack-trove | 17:57 | |
*** tosky has quit IRC | 17:59 | |
*** khushbu_ has quit IRC | 18:07 | |
*** david-lyle_ is now known as david-lyle | 18:08 | |
*** johnbabers has quit IRC | 18:15 | |
*** gouthamr_ has joined #openstack-trove | 18:16 | |
*** gouthamr has quit IRC | 18:17 | |
*** johnbabers has joined #openstack-trove | 18:18 | |
*** johnbabers has quit IRC | 18:21 | |
*** johnbabers has joined #openstack-trove | 18:25 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 1/6 https://review.openstack.org/406280 | 18:28 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 2/6 https://review.openstack.org/406281 | 18:29 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n tranlastion to guestagent datastore 3/6 https://review.openstack.org/406283 | 18:30 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 4/6 https://review.openstack.org/406284 | 18:30 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 5/6 https://review.openstack.org/406286 | 18:30 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 6/6 https://review.openstack.org/406287 | 18:31 |
*** johnbabers has quit IRC | 18:35 | |
*** james_li has quit IRC | 18:36 | |
*** johnbabers has joined #openstack-trove | 18:39 | |
*** johnbabe_ has joined #openstack-trove | 18:41 | |
*** johnbabers has quit IRC | 18:44 | |
*** robertmyers has quit IRC | 19:19 | |
*** robertmyers has joined #openstack-trove | 19:19 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 2/6 https://review.openstack.org/406315 | 19:23 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 1/6 https://review.openstack.org/406316 | 19:24 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 3/6 https://review.openstack.org/406317 | 19:24 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 4/6 https://review.openstack.org/406318 | 19:25 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 5/6 https://review.openstack.org/406319 | 19:25 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent 6/6 https://review.openstack.org/406320 | 19:25 |
*** serverascode has quit IRC | 19:34 | |
*** ctracey has quit IRC | 19:34 | |
*** zhiyan has quit IRC | 19:34 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: add i18n translation to others 1/3 https://review.openstack.org/406325 | 19:42 |
*** gouthamr_ has quit IRC | 19:42 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to others 2/3 https://review.openstack.org/406326 | 19:43 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to others 3/3 https://review.openstack.org/406327 | 19:43 |
*** gouthamr has joined #openstack-trove | 19:44 | |
*** ctracey has joined #openstack-trove | 19:47 | |
*** serverascode has joined #openstack-trove | 19:50 | |
*** zhiyan has joined #openstack-trove | 19:52 | |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add translation_checks for i18n https://review.openstack.org/402780 | 19:54 |
openstackgerrit | Doug Shelley proposed openstack/trove: DNM: canary https://review.openstack.org/405055 | 19:55 |
*** james_li has joined #openstack-trove | 20:19 | |
*** johnma has quit IRC | 20:35 | |
*** chlong has quit IRC | 20:42 | |
*** johnma has joined #openstack-trove | 20:47 | |
*** james_li has quit IRC | 20:54 | |
*** james_li has joined #openstack-trove | 20:54 | |
*** chlong has joined #openstack-trove | 20:55 | |
*** johnbabe_ has quit IRC | 20:57 | |
amrith | trevormc, yt? | 21:04 |
trevormc | hi amrith | 21:05 |
amrith | hi | 21:05 |
amrith | I've been looking at some of your patches above | 21:05 |
amrith | one concern I have is with the change(s) like this one: https://review.openstack.org/#/c/406158/1/trove/common/cfg.py | 21:05 |
amrith | there's nothing that requires one to change _ to _L? | 21:05 |
amrith | it may reduce the merge load for others if you don't make this change | 21:05 |
amrith | rather it *will* reduce the merge load for others if you don't make this change | 21:06 |
amrith | This change makes sense (for example) | 21:06 |
amrith | but this one, not so much: https://review.openstack.org/#/c/406158/1/trove/common/debug_utils.py | 21:06 |
amrith | also, a heads-up for you, this change will land you in conflict with someone else (don't recall his name, from intel) who's fixing the thing about not rendering strings. https://review.openstack.org/#/c/406158/1/trove/common/cfg.py | 21:08 |
trevormc | ok I think what you are referring to are called translation hints | 21:09 |
amrith | specifically I was looking at http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function in making my comment. | 21:11 |
trevormc | "there's nothing that requires one to change _ to _L?" yes there is | 21:13 |
*** gouthamr has quit IRC | 21:14 | |
trevormc | I did look out for the message being used in both an exception and a log, in that case we are supposed to use _ only | 21:14 |
trevormc | although I do remember a lot of " %s/warning(_(/(_LW(/g "being done on my part so there could be some slip ups. | 21:15 |
trevormc | %s/warning(_(/warning(_LW(/g | 21:15 |
openstackgerrit | Peter Stachowski proposed openstack/trove: (fix troveclient gate) Use alt-demo network https://review.openstack.org/405671 | 21:22 |
openstackgerrit | Peter Stachowski proposed openstack/trove: (fix troveclient gate) Use alt-demo network https://review.openstack.org/405671 | 21:34 |
trevormc | All the translation checks have been broken up into their smaller patches and the depends on tag for each one was put on the commit that introduces the hacking rules: https://review.openstack.org/402780. This should make it easier to identify errors and make it easier to reivew :) so if anyone is looking for some quick reviews (i hope) you can click here https://review.openstack.org/#/q/Add+i18n+translation+to and get start | 21:34 |
amrith | "there's nothing that requires one to change _ to _L?" yes there is --- what's that. | 21:34 |
trevormc | validate_log_translations() does it | 21:35 |
trevormc | in this file https://review.openstack.org/#/c/402780/3/trove/hacking/translation_checks.py | 21:35 |
trevormc | L17-40 show the regex for it too | 21:36 |
amrith | yes, I see the code; I'm saying that nothing in the developer guidelines requires you to use _LW, _LI, _LE ... you can always use _. | 21:37 |
amrith | There are restrictions on where you can use _LW, LE ... No restrictions on where you can use _ | 21:38 |
amrith | so _ is safe everywhere and I suggest we stay with that. | 21:38 |
amrith | now, your hacking rule seems to want you to do _LW, _LE, ... | 21:38 |
amrith | I submit to you that your hacking rule is the culprit | 21:38 |
amrith | fix your hacking rule to look for _ and all is good; personally, I'd be happy if we removed the use of _LW, _LI, _LE :) | 21:39 |
openstackgerrit | Trevor McCasland proposed openstack/trove: Add i18n translation to guestagent datastore 6/6 https://review.openstack.org/406287 | 21:39 |
*** nexusz99 has quit IRC | 21:39 | |
*** nexusz99 has joined #openstack-trove | 21:40 | |
*** nexusz99 has quit IRC | 21:40 | |
trevormc | amrith: That makes sense.. I knew I should've asked that question! I tried bringing it up in the meeting last week but I guess I didn't explain the rules well enough. Oh well I'll update the commits when I get home if not then Monday. | 21:53 |
amrith | sorry trevormc I should have said something sooner :) | 21:53 |
trevormc | thanks for your help and input so far. have a good weekend :) | 21:54 |
*** trevormc has quit IRC | 21:56 | |
openstackgerrit | amrith proposed openstack/trove-specs: Spec for new feature, secure-oslo-messaging.rpc messages https://review.openstack.org/391637 | 21:58 |
amrith | have a good weekend trevor! | 21:59 |
openstackgerrit | Peter Stachowski proposed openstack/trove: (fix troveclient gate) Use alt-demo network https://review.openstack.org/405671 | 22:26 |
*** robertmyers has quit IRC | 22:28 | |
*** chlong has quit IRC | 22:44 | |
*** johnbabers has joined #openstack-trove | 22:58 | |
*** johnbabers has quit IRC | 23:03 | |
openstackgerrit | Doug Shelley proposed openstack/trove: DNM: canary https://review.openstack.org/405055 | 23:10 |
openstackgerrit | Petr Malik proposed openstack/python-troveclient: [WIP] Enable access operations on clusters https://review.openstack.org/406394 | 23:13 |
openstackgerrit | Petr Malik proposed openstack/trove: [WIP] Datastore-specific API controllers https://review.openstack.org/406395 | 23:14 |
*** hongbin has quit IRC | 23:26 | |
*** james_li has quit IRC | 23:33 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!