| *** itlinux has quit IRC | 00:02 | |
| *** kylek3h has joined #openstack-trove | 00:15 | |
| *** kylek3h has quit IRC | 00:16 | |
| *** dixiaoli has joined #openstack-trove | 00:51 | |
| *** kylek3h has joined #openstack-trove | 00:52 | |
| *** kylek3h has quit IRC | 00:53 | |
| *** itlinux has joined #openstack-trove | 00:53 | |
| *** itlinux has quit IRC | 00:58 | |
| *** harlowja has quit IRC | 01:19 | |
| *** cdelatte has quit IRC | 01:27 | |
| *** kylek3h has joined #openstack-trove | 01:29 | |
| *** kylek3h has quit IRC | 01:29 | |
| *** zhaochao has joined #openstack-trove | 02:04 | |
| *** kylek3h has joined #openstack-trove | 02:23 | |
| *** kylek3h_ has joined #openstack-trove | 02:30 | |
| *** kylek3h has quit IRC | 02:33 | |
| *** kylek3h_ has quit IRC | 02:45 | |
| *** dixiaoli has quit IRC | 03:09 | |
| openstackgerrit | Fan Zhang proposed openstack/trove master: Fix missing package and remove inexistent option. Close-bug:#1706528 https://review.openstack.org/487675 | 03:11 |
|---|---|---|
| fanzhang | amrith, hi, are you there? I just commited a patch about bug https://bugs.launchpad.net/trove/+bug/1706528 . We discussed earlier about the inaccurate doc description with trevormc. Would you please help me review my patch https://review.openstack.org/487675 ? | 03:16 |
| openstack | Launchpad bug 1706528 in OpenStack DBaaS (Trove) "Missing ops in Install and configure for Red Hat Enterprise Linux and CentOS in Installation Guide" [Undecided,New] - Assigned to Fan Zhang (fanzhang) | 03:16 |
| *** harlowja has joined #openstack-trove | 03:31 | |
| *** hoonetorg has joined #openstack-trove | 04:26 | |
| *** itlinux has joined #openstack-trove | 04:29 | |
| *** chhavi has joined #openstack-trove | 04:31 | |
| *** links has joined #openstack-trove | 04:33 | |
| *** gouthamr has quit IRC | 04:38 | |
| *** harlowja has quit IRC | 04:52 | |
| openstackgerrit | Fan Zhang proposed openstack/trove master: Fix missing package and remove inexistent option. Remove notifier_queue_* because this option is removed before. Add "openstack-trove-guestagent" to yum command because the /etc/trove/trove-guestagent.conf is in openstack-trove-guestagent package. https://review.openstack.org/487716 | 06:44 |
| *** rcernin has joined #openstack-trove | 07:13 | |
| *** smatzek has joined #openstack-trove | 10:57 | |
| *** kylek3h has joined #openstack-trove | 11:42 | |
| *** kylek3h has quit IRC | 11:42 | |
| *** fanzhang_ has joined #openstack-trove | 11:53 | |
| *** kylek3h has joined #openstack-trove | 12:02 | |
| *** kylek3h has quit IRC | 12:11 | |
| *** chhavi has quit IRC | 12:32 | |
| *** links has quit IRC | 12:52 | |
| *** gcb has quit IRC | 13:02 | |
| *** gcb has joined #openstack-trove | 13:04 | |
| *** gouthamr has joined #openstack-trove | 13:31 | |
| *** trevormc has joined #openstack-trove | 14:48 | |
| openstackgerrit | Samuel Matzek proposed openstack/trove master: Fix nova proxy admin login https://review.openstack.org/487881 | 14:49 |
| openstackgerrit | Samuel Matzek proposed openstack/trove master: Fix nova proxy admin login https://review.openstack.org/487881 | 14:51 |
| openstackgerrit | Samuel Matzek proposed openstack/trove master: Fix nova proxy admin login https://review.openstack.org/487881 | 14:53 |
| *** rcernin has quit IRC | 15:03 | |
| *** links has joined #openstack-trove | 15:04 | |
| *** links has quit IRC | 15:07 | |
| fanzhang_ | hi, trevormc, are you there? | 15:18 |
| trevormc | yes I am, hows it going | 15:19 |
| trevormc | ? | 15:19 |
| fanzhang_ | I just read about your comments. So I have to change the commit message , remove unconfirmed settings and commit --amend ? | 15:20 |
| trevormc | yeah thats about right. | 15:21 |
| trevormc | the trove.test.conf will run it against our gate, that way we'll be able to see it perform in our scenario tests (i think ?0 | 15:22 |
| trevormc | yeah you can test the changes with the integration project. | 15:23 |
| fanzhang_ | trevormc , ok, I will do that later. Thank you so much for guiding me. It's my 1st commit, so I am a little bit confusing :) | 15:24 |
| trevormc | yeah no worries, thanks for being up so late to communicate with us | 15:25 |
| fanzhang_ | trevormc , as for the line 12, it's right, isn't it ? | 15:25 |
| trevormc | it should say Closes | 15:25 |
| trevormc | you have Close-Bug | 15:25 |
| trevormc | Closes-Bug: #<bug> | 15:26 |
| fanzhang_ | oh..sorry for missing "s" LOL | 15:26 |
| trevormc | if you do it correctly, you can see a link will appear in your commit message and it will re-direct you to the bug report | 15:26 |
| trevormc | yep, you got it | 15:26 |
| fanzhang_ | yep, I think that tag should work like that, I was wondering why there is no link ... LOL | 15:27 |
| fanzhang_ | trevormc , have a nice day. I am going to bed :) | 15:29 |
| trevormc | thanks! | 15:29 |
| *** fanzhang_ has quit IRC | 15:31 | |
| *** ekoorjr has joined #openstack-trove | 15:37 | |
| smatzek | amrith, when you get a chance can you look at the comment I left on https://review.openstack.org/#/c/477327 and let me know your if you think some latent bugs are lurking here? If you agree I can toss that in a bug report rather than just in some gerrit comment. | 16:16 |
| *** fanzhang has quit IRC | 16:20 | |
| *** fanzhang has joined #openstack-trove | 16:21 | |
| *** harlowja has joined #openstack-trove | 17:09 | |
| *** rcernin has joined #openstack-trove | 17:16 | |
| smatzek | amrith, have you or anyone else looked into the "AttributeError: 'module' object has no attribute '_logger'" failure that is wedging the apiexamples tox gate? | 17:19 |
| smatzek | I'll dig in but don't want to redo work that someone else is doing. | 17:20 |
| trevormc | smatzek, I believe that was caused by a patch from changing from logger to LOG, looks like we missed one. | 17:21 |
| trevormc | uh i guess it didnt merge https://review.openstack.org/#/c/439377/3 | 17:23 |
| smatzek | so getting that out of merge conflict and merging it will fix the issue you think? | 17:26 |
| trevormc | no because none of the changes include _logger. only logger | 17:39 |
| smatzek | ah, yeah, I haven't looked at the code involved in the error. I have a change to push to OpenStack ansible for Trove and then I'll look at putting a change up to unwedge the gate. | 17:40 |
| trevormc | this is the change https://review.openstack.org/#/c/430362/6/troveclient/apiclient/client.py | 17:43 |
| trevormc | its from python-troveclient's client.py file.. the snippet writer imports the trove_client and calls ._logger here http://git.openstack.org/cgit/openstack/trove/tree/trove/tests/examples/snippets.py#n36 | 17:44 |
| trevormc | change _logger to LOG and it should be fixed | 17:44 |
| *** magicboiz has quit IRC | 17:51 | |
| openstackgerrit | Samuel Matzek proposed openstack/trove master: Fix snippets test case failure https://review.openstack.org/487963 | 18:00 |
| smatzek | trevormc, that change did it, review posted ^ Thanks. | 18:01 |
| *** fanzhang_ has joined #openstack-trove | 19:54 | |
| *** fanzhang has quit IRC | 19:56 | |
| *** smatzek has quit IRC | 20:15 | |
| *** fanzhang_ has quit IRC | 22:09 | |
| *** fanzhang_ has joined #openstack-trove | 22:09 | |
| *** trevormc has quit IRC | 22:10 | |
| *** gouthamr_ has joined #openstack-trove | 22:10 | |
| *** gouthamr has quit IRC | 22:10 | |
| *** fanzhang__ has joined #openstack-trove | 22:11 | |
| *** fanzhang_ has quit IRC | 22:15 | |
| *** rcernin has quit IRC | 22:26 | |
| *** gouthamr_ has quit IRC | 22:37 | |
| *** openstack has joined #openstack-trove | 22:42 | |
| *** amrith has quit IRC | 22:43 | |
| *** amrith has joined #openstack-trove | 22:45 | |
| *** ChanServ sets mode: +o amrith | 22:45 | |
| *** gouthamr has joined #openstack-trove | 22:53 | |
| *** itlinux has joined #openstack-trove | 23:03 | |
| *** ekoorjr has quit IRC | 23:20 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!