| *** tosky has quit IRC | 00:06 | |
| *** sapd1_x has joined #openstack-trove | 01:07 | |
| *** sapd1_x has quit IRC | 01:18 | |
| *** jamesmcarthur has joined #openstack-trove | 01:32 | |
| *** jamesmcarthur has quit IRC | 01:33 | |
| *** jamesmcarthur has joined #openstack-trove | 01:33 | |
| *** jamesmcarthur has quit IRC | 02:21 | |
| *** jamesmcarthur has joined #openstack-trove | 02:47 | |
| *** jamesmcarthur has quit IRC | 02:56 | |
| *** jamesmcarthur has joined #openstack-trove | 02:56 | |
| sorrison | lxkong: I've been having a look into how the backups work. I'm still unsure why this part is now in a container? Eg. why separate out part of the code as opposed to keeping it all under the trove namespace | 03:15 |
|---|---|---|
| sorrison | other option would be to create a whole new repo called trove-backup or something and them a python library called trove_backup? then deployers could choose whether they want to deploy this as a container or just do it the way it is? | 03:16 |
| sorrison | it just seems like the 2 parts of the code will always be tightly coupled so why separate them, it just adds complexity | 03:16 |
| *** jamesmcarthur has quit IRC | 04:12 | |
| lxkong | sorrison: without using container, we need to install extra packages to guest image | 04:51 |
| sorrison | sure, that is how we do it now | 04:51 |
| sorrison | I just guess it would be nice if deployer could choose how to do it | 04:52 |
| lxkong | i was thinking about create new repo, but that is going to introduce more maintenance for the team | 04:52 |
| lxkong | sorrison: i was doing that from upstream team point of view | 04:52 |
| sorrison | the code could all still be in the main trove codebase | 04:52 |
| sorrison | just put the whole trove code base in the container for backups? | 04:52 |
| lxkong | sorrison: i know your point, you want to avoid using backup container and maintain your own guest image. | 04:53 |
| sorrison | it sounds like all that needs to actually go in the container are the xtrabackup etc. packages? | 04:53 |
| lxkong | sorrison: feel free to change that but don't break the current container behavior | 04:54 |
| sorrison | yeah we really need to be able to manage our own images, specially from a security point of view | 04:54 |
| sorrison | I think we could support both methods with a bit of moving of code around | 04:54 |
| lxkong | i totally understand but that's not possble for the upstream currently | 04:54 |
| lxkong | sorrison: what i have been doing is to decrease the maintenance effort as the upstream team | 04:55 |
| sorrison | is the main issue your've trying to solve being the changes in the backup packages break trove? Eg. xrtrabackup changing args etc.? | 04:55 |
| sorrison | yeah I'm very greatful for all the work you've done to revive the trove project! | 04:56 |
| lxkong | e.g. if not using container, you need to maintain the elements to install xtrabackup, mariabackup for different datastores | 04:57 |
| lxkong | and different guest images for mysql and mariadb and postgresql | 04:57 |
| lxkong | using container, the upstream team only need to maintain one single 'standard' guest image for all datastores | 04:58 |
| lxkong | there are only trove code, docker included in the image | 04:58 |
| sorrison | yeah ok, so also putting mysql-server etc. inside a container too and the "standard" image is a vanila ubuntu? | 04:58 |
| lxkong | ubuntu + docker + trove-guestagent | 04:59 |
| sorrison | yeah ok, does make sense | 05:01 |
| lxkong | and the bonus point of the backup docker image is, anyone could use that to do backup, not only for trove only | 05:02 |
| lxkong | we have customer that created mysql db in a VM, could use that to upload data to swift | 05:03 |
| sorrison | yeah that's cool | 05:03 |
| lxkong | the plugable machanism could also make it easy to support s3 | 05:03 |
| sorrison | sure, but it's not really containers that help there | 05:05 |
| sorrison | it's all just python code in the end | 05:05 |
| sorrison | essentially it could just be another shell script that trove produces, that could be packaged up in a container or not | 05:07 |
| sorrison | also dockerhub the way it's going isn't a good way forward so have to think about that too | 05:08 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: [WIP] Support ram quota https://review.opendev.org/760284 | 05:11 |
| sorrison | also lxkong I think https://review.opendev.org/#/c/759149/ can be abandoned as your mysql8 patch fixes this right? | 05:16 |
| *** rcernin has quit IRC | 07:31 | |
| lxkong | > 18:05 <sorrison> it's all just python code in the end | 08:50 |
| lxkong | not that simple. Using container only needs to install docker, pure python code still needs to install extra packages. | 08:51 |
| *** tosky has joined #openstack-trove | 08:51 | |
| lxkong | and yes, https://review.opendev.org/#/c/759149/ could be abandoned | 08:51 |
| *** rcernin has joined #openstack-trove | 09:18 | |
| openstackgerrit | Lingxian Kong proposed openstack/trove master: [WIP] Fix restore encrypted backup https://review.opendev.org/760260 | 10:07 |
| *** rcernin has quit IRC | 10:07 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove-dashboard master: Imported Translations from Zanata https://review.opendev.org/760319 | 10:19 |
| *** e0ne has joined #openstack-trove | 10:28 | |
| *** e0ne has quit IRC | 10:46 | |
| *** e0ne has joined #openstack-trove | 11:03 | |
| *** rcernin has joined #openstack-trove | 11:15 | |
| *** spatel has joined #openstack-trove | 11:56 | |
| *** spatel has quit IRC | 12:01 | |
| openstackgerrit | Merged openstack/trove master: Return instances by created order https://review.opendev.org/760257 | 12:03 |
| *** sapd1 has quit IRC | 12:19 | |
| *** congnt95 has quit IRC | 12:20 | |
| *** sapd1 has joined #openstack-trove | 12:20 | |
| *** congnt95 has joined #openstack-trove | 12:20 | |
| *** __ministry1 has joined #openstack-trove | 13:37 | |
| *** sapd1_x has joined #openstack-trove | 13:38 | |
| *** rcernin has quit IRC | 13:43 | |
| *** sapd1_x has quit IRC | 14:06 | |
| *** jamesmcarthur has joined #openstack-trove | 15:22 | |
| *** jamesmcarthur has quit IRC | 15:23 | |
| *** jamesmcarthur has joined #openstack-trove | 15:29 | |
| *** __ministry1 has quit IRC | 15:33 | |
| *** jamesmcarthur has quit IRC | 15:33 | |
| *** jamesmcarthur has joined #openstack-trove | 15:38 | |
| *** e0ne has quit IRC | 15:46 | |
| *** e0ne has joined #openstack-trove | 15:47 | |
| *** e0ne has quit IRC | 17:03 | |
| *** tosky has quit IRC | 18:29 | |
| *** jamesmcarthur has quit IRC | 18:44 | |
| openstackgerrit | Merged openstack/trove-dashboard master: Imported Translations from Zanata https://review.opendev.org/760319 | 19:08 |
| *** jamesmcarthur has joined #openstack-trove | 19:29 | |
| *** cyberde has quit IRC | 20:05 | |
| *** jamesmcarthur has quit IRC | 20:38 | |
| *** jamesmcarthur has joined #openstack-trove | 20:38 | |
| openstackgerrit | Lingxian Kong proposed openstack/trove master: Fix restore encrypted backup https://review.opendev.org/760260 | 21:43 |
| *** tosky has joined #openstack-trove | 21:57 | |
| *** congnt96 has joined #openstack-trove | 22:13 | |
| *** jamesmcarthur has quit IRC | 22:19 | |
| *** jamesmcarthur has joined #openstack-trove | 22:20 | |
| *** jamesmcarthur has quit IRC | 22:25 | |
| *** jamesmcarthur has joined #openstack-trove | 22:28 | |
| *** jamesmcarthur has quit IRC | 22:41 | |
| *** jamesmcarthur has joined #openstack-trove | 22:42 | |
| *** jamesmcarthur has quit IRC | 22:46 | |
| *** rcernin has joined #openstack-trove | 22:58 | |
| *** rcernin has quit IRC | 23:00 | |
| *** rcernin has joined #openstack-trove | 23:00 | |
| *** jmlowe has quit IRC | 23:24 | |
| *** jmlowe has joined #openstack-trove | 23:24 | |
| *** spatel has joined #openstack-trove | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!