| *** tosky has quit IRC | 00:14 | |
| lxkong | btw sorrison, are you dev or ops? or devops? | 00:15 |
|---|---|---|
| sorrison | I'm both | 00:16 |
| lxkong | ah ok, may i know how many people in your team is looking after trove? | 00:17 |
| sorrison | I'm the only one doing dev in trove | 00:18 |
| sorrison | but we have other ops/helpdesk that will do that side of thing in trove too, we share | 00:18 |
| lxkong | sorrison: ok, thanks for the info | 00:19 |
| sorrison | yeah I'm just mainly frustrated as I think all the changes since ussuri are going to make it essentially impossible to upgrade. We are almost at the point where we might have to drop trove or fork it etc. | 00:19 |
| lxkong | it depends on what you need, i can help add things back, either for master or Victoria. | 00:20 |
| sorrison | ussuri works really well for us | 00:20 |
| lxkong | but it's your call | 00:20 |
| sorrison | I want to contribute to trove but I think the priorities need to be getting the tests working upstream and making it upgradable | 00:21 |
| sorrison | once that's done then things like making it use containers etc. could be done but it's really hard with no proper testing in the gate and the removal of all the api tests in trove-tempest-plugin | 00:22 |
| lxkong | i understand, the functional test and tempest test both work on my local. Upstream CI fails because of CI host performance issue, container in a vm in another vm, etc. | 00:22 |
| lxkong | have you checked the existing tests in trove-tempest-plugin? | 00:23 |
| lxkong | i don't think the current test cases are less than the privious ones | 00:23 |
| lxkong | and the previous ones actually didn't provide many valid tests | 00:23 |
| lxkong | we are using trove tempest in our scenario test, which covers instance creation, access, backup/restore, configuration and replication | 00:24 |
| lxkong | what other api tests are you looking for? | 00:24 |
| sorrison | yeah lots missing though | 00:25 |
| sorrison | what was the reason to remove the existing api tests? | 00:26 |
| sorrison | sorry I'm missing a lot of history here and just trying to catch up | 00:26 |
| sorrison | So with upstream CI, do you know what needs to be done to fix the issues? | 00:37 |
| lxkong | > yeah lots missing though | 00:41 |
| lxkong | looking at https://review.opendev.org/#/c/761472/, i don't think there are *lots* missing | 00:41 |
| lxkong | on the contrary, the current tests can cover more than the tests in that patch | 00:42 |
| lxkong | https://review.opendev.org/#/c/761472/1/trove_tempest_plugin/tests/api/database/versions/test_versions.py do you think this test is doing any valid check for the end user? | 00:43 |
| lxkong | > what was the reason to remove the existing api tests? | 00:43 |
| sorrison | it's all about API compatibility | 00:44 |
| lxkong | because those tests were not well organized, and as cloud provider, we do care about the real scenario test, e.g. create a instance and access the mysql | 00:45 |
| sorrison | I couldn't see tests for restart, update name etc. but I haven't looked through it all yet. it's a bit different to all the other tempest code now so a bit less familiar to me | 00:45 |
| lxkong | and check the data after restoing a db instance | 00:45 |
| sorrison | yeah they are equally as important | 00:45 |
| lxkong | for the upstream CI, i've talked with the infra people, there is no workaround at the moment. | 00:46 |
| lxkong | magnum is having the same issue | 00:46 |
| lxkong | so we have to rely on the test run on the local dev environment | 00:46 |
| lxkong | like what i did for your reverting flavor API patch | 00:47 |
| sorrison | yeah ok, could it run as external CI feeding back into gerrit? We can host resources if needed | 00:47 |
| lxkong | i think so. We are hosting CI jobs for cloud-provider-openstack in k8s, but not yet for trove | 00:48 |
| lxkong | just because of lack of resources | 00:48 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Make guest agent api changes backwards compatible https://review.opendev.org/761270 | 00:49 |
| lxkong | because there was no other active contributor before, i just run all the test locally by myself | 00:50 |
| sorrison | I guess if you're the only one doing anything it is easy to only think about one environment. For the future of trove though it needs to change | 00:53 |
| sorrison | most of the sites I know running trove are running older versions so it might not be for a while until operators try an upgrade to newer versions and discover all these issues | 00:54 |
| lxkong | yep, that's what i was trying to explain for all the changes introduced since ussuri | 00:54 |
| sorrison | but if you want other people to continue to use trove you're going to have to start taking these things into account | 00:55 |
| lxkong | you are absulutely right, the thing is, when i contribute to trove at the beginning, after proposing a patch, no one is interested in review | 00:56 |
| lxkong | no reviewers, no discussion in mailing list | 00:56 |
| lxkong | it's hard to get feedback | 00:56 |
| lxkong | if i stopped contribution and maintaining, trove has already been retired | 00:57 |
| lxkong | i was so suprised when you joined and said you are using trove | 00:58 |
| sorrison | yeah I understand that, it's great to have someone maintaining trove | 00:58 |
| sorrison | My fear is the the existing people who are using trove will give up and stop using it so I'm really keen to get it working the way it was in Ussuri. It's a really great piece of software and is a good value add for our users | 00:59 |
| lxkong | but anyway, like i said, i'm glad people are coming, and i agree we could have things added back or get fixed | 01:00 |
| lxkong | you are the only one of "existing people" i've known of, besides us | 01:00 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Use datastore manager as opposed to name to restrict actions https://review.opendev.org/761253 | 01:02 |
| sorrison | I think mariadb uses the mysql manager so maybe this could change a little? | 01:02 |
| lxkong | sorry, change for what? | 01:05 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Pass availability zone through to volume creation. https://review.opendev.org/761250 | 01:07 |
| lxkong | btw, i have fixed the revert flavor api patch and started runing test | 01:07 |
| openstackgerrit | Merged openstack/python-troveclient master: Fix help message of datastore version upgrade https://review.opendev.org/761393 | 01:20 |
| openstackgerrit | Lingxian Kong proposed openstack/trove master: Revert "Remove flavor API" https://review.opendev.org/761063 | 01:31 |
| *** sapd1 has joined #openstack-trove | 01:41 | |
| *** rcernin has quit IRC | 01:43 | |
| *** rcernin_ has joined #openstack-trove | 01:43 | |
| *** spatel has joined #openstack-trove | 02:10 | |
| *** spatel has quit IRC | 02:11 | |
| *** spatel has joined #openstack-trove | 02:12 | |
| *** spatel has quit IRC | 02:14 | |
| *** rcernin_ has quit IRC | 03:24 | |
| *** rcernin_ has joined #openstack-trove | 03:34 | |
| *** rcernin_ has quit IRC | 03:47 | |
| *** sapd1 has quit IRC | 03:57 | |
| openstackgerrit | Lingxian Kong proposed openstack/trove master: Fix upgrading instance datastore version https://review.opendev.org/761465 | 04:07 |
| openstackgerrit | Lingxian Kong proposed openstack/trove stable/victoria: Revert "Remove flavor API" https://review.opendev.org/761490 | 04:10 |
| *** rcernin has joined #openstack-trove | 04:20 | |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Make guest agent api changes backwards compatible https://review.opendev.org/761270 | 04:30 |
| sorrison | lxkong: I think I found another issue relating to flavor API | 04:51 |
| sorrison | resize isn't working. Get the error Details: {'code': 400, 'message': "Validation error: resize['flavorRef'] '' is not valid under any of the given schemas; '' is too short; '' does not match '^.*[0-9a-zA-Z]+.*$'; '' is not of type 'integer'"} | 04:51 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Make guest agent api changes backwards compatible https://review.opendev.org/761270 | 04:59 |
| *** rcernin has quit IRC | 05:13 | |
| *** rcernin has joined #openstack-trove | 05:15 | |
| lxkong | sorrison: can you provide more detail? If using CLI, what's the command? If API, the body? | 05:26 |
| sorrison | sure one sec, I'm just doing some full tempest runs, mostly looking good, resize and rename are failing so far | 05:31 |
| sorrison | I've discovered one of the reasons we need the flavor ID is that the flavors that trove uses are private | 05:35 |
| sorrison | so doing something like `trove resize-instance x db.medium` fails as flavor can't be found | 05:35 |
| sorrison | OK I figured it out it was a misconfiguration by me, whoops | 05:40 |
| sorrison | I think the flavor API needs to be restored in full along with docs and tests as it's not something we can remove and is very useful | 05:41 |
| sorrison | lxkong: are using designate plugin in your env? I think that is broken with a change around instance.address. Just trying to diagnose now | 05:46 |
| openstackgerrit | Merged openstack/trove master: Revert "Remove flavor API" https://review.opendev.org/761063 | 06:03 |
| *** rcernin has quit IRC | 06:37 | |
| *** rcernin has joined #openstack-trove | 06:50 | |
| *** rcernin has quit IRC | 07:12 | |
| *** rcernin has joined #openstack-trove | 07:33 | |
| *** rcernin has quit IRC | 07:43 | |
| *** tosky has joined #openstack-trove | 08:13 | |
| *** hoonetorg has quit IRC | 08:21 | |
| *** hoonetorg has joined #openstack-trove | 08:26 | |
| *** e0ne has joined #openstack-trove | 10:46 | |
| *** sapd1 has joined #openstack-trove | 13:18 | |
| *** congnt96 has joined #openstack-trove | 14:55 | |
| *** sapd1 has quit IRC | 16:51 | |
| *** congnt96 has quit IRC | 18:17 | |
| lxkong | sorrison: i am afraid i don't agree that flavor API in Trove is necessary. All trove does is to query flavor from Nova. | 19:32 |
| lxkong | sorrison: do you have any use case that trove flaovr API can do but Nova flavor can't? | 19:32 |
| lxkong | If you want to limit the flavors can be used by users, just config that in datastore version using`trove-manage datastore_version_flavor_add` | 19:34 |
| openstackgerrit | Merged openstack/trove-dashboard master: Fix replica number input type https://review.opendev.org/761419 | 19:48 |
| openstackgerrit | Lingxian Kong proposed openstack/trove stable/victoria: Use datastore manager as opposed to name to restrict actions https://review.opendev.org/761660 | 20:01 |
| *** e0ne has quit IRC | 20:21 | |
| *** e0ne has joined #openstack-trove | 20:37 | |
| *** e0ne has quit IRC | 21:02 | |
| *** rcernin has joined #openstack-trove | 21:27 | |
| *** rcernin has quit IRC | 21:53 | |
| *** rcernin has joined #openstack-trove | 21:55 | |
| openstackgerrit | Lingxian Kong proposed openstack/trove master: Fix the functional test related to flavor check https://review.opendev.org/761674 | 21:57 |
| openstackgerrit | Lingxian Kong proposed openstack/trove stable/victoria: Revert "Remove flavor API" https://review.opendev.org/761490 | 21:59 |
| *** e0ne has joined #openstack-trove | 22:03 | |
| openstackgerrit | Merged openstack/trove master: Use datastore manager as opposed to name to restrict actions https://review.opendev.org/761253 | 22:15 |
| *** e0ne has quit IRC | 22:17 | |
| sorrison | lxkong: There are 2 reasons for the flavor ID, one is if you are using a separate nova/cinder that is not exposed to end users. That is how we used to have trove deployed and there might be other installs set up that way | 22:25 |
| sorrison | the second reason is that the flavors that trove users might not be accessible to normal users. This is the case for us where trove uses special private flavors that aren't accessible to normal users | 22:26 |
| sorrison | does that make sense? | 22:26 |
| sorrison | I mean flavor API | 22:33 |
| lxkong | Could both the reasons be solved using `trove-manage datastore_version_flavor_add`? | 22:50 |
| *** rcernin has quit IRC | 22:57 | |
| *** rcernin has joined #openstack-trove | 23:01 | |
| *** spatel has joined #openstack-trove | 23:20 | |
| *** spatel has quit IRC | 23:25 | |
| openstackgerrit | Merged openstack/trove stable/victoria: Use datastore manager as opposed to name to restrict actions https://review.opendev.org/761660 | 23:52 |
| *** tosky has quit IRC | 23:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!