| *** congnt96 has quit IRC | 00:09 | |
| lxkong | > in tempest it creates a network for each test class, maybe you're unaware about this as it looks like trove-tempest-plugin duplicates this | 00:15 |
|---|---|---|
| lxkong | This is no duplication, trove tempest doesn't reply on tempest code to create those tenant network resources, https://github.com/openstack/trove-tempest-plugin/blob/master/trove_tempest_plugin/tests/base.py#L73 | 00:15 |
| lxkong | there was a reason to create network resources in trove plugin, need some time to remember | 00:16 |
| lxkong | if relying on tempest, will it also create network resources from admin user as well? | 00:20 |
| sorrison | not quite sure what you mean "from admin" ? | 00:53 |
| lxkong | sorry, 'for admin' | 00:54 |
| sorrison | it will create a network/subnet/router for the os_primary credential | 00:55 |
| lxkong | and os_admin? | 00:56 |
| sorrison | I'm not sure about that | 00:56 |
| lxkong | from the code, yes, but not verified | 00:56 |
| sorrison | from what I can see the tests don't need that? | 00:56 |
| lxkong | but the trove tempest plugin is doing the right thing, right? | 00:57 |
| lxkong | tempest won't create those resources automatically | 00:57 |
| lxkong | because of the code i linked | 00:57 |
| sorrison | yeah it does create them automatically | 00:57 |
| lxkong | i need to check then | 00:57 |
| sorrison | ahh, sorry I didn't see that link above | 00:58 |
| sorrison | yeah it won't in that case but not sure why it would do that? Wouldn't it be better to just let the tempest code do this as opposed to doing it inside trove-tempest-plugin? | 00:58 |
| lxkong | yeah, it's fine if tempest doesn't create resources for admin user | 00:59 |
| lxkong | another thing is the resource prefix can't be customized | 01:00 |
| sorrison | does it need to be? | 01:00 |
| lxkong | e.g. we are using 'trove-tempest' as prefix, if using tempest, it's 'tempest' | 01:00 |
| sorrison | correct, is that an issue? | 01:01 |
| lxkong | yes | 01:01 |
| lxkong | it makes it hard to do resource clean up | 01:01 |
| lxkong | and creating resources for admin user is not necessary | 01:01 |
| sorrison | that's all taken care of, trove-tempest-plugin doesn't need to worry about all of that | 01:01 |
| lxkong | tempest provices that capability, trove-tempest-plugin just uses that | 01:02 |
| lxkong | personally, i don't think that's a big issue only if it causes problem | 01:02 |
| lxkong | so i need to check if https://github.com/openstack/trove-tempest-plugin/blob/master/trove_tempest_plugin/tests/base.py#L73 is really working or not | 01:03 |
| sorrison | It just makes trove-tempest-plugin more complicated and more to maintain | 01:03 |
| lxkong | if yes, we don't need to change anything | 01:03 |
| lxkong | it's common to use that if you search in tempest or other tempest plugins | 01:03 |
| sorrison | I'll submit a review and see what you think, we should be able to remove a lot of lines of code which is always nice | 01:04 |
| openstackgerrit | Sam Morrison proposed openstack/trove master: Fixup zuul nodetype for nested https://review.opendev.org/c/openstack/trove/+/765029 | 01:12 |
| sorrison | lxkong: also this will fix the issue where tempest isn't running in the gate I hope ^^ | 01:12 |
| lxkong | sorrison: thanks, will take a look when i have some time | 01:21 |
| lxkong | need to pick up the kid now :-) | 01:22 |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 01:36 |
| *** rcernin has quit IRC | 01:37 | |
| *** rcernin has joined #openstack-trove | 01:39 | |
| *** spatel has joined #openstack-trove | 01:48 | |
| *** sapd1_x has joined #openstack-trove | 02:30 | |
| *** rcernin has quit IRC | 02:36 | |
| *** sapd1_x has quit IRC | 02:42 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 02:59 |
| *** rcernin has joined #openstack-trove | 03:06 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 03:53 |
| *** sapd1_x has joined #openstack-trove | 04:23 | |
| *** sapd1_x has quit IRC | 05:01 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 05:06 |
| *** rcernin has quit IRC | 05:43 | |
| *** rcernin has joined #openstack-trove | 05:55 | |
| *** spatel has quit IRC | 06:37 | |
| openstackgerrit | Sam Morrison proposed openstack/trove master: [DNM] - debugging race ocndition https://review.opendev.org/c/openstack/trove/+/765066 | 07:38 |
| *** rcernin has quit IRC | 07:38 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 07:39 |
| *** rcernin has joined #openstack-trove | 07:44 | |
| *** rcernin has quit IRC | 07:48 | |
| *** rcernin has joined #openstack-trove | 08:01 | |
| *** damien_r has joined #openstack-trove | 08:12 | |
| *** rcernin has quit IRC | 08:16 | |
| *** damien_r has quit IRC | 08:17 | |
| *** rcernin has joined #openstack-trove | 08:32 | |
| *** rcernin has quit IRC | 08:46 | |
| *** sapd1_x has joined #openstack-trove | 09:00 | |
| *** tosky has joined #openstack-trove | 09:05 | |
| *** rcernin has joined #openstack-trove | 09:42 | |
| *** rcernin has quit IRC | 09:42 | |
| *** sapd1_x has quit IRC | 10:00 | |
| *** sapd1_x has joined #openstack-trove | 10:15 | |
| *** icey_ has joined #openstack-trove | 10:43 | |
| *** sapd1_x has quit IRC | 10:43 | |
| *** icey has quit IRC | 10:44 | |
| *** e0ne has joined #openstack-trove | 10:57 | |
| *** sapd1_x has joined #openstack-trove | 11:15 | |
| *** sapd1_x has quit IRC | 11:40 | |
| openstackgerrit | likui proposed openstack/trove master: Add support for python 3.8 https://review.opendev.org/c/openstack/trove/+/765123 | 11:40 |
| *** icey_ has quit IRC | 11:44 | |
| *** icey has joined #openstack-trove | 11:58 | |
| *** e0ne has quit IRC | 12:40 | |
| *** henrietaMag has quit IRC | 12:53 | |
| *** sapd1_x has joined #openstack-trove | 13:24 | |
| *** e0ne has joined #openstack-trove | 13:34 | |
| *** spatel has joined #openstack-trove | 13:52 | |
| *** spatel has quit IRC | 13:53 | |
| *** damien_r has joined #openstack-trove | 15:20 | |
| *** sapd1_x has quit IRC | 15:44 | |
| *** damien_r has quit IRC | 16:08 | |
| *** e0ne has quit IRC | 16:51 | |
| *** congnt96 has joined #openstack-trove | 16:58 | |
| *** e0ne has joined #openstack-trove | 17:41 | |
| *** e0ne has quit IRC | 19:16 | |
| *** e0ne has joined #openstack-trove | 19:50 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/trove-dashboard master: Add Backup Strategies table https://review.opendev.org/c/openstack/trove-dashboard/+/765200 | 20:00 |
| *** e0ne has quit IRC | 20:11 | |
| *** congnt96 has quit IRC | 21:03 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Reinstate removed api tests https://review.opendev.org/c/openstack/trove-tempest-plugin/+/761472 | 21:12 |
| sorrison | lxkong: making some progress with the tempest failures in the gate | 22:24 |
| sorrison | I wonder if you're able to replicate https://storyboard.openstack.org/#!/story/2008410 | 22:24 |
| sorrison | I see it in the gate and I can replicate it in my own environment easily | 22:25 |
| lxkong | yes, i also noticed that test case fails sometimes in devstack. But in our internal tempest, it's always passing | 22:27 |
| lxkong | i need to spend some time on that | 22:27 |
| lxkong | lots of things on my TODO :-( | 22:27 |
| lxkong | I'm still working on our trove upgrade patch and helping our ops to understand the trove upgrade process | 22:28 |
| lxkong | sorrison: btw, i'm also working on adding a new field 'opearting_status' for instance | 22:30 |
| lxkong | to split the dabase service status from the original 'status' field | 22:30 |
| sorrison | ok, good to know you can replicate it and just not me | 22:30 |
| sorrison | If I run it by itself it works so must be some issue or conflict with the other tests | 22:30 |
| openstackgerrit | Merged openstack/trove-dashboard master: Add Backup Strategies table https://review.opendev.org/c/openstack/trove-dashboard/+/765200 | 22:31 |
| *** rcernin has joined #openstack-trove | 22:34 | |
| openstackgerrit | Merged openstack/trove master: Add support for python 3.8 https://review.opendev.org/c/openstack/trove/+/765123 | 23:06 |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Remove use of custom network setup https://review.opendev.org/c/openstack/trove-tempest-plugin/+/765216 | 23:21 |
| *** TeamDevOps has quit IRC | 23:24 | |
| openstackgerrit | Sam Morrison proposed openstack/trove-tempest-plugin master: Temporarily skip broken test_user_database test https://review.opendev.org/c/openstack/trove-tempest-plugin/+/765220 | 23:47 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!