Friday, 2021-07-09

opendevreviewLingxian Kong proposed openstack/trove master: Fix resize instance of replication cluster  https://review.opendev.org/c/openstack/trove/+/80001901:04
opendevreviewLingxian Kong proposed openstack/trove master: Restore configuration after resizing instance  https://review.opendev.org/c/openstack/trove/+/80001901:09
__ministrylxkong: I was view new your patch about fix error when resize, but i think if we do that, when i do resize, it will take long time. What problem which we met if we do as my path?02:10
lxkong__ministry: ah, I see your point, let me do some test04:56
lxkong__ministry: because lots of functions are going to be affected by that change04:57
lxkongwhich I am trying to avoid04:57
__ministrywhen that function need override old config? I can't find :(04:58
__ministrywhat are contexts in here?04:59
lxkong__ministry: look for the places that call save_configuration()05:02
lxkongand `reset_configuration()`05:03
lxkongthe patch is going to change the behavior of all of those places05:03
lxkongthe original purpose of `save_configuration` is to reset configuration05:04
lxkongwhich needs to remove all current user defined configs05:04
lxkongnow you changed that, that may help resize, but may affect others05:04
opendevreviewLingxian Kong proposed openstack/trove master: Release note for adding iptables-persistent package  https://review.opendev.org/c/openstack/trove/+/80015805:26
__ministryI saw, when I save configuration, if old config still in here, and we do update configuration group, it still effect to old file =)).07:57
__ministryLet me test your patch.07:58
opendevreviewLingxian Kong proposed openstack/python-troveclient master: Fix detach configuration from instance  https://review.opendev.org/c/openstack/python-troveclient/+/80016608:48
opendevreviewMerged openstack/python-troveclient master: Fix detach configuration from instance  https://review.opendev.org/c/openstack/python-troveclient/+/80016610:31
lxkong__ministry: I'm also verying yours10:45
lxkongs/verying/verifying10:45
lxkong__ministry: what do you mean by "we do update configuration group, it still effect to old file"?11:15
lxkongHow did you test that?11:16
__ministryOh, I using my patch to create an instance and resize it11:17
lxkonghave you tested resizing the replica using your patch?11:17
__ministryafter i do update configuration for instance, and I was see config value was changed.11:17
__ministrylxkong: yep, I was tested.11:18
lxkongso expected?11:18
__ministrymy expected that are: when I resize a instance, I think about deep dive, it just is rebuild flavor and keep root disk.11:21
__ministrybut we doing that are change data of root disk.11:21
__ministryso, my expected about resize instance take less time. because, if we reboot database engine, it is maybe to take long time to start11:23
__ministryit take resize flow long time too.11:23
lxkongrestart database is just a docker container restart, which is actually fast. The point is not restarting, I'm looking at why the user defined configs are removed in save_configuration. Maybe I will do some changes based on yours.11:26
lxkongso basically, we need to verify: 11:26
lxkong1. create a replication cluster with at least 2 instances.11:26
lxkong2. resize primary, see if that will break the replication function 11:27
lxkong3. resize replica, check if it is still working as a replica11:27
lxkong4. resize a stand-alone instance (with configuration attached), see if the configuration still exists11:27
lxkong5 change the configuration of the stand-alone instance, see if the configuration is correct inside the instance.11:28
__ministryyep.11:29
__ministrythank you.11:30
opendevreviewMerged openstack/trove master: Add package iptables-persistent inside guest instance  https://review.opendev.org/c/openstack/trove/+/80013013:40
opendevreviewMerged openstack/trove master: Release note for adding iptables-persistent package  https://review.opendev.org/c/openstack/trove/+/80015821:04
opendevreviewLingxian Kong proposed openstack/trove stable/wallaby: Add package iptables-persistent inside guest instance  https://review.opendev.org/c/openstack/trove/+/80018221:10
opendevreviewLingxian Kong proposed openstack/trove stable/victoria: Add package iptables-persistent inside guest instance  https://review.opendev.org/c/openstack/trove/+/80031122:11
lxkong__ministry: with your patch, I met with the error inside the guest intance `2021-07-09T21:36:05.220833Z 0 [ERROR] Fatal error: Can't open and lock privilege tables: Table './mysql/user' is marked as crashed and should be repaired` when resizing replicas.22:20
lxkongI have reproduced many times.22:20

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!