| __ministry | @lxkong, I'm reading trove, but I was noticed in: https://github.com/openstack/trove/blob/master/trove/taskmanager/manager.py#L98 and have a question, that is: Whether current and future, trove just only support for mariadb, mysql, pgsql, ..? So, I want rewrite this function to separate file and config import by each datastore manager. What do you think about this? | 02:42 |
|---|---|---|
| lxkong | __ministry: no, trove support mysql, mariadb and postgresql for now, but nothing should stop people contributing for other datastores. | 06:01 |
| __ministry | lxkong: So, I want rewrite this function to separate file and config import by each datastore manager. What do you think about this? | 06:01 |
| lxkong | why you need to import this in the datastore manager? | 06:02 |
| __ministry | oops, if we support for others database, when we do promote a master node, they don't same. | 06:03 |
| __ministry | such as mongodb or redis, function `wait_for_txn` or `get_latest_txn_id` don't need. | 06:05 |
| __ministry | I noticed with each database type, they have a way to do promote to master separate. | 06:06 |
| lxkong | yeah, sure, you can change the code structure in a reasonable way | 06:07 |
| lxkong | but I think `promote_to_replica_source` is the predefined interface between trove-api and trove-taskmanager, you can't change the function name but change the logic of the fucntion definition. | 06:09 |
| __ministry | yep. i will push new commit as soon as to do test done. thank you for support. | 06:10 |
| lxkong | np, thanks for contribution | 06:10 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!