*** lblanchard has joined #openstack-ux | 00:45 | |
*** ducttape_ has quit IRC | 01:06 | |
*** chlong_ has joined #openstack-ux | 01:55 | |
*** david-lyle_ has joined #openstack-ux | 02:04 | |
*** david-lyle_ is now known as david-lyle | 02:05 | |
*** Marga__ has joined #openstack-ux | 02:10 | |
*** Marga_ has quit IRC | 02:14 | |
*** lblanchard has quit IRC | 02:18 | |
*** ducttape_ has joined #openstack-ux | 02:34 | |
*** Marga__ has quit IRC | 03:04 | |
*** Marga_ has joined #openstack-ux | 03:05 | |
*** ducttape_ has quit IRC | 03:12 | |
*** krotscheck_dr is now known as krotscheck_afk | 03:18 | |
*** ducttape_ has joined #openstack-ux | 03:20 | |
*** ducttape_ has quit IRC | 03:21 | |
*** ducttape_ has joined #openstack-ux | 03:34 | |
*** david-lyle_ has joined #openstack-ux | 03:42 | |
*** Marga_ has quit IRC | 03:42 | |
*** david-lyle has quit IRC | 03:45 | |
*** ducttape_ has quit IRC | 03:51 | |
*** david-lyle_ has quit IRC | 04:03 | |
*** david_lyle__ has joined #openstack-ux | 04:03 | |
*** Marga_ has joined #openstack-ux | 04:05 | |
*** Marga_ has quit IRC | 04:06 | |
*** Marga_ has joined #openstack-ux | 04:06 | |
*** david_lyle__ has quit IRC | 04:08 | |
*** Marga_ has quit IRC | 06:01 | |
*** Marga_ has joined #openstack-ux | 06:11 | |
*** jtomasek has joined #openstack-ux | 07:02 | |
*** chlong_ has quit IRC | 07:41 | |
*** piet has joined #openstack-ux | 08:37 | |
*** piet has quit IRC | 08:45 | |
*** piet has joined #openstack-ux | 08:47 | |
*** piet has quit IRC | 08:49 | |
*** piet has joined #openstack-ux | 08:55 | |
*** piet has quit IRC | 09:07 | |
*** piet has joined #openstack-ux | 09:08 | |
*** piet has quit IRC | 09:13 | |
*** piet has joined #openstack-ux | 09:15 | |
*** piet has quit IRC | 09:16 | |
*** piet has joined #openstack-ux | 09:21 | |
*** piet has quit IRC | 09:36 | |
*** piet has joined #openstack-ux | 09:38 | |
*** piet has quit IRC | 09:56 | |
*** piet has joined #openstack-ux | 10:02 | |
*** piet has quit IRC | 10:07 | |
*** piet has joined #openstack-ux | 10:08 | |
*** piet has quit IRC | 10:27 | |
*** piet has joined #openstack-ux | 10:27 | |
*** piet has quit IRC | 11:03 | |
*** piet has joined #openstack-ux | 11:04 | |
*** piet has quit IRC | 11:06 | |
*** piet has joined #openstack-ux | 11:07 | |
*** piet has quit IRC | 11:33 | |
*** piet has joined #openstack-ux | 11:33 | |
*** piet has quit IRC | 11:37 | |
*** piet has joined #openstack-ux | 11:38 | |
*** piet has quit IRC | 11:44 | |
*** piet has joined #openstack-ux | 11:48 | |
*** piet has quit IRC | 11:58 | |
*** chlong_ has joined #openstack-ux | 12:11 | |
*** piet has joined #openstack-ux | 12:23 | |
*** piet has quit IRC | 12:36 | |
*** lblanchard has joined #openstack-ux | 12:39 | |
*** krotscheck_afk is now known as krotscheck | 13:05 | |
*** 32NAABCSV has joined #openstack-ux | 13:23 | |
*** piet has joined #openstack-ux | 13:37 | |
*** 32NAABCSV has quit IRC | 13:38 | |
*** piet has quit IRC | 14:04 | |
*** piet has joined #openstack-ux | 14:06 | |
krotscheck | So, using git/gerrit to review binary images is a bad idea. | 14:13 |
---|---|---|
krotscheck | Not that I don't like the idea of reviewing things using our process. | 14:13 |
betherly | krotscheck: would you change your opinion on git reviewing images / mockups in gerrit if it had already gone through the commenting system in invision or similar? | 14:14 |
krotscheck | And if we could make gerrit be backed by not-git, that'd be perfect. | 14:14 |
krotscheck | betherly: No, it's a technological hurdle. | 14:14 |
krotscheck | Not a process one | 14:14 |
krotscheck | Git doesn't diff images. | 14:14 |
betherly | hmm that would be a pretty huge change to gerrit since it is git base | 14:14 |
krotscheck | i.e. every image will be stored, in full, at every revision. | 14:14 |
betherly | based | 14:14 |
krotscheck | Initially that doesn't seem so bad. | 14:14 |
krotscheck | But once you delete an image, that image is _never_ removed from the git history | 14:15 |
betherly | ah gotcha. ugh | 14:15 |
betherly | ye thats a problem i didnt know that | 14:15 |
krotscheck | So every time you clone, you're cloning every image that has been landed, deleted, updated, ever. | 14:15 |
* krotscheck learned that the hard way. We once committed 100MB video test data to a repository. | 14:15 | |
krotscheck | Then we deleted it. | 14:16 |
krotscheck | Damage was done. | 14:16 |
krotscheck | +100MB of repo size. | 14:16 |
krotscheck | FORREEEVER | 14:16 |
krotscheck | (until we erased it from git history, but we can't do that in gerrit) | 14:16 |
krotscheck | Note: I am less concerned about the size of patches. It's the revisions that land in master that are the problem. | 14:17 |
betherly | ohhh that is not haooy | 14:17 |
betherly | happy | 14:17 |
betherly | ugh i cant spell today | 14:17 |
krotscheck | Now, there's ways around that. If all images proposed are SVG format. | 14:18 |
krotscheck | That'd work as far as git is concerned, but Gerrit doesn't know how to display those. | 14:18 |
krotscheck | (SVG being a text-based format) | 14:18 |
krotscheck | Anyway- I've said my piece | 14:18 |
betherly | hmm so if design patches were put on gerrit for the official review process but never actually merged into the repo that would be ok? | 14:19 |
betherly | ok that svg idea is also interesting... | 14:19 |
betherly | gerrit may just be not the solution at alllll | 14:20 |
betherly | but options wise its good to know the eventuality of the choices | 14:20 |
*** piet has quit IRC | 14:29 | |
*** piet has joined #openstack-ux | 14:34 | |
*** openstackgerrit_ has quit IRC | 14:43 | |
*** ducttape_ has joined #openstack-ux | 15:00 | |
*** openstackgerrit_ has joined #openstack-ux | 15:00 | |
*** piet has quit IRC | 15:13 | |
*** piet has joined #openstack-ux | 15:20 | |
*** Marga_ has quit IRC | 15:33 | |
*** piet has quit IRC | 16:01 | |
*** piet has joined #openstack-ux | 16:06 | |
*** piet has quit IRC | 16:19 | |
*** piet has joined #openstack-ux | 16:24 | |
*** piet has quit IRC | 16:42 | |
*** Marga_ has joined #openstack-ux | 17:38 | |
*** chlong_ has quit IRC | 18:18 | |
*** ccesario has quit IRC | 18:25 | |
*** tonyb has quit IRC | 18:25 | |
*** abramley has quit IRC | 18:25 | |
*** krotscheck has quit IRC | 18:25 | |
*** krotscheck has joined #openstack-ux | 18:25 | |
*** abramley has joined #openstack-ux | 18:26 | |
*** bradjones has quit IRC | 18:27 | |
*** david-lyle has joined #openstack-ux | 18:27 | |
*** ccesario has joined #openstack-ux | 18:28 | |
*** bradjones has joined #openstack-ux | 18:28 | |
*** bradjones has quit IRC | 18:28 | |
*** bradjones has joined #openstack-ux | 18:28 | |
*** tonyb has joined #openstack-ux | 18:31 | |
*** Marga_ has quit IRC | 18:50 | |
*** Marga_ has joined #openstack-ux | 19:14 | |
*** Marga_ has quit IRC | 19:15 | |
*** Marga__ has joined #openstack-ux | 19:18 | |
*** lblanchard has quit IRC | 22:04 | |
*** ducttape_ has quit IRC | 22:15 | |
*** ducttape_ has joined #openstack-ux | 22:16 | |
*** ducttape_ has quit IRC | 22:22 | |
*** ducttape_ has joined #openstack-ux | 22:46 | |
*** ducttape_ has quit IRC | 22:47 | |
*** david-lyle has quit IRC | 22:50 | |
*** david-lyle has joined #openstack-ux | 22:51 | |
*** david-lyle has quit IRC | 22:54 | |
*** david-lyle has joined #openstack-ux | 22:54 | |
*** ducttape_ has joined #openstack-ux | 23:15 | |
*** jtomasek has quit IRC | 23:19 | |
*** ducttape_ has quit IRC | 23:28 | |
*** david-lyle_ has joined #openstack-ux | 23:29 | |
*** david-lyle has quit IRC | 23:30 | |
*** ducttape_ has joined #openstack-ux | 23:30 | |
*** ducttape_ has quit IRC | 23:39 | |
*** Marga_ has joined #openstack-ux | 23:51 | |
*** Marga__ has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!