*** openstackgerrit has quit IRC | 01:02 | |
*** openstackgerrit has joined #openstack-valence | 02:18 | |
openstackgerrit | Lin Yang proposed openstack/valence master: Fixed incorrect filed "status_code" in exception https://review.openstack.org/427986 | 02:18 |
---|---|---|
*** ramineni_ has quit IRC | 03:09 | |
openstackgerrit | Anusha Ramineni proposed openstack/valence master: Add API Validation framework https://review.openstack.org/422547 | 06:01 |
*** openstackgerrit has quit IRC | 12:03 | |
*** openstackgerrit has joined #openstack-valence | 20:10 | |
openstackgerrit | Lin Yang proposed openstack/valence master: Support post action to composed node https://review.openstack.org/428403 | 20:10 |
ntpttr | lin_yang: I just thought of a potential issue with https://review.openstack.org/#/c/422326/11/valence/controller/nodes.py | 22:08 |
ntpttr | I pulled the patch down because I want to base my flavor composition on it | 22:08 |
ntpttr | and when you do list nodes, nodes that were created and exist in pod manager before the database was created aren't showing up | 22:08 |
ntpttr | it just looks for nodes it knows about in the database, so any that exist that aren't in it don't show up | 22:09 |
lin_yang | that's true. On normal case, the node in podm should exist in database. To cover the unusual case, valence list all node in podm at first, then update the corresponding db entry if it missing? | 22:15 |
ntpttr | hmm, how will we be able to tell that it's the first call? | 22:16 |
ntpttr | I guess it's a little like manage volume in cinder | 22:17 |
ntpttr | which is, if you have say an LVM setup with pre-existing volumes, when you install cinder they won't know about them | 22:17 |
ntpttr | but - there's a command called volume manage, which takes the existing volume and adds it to cinder's database | 22:17 |
ntpttr | maybe a function like that would be useful | 22:18 |
ntpttr | rather than trying to figure out if it was the first 'list' call and adding them all. The admin who should know what the state of the podm is like could be able to say 'valence node-manage' and then give it the redfish URL | 22:18 |
ntpttr | I'll see about adding that before doing this flavor thing, and I'll let you know when it's reviewable | 22:19 |
lin_yang | this solution sounds great, leave them to admin to decide whether need to add it to db | 22:34 |
openstackgerrit | Lin Yang proposed openstack/valence master: Support post action to composed node https://review.openstack.org/428403 | 22:51 |
-openstackstatus- NOTICE: Restarting gerrit due to performance problems | 22:52 | |
*** ntpttr has quit IRC | 23:31 | |
*** ntpttr has joined #openstack-valence | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!