| *** yujunz has joined #openstack-vitrage | 00:24 | |
| openstackgerrit | xupeipei proposed openstack/vitrage-specs master: add snmp-parsing-service.rst https://review.openstack.org/486812 | 01:33 |
|---|---|---|
| *** zengjianfang has quit IRC | 01:40 | |
| *** yujunz has quit IRC | 02:17 | |
| *** yujunz has joined #openstack-vitrage | 02:36 | |
| *** yujunz has quit IRC | 03:40 | |
| *** ifat_afek has joined #openstack-vitrage | 05:56 | |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: Doc Migration: move the developer guide documents under the "contributor" folder https://review.openstack.org/486927 | 06:28 |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: Doc Migration: move the developer guide documents under the "contributor" folder https://review.openstack.org/486927 | 06:32 |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: Doc Migration: move the developer guide documents under the "contributor" folder https://review.openstack.org/486927 | 06:35 |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: Doc Migration: move the developer guide documents under the "contributor" folder https://review.openstack.org/486927 | 06:38 |
| openstackgerrit | Rajat Sharma proposed openstack/python-vitrageclient master: Replaces yaml.load() with yaml.safe_load() https://review.openstack.org/487299 | 06:43 |
| openstackgerrit | Eylon Malin proposed openstack/vitrage master: listener_service - enable listen to multiple topics + specify exchange name https://review.openstack.org/486967 | 07:01 |
| *** yujunz has joined #openstack-vitrage | 07:36 | |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: DO NOT MERGE - Disable swift services in Vitrage devstack https://review.openstack.org/487311 | 07:41 |
| *** yujunz has quit IRC | 07:54 | |
| *** yujunz has joined #openstack-vitrage | 08:01 | |
| *** efoley has joined #openstack-vitrage | 08:23 | |
| *** efoley_ has joined #openstack-vitrage | 08:24 | |
| *** efoley has quit IRC | 08:24 | |
| *** efoley_ is now known as efoley | 08:35 | |
| yujunz | ifat_afek it seems some implemented blueprint are not marked in Pike series. e.g. https://blueprints.launchpad.net/vitrage/+spec/not-operator-support | 08:42 |
| yujunz | I'm trying to get an overview of the Pike release for downstream development in ZTE | 08:42 |
| ifat_afek | You are right, thanks! | 08:42 |
| ifat_afek | I went over that list more than once, and somehow missed it… | 08:43 |
| ifat_afek | yujunz: makes sense | 08:44 |
| ifat_afek | Let me know if you have any other questions, or find other mismatches… | 08:44 |
| yujunz | Sure | 08:45 |
| ifat_afek | yujunz: I’m trying to see the effect of your healthcheck change in my environment. Before the change I had: passed=True, status_code=200. | 08:49 |
| yujunz | Yes | 08:49 |
| ifat_afek | After the change I get: detailed=False, reasons=[] | 08:49 |
| ifat_afek | Why is it better? | 08:49 |
| ifat_afek | To me it sounds like a “False” healthcheck, i.e. indicates a problem... | 08:50 |
| yujunz | OK. That it what returned from healthcheck api... | 08:51 |
| ifat_afek | Do other projects have something else? is there a standard? | 08:52 |
| yujunz | No, I think it is up to the client for the display | 08:53 |
| ifat_afek | So why do you think that displaying the original message is better? to me it doesn’t look so clear | 08:54 |
| yujunz | I think the main difference is when you have an error | 08:55 |
| yujunz | Because "details" and "reasons" will be hidden from user | 08:55 |
| yujunz | And you don't get enough information on the health status | 08:55 |
| ifat_afek | What chould be written in details, other than false? | 08:56 |
| ifat_afek | could | 08:56 |
| yujunz | details: True, reasons=[..., ...] | 08:56 |
| yujunz | When you have details, the reasons will be filled | 08:56 |
| ifat_afek | So, you are saying there could be three cases: | 08:57 |
| ifat_afek | 1. All is ok, details = False | 08:57 |
| ifat_afek | 2. problem, details=blabla, reasons=blabla2 | 08:57 |
| ifat_afek | 3. exception | 08:57 |
| ifat_afek | So why not write “pass”=True and also the details and reasons? or write the details and reasons if not passed? | 08:58 |
| ifat_afek | I just think it’s confusing this way, to call healthcheck and see “False” | 08:58 |
| yujunz | OK, that make sense. | 08:59 |
| yujunz | I'll check oslo.middleware.healthcheck again and update the patch | 09:00 |
| yujunz | It supposed to give "OK" in reasons as described in https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/__init__.py#L90 | 09:03 |
| yujunz | Not sure why an empty array is returned, ifat_afek | 09:03 |
| ifat_afek | Could be a problem in my env then | 09:04 |
| ifat_afek | my devstack is a bit old | 09:05 |
| ifat_afek | Is it running well in your env? | 09:05 |
| yujunz | No, I mean it could be an issue in oslo.middleware.healthcheck | 09:05 |
| yujunz | So I'll try to dig and let you know what could be the best solution. | 09:05 |
| ifat_afek | Ok, thanks | 09:05 |
| ifat_afek | And again, if it is working in your env then I’m fine with it | 09:06 |
| yujunz | OK, got it. If it is an upstream issue, I'll try to propose a patch in oslo before changing in vitrage. | 09:06 |
| openstackgerrit | Merged openstack/vitrage-dashboard master: Update the documentation link for doc migration https://review.openstack.org/486897 | 09:06 |
| yujunz | An empty reason does look confusing | 09:07 |
| openstackgerrit | Merged openstack/vitrage-dashboard master: Doc Migration: move the developer guide under doc/source/contributor folder https://review.openstack.org/486957 | 09:07 |
| ifat_afek | Thanks | 09:07 |
| yujunz | You are welcome | 09:08 |
| *** zengjianfang has joined #openstack-vitrage | 09:11 | |
| *** zengjianfang has quit IRC | 09:12 | |
| openstackgerrit | Merged openstack/python-vitrageclient master: Move osprofiler help message to the end of output https://review.openstack.org/486960 | 09:12 |
| *** yujunz has quit IRC | 09:14 | |
| *** ifat_afek has quit IRC | 09:21 | |
| openstackgerrit | Yujun Zhang proposed openstack/vitrage master: Add osprofiler support for RPC, api controllers and handlers https://review.openstack.org/485486 | 09:46 |
| *** ifat_afek has joined #openstack-vitrage | 09:58 | |
| *** ifat_afek has quit IRC | 10:04 | |
| *** XueFeng has joined #openstack-vitrage | 11:17 | |
| openstackgerrit | Yujun Zhang proposed openstack/vitrage master: Add default backend for healthcheck https://review.openstack.org/487388 | 12:06 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-vitrageclient master: Updated from global requirements https://review.openstack.org/485888 | 12:34 |
| *** efoley has quit IRC | 12:47 | |
| *** ifat_afek has joined #openstack-vitrage | 12:48 | |
| *** efoley has joined #openstack-vitrage | 12:50 | |
| *** ifat_afek has left #openstack-vitrage | 13:01 | |
| *** ifat_afek has joined #openstack-vitrage | 13:01 | |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: DO NOT MERGE - Disable swift services in Vitrage devstack https://review.openstack.org/487311 | 13:34 |
| *** aasmith has joined #openstack-vitrage | 13:43 | |
| openstackgerrit | Merged openstack/vitrage master: Add osprofiler support for RPC, api controllers and handlers https://review.openstack.org/485486 | 14:04 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/vitrage master: Updated from global requirements https://review.openstack.org/486438 | 14:09 |
| openstackgerrit | Merged openstack/python-vitrageclient master: Doc Migration: move the developer guide docs under contributor folder https://review.openstack.org/486993 | 14:10 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-vitrageclient master: Updated from global requirements https://review.openstack.org/485888 | 14:23 |
| openstackgerrit | Yujun Zhang proposed openstack/vitrage master: Add default backend for healthcheck https://review.openstack.org/487388 | 14:54 |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: DO NOT MERGE - Disable swift services in Vitrage devstack https://review.openstack.org/487311 | 15:22 |
| openstackgerrit | Ifat Afek proposed openstack/vitrage master: Doc Migration: move the developer guide documents under the "contributor" folder https://review.openstack.org/486927 | 16:05 |
| *** ifat_afek has quit IRC | 16:55 | |
| openstackgerrit | Matthew Thode proposed openstack/vitrage master: don't merge this https://review.openstack.org/487567 | 19:25 |
| *** aasmith has quit IRC | 20:34 | |
| *** efoley has quit IRC | 21:24 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!