Monday, 2018-06-18

*** e0ne has joined #openstack-vitrage04:11
*** e0ne has quit IRC04:13
*** ifat_afek has joined #openstack-vitrage04:40
*** ifat_afek has quit IRC04:43
*** bobh has joined #openstack-vitrage05:17
*** e0ne has joined #openstack-vitrage05:19
*** e0ne has quit IRC05:22
*** bobh has quit IRC05:41
*** ifat_afek has joined #openstack-vitrage06:54
*** brault has joined #openstack-vitrage07:00
*** brault has quit IRC07:01
openstackgerritIfat Afek proposed openstack/vitrage master: Prometheus datasource  https://review.openstack.org/56609107:13
*** brault has joined #openstack-vitrage07:17
openstackgerritMerged openstack/vitrage-tempest-plugin master: Fixed a bug that occasionally causes the tempest tests to fail  https://review.openstack.org/57544207:34
*** ifat_afek has quit IRC07:56
*** ifat_afek has joined #openstack-vitrage07:57
*** ifat_afek has quit IRC07:57
*** e0ne has joined #openstack-vitrage08:03
*** sq4ind has joined #openstack-vitrage08:06
*** e0ne has quit IRC08:07
openstackgerritOleksiy Petrenko proposed openstack/vitrage master: [WIP] Add ability to upgrade db  https://review.openstack.org/57515008:10
openstackgerritIdan Hefetz proposed openstack/vitrage-specs master: Add proposal "Vitage high availability - fast failover"  https://review.openstack.org/57537908:24
*** eyalb has joined #openstack-vitrage08:28
*** e0ne has joined #openstack-vitrage08:46
openstackgerritIvan Kolodyazhny proposed openstack/vitrage master:  Add upgrade support for Vitrage  https://review.openstack.org/57511509:20
openstackgerritOleksiy Petrenko proposed openstack/vitrage master: [WIP] Add ability to upgrade db  https://review.openstack.org/57515009:33
openstackgerritMerged openstack/vitrage master: Prometheus datasource  https://review.openstack.org/56609109:38
openstackgerritOleksiy Petrenko proposed openstack/vitrage master: [WIP] Add ability to upgrade db  https://review.openstack.org/57515009:43
opetrenko_Hello folks10:10
opetrenko_I want to ask you about vitrage models10:10
eyalbhi10:11
opetrenko_They are pretty strange. Everything is inherited from VitrageBase. Some models are explicitly inherited from oslo's TimeMixin. But VitrageBase is also inherited from TimeMixin. Therefore I have a question. Why do we inherit every model from TimeMixin, if we need them only in some models?10:13
eyalbHi, I need to ask the guy that wrote it but I think that we looked at other openstack projects and used the same concept if you think that this is wrong you can submit a patch10:16
eyalbnow that i look at it it looks redundant I assume we can just inherit from VitrageBase10:22
eyalbwhen webhook feature was added They added TimeStampMixin to base but forgot to remove it from other models :-(10:26
eyalbgood catch :-)10:26
e0neupdated_at fields are extremely useful during troubleshooting, so it would be good to use it for every mutable models10:29
eyalbyes but there is no need to inherit it twice10:30
e0neeyalb: +110:31
e0nebase grenade job is ready https://review.openstack.org/57511510:36
e0neit's still needed to add some tests10:36
eyalbok10:36
openstackgerritMerged openstack/vitrage master: don't expose exception info on http response  https://review.openstack.org/57536310:54
*** ifat_afek has joined #openstack-vitrage12:10
*** bobh has joined #openstack-vitrage12:55
*** eyalb has quit IRC13:05
*** eyalb has joined #openstack-vitrage13:05
*** eyalb has quit IRC13:06
*** eyalb has joined #openstack-vitrage13:07
*** bobh has quit IRC13:29
*** eyalb has quit IRC13:42
*** bobh has joined #openstack-vitrage13:53
*** sq4ind has quit IRC14:12
*** sq4ind has joined #openstack-vitrage14:15
*** sq4ind has quit IRC14:33
openstackgerritIfat Afek proposed openstack/vitrage-tempest-plugin master: Add a tempest test for the --all-tenants bug.  https://review.openstack.org/57615914:55
*** sq4ind has joined #openstack-vitrage15:09
*** bobh has quit IRC15:10
*** sq4ind has quit IRC15:16
openstackgerritIfat Afek proposed openstack/python-vitrageclient master: Remove mox3 from lower-constraints  https://review.openstack.org/57616615:17
openstackgerritIfat Afek proposed openstack/vitrage master: Remove mox from lower-constraints.txt  https://review.openstack.org/57616715:19
openstackgerritIfat Afek proposed openstack/vitrage-tempest-plugin master: Add a tempest test for the --all-tenants bug.  https://review.openstack.org/57615915:24
*** e0ne has quit IRC15:54
*** bobh has joined #openstack-vitrage15:54
openstackgerritIfat Afek proposed openstack/vitrage master: Dummy change to test a new tempest  https://review.openstack.org/57619716:04
*** bobh has quit IRC16:48
*** ifat_afek has quit IRC17:05
*** e0ne has joined #openstack-vitrage17:53
*** e0ne has quit IRC20:02
*** e0ne has joined #openstack-vitrage20:12
*** e0ne has quit IRC20:18
*** ifat_afek has joined #openstack-vitrage20:50
*** ifat_afek has quit IRC20:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!