*** bobh has joined #openstack-vitrage | 00:00 | |
*** bobh has quit IRC | 01:37 | |
*** e0ne has joined #openstack-vitrage | 05:13 | |
*** eyalb has joined #openstack-vitrage | 05:54 | |
*** openstackgerrit has quit IRC | 06:04 | |
*** e0ne has quit IRC | 06:08 | |
*** ifat_afek has joined #openstack-vitrage | 06:34 | |
*** e0ne has joined #openstack-vitrage | 08:05 | |
*** brault has quit IRC | 08:57 | |
*** openstackgerrit has joined #openstack-vitrage | 09:02 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Add upgrade support for Vitrage https://review.openstack.org/575115 | 09:02 |
---|---|---|
*** opetrenko_ has quit IRC | 09:10 | |
*** opetrenko_ has joined #openstack-vitrage | 09:10 | |
*** brault has joined #openstack-vitrage | 09:13 | |
openstackgerrit | Merged openstack/vitrage-tempest-plugin master: Added a debug message to help fix a tempest failure https://review.openstack.org/576499 | 09:52 |
openstackgerrit | Merged openstack/vitrage master: Remove mox from lower-constraints.txt https://review.openstack.org/576167 | 11:19 |
*** bobh has joined #openstack-vitrage | 12:13 | |
openstackgerrit | Ifat Afek proposed openstack/python-vitrageclient master: Fixed the template add cli documentation https://review.openstack.org/578093 | 13:04 |
*** bobh has quit IRC | 13:29 | |
ifat_afek | eOne: Hi | 13:30 |
ifat_afek | e0ne: Hi | 13:30 |
*** e0ne has quit IRC | 13:39 | |
*** e0ne has joined #openstack-vitrage | 13:44 | |
e0ne | ifat_afek: hi | 13:45 |
ifat_afek | Hi :-) eyalb and I wanted to better understand the state of the upgrade changes | 13:46 |
ifat_afek | There are three changes | 13:46 |
ifat_afek | 1. your change 2. opetrenko_ change 3. refactoring the conf | 13:46 |
e0ne | sure, just ask it:) | 13:46 |
ifat_afek | Is there a dependency between them? we understand that 2 depends on 3. What about 1? | 13:47 |
e0ne | the ideal workflow is something like: fix conf stuff => db upgrades => granade => granade with tests | 13:48 |
ifat_afek | So should we wait with #1 approval until 2 and 3 are merged? | 13:49 |
e0ne | but since we're limited with time and resources, I prefer to do some tasks in parallel to not block others with 'depends on' tag | 13:49 |
e0ne | technically, my change it independent on others | 13:49 |
e0ne | it adds basic checks that vitrage could be upgraded from Queens to Rocky | 13:50 |
ifat_afek | And these checks should work even if there is no upgrade yet? | 13:50 |
e0ne | honestly, this change does upgrade :) | 13:51 |
e0ne | we just could not be sure that everything works as expected | 13:51 |
e0ne | by these words I mean | 13:51 |
e0ne | 1)we don't check db migrations if any | 13:51 |
*** eyalb has quit IRC | 13:52 | |
e0ne | 2) we don't have tests which verify that some resources created in Queens are available in Rocky | 13:52 |
e0ne | I'm going to implement these checks a bit later | 13:52 |
e0ne | maybe after rocky-3 milestone :( | 13:53 |
e0ne | but here is a list what my change with grenade tests: | 13:53 |
openstackgerrit | Merged openstack/python-vitrageclient master: Fixed the template add cli documentation https://review.openstack.org/578093 | 13:53 |
e0ne | 1) new vitrage with old config - it means we don't break backward compatibility | 13:54 |
e0ne | 2) at least 'db sync' commad works during Q->R upgrade w/o issues | 13:55 |
ifat_afek | So what is the part of opetrenko_’s change? | 13:56 |
e0ne | it'll allow us to test that db migrations work as expected including data migration. E.g. data is not corrupted after migration, we can do migrate with some data in the DB and it's tested | 13:57 |
ifat_afek | Ok. Sounds good | 13:58 |
ifat_afek | So it makes sense to merge your change even if it has only partial implementation | 13:58 |
ifat_afek | Thanks | 13:58 |
e0ne | https://governance.openstack.org/tc/reference/tags/assert_supports-upgrade.html#requirements - #3 is related to db migrations | 13:58 |
e0ne | ifat_afek: np. thanks for supporting this effort | 13:59 |
ifat_afek | Of course :-) | 13:59 |
e0ne | ifat_afek: I didn't say it explicitly, but this is only about 'cold' upgrades with services downtime | 13:59 |
e0ne | live upgrades or rolling upgrades is a different feature | 14:00 |
ifat_afek | Much more complicated probably… | 14:00 |
ifat_afek | So the ‘supports-upgrade’ tag is for cold upgrades? | 14:00 |
e0ne | yep | 14:01 |
ifat_afek | Cool | 14:01 |
e0ne | there is other tag https://governance.openstack.org/tc/reference/tags/assert_supports-rolling-upgrade.html for live upgrades | 14:01 |
ifat_afek | Thanks for the info | 14:02 |
e0ne | you're welcome :) | 14:02 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Add upgrade support for Vitrage https://review.openstack.org/575115 | 14:17 |
*** e0ne has quit IRC | 14:23 | |
*** e0ne has joined #openstack-vitrage | 14:26 | |
*** bobh has joined #openstack-vitrage | 14:40 | |
*** e0ne has quit IRC | 15:07 | |
*** e0ne has joined #openstack-vitrage | 15:11 | |
*** e0ne has quit IRC | 16:09 | |
*** e0ne has joined #openstack-vitrage | 16:13 | |
*** e0ne has quit IRC | 16:35 | |
*** ifat_afek has quit IRC | 16:50 | |
*** e0ne has joined #openstack-vitrage | 17:11 | |
*** e0ne has quit IRC | 17:18 | |
*** e0ne has joined #openstack-vitrage | 19:52 | |
*** e0ne has quit IRC | 20:15 | |
*** aasmith has quit IRC | 20:16 | |
*** aasmith has joined #openstack-vitrage | 20:50 | |
*** bobh has quit IRC | 22:07 | |
*** bobh has joined #openstack-vitrage | 23:08 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!