| *** bobh has joined #openstack-vitrage | 03:35 | |
| *** bobh has quit IRC | 03:41 | |
| *** eyalb has joined #openstack-vitrage | 06:21 | |
| *** e0ne has joined #openstack-vitrage | 07:10 | |
| *** ifat_afek has joined #openstack-vitrage | 07:23 | |
| *** openstackgerrit has joined #openstack-vitrage | 07:24 | |
| openstackgerrit | Idan Hefetz proposed openstack/vitrage master: WIP - Api performance enhancements https://review.openstack.org/620795 | 07:24 |
|---|---|---|
| openstackgerrit | Idan Hefetz proposed openstack/vitrage master: WIP - Api performance enhancements https://review.openstack.org/619623 | 07:24 |
| e0ne | ifat_afek: hi. do you know if Idan usually connected to IRC? I've got some questions according his patch | 09:01 |
| eyalb | I told him to connect | 09:02 |
| *** idan_hefetz has joined #openstack-vitrage | 09:03 | |
| idan_hefetz | Hi! | 09:03 |
| idan_hefetz | whats up? | 09:03 |
| e0ne | eyalb: thanks | 09:04 |
| e0ne | idan_hefetz: I | 09:04 |
| idan_hefetz | hi e0ne | 09:04 |
| e0ne | idan_hefetz: I'm looking on your patch with API performance improvements | 09:04 |
| idan_hefetz | cool, thanks, still in progress though | 09:05 |
| e0ne | I"m worried about garbage collector configuration | 09:05 |
| idan_hefetz | OK, i will try to explain the logic | 09:05 |
| e0ne | it could lead to some performance issue during garbage collecting | 09:06 |
| idan_hefetz | On a large scale environment - topology returns large amounts of data that is a single string that is very big. I wanted to configure the GC to collect even if there is only one collectable object. this is done only in vitrage-api service | 09:08 |
| e0ne | do you have an example of such data? | 09:09 |
| idan_hefetz | I have tested this on a large scale, and it prevents vitrage-api memory usage to create large peaks for every api (a peak of additional 1-2 gb) | 09:10 |
| e0ne | I understand the reason and the root cause | 09:11 |
| e0ne | the issues is we'll have GC.collect call on the each API which could lead to high CPU usage | 09:12 |
| e0ne | can we use weakref instead of tweaking GC? | 09:13 |
| idan_hefetz | Memory is mainly used and held by oslo.messaging | 09:13 |
| idan_hefetz | Also i'm not very familiar with weak ref | 09:14 |
| idan_hefetz | Are you worried about the "gc.set_threshold(1, 1, 1)" or about the gc.collect() per each API? or both :)? | 09:15 |
| e0ne | I'm worried about both of these calls | 09:16 |
| idan_hefetz | I have not thought of all the implications of these, but I feel comfortable as these are only in vitrage-api and I have tested it under load. | 09:18 |
| e0ne | did you measure CPU usage and API response time too? | 09:19 |
| idan_hefetz | I measured API response time, which this commit is mostly about | 09:20 |
| idan_hefetz | I think the GC does not have allot of objects to collect, problem is the we have few large objects that need to be collected. | 09:21 |
| idan_hefetz | So it shouldn't work to hard. | 09:22 |
| idan_hefetz | too | 09:22 |
| e0ne | sounds reasonable | 09:22 |
| idan_hefetz | OK, cheers, alyway I will look into weakref and consider if it can be of use here.. | 09:25 |
| e0ne | thanks. I'll test your patch later this week | 09:26 |
| idan_hefetz | That'll be great, thanks! | 09:27 |
| *** idan_hefetz has quit IRC | 10:01 | |
| *** ifat_afek has quit IRC | 10:06 | |
| *** ifat_afek has joined #openstack-vitrage | 11:06 | |
| *** e0ne has quit IRC | 12:53 | |
| *** ifat_afek has quit IRC | 12:57 | |
| *** e0ne has joined #openstack-vitrage | 13:31 | |
| *** bobh has joined #openstack-vitrage | 14:09 | |
| openstackgerrit | Idan Hefetz proposed openstack/vitrage master: WIP - Api performance enhancements https://review.openstack.org/619623 | 14:59 |
| *** eyalb has quit IRC | 15:19 | |
| *** e0ne has quit IRC | 16:26 | |
| *** e0ne has joined #openstack-vitrage | 16:38 | |
| *** e0ne has quit IRC | 16:48 | |
| openstackgerrit | Merged openstack/vitrage master: Bug fix: delete outdated entities for OpenStack datasources https://review.openstack.org/619566 | 16:55 |
| *** bobh has quit IRC | 18:12 | |
| *** e0ne has joined #openstack-vitrage | 20:20 | |
| *** e0ne has quit IRC | 20:30 | |
| *** ifat_afek has joined #openstack-vitrage | 21:26 | |
| *** ifat_afek has quit IRC | 22:01 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!