| openstackgerrit | hewei proposed openstack/vitrage master: validate static configuration https://review.openstack.org/637660 | 02:00 |
|---|---|---|
| *** irclogbot_3 has quit IRC | 04:55 | |
| *** e0ne has joined #openstack-vitrage | 06:25 | |
| *** e0ne has quit IRC | 06:26 | |
| *** eyalb1 has joined #openstack-vitrage | 06:50 | |
| *** ifat_afek has joined #openstack-vitrage | 07:05 | |
| *** e0ne has joined #openstack-vitrage | 07:23 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: WIP. Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 07:37 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Do not review. One more tempest change test https://review.openstack.org/637617 | 07:37 |
| openstackgerrit | Idan Hefetz proposed openstack/vitrage master: Remove end messages https://review.openstack.org/637553 | 07:38 |
| openstackgerrit | Eyal proposed openstack/vitrage-tempest-plugin master: removed skipped tests https://review.openstack.org/637720 | 08:05 |
| *** e0ne has quit IRC | 08:13 | |
| openstackgerrit | Merged openstack/vitrage master: fix minor spelling mistakes https://review.openstack.org/637496 | 08:33 |
| *** e0ne has joined #openstack-vitrage | 09:53 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use admin credentials for vitrageclient from tempest.conf https://review.openstack.org/637545 | 09:57 |
| openstackgerrit | Merged openstack/vitrage master: optimize aodh/ceilometer/kubernetes datasource https://review.openstack.org/637484 | 09:57 |
| openstackgerrit | Merged openstack/vitrage-tempest-plugin master: removed skipped tests https://review.openstack.org/637720 | 10:00 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 10:03 |
| e0ne | ifat_afek: btw, do you use vitrage tempest plugin in your CI? | 10:07 |
| e0ne | I'm wondering if somebody uses environment variables during tests https://github.com/openstack/vitrage-tempest-plugin/blob/master/vitrage_tempest_plugin/tests/utils.py#L101-L102 | 10:09 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 10:09 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: WIP. Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 10:09 |
| openstackgerrit | Merged openstack/python-vitrageclient master: add python 3.7 unit test job https://review.openstack.org/637787 | 10:11 |
| e0ne | if somebody wants to review my tempest changes - tests results are available here: https://etherpad.openstack.org/p/vitrage-tempest-tests-check | 10:17 |
| e0ne | I tested everything except the last patch | 10:17 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use Tempest config https://review.openstack.org/627016 | 10:47 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use Tempest config for user sessions https://review.openstack.org/637509 | 10:47 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use admin credentials for vitrageclient from tempest.conf https://review.openstack.org/637545 | 10:47 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 10:47 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 10:48 |
| ifat_afek | e0ne: thanks, looking now | 10:52 |
| e0ne | ifat_afek: thanks! | 10:52 |
| e0ne | I'll leave some vitrage usage for now. E.g.: from vitrage.graph import Vertex | 10:53 |
| e0ne | but it should not block me during further vitrage development | 10:53 |
| ifat_afek | ok, no problem | 10:53 |
| e0ne | I just noticed that some patches refer to incorrect story in the commit message, I'll fix it once CI pass to not schedule new run | 10:55 |
| ifat_afek | om | 10:56 |
| ifat_afek | ok | 10:56 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Finally remove vitrage.conf usage https://review.openstack.org/637819 | 10:56 |
| e0ne | eyalb1: hi are you around? | 11:27 |
| eyalb1 | yes | 11:28 |
| e0ne | eyalb1: first of all, thanks for review | 11:28 |
| e0ne | https://review.openstack.org/#/c/637545/7/vitrage_tempest_plugin/tests/api/resources/test_resources.py | 11:28 |
| eyalb1 | e0ne: my pleasure | 11:29 |
| e0ne | since, we've got other user here, API returns instance, network, port, host, zone and cluster | 11:30 |
| e0ne | I can change to use non-admin user for that test and see what happens | 11:31 |
| e0ne | eyalb1: what's the best way to do it for this test? | 11:31 |
| eyalb1 | e0ne: maybe we should check both cases and see what is returned | 11:32 |
| e0ne | makes sense. I'll do it a bit later today | 11:32 |
| eyalb1 | e0ne: +2 | 11:33 |
| e0ne | it requires a bit more refactoring :( | 11:34 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use admin credentials for vitrageclient from tempest.conf https://review.openstack.org/637545 | 11:40 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 11:41 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 11:41 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 11:41 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 11:42 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Finally remove vitrage.conf usage https://review.openstack.org/637819 | 11:42 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Do not review. One more tempest change test https://review.openstack.org/637617 | 11:43 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Do not review. One more tempest change test https://review.openstack.org/637617 | 11:45 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Use admin credentials for vitrageclient from tempest.conf https://review.openstack.org/637545 | 12:14 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use keystoneclient from Vitrage https://review.openstack.org/637556 | 12:14 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Do not use OpenStack services clients from Vitrage https://review.openstack.org/637557 | 12:15 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage-tempest-plugin master: Finally remove vitrage.conf usage https://review.openstack.org/637819 | 12:15 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/vitrage master: Do Not Review. Test tempest changes https://review.openstack.org/612652 | 12:16 |
| e0ne | eyalb1: I've added todo and a proper comment for that patch. fix require a lot of refactoring of novaclient usage :( | 12:18 |
| e0ne | eyalb1: I would like to do it in a separate patch, if you are agree with this approach | 12:18 |
| eyalb1 | e0ne: ok | 12:19 |
| e0ne | also, I marked the first patch of the chain as WIP to not merge it until CI passes for all chain | 12:20 |
| eyalb1 | ok | 12:21 |
| eyalb1 | when you finish let us know | 12:21 |
| e0ne | it's less complex than adding temporary vitrage patch per each tempest change | 12:21 |
| eyalb1 | so the last issue of seperating the vitrage from tempest is the graph issue ? | 12:22 |
| e0ne | eyalb1: it's safe to review and even approve any patch. I put -2 on the first one, so it will block any other to merge | 12:22 |
| e0ne | eyalb1: yes, but I don't have a time for it now:( | 12:23 |
| e0ne | maybe I'll find some resources in my team | 12:23 |
| eyalb1 | i will look at it and think of a solution | 12:23 |
| e0ne | thanks | 12:23 |
| e0ne | ideally, we need to work with json only to verify that API returns correct data | 12:24 |
| openstackgerrit | Merged openstack/vitrage master: add python 3.7 unit test job https://review.openstack.org/637784 | 13:37 |
| *** smrcascao has joined #openstack-vitrage | 13:45 | |
| *** amorin has quit IRC | 13:50 | |
| *** smrcascao has quit IRC | 13:56 | |
| *** smrcascao has joined #openstack-vitrage | 14:06 | |
| *** smrcascao has quit IRC | 14:36 | |
| *** e0ne has quit IRC | 16:00 | |
| *** e0ne has joined #openstack-vitrage | 16:03 | |
| *** eyalb1 has quit IRC | 16:11 | |
| *** smrcascao has joined #openstack-vitrage | 16:49 | |
| *** smrcascao has quit IRC | 16:49 | |
| *** smrcascao has joined #openstack-vitrage | 16:51 | |
| *** e0ne has quit IRC | 17:35 | |
| *** ifat_afek has quit IRC | 18:10 | |
| *** smrcascao has quit IRC | 18:10 | |
| *** e0ne has joined #openstack-vitrage | 18:41 | |
| *** e0ne has quit IRC | 18:42 | |
| *** e0ne has joined #openstack-vitrage | 18:54 | |
| *** e0ne has quit IRC | 19:39 | |
| *** e0ne has joined #openstack-vitrage | 19:39 | |
| *** e0ne has quit IRC | 19:45 | |
| *** openstackgerrit has quit IRC | 20:09 | |
| *** e0ne has joined #openstack-vitrage | 20:37 | |
| *** e0ne has quit IRC | 21:28 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!