*** huntxu has joined #openstack-vpnaas | 01:21 | |
hoangcx | huntxu: I +2 for your patches. | 01:56 |
---|---|---|
hoangcx | huntxu: Will as yamamoto for another round of reviews when he is online. | 01:57 |
hoangcx | huntxu: Especially for https://bugs.launchpad.net/neutron/+bug/1747654 | 01:57 |
openstack | Launchpad bug 1747654 in neutron "VPNaaS: enable sha384/sha512 auth algorithms for *Swan drivers" [Medium,In progress] - Assigned to Hunt Xu (huntxu) | 01:57 |
amotoki | huntxu: hoangcx: which patch are you talking about? | 02:23 |
hoangcx | amotoki: Just a moment | 02:23 |
hoangcx | amotoki: https://review.openstack.org/#/c/535208/ https://review.openstack.org/#/c/541250/ https://review.openstack.org/#/c/495284/ | 02:24 |
amotoki | hoangcx: thanks. | 02:24 |
hoangcx | amotoki: those patches are needed for fixing bug 1747654 | 02:24 |
openstack | bug 1747654 in neutron "VPNaaS: enable sha384/sha512 auth algorithms for *Swan drivers" [Medium,In progress] https://launchpad.net/bugs/1747654 - Assigned to Hunt Xu (huntxu) | 02:24 |
hoangcx | amotoki: huntxu is going to update patch 495284 | 02:25 |
amotoki | hoangcx: I think it is better to land them until RC1 is shipped. | 02:26 |
amotoki | hoangcx: adding sha384/512 sounds a mini feature | 02:26 |
hoangcx | amotoki: Yes. We just need to unblock current validated code | 02:27 |
amotoki | hoangcx: what do you mean by "unblock"? | 02:27 |
hoangcx | amotoki: current our code base have a validator code to restrict support sh384/sha512 for *Swan driver. See https://review.openstack.org/#/c/393702/ | 02:29 |
amotoki | hoangcx: got it. | 02:31 |
amotoki | hoangcx: is it okay to land them for Rocky? | 02:31 |
hoangcx | amotoki: Yes. There is no problem for me | 02:32 |
amotoki | hoangcx: until the master branch is open for Rocky, we need to be careful on landing patches. merging patches means they are included in RC1 | 02:33 |
amotoki | testing code can land anytime | 02:33 |
hoangcx | amotoki: I was asked about supporting sha512 auth algorithm for *Swan driver from other guy. But didn't get specific which cycle. | 02:33 |
hoangcx | amotoki: I see. | 02:34 |
hoangcx | amotoki: AFAIK, vpnaas is not released with milestone for this cycle. why do we need to care about RC1? (just curious question to understand more) | 03:04 |
openstackgerrit | Merged openstack/neutron-vpnaas master: Zuul: Remove project name https://review.openstack.org/541157 | 03:12 |
*** hoangcx has quit IRC | 03:14 | |
*** hoangcx has joined #openstack-vpnaas | 03:14 | |
*** ChanServ sets mode: +o hoangcx | 03:14 | |
amotoki | hoangcx: ah.. you are right. RC1 is not strictly applied to queens release. | 03:15 |
amotoki | hoangcx: it was originally released with cycle-with-milestone, but we missed the deadline for cycle-with-milestone in milestone-2 release | 03:16 |
amotoki | hoangcx: I forgot that, but I think it is better to use the same procedure to avoid confusions. this is the only reason to me. | 03:17 |
hoangcx | amotoki: Indeed. I was expected vpnaas be released with milestone but ... | 03:17 |
hoangcx | amotoki: OK, no problem for me, we can land them after Rocky is open | 03:18 |
amotoki | I think we need to cut a stable branch at some point. | 03:20 |
hoangcx | amotoki: +1 from me | 03:29 |
amotoki | I release neutron-vpnaas-dashboard and create a stable branch. I can propose a stable branch for vpnaas at the same time. | 03:30 |
hoangcx | amotoki: https://review.openstack.org/#/c/540455/ is it OK to approve ? | 03:35 |
hoangcx | amotoki: I just +W on it | 03:35 |
amotoki | hoangcx: thanks. | 03:35 |
*** yamamoto has joined #openstack-vpnaas | 03:38 | |
openstackgerrit | Merged openstack/neutron-vpnaas-dashboard master: Add VPN service: List only routers with external gateway https://review.openstack.org/540455 | 03:39 |
amotoki | hoangcx: https://review.openstack.org/542006 | 03:43 |
hoangcx | amotoki: thank you. Will +1 after zuul | 03:45 |
*** yamamoto_ has joined #openstack-vpnaas | 06:26 | |
*** yamamoto has quit IRC | 06:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/542056 | 07:12 |
amotoki | hoangcx: for translation import patches, you can approve with a single +2 if the job succeeds | 08:05 |
openstackgerrit | Merged openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/542056 | 08:10 |
hoangcx | amotoki: ack :) | 08:26 |
*** hoangcx has quit IRC | 08:56 | |
*** yamamoto has joined #openstack-vpnaas | 08:57 | |
*** yamamoto_ has quit IRC | 09:00 | |
*** hoangcx has joined #openstack-vpnaas | 09:02 | |
*** ChanServ sets mode: +o hoangcx | 09:02 | |
hoangcx | amotoki: BTW, I updated networking admin guide in neutron as your request :) | 09:03 |
openstackgerrit | Hunt Xu proposed openstack/neutron-vpnaas master: Add IPv6 VPNaaS scenario tests https://review.openstack.org/533172 | 10:41 |
*** huntxu has quit IRC | 11:48 | |
*** yamamoto has quit IRC | 14:34 | |
*** yamamoto has joined #openstack-vpnaas | 14:46 | |
*** yamamoto has quit IRC | 14:51 | |
openstackgerrit | OpenStack Release Bot proposed openstack/neutron-vpnaas-dashboard master: Update reno for stable/queens https://review.openstack.org/542252 | 15:11 |
openstackgerrit | OpenStack Release Bot proposed openstack/neutron-vpnaas master: Update reno for stable/queens https://review.openstack.org/542255 | 15:11 |
*** yamamoto has joined #openstack-vpnaas | 15:32 | |
*** yamamoto has quit IRC | 15:37 | |
*** yamamoto has joined #openstack-vpnaas | 15:44 | |
*** yamamoto has quit IRC | 15:44 | |
*** yamamoto has joined #openstack-vpnaas | 16:44 | |
*** openstackgerrit has quit IRC | 16:48 | |
*** yamamoto has quit IRC | 17:02 | |
*** ChanServ has quit IRC | 20:57 | |
*** ChanServ has joined #openstack-vpnaas | 21:32 | |
*** barjavel.freenode.net sets mode: +o ChanServ | 21:32 | |
*** yamamoto has joined #openstack-vpnaas | 21:32 | |
*** kektrain__ has joined #openstack-vpnaas | 23:18 | |
*** kektrain__ has left #openstack-vpnaas | 23:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!