| *** yamamoto has joined #openstack-vpnaas | 00:02 | |
| *** yamamoto has quit IRC | 00:08 | |
| *** yamamoto has joined #openstack-vpnaas | 01:04 | |
| *** yamamoto has quit IRC | 01:09 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/neutron-vpnaas-dashboard master: Show team and repo badges on README https://review.openstack.org/557564 | 01:13 |
|---|---|---|
| *** huntxu has joined #openstack-vpnaas | 01:20 | |
| *** yamamoto has joined #openstack-vpnaas | 02:05 | |
| *** yamamoto has quit IRC | 02:11 | |
| *** yamamoto has joined #openstack-vpnaas | 02:47 | |
| *** hoangcx has quit IRC | 04:25 | |
| *** hoangcx has joined #openstack-vpnaas | 04:28 | |
| *** ChanServ sets mode: +o hoangcx | 04:28 | |
| hoangcx | amotoki: hi, could you check and land this one? https://review.openstack.org/#/c/543394/ | 04:43 |
| hoangcx | amotoki: it got your +2 in the past | 04:44 |
| *** hoangcx has quit IRC | 04:50 | |
| *** hoangcx has joined #openstack-vpnaas | 04:51 | |
| *** ChanServ sets mode: +o hoangcx | 04:51 | |
| amotoki | hoangcx: one question https://review.openstack.org/#/c/543394/11/neutron_vpnaas/tests/unit/services/vpn/test_plugin.py | 05:19 |
| amotoki | hoangcx: do we need to maintain it or do we drop this in near future? | 05:20 |
| amotoki | hoangcx: if the former (need to maintain), I am not confident it should be skipped. | 05:20 |
| amotoki | yamamoto: https://review.openstack.org/#/c/555167/1/doc/source/conf.py@166 are you suggesting to drop all commented out things from conf.py? | 05:24 |
| amotoki | yamamoto: I cannot understand why you commented only on html_static_path. | 05:25 |
| amotoki | yamamoto: ooops..... you said 'uncomment' sorry | 05:25 |
| yamamoto | amotoki: i meant to specify html_static_path so that sample configs are copied to the output tree | 05:25 |
| amotoki | yamamoto: you are right. I completely forgot it | 05:27 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-vpnaas master: Improve docs to follow the standard structure https://review.openstack.org/555167 | 05:28 |
| hoangcx | amotoki: Which one do you suggest? | 05:28 |
| amotoki | hoangcx: i'd like to clarify the background of skipTest first? | 05:29 |
| hoangcx | amotoki: I don't see any plan to drop multiple drivers support. The problem is that only one driver (IPSEC_SERVICE_DRIVER) remain after the patch land. | 05:31 |
| amotoki | hoangcx: so, do you mean the test no longer works? | 05:32 |
| hoangcx | amotoki: So I tried to keep the code base and will update for new driver land in the further | 05:32 |
| hoangcx | amotoki: Yes, I think so | 05:32 |
| amotoki | hoangcx: okay, sounds reasonable to skip the test. | 05:32 |
| hoangcx | amotoki: Do I need to update the patch with TODO comment? | 05:33 |
| amotoki | hoangcx: I would suggest to add some comment like "we have only one driver in our codebase, so we cannot run the test successfully now" | 05:33 |
| hoangcx | amotoki: ++ | 05:33 |
| hoangcx | amotoki: I will update. Thank you :) | 05:34 |
| amotoki | hoangcx: TODO is optional, but we need to describe the reason clearly. we tend to forget the background so easily. | 05:34 |
| hoangcx | amotoki: Okay. I got it :) | 05:35 |
| yamamoto | it might make some sense to have a dummy driver. | 05:37 |
| amotoki | yamamoto: +1 | 05:38 |
| hoangcx | yamamoto: +1 but will be in separate patch | 05:53 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/neutron-vpnaas master: Remove unmaintained drivers https://review.openstack.org/543394 | 06:20 |
| *** yamamoto has quit IRC | 07:22 | |
| *** yamamoto has joined #openstack-vpnaas | 07:23 | |
| *** yamamoto_ has joined #openstack-vpnaas | 07:32 | |
| *** yamamoto has quit IRC | 07:34 | |
| *** hoangcx has quit IRC | 07:46 | |
| *** hoangcx has joined #openstack-vpnaas | 07:46 | |
| *** ChanServ sets mode: +o hoangcx | 07:46 | |
| openstackgerrit | Thomas Morin proposed openstack/neutron-vpnaas master: remove unused plugin.get_plugin_name() https://review.openstack.org/557670 | 10:17 |
| *** yamamoto has joined #openstack-vpnaas | 11:01 | |
| *** yamamoto_ has quit IRC | 11:05 | |
| *** hoangcx_ has joined #openstack-vpnaas | 13:24 | |
| *** huntxu has quit IRC | 14:46 | |
| *** hoangcx_ has quit IRC | 15:07 | |
| *** yamamoto has quit IRC | 16:04 | |
| *** yamamoto has joined #openstack-vpnaas | 16:07 | |
| *** yamamoto has quit IRC | 16:24 | |
| *** yamamoto has joined #openstack-vpnaas | 16:29 | |
| *** yamamoto has quit IRC | 16:34 | |
| *** yamamoto has joined #openstack-vpnaas | 17:30 | |
| *** yamamoto has quit IRC | 17:37 | |
| *** yamamoto has joined #openstack-vpnaas | 18:33 | |
| *** yamamoto has quit IRC | 18:38 | |
| *** yamamoto has joined #openstack-vpnaas | 19:35 | |
| *** yamamoto has quit IRC | 19:40 | |
| *** yamamoto has joined #openstack-vpnaas | 20:37 | |
| *** yamamoto has quit IRC | 20:42 | |
| *** yamamoto has joined #openstack-vpnaas | 21:38 | |
| *** yamamoto has quit IRC | 21:44 | |
| *** yamamoto has joined #openstack-vpnaas | 22:40 | |
| *** yamamoto has quit IRC | 22:45 | |
| *** yamamoto has joined #openstack-vpnaas | 23:41 | |
| *** yamamoto has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!