| *** yamamoto has joined #openstack-vpnaas | 00:12 | |
| *** yamamoto has quit IRC | 00:18 | |
| *** hoangcx has joined #openstack-vpnaas | 00:33 | |
| *** ChanServ sets mode: +o hoangcx | 00:33 | |
| *** huntxu has joined #openstack-vpnaas | 01:14 | |
| *** yamamoto has joined #openstack-vpnaas | 01:14 | |
| *** yamamoto has quit IRC | 01:20 | |
| *** yamamoto has joined #openstack-vpnaas | 02:16 | |
| *** yamamoto has quit IRC | 02:18 | |
| *** yamamoto has joined #openstack-vpnaas | 02:18 | |
| hoangcx | amotoki: hi, are you there? | 03:34 |
|---|---|---|
| hoangcx | amotoki: I have a question regarding to review policy in neutron subproject (like vpnaas) | 03:36 |
| hoangcx | amotoki: Is it OK to +W for a patch that got one +2 after long time (maybe > 2 weeks in idle status) same as horizon subproject? | 03:38 |
| hoangcx | amotoki: This one is an example: https://review.openstack.org/#/c/554445/ | 03:38 |
| hoangcx | amotoki: Or it requires to get at least 2 +2 before +W ? I'm a little bit confuse :) | 03:39 |
| hoangcx | yamamoto: ^^ Oops, I've realized that you are online too :) | 03:41 |
| amotoki | hoangcx: hi | 03:43 |
| amotoki | hoangcx: I think it is totally up to situations. | 03:44 |
| amotoki | hoangcx: two +2's is nice, but as you mentioned it sometimes/often? takes time to land patches if the number of active cores is small. | 03:45 |
| amotoki | hoangcx: for simple patches and if you are confident with changes I am fine to do that. actually horizon uses this model (though most patches are merged with two +2) | 03:45 |
| hoangcx | amotoki: indeed. two +2's is ideal. I am asking the exception in case number of active cores is small | 03:47 |
| amotoki | hoangcx: yeah, my criteria is "am I confident with this patch?" and "Am I confident with this? or I'd like to wait other opinions?" | 03:48 |
| yamamoto | my impression is that vpnaas has enough number of cores you can ping | 03:50 |
| hoangcx | amotoki: Okay. I understand the situation. Thanks for your clarification. | 03:50 |
| hoangcx | yamamoto: Oh thanks for your response. | 03:51 |
| hoangcx | yamamoto: I need your attention for following patch: https://review.openstack.org/#/c/554445/ and https://review.openstack.org/#/c/547347 | 03:52 |
| hoangcx | yamamoto: we need this at least in Rocky for our upgrading thing | 03:52 |
| hoangcx | yamamoto: Actually, I was ping you and amotoki sometime before but no response. I didn't know how to overcome this situation. That is the reason I want to ask for more detail to have a proper actions :) | 03:55 |
| hoangcx | yamamoto: and happy to hear from you | 03:55 |
| amotoki | hoangcx: sorry for slow responses. I was busy these weeks. | 04:00 |
| hoangcx | amotoki: Ah, no worries. I learn a lot from you guys (that is the reason i usually ask before perform some unsure thing) | 04:01 |
| openstackgerrit | Hunt Xu proposed openstack/neutron-vpnaas master: Switch non-experimental zuul jobs to zuul v3 native https://review.openstack.org/554445 | 05:19 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/564689 | 07:20 |
| openstackgerrit | Merged openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/564689 | 07:52 |
| openstackgerrit | Hunt Xu proposed openstack/neutron-vpnaas master: Switch tempest zuul job to zuul v3 native https://review.openstack.org/554445 | 08:33 |
| *** hoangcx has quit IRC | 10:37 | |
| *** yamamoto has quit IRC | 12:33 | |
| *** huntxu has quit IRC | 13:00 | |
| *** yamamoto has joined #openstack-vpnaas | 13:14 | |
| *** yamamoto has quit IRC | 13:14 | |
| *** yamamoto has joined #openstack-vpnaas | 13:18 | |
| openstackgerrit | Merged openstack/neutron-vpnaas master: Switch tempest zuul job to zuul v3 native https://review.openstack.org/554445 | 14:03 |
| *** yamamoto has quit IRC | 14:31 | |
| *** yamamoto has joined #openstack-vpnaas | 14:46 | |
| *** yamamoto has quit IRC | 14:58 | |
| *** yamamoto has joined #openstack-vpnaas | 15:07 | |
| *** yamamoto has quit IRC | 15:12 | |
| *** yamamoto has joined #openstack-vpnaas | 15:17 | |
| *** yamamoto has quit IRC | 15:35 | |
| *** yamamoto has joined #openstack-vpnaas | 16:36 | |
| *** yamamoto has quit IRC | 16:42 | |
| *** yamamoto has joined #openstack-vpnaas | 17:38 | |
| *** yamamoto has quit IRC | 17:43 | |
| *** yamamoto has joined #openstack-vpnaas | 18:40 | |
| *** yamamoto has quit IRC | 18:45 | |
| *** yamamoto has joined #openstack-vpnaas | 19:42 | |
| *** yamamoto has quit IRC | 19:47 | |
| *** yamamoto has joined #openstack-vpnaas | 20:43 | |
| *** yamamoto has quit IRC | 20:49 | |
| *** yamamoto has joined #openstack-vpnaas | 21:46 | |
| *** yamamoto has quit IRC | 21:52 | |
| *** yamamoto has joined #openstack-vpnaas | 22:47 | |
| *** yamamoto has quit IRC | 22:53 | |
| *** yamamoto has joined #openstack-vpnaas | 23:49 | |
| *** yamamoto has quit IRC | 23:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!