| *** jwcroppe has joined #openstack-watcher | 00:40 | |
| *** bzhou has joined #openstack-watcher | 01:20 | |
| *** thorst has joined #openstack-watcher | 01:40 | |
| *** thorst has quit IRC | 01:40 | |
| *** thorst has joined #openstack-watcher | 01:41 | |
| *** thorst has quit IRC | 02:04 | |
| *** thorst has joined #openstack-watcher | 02:08 | |
| *** thorst has quit IRC | 02:22 | |
| *** cjvolzka has joined #openstack-watcher | 02:33 | |
| *** cjvolzka has quit IRC | 02:33 | |
| *** jwcroppe has quit IRC | 03:05 | |
| *** jwcroppe has joined #openstack-watcher | 03:06 | |
| *** jwcroppe has quit IRC | 03:11 | |
| *** Kevin_Zheng has joined #openstack-watcher | 03:56 | |
| *** jwcroppe has joined #openstack-watcher | 04:08 | |
| *** thorst has joined #openstack-watcher | 04:11 | |
| *** thorst has quit IRC | 04:15 | |
| *** jwcroppe has quit IRC | 04:27 | |
| *** bzhou has quit IRC | 04:37 | |
| *** bzhou has joined #openstack-watcher | 04:43 | |
| *** jwcroppe has joined #openstack-watcher | 05:04 | |
| *** wznoinsk has quit IRC | 06:11 | |
| *** wznoinsk has joined #openstack-watcher | 06:12 | |
| *** thorst has joined #openstack-watcher | 06:13 | |
| *** thorst has quit IRC | 06:17 | |
| *** bzhou has quit IRC | 08:26 | |
| *** vincentfrancoise has joined #openstack-watcher | 08:28 | |
| *** brunograz has quit IRC | 08:34 | |
| *** bruno has joined #openstack-watcher | 08:40 | |
| *** bruno is now known as Guest74474 | 08:41 | |
| *** thorst has joined #openstack-watcher | 10:15 | |
| *** thorst has quit IRC | 10:20 | |
| *** aspiers has quit IRC | 10:43 | |
| *** bzhou has joined #openstack-watcher | 10:51 | |
| *** bzhou has quit IRC | 10:52 | |
| *** jwcroppe has quit IRC | 11:29 | |
| *** jwcroppe has joined #openstack-watcher | 11:32 | |
| *** jwcroppe has quit IRC | 11:36 | |
| *** thorst has joined #openstack-watcher | 12:15 | |
| *** thorst has quit IRC | 12:20 | |
| *** jwcroppe has joined #openstack-watcher | 12:33 | |
| *** jwcroppe has quit IRC | 12:50 | |
| sballe | Morning | 13:12 |
|---|---|---|
| *** thorst has joined #openstack-watcher | 13:36 | |
| *** thorst_ has joined #openstack-watcher | 13:37 | |
| *** thorst has quit IRC | 13:41 | |
| *** thorst_ has quit IRC | 13:44 | |
| *** thorst_ has joined #openstack-watcher | 13:45 | |
| *** thorst_ has quit IRC | 13:49 | |
| *** dtardivel has joined #openstack-watcher | 14:06 | |
| jed56 | https://review.openstack.org/#/c/248610/ | 14:07 |
| *** vmahe_ has joined #openstack-watcher | 14:08 | |
| *** cjvolzka has joined #openstack-watcher | 14:14 | |
| *** jwcroppe has joined #openstack-watcher | 14:47 | |
| *** wxy has quit IRC | 14:56 | |
| *** wxy has joined #openstack-watcher | 14:58 | |
| *** jwcroppe has quit IRC | 14:59 | |
| *** thorst_ has joined #openstack-watcher | 15:04 | |
| *** thorst_ has quit IRC | 15:05 | |
| *** thorst_ has joined #openstack-watcher | 15:06 | |
| *** thorst_ has quit IRC | 15:10 | |
| tpeoples | dtardivel: did you see my comment regarding the nova api version in nova_wrapper.py? not a big deal, just curious. everything else looks good | 15:39 |
| tpeoples | jed56: vincentfrancoise: did Zenzhan Zhou's comment regarding the conf file for https://review.openstack.org/#/c/248610/ ? | 15:52 |
| tpeoples | err did his comment get responded to** | 15:53 |
| *** wootehfoot has joined #openstack-watcher | 15:55 | |
| vincentfrancoise | tpeoples: I just pushed a new patchset with some more information following Zenzhan Zhou's comment (although I actually didn't answer to its comment) | 15:58 |
| *** aspiers has joined #openstack-watcher | 16:00 | |
| *** wootehfoot has quit IRC | 16:02 | |
| tpeoples | vincentfrancoise: so the answer to his question is probably no? if you manually put the plugin name under entry_points in setup.py, then it would be redundant to also put it in the watcher.conf file? but it probably makes more sense to put it in the conf file | 16:02 |
| *** wootehfoot has joined #openstack-watcher | 16:04 | |
| vincentfrancoise | tpeoples: uhoh! Seems like there's a mistake I didn't see here. It is supposed to be loaded only within the setup.py/setup.cfg and then automatically referenced within the ``[watcher_goals]`` section of ``watcher.conf``. | 16:09 |
| tpeoples | vincentfrancoise: ok that makes sense. before you respin, let me post my nits so you can address those real quick too | 16:10 |
| vincentfrancoise | tpeoples: ok thanks for the review :) | 16:11 |
| tpeoples | vincentfrancoise: posted, i will +2 once you respin | 16:18 |
| vincentfrancoise | tpeoples: ok I'm on it | 16:19 |
| *** wootehfoot has quit IRC | 16:21 | |
| *** wootehfoot has joined #openstack-watcher | 16:25 | |
| *** wxy has quit IRC | 16:27 | |
| *** wxy has joined #openstack-watcher | 16:28 | |
| *** jwcroppe has joined #openstack-watcher | 16:55 | |
| *** jwcroppe has quit IRC | 17:03 | |
| *** vincentfrancoise has quit IRC | 17:14 | |
| *** jwcroppe has joined #openstack-watcher | 17:17 | |
| *** aspiers_ has joined #openstack-watcher | 17:23 | |
| *** aspiers has quit IRC | 17:26 | |
| *** aspiers_ has quit IRC | 19:30 | |
| *** vmahe_ has quit IRC | 19:47 | |
| *** dtardivel has quit IRC | 20:07 | |
| *** wootehfoot has quit IRC | 20:48 | |
| *** thorst_ has joined #openstack-watcher | 22:21 | |
| *** thorst__ has joined #openstack-watcher | 22:22 | |
| *** cjvolzka has quit IRC | 22:23 | |
| *** thorst_ has quit IRC | 22:25 | |
| *** thorst__ has quit IRC | 22:26 | |
| *** thorst_ has joined #openstack-watcher | 22:27 | |
| *** thorst_ has quit IRC | 22:31 | |
| *** jwcroppe has quit IRC | 23:11 | |
| *** jwcroppe has joined #openstack-watcher | 23:13 | |
| *** jwcroppe has quit IRC | 23:17 | |
| *** jwcroppe has joined #openstack-watcher | 23:18 | |
| *** jwcroppe has quit IRC | 23:22 | |
| *** thorst has joined #openstack-watcher | 23:29 | |
| *** thorst has quit IRC | 23:36 | |
| *** jwcroppe has joined #openstack-watcher | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!