| *** thorst has joined #openstack-watcher | 00:05 | |
| *** wootehfoot has quit IRC | 00:38 | |
| *** harlowja has quit IRC | 01:30 | |
| *** harlowja has joined #openstack-watcher | 01:30 | |
| *** thorst has quit IRC | 03:09 | |
| *** jwcroppe_ has joined #openstack-watcher | 06:00 | |
| *** jwcroppe has quit IRC | 06:02 | |
| openstackgerrit | Taylor Peoples proposed openstack/watcher: WIP: Create OpenStackClients convenience class https://review.openstack.org/270039 | 07:33 |
|---|---|---|
| *** tkaczynski has joined #openstack-watcher | 07:48 | |
| *** dtardivel has joined #openstack-watcher | 08:08 | |
| *** vincentfrancoise has joined #openstack-watcher | 08:26 | |
| *** gabor_antal has joined #openstack-watcher | 10:57 | |
| *** vincentfrancoise has quit IRC | 11:40 | |
| *** openstackgerrit has quit IRC | 11:43 | |
| *** openstackgerrit has joined #openstack-watcher | 11:44 | |
| *** thorst has joined #openstack-watcher | 12:46 | |
| *** vincentfrancoise has joined #openstack-watcher | 13:01 | |
| *** bruno_ has joined #openstack-watcher | 13:22 | |
| *** bruno_ is now known as brunograz | 13:22 | |
| *** seanmurphy has joined #openstack-watcher | 13:37 | |
| seanmurphy | hey guys - we’re working on our specification | 13:37 |
| seanmurphy | which we will submit some variant today | 13:37 |
| *** vtech has joined #openstack-watcher | 13:39 | |
| acabot | seanmurphy : just in time ;-) | 13:53 |
| *** vtech has quit IRC | 13:56 | |
| *** seanmurphy has quit IRC | 13:56 | |
| acabot | we will start our weekly meeting in 4 minutes on #openstacl-meeting-4 | 13:57 |
| dtardivel | o/ | 13:59 |
| sballe | morning | 14:00 |
| sballe | acabot: I will only be able to participate in the meeting for the first 30 minutes because I have a personal commitment at 9:30 | 14:00 |
| *** jwcroppe_ is now known as jwcroppe | 14:01 | |
| *** seanmurphy has joined #openstack-watcher | 14:01 | |
| acabot | sballe: if you can talk about Intel staff changes in ancouncements so | 14:01 |
| *** vtech has joined #openstack-watcher | 14:02 | |
| sballe | ok | 14:02 |
| *** vtech has quit IRC | 14:03 | |
| *** vtech has joined #openstack-watcher | 14:03 | |
| *** thorst has quit IRC | 14:09 | |
| *** thorst has joined #openstack-watcher | 14:09 | |
| openstackgerrit | Merged openstack/watcher: Missing super() in API collection controllers https://review.openstack.org/269590 | 14:14 |
| openstackgerrit | Vincent Mahe proposed openstack/watcher: Add diagrams to the architecture doc page https://review.openstack.org/266461 | 14:14 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Fix Warnings generated while building of HTML docu https://review.openstack.org/268006 | 14:23 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Refactor Commands section https://review.openstack.org/268086 | 14:23 |
| *** thorst has quit IRC | 14:32 | |
| *** cjvolzka has joined #openstack-watcher | 14:34 | |
| *** vtech has quit IRC | 14:50 | |
| *** vtech_ has joined #openstack-watcher | 14:50 | |
| tpeoples | dtardivel: the request comes in and wsme_pecan converts the json body to an Audit object (https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/audit.py#L349). part of that conversion is grabbing the audit template (https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/audit.py#L87). in that method you can see we | 14:57 |
| tpeoples | just pass over the AuditTemplateNotFound exception. if we don't (i.e., let the exception through) and if we ever have any audit's with an audit template of None, then the audit list API would fail. | 14:57 |
| tpeoples | dtardivel: so as is with the pass on exception, we end up with an Audit object with an audit template of None. we could do an if check on the audit template field in the post() method, but we lose the context and can't tell the user what the UUID/name of the audit template that wasn't found was | 14:58 |
| *** seanmurphy has left #openstack-watcher | 15:04 | |
| *** seanmurphy has joined #openstack-watcher | 15:06 | |
| dtardivel | tpeoples: let me have a look on the code :) | 15:08 |
| *** thorst has joined #openstack-watcher | 15:08 | |
| *** thorst has quit IRC | 15:08 | |
| *** thorst has joined #openstack-watcher | 15:08 | |
| *** darrenshaw has joined #openstack-watcher | 15:24 | |
| *** dshaw has joined #openstack-watcher | 15:36 | |
| *** darrenshaw has quit IRC | 15:55 | |
| dtardivel | tpeoples: Why not do this simply to fix the bug (validate on devstack) : | 16:16 |
| dtardivel | https://www.irccloud.com/pastebin/scHNZp9H/ | 16:16 |
| tpeoples | sure, but that error message doesn't include the uuid / name that wasn't found | 16:17 |
| dtardivel | https://www.irccloud.com/pastebin/wSfTEns5/ | 16:17 |
| dtardivel | This information is on CLI side | 16:20 |
| dtardivel | When I wrote this bug, the main idea is Server Internal Error was not the good error code, because the error is on client side (so an 4XX error) | 16:21 |
| tpeoples | right, but i'm saying that IMO the error should be returning the UUID / name in the message and the way we have the Audit object fetching the audit template this is not possible | 16:22 |
| dtardivel | in this particular use case (creation of audit, we have only one parameter today) CLI has this information and maybe sould add this information in error message ? | 16:24 |
| tpeoples | seems odd that the client should have to do that when the server should just be including it IMO. for now we can just do the simple fix. it's going to probably change when we fix the audit template / audit history issue anyways | 16:26 |
| dtardivel | right | 16:27 |
| dtardivel | We have to work about Audit Template updates. How to manage existed audit ? What about periodic audit. A lot a questions ... and your idea to copy some AT parameters into Audit object is a good idea... | 16:30 |
| dtardivel | If you create the BP, I would be able to work with you and vincentfrancoise on it | 16:31 |
| tpeoples | +1 dtardivel, sounds good. won't get to it until later this week though | 16:31 |
| tpeoples | i'll get a review up for that simple fix to the bug for now | 16:31 |
| dtardivel | ok | 16:31 |
| dtardivel | Do you want I create the BP now ? | 16:34 |
| tpeoples | sure, if you'd like | 16:34 |
| dtardivel | ok | 16:34 |
| *** gabor_antal has quit IRC | 16:53 | |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Add reference de Ceilometer developer guide https://review.openstack.org/269662 | 17:07 |
| *** seanmurphy has quit IRC | 17:15 | |
| *** vincentfrancoise has quit IRC | 17:18 | |
| openstackgerrit | Vincent Mahe proposed openstack/watcher: Add diagrams to the architecture doc page https://review.openstack.org/266461 | 17:21 |
| *** vtech_ has quit IRC | 17:52 | |
| *** vmahe1 has joined #openstack-watcher | 18:13 | |
| *** dtardivel_ has joined #openstack-watcher | 18:14 | |
| *** dshaw has quit IRC | 18:22 | |
| *** thorst has quit IRC | 18:22 | |
| *** dtardivel has quit IRC | 18:22 | |
| *** vmahe has quit IRC | 18:22 | |
| *** dtardivel_ is now known as dtardivel | 18:22 | |
| *** thorst has joined #openstack-watcher | 18:29 | |
| *** vtech has joined #openstack-watcher | 18:46 | |
| *** cjvolzka has quit IRC | 18:57 | |
| *** cjvolzka has joined #openstack-watcher | 18:57 | |
| *** dtardivel has quit IRC | 18:58 | |
| *** dtardivel has joined #openstack-watcher | 18:58 | |
| *** darrenshaw has joined #openstack-watcher | 19:07 | |
| *** darrenshaw has quit IRC | 19:08 | |
| *** dtardivel has quit IRC | 19:17 | |
| *** vtech has quit IRC | 20:17 | |
| *** vtech has joined #openstack-watcher | 20:19 | |
| *** vtech has quit IRC | 20:29 | |
| *** vtech has joined #openstack-watcher | 20:30 | |
| *** vtech has quit IRC | 20:49 | |
| *** vtech has joined #openstack-watcher | 20:50 | |
| *** vtech has quit IRC | 22:05 | |
| *** vtech has joined #openstack-watcher | 22:06 | |
| *** vtech has quit IRC | 22:11 | |
| *** vtech has joined #openstack-watcher | 22:11 | |
| *** thorst has quit IRC | 22:14 | |
| *** thorst has joined #openstack-watcher | 22:15 | |
| *** vtech has quit IRC | 22:16 | |
| *** vtech_ has joined #openstack-watcher | 22:16 | |
| *** thorst has quit IRC | 22:19 | |
| *** thorst has joined #openstack-watcher | 22:40 | |
| *** thorst has quit IRC | 22:44 | |
| *** vtech_ has quit IRC | 22:44 | |
| *** cjvolzka has quit IRC | 22:57 | |
| *** mordred has quit IRC | 23:04 | |
| *** mordred has joined #openstack-watcher | 23:05 | |
| *** cjvolzka has joined #openstack-watcher | 23:32 | |
| *** cjvolzka has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!